[jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp [v2]
Alexey Pavlyutkin
duke at openjdk.org
Wed Jun 22 08:16:17 UTC 2022
> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - common\autoconf\generated-configure.sh is regenerated to add MSVS2019 recognition (I forgot to do that in https://urldefense.com/v3/__https://github.com/openjdk/jdk8u-dev/pull/33__;!!ACWV5N9M2RV99hQ!MQ8en-zp95Ab0GcQhgBtqxWn73nhxKsGF4QzcSCkJYMbwA4ZblsXd-mKU0jZ0DSlukISoS8x3HTfzdsHXks$ )
>
> Verification: 2019 build (both 32/64) now fails with
>
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
>
> error (to be fixed by backport of 8043492)
>
> Regression: 2017/2013/2012/2010 full build - ok
>
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
Alexey Pavlyutkin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
- Merge branch 'backport-8197859' of https://urldefense.com/v3/__https://github.com/apavlyutkin/jdk8u-dev__;!!ACWV5N9M2RV99hQ!MQ8en-zp95Ab0GcQhgBtqxWn73nhxKsGF4QzcSCkJYMbwA4ZblsXd-mKU0jZ0DSlukISoS8x3HTfs1jeYg0$ into backport-8197859
- fixes trailing whitespaces
- Backport b8ab854bdcf625772e965a5e476e0a9db1b91f3f
- fixes trailing whitespaces
- rebasing and resolving the merge conflict
-------------
Changes: https://git.openjdk.org/jdk8u-dev/pull/58/files
Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=58&range=01
Stats: 11664 lines in 2 files changed: 2643 ins; 513 del; 8508 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/58.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/58/head:pull/58
PR: https://git.openjdk.org/jdk8u-dev/pull/58
More information about the jdk8u-dev
mailing list