[jdk8u-dev] RFR: 8251551: Use .md filename extension for README

[Andrew John Hughes]

On Fri, 24 Jun 2022 15:07:14 GMT, George Adams <duke at openjdk.org> wrote:

> > I think we need to bring in the changes to convert to markdown first (notably [JDK-8139668](https://bugs.openjdk.org/browse/JDK-8139668) and [JDK-8176509](https://bugs.openjdk.org/browse/JDK-8176509)) before doing this.
> 
> I hadn't seen those patches before, are they not focussed on the [README-builds.html](http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html) file rather than the top-level `README` file? I'm not sure why one would block the other.
> 

8176509 also updates README and would essentially making this patch a clean backport as far as I can see. If we apply this change first as it is, we'll introduce changes unique to 8u into the README file. 8139668 is a prerequisite for 8176509.

> > Also, this patch looks to be removing the old file and adding a new one, when it should be a rename. That makes it hard to see what has actually changed.
> 
> That's the way the patch was applied from the top (see the original [commit](https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/6ed221cb9ad2e81d92dda0ef32095dda5d52cb85__;!!ACWV5N9M2RV99hQ!Mx5kWBOIf8yFiVO9fsFpB4WaIfmYjzYZyL6m5drK1ThpvGfLoLS3QjG1xlHKopYlYTFsPszF2X2Q5Rda_LRbzA$ )). I wouldn't like to change that now as it would be inconsistent with the other repos?

Ugh, I see. Well, we're already inconsistent with other repos with this patch, because the file being changed is quite different. Not having this as a rename makes it hard to see what changes have been made other than the rename.

I can accept the patch as it is in trunk and 11u if we're doing the same change on top of JDK-8176509. If we're going to do unique 8u changes, we should do the rename properly.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/75