From sgehwolf at redhat.com  Tue Mar  1 13:02:14 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Tue, 01 Mar 2022 14:02:14 +0100
Subject: Fix backport request For JDK-8193682
In-Reply-To: <4AA9CAB4-D777-4119-A282-823FD8B9FC95@in.ibm.com>
References: <4AA9CAB4-D777-4119-A282-823FD8B9FC95@in.ibm.com>
Message-ID: <2a68bca19789043e3a633e5d3d35b8e40e7203a2.camel@redhat.com>

Hi Pushkar,

On Tue, 2022-03-01 at 10:26 +0000, Pushkar N Kulkarni wrote:
> I am not sure if I am writing to the right mailing list. Pardon me if
> I am not.

jdk8u-dev (cc) is the right list.

> I want to request for a backport of
> https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f
> ?? to the JDK8.? If someone could help me with the process to raise
> backport requests, or point me to steps I could follow to help with
> the backport work, I?d appreciate it. I guess, git -> Hg backports
> are not as straightforward as the git->git ones?
> 

Currently the JDK 8u tree is frozen[1] for the git migration[2]. Once
it opens up you should be able to use the same git process to
contribute to JDK 8u than you'd be using for JDK 11u, 17u and others.

The JDK 8u wiki has some instructions about the process (see section
"Contributing"):
https://wiki.openjdk.java.net/display/jdk8u

HTH.

Thanks,
Severin

[1] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014580.html

[2] Once it's open for pushes Git tree will be here:
    https://github.com/openjdk/jdk8u-dev


From sgehwolf at openjdk.java.net  Wed Mar  2 13:55:28 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 13:55:28 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
Message-ID: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>

Bump update version of jdk8u-dev to 8u342

### Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed

### Error
&nbsp;?? The pull request body must not be empty.



### Reviewing
<details><summary>Using <code>git</code></summary>

Checkout this PR locally: \
`$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
`$ git checkout pull/1`

Update a local copy of the PR: \
`$ git checkout pull/1` \
`$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`

</details>
<details><summary>Using Skara CLI tools</summary>

Checkout this PR locally: \
`$ git pr checkout 1`

View PR using the GUI difftool: \
`$ git pr show -t 1`

</details>
<details><summary>Using diff file</summary>

Download this PR as a diff file: \
<a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>

</details>

-------------

Commit messages:
 - 8282552: Bump update version of OpenJDK: 8u342

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/1/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=1&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282552
  Stats: 32 lines in 2 files changed: 29 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/1.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From erikj at openjdk.java.net  Wed Mar  2 13:58:12 2022
From: erikj at openjdk.java.net (Erik Joelsson)
Date: Wed, 2 Mar 2022 13:58:12 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <IWn43X-w30Rh8pv0mpa7tGyQQ6YnGE8kmJ0fqajLPck=.2e165f07-a630-4d68-8326-45d92f393904@github.com>

On Wed, 2 Mar 2022 13:47:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Bump update version of jdk8u-dev to 8u342
> 
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 17:29:21 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 17:29:21 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <uGacQCRzLipMROP2mD4Vl50TOi0mN65JsPpjedoXDBs=.b1c50f87-48bb-41e1-94eb-2271af726f52@github.com>

On Wed, 2 Mar 2022 13:47:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Bump update version of jdk8u-dev to 8u342
> 
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

This is doing a lot more than bumping the update version.

I already filed a bug for the .jcheck/conf change: https://bugs.openjdk.java.net/browse/JDK-8282458 

That change should happen under that bug ID.

As to changing JDK_UPDATE_VERSION, we have not set this in the past for 8u and there was objection at the time to doing this. It certainly should have its own PR, separate from the necessary .jcheck/conf change.

-------------

Changes requested by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From sgehwolf at openjdk.java.net  Wed Mar  2 18:22:16 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 18:22:16 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <uGacQCRzLipMROP2mD4Vl50TOi0mN65JsPpjedoXDBs=.b1c50f87-48bb-41e1-94eb-2271af726f52@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
 <uGacQCRzLipMROP2mD4Vl50TOi0mN65JsPpjedoXDBs=.b1c50f87-48bb-41e1-94eb-2271af726f52@github.com>
Message-ID: <oMVBiV3QL6k0U6z8cHwtJ1COQXt0uwjxWLVRP7TlP-Q=.98a2e068-38ab-4a40-997a-8045aa8aa7f1@github.com>

On Wed, 2 Mar 2022 17:26:24 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is doing a lot more than bumping the update version.
> 
> I already filed a bug for the .jcheck/conf change: https://bugs.openjdk.java.net/browse/JDK-8282458

I didn't know that existed. Happy to withdraw the `.jcheck/conf` changes from this PR, or withdraw entirely.

> That change should happen under that bug ID.

Sure.

> As to changing JDK_UPDATE_VERSION, we have not set this in the past for 8u and there was objection at the time to doing this. It certainly should have its own PR, separate from the necessary .jcheck/conf change.

I was thinking it would be something we could be doing for 8u so that `java -version` gives the developer an idea which update cycle this would be. We'd have to do `.jcheck/conf` updates every quarter now anyway. Example:


$ java -version
openjdk version "1.8.0_342-internal"
OpenJDK Runtime Environment (build 1.8.0_342-internal-sgeholf_2022_03_02_12_07-b00)
OpenJDK 64-Bit Server VM (build 25.342-b00, mixed mode)


It still doesn't look like a real production build, which would match 11u IMO. Do you remember what the objection was?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 18:32:37 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 18:32:37 GMT
Subject: [jdk8u-dev] RFR: 8282458: Update .jcheck/conf file for 8u move to git
Message-ID: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>

This space deliberately left empty.

-------------

Commit messages:
 - 8282458: Update .jcheck/conf file for 8u move to git

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/2/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=2&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282458
  Stats: 31 lines in 1 file changed: 29 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/2.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/2/head:pull/2

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From sgehwolf at openjdk.java.net  Wed Mar  2 18:32:38 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 18:32:38 GMT
Subject: [jdk8u-dev] RFR: 8282458: Update .jcheck/conf file for 8u move to
 git
In-Reply-To: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
References: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
Message-ID: <w_Xxi10rF13E-z_NKjWZ9mcVFE1MqxZOJmdOccqXdBI=.ca32011c-21fd-4f7f-b513-6c89129d3e8e@github.com>

On Wed, 2 Mar 2022 18:18:30 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This space deliberately left empty.

LGTM

-------------

Marked as reviewed by sgehwolf (no project role).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From andrew at openjdk.java.net  Wed Mar  2 18:35:05 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 18:35:05 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
 [v2]
In-Reply-To: <oMVBiV3QL6k0U6z8cHwtJ1COQXt0uwjxWLVRP7TlP-Q=.98a2e068-38ab-4a40-997a-8045aa8aa7f1@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
 <uGacQCRzLipMROP2mD4Vl50TOi0mN65JsPpjedoXDBs=.b1c50f87-48bb-41e1-94eb-2271af726f52@github.com>
 <oMVBiV3QL6k0U6z8cHwtJ1COQXt0uwjxWLVRP7TlP-Q=.98a2e068-38ab-4a40-997a-8045aa8aa7f1@github.com>
Message-ID: <6cJd1eBQ71UVSZ4iO-YJlzMg9vA8Mbv7a1aMpQE3BMg=.2b496af1-aa4b-4290-92c2-1f0ff65a7fd9@github.com>

On Wed, 2 Mar 2022 18:18:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > This is doing a lot more than bumping the update version.
> > I already filed a bug for the .jcheck/conf change: https://bugs.openjdk.java.net/browse/JDK-8282458
> 
> I didn't know that existed. Happy to withdraw the `.jcheck/conf` changes from this PR, or withdraw entirely.

Thanks. No worries, I did link it to the SKARA bug but I guess you missed it. I was going to try and move further with this on Monday but the transition wasn't ready in time.

No objection to the content - i just copied your changes to the other PR, after comparing with 11u - I just wanted it to be clearer what change was being made. It took me a while to find the change in 11u because it was hidden in one of these 'bump' changes.

> 
> > That change should happen under that bug ID.
> 
> Sure.
> 
> > As to changing JDK_UPDATE_VERSION, we have not set this in the past for 8u and there was objection at the time to doing this. It certainly should have its own PR, separate from the necessary .jcheck/conf change.
> 
> I was thinking it would be something we could be doing for 8u so that `java -version` gives the developer an idea which update cycle this would be. We'd have to do `.jcheck/conf` updates every quarter now anyway. Example:
> 
> ```
> $ java -version
> openjdk version "1.8.0_342-internal"
> OpenJDK Runtime Environment (build 1.8.0_342-internal-sgeholf_2022_03_02_12_07-b00)
> OpenJDK 64-Bit Server VM (build 25.342-b00, mixed mode)
> ```
> 
> It still doesn't look like a real production build, which would match 11u IMO. Do you remember what the objection was?

Yeah, I have no objection. I originally proposed even doing the build number, but that was some pushback from Azul that I never really understood. I'll dig out the original thread.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 18:35:06 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 18:35:06 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <syZb86ujzoEOC8fuZxm5jzPU8_iE775kqTK_Vfn3YuM=.9724bc6e-fea5-477c-af16-c3caa0cf2b1c@github.com>

On Wed, 2 Mar 2022 13:47:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Bump update version of jdk8u-dev to 8u342
> 
> ------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

Thanks. Just waiting on a jdk8u-fix-yes, I think.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From sgehwolf at openjdk.java.net  Wed Mar  2 18:35:06 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 18:35:06 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <faGB_0UAuJ_r4wia6SLVExs5ai6oESKmwNPLfDrPB-c=.3991f87b-5227-4175-9991-94f9d1f04b04@github.com>

On Wed, 2 Mar 2022 13:47:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Bump update version of jdk8u-dev to 8u342
> 
> ------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

I'll wait until #2 is in and remove `.jcheck/conf` changes.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From sgehwolf at openjdk.java.net  Wed Mar  2 18:35:04 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 18:35:04 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
 [v2]
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <bf0xCPBmIJ_Rbi7BYGAmSVQ6Mx-Qr00DFlgY0M0Y8Nk=.04564244-2b6f-48ec-86e7-e6007f934845@github.com>

> Bump update version of jdk8u-dev to 8u342
> 
> ------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8282552: Bump update version of OpenJDK: 8u342

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/1/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/1/files/7d9e3b51..feaf07b6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=1&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=1&range=00-01

  Stats: 31 lines in 1 file changed: 0 ins; 29 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/1.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 18:45:12 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 18:45:12 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
 [v2]
In-Reply-To: <bf0xCPBmIJ_Rbi7BYGAmSVQ6Mx-Qr00DFlgY0M0Y8Nk=.04564244-2b6f-48ec-86e7-e6007f934845@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
 <bf0xCPBmIJ_Rbi7BYGAmSVQ6Mx-Qr00DFlgY0M0Y8Nk=.04564244-2b6f-48ec-86e7-e6007f934845@github.com>
Message-ID: <j2M7A838H9M6-2W4XsZWsUOAo94R_OcbvzR8OMbM2-0=.40181174-7788-4c81-9050-315036985b02@github.com>

On Wed, 2 Mar 2022 18:35:04 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Bump update version of jdk8u-dev to 8u342
>> 
>> ------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> 
>> 
>> ### Reviewing
>> <details><summary>Using <code>git</code></summary>
>> 
>> Checkout this PR locally: \
>> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
>> `$ git checkout pull/1`
>> 
>> Update a local copy of the PR: \
>> `$ git checkout pull/1` \
>> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
>> 
>> </details>
>> <details><summary>Using Skara CLI tools</summary>
>> 
>> Checkout this PR locally: \
>> `$ git pr checkout 1`
>> 
>> View PR using the GUI difftool: \
>> `$ git pr show -t 1`
>> 
>> </details>
>> <details><summary>Using diff file</summary>
>> 
>> Download this PR as a diff file: \
>> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
>> 
>> </details>
>
> Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8282552: Bump update version of OpenJDK: 8u342

Marked as reviewed by andrew (Reviewer).

This is the thread I was referring to: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-June/009598.html

Re-reading it, I think Gil's main objection was to change the default to "fcs" with a release. I don't see any objection to setting the update version and there seems to have been none to this on 11u.

They also seem to be doing the same bump in 13u - https://github.com/openjdk/jdk13u-dev/commit/9e30b3d316dcbbb1e31fafac6d622cba77a7629f - so I can't see an objection to this. I was probably going too far with my change (though I still think it was the right thing)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 18:46:07 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 18:46:07 GMT
Subject: [jdk8u-dev] RFR: 8282458: Update .jcheck/conf file for 8u move to
 git
In-Reply-To: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
References: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
Message-ID: <8q6FYchpqKDQfJUbpmmv-kIzZhzVLVpKqh284R5OeZo=.74074eb0-9614-4ca6-aef2-ab3ef5956fa6@github.com>

On Wed, 2 Mar 2022 18:18:30 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This space deliberately left empty.

Just waiting on jdk8u-fix-yes before push.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From sgehwolf at openjdk.java.net  Wed Mar  2 19:05:18 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 19:05:18 GMT
Subject: [jdk8u-dev] RFR: 8282458: Update .jcheck/conf file for 8u move to
 git
In-Reply-To: <8q6FYchpqKDQfJUbpmmv-kIzZhzVLVpKqh284R5OeZo=.74074eb0-9614-4ca6-aef2-ab3ef5956fa6@github.com>
References: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
 <8q6FYchpqKDQfJUbpmmv-kIzZhzVLVpKqh284R5OeZo=.74074eb0-9614-4ca6-aef2-ab3ef5956fa6@github.com>
Message-ID: <_CCF5mxyF7pgTOMW_Mh9rFUz8QrKqGdB_GRmFRh8AJE=.5abd605d-0910-4c8a-b210-9af406f4f7f3@github.com>

On Wed, 2 Mar 2022 18:43:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Just waiting on jdk8u-fix-yes before push.

I've approved. Looking forward to see the bots resolve the bugs correctly once it's integrated :)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From andrew at openjdk.java.net  Wed Mar  2 19:14:19 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 19:14:19 GMT
Subject: [jdk8u-dev] Integrated: 8282458: Update .jcheck/conf file for 8u move
 to git
In-Reply-To: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
References: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
Message-ID: <KR__6AQnETjSoUERB4wqNSS6TeIQIH1v7Q76riCVamE=.6ecb28e7-fbe2-4ea1-8774-12df2785d7aa@github.com>

On Wed, 2 Mar 2022 18:18:30 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This space deliberately left empty.

This pull request has now been integrated.

Changeset: 4a19c1a6
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/4a19c1a65107202800bf8df51684f7255d6ef027
Stats:     31 lines in 1 file changed: 29 ins; 0 del; 2 mod

8282458: Update .jcheck/conf file for 8u move to git

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From sgehwolf at openjdk.java.net  Wed Mar  2 19:26:47 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 2 Mar 2022 19:26:47 GMT
Subject: [jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342
 [v3]
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <hwf1K-mJvMHyI-vWPcIom8fom9NwDQF24-eFCrfN7dE=.cb4364c5-c74c-4755-a4a5-da266d8c3b28@github.com>

> Bump update version of jdk8u-dev to 8u342
> 
> ------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8u342-git-version-bump
 - 8282552: Bump update version of OpenJDK: 8u342

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/1/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/1/files/feaf07b6..af936812

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=1&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=1&range=01-02

  Stats: 31 lines in 1 file changed: 29 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/1.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Wed Mar  2 20:03:11 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 2 Mar 2022 20:03:11 GMT
Subject: [jdk8u-dev] RFR: 8282458: Update .jcheck/conf file for 8u move to
 git
In-Reply-To: <_CCF5mxyF7pgTOMW_Mh9rFUz8QrKqGdB_GRmFRh8AJE=.5abd605d-0910-4c8a-b210-9af406f4f7f3@github.com>
References: <3hm1daiZR4CWPeSdAePp8KSQ0jChsMGbNaeQiMrCEI8=.e389afb0-0806-493f-a44b-2cc32082c245@github.com>
 <8q6FYchpqKDQfJUbpmmv-kIzZhzVLVpKqh284R5OeZo=.74074eb0-9614-4ca6-aef2-ab3ef5956fa6@github.com>
 <_CCF5mxyF7pgTOMW_Mh9rFUz8QrKqGdB_GRmFRh8AJE=.5abd605d-0910-4c8a-b210-9af406f4f7f3@github.com>
Message-ID: <Uo9ILcEInTqIYmp93GYRxIsBLaayq0gxtKoXP3DVg0I=.495a0581-ee9a-4188-a80b-9f0e3f1c87ec@github.com>

On Wed, 2 Mar 2022 19:01:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > Just waiting on jdk8u-fix-yes before push.
> 
> I've approved. Looking forward to see the bots resolve the bugs correctly once it's integrated :)

And it worked! :)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/2

From sgehwolf at openjdk.java.net  Thu Mar  3 09:47:18 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Thu, 3 Mar 2022 09:47:18 GMT
Subject: [jdk8u-dev] Integrated: 8282552: Bump update version of OpenJDK: 8u342
In-Reply-To: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
References: <Ha__Z_fCmp82c3QNclTwpoFeztj8FC6oG6xZ8xD6O4c=.acf90c55-e6fd-4578-90ae-53e3403fa8f2@github.com>
Message-ID: <GmaDXwOnlpTyl6vDx82t3TXj5PFmoAlsLisvPCgSDBE=.8796320d-a1c5-41f2-9172-c6155017b712@github.com>

On Wed, 2 Mar 2022 13:47:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Bump update version of jdk8u-dev to 8u342
> 
> ------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
> `$ git checkout pull/1`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1` \
> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
> 
> </details>

This pull request has now been integrated.

Changeset: 6f01b534
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/6f01b5341956285a9f246a9228586d8c000603dc
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8282552: Bump update version of OpenJDK: 8u342

Reviewed-by: erikj, andrew

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1

From andrew at openjdk.java.net  Sat Mar  5 17:11:33 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 5 Mar 2022 17:11:33 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit testing
 using GitHub Actions
Message-ID: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>

Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44

Changes so far:
* make/autoconf/version-numbers -> common/autoconf/version-numbers
* Fix version variables (JDK_MAJOR_VERSION, JDK_MINOR_VERSION and JDK_MICRO_VERSION in 8u)
* Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)

-------------

Commit messages:
 - Backport 1faefed218051c324bdb5c7c10369050d6c9dd44

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253424
  Stats: 1454 lines in 2 files changed: 1454 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar  5 17:27:36 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 5 Mar 2022 17:27:36 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v2]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <w6pU1CBfrGP0MHKKdzJoGVnSdP241XvDnVZRrxBF7r0=.9be8cfa4-09ce-42a0-9d89-dcd2afbcad34@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Replace --with-version-opt with --with-user-release-suffix, drop --enable-jtreg-failure-handler and move make targets to make command

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/61cd9167..39c5d9ad

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=00-01

  Stats: 19 lines in 1 file changed: 0 ins; 9 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar  5 17:36:47 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 5 Mar 2022 17:36:47 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v3]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <3XljLjDQz_haOyNhTyzlQl-y9hz2AUxwVMBV2tt_cQE=.d59db9be-ee0e-484c-81d0-97a8b41aebde@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Replace --with-version-build with --with-build-number

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/39c5d9ad..13d94420

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=01-02

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar  5 18:48:40 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 5 Mar 2022 18:48:40 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v4]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <utd4fBOHeAR0p5DSOQ_l7lCxP2swxsB8mBYPg6BX-D4=.a4fbe810-4a11-4102-aa37-a1e951e139ef@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Replace product-bundles and test-bundles targets with images

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/13d94420..e0bf82c0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar  5 20:30:46 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 5 Mar 2022 20:30:46 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v5]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <5cYwqrtajR7m8NFlDMmmBLUGRxoM50A7LXxqOnlFsS4=.6e35959e-dff1-49ba-a551-9e54e583e8dd@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Disable tests, remove unsupported --with-msvc-toolset-version, add missing dependency for x86 build, turn on verbose logging for x64

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/e0bf82c0..12fe9496

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=03-04

  Stats: 11 lines in 1 file changed: 4 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sun Mar  6 01:45:42 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sun, 6 Mar 2022 01:45:42 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v6]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <N366dXhLz94PUQ2GPKV3OmHZIBTBVDeRcYQJupDsq08=.065dd008-ace6-4414-acb7-3ee966062919@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Switch Linux builds to use bundled zlib

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/12fe9496..f1aa163d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=04-05

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Mon Mar  7 01:29:43 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 7 Mar 2022 01:29:43 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v7]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <u4sAE4Zoptyy5NX1Fep0v2EesQEmrZivLe6nSQCWOL0=.6f8a8248-2bff-4acd-a8ea-f0e3cb679e2f@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Disable additional Linux builds which depend on first Linux build bundle

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/f1aa163d..ad22b985

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=05-06

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Mon Mar  7 02:07:43 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 7 Mar 2022 02:07:43 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Revert "Disable additional Linux builds which depend on first Linux build bundle"
  
  This reverts commit ad22b985262aa5aa1c6e01e6e061d57a045e48d4.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/ad22b985..c5015f57

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From sgehwolf at openjdk.java.net  Mon Mar  7 09:06:08 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Mon, 7 Mar 2022 09:06:08 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
Message-ID: <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>

On Mon, 7 Mar 2022 02:07:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Disable additional Linux builds which depend on first Linux build bundle"
>   
>   This reverts commit ad22b985262aa5aa1c6e01e6e061d57a045e48d4.

@gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Mon Mar  7 13:42:14 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 7 Mar 2022 13:42:14 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
Message-ID: <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>

On Mon, 7 Mar 2022 09:03:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> @gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.

Done. Sorry, I didn't realise it wasn't spamming anyone.

I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From sgehwolf at openjdk.java.net  Tue Mar  8 10:08:09 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Tue, 8 Mar 2022 10:08:09 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
Message-ID: <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>

On Mon, 7 Mar 2022 13:38:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.

Maybe @akashche  or @stooke can help with the Windows GHA builds?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From akasko at openjdk.java.net  Tue Mar  8 11:02:05 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Tue, 8 Mar 2022 11:02:05 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
 <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
Message-ID: <It8ZC6kaIK-80TLQ94MnzygL795tja6_MMEPjbmjdR0=.eef4d6df-bb50-4d7f-8987-55bb56f2b86e@github.com>

On Tue, 8 Mar 2022 10:05:24 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> @gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.
>> 
>> Done. Sorry, I didn't realise it wasn't spamming anyone.
>> 
>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
>
>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
> 
> Maybe @akashche  or @stooke can help with the Windows GHA builds?

@jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From duke at openjdk.java.net  Wed Mar  9 13:52:14 2022
From: duke at openjdk.java.net (George Adams)
Date: Wed, 9 Mar 2022 13:52:14 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <It8ZC6kaIK-80TLQ94MnzygL795tja6_MMEPjbmjdR0=.eef4d6df-bb50-4d7f-8987-55bb56f2b86e@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
 <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
 <It8ZC6kaIK-80TLQ94MnzygL795tja6_MMEPjbmjdR0=.eef4d6df-bb50-4d7f-8987-55bb56f2b86e@github.com>
Message-ID: <RXrLVtNlIbWO7BUOdIyiQkFh-z1CFjaFiILf_vTxcK0=.a5625915-a159-4b5c-977a-8b870107e801@github.com>

On Tue, 8 Mar 2022 10:59:00 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
>> 
>> Maybe @akashche  or @stooke can help with the Windows GHA builds?
>
> @jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

> Maybe @akashche or @stooke can help with the Windows GHA builds?

I've played around with trying to get JDK8u to compile on Windows in GH actions before, I think it mainly boils down to the version of Visual Studio on the executors. At Eclipse Adoptium we use Visual Studio 2013 but there is no easy way to install that onto the environment anymore (we used to use chocolatey but that package broke a while back). Happy to provide any help if required

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From gnu.andrew at redhat.com  Wed Mar  9 16:08:20 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 9 Mar 2022 16:08:20 +0000
Subject: [IMPORTANT] jdk8u-dev OPEN for development on GitHub
Message-ID: <YijQ9IhnZpxnvD7c@hex.discworld.ac.uk>

Hi all,

You should now be able to submit pull requests on GitHub for
inclusion in 8u-dev and the forthcoming July update, 8u342.

The 8u-dev GitHub repository is:

https://github.com/openjdk/jdk8u-dev

I have updated the process description on the wiki:

https://wiki.openjdk.java.net/display/jdk8u/Main

which now mostly refers you to the SKARA documentation common to all
JDK versions. Please let me know if anything is hard to follow or any
errant Mercurial references remain, apart from the monojdk8u
repository which will remain until the 8u332 release in April.

Testing via GitHub actions is still a work-in-progress. I had hoped to
have this ready for 8u-dev being re-opened, but there are still some
issues on Windows; see https://github.com/openjdk/jdk8u-dev/pull/3 In
the meantime, please be extra careful before pushing patches and make
sure the patch has built successfully on those platforms you have
access to.  If anyone can help with the Windows problems, please
join the discussion on the pull request.

Any critical fixes for the April 8u332 release follow the same process
as the last release; jdk8u-critical-yes is required before a push to
the Mercurial monojdk8u repository.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From andrew at openjdk.java.net  Wed Mar  9 16:16:11 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 9 Mar 2022 16:16:11 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <It8ZC6kaIK-80TLQ94MnzygL795tja6_MMEPjbmjdR0=.eef4d6df-bb50-4d7f-8987-55bb56f2b86e@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
 <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
 <It8ZC6kaIK-80TLQ94MnzygL795tja6_MMEPjbmjdR0=.eef4d6df-bb50-4d7f-8987-55bb56f2b86e@github.com>
Message-ID: <AxV4VMgeFFvckBFMrltcm2PeqItPuyQgFE31VamgxqM=.32df8c8d-cbb9-47c6-acd8-9782b2bc0a07@github.com>

On Tue, 8 Mar 2022 10:59:00 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
>> 
>> Maybe @akashche  or @stooke can help with the Windows GHA builds?
>
> @jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

> > Maybe @akashche or @stooke can help with the Windows GHA builds?
> 
> I've played around with trying to get JDK8u to compile on Windows in GH actions before, I think it mainly boils down to the version of Visual Studio on the executors. At Eclipse Adoptium we use Visual Studio 2013 but there is no easy way to install that onto the environment anymore (we used to use chocolatey but that package broke a while back). Happy to provide any help if required

Any help is very much welcome. I've never built on Windows before, so I have no idea of the requirements and issues there. What we have at present is pretty much what is in 11u-dev, other than I removed the `--with-msvc-toolset-version` option which 8u doesn't support. Maybe we have to either look into getting 8u to support newer versions of Windows or forego automated Windows testing. The former is risky, but preferable to the latter.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Wed Mar  9 16:24:14 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 9 Mar 2022 16:24:14 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
 <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
Message-ID: <YFKxy0cMELG4G-rOeARL1HGv31GOudAWHGNaH2Nsmqg=.bea47193-93b5-4776-9bbb-e04c9e2118a9@github.com>

On Tue, 8 Mar 2022 10:05:24 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> @gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.
>> 
>> Done. Sorry, I didn't realise it wasn't spamming anyone.
>> 
>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
>
>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
> 
> Maybe @akashche  or @stooke can help with the Windows GHA builds?

> @jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

It's largely just a collection of build scripts with interdependencies. The main part for you to look at is under `windows_x64_build` in https://github.com/openjdk/jdk8u-dev/pull/3/files#diff-d9aafa5b5fb68a30f87fd41d7f84a7087fd33b0b07e406fd1ba4b3e66a6b9683R756 and the `configure` failure in https://github.com/gnu-andrew/jdk8u-dev/runs/5442291679?check_suite_focus=true It may be that this is already familiar to you from your own builds.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Wed Mar  9 16:57:49 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 9 Mar 2022 16:57:49 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v9]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <k-b8qCojb-c-wetcpuwGbN3CI1CoZdcL0NoLUCgB1jI=.cccf3d44-9a19-4026-b2a8-815800e46f47@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Try permissions fix for Windows suggested by Simon Tooke in https://github.com/AdoptOpenJDK/openjdk8-upstream-binaries/pull/18/files

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/c5015f57..7d26551e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=07-08

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Wed Mar  9 18:10:43 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 9 Mar 2022 18:10:43 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Add missing semi-colon

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/7d26551e..ee7ab5ae

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=08-09

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From duke at openjdk.java.net  Wed Mar  9 18:15:18 2022
From: duke at openjdk.java.net (George Adams)
Date: Wed, 9 Mar 2022 18:15:18 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
Message-ID: <VE7zzBxSc1ntavllucy2uZjnu46M5m6MQ5xKQ1RBeik=.75ff46c9-a64d-48c4-bb76-13054761e290@github.com>

On Wed, 9 Mar 2022 18:10:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing semi-colon

make/conf/test-dependencies line 32:

> 30: JTREG_BUILD=b01
> 31: 
> 32: WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-11_windows-x64_bin.zip

Suggestion:

WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-8_windows-x64_bin.zip

make/conf/test-dependencies line 36:

> 34: WINDOWS_X64_BOOT_JDK_SHA256=c9e06afb5df850e90a4da9da31c2edf10bd6da9962c4b253e91b41237f8fb2fb
> 35: 
> 36: MACOS_X64_BOOT_JDK_FILENAME=openjdk-11_osx-x64_bin.tar.gz

Suggestion:

MACOS_X64_BOOT_JDK_FILENAME=openjdk-8_osx-x64_bin.tar.gz

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From akasko at openjdk.java.net  Wed Mar  9 21:17:32 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Wed, 9 Mar 2022 21:17:32 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in jaxp
Message-ID: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>

Please review a backport of a JAXP cleanup.

Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.

Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.

This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.

All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).

Testing:

 - [x] jtreg:javax/xml/jaxp
 - [x] jck:api/javax_xml

-------------

Commit messages:
 - 8129572: Cleanup usage of getResourceAsStream in jaxp

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/4/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8129572
  Stats: 239 lines in 13 files changed: 0 ins; 229 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/4/head:pull/4

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From akasko at openjdk.java.net  Wed Mar  9 21:29:13 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Wed, 9 Mar 2022 21:29:13 GMT
Subject: [jdk8u-dev] RFR: 8132256: jaxp: Investigate removal of
 com/sun/org/apache/bcel/internal/util/ClassPath.java
Message-ID: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>

Please review a backport of a JAXP cleanup.

Original commit [dcdbd67e6408](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/dcdbd67e6408) in jdk9.

Commit [6e586e8](https://github.com/openjdk/jdk11u-dev/commit/6e586e8a3b8807652218c4caf97ef501f42d7f36) in jdk11u-dev.

This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.

Patch does not apply cleanly because in jdk9 ClassPath.java (that is deleted in this backport) was changed in [JDK-8049367](https://bugs.openjdk.java.net/browse/JDK-8049367) that is not in 8u.

Testing:

 - [x] jtreg:javax/xml/jaxp
 - [x] jck:api/javax_xml

-------------

Commit messages:
 - 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/5/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=5&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8132256
  Stats: 415 lines in 3 files changed: 1 ins; 410 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/5.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/5/head:pull/5

PR: https://git.openjdk.java.net/jdk8u-dev/pull/5

From duke at openjdk.java.net  Wed Mar  9 23:47:46 2022
From: duke at openjdk.java.net (zzambers)
Date: Wed, 9 Mar 2022 23:47:46 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
Message-ID: <DfDa9hsP2Jpn2AXebPHqHjrRLI47_6WDFhHqnpdp4ws=.b2515990-7d01-439f-be9f-5d5da6d95ed3@github.com>

On Wed, 9 Mar 2022 18:10:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing semi-colon

I was doing some experiments with windows (32-bit) builds of jdk8 in github actions in the past using vs2010express.  (Visual Studio 2010 is mentioned for windows in README-builds.html) When I tried my old code, and have found, that it no longer works (simple steps to install vs2010express no longer work, caused by dead MS links [1]). However, after some experimentation, I was able to install vs2010express from iso (from webarchive) and now it works again.

My basic (cleaned up) github workflow which does 32-bit build of openjdk8 using vs2010express can be found here. [2]
(feel free to use any of that code)

[1] https://github.community/t/how-to-use-vc100-for-msbuild/16623/2
[2] https://github.com/zzambers/test-jdk-builder/blob/build-ojdk8-win/.github/workflows/build-workflow.yaml

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From duke at openjdk.java.net  Thu Mar 10 00:09:42 2022
From: duke at openjdk.java.net (zzambers)
Date: Thu, 10 Mar 2022 00:09:42 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
Message-ID: <Gx6MN-vhqn_MVgCh2f9lgZbyIgV3Ws4wZHND0Kp21Yc=.222445e9-1269-4fce-9778-52a37e5beaf8@github.com>

On Wed, 9 Mar 2022 18:10:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing semi-colon

But there is one problem, which needs to be workarounded in my setup (see that ugly sed [3] in my workflow), to get through configure, as otherwise it dies with this error (seems like problem with path conversion somewhere, but I don't remember exactly, as this is from my old code):


...
checking if fixpath can be created... no
Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.30319.01 for 80x86
Copyright (C) Microsoft Corporation.  All rights reserved.

fixpath.c
Microsoft (R) Incremental Linker Version 10.00.30319.01
Copyright (C) Microsoft Corporation.  All rights reserved.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From shade at openjdk.java.net  Thu Mar 10 09:10:46 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Thu, 10 Mar 2022 09:10:46 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v8]
In-Reply-To: <YFKxy0cMELG4G-rOeARL1HGv31GOudAWHGNaH2Nsmqg=.bea47193-93b5-4776-9bbb-e04c9e2118a9@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <fQRH5FN4DmU28VeLQkWEr3UzQqsEfX31jYP2F6qXPcc=.0c3ea7cc-6c3b-44ee-a61d-4c324661f1ad@github.com>
 <2PXDyPSiztP8N4eehr4EemP0tqU1qfBn3rjOameyABM=.0fca8419-7d82-4652-ace6-83bb85e59d6b@github.com>
 <7U72MC62wmmqw-8r4aNN42aLrgLE63M2_Jzov_bjNLc=.8b7e8a3b-56ae-4a00-b3fe-8581e9e309ce@github.com>
 <Dz_xFsx5PaN2BDAMsVMorMG_2cWr0rZfiY24ODaVeQY=.3b1de75c-5190-4167-8b5c-5789f4f0632d@github.com>
 <YFKxy0cMELG4G-rOeARL1HGv31GOudAWHGNaH2Nsmqg=.bea47193-93b5-4776-9bbb-e04c9e2118a9@github.com>
Message-ID: <mQh4ar4Xh6X0j4Pemk4Iycac9DuV-jYzR2KJNDXyCyA=.03acdb0a-9182-40bc-b321-23ef64a87234@github.com>

On Wed, 9 Mar 2022 16:21:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.
>> 
>> Maybe @akashche  or @stooke can help with the Windows GHA builds?
>
>> @jerboaa , I don't have experience with GitHub Actions, will look into them and report back.
> 
> It's largely just a collection of build scripts with interdependencies. The main part for you to look at is under `windows_x64_build` in https://github.com/openjdk/jdk8u-dev/pull/3/files#diff-d9aafa5b5fb68a30f87fd41d7f84a7087fd33b0b07e406fd1ba4b3e66a6b9683R756 and the `configure` failure in https://github.com/gnu-andrew/jdk8u-dev/runs/5442291679?check_suite_focus=true It may be that this is already familiar to you from your own builds.

@gnu-andrew -- please consider adding [JDK-8282225](https://bugs.openjdk.java.net/browse/JDK-8282225) to this batch as well.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From sgehwolf at openjdk.java.net  Thu Mar 10 09:36:50 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Thu, 10 Mar 2022 09:36:50 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
Message-ID: <vs0O4wwt2Q-NQ_LhH1gVmplu7wkgUavkGDc6LK8S1c0=.2905713c-c5d3-4a33-9de8-59f89f7397f3@github.com>

On Wed, 9 Mar 2022 18:10:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing semi-colon

> Pre-submit tests - Linux additional - Build Failing after 24s ? 8/8 failed 

Should we disable those cross compile builds for the initial integration?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Thu Mar 10 18:27:35 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 10 Mar 2022 18:27:35 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v11]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <yCWpq3E10nIc9Ft7lfELQKLhjY7DUUXjtkXYdsDr84E=.3decd972-e3fc-4c27-8ec9-ca045a5dd878@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Fix name of downloaded files and try again to disable additional HotSpot builds

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/ee7ab5ae..f87dd745

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=09-10

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Thu Mar 10 18:27:36 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 10 Mar 2022 18:27:36 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <vs0O4wwt2Q-NQ_LhH1gVmplu7wkgUavkGDc6LK8S1c0=.2905713c-c5d3-4a33-9de8-59f89f7397f3@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
 <vs0O4wwt2Q-NQ_LhH1gVmplu7wkgUavkGDc6LK8S1c0=.2905713c-c5d3-4a33-9de8-59f89f7397f3@github.com>
Message-ID: <PuW8e5KRre0SJbAm76rdW3_D6cMrAkXmHmZ5fDY3sw8=.4afe3dd4-9dc3-4480-b510-32450a0b7b3f@github.com>

On Thu, 10 Mar 2022 09:33:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > Pre-submit tests - Linux additional - Build Failing after 24s ? 8/8 failed
> 
> Should we disable those cross compile builds for the initial integration?

Yes, I actually already tried to do that but it's not easy to do in a non-destructive way. I'll try again with this next commit.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Thu Mar 10 18:27:36 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 10 Mar 2022 18:27:36 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <PuW8e5KRre0SJbAm76rdW3_D6cMrAkXmHmZ5fDY3sw8=.4afe3dd4-9dc3-4480-b510-32450a0b7b3f@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
 <vs0O4wwt2Q-NQ_LhH1gVmplu7wkgUavkGDc6LK8S1c0=.2905713c-c5d3-4a33-9de8-59f89f7397f3@github.com>
 <PuW8e5KRre0SJbAm76rdW3_D6cMrAkXmHmZ5fDY3sw8=.4afe3dd4-9dc3-4480-b510-32450a0b7b3f@github.com>
Message-ID: <XLN0B8BzbcCWLJGjiPimDe4R_RNmvmDQgPjlf3rCvwA=.444c95e7-ef69-4289-bd5c-c3bee1f88d77@github.com>

On Thu, 10 Mar 2022 18:21:31 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > > Pre-submit tests - Linux additional - Build Failing after 24s ? 8/8 failed
> > 
> > 
> > Should we disable those cross compile builds for the initial integration?
> 
> Yes, I actually already tried to do that but it's not easy to do in a non-destructive way. I'll try again with this next commit.

For the record, the issue is the same as with the tests; bundles. It needs the host JDK built by the x86_64 build for the cross-compiled builds, and that is cached and then retrieved via a bundle. I'll open a separate PR to backport bundles after this. That should fix additional HS builds, but tests probably need more backporting work.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Thu Mar 10 18:27:36 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 10 Mar 2022 18:27:36 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <XLN0B8BzbcCWLJGjiPimDe4R_RNmvmDQgPjlf3rCvwA=.444c95e7-ef69-4289-bd5c-c3bee1f88d77@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
 <vs0O4wwt2Q-NQ_LhH1gVmplu7wkgUavkGDc6LK8S1c0=.2905713c-c5d3-4a33-9de8-59f89f7397f3@github.com>
 <PuW8e5KRre0SJbAm76rdW3_D6cMrAkXmHmZ5fDY3sw8=.4afe3dd4-9dc3-4480-b510-32450a0b7b3f@github.com>
 <XLN0B8BzbcCWLJGjiPimDe4R_RNmvmDQgPjlf3rCvwA=.444c95e7-ef69-4289-bd5c-c3bee1f88d77@github.com>
Message-ID: <Imqa0zPBZR-7bTKlMFQQxQM4sPBs-WHwng4lxogr9Uo=.2a1cc448-1be3-4281-b1e3-9ef0f398ab31@github.com>

On Thu, 10 Mar 2022 18:23:04 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> > Pre-submit tests - Linux additional - Build Failing after 24s ? 8/8 failed
>>> 
>>> Should we disable those cross compile builds for the initial integration?
>> 
>> Yes, I actually already tried to do that but it's not easy to do in a non-destructive way. I'll try again with this next commit.
>
>> > > Pre-submit tests - Linux additional - Build Failing after 24s ? 8/8 failed
>> > 
>> > 
>> > Should we disable those cross compile builds for the initial integration?
>> 
>> Yes, I actually already tried to do that but it's not easy to do in a non-destructive way. I'll try again with this next commit.
> 
> For the record, the issue is the same as with the tests; bundles. It needs the host JDK built by the x86_64 build for the cross-compiled builds, and that is cached and then retrieved via a bundle. I'll open a separate PR to backport bundles after this. That should fix additional HS builds, but tests probably need more backporting work.

> @gnu-andrew -- please consider adding [JDK-8282225](https://bugs.openjdk.java.net/browse/JDK-8282225) to this batch as well.

Can do. I was actually wondering how much build noise all my pushes was creating, so that looks like it'll ease things a bit.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Thu Mar 10 18:27:37 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 10 Mar 2022 18:27:37 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v10]
In-Reply-To: <VE7zzBxSc1ntavllucy2uZjnu46M5m6MQ5xKQ1RBeik=.75ff46c9-a64d-48c4-bb76-13054761e290@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <RDgUpqn-PxcnWIedK92M808GN_265WF_Xc9x9J1ODto=.40f0248d-16f3-49cb-a488-2c8d39960237@github.com>
 <VE7zzBxSc1ntavllucy2uZjnu46M5m6MQ5xKQ1RBeik=.75ff46c9-a64d-48c4-bb76-13054761e290@github.com>
Message-ID: <SGPMNEg5K_kzko4dqNwwD_GrLqjQE30lAzDsBzIixpo=.ea762845-1382-4fa5-b5d4-c10d7a07415c@github.com>

On Wed, 9 Mar 2022 18:12:15 GMT, George Adams <duke at openjdk.java.net> wrote:

>> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing semi-colon
>
> make/conf/test-dependencies line 32:
> 
>> 30: JTREG_BUILD=b01
>> 31: 
>> 32: WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-11_windows-x64_bin.zip
> 
> Suggestion:
> 
> WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-8_windows-x64_bin.zip

Thanks for catching this. It's only the name for the downloaded file, but it's better that the label matches what's in the box :)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From akasko at openjdk.java.net  Sun Mar 13 19:51:51 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Sun, 13 Mar 2022 19:51:51 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v11]
In-Reply-To: <yCWpq3E10nIc9Ft7lfELQKLhjY7DUUXjtkXYdsDr84E=.3decd972-e3fc-4c27-8ec9-ca045a5dd878@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
 <yCWpq3E10nIc9Ft7lfELQKLhjY7DUUXjtkXYdsDr84E=.3decd972-e3fc-4c27-8ec9-ca045a5dd878@github.com>
Message-ID: <OCxKIDcRTTdvmtcq4zFRV7M7ET_41xdf4qvIZ4p40aw=.c574e16e-5f7e-4fdf-8a48-ab0be1dc1bb8@github.com>

On Thu, 10 Mar 2022 18:27:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
>> 
>> Changes so far:
>> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
>> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
>> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
>> * Replace `--with-version-opt` with `--with-user-release-suffix`
>> * Drop `--enable-jtreg-failure-handler` (unsupported)
>> * Move make targets to make invocation (`--with-default-make-target` not supported)
>> * Drop `--with-msvc-toolset-version`
>> * Disable tests as we don't currently have the bundles required to support them
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix name of downloaded files and try again to disable additional HotSpot builds

Windows build setup with VS2017 [has worked for me](https://github.com/akashche/jdk8u-dev/actions/runs/1977187284): [modified submit.yml](https://github.com/akashche/jdk8u-dev/blob/gh-actions-win/.github/workflows/submit.yml), [additional file for a FreeType build](https://github.com/akashche/jdk8u-dev/blob/gh-actions-win/.github/workflows/freetype.vcxproj).

There is one questionable bit, when VS installer bootstrap launcher is being taken from [my msvs_2017_installer_bootstrap repo](https://github.com/akashche/msvs_2017_installer_bootstrap). This launcher is publicly available from MSFT ([download link](https://visualstudio.microsoft.com/thank-you-downloading-visual-studio/?sku=Community&rel=15)) but I was unable to automate its fetching easily and have uploaded it to this msvs_2017_installer_bootstrap personal repo.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From duke at openjdk.java.net  Mon Mar 14 16:53:24 2022
From: duke at openjdk.java.net (zzambers)
Date: Mon, 14 Mar 2022 16:53:24 GMT
Subject: [jdk8u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses
 wrong condition
Message-ID: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

-------------

Commit messages:
 - Backport 4c52eb39431c2479b0d140907bdcc0311d30f871

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/6/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=6&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8279669
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/6.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/6/head:pull/6

PR: https://git.openjdk.java.net/jdk8u-dev/pull/6

From phh at openjdk.java.net  Mon Mar 14 17:56:54 2022
From: phh at openjdk.java.net (Paul Hohensee)
Date: Mon, 14 Mar 2022 17:56:54 GMT
Subject: [jdk8u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java
 uses wrong condition
In-Reply-To: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
References: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
Message-ID: <UlwrWMJdceRF5GGyMq4aNNbMCUAF9KOF8zF7aNP8T3Y=.0c6281d8-45d1-4d60-8ced-041cb5ba866b@github.com>

On Mon, 14 Mar 2022 16:44:49 GMT, zzambers <duke at openjdk.java.net> wrote:

> please review this backport.
> It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
> I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).
> 
> This is PR for backport posted to jdk8u-dev just before move to github:
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/6

From sgehwolf at openjdk.java.net  Tue Mar 15 09:17:44 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Tue, 15 Mar 2022 09:17:44 GMT
Subject: [jdk8u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java
 uses wrong condition
In-Reply-To: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
References: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
Message-ID: <KUxcLuI7_5UQIRVL6HM5axjkdsGzxHO7qAmwk3nwUds=.ef25ed34-6f18-4435-8760-8f313fe7b937@github.com>

On Mon, 14 Mar 2022 16:44:49 GMT, zzambers <duke at openjdk.java.net> wrote:

> please review this backport.
> It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
> I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).
> 
> This is PR for backport posted to jdk8u-dev just before move to github:
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html

Looks fine. Same patch as for 11u.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/6

From duke at openjdk.java.net  Tue Mar 15 11:43:52 2022
From: duke at openjdk.java.net (zzambers)
Date: Tue, 15 Mar 2022 11:43:52 GMT
Subject: [jdk8u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java
 uses wrong condition
In-Reply-To: <KUxcLuI7_5UQIRVL6HM5axjkdsGzxHO7qAmwk3nwUds=.ef25ed34-6f18-4435-8760-8f313fe7b937@github.com>
References: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
 <KUxcLuI7_5UQIRVL6HM5axjkdsGzxHO7qAmwk3nwUds=.ef25ed34-6f18-4435-8760-8f313fe7b937@github.com>
Message-ID: <nzU74alaFr7cQpiXNNupwpb20sBNkgiYD-SJfjLeLbg=.0d7409ff-c50d-452f-981a-7de52d3feabd@github.com>

On Tue, 15 Mar 2022 09:14:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> please review this backport.
>> It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
>> I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).
>> 
>> This is PR for backport posted to jdk8u-dev just before move to github:
>> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html
>
> Looks fine. Same patch as for 11u.

@jerboaa @phohensee thanks for reviews

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/6

From duke at openjdk.java.net  Tue Mar 15 12:53:47 2022
From: duke at openjdk.java.net (zzambers)
Date: Tue, 15 Mar 2022 12:53:47 GMT
Subject: [jdk8u-dev] Integrated: 8279669:
 test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
In-Reply-To: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
References: <1aCjHXepjCRWJkmCvtbIxS8MyHyqkumIVP23k1t9QEA=.9086de35-2b6d-48c6-b474-4323b6259ad6@github.com>
Message-ID: <U9Aldu6PJXNICu_4yKo4vKCqyiZaP3aEdGLYsl8JFZY=.fc6408ed-616e-4677-bc37-c181bce83bdf@github.com>

On Mon, 14 Mar 2022 16:44:49 GMT, zzambers <duke at openjdk.java.net> wrote:

> please review this backport.
> It fixes: test/com/sun/jdi/RedefineCrossEvent.java test.
> I manually ran all tests in test/com/sun/jdi and they passed for me with this patch applied (when originally created).
> 
> This is PR for backport posted to jdk8u-dev just before move to github:
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014578.html

This pull request has now been integrated.

Changeset: b5bcf6c2
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/b5bcf6c272cdd0397555bcf0d9887081016bc9a4
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

Reviewed-by: phh, sgehwolf
Backport-of: 4c52eb39431c2479b0d140907bdcc0311d30f871

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/6

From evergizova at openjdk.java.net  Tue Mar 15 17:01:19 2022
From: evergizova at openjdk.java.net (Ekaterina Vergizova)
Date: Tue, 15 Mar 2022 17:01:19 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements from
 Xalan
Message-ID: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>

I'd like to backport JDK-8041523 to 8u.
This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
?ffected tests:
api/xinclude/Nist/Nist-include-38.html#Nist-include-38
api/xinclude/Nist/Nist-include-37.html#Nist-include-37
api/xinclude/Harold/harold-64.html#harold-64

Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.

Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

-------------

Commit messages:
 - Backport 38fdd0804030744b2804c35c97f843319a961799

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/7/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=7&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8041523
  Stats: 1229 lines in 12 files changed: 721 ins; 346 del; 162 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/7.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/7/head:pull/7

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From andrew at openjdk.java.net  Tue Mar 15 19:06:46 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 15 Mar 2022 19:06:46 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
Message-ID: <BNzCXqjKYbngbLGB6tF-uw464n1elNpbMA5xVGU9Ajo=.17b26e8f-0ae7-49b8-9643-a0cff8319847@github.com>

On Tue, 15 Mar 2022 16:53:00 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> I'd like to backport JDK-8041523 to 8u.
> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
> ?ffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
> 
> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

Hi,

Thanks for the backport. I don't see a link between JDK-8041523 & JDK-8037259 in the bug database. If the latter does indeed introduce a TCK failure corrected by the former, can you please link the two together? I guess that's why this wasn't spotted when JDK-8037259 was backported.

If it is indeed fixing a TCK failure introduced in 8u332, I think this should be a `jdk8u-critical-request` and go directly into the [monojdk8u](https://hg.openjdk.java.net/jdk8u/monojdk8u) Mercurial repository once approved, rather than merging this PR.

As to the patch itself:

* `jaxp/src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java` copyright change is already present from JDK-8068842
* `jaxp/src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java`: same
* `jaxp/src/com/sun/org/apache/xml/internal/serializer/EmptySerializer.java`: same
* `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java`: the structure of the diff doesn't align well with the 9u version so it's hard to tell if these changes are the same. Were any additional changes needed here? It may just be whitespace differences confusing things.

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From evergizova at openjdk.java.net  Tue Mar 15 21:01:48 2022
From: evergizova at openjdk.java.net (Ekaterina Vergizova)
Date: Tue, 15 Mar 2022 21:01:48 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
Message-ID: <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>

On Tue, 15 Mar 2022 16:53:00 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> I'd like to backport JDK-8041523 to 8u.
> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
> ?ffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
> 
> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

Hi,
thanks for the comments.

I added the link and comment to JDK-8037259.

As for the `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java` difference, probably it's better to compare with 11u git commit [38fdd08](https://github.com/openjdk/jdk11u-dev/commit/38fdd0804030744b2804c35c97f843319a961799)
It is similar to proposed 8u patch for ToStream.java. 
Actually the only hunk that was rejected and manually reapplied due to a difference in context is #1, the copyright comment, all other hunks were applied cleanly.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From sgehwolf at openjdk.java.net  Wed Mar 16 10:59:48 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Wed, 16 Mar 2022 10:59:48 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
 <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
Message-ID: <F9MoR41hnNBPPn6dNLV6_4A1gNBPP6rst_bf93jiSrE=.ad0b55fe-c2f5-4f27-9308-b171d7fa27c2@github.com>

On Tue, 15 Mar 2022 20:58:17 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> I'd like to backport JDK-8041523 to 8u.
>> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
>> ?ffected tests:
>> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
>> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
>> api/xinclude/Harold/harold-64.html#harold-64
>> 
>> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
>> 
>> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.
>
> Hi,
> thanks for the comments.
> 
> I added the link and comment to JDK-8037259.
> 
> As for the `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java` difference, probably it's better to compare with 11u git commit [38fdd08](https://github.com/openjdk/jdk11u-dev/commit/38fdd0804030744b2804c35c97f843319a961799)
> It is similar to proposed 8u patch for ToStream.java. 
> Actually the only hunk that was rejected and manually reapplied due to a difference in context is #1, the copyright comment, all other hunks were applied cleanly.

@kvergizova This looks good to me. Please create a webrev targetting the monorepo here: https://hg.openjdk.java.net/jdk8u/monojdk8u and send an RFR with that and close this PR. It's a critical fix and we need to push it there not to the jdk8u-dev git tree. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From akasko at openjdk.java.net  Wed Mar 16 17:00:31 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Wed, 16 Mar 2022 17:00:31 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v2]
In-Reply-To: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
Message-ID: <TSF87h3WtBxcxQAd3cq_h7suQo-XNL__Pckxlooqb7s=.aeb72c59-9493-4a1d-be53-510aa738ec95@github.com>

> Please review a backport of a JAXP cleanup.
> 
> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
> 
> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8129572: Cleanup usage of getResourceAsStream in jaxp
  
  Reviewed-by: alanb, joehw, mchung, redestad
  Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/4/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/4/files/f0cd3f72..2bf03c91

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/4/head:pull/4

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From akasko at openjdk.java.net  Wed Mar 16 17:01:57 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Wed, 16 Mar 2022 17:01:57 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v3]
In-Reply-To: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
Message-ID: <mpjJl4RxR4BGM_vMiGp9ItyTfH3q8hI3doCipQ8ulyI=.d2f4dabd-72af-4e39-a0df-462bfcbb2641@github.com>

> Please review a backport of a JAXP cleanup.
> 
> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
> 
> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Backport 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75
  
  Reviewed-by: alanb, joehw, mchung, redestad
  Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/4/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/4/files/2bf03c91..24601c81

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/4/head:pull/4

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From akasko at openjdk.java.net  Wed Mar 16 17:05:04 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Wed, 16 Mar 2022 17:05:04 GMT
Subject: [jdk8u-dev] RFR: Backport 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75
 [v4]
In-Reply-To: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
Message-ID: <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>

> Please review a backport of a JAXP cleanup.
> 
> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
> 
> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8129572: Cleanup usage of getResourceAsStream in jaxp
  
  Reviewed-by: alanb, joehw, mchung, redestad
  Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/4/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/4/files/24601c81..0c0854a8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=4&range=02-03

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/4.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/4/head:pull/4

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From andrew at openjdk.java.net  Thu Mar 17 03:11:39 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 17 Mar 2022 03:11:39 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
 <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
Message-ID: <V1lw1WrklOgnrdHRS9MxkWQT42wrleZLPwXYElo7epY=.dfc0f652-05d7-4b30-94ec-9685195c60eb@github.com>

On Tue, 15 Mar 2022 20:58:17 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> Hi, thanks for the comments.
> 
> I added the link and comment to JDK-8037259.
> 
> As for the `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java` difference, probably it's better to compare with 11u git commit [38fdd08](https://github.com/openjdk/jdk11u-dev/commit/38fdd0804030744b2804c35c97f843319a961799) It is similar to proposed 8u patch for ToStream.java. Actually the only hunk that was rejected and manually reapplied due to a difference in context is #1, the copyright comment, all other hunks were applied cleanly.

Hmm, I would have thought it would be the same commit in either repository, but it does seem to have been altered in the move to git. Interesting. I guess people should use the 11u version of commits then. I'll update the 8u docs with that.

As the changes are part of that git transfer, I'm fine with your patch as is, but please rebase to monojdk8u and apply for jdk8u-critical-fix as @jerboaa suggests.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From andrew at openjdk.java.net  Thu Mar 17 03:16:37 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 17 Mar 2022 03:16:37 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v4]
In-Reply-To: <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
 <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
Message-ID: <0vZ-_a1goSa71yyXDOmzMgBzpwwY-nFp0Z9HtZFysLw=.68356dbd-9e54-461b-a518-63bcdae31f21@github.com>

On Wed, 16 Mar 2022 17:05:04 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> Please review a backport of a JAXP cleanup.
>> 
>> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
>> 
>> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
>> 
>> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
>> 
>> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
>> 
>> Testing:
>> 
>>  - [x] jtreg:javax/xml/jaxp
>>  - [x] jck:api/javax_xml
>
> Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8129572: Cleanup usage of getResourceAsStream in jaxp
>   
>   Reviewed-by: alanb, joehw, mchung, redestad
>   Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

This looks fine to me; only difference from the 11u patch, other than the paths, is the missing test change, which just adds some `println` statements to it. While it might be nice to bring in all those additional tests for 8u, JDK-8043084 is not a mandatory prerequisite of this change.

Please flag with `jdk8u-fix-request`.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From andrew at openjdk.java.net  Thu Mar 17 03:48:35 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 17 Mar 2022 03:48:35 GMT
Subject: [jdk8u-dev] RFR: 8132256: jaxp: Investigate removal of
 com/sun/org/apache/bcel/internal/util/ClassPath.java
In-Reply-To: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
References: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
Message-ID: <OJeabZsFt2M-kmiVZ_LW8AeHxP2N7IziSpyGXiwzOTM=.6215b217-ab17-4b03-9f35-9482cd8ffba4@github.com>

On Wed, 9 Mar 2022 21:23:12 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> Please review a backport of a JAXP cleanup.
> 
> Original commit [dcdbd67e6408](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/dcdbd67e6408) in jdk9.
> 
> Commit [6e586e8](https://github.com/openjdk/jdk11u-dev/commit/6e586e8a3b8807652218c4caf97ef501f42d7f36) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> Patch does not apply cleanly because in jdk9 ClassPath.java (that is deleted in this backport) was changed in [JDK-8049367](https://bugs.openjdk.java.net/browse/JDK-8049367) that is not in 8u.
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Looks fine to me. It doesn't matter about changes for the module system we don't want being missing from a file we're deleting anyway :)

Please flag with `jdk8u-fix-request`

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/5

From hedongbo at huawei.com  Thu Mar 17 08:16:16 2022
From: hedongbo at huawei.com (hedongbo)
Date: Thu, 17 Mar 2022 08:16:16 +0000
Subject: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
In-Reply-To: <510c8595d5124a8c9aeca33795ef92bd@huawei.com>
References: <4dd54b5a943842868ec4b1c8aed2dbf3@huawei.com>
 <348b7a3fcfef4d66bb8f0a4c085e20d9@huawei.com>
 <9EA91A8B-8D32-4652-A393-8F3685DC6F41@oracle.com>
 <510c8595d5124a8c9aeca33795ef92bd@huawei.com>
Message-ID: <73f0533bc8f946899f867f13abd1efa4@huawei.com>

Hi 8u-maintainers,

Excuse me, can this fix be merged into 8u332 or 8u342?

Thanks,
Hedongbo


-----Original Message-----
From: hedongbo 
Sent: Wednesday, January 5, 2022 10:20 AM
To: 'Serguei Spitsyn' <serguei.spitsyn at oracle.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Cc: serviceability-dev at openjdk.java.net
Subject: RE: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

Thank you for your review, Serguei.

I have added jdk8u-fix-request label in JDK-8173361[1], and now I need to wait for an 8u maintainer to add jdk8u-fix-yes.
After that, the change can be commited by the committer, the recommended process is on the wiki of jdk8u#Contributing[2].

[1] https://bugs.openjdk.java.net/browse/JDK-8146690
[2] https://wiki.openjdk.java.net/display/jdk8u/Main

Thanks,
Hedongbo

-----Original Message-----
From: Serguei Spitsyn <serguei.spitsyn at oracle.com> 
Sent: Wednesday, January 5, 2022 7:05 AM
To: hedongbo <hedongbo at huawei.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Cc: serviceability-dev at openjdk.java.net
Subject: Re: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

Hi Hedongbo,

The backport looks okay to me.
But I do not see where I can mark it as approved.
Do you have a PR (Pool Request) or a backport bug number?

Thanks,
Serguei


?On 12/29/21, 7:58 PM, "jdk8u-dev on behalf of hedongbo" <jdk8u-dev-retn at openjdk.java.net on behalf of hedongbo at huawei.com> wrote:

    This problem has affected the customer's use at present. Can anyone help to take a look? Thanks.
    
    Thanks,
    hedongbo
    
    From: hedongbo
    Sent: Friday, December 17, 2021 9:35 AM
    To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
    Cc: 'serviceability-dev at openjdk.java.net' <serviceability-dev at openjdk.java.net>
    Subject: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load
    
    
    Hi,
    
    Please review the backport of JDK-8173361 to 8u.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
    11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
    8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/
    
    This patch doesn't apply cleanly.
    I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
    I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
    I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.
    
    Tested with tier1. No regression in tests.
    Follow-up fix JDK-8235218[4] is planned to be backported as well.
    
    [1] https://bugs.openjdk.java.net/browse/JDK-8146690
    [2] https://bugs.openjdk.java.net/browse/JDK-8047290
    [3] https://bugs.openjdk.java.net/browse/JDK-8154580
    [4] https://bugs.openjdk.java.net/browse/JDK-8235218
    
    
    Thanks,
    
    hedongbo
    
    
    
    
    


From dongbohe at openjdk.java.net  Thu Mar 17 09:10:11 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 09:10:11 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed
Message-ID: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>

Hi,

Please review the backport of JDK-8194154 to 8u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/

Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
and some copyright year conflicts.

Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.

[1] https://bugs.openjdk.java.net/browse/JDK-8154231
[2] https://bugs.openjdk.java.net/browse/JDK-8155775

Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html

Thanks,
hedongbo

-------------

Commit messages:
 - 8194154: System property user.dir should not be changed

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/8/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=8&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8194154
  Stats: 69 lines in 3 files changed: 65 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/8.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/8/head:pull/8

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From sgehwolf at openjdk.java.net  Thu Mar 17 09:34:36 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Thu, 17 Mar 2022 09:34:36 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed
In-Reply-To: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
Message-ID: <6En6YA4dnFeDgfmtpgMZ54H4-3zdSsVhD-b5rCzTLTA=.be4c3db4-c2cf-4d21-aeab-026753d37aa7@github.com>

On Thu, 17 Mar 2022 09:04:07 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> Please review the backport of JDK-8194154 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
> 
> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
> and some copyright year conflicts.
> 
> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
> 
> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
> 
> Thanks,
> hedongbo

@dongbohe Skara tooling doesn't recognize this as a backport. Please use `Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151` as the PR title, which should make this so.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From sgehwolf at redhat.com  Thu Mar 17 09:52:02 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Thu, 17 Mar 2022 10:52:02 +0100
Subject: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
In-Reply-To: <73f0533bc8f946899f867f13abd1efa4@huawei.com>
References: <4dd54b5a943842868ec4b1c8aed2dbf3@huawei.com>
 <348b7a3fcfef4d66bb8f0a4c085e20d9@huawei.com>
 <9EA91A8B-8D32-4652-A393-8F3685DC6F41@oracle.com>
 <510c8595d5124a8c9aeca33795ef92bd@huawei.com>
 <73f0533bc8f946899f867f13abd1efa4@huawei.com>
Message-ID: <5ea4c55a4c258613aca88989ca33185bd54a8230.camel@redhat.com>

Hi,

On Thu, 2022-03-17 at 08:16 +0000, hedongbo wrote:
> Hi 8u-maintainers,
> 
> Excuse me, can this fix be merged into 8u332 or 8u342?

At this point you need to create a git PR at:
https://github.com/openjdk/jdk8u-dev/ and get it integrated for 8u342
that way. 8u332 is in rampdown and this fix doesn't qualify as a
critical fix.

Thanks,
Severin

> Thanks,
> Hedongbo
> 
> 
> -----Original Message-----
> From: hedongbo 
> Sent: Wednesday, January 5, 2022 10:20 AM
> To: 'Serguei Spitsyn' <serguei.spitsyn at oracle.com>; jdk8u-dev
> <jdk8u-dev at openjdk.java.net>
> Cc: serviceability-dev at openjdk.java.net
> Subject: RE: [8u] RFR: 8173361: various crashes in
> JvmtiExport::post_compiled_method_load
> 
> Thank you for your review, Serguei.
> 
> I have added jdk8u-fix-request label in JDK-8173361[1], and now I
> need to wait for an 8u maintainer to add jdk8u-fix-yes.
> After that, the change can be commited by the committer, the
> recommended process is on the wiki of jdk8u#Contributing[2].
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8146690
> [2] https://wiki.openjdk.java.net/display/jdk8u/Main
> 
> Thanks,
> Hedongbo
> 
> -----Original Message-----
> From: Serguei Spitsyn <serguei.spitsyn at oracle.com> 
> Sent: Wednesday, January 5, 2022 7:05 AM
> To: hedongbo <hedongbo at huawei.com>; jdk8u-dev
> <jdk8u-dev at openjdk.java.net>
> Cc: serviceability-dev at openjdk.java.net
> Subject: Re: [8u] RFR: 8173361: various crashes in
> JvmtiExport::post_compiled_method_load
> 
> Hi Hedongbo,
> 
> The backport looks okay to me.
> But I do not see where I can mark it as approved.
> Do you have a PR (Pool Request) or a backport bug number?
> 
> Thanks,
> Serguei
> 
> 
> ?On 12/29/21, 7:58 PM, "jdk8u-dev on behalf of hedongbo"
> <jdk8u-dev-retn at openjdk.java.net?on behalf of hedongbo at huawei.com>
> wrote:
> 
> ??? This problem has affected the customer's use at present. Can
> anyone help to take a look? Thanks.
> ??? 
> ??? Thanks,
> ??? hedongbo
> ??? 
> ??? From: hedongbo
> ??? Sent: Friday, December 17, 2021 9:35 AM
> ??? To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> ??? Cc: 'serviceability-dev at openjdk.java.net'
> <serviceability-dev at openjdk.java.net>
> ??? Subject: [8u] RFR: 8173361: various crashes in
> JvmtiExport::post_compiled_method_load
> ??? 
> ??? 
> ??? Hi,
> ??? 
> ??? Please review the backport of JDK-8173361 to 8u.
> ??? Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
> ??? 11u commit:
> https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
> ??? 8u webrev:
> https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/
> ??? 
> ??? This patch doesn't apply cleanly.
> ??? I turned NoSafepointVerifier to No_Safepoint_Verifier because
> JDK- 8146690[1] changed the naming convention.
> ??? I removed the mutexLocker.cpp changeset because JDK-8047290[2]?
> does not exist in 8.
> ??? I added the CLDClosure* to ServiceThread::oops_do because JDK-
> 8154580[3] does not exist in 8.
> ??? 
> ??? Tested with tier1. No regression in tests.
> ??? Follow-up fix JDK-8235218[4] is planned to be backported as well.
> ??? 
> ??? [1] https://bugs.openjdk.java.net/browse/JDK-8146690
> ??? [2] https://bugs.openjdk.java.net/browse/JDK-8047290
> ??? [3] https://bugs.openjdk.java.net/browse/JDK-8154580
> ??? [4] https://bugs.openjdk.java.net/browse/JDK-8235218
> ??? 
> ??? 
> ??? Thanks,
> ??? 
> ??? hedongbo
> ??? 
> ??? 
> ??? 
> ??? 
> ??? 
> 


From dongbohe at openjdk.java.net  Thu Mar 17 10:37:26 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 10:37:26 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed [v2]
In-Reply-To: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
Message-ID: <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>

> Hi,
> 
> Please review the backport of JDK-8194154 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
> 
> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
> and some copyright year conflicts.
> 
> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
> 
> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
> 
> Thanks,
> hedongbo

Dongbo He has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/8/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/8/files/578d2285..d0d7c4ad

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=8&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=8&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/8.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/8/head:pull/8

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From sgehwolf at openjdk.java.net  Thu Mar 17 10:49:42 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Thu, 17 Mar 2022 10:49:42 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed [v2]
In-Reply-To: <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
 <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
Message-ID: <CzPrsjyjl101GZJ1rs_SjQSgTYsQMxk54NvUF4cNP2E=.a6908640-6192-4f9b-b9b2-dbef6eed460c@github.com>

On Thu, 17 Mar 2022 10:37:26 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the backport of JDK-8194154 to 8u.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
>> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
>> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
>> 
>> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
>> and some copyright year conflicts.
>> 
>> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
>> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
>> 
>> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
>> 
>> Thanks,
>> hedongbo
>
> Dongbo He has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151

PR title (in the UI), not commit message :)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From dongbohe at openjdk.java.net  Thu Mar 17 10:58:34 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 10:58:34 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed [v2]
In-Reply-To: <CzPrsjyjl101GZJ1rs_SjQSgTYsQMxk54NvUF4cNP2E=.a6908640-6192-4f9b-b9b2-dbef6eed460c@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
 <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
 <CzPrsjyjl101GZJ1rs_SjQSgTYsQMxk54NvUF4cNP2E=.a6908640-6192-4f9b-b9b2-dbef6eed460c@github.com>
Message-ID: <Js3_OAurB6w9zdqFFD2lMFSIgmfB7dPt7cE3mjh16Bs=.72772592-e16b-4f83-8d60-6792aa25dbb3@github.com>

On Thu, 17 Mar 2022 10:46:42 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> PR title (in the UI), not commit message :)

Thanks for correcting me.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From dongbohe at openjdk.java.net  Thu Mar 17 11:22:00 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 11:22:00 GMT
Subject: [jdk8u-dev] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
Message-ID: <XYwkEcOZQzAj1pJk9SBS6SO4GG90ETqkVbZaWlkM4ME=.530b79e3-d82f-40c3-a553-46ea1a5377f8@github.com>

Hi,

This PR has been reviewed before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014487.html

Thanks,
hedongbo

-------------

Commit messages:
 - 8173361: various crashes in JvmtiExport::post_compiled_method_load

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/9/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=9&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8173361
  Stats: 98 lines in 8 files changed: 69 ins; 6 del; 23 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/9.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/9/head:pull/9

PR: https://git.openjdk.java.net/jdk8u-dev/pull/9

From dongbohe at openjdk.java.net  Thu Mar 17 11:38:01 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 11:38:01 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is unstable
Message-ID: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>

Hi,

This PR has been reviewed by Paul before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014489.html

Thanks,
hedongbo

-------------

Commit messages:
 - 8202142: jfr/event/io/TestInstrumentation is unstable

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/10/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=10&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8202142
  Stats: 401 lines in 11 files changed: 46 ins; 38 del; 317 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/10.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/10/head:pull/10

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From dongbohe at openjdk.java.net  Thu Mar 17 11:47:58 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 11:47:58 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage class
 specifier
Message-ID: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>

Hi,

Please review the backport of JDK-8207011 to 8u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8207011
Original commit: https://git.openjdk.java.net/jdk11u-dev/commit/98fb4f5e18a58727f51e00e3c08c0f5eac6748ec
8u webrev: http://cr.openjdk.java.net/~dongbohe/8207011/webrev.01/

This patch fixes build failure with gcc 11. Patch doesn?t apply cleanly, because JDK-8188813[1], JDK-8204301[2], JDK-8041415 [3], and JDK-8186089[4] does not exist in 8.
+ JDK-8188813 added register in orderAccess_aix_ppc.inline.hpp, orderAccess_linux_ppc.inline.hpp, orderAccess_linux_s390.inline.hpp, 
and JDK-8204301 renamed these files to orderAccess_aix_ppc.inline.hpp, orderAccess_aix_ppc.hpp, orderAccess_linux_s390.hpp.
+ JDK-8041415 changed uint32 to uint32_t.
+ JDK-8186089 moved arena from allocation.cpp to arena.cpp.

Before patch:
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/jiangshunningy/install/libexec/gcc/aarch64-unknown-linux-gnu/11.2.0/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: ../configure --prefix=/home/jiangshunningy/install --enable-languages=c,c++,fortran,go
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.2.0 (GCC)

$ bash configure
$ make images

-------------

Commit messages:
 - 8207011: Remove uses of the register storage class specifier

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/11/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=11&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8207011
  Stats: 52 lines in 12 files changed: 0 ins; 0 del; 52 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/11.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/11/head:pull/11

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11

From dongbohe at openjdk.java.net  Thu Mar 17 12:03:35 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Thu, 17 Mar 2022 12:03:35 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
References: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
Message-ID: <VnsHXXzTme9aVZPRAC_CoOHmfowYqvoi2XS33xDipLQ=.6b71bd27-6cb9-49ed-ae1f-15f43cc0379e@github.com>

On Thu, 17 Mar 2022 11:41:58 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> Please review the backport of JDK-8207011 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207011
> Original commit: https://git.openjdk.java.net/jdk11u-dev/commit/98fb4f5e18a58727f51e00e3c08c0f5eac6748ec
> 8u webrev: http://cr.openjdk.java.net/~dongbohe/8207011/webrev.01/
> 
> This patch fixes build failure with gcc 11. Patch doesn?t apply cleanly, because JDK-8188813[1], JDK-8204301[2], JDK-8041415 [3], and JDK-8186089[4] does not exist in 8.
> + JDK-8188813 added register in orderAccess_aix_ppc.inline.hpp, orderAccess_linux_ppc.inline.hpp, orderAccess_linux_s390.inline.hpp, 
> and JDK-8204301 renamed these files to orderAccess_aix_ppc.inline.hpp, orderAccess_aix_ppc.hpp, orderAccess_linux_s390.hpp.
> + JDK-8041415 changed uint32 to uint32_t.
> + JDK-8186089 moved arena from allocation.cpp to arena.cpp.
> 
> Before patch:
> $ gcc -v
> Using built-in specs.
> COLLECT_GCC=gcc
> COLLECT_LTO_WRAPPER=/home/jiangshunningy/install/libexec/gcc/aarch64-unknown-linux-gnu/11.2.0/lto-wrapper
> Target: aarch64-unknown-linux-gnu
> Configured with: ../configure --prefix=/home/jiangshunningy/install --enable-languages=c,c++,fortran,go
> Thread model: posix
> Supported LTO compression algorithms: zlib
> gcc version 11.2.0 (GCC)
> 
> $ bash configure
> $ make images

It seems that some of the information described on the PR is not displayed in the email(https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-March/014654.html).

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11

From abakhtin at openjdk.java.net  Thu Mar 17 12:36:22 2022
From: abakhtin at openjdk.java.net (Alexey Bakhtin)
Date: Thu, 17 Mar 2022 12:36:22 GMT
Subject: [jdk8u-dev] RFR: 8076190: Customizing the generation of a PKCS12
 keystore
Message-ID: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>

Please find the backport of JDK-8076190 to JDK8u

This patch is already reviewed and approved on the JDK8u mailing list:
- https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014142.html
- https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html

This PR is submitted to integrate already reviewed patch into the new git repository

-------------

Commit messages:
 - Backport 9136c7d1d0e1247ea1ac95a6577acbb789169031

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/12/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=12&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8076190
  Stats: 2370 lines in 21 files changed: 1903 ins; 280 del; 187 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/12.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/12/head:pull/12

PR: https://git.openjdk.java.net/jdk8u-dev/pull/12

From sgehwolf at openjdk.java.net  Thu Mar 17 14:37:32 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Thu, 17 Mar 2022 14:37:32 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed [v2]
In-Reply-To: <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
 <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
Message-ID: <8dGcrtwrDtHPMon_8eRLN85ueHXb7HyAOQoAkYQHFbw=.09a8eb0c-0bd1-4e1d-8949-5893030beb30@github.com>

On Thu, 17 Mar 2022 10:37:26 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the backport of JDK-8194154 to 8u.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
>> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
>> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
>> 
>> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
>> and some copyright year conflicts.
>> 
>> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
>> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
>> 
>> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
>> 
>> Thanks,
>> hedongbo
>
> Dongbo He has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151

LGTM

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From mbalao at openjdk.java.net  Thu Mar 17 15:57:36 2022
From: mbalao at openjdk.java.net (Martin Balao)
Date: Thu, 17 Mar 2022 15:57:36 GMT
Subject: [jdk8u-dev] RFR: 8076190: Customizing the generation of a PKCS12
 keystore
In-Reply-To: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>
References: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>
Message-ID: <B6PBpRw6UXc3uBmCL2C6C29KqfTKHUu2CCJiFwwpFMA=.d72b4ddf-5353-4adc-a11a-085725526e25@github.com>

On Thu, 17 Mar 2022 12:29:02 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Please find the backport of JDK-8076190 to JDK8u
> 
> This patch is already reviewed and approved on the JDK8u mailing list:
> - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014142.html
> - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html
> 
> This PR is submitted to integrate already reviewed patch into the new git repository

Already reviewed: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html

-------------

Marked as reviewed by mbalao (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/12

From abakhtin at openjdk.java.net  Thu Mar 17 16:08:39 2022
From: abakhtin at openjdk.java.net (Alexey Bakhtin)
Date: Thu, 17 Mar 2022 16:08:39 GMT
Subject: [jdk8u-dev] RFR: 8076190: Customizing the generation of a PKCS12
 keystore
In-Reply-To: <B6PBpRw6UXc3uBmCL2C6C29KqfTKHUu2CCJiFwwpFMA=.d72b4ddf-5353-4adc-a11a-085725526e25@github.com>
References: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>
 <B6PBpRw6UXc3uBmCL2C6C29KqfTKHUu2CCJiFwwpFMA=.d72b4ddf-5353-4adc-a11a-085725526e25@github.com>
Message-ID: <_isZADFq9dhkI_Oc927OeqHzJYTYkxCyh94h8cDw5K0=.1dca2c9b-2665-406e-9c13-ccb7b73b3cce@github.com>

On Thu, 17 Mar 2022 15:54:08 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Already reviewed: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html

Thank you @martinuy for review it one more time

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/12

From abakhtin at openjdk.java.net  Thu Mar 17 16:08:39 2022
From: abakhtin at openjdk.java.net (Alexey Bakhtin)
Date: Thu, 17 Mar 2022 16:08:39 GMT
Subject: [jdk8u-dev] Integrated: 8076190: Customizing the generation of a
 PKCS12 keystore
In-Reply-To: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>
References: <zBGV6dASnEKXBZLU1owl_at4e3OE2c2JCl3-NTGCMNo=.39138ec8-ab44-4c9b-acf5-0a942f7ee39a@github.com>
Message-ID: <wvujiyg06R1d6ilT6JwGKyj4Pp_zJp0bcjMaV__BorM=.bd163f2c-4e3d-4cdb-9da2-c43e2c1363c1@github.com>

On Thu, 17 Mar 2022 12:29:02 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Please find the backport of JDK-8076190 to JDK8u
> 
> This patch is already reviewed and approved on the JDK8u mailing list:
> - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014142.html
> - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html
> 
> This PR is submitted to integrate already reviewed patch into the new git repository

This pull request has now been integrated.

Changeset: 94cb2ef9
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/94cb2ef9307e1da317b4c17c65be25a724155876
Stats:     2370 lines in 21 files changed: 1903 ins; 280 del; 187 mod

8076190: Customizing the generation of a PKCS12 keystore

Reviewed-by: mbalao
Backport-of: 9136c7d1d0e1247ea1ac95a6577acbb789169031

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/12

From zgu at openjdk.java.net  Thu Mar 17 16:22:38 2022
From: zgu at openjdk.java.net (Zhengyu Gu)
Date: Thu, 17 Mar 2022 16:22:38 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is
 unstable
In-Reply-To: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
References: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
Message-ID: <QekQtfc-1woi7LRM-mI5O-Pff5zYGEpTkKpLGHhPiv8=.37232abb-090d-45ee-9426-42eeaf0ee5d5@github.com>

On Thu, 17 Mar 2022 11:30:31 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This PR has been reviewed by Paul before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014489.html
> 
> Thanks,
> hedongbo

I think should backport [8223396](https://bugs.openjdk.java.net/browse/JDK-8223396) first to eliminate another out-of-order backport.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From phh at openjdk.java.net  Thu Mar 17 16:52:35 2022
From: phh at openjdk.java.net (Paul Hohensee)
Date: Thu, 17 Mar 2022 16:52:35 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is
 unstable
In-Reply-To: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
References: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
Message-ID: <7f6oAWayKc3ELR1OYXBZrG5rIPrzM_TN5xHzOnFPH6E=.a70c900d-cea3-4d1c-a149-af01f8efe77f@github.com>

On Thu, 17 Mar 2022 11:30:31 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This PR has been reviewed by Paul before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014489.html
> 
> Thanks,
> hedongbo

Lgtm (again).

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From andrew at openjdk.java.net  Thu Mar 17 18:12:35 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Thu, 17 Mar 2022 18:12:35 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
References: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
Message-ID: <eYQxUgCYQ68AELAOk44CDOUpuXldfFOaLQj_r9yZbVY=.42a818d2-0434-43be-af27-11e467f27f90@github.com>

On Thu, 17 Mar 2022 11:41:58 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> Please review the backport of JDK-8207011 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207011
> Original commit: https://git.openjdk.java.net/jdk11u-dev/commit/98fb4f5e18a58727f51e00e3c08c0f5eac6748ec
> 8u webrev: http://cr.openjdk.java.net/~dongbohe/8207011/webrev.01/
> 
> This patch fixes build failure with gcc 11. Patch doesn?t apply cleanly, because JDK-8188813[1], JDK-8204301[2], JDK-8041415 [3], and JDK-8186089[4] does not exist in 8.
> + JDK-8188813 added register in orderAccess_aix_ppc.inline.hpp, orderAccess_linux_ppc.inline.hpp, orderAccess_linux_s390.inline.hpp, 
> and JDK-8204301 renamed these files to orderAccess_aix_ppc.inline.hpp, orderAccess_aix_ppc.hpp, orderAccess_linux_s390.hpp.
> + JDK-8041415 changed uint32 to uint32_t.
> + JDK-8186089 moved arena from allocation.cpp to arena.cpp.
> 
> Before patch:
> $ gcc -v
> Using built-in specs.
> COLLECT_GCC=gcc
> COLLECT_LTO_WRAPPER=/home/jiangshunningy/install/libexec/gcc/aarch64-unknown-linux-gnu/11.2.0/lto-wrapper
> Target: aarch64-unknown-linux-gnu
> Configured with: ../configure --prefix=/home/jiangshunningy/install --enable-languages=c,c++,fortran,go
> Thread model: posix
> Supported LTO compression algorithms: zlib
> gcc version 11.2.0 (GCC)
> 
> $ bash configure
> $ make images

This is an enhancement/cleanup fix and not appropriate for backporting to 8u.

Besides, this isn't the actual issue here. The baseline for 8u is C++98 (well, gnu++98 for GCC) where `register` is not deprecated. Newer versions of GCC have a later C++ standard as default so it has to be explicitly set (see [JDK-8151841](https://bugs.openjdk.java.net/browse/JDK-8151841))

The problem you're seeing here is that the ADLC code is not being passed that option. Indeed, it is not passed any of the extra C and C++ flags that may be specified to the build. This has gone unnoticed thus far because ADLC is a build tool that is used to generate files during the build and is not part of the shipped product.

I already have a bug for this - [JDK-8281098](https://bugs.openjdk.java.net/browse/JDK-8281098) - and a tested fix. I've not yet submitted it upstream as I'd like at least the build testing on PRs to be in place - PR #3 - so we can reduce the (already unlikely) chance it breaks anything.

I would appreciate it if you would withdraw this PR and wait for JDK-8281098 to be integrated. That should happen soon.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11

From katya at azul.com  Thu Mar 17 18:21:33 2022
From: katya at azul.com (Ekaterina Vergizova)
Date: Thu, 17 Mar 2022 18:21:33 +0000
Subject: [8u] RFR: 8041523: Xerces Update: Serializer improvements from Xalan
Message-ID: <DM4PR11MB52453A76AAA5B99D510C1F13D1129@DM4PR11MB5245.namprd11.prod.outlook.com>

Hello,
I would like to backport JDK-8041523 to 8u. It should be included to monojdk8u as a critical fix.

This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
?ffected tests:
api/xinclude/Nist/Nist-include-38.html#Nist-include-38
api/xinclude/Nist/Nist-include-37.html#Nist-include-37
api/xinclude/Harold/harold-64.html#harold-64

JBS: https://bugs.openjdk.java.net/browse/JDK-8041523
Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453
Webrev for 8u: https://cr.openjdk.java.net/~apetushkov/8041523/webrev.00/

Original patch from jdk9 applies almost cleanly except for some copyright differences and imports reshuffling.

Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

Thanks,
Ekaterina

From evergizova at openjdk.java.net  Thu Mar 17 18:37:41 2022
From: evergizova at openjdk.java.net (Ekaterina Vergizova)
Date: Thu, 17 Mar 2022 18:37:41 GMT
Subject: [jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
 <2KNlC11oly1--Em0wlYnx90Q2TcwoMsD_OYzb59gSHE=.5c8d39c8-5550-44ed-8881-d9850f8da9c1@github.com>
Message-ID: <r2c_RPVOTfKoby-yADmI3dNFB3OgWXR-Fqtl2cScFxQ=.84c241d2-f0f0-47cf-8d1e-c38b5b621a99@github.com>

On Tue, 15 Mar 2022 20:58:17 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> I'd like to backport JDK-8041523 to 8u.
>> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
>> ?ffected tests:
>> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
>> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
>> api/xinclude/Harold/harold-64.html#harold-64
>> 
>> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
>> 
>> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.
>
> Hi,
> thanks for the comments.
> 
> I added the link and comment to JDK-8037259.
> 
> As for the `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java` difference, probably it's better to compare with 11u git commit [38fdd08](https://github.com/openjdk/jdk11u-dev/commit/38fdd0804030744b2804c35c97f843319a961799)
> It is similar to proposed 8u patch for ToStream.java. 
> Actually the only hunk that was rejected and manually reapplied due to a difference in context is #1, the copyright comment, all other hunks were applied cleanly.

> @kvergizova This looks good to me. Please create a webrev targetting the monorepo here: https://hg.openjdk.java.net/jdk8u/monojdk8u and send an RFR with that and close this PR. It's a critical fix and we need to push it there not to the jdk8u-dev git tree. Thanks!

Thanks, RFR for monojdk8u: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-March/014664.html

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From evergizova at openjdk.java.net  Thu Mar 17 18:37:41 2022
From: evergizova at openjdk.java.net (Ekaterina Vergizova)
Date: Thu, 17 Mar 2022 18:37:41 GMT
Subject: [jdk8u-dev] Withdrawn: 8041523: Xerces Update: Serializer improvements
 from Xalan
In-Reply-To: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
References: <1r8fIEn1wQqMmAxdzLAq61hwIpNE2MEOIscVgv2JrkY=.24ad319a-e318-4208-bd9a-36209f583c20@github.com>
Message-ID: <i4C2BgkAIq9inmzZdxh76flGIeO83SIRbdAURjbFAMY=.5d2426d2-f50d-428f-bd5e-583fba8276c9@github.com>

On Tue, 15 Mar 2022 16:53:00 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> I'd like to backport JDK-8041523 to 8u.
> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
> ?ffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
> 
> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7

From dongbohe at openjdk.java.net  Fri Mar 18 01:28:35 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 01:28:35 GMT
Subject: [jdk8u-dev] RFR: 8194154: System property user.dir should not be
 changed [v2]
In-Reply-To: <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
 <YD0tikez32Mkn8NpNQit3lZcqiVBybLFYs6qi6rPw50=.4a214fcb-5a1a-4bde-bd0e-03b22f01f339@github.com>
Message-ID: <Yvoq6nhm66PM9ZF3IIZXfpkngNKZVjKWC78kjmfC0Qg=.efad6a77-7cbf-4898-9bb0-cd0acd8afd74@github.com>

On Thu, 17 Mar 2022 10:37:26 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the backport of JDK-8194154 to 8u.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
>> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
>> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
>> 
>> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
>> and some copyright year conflicts.
>> 
>> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
>> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
>> 
>> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
>> 
>> Thanks,
>> hedongbo
>
> Dongbo He has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151

Thank you for your review, Severin. Tagged the JBS issue with jdk8u-fix-request.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From dongbohe at openjdk.java.net  Fri Mar 18 02:29:39 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 02:29:39 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <eYQxUgCYQ68AELAOk44CDOUpuXldfFOaLQj_r9yZbVY=.42a818d2-0434-43be-af27-11e467f27f90@github.com>
References: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
 <eYQxUgCYQ68AELAOk44CDOUpuXldfFOaLQj_r9yZbVY=.42a818d2-0434-43be-af27-11e467f27f90@github.com>
Message-ID: <omw911wwlKkNvnl3nep4_uV1-iaDIv5MhB1r3Cn-Wi8=.9abe2f18-61e5-4887-a748-4499e7c714b8@github.com>

On Thu, 17 Mar 2022 18:09:52 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> his is an enhancement/cleanup fix and not appropriate for backporting to 8u.
> 
> Besides, this isn't the actual issue here. The baseline for 8u is C++98 (well, gnu++98 for GCC) where `register` is not deprecated. Newer versions of GCC have a later C++ standard as default so it has to be explicitly set (see [JDK-8151841](https://bugs.openjdk.java.net/browse/JDK-8151841))
> 
> The problem you're seeing here is that the ADLC code is not being passed that option. Indeed, it is not passed any of the extra C and C++ flags that may be specified to the build. This has gone unnoticed thus far because ADLC is a build tool that is used to generate files during the build and is not part of the shipped product.

Thanks for reminding me of this and explaining the issue in detail.


> I already have a bug for this - [JDK-8281098](https://bugs.openjdk.java.net/browse/JDK-8281098) - and a tested fix. I've not yet submitted it upstream as I'd like at least the build testing on PRs to be in place - PR #3 - so we can reduce the (already unlikely) chance it breaks anything.
> 
> I would appreciate it if you would withdraw this PR and wait for JDK-8281098 to be integrated. That should happen soon.

Glad to hear that, I'll close this PR now and look forward to JDK-8281098 being integrated.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11

From dongbohe at openjdk.java.net  Fri Mar 18 02:29:39 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 02:29:39 GMT
Subject: [jdk8u-dev] Withdrawn: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
References: <u-rJlppJpXKrAuLAyNoTuVKsMdL3IQgi9mQ1MTJtA4M=.fc57051b-f76c-4ab9-8bfe-4865fee755fd@github.com>
Message-ID: <R7PEhagqmaxkbRraLWy3iXnFMvlFa165f8wmmWKZ2a0=.b613e000-feb8-493c-af94-832df4271475@github.com>

On Thu, 17 Mar 2022 11:41:58 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> Please review the backport of JDK-8207011 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207011
> Original commit: https://git.openjdk.java.net/jdk11u-dev/commit/98fb4f5e18a58727f51e00e3c08c0f5eac6748ec
> 8u webrev: http://cr.openjdk.java.net/~dongbohe/8207011/webrev.01/
> 
> This patch fixes build failure with gcc 11. Patch doesn?t apply cleanly, because JDK-8188813[1], JDK-8204301[2], JDK-8041415 [3], and JDK-8186089[4] does not exist in 8.
> + JDK-8188813 added register in orderAccess_aix_ppc.inline.hpp, orderAccess_linux_ppc.inline.hpp, orderAccess_linux_s390.inline.hpp, 
> and JDK-8204301 renamed these files to orderAccess_aix_ppc.inline.hpp, orderAccess_aix_ppc.hpp, orderAccess_linux_s390.hpp.
> + JDK-8041415 changed uint32 to uint32_t.
> + JDK-8186089 moved arena from allocation.cpp to arena.cpp.
> 
> Before patch:
> $ gcc -v
> Using built-in specs.
> COLLECT_GCC=gcc
> COLLECT_LTO_WRAPPER=/home/jiangshunningy/install/libexec/gcc/aarch64-unknown-linux-gnu/11.2.0/lto-wrapper
> Target: aarch64-unknown-linux-gnu
> Configured with: ../configure --prefix=/home/jiangshunningy/install --enable-languages=c,c++,fortran,go
> Thread model: posix
> Supported LTO compression algorithms: zlib
> gcc version 11.2.0 (GCC)
> 
> $ bash configure
> $ make images

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11

From dongbohe at openjdk.java.net  Fri Mar 18 09:32:59 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 09:32:59 GMT
Subject: [jdk8u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean up
 files created in /tmp
Message-ID: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>

Hi,

This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.

Test:
- [x] jdk_jfr
  EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

-------------

Commit messages:
 - Backport 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/14/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=14&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8223396
  Stats: 56 lines in 11 files changed: 30 ins; 6 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/14.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/14/head:pull/14

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From dongbohe at openjdk.java.net  Fri Mar 18 09:51:57 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 09:51:57 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
Message-ID: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>

Hi,

I would like to backport this patch to fix test failure, introduced by JDK-8223396.

This is a clean backport on top of JDK-8223396 backport.

Test:
- [x] jdk_jfr

-------------

Commit messages:
 - Backport 725da985e170d72c3ca3dc2dfbb3d7e083b5371a

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/16/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=16&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8230865
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/16.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/16/head:pull/16

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Fri Mar 18 09:53:40 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 18 Mar 2022 09:53:40 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is
 unstable
In-Reply-To: <QekQtfc-1woi7LRM-mI5O-Pff5zYGEpTkKpLGHhPiv8=.37232abb-090d-45ee-9426-42eeaf0ee5d5@github.com>
References: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
 <QekQtfc-1woi7LRM-mI5O-Pff5zYGEpTkKpLGHhPiv8=.37232abb-090d-45ee-9426-42eeaf0ee5d5@github.com>
Message-ID: <M7EAwX5jJZCOfm3j-sZ0B0Nh0UbFLuXkNguZjSZzzMw=.1f8b0dbf-bdf3-4f4f-a7d2-3b0dcd27f668@github.com>

On Thu, 17 Mar 2022 16:19:37 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> I think should backport [8223396](https://bugs.openjdk.java.net/browse/JDK-8223396) first to eliminate another out-of-order backport.

Hi, Zhengyu. I have created #14 to backport 8223396.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From sgehwolf at openjdk.java.net  Fri Mar 18 10:40:38 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Fri, 18 Mar 2022 10:40:38 GMT
Subject: [jdk8u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean
 up files created in /tmp
In-Reply-To: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
References: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
Message-ID: <KM02WP37HzxYB8C20FWfLyjsmQAlBLn4ERkPUBxIo9c=.0e9b7e82-3483-423b-843a-b49ff589285e@github.com>

On Fri, 18 Mar 2022 09:26:36 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.
> 
> Test:
> - [x] jdk_jfr
>   EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Clean backport other than path reshuffling.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From sgehwolf at openjdk.java.net  Fri Mar 18 10:44:38 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Fri, 18 Mar 2022 10:44:38 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
Message-ID: <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>

On Fri, 18 Mar 2022 09:45:38 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> I would like to backport this patch to fix test failure, introduced by JDK-8223396.
> 
> This is a clean backport on top of JDK-8223396 backport.
> 
> Test:
> - [x] jdk_jfr

@dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From duke at openjdk.java.net  Fri Mar 18 12:31:05 2022
From: duke at openjdk.java.net (Alexey Pavlyutkin)
Date: Fri, 18 Mar 2022 12:31:05 GMT
Subject: [jdk8u-dev] RFR: 8190753: (zipfs): Accessing a large entry (> 2^31
 bytes) leads to a negative initial size for ByteArrayOutputStream
Message-ID: <2f1WZB-7a95AbsGtWUlAX_cQhK19C6zRXx9NTANDNW0=.3082177e-e569-4aef-b630-60c29f83a41f@github.com>

Hi!

Please review the backport of JDK-8190753 to 8u. The patch fixes IllegalArgumentException that takes place on accessing large (>2^31 bytes) entries in zipfs.

The original patch

https://github.com/openjdk/jdk11u-dev/pull/545

was applied with the following changes:

- changes to absent DeflatingEntryOutputStream class were skipped (in 8u EntryOutputStream handles both RAW and deflating streaming);
- the tests were updated to not use unsupported APIs like Path.of() and Map.of()
- timeout value for ZipFSOutputStreamTest was increased, because the test is too gready and may fail by timeout on low performance hosts

Verification/regression: jdk_other (20.04/amd64)

-------------

Commit messages:
 - 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/17/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=17&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8190753
  Stats: 365 lines in 3 files changed: 360 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/17.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/17/head:pull/17

PR: https://git.openjdk.java.net/jdk8u-dev/pull/17

From sgehwolf at redhat.com  Fri Mar 18 12:55:08 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Fri, 18 Mar 2022 13:55:08 +0100
Subject: [8u] RFR: 8041523: Xerces Update: Serializer improvements from
 Xalan
In-Reply-To: <DM4PR11MB52453A76AAA5B99D510C1F13D1129@DM4PR11MB5245.namprd11.prod.outlook.com>
References: <DM4PR11MB52453A76AAA5B99D510C1F13D1129@DM4PR11MB5245.namprd11.prod.outlook.com>
Message-ID: <d542d71d5a6fe1639a21f454ab77f7f499918af0.camel@redhat.com>

Hi,

On Thu, 2022-03-17 at 18:21 +0000, Ekaterina Vergizova wrote:
> Hello,
> I would like to backport JDK-8041523 to 8u. It should be included to
> monojdk8u as a critical fix.
> 
> This backport fixes jck8 api/xinclude test failures that occur after
> JDK-8037259 backport to 8u.
> ?ffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8041523
> Original patch:
> http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453
> Webrev for 8u:
> https://cr.openjdk.java.net/~apetushkov/8041523/webrev.00/
> 
> Original patch from jdk9 applies almost cleanly except for some
> copyright differences and imports reshuffling.

Looks good. Please flag the bug jdk8u-critical-request with a Fix
Request comment for approval.

Thanks,
Severin


From phh at openjdk.java.net  Fri Mar 18 16:49:35 2022
From: phh at openjdk.java.net (Paul Hohensee)
Date: Fri, 18 Mar 2022 16:49:35 GMT
Subject: [jdk8u-dev] RFR: 8190753: (zipfs): Accessing a large entry (> 2^31
 bytes) leads to a negative initial size for ByteArrayOutputStream
In-Reply-To: <2f1WZB-7a95AbsGtWUlAX_cQhK19C6zRXx9NTANDNW0=.3082177e-e569-4aef-b630-60c29f83a41f@github.com>
References: <2f1WZB-7a95AbsGtWUlAX_cQhK19C6zRXx9NTANDNW0=.3082177e-e569-4aef-b630-60c29f83a41f@github.com>
Message-ID: <b-VedbaL5hQelFmI2uelmkYRF_9sVjte8ee1frLw_AQ=.ac536d5c-ee8a-43bb-b16c-e0bf9795e39f@github.com>

On Fri, 18 Mar 2022 12:24:37 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

> Hi!
> 
> Please review the backport of JDK-8190753 to 8u. The patch fixes IllegalArgumentException that takes place on accessing large (>2^31 bytes) entries in zipfs.
> 
> The original patch
> 
> https://github.com/openjdk/jdk11u-dev/pull/545
> 
> was applied with the following changes:
> 
> - changes to absent DeflatingEntryOutputStream class were skipped (in 8u EntryOutputStream handles both RAW and deflating streaming);
> - the tests were updated to not use unsupported APIs like Path.of() and Map.of()
> - timeout value for ZipFSOutputStreamTest was increased, because the test is too gready and may fail by timeout on low performance hosts
> 
> The changes were previously reviewed: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-December/014479.html
> 
> Verification/regression: jdk_other (20.04/amd64)

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/17

From andrew at openjdk.java.net  Sat Mar 19 18:18:15 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 19 Mar 2022 18:18:15 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v12]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <DZJ5KJheMDcW76uOxePVk3IcZBcgd16Ucss5pJ6ySW0=.8c27edda-db02-4f0a-87d2-e242daca4dfe@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with three additional commits since the last revision:

 - Remove linux_additional_build dependency for now
 - Add Windows x86 with VS2010 & Windows x64 with VS2017 builds, adapted from work of Alex Kashchenko and Zden?k ?ambersk?
 - 8282225: GHA: Allow one concurrent run per PR only

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/f87dd745..c0a22e50

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=10-11

  Stats: 1957 lines in 3 files changed: 1950 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar 19 19:07:02 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 19 Mar 2022 19:07:02 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v13]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <56zf5qYATr2XZXllhpDovgUhPUpuF_3PD7hflacWCHg=.ec498e8a-f940-4d2a-9537-210a73940b72@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Try to fix quoting and dependencies

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/c0a22e50..f2fc1c47

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=11-12

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sat Mar 19 19:48:23 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sat, 19 Mar 2022 19:48:23 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v14]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <fWPmdkI0LmcyWDF-YMCbZYPNllhkFPifv9yxvgGTF-0=.0ba89768-755a-4690-bd75-84450baacb6f@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  windows-2016 dropped on 2022-03-15. Search for config.log first

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/f2fc1c47..e78b0e45

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=12-13

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From andrew at openjdk.java.net  Sun Mar 20 06:12:08 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Sun, 20 Mar 2022 06:12:08 GMT
Subject: [jdk8u-dev] RFR: 8253424: Add support for running pre-submit
 testing using GitHub Actions [v15]
In-Reply-To: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
References: <n-1Y9ApII-VpZgDwqk5EezTW1BKJUiK819AX2Bo7ADw=.6e17a648-5d65-4f83-ba83-27a3b55d8311@github.com>
Message-ID: <W00S1dlPSGaTesyjV6kDclJb9T56W3rFClR6MwbWE2U=.9f43d5d4-aa6d-43eb-ac8e-a4fdd3417645@github.com>

> Initial attempt to backport https://github.com/openjdk/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44
> 
> Changes so far:
> * `make/autoconf/version-numbers` -> `common/autoconf/version-numbers`
> * Fix version variables (`JDK_MAJOR_VERSION`, `JDK_MINOR_VERSION` and `JDK_MICRO_VERSION` in 8u)
> * Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
> * Replace `--with-version-opt` with `--with-user-release-suffix`
> * Drop `--enable-jtreg-failure-handler` (unsupported)
> * Move make targets to make invocation (`--with-default-make-target` not supported)
> * Drop `--with-msvc-toolset-version`
> * Disable tests as we don't currently have the bundles required to support them

Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:

  Build number should be of the format "bxx" in OpenJDK 8u

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/3/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/3/files/e78b0e45..c31ac2f8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=14
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=3&range=13-14

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/3.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3

PR: https://git.openjdk.java.net/jdk8u-dev/pull/3

From dongbohe at openjdk.java.net  Mon Mar 21 04:03:36 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 04:03:36 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
 <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
Message-ID: <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>

On Fri, 18 Mar 2022 10:41:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

done

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Mon Mar 21 04:05:35 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 04:05:35 GMT
Subject: [jdk8u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean
 up files created in /tmp
In-Reply-To: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
References: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
Message-ID: <3JZOURToQb5mbZdPxh54HJ5BHcK9GJHXsoGdD3vQeX8=.8cc5aba6-8bcb-42b3-82ee-5984cd479e8a@github.com>

On Fri, 18 Mar 2022 09:26:36 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.
> 
> Test:
> - [x] jdk_jfr
>   EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Tagged the JBS issue with jdk8u-fix-request.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From dongbohe at openjdk.java.net  Mon Mar 21 06:18:39 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 06:18:39 GMT
Subject: [jdk8u-dev] Integrated: 8194154: System property user.dir should not
 be changed
In-Reply-To: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
References: <eH0NvJiXhnqJXJR6FU0pdGaOPE70IxJcBum-G6vJTP4=.4cc9ba60-c00c-4a8b-a1a1-3263943402ae@github.com>
Message-ID: <7uqb_EU_OCboGBDthk5LU0Tr45JpzFFZX1aOIq_6HJI=.b7115bb7-6ee7-4aa0-8fbb-f7df3a007c27@github.com>

On Thu, 17 Mar 2022 09:04:07 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> Please review the backport of JDK-8194154 to 8u.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8194154
> Original commit: [http://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8](https://hg.openjdk.java.net/jdk/jdk/rev/847a988152b8)
> 8u webrev: https://cr.openjdk.java.net/~dongbohe/8194154/webrev.00/
> 
> Patch doesn't apply cleanly but is trivial, because JDK-8154231[1] and JDK-8155775[2] does not exist in 8,
> and some copyright year conflicts.
> 
> Testing: checked that added test fails without the patch and passes with the patch, tested with tier1.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8154231
> [2] https://bugs.openjdk.java.net/browse/JDK-8155775
> 
> Original RFR email: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014497.html
> 
> Thanks,
> hedongbo

This pull request has now been integrated.

Changeset: 5fcfb7ac
Author:    Dongbo He <dongbohe at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/5fcfb7acbe340c8347bd47413a36dd0b1e267dc1
Stats:     69 lines in 3 files changed: 65 ins; 0 del; 4 mod

8194154: System property user.dir should not be changed

Cached user.dir so getCanonicalPath uses the cached value.

Reviewed-by: sgehwolf
Backport-of: 4ea684bf31fc4e3cdee2ae51c0000a7b3e914151

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/8

From dongbohe at openjdk.java.net  Mon Mar 21 06:46:36 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 06:46:36 GMT
Subject: [jdk8u-dev] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
In-Reply-To: <XYwkEcOZQzAj1pJk9SBS6SO4GG90ETqkVbZaWlkM4ME=.530b79e3-d82f-40c3-a553-46ea1a5377f8@github.com>
References: <XYwkEcOZQzAj1pJk9SBS6SO4GG90ETqkVbZaWlkM4ME=.530b79e3-d82f-40c3-a553-46ea1a5377f8@github.com>
Message-ID: <x8VBYsBjf3o7aD4iKCIqt0NZEePazU45orWfoSI_W7U=.cad3fe7c-0d40-457d-9bf5-1b8a643346af@github.com>

On Thu, 17 Mar 2022 11:07:23 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This PR has been reviewed before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014487.html
> 
> Thanks,
> hedongbo

Hi,

Can I get another review from 8u reviewer?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/9

From dongbohe at openjdk.java.net  Mon Mar 21 06:57:13 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 06:57:13 GMT
Subject: [jdk8u-dev] RFR: 8235218: Minimal VM is broken after JDK-8173361
Message-ID: <rKZfPWwNN8FbdXjtnA6ZVOWkmpPo2e5Iaqs7G2qiYRQ=.b42361aa-1b70-4cc9-9c9c-3b23a803aa9c@github.com>

Hi,

I would like to backport this as follow up of [JDK-8173361](https://bugs.openjdk.java.net/browse/JDK-8173361), only a different context.

Thanks,
hedongbo

-------------

Depends on: https://git.openjdk.java.net/jdk8u-dev/pull/9

Commit messages:
 - Backport c10f731b11f314c97660df08c62f3c3d2f718f54

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/19/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=19&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8235218
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/19.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/19/head:pull/19

PR: https://git.openjdk.java.net/jdk8u-dev/pull/19

From sgehwolf at openjdk.java.net  Mon Mar 21 09:23:37 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Mon, 21 Mar 2022 09:23:37 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
 <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
 <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
Message-ID: <kTw6V5OpornjKwI0MRfbq2EZ_RfEQZFYZ0ZJQoWf0vU=.2623703c-468b-491d-8a50-8c5e774be886@github.com>

On Mon, 21 Mar 2022 04:00:04 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
>
>> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
> 
> done

@dongbohe Please add "Fix Request" comments to bugs you flag for approval. This one should get approved together with JDK-8223396.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Mon Mar 21 09:41:37 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Mon, 21 Mar 2022 09:41:37 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
 <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
 <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
Message-ID: <ZRJxx50v2ETHmL2RQ1UDLBF3ErVwHntsUWVETeUMz0I=.3e71a4bd-4202-4141-b19a-ddd84f91581c@github.com>

On Mon, 21 Mar 2022 04:00:04 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
>
>> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
> 
> done

> @dongbohe Please add "Fix Request" comments to bugs you flag for approval. This one should get approved together with JDK-8223396.

Thanks sgehwolf, flagged.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From sgehwolf at openjdk.java.net  Mon Mar 21 13:05:34 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Mon, 21 Mar 2022 13:05:34 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <ZRJxx50v2ETHmL2RQ1UDLBF3ErVwHntsUWVETeUMz0I=.3e71a4bd-4202-4141-b19a-ddd84f91581c@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
 <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
 <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
 <ZRJxx50v2ETHmL2RQ1UDLBF3ErVwHntsUWVETeUMz0I=.3e71a4bd-4202-4141-b19a-ddd84f91581c@github.com>
Message-ID: <LcadVMN2zm1kL9S7-9Cwqd3TKq25GQqbgCLoZ1uD7J8=.d64fbf4d-c53c-4539-86b4-4710ca08273a@github.com>

On Mon, 21 Mar 2022 09:38:29 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> > @dongbohe Please add "Fix Request" comments to bugs you flag for approval. This one should get approved together with JDK-8223396.
> 
> Thanks sgehwolf, flagged.

I actually meant a comment on the bugs with 'Fix Request (8u)' that you want approved for backporting (not just the label). Explain why this should get backported and what the risks are. What testing you've done and so on. See: https://openjdk.java.net/projects/jdk-updates/approval.html

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From andrew at openjdk.java.net  Mon Mar 21 19:42:34 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 21 Mar 2022 19:42:34 GMT
Subject: [jdk8u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean
 up files created in /tmp
In-Reply-To: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
References: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
Message-ID: <E8YXVhhgQxRRt3LyMGESdUIbeO4XJ43iK1T8sFXBHc4=.3a6aabe4-a0c5-4e2c-b87d-5447d45fd560@github.com>

On Fri, 18 Mar 2022 09:26:36 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.
> 
> Test:
> - [x] jdk_jfr
>   EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Note that the shuffle for `test/lib/jdk/test/lib/Utils.java` should really have been `jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java`. This is not a problem with this backport, but with the lack of correct path shuffling applied by the original JFR backport. We should migrate to the newer file generally to avoid duplication.

I've approved this bug.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From gnu.andrew at redhat.com  Mon Mar 21 20:55:54 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Mon, 21 Mar 2022 20:55:54 +0000
Subject: [8u] RFR: 8041523: Xerces Update: Serializer improvements from
 Xalan
In-Reply-To: <DM4PR11MB52453A76AAA5B99D510C1F13D1129@DM4PR11MB5245.namprd11.prod.outlook.com>
References: <DM4PR11MB52453A76AAA5B99D510C1F13D1129@DM4PR11MB5245.namprd11.prod.outlook.com>
Message-ID: <YjjmWk+ns6NM5HKN@hex.discworld.ac.uk>

On 18:21 Thu 17 Mar     , Ekaterina Vergizova wrote:
> Hello,
> I would like to backport JDK-8041523 to 8u. It should be included to monojdk8u as a critical fix.
> 
> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
> ?ffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8041523
> Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453
> Webrev for 8u: https://cr.openjdk.java.net/~apetushkov/8041523/webrev.00/
> 
> Original patch from jdk9 applies almost cleanly except for some copyright differences and imports reshuffling.
> 
> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.
> 
> Thanks,
> Ekaterina
> 

Thanks, this looks fine (as did the original 8u-dev version).

I've approved & pushed this to monojdk8u so it can make jdk8u322-b05.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From akasko at openjdk.java.net  Mon Mar 21 21:19:42 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Mon, 21 Mar 2022 21:19:42 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v4]
In-Reply-To: <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
 <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
Message-ID: <WtLro_o9Ke4yXNC9OBLXh6cK_YJyMNZ570V2H5HGG0k=.40fa0852-e969-464d-9a98-a9f6a4460172@github.com>

On Wed, 16 Mar 2022 17:05:04 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> Please review a backport of a JAXP cleanup.
>> 
>> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
>> 
>> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
>> 
>> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
>> 
>> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
>> 
>> Testing:
>> 
>>  - [x] jtreg:javax/xml/jaxp
>>  - [x] jck:api/javax_xml
>
> Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8129572: Cleanup usage of getResourceAsStream in jaxp
>   
>   Reviewed-by: alanb, joehw, mchung, redestad
>   Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

Thanks for the review! I've marked the issue for approval.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From akasko at openjdk.java.net  Mon Mar 21 21:21:33 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Mon, 21 Mar 2022 21:21:33 GMT
Subject: [jdk8u-dev] RFR: 8132256: jaxp: Investigate removal of
 com/sun/org/apache/bcel/internal/util/ClassPath.java
In-Reply-To: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
References: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
Message-ID: <pg7WWJnpzd2E3_cHTZUE0TaoLFpLa81VgMccjkhJ4Pk=.169b5539-85d0-47be-9750-6f3129427af1@github.com>

On Wed, 9 Mar 2022 21:23:12 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> Please review a backport of a JAXP cleanup.
> 
> Original commit [dcdbd67e6408](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/dcdbd67e6408) in jdk9.
> 
> Commit [6e586e8](https://github.com/openjdk/jdk11u-dev/commit/6e586e8a3b8807652218c4caf97ef501f42d7f36) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> Patch does not apply cleanly because in jdk9 ClassPath.java (that is deleted in this backport) was changed in [JDK-8049367](https://bugs.openjdk.java.net/browse/JDK-8049367) that is not in 8u.
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Thanks for the review! I've marked the issue for approval.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/5

From dongbohe at openjdk.java.net  Tue Mar 22 03:44:35 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Tue, 22 Mar 2022 03:44:35 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <ZRJxx50v2ETHmL2RQ1UDLBF3ErVwHntsUWVETeUMz0I=.3e71a4bd-4202-4141-b19a-ddd84f91581c@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
 <XcmLut94O3VVuSNdmSmg8xbFZsm414tmz7EPfZBc-uE=.2192a532-e7a3-45c5-ae9f-c6f9e3c96b5f@github.com>
 <Yqql95QnNp2ZZjl5q6P4cMMBFBR3XIl_7T39xD_LjnM=.9ee77c1e-0b32-4537-97d8-92001a221d96@github.com>
 <ZRJxx50v2ETHmL2RQ1UDLBF3ErVwHntsUWVETeUMz0I=.3e71a4bd-4202-4141-b19a-ddd84f91581c@github.com>
Message-ID: <lPPTls3cOZ6ABvdJWgXJcFOKcU_6ahA886oSmOJv4Rc=.022cfd5c-af38-43bc-8643-df7f20823d52@github.com>

On Mon, 21 Mar 2022 09:38:29 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>>> @dongbohe Please target this PR to merge into `pr/14` branch instead of `master`. I.e. mark this as a dependent PR. #14 needs to go in first anyway. See also https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
>> 
>> done
>
>> @dongbohe Please add "Fix Request" comments to bugs you flag for approval. This one should get approved together with JDK-8223396.
> 
> Thanks sgehwolf, flagged.

> > > @dongbohe Please add "Fix Request" comments to bugs you flag for approval. This one should get approved together with JDK-8223396.
> > 
> > 
> > Thanks sgehwolf, flagged.
> 
> I actually meant a comment on the bugs with 'Fix Request (8u)' that you want approved for backporting (not just the label). Explain why this should get backported and what the risks are. What testing you've done and so on. See: https://openjdk.java.net/projects/jdk-updates/approval.html

Thank you for your patient explanation, I've added a Fix Request (8u) comment on the bugs.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Tue Mar 22 03:50:39 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Tue, 22 Mar 2022 03:50:39 GMT
Subject: [jdk8u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean
 up files created in /tmp
In-Reply-To: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
References: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
Message-ID: <8DtVFl_Qzjji0LYth1Cxks-d5LjVrxR2PMG4Fy9KK9Q=.6b96816a-4eb1-4ed2-8c4a-6b47a26b5ff2@github.com>

On Fri, 18 Mar 2022 09:26:36 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.
> 
> Test:
> - [x] jdk_jfr
>   EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Thank you for your review, andrew.

Got the push approval

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From dongbohe at openjdk.java.net  Tue Mar 22 06:36:33 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Tue, 22 Mar 2022 06:36:33 GMT
Subject: [jdk8u-dev] Integrated: 8223396: [TESTBUG] several jfr tests do not
 clean up files created in /tmp
In-Reply-To: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
References: <cLVmqRq4qm3RqadR567t1P2_yCo67Wa1Qo0ie6DzvFU=.793a907b-852b-43ec-99bc-54f3891fbc80@github.com>
Message-ID: <xqrTIU7qriskx0lCmTVtywezrNyBpAg-Dj0xj45yXvk=.1c1b4a07-5470-4bc8-b53e-9d51838b713f@github.com>

On Fri, 18 Mar 2022 09:26:36 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> This is a clean backport of [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). I'm backporting this as a predecessor of PR #10.
> 
> Test:
> - [x] jdk_jfr
>   EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

This pull request has now been integrated.

Changeset: 25693fa8
Author:    Dongbo He <dongbohe at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/25693fa8c5dbdc23ead1c7d837050adb4af1b705
Stats:     56 lines in 11 files changed: 30 ins; 6 del; 20 mod

8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

Using test utils to create temp files and directories

Reviewed-by: andrew
Backport-of: 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/14

From duke at openjdk.java.net  Tue Mar 22 06:38:31 2022
From: duke at openjdk.java.net (openjdk-notifier[bot])
Date: Tue, 22 Mar 2022 06:38:31 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
Message-ID: <xQL5bGoCahqh89a-fqUybZlE2ZtdhV5e27ZT6Rkj7Y8=.4c15c5c9-1bc4-4e72-a9a7-3942ec9ec64f@github.com>

On Fri, 18 Mar 2022 09:45:38 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> I would like to backport this patch to fix test failure, introduced by JDK-8223396.
> 
> This is a clean backport on top of JDK-8223396 backport.
> 
> Test:
> - [x] jdk_jfr

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:


git checkout 8223396
git fetch https://git.openjdk.java.net/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Tue Mar 22 06:45:41 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Tue, 22 Mar 2022 06:45:41 GMT
Subject: [jdk8u-dev] RFR: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
Message-ID: <4Qx4ApPC3WhUgmNvqMcz8BlIAJmpTQ44KVZhOdrUHBc=.7315be37-2742-434c-afd8-ab1269235e68@github.com>

On Fri, 18 Mar 2022 09:45:38 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> I would like to backport this patch to fix test failure, introduced by JDK-8223396.
> 
> This is a clean backport on top of JDK-8223396 backport.
> 
> Test:
> - [x] jdk_jfr

Got the push approval.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From dongbohe at openjdk.java.net  Tue Mar 22 06:50:35 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Tue, 22 Mar 2022 06:50:35 GMT
Subject: [jdk8u-dev] Integrated: 8230865: [TESTBUG]
 jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
In-Reply-To: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
References: <F5CEzltqx0topuKjzVf11ykkOR6wx2rVXvahKyupyaE=.39351937-19f9-4abe-bd2e-0e28acbe6162@github.com>
Message-ID: <BkAJyC32zJK2qPAmsGJvRgClzj0J8BJ9EwNG5yOwwu0=.4c0d8de8-2052-47ca-8192-d0e98457520b@github.com>

On Fri, 18 Mar 2022 09:45:38 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> I would like to backport this patch to fix test failure, introduced by JDK-8223396.
> 
> This is a clean backport on top of JDK-8223396 backport.
> 
> Test:
> - [x] jdk_jfr

This pull request has now been integrated.

Changeset: 2bbec15b
Author:    Dongbo He <dongbohe at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/2bbec15b3e571b2b7ead4f7911f965f2b72c245a
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target

Prebuilding the test class before adding it into a jar file

Backport-of: 725da985e170d72c3ca3dc2dfbb3d7e083b5371a

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/16

From duke at openjdk.java.net  Tue Mar 22 07:09:55 2022
From: duke at openjdk.java.net (ktakakuri)
Date: Tue, 22 Mar 2022 07:09:55 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file is
 corrupted in Japanese locale
Message-ID: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>

This is a backport of JDK-8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale.

I would like to backport the patch to openjdk8u. 
Original patch does not apply cleanly to 8u.
Because the format of time zone in hs_err_pid log is different from 11u and later.
The following is the example of time zone info:
  jdk11:
     Time: Sat Mar 12 00:14:03 2022 Tokyo Standard Time elapsed time: 0 seconds (0d 0h 0m 0s)
  jdk8:
     time: Sat Mar 12 00:09:26 2022
     timezone: Tokyo Standard Time
     elapsed time: 2.736524 seconds (0d 0h 0m 2s)

Testing:
 build on Windows x86_64
 hotspot/runtime on Windows x86_64
 a specific test to confirm the fix in Japanese locale

Could you please review this PR?

-------------

Commit messages:
 - Backport e2f792c54919d3bb42901ed3c23e8c846db03852

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/20/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=20&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282051
  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/20/head:pull/20

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From phh at openjdk.java.net  Tue Mar 22 15:58:41 2022
From: phh at openjdk.java.net (Paul Hohensee)
Date: Tue, 22 Mar 2022 15:58:41 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
Message-ID: <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>

On Tue, 22 Mar 2022 07:04:16 GMT, ktakakuri <duke at openjdk.java.net> wrote:

> This is a backport of JDK-8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale.
> 
> I would like to backport the patch to openjdk8u. 
> Original patch does not apply cleanly to 8u.
> Because the format of time zone in hs_err_pid log is different from 11u and later.
> The following is the example of time zone info:
>   jdk11:
>      Time: Sat Mar 12 00:14:03 2022 Tokyo Standard Time elapsed time: 0 seconds (0d 0h 0m 0s)
>   jdk8:
>      time: Sat Mar 12 00:09:26 2022
>      timezone: Tokyo Standard Time
>      elapsed time: 2.736524 seconds (0d 0h 0m 2s)
> 
> Testing:
>  build on Windows x86_64
>  hotspot/runtime on Windows x86_64
>  a specific test to confirm the fix in Japanese locale
> 
> Could you please review this PR?

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From akasko at openjdk.java.net  Tue Mar 22 18:12:43 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Tue, 22 Mar 2022 18:12:43 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v4]
In-Reply-To: <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
 <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
Message-ID: <7VuDcenz2CSfJzg64xUx6Mza0L1_asvbiBR468sP0HQ=.f17308fb-dd4a-4105-92c9-3952a3c5dae6@github.com>

On Wed, 16 Mar 2022 17:05:04 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> Please review a backport of a JAXP cleanup.
>> 
>> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
>> 
>> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
>> 
>> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
>> 
>> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
>> 
>> Testing:
>> 
>>  - [x] jtreg:javax/xml/jaxp
>>  - [x] jck:api/javax_xml
>
> Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8129572: Cleanup usage of getResourceAsStream in jaxp
>   
>   Reviewed-by: alanb, joehw, mchung, redestad
>   Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

Thanks for the approval! Should this PR be somehow marked as "reviewed" or can I go forward and integrate it?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From andrew at openjdk.java.net  Tue Mar 22 19:01:47 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 22 Mar 2022 19:01:47 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
 <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>
Message-ID: <rV9K9egS5cgGdRuNPCsjbbWgtKPWr3NC_XXfPcFaVZM=.ca0c8044-df8d-477d-a590-7fb8b0b9d362@github.com>

On Tue, 22 Mar 2022 15:55:29 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From andrew at openjdk.java.net  Tue Mar 22 19:04:40 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 22 Mar 2022 19:04:40 GMT
Subject: [jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in
 jaxp [v4]
In-Reply-To: <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
 <-L6FshWkLx7J7tgTdoM5MV-bfKh1df_-4mSE48bmhxc=.981cc7d3-d9d9-481e-9034-4294856d8dfb@github.com>
Message-ID: <pRs2zmMbHjBd4udF2i8EFfhaslstbCxHff5ag1tHbnQ=.f01bbb10-d3fe-4889-909d-6bd2b8573cdc@github.com>

On Wed, 16 Mar 2022 17:05:04 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> Please review a backport of a JAXP cleanup.
>> 
>> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
>> 
>> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
>> 
>> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
>> 
>> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
>> 
>> Testing:
>> 
>>  - [x] jtreg:javax/xml/jaxp
>>  - [x] jck:api/javax_xml
>
> Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8129572: Cleanup usage of getResourceAsStream in jaxp
>   
>   Reviewed-by: alanb, joehw, mchung, redestad
>   Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

Marked as reviewed. I was holding off as SKARA doesn't yet check for `jdk8u-fix-yes` (see SKARA-1199)

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From andrew at openjdk.java.net  Tue Mar 22 19:08:42 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 22 Mar 2022 19:08:42 GMT
Subject: [jdk8u-dev] RFR: 8132256: jaxp: Investigate removal of
 com/sun/org/apache/bcel/internal/util/ClassPath.java
In-Reply-To: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
References: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
Message-ID: <g3rHbA-oL8wDmIiEAU89JDQTTeRtANQ_WWLB1BCluQU=.3409c42b-1cc7-40ce-a706-2107c054d686@github.com>

On Wed, 9 Mar 2022 21:23:12 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> Please review a backport of a JAXP cleanup.
> 
> Original commit [dcdbd67e6408](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/dcdbd67e6408) in jdk9.
> 
> Commit [6e586e8](https://github.com/openjdk/jdk11u-dev/commit/6e586e8a3b8807652218c4caf97ef501f42d7f36) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> Patch does not apply cleanly because in jdk9 ClassPath.java (that is deleted in this backport) was changed in [JDK-8049367](https://bugs.openjdk.java.net/browse/JDK-8049367) that is not in 8u.
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

Fix approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/5

From akasko at openjdk.java.net  Tue Mar 22 19:43:43 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Tue, 22 Mar 2022 19:43:43 GMT
Subject: [jdk8u-dev] Integrated: 8129572: Cleanup usage of getResourceAsStream
 in jaxp
In-Reply-To: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
References: <YxhGZ1SCclH1dPI0M0yAkAsLdO78VYfgZ58ohv-YF7s=.8ba63389-4595-45ff-9b45-afa5c70908fa@github.com>
Message-ID: <dHaM24FoUNd7xCVcEUredz-SPV50F7tYUc70ziMBcEo=.a50d321f-9738-416c-8c10-b59183aea928@github.com>

On Wed, 9 Mar 2022 21:11:48 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> Please review a backport of a JAXP cleanup.
> 
> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
> 
> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

This pull request has now been integrated.

Changeset: bb69732e
Author:    Alex Kasko <akasko at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/bb69732e30a2f7ba68438787d4820d43787c7244
Stats:     239 lines in 13 files changed: 0 ins; 229 del; 10 mod

8129572: Cleanup usage of getResourceAsStream in jaxp

Reviewed-by: andrew
Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4

From akasko at openjdk.java.net  Tue Mar 22 19:50:38 2022
From: akasko at openjdk.java.net (Alex Kasko)
Date: Tue, 22 Mar 2022 19:50:38 GMT
Subject: [jdk8u-dev] Integrated: 8132256: jaxp: Investigate removal of
 com/sun/org/apache/bcel/internal/util/ClassPath.java
In-Reply-To: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
References: <H8ukwdsqww51jx6T21SXxuG5ELRlmcyTay9756s_Vww=.d1e0d3f4-efec-4424-b187-75235d70316f@github.com>
Message-ID: <PmkRs9pBW0mTkt7RqMYi2dNmu7lc_V78lthbky0BSDA=.390da888-904a-4b0f-b802-730bf057d5aa@github.com>

On Wed, 9 Mar 2022 21:23:12 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> Please review a backport of a JAXP cleanup.
> 
> Original commit [dcdbd67e6408](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/dcdbd67e6408) in jdk9.
> 
> Commit [6e586e8](https://github.com/openjdk/jdk11u-dev/commit/6e586e8a3b8807652218c4caf97ef501f42d7f36) in jdk11u-dev.
> 
> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
> 
> Patch does not apply cleanly because in jdk9 ClassPath.java (that is deleted in this backport) was changed in [JDK-8049367](https://bugs.openjdk.java.net/browse/JDK-8049367) that is not in 8u.
> 
> Testing:
> 
>  - [x] jtreg:javax/xml/jaxp
>  - [x] jck:api/javax_xml

This pull request has now been integrated.

Changeset: 57d8d290
Author:    Alex Kasko <akasko at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/57d8d29080414dd038fffff1b97d97f3ab3f1570
Stats:     415 lines in 3 files changed: 1 ins; 410 del; 4 mod

8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java

Com/sun/org/apache/bcel/internal/util/ClassPath.java removed

Reviewed-by: andrew
Backport-of: 6e586e8a3b8807652218c4caf97ef501f42d7f36

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/5

From gnu.andrew at redhat.com  Wed Mar 23 20:13:59 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 23 Mar 2022 20:13:59 +0000
Subject: [Proposal] Maintainer Approvals and SKARA
Message-ID: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>

Hi all,

We have been discussing how to implement and/or adapt the current
approval process (jdk<x>-fix-request, jdk<x>-fix-yes, etc.) to SKARA
on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199

At present, we have been continuing to approve bugs for update
releases as we did in Mercurial; when the change is reviewed, the
proposer should flag it as jdk<>-fix-request (or
jdk<>-critical-request for a rampdown fix) and then an approver
responds with the *-yes or *-no response on the bug.

SKARA has introduced a new worry for me into this process, due to the
way the PR bot directs the user through the change process. This in
itself is a good thing. However, while it is currently not aware of
the approval process, it can encourage someone to integrate a change
which has not yet been approved. Hence why I feel some solution to
SKARA-1199 is quite critical (especially with the potential move of
the master 8u repository to SKARA) and it surprises me that other
update projects have not pushed harder for this, prior to 8u adopting
SKARA.

In thinking through how to implement this in SKARA, it occurred to me
that trying to continue with what we have now may not be the best
solution. The issues I see are:

1. Having the approval process in the bug database separate from the
proposed commit on GitHub creates a disconnect between the two.
We had this before, with the separation between mailing list activity
and the bug database, but now that pretty much everything else happens
in GitHub/SKARA, it feels odd to have to go back and forth between
JBS and GitHub to approve a change.

2. Access to add a label in JBS requires someone to have JDK authorship
status, so, for non-authors, someone else has to do this on their
behalf (as with sponsoring)

3. On the flip-side to #2, any JDK author can add jdk<x>-fix-yes or
jdk<x>-critical-yes to a bug, as I believe has happened in the past.

4. From a technical perspective, this means JBS has to be regularly
probed to pick up new labels. This also affects CSRs, which already
have issues in this area, and the demand for backports would be
much higher.

5. When we've dealt with backports which affect multiple bugs,
the informal process we've had in the past means we've been able
to choose whether to require that all bugs are flagged or not.
Having a formal version of the process we have now in SKARA would
mean having to label every referenced bug in something like [0].

My proposal would be that we shift approvals to SKARA in a similar
way to which sponsorship is currently handled:

1. When a PR for a backport project reaches the point at which
it would currently be integrated (after either /integrate for
a committer or /sponsor for a non-committer), it instead
gets an 'approval' label.

2. For the PR to move forward, an 'integrator' (someone capable
of merges & tags) [1] would need to perform '/approval [yes|no]' to
cause the change to either be integrated or rejected.

I believe this would simplify the implementation of this feature
a lot and also integrate it better into SKARA.

The bot could still label bugs with the jdk<x>-fix-request when
it adds the 'approval' label to the PR and with jdk<x>-fix-yes
and jdk<x>-fix-no when the /approval command is used.

The use of jdk<x>-fix-request or jdk<x>-critical-request can
also be pre-determined by the bot, based on the repository
the PR is against (jdk<x>u-dev for the former, jdk<x>u for the
latter).  This is something that would go in the server-side
bot configuration.

Thoughts?

I'm honestly struggling to see why we'd hold onto the existing
process, but I also realise that adaptation can be hard, particularly
for other update projects where SKARA has been in use longer.

[0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6
[1] https://bugs.openjdk.java.net/browse/SKARA-1384

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From gnu.andrew at redhat.com  Thu Mar 24 01:21:54 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 24 Mar 2022 01:21:54 +0000
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <b15d825e-b69a-7832-868f-0f1378762474@oracle.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <b15d825e-b69a-7832-868f-0f1378762474@oracle.com>
Message-ID: <YjvHsgeJ1iBrgg8n@hex.discworld.ac.uk>

On 14:13 Wed 23 Mar     , Kevin Rushforth wrote:
> Without discussing whether I think this is a better approach than the 
> existing label (it's certainly more work, and requires formalizing the 
> role an "approver" in Skara, but I'll let others comment on the relative 
> merits), I did want to comment on one aspect of your proposal. I don't 
> think that having another state *after* integrate is the best way to go. 
> Even if you don't use the bug database to record approvals, It seems 
> cleaner to make the approval an integration blocker in the same way that 
> the appropriate number of reviews, a matching title for the PR and bug, 
> etc., are integration blockers. That way once Skara says "ready" to 
> integrate, it really is.
> 
> So my recommendation is that, regardless of whether SKARA-1199 is 
> implemented via JBS labels or some other approval mechanism, the 
> "approval" label (or whatever it is called) is added initially when the 
> PR is created, and is an integration blocker. An "approver" can then 
> indicate approval, either in parallel with the review or after the 
> review is done (just like CSR reviews). Once both the review and the 
> approval are done, Skara would mark it as "ready".
> 
> -- Kevin
> 
> 

I don't have a strong issue with doing it that way instead. My initial
suggestion was based on how the sponsorship system works at present,
because this is essentially the same thing - block until someone else
gives the ok - and that is the time in the process when we would
currently approve changes.  For 8u, we've tended to ask people only to
add jdk8u-fix-request when the change has been reviewed and is
"ready".

I don't see how one would approve something that is not in its final
form, but there's certainly no reason to complicate things by making
it impossible to do so.

As to the role of approver, it would be those who are currently
maintainers for the update project. There is already a role in SKARA -
integrators - which I believe fits the bill and is already required to
tag commits and perform merges.

I'm not sure how you see this as "more work", as the existing task
of flagging the issue for approval would now be handled by the bot,
rather than the committer.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From serb at openjdk.java.net  Thu Mar 24 03:59:16 2022
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Thu, 24 Mar 2022 03:59:16 GMT
Subject: [jdk8u-dev] RFR: 8261107: ArrayIndexOutOfBoundsException in the
 ICC_Profile.getInstance(InputStream)
Message-ID: <B1ga2v1dh4btwF-HOyMgBpTHM7caIeUu5EiV3CGEG6E=.9db8d760-2817-49e5-b37a-8628dade6fca@github.com>

Hi all,
This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository.
The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan.

The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests.
To apply the patch I had to change the paths and some patch context. The changed lines are the same.

Thanks!

-------------

Commit messages:
 - Backport 06b33a0ad78d1577711af22020cf5fdf25112523

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/21/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=21&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261107
  Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/21.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/21/head:pull/21

PR: https://git.openjdk.java.net/jdk8u-dev/pull/21

From sakshipatil9300 at gmail.com  Sat Mar 12 14:45:33 2022
From: sakshipatil9300 at gmail.com (Sakshi Patil)
Date: Sat, 12 Mar 2022 20:15:33 +0530
Subject: rohanpatils1817@gmail.com
Message-ID: <CAONz19PE2W1k51sf-aP1zds-6ZD4e+nkuvSNgkznWt-hcUXkyg@mail.gmail.com>



From kevin.rushforth at oracle.com  Wed Mar 23 21:13:02 2022
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Wed, 23 Mar 2022 14:13:02 -0700
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
Message-ID: <b15d825e-b69a-7832-868f-0f1378762474@oracle.com>

Without discussing whether I think this is a better approach than the 
existing label (it's certainly more work, and requires formalizing the 
role an "approver" in Skara, but I'll let others comment on the relative 
merits), I did want to comment on one aspect of your proposal. I don't 
think that having another state *after* integrate is the best way to go. 
Even if you don't use the bug database to record approvals, It seems 
cleaner to make the approval an integration blocker in the same way that 
the appropriate number of reviews, a matching title for the PR and bug, 
etc., are integration blockers. That way once Skara says "ready" to 
integrate, it really is.

So my recommendation is that, regardless of whether SKARA-1199 is 
implemented via JBS labels or some other approval mechanism, the 
"approval" label (or whatever it is called) is added initially when the 
PR is created, and is an integration blocker. An "approver" can then 
indicate approval, either in parallel with the review or after the 
review is done (just like CSR reviews). Once both the review and the 
approval are done, Skara would mark it as "ready".

-- Kevin


On 3/23/2022 1:13 PM, Andrew Hughes wrote:
> Hi all,
>
> We have been discussing how to implement and/or adapt the current
> approval process (jdk<x>-fix-request, jdk<x>-fix-yes, etc.) to SKARA
> on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199
>
> At present, we have been continuing to approve bugs for update
> releases as we did in Mercurial; when the change is reviewed, the
> proposer should flag it as jdk<>-fix-request (or
> jdk<>-critical-request for a rampdown fix) and then an approver
> responds with the *-yes or *-no response on the bug.
>
> SKARA has introduced a new worry for me into this process, due to the
> way the PR bot directs the user through the change process. This in
> itself is a good thing. However, while it is currently not aware of
> the approval process, it can encourage someone to integrate a change
> which has not yet been approved. Hence why I feel some solution to
> SKARA-1199 is quite critical (especially with the potential move of
> the master 8u repository to SKARA) and it surprises me that other
> update projects have not pushed harder for this, prior to 8u adopting
> SKARA.
>
> In thinking through how to implement this in SKARA, it occurred to me
> that trying to continue with what we have now may not be the best
> solution. The issues I see are:
>
> 1. Having the approval process in the bug database separate from the
> proposed commit on GitHub creates a disconnect between the two.
> We had this before, with the separation between mailing list activity
> and the bug database, but now that pretty much everything else happens
> in GitHub/SKARA, it feels odd to have to go back and forth between
> JBS and GitHub to approve a change.
>
> 2. Access to add a label in JBS requires someone to have JDK authorship
> status, so, for non-authors, someone else has to do this on their
> behalf (as with sponsoring)
>
> 3. On the flip-side to #2, any JDK author can add jdk<x>-fix-yes or
> jdk<x>-critical-yes to a bug, as I believe has happened in the past.
>
> 4. From a technical perspective, this means JBS has to be regularly
> probed to pick up new labels. This also affects CSRs, which already
> have issues in this area, and the demand for backports would be
> much higher.
>
> 5. When we've dealt with backports which affect multiple bugs,
> the informal process we've had in the past means we've been able
> to choose whether to require that all bugs are flagged or not.
> Having a formal version of the process we have now in SKARA would
> mean having to label every referenced bug in something like [0].
>
> My proposal would be that we shift approvals to SKARA in a similar
> way to which sponsorship is currently handled:
>
> 1. When a PR for a backport project reaches the point at which
> it would currently be integrated (after either /integrate for
> a committer or /sponsor for a non-committer), it instead
> gets an 'approval' label.
>
> 2. For the PR to move forward, an 'integrator' (someone capable
> of merges & tags) [1] would need to perform '/approval [yes|no]' to
> cause the change to either be integrated or rejected.
>
> I believe this would simplify the implementation of this feature
> a lot and also integrate it better into SKARA.
>
> The bot could still label bugs with the jdk<x>-fix-request when
> it adds the 'approval' label to the PR and with jdk<x>-fix-yes
> and jdk<x>-fix-no when the /approval command is used.
>
> The use of jdk<x>-fix-request or jdk<x>-critical-request can
> also be pre-determined by the bot, based on the repository
> the PR is against (jdk<x>u-dev for the former, jdk<x>u for the
> latter).  This is something that would go in the server-side
> bot configuration.
>
> Thoughts?
>
> I'm honestly struggling to see why we'd hold onto the existing
> process, but I also realise that adaptation can be hard, particularly
> for other update projects where SKARA has been in use longer.
>
> [0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6
> [1] https://bugs.openjdk.java.net/browse/SKARA-1384
>
> Thanks,


From kevin.rushforth at oracle.com  Thu Mar 24 12:07:13 2022
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Thu, 24 Mar 2022 05:07:13 -0700
Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <YjvHsgeJ1iBrgg8n@hex.discworld.ac.uk>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <b15d825e-b69a-7832-868f-0f1378762474@oracle.com>
 <YjvHsgeJ1iBrgg8n@hex.discworld.ac.uk>
Message-ID: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com>


> I'm not sure how you see this as "more work", as the existing task
> of flagging the issue for approval would now be handled by the bot,
> rather than the committer.

I meant more work in Skara to develop and implement this new feature 
(although Erik could confirm whether my assessment is accurate). I can 
see some advantages for the maintainers, but we need to balance to 
potential benefit against the cost to implement.

-- Kevin


On 3/23/2022 6:21 PM, Andrew Hughes wrote:
> On 14:13 Wed 23 Mar     , Kevin Rushforth wrote:
>> Without discussing whether I think this is a better approach than the
>> existing label (it's certainly more work, and requires formalizing the
>> role an "approver" in Skara, but I'll let others comment on the relative
>> merits), I did want to comment on one aspect of your proposal. I don't
>> think that having another state *after* integrate is the best way to go.
>> Even if you don't use the bug database to record approvals, It seems
>> cleaner to make the approval an integration blocker in the same way that
>> the appropriate number of reviews, a matching title for the PR and bug,
>> etc., are integration blockers. That way once Skara says "ready" to
>> integrate, it really is.
>>
>> So my recommendation is that, regardless of whether SKARA-1199 is
>> implemented via JBS labels or some other approval mechanism, the
>> "approval" label (or whatever it is called) is added initially when the
>> PR is created, and is an integration blocker. An "approver" can then
>> indicate approval, either in parallel with the review or after the
>> review is done (just like CSR reviews). Once both the review and the
>> approval are done, Skara would mark it as "ready".
>>
>> -- Kevin
>>
>>
> I don't have a strong issue with doing it that way instead. My initial
> suggestion was based on how the sponsorship system works at present,
> because this is essentially the same thing - block until someone else
> gives the ok - and that is the time in the process when we would
> currently approve changes.  For 8u, we've tended to ask people only to
> add jdk8u-fix-request when the change has been reviewed and is
> "ready".
>
> I don't see how one would approve something that is not in its final
> form, but there's certainly no reason to complicate things by making
> it impossible to do so.
>
> As to the role of approver, it would be those who are currently
> maintainers for the update project. There is already a role in SKARA -
> integrators - which I believe fits the bill and is already required to
> tag commits and perform merges.
>
> I'm not sure how you see this as "more work", as the existing task
> of flagging the issue for approval would now be handled by the bot,
> rather than the committer.
>
> Thanks,


From sgehwolf at redhat.com  Thu Mar 24 13:05:43 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Thu, 24 Mar 2022 14:05:43 +0100
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
Message-ID: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com>

On Wed, 2022-03-23 at 20:13 +0000, Andrew Hughes wrote:
> 
> Hi all,
> 
> We have been discussing how to implement and/or adapt the current
> approval process (jdk<x>-fix-request, jdk<x>-fix-yes, etc.) to SKARA
> on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199
> 
> At present, we have been continuing to approve bugs for update
> releases as we did in Mercurial; when the change is reviewed, the
> proposer should flag it as jdk<>-fix-request (or
> jdk<>-critical-request for a rampdown fix) and then an approver
> responds with the *-yes or *-no response on the bug.
> 
> SKARA has introduced a new worry for me into this process, due to the
> way the PR bot directs the user through the change process. This in
> itself is a good thing. However, while it is currently not aware of
> the approval process, it can encourage someone to integrate a change
> which has not yet been approved. Hence why I feel some solution to
> SKARA-1199 is quite critical (especially with the potential move of
> the master 8u repository to SKARA) and it surprises me that other
> update projects have not pushed harder for this, prior to 8u adopting
> SKARA.
> 
> In thinking through how to implement this in SKARA, it occurred to me
> that trying to continue with what we have now may not be the best
> solution. The issues I see are:
> 
> 1. Having the approval process in the bug database separate from the
> proposed commit on GitHub creates a disconnect between the two.
> We had this before, with the separation between mailing list activity
> and the bug database, but now that pretty much everything else
> happens in GitHub/SKARA, it feels odd to have to go back and forth
> between JBS and GitHub to approve a change.



> 2. Access to add a label in JBS requires someone to have JDK
> authorship
> status, so, for non-authors, someone else has to do this on their
> behalf (as with sponsoring)
> 
> 3. On the flip-side to #2, any JDK author can add jdk<x>-fix-yes or
> jdk<x>-critical-yes to a bug, as I believe has happened in the past.
> 
> 4. From a technical perspective, this means JBS has to be regularly
> probed to pick up new labels. This also affects CSRs, which already
> have issues in this area, and the demand for backports would be
> much higher.
> 
> 5. When we've dealt with backports which affect multiple bugs,
> the informal process we've had in the past means we've been able
> to choose whether to require that all bugs are flagged or not.
> Having a formal version of the process we have now in SKARA would
> mean having to label every referenced bug in something like [0].
> 
> My proposal would be that we shift approvals to SKARA in a similar
> way to which sponsorship is currently handled:
> 
> 1. When a PR for a backport project reaches the point at which
> it would currently be integrated (after either /integrate for
> a committer or /sponsor for a non-committer), it instead
> gets an 'approval' label.
> 
> 2. For the PR to move forward, an 'integrator' (someone capable
> of merges & tags) [1] would need to perform '/approval [yes|no]' to
> cause the change to either be integrated or rejected.
> 
> I believe this would simplify the implementation of this feature
> a lot and also integrate it better into SKARA.
> 
> The bot could still label bugs with the jdk<x>-fix-request when
> it adds the 'approval' label to the PR and with jdk<x>-fix-yes
> and jdk<x>-fix-no when the /approval command is used.
> 
> The use of jdk<x>-fix-request or jdk<x>-critical-request can
> also be pre-determined by the bot, based on the repository
> the PR is against (jdk<x>u-dev for the former, jdk<x>u for the
> latter).? This is something that would go in the server-side
> bot configuration.
> 
> Thoughts?

My worry would be that "Fix Request" comments would be spread across
different PRs if a single bug gets backported to, many update releases.
JDK 18u, 17u, 11u and 8u, for example. It would move the "approval"
conversation to the source control system (and per backport PR) rather
than the bug database. From a maintenance perspective it makes sense to
have all the info related to backports in one place (on the bug). If
something gets requested for 8u, say, I can see immediately in the bug
database that it has been backported to later releases too and can see
the approval flags (and who approved it). Moving this to skare makes
the info much more dispersed.

Besides, we've had the issue of update project committers being able to
integrate without formal approval in JBS before. It's only much more
visible now (which is a good thing). I.e. the problem doesn't change
with Skara. The difference really is bot guidance. In general, the
process is fairly well understood and I don't anticipate this to be a
huge problem in practise.

Thanks,
Severin

> I'm honestly struggling to see why we'd hold onto the existing
> process, but I also realise that adaptation can be hard, particularly
> for other update projects where SKARA has been in use longer.
> 
> [0]
> https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b9593=
> 3aa35eac6
> [1] https://bugs.openjdk.java.net/browse/SKARA-1384
> 
> Thanks,
> --=20
> Andrew :)
> Pronouns: he / him or they / them
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint =3D 5132 579D D154 0ED2 3E04? C5A0 CFDA 0F9B 3596 4222
> 
> --X28JfW0BSfKBk7hD--
> 


From zgu at redhat.com  Thu Mar 24 13:23:07 2022
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 24 Mar 2022 09:23:07 -0400
Subject: [Gentle Ping?][8u] RFR: 8260589: Crash in
 JfrTraceIdLoadBarrier::load(_jclass*)
In-Reply-To: <CAJwKKmbf0kQn-rtXByH4B8Hz9vzOnkTL8XO=rTuDPn13AXR=SA@mail.gmail.com>
References: <c37456a6-27cc-4e4f-bce7-6ae09044e06f.yibo.yl@alibaba-inc.com>
 <CAJwKKmbf0kQn-rtXByH4B8Hz9vzOnkTL8XO=rTuDPn13AXR=SA@mail.gmail.com>
Message-ID: <18a42a7c-3e15-0501-0713-02f202493a3d@redhat.com>

Looks good to me.

Thanks,

-Zhengyu

> 
> Hi,
> 
> I would appreciate it if you could review the backport of JDK-8260589 to 8u.
> This crash problem is very easy to reproduce, so I feel it is
> necessary to backport it to 8u.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8260589
> 11u commit: https://github.com/openjdk/jdk11u-dev/commit/1d204c554ffe969567161cc05992486ff47d346d
> 8u webrev: https://cr.openjdk.java.net/~ddong/8260589/webrev.00
> Test: jdk/test/jdk/jfr/jvm/TestPrimitiveClasses.java passed.
> 
> Due to the differences between JFR in 11u and 17, Denghui made some
> changes when backporting this fix to 11u.
> Denghui's changes also apply to 8u, so I directly quote Denghui's list
> here. (4 in total)
> 1. use MaxJfrEventId + 101 instead of LAST_TYPE_ID + 1 as the klass id
> of void.class
> 2. jdk 11 doesn't support jfr streaming, so I removed the call
> `JfrTraceIdEpoch::set_changed_tag_state()` in `load_primitive`
> 3. the Class in jdk 11 doesn't have the field 'hidden', so I removed
> `writer->write<bool>(false);` in `write_primitive`
> 4. there are many differences in the API of JfrTraceId between 11u and tip
> 
> In addition to the above differences, I also make supplementary
> explanations for the modifications I made.
> 1. The static global variable clear_artifacts in 11u was introduced by
> the bugfix https://bugs.openjdk.java.net/browse/JDK-8231081, but this
> fix has not been backported to 8u, so I removed the code related to
> clear_artifacts. In 8u, the metadata of the primitive types will be
> written into the previous chunk on every chunk rotation.
> 2. In 11u, _artifacts and _class_unload are static global variables,
> but in 8u, they are static member variables of JfrTypeSet, so I also
> made necessary changes to the functions that use these two variables.
> 
> Thanks,
> Long Yang
> 
> 
> 


From erik.joelsson at oracle.com  Thu Mar 24 14:01:53 2022
From: erik.joelsson at oracle.com (erik.joelsson at oracle.com)
Date: Thu, 24 Mar 2022 07:01:53 -0700
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
Message-ID: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>

Hello,

I agree that solving SKARA-1199 would provide quite a bit of benefit to 
the update releases. The current process works, but it requires 
knowledge and manual care to not make mistakes. One of the main ideas 
with Skara was to codify our processes to make them more foolproof and 
easy to follow. I definitely think this approval process fits the bill 
as something we should support better with tooling.

Breaking apart the problem a bit, from the perspective of a user 
developing a fix for an update release that requires approval, I agree 
with Kevin that the current state of the approval should be reflected as 
a "progress" on the PR. That makes it very clear if the PR is ready for 
integration or not and fits in with how Skara tracks and treats other 
integration blockers. Basing this functionality around the model of the 
/sponsor command would be a pretty major shift in my opinion. It moves 
the ability to actually integrate, and as such the control of the 
timing, from the contributor to the integrator. This mimics how some 
other big open source projects handle things (e.g. the Linux kernel). I 
think it makes sense to do this when sponsoring, because we are then 
helping new and inexperienced (in OpenJDK processes at least) users, 
which helps prevent mistakes. For contributors of committer status or 
above, I think we should retain their ability to control the timing of 
integration. Implementation wise, I don't think it makes a big difference.

The other part of the problem, which I think is what this discussion 
should really focus on, is where the official approval takes place. We 
can keep it in JBS like today, or we can move it to the PR, as suggested 
by Andrew. From an implementation point of view, moving it to the PR is 
less work, but I don't think we should base this decision on process on 
if it takes an extra day to implement. The tooling should support the 
process we want.

Without having spent a lot of time thinking about it so please tell me 
if I'm missing something, would it be possible to support a hybrid/dual 
solution? The official process could still be the labels in the JBS 
issues, but the Skara 'integrator'-only /approve command on a PR could 
also add the appropriate *-fix-yes label to all associated bugs. There 
would also be a Skara bot monitoring JBS and automatically updating the 
approval status on PRs based on labels in JBS. This would shortcut the 
process for integrators that prefer working through PRs, while 
integrators that prefer to work through JBS can continue the same way as 
before. I think this should alleviate the issue of backporting many bugs 
with one PR. This is of course also the biggest change to implement, but 
not that much more than what I had already outlined in SKARA-1199.

/Erik


On 2022-03-23 13:13, Andrew Hughes wrote:
> Hi all,
>
> We have been discussing how to implement and/or adapt the current
> approval process (jdk<x>-fix-request, jdk<x>-fix-yes, etc.) to SKARA
> on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199
>
> At present, we have been continuing to approve bugs for update
> releases as we did in Mercurial; when the change is reviewed, the
> proposer should flag it as jdk<>-fix-request (or
> jdk<>-critical-request for a rampdown fix) and then an approver
> responds with the *-yes or *-no response on the bug.
>
> SKARA has introduced a new worry for me into this process, due to the
> way the PR bot directs the user through the change process. This in
> itself is a good thing. However, while it is currently not aware of
> the approval process, it can encourage someone to integrate a change
> which has not yet been approved. Hence why I feel some solution to
> SKARA-1199 is quite critical (especially with the potential move of
> the master 8u repository to SKARA) and it surprises me that other
> update projects have not pushed harder for this, prior to 8u adopting
> SKARA.
>
> In thinking through how to implement this in SKARA, it occurred to me
> that trying to continue with what we have now may not be the best
> solution. The issues I see are:
>
> 1. Having the approval process in the bug database separate from the
> proposed commit on GitHub creates a disconnect between the two.
> We had this before, with the separation between mailing list activity
> and the bug database, but now that pretty much everything else happens
> in GitHub/SKARA, it feels odd to have to go back and forth between
> JBS and GitHub to approve a change.
>
> 2. Access to add a label in JBS requires someone to have JDK authorship
> status, so, for non-authors, someone else has to do this on their
> behalf (as with sponsoring)
>
> 3. On the flip-side to #2, any JDK author can add jdk<x>-fix-yes or
> jdk<x>-critical-yes to a bug, as I believe has happened in the past.
>
> 4. From a technical perspective, this means JBS has to be regularly
> probed to pick up new labels. This also affects CSRs, which already
> have issues in this area, and the demand for backports would be
> much higher.
>
> 5. When we've dealt with backports which affect multiple bugs,
> the informal process we've had in the past means we've been able
> to choose whether to require that all bugs are flagged or not.
> Having a formal version of the process we have now in SKARA would
> mean having to label every referenced bug in something like [0].
>
> My proposal would be that we shift approvals to SKARA in a similar
> way to which sponsorship is currently handled:
>
> 1. When a PR for a backport project reaches the point at which
> it would currently be integrated (after either /integrate for
> a committer or /sponsor for a non-committer), it instead
> gets an 'approval' label.
>
> 2. For the PR to move forward, an 'integrator' (someone capable
> of merges & tags) [1] would need to perform '/approval [yes|no]' to
> cause the change to either be integrated or rejected.
>
> I believe this would simplify the implementation of this feature
> a lot and also integrate it better into SKARA.
>
> The bot could still label bugs with the jdk<x>-fix-request when
> it adds the 'approval' label to the PR and with jdk<x>-fix-yes
> and jdk<x>-fix-no when the /approval command is used.
>
> The use of jdk<x>-fix-request or jdk<x>-critical-request can
> also be pre-determined by the bot, based on the repository
> the PR is against (jdk<x>u-dev for the former, jdk<x>u for the
> latter).  This is something that would go in the server-side
> bot configuration.
>
> Thoughts?
>
> I'm honestly struggling to see why we'd hold onto the existing
> process, but I also realise that adaptation can be hard, particularly
> for other update projects where SKARA has been in use longer.
>
> [0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6
> [1] https://bugs.openjdk.java.net/browse/SKARA-1384
>
> Thanks,

From christoph.langer at sap.com  Thu Mar 24 16:46:21 2022
From: christoph.langer at sap.com (Langer, Christoph)
Date: Thu, 24 Mar 2022 16:46:21 +0000
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
Message-ID: <PAXPR02MB779955CB442A6880AB8B1F1A8A199@PAXPR02MB7799.eurprd02.prod.outlook.com>

Hi Erik, all,

I completely second both points:

1. The fact that the maintainer/approval process could be improved from a tooling perspective and
2. In the end, the information has to be persisted in JBS.

I very much like your analysis, Erik, and I think I would welcome a hybrid solution.
So there should still be the labels and request like we have now. A missing approval label should be an integration blocker in the PR. And if we'd in the end get some commands, like /approve which only maintainers are allowed to issue and /request-approval <comment> which adds the request to JBS, also enabling non JBS users to request approval, it would greatly help.

Thanks & Best regards
Christoph


> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> On Behalf Of
> erik.joelsson at oracle.com
> Sent: Donnerstag, 24. M?rz 2022 15:02
> To: Andrew Hughes <gnu.andrew at redhat.com>; jdk8u-dev at openjdk.java.net;
> jdk-updates-dev at openjdk.java.net
> Subject: Re: [Proposal] Maintainer Approvals and SKARA
> 
> Hello,
> 
> I agree that solving SKARA-1199 would provide quite a bit of benefit to the
> update releases. The current process works, but it requires knowledge and
> manual care to not make mistakes. One of the main ideas with Skara was to
> codify our processes to make them more foolproof and easy to follow. I
> definitely think this approval process fits the bill as something we should
> support better with tooling.
> 
> Breaking apart the problem a bit, from the perspective of a user developing a
> fix for an update release that requires approval, I agree with Kevin that the
> current state of the approval should be reflected as a "progress" on the PR.
> That makes it very clear if the PR is ready for integration or not and fits in with
> how Skara tracks and treats other integration blockers. Basing this functionality
> around the model of the /sponsor command would be a pretty major shift in
> my opinion. It moves the ability to actually integrate, and as such the control of
> the timing, from the contributor to the integrator. This mimics how some other
> big open source projects handle things (e.g. the Linux kernel). I think it makes
> sense to do this when sponsoring, because we are then helping new and
> inexperienced (in OpenJDK processes at least) users, which helps prevent
> mistakes. For contributors of committer status or above, I think we should
> retain their ability to control the timing of integration. Implementation wise, I
> don't think it makes a big difference.
> 
> The other part of the problem, which I think is what this discussion should
> really focus on, is where the official approval takes place. We can keep it in JBS
> like today, or we can move it to the PR, as suggested by Andrew. From an
> implementation point of view, moving it to the PR is less work, but I don't think
> we should base this decision on process on if it takes an extra day to
> implement. The tooling should support the process we want.
> 
> Without having spent a lot of time thinking about it so please tell me if I'm
> missing something, would it be possible to support a hybrid/dual solution? The
> official process could still be the labels in the JBS issues, but the Skara
> 'integrator'-only /approve command on a PR could also add the appropriate *-
> fix-yes label to all associated bugs. There would also be a Skara bot monitoring
> JBS and automatically updating the approval status on PRs based on labels in
> JBS. This would shortcut the process for integrators that prefer working
> through PRs, while integrators that prefer to work through JBS can continue
> the same way as before. I think this should alleviate the issue of backporting
> many bugs with one PR. This is of course also the biggest change to implement,
> but not that much more than what I had already outlined in SKARA-1199.
> 
> /Erik
> 
> 
> On 2022-03-23 13:13, Andrew Hughes wrote:
> > Hi all,
> >
> > We have been discussing how to implement and/or adapt the current
> > approval process (jdk<x>-fix-request, jdk<x>-fix-yes, etc.) to SKARA
> > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199
> >
> > At present, we have been continuing to approve bugs for update
> > releases as we did in Mercurial; when the change is reviewed, the
> > proposer should flag it as jdk<>-fix-request (or
> > jdk<>-critical-request for a rampdown fix) and then an approver
> > responds with the *-yes or *-no response on the bug.
> >
> > SKARA has introduced a new worry for me into this process, due to the
> > way the PR bot directs the user through the change process. This in
> > itself is a good thing. However, while it is currently not aware of
> > the approval process, it can encourage someone to integrate a change
> > which has not yet been approved. Hence why I feel some solution to
> > SKARA-1199 is quite critical (especially with the potential move of
> > the master 8u repository to SKARA) and it surprises me that other
> > update projects have not pushed harder for this, prior to 8u adopting
> > SKARA.
> >
> > In thinking through how to implement this in SKARA, it occurred to me
> > that trying to continue with what we have now may not be the best
> > solution. The issues I see are:
> >
> > 1. Having the approval process in the bug database separate from the
> > proposed commit on GitHub creates a disconnect between the two.
> > We had this before, with the separation between mailing list activity
> > and the bug database, but now that pretty much everything else happens
> > in GitHub/SKARA, it feels odd to have to go back and forth between JBS
> > and GitHub to approve a change.
> >
> > 2. Access to add a label in JBS requires someone to have JDK
> > authorship status, so, for non-authors, someone else has to do this on
> > their behalf (as with sponsoring)
> >
> > 3. On the flip-side to #2, any JDK author can add jdk<x>-fix-yes or
> > jdk<x>-critical-yes to a bug, as I believe has happened in the past.
> >
> > 4. From a technical perspective, this means JBS has to be regularly
> > probed to pick up new labels. This also affects CSRs, which already
> > have issues in this area, and the demand for backports would be much
> > higher.
> >
> > 5. When we've dealt with backports which affect multiple bugs, the
> > informal process we've had in the past means we've been able to choose
> > whether to require that all bugs are flagged or not.
> > Having a formal version of the process we have now in SKARA would mean
> > having to label every referenced bug in something like [0].
> >
> > My proposal would be that we shift approvals to SKARA in a similar way
> > to which sponsorship is currently handled:
> >
> > 1. When a PR for a backport project reaches the point at which it
> > would currently be integrated (after either /integrate for a committer
> > or /sponsor for a non-committer), it instead gets an 'approval' label.
> >
> > 2. For the PR to move forward, an 'integrator' (someone capable of
> > merges & tags) [1] would need to perform '/approval [yes|no]' to cause
> > the change to either be integrated or rejected.
> >
> > I believe this would simplify the implementation of this feature a lot
> > and also integrate it better into SKARA.
> >
> > The bot could still label bugs with the jdk<x>-fix-request when it
> > adds the 'approval' label to the PR and with jdk<x>-fix-yes and
> > jdk<x>-fix-no when the /approval command is used.
> >
> > The use of jdk<x>-fix-request or jdk<x>-critical-request can also be
> > pre-determined by the bot, based on the repository the PR is against
> > (jdk<x>u-dev for the former, jdk<x>u for the latter).  This is
> > something that would go in the server-side bot configuration.
> >
> > Thoughts?
> >
> > I'm honestly struggling to see why we'd hold onto the existing
> > process, but I also realise that adaptation can be hard, particularly
> > for other update projects where SKARA has been in use longer.
> >
> > [0]
> >
> https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95
> 9
> > 33aa35eac6 [1] https://bugs.openjdk.java.net/browse/SKARA-1384
> >
> > Thanks,

From dongbohe at openjdk.java.net  Fri Mar 25 06:16:12 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 25 Mar 2022 06:16:12 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is
 unstable [v2]
In-Reply-To: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
References: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
Message-ID: <DpJNVwenZ6AWxurqfSUYK74msJZZnidY57P9No7ysoo=.1b387492-fff3-46e3-9e0d-4c68a0242737@github.com>

> Hi,
> 
> This PR has been reviewed by Paul before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014489.html
> 
> Thanks,
> hedongbo

Dongbo He has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge master
 - 8202142: jfr/event/io/TestInstrumentation is unstable
   
   Backport-of: 0b9ff0c3a418070996f61f69165de02d33070f7f

-------------

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/10/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=10&range=01
  Stats: 412 lines in 11 files changed: 51 ins; 37 del; 324 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/10.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/10/head:pull/10

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From dongbohe at openjdk.java.net  Fri Mar 25 06:45:53 2022
From: dongbohe at openjdk.java.net (Dongbo He)
Date: Fri, 25 Mar 2022 06:45:53 GMT
Subject: [jdk8u-dev] RFR: 8202142: jfr/event/io/TestInstrumentation is
 unstable
In-Reply-To: <M7EAwX5jJZCOfm3j-sZ0B0Nh0UbFLuXkNguZjSZzzMw=.1f8b0dbf-bdf3-4f4f-a7d2-3b0dcd27f668@github.com>
References: <i99997MY_arGM_fjApfVzdmaew4SgkesOguSNb42mwE=.e9ce1b49-3f94-45fb-a68c-6d71f60002d8@github.com>
 <QekQtfc-1woi7LRM-mI5O-Pff5zYGEpTkKpLGHhPiv8=.37232abb-090d-45ee-9426-42eeaf0ee5d5@github.com>
 <M7EAwX5jJZCOfm3j-sZ0B0Nh0UbFLuXkNguZjSZzzMw=.1f8b0dbf-bdf3-4f4f-a7d2-3b0dcd27f668@github.com>
Message-ID: <U-Mz-P_7cuqKkPzg6d3BBiKKIi5fEqsytq7Nf7e-w_M=.3840e445-ef03-419b-aaff-32b0b59c3361@github.com>

On Fri, 18 Mar 2022 09:50:00 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> I think should backport [8223396](https://bugs.openjdk.java.net/browse/JDK-8223396) first to eliminate another out-of-order backport.

Hi, Zhengyu

[8223396](https://bugs.openjdk.java.net/browse/JDK-8223396) has been merged into 8u in #14, can you help me look at this again?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/10

From yyang at openjdk.java.net  Fri Mar 25 07:10:13 2022
From: yyang at openjdk.java.net (Yi Yang)
Date: Fri, 25 Mar 2022 07:10:13 GMT
Subject: [jdk8u-dev] RFR: 8283672: Cleanup: Remove some unused flags/code in
 loop optimizations
Message-ID: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>

We encountered this problem in downstream JDK. This is a backport of JDK-8283672, which simply removes several diagnostic flags, build passed. There is a related fix https://bugs.openjdk.java.net/browse/JDK-8159715, I would backport it after the current fix merged.

Original changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a1e41855499b

Please help review it.

Thanks.

-------------

Commit messages:
 - 8283672: Cleanup: Remove some unused flags/code in loop optimizations

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/22/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=22&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8283672
  Stats: 406 lines in 7 files changed: 49 ins; 241 del; 116 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/22.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/22/head:pull/22

PR: https://git.openjdk.java.net/jdk8u-dev/pull/22

From yyang at openjdk.java.net  Fri Mar 25 07:17:26 2022
From: yyang at openjdk.java.net (Yi Yang)
Date: Fri, 25 Mar 2022 07:17:26 GMT
Subject: [jdk8u-dev] RFR: 8072422: Cleanup: Remove some unused flags/code
 in loop optimizations [v2]
In-Reply-To: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>
References: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>
Message-ID: <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>

> We encountered this problem in downstream JDK. This is a backport of JDK-8283672, which simply removes several diagnostic flags, build passed. There is a related fix https://bugs.openjdk.java.net/browse/JDK-8159715, I would backport it after the current fix merged.
> 
> Original changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a1e41855499b
> 
> Please help review it.
> 
> Thanks.

Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8072422: Cleanup: Remove some unused flags/code in loop optimizations

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/22/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/22/files/4b4adcd6..11338be2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=22&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=22&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/22.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/22/head:pull/22

PR: https://git.openjdk.java.net/jdk8u-dev/pull/22

From sgehwolf at openjdk.java.net  Fri Mar 25 09:58:54 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Fri, 25 Mar 2022 09:58:54 GMT
Subject: [jdk8u-dev] RFR: 8072422: Cleanup: Remove some unused flags/code
 in loop optimizations [v2]
In-Reply-To: <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>
References: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>
 <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>
Message-ID: <h-Mg7bk3xgK_SfPng1giARNAJ1SXvxwoQSygOKZr8Gk=.1cfbad3e-4458-464c-9f06-3c0354bb8038@github.com>

On Fri, 25 Mar 2022 07:17:26 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> We encountered this problem in downstream JDK. This is a backport of JDK-8283672, which simply removes several diagnostic flags, build passed. There is a related fix https://bugs.openjdk.java.net/browse/JDK-8159715, I would backport it after the current fix merged.
>> 
>> Original changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a1e41855499b
>> 
>> Please help review it.
>> 
>> Thanks.
>
> Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8072422: Cleanup: Remove some unused flags/code in loop optimizations

@kelthuzadx Skara tooling doesn't recognize this as a backport. Please use pull request title `Backport <sha-of-original-commit>` which should then let the bots do it's thing and figure out it's a backport and change the title back to the right bug description.

With that said, what are you trying to do? Looking at both bugs it sounds like if we don't introduce [JDK-8072422](https://bugs.openjdk.java.net/browse/JDK-8072422), then [JDK-8159715](https://bugs.openjdk.java.net/browse/JDK-8159715) won't be an issue? If you are seeing an issue, without it I strongly encourage you to bring in the fix *without* the cleanup patch.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/22

From yyang at openjdk.java.net  Fri Mar 25 10:11:02 2022
From: yyang at openjdk.java.net (Yi Yang)
Date: Fri, 25 Mar 2022 10:11:02 GMT
Subject: [jdk8u-dev] RFR: 8072422: Cleanup: Remove some unused flags/code
 in loop optimizations [v2]
In-Reply-To: <h-Mg7bk3xgK_SfPng1giARNAJ1SXvxwoQSygOKZr8Gk=.1cfbad3e-4458-464c-9f06-3c0354bb8038@github.com>
References: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>
 <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>
 <h-Mg7bk3xgK_SfPng1giARNAJ1SXvxwoQSygOKZr8Gk=.1cfbad3e-4458-464c-9f06-3c0354bb8038@github.com>
Message-ID: <sSyIfggdzLpC_9FF-s4aoFX1jrB3OM1nhsqmXs7-oKM=.c78b2224-d2a4-4172-9f29-deb860c42365@github.com>

On Fri, 25 Mar 2022 09:55:11 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please use pull request title `Backport <sha-of-original-commit>` which should then let the bots do it's thing and figure out it's a backport and change the title back to the right bug description.

Thanks, I will do that.

> With that said, what are you trying to do? Looking at both bugs it sounds like if we don't introduce [JDK-8072422](https://bugs.openjdk.java.net/browse/JDK-8072422), then [JDK-8159715](https://bugs.openjdk.java.net/browse/JDK-8159715) won't be an issue? If you are seeing an issue, without it I strongly encourage you to bring in the fix _without_ the cleanup patch.

We do need the cleanup patch, because https://github.com/alibaba/dragonwell8/issues/305 reports a crash due to use of UnrollLoopLimit, this flag is not supposed to be used by end users, it could be removed by cleanup patch. As I understand, the cleanup patch introduces another problem that can be fixed by JDK-8159715, so once cleanup backport is merged, I will backport JDK-8159715 as well.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/22

From sgehwolf at openjdk.java.net  Fri Mar 25 10:31:54 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Fri, 25 Mar 2022 10:31:54 GMT
Subject: [jdk8u-dev] RFR: 8072422: Cleanup: Remove some unused flags/code
 in loop optimizations [v2]
In-Reply-To: <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>
References: <aczlc1O_a-Lly8RApyOmj9Fm1Zj-VqcR2V_WPVQEgE0=.ea52bc36-bdd4-48e6-bcbc-31e9f88dab8b@github.com>
 <e0pijhWJI0doTEDW6DiYk16R3a_Lpvyv-SAPXxjie9Q=.eb6edbc0-a170-42a2-ab95-b881d0e66a9a@github.com>
Message-ID: <RntTetXtMEVRpvzLXan_f0j1OPL6k0uWY5sc0TF4Tc4=.1ac3efb4-26f2-448d-be5f-428449f5d4f0@github.com>

On Fri, 25 Mar 2022 07:17:26 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> We encountered this problem in downstream JDK. This is a backport of JDK-8283672, which simply removes several diagnostic flags, build passed. There is a related fix https://bugs.openjdk.java.net/browse/JDK-8159715, I would backport it after the current fix merged.
>> 
>> Original changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a1e41855499b
>> 
>> Please help review it.
>> 
>> Thanks.
>
> Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8072422: Cleanup: Remove some unused flags/code in loop optimizations

> We do need the cleanup patch, because [alibaba/dragonwell8#305](https://github.com/alibaba/dragonwell8/issues/305) reports a crash due to use of UnrollLoopLimit, this flag is not supposed to be used by end users, it could be removed by cleanup patch. As I understand, the cleanup patch introduces another problem that can be fixed by JDK-8159715, so once cleanup backport is merged, I will backport JDK-8159715 as well.

So we have a work-around: Don't use `-XX:+UnlockDiagnosticVMOptions -XX:-UnrollLimitCheck`. We shouldn't take backporting non-critical fixes to JDK 8u lightly. This very much sounds like a `jdk8u-fix-no` candidate to me. Are you aware of this?  https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012002.html

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/22

From serb at openjdk.java.net  Mon Mar 28 06:35:08 2022
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Mon, 28 Mar 2022 06:35:08 GMT
Subject: [jdk8u-dev] RFR: 8274751: Drag And Drop hangs on Windows
Message-ID: <eUL3VxgTAo12NOAS9jUUDqXlf2j6ecCgfTTZbklAX4Y=.71240260-de7a-49ec-80aa-4f844c3a8d5c@github.com>

Hi all,
This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository.
The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov.
Thanks!

-------------

Commit messages:
 - Backport 7a0a6c95a53c6cb3340328d6543a97807320b740

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/23/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=23&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274751
  Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/23.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/23/head:pull/23

PR: https://git.openjdk.java.net/jdk8u-dev/pull/23

From duke at openjdk.java.net  Mon Mar 28 08:33:45 2022
From: duke at openjdk.java.net (ktakakuri)
Date: Mon, 28 Mar 2022 08:33:45 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <rV9K9egS5cgGdRuNPCsjbbWgtKPWr3NC_XXfPcFaVZM=.ca0c8044-df8d-477d-a590-7fb8b0b9d362@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
 <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>
 <rV9K9egS5cgGdRuNPCsjbbWgtKPWr3NC_XXfPcFaVZM=.ca0c8044-df8d-477d-a590-7fb8b0b9d362@github.com>
Message-ID: <2dfKZpeIRGdYBj2SO4J7DZFhjLlZjhsyHpE8TbLISz4=.dede3e30-9d9b-4116-b01e-d4e438190524@github.com>

On Tue, 22 Mar 2022 18:58:05 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.
> 
> You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

This backport is not clean. 
Would it be ok to just change the commit message?
Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From sgehwolf at openjdk.java.net  Mon Mar 28 09:04:49 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Mon, 28 Mar 2022 09:04:49 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <2dfKZpeIRGdYBj2SO4J7DZFhjLlZjhsyHpE8TbLISz4=.dede3e30-9d9b-4116-b01e-d4e438190524@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
 <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>
 <rV9K9egS5cgGdRuNPCsjbbWgtKPWr3NC_XXfPcFaVZM=.ca0c8044-df8d-477d-a590-7fb8b0b9d362@github.com>
 <2dfKZpeIRGdYBj2SO4J7DZFhjLlZjhsyHpE8TbLISz4=.dede3e30-9d9b-4116-b01e-d4e438190524@github.com>
Message-ID: <STwnIpaNhynSyCAdMv6A3d0-zdeuaViQ_vBrWVdnan4=.8e532f5c-c95c-4a61-ba59-51d7e751e9fd@github.com>

On Mon, 28 Mar 2022 08:30:27 GMT, ktakakuri <duke at openjdk.java.net> wrote:

> > > You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.
> > 
> > 
> > You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"
> 
> This backport is not clean.

OK. Once the bot recognizes it as a backport this should be apparent by the bot not adding the `clean` label.

> Would it be ok to just change the commit message?

It's OK, but it wouldn't change anything. The Skara bots go by *PR* title.

> Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

Yes.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From andrew at openjdk.java.net  Mon Mar 28 14:31:23 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 28 Mar 2022 14:31:23 GMT
Subject: [jdk8u-dev] RFR: 8274658: ISO 4217 Amendment 170 Update
Message-ID: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>

Currency data update already backported to OpenJDK 11u, 13u, 15u & 17u as well as Oracle forks of 7,  8, 11 & 17.

Patch applies mostly clean once shuffled. A few header changes had to be applied manually due to differing bug IDs and `FILEVERSION` in `tablea1.txt`.

Testing:
- [X] `jdk/test/java/util/Currency` tests pass
- [X] `jdk/test/sun/text/resources` tests pass

-------------

Commit messages:
 - Backport f2404d60de2b58c590bf885f5cce50c289073673

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/24/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=24&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274658
  Stats: 15 lines in 6 files changed: 3 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/24.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/24/head:pull/24

PR: https://git.openjdk.java.net/jdk8u-dev/pull/24

From sgehwolf at openjdk.java.net  Mon Mar 28 18:24:53 2022
From: sgehwolf at openjdk.java.net (Severin Gehwolf)
Date: Mon, 28 Mar 2022 18:24:53 GMT
Subject: [jdk8u-dev] RFR: 8274658: ISO 4217 Amendment 170 Update
In-Reply-To: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
References: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
Message-ID: <JC170kByLQ_wXyfza2NKoeb_fX6Sps0xXvHgx6Wjlhc=.eacbd87f-4c05-4396-a235-4a45f8cf1519@github.com>

On Mon, 28 Mar 2022 14:24:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Currency data update already backported to OpenJDK 11u, 13u, 15u & 17u as well as Oracle forks of 7,  8, 11 & 17.
> 
> Patch applies mostly clean once shuffled. A few header changes had to be applied manually due to differing bug IDs and `FILEVERSION` in `tablea1.txt`.
> 
> Testing:
> - [X] `jdk/test/java/util/Currency` tests pass
> - [X] `jdk/test/sun/text/resources` tests pass

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/24

From andrew at openjdk.java.net  Mon Mar 28 19:59:47 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 28 Mar 2022 19:59:47 GMT
Subject: [jdk8u-dev] RFR: 8282051: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <STwnIpaNhynSyCAdMv6A3d0-zdeuaViQ_vBrWVdnan4=.8e532f5c-c95c-4a61-ba59-51d7e751e9fd@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
 <7GKg_OskYLedYcE9UHb0IEyr55NPF588Ac9tcc6uU9I=.60eb2501-e20b-4409-83c8-61cb38861a9f@github.com>
 <rV9K9egS5cgGdRuNPCsjbbWgtKPWr3NC_XXfPcFaVZM=.ca0c8044-df8d-477d-a590-7fb8b0b9d362@github.com>
 <2dfKZpeIRGdYBj2SO4J7DZFhjLlZjhsyHpE8TbLISz4=.dede3e30-9d9b-4116-b01e-d4e438190524@github.com>
 <STwnIpaNhynSyCAdMv6A3d0-zdeuaViQ_vBrWVdnan4=.8e532f5c-c95c-4a61-ba59-51d7e751e9fd@github.com>
Message-ID: <eY-8XOx1PDGkLlPkWxfSrS5RSAOobE3sjC1a-RK2t9Q=.dcfd88b0-f7c1-46aa-98bd-f69bed2dc6ed@github.com>

On Mon, 28 Mar 2022 09:01:51 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > > You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.
> > 
> > 
> > You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"
> 
> This backport is not clean. 

Few 8u backports are. I don't expect any to be automatically picked up as clean by the bot as even those we human maintainers regard as clean require path shuffling.

Either way, the correct PR title needs to be used so the bot will link this PR to the original issue correctly.

> Would it be ok to just change the commit message? Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

You can change the commit message to whatever you like. The bot really doesn't care about it. The PR title does need to be changed as you mention, so the bot picks that up, links in the original bug and sets the PR title to that of the bug.

Once the PR title change is made, we can review the patch :-)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From andrew at openjdk.java.net  Mon Mar 28 20:21:44 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Mon, 28 Mar 2022 20:21:44 GMT
Subject: [jdk8u-dev] RFR: 8274658: ISO 4217 Amendment 170 Update
In-Reply-To: <JC170kByLQ_wXyfza2NKoeb_fX6Sps0xXvHgx6Wjlhc=.eacbd87f-4c05-4396-a235-4a45f8cf1519@github.com>
References: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
 <JC170kByLQ_wXyfza2NKoeb_fX6Sps0xXvHgx6Wjlhc=.eacbd87f-4c05-4396-a235-4a45f8cf1519@github.com>
Message-ID: <biYUfblwMNCCGeOacZbIz_cS3RnO6LYLxjkBydwTd-k=.1a5ffcd3-74b0-47f5-a652-e7f91d893949@github.com>

On Mon, 28 Mar 2022 18:21:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Currency data update already backported to OpenJDK 11u, 13u, 15u & 17u as well as Oracle forks of 7,  8, 11 & 17.
>> 
>> Patch applies mostly clean once shuffled. A few header changes had to be applied manually due to differing bug IDs and `FILEVERSION` in `tablea1.txt`.
>> 
>> Testing:
>> - [X] `jdk/test/java/util/Currency` tests pass
>> - [X] `jdk/test/sun/text/resources` tests pass
>
> LGTM.

Thanks @jerboaa. I've added `jdk8u-fix-request` to the bug for approval.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/24

From gnu.andrew at redhat.com  Tue Mar 29 02:53:38 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 29 Mar 2022 03:53:38 +0100
Subject: [FREEZE] 8u332 NOW FROZEN
Message-ID: <YkJ0sh4NBo7nPhPx@hex.discworld.ac.uk>

The release tree:

https://hg.openjdk.java.net/jdk8u/monojdk8u

is now frozen in preparation for release on or after 2022-04-19.

The final pre-release tag will be jdk8u332-b06, which I will push once
tested.

The final release tag will be no lower than jdk8u332-b07.

This should be the last release to use Mercurial, as we plan to switch
jdk8u to git after 8u332 is released [0].  That said, I doubt that
will make much difference to many as only critical and regression
fixes should be submitted to jdk8u during the rampdown period.

[0] https://bugs.openjdk.java.net/browse/SKARA-1261
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From serguei.spitsyn at oracle.com  Tue Mar 29 06:09:21 2022
From: serguei.spitsyn at oracle.com (Serguei Spitsyn)
Date: Tue, 29 Mar 2022 06:09:21 +0000
Subject: [External] : Re: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
Message-ID: <F57479F1-1150-4937-A641-426190C6FEA4@oracle.com>

Hi Paul,

It seems I missed to reply to you.
Thank you for the explanation!

Thanks,
Serguei

?On 1/5/22, 8:23 AM, "Hohensee, Paul" <hohensee at amazon.com> wrote:

    Hi, Serguei,
    
    For 8u, we're still using mailing lists, not PRs. We'll move to PRs when 8u moves to github, which I believe is scheduled for real soon now (for 8u332). Hedong (I think I got his first name right!) just needs to tag the JBS issue with jdk8u-fix-request and add a Fix Request comment pointing to your review email (at https://mail.openjdk.java.net/pipermail/jdk8u-dev/). hg-updater will create a backport JBS issue after the commit.
    
    Thanks,
    Paul
    
    -----Original Message-----
    From: serviceability-dev <serviceability-dev-retn at openjdk.java.net> on behalf of Serguei Spitsyn <serguei.spitsyn at oracle.com>
    Date: Tuesday, January 4, 2022 at 3:05 PM
    To: hedongbo <hedongbo at huawei.com>, jdk8u-dev <jdk8u-dev at openjdk.java.net>
    Cc: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
    Subject: Re: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load
    
    Hi Hedongbo,
    
    The backport looks okay to me.
    But I do not see where I can mark it as approved.
    Do you have a PR (Pool Request) or a backport bug number?
    
    Thanks,
    Serguei
    
    
    On 12/29/21, 7:58 PM, "jdk8u-dev on behalf of hedongbo" <jdk8u-dev-retn at openjdk.java.net on behalf of hedongbo at huawei.com> wrote:
    
        This problem has affected the customer's use at present. Can anyone help to take a look? Thanks.
    
        Thanks,
        hedongbo
    
        From: hedongbo
        Sent: Friday, December 17, 2021 9:35 AM
        To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
        Cc: 'serviceability-dev at openjdk.java.net' <serviceability-dev at openjdk.java.net>
        Subject: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load
    
    
        Hi,
    
        Please review the backport of JDK-8173361 to 8u.
        Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
        11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
        8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/
    
        This patch doesn't apply cleanly.
        I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
        I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
        I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.
    
        Tested with tier1. No regression in tests.
        Follow-up fix JDK-8235218[4] is planned to be backported as well.
    
        [1] https://bugs.openjdk.java.net/browse/JDK-8146690
        [2] https://bugs.openjdk.java.net/browse/JDK-8047290
        [3] https://bugs.openjdk.java.net/browse/JDK-8154580
        [4] https://bugs.openjdk.java.net/browse/JDK-8235218
    
    
        Thanks,
    
        hedongbo
    
    
    
    
    
    
    
    


From duke at openjdk.java.net  Tue Mar 29 06:48:15 2022
From: duke at openjdk.java.net (ktakakuri)
Date: Tue, 29 Mar 2022 06:48:15 GMT
Subject: [jdk8u-dev] RFR: 8278138: OpenJDK8 fails to start on Windows 8.1 after
 upgrading compiler to VS2017
Message-ID: <EY6NkB82WC9qCoUsPJ7dIR5UFKZjdL0hmmjGtvXM8Fw=.aa052a7d-07e8-49c9-bcb7-da6041f567b7@github.com>

Could you please review the 8278138 bug fixes?

This problem is caused by missing DLL's which vcruntime140.dll depends on.
I think it is needed to copy the missing DLL's into jdk/bin as like jdk/jre/bin.
I fix to copy api-ms-win-*.dll files to jdk/bin when images directory is created.

-------------

Commit messages:
 - 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/25/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=25&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278138
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/25.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/25/head:pull/25

PR: https://git.openjdk.java.net/jdk8u-dev/pull/25

From andrew at openjdk.java.net  Tue Mar 29 15:21:52 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 29 Mar 2022 15:21:52 GMT
Subject: [jdk8u-dev] RFR: 8274658: ISO 4217 Amendment 170 Update
In-Reply-To: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
References: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
Message-ID: <hRY1J-evWthreYBKpOGhjj6gO0rYP97LYmEaRbl8qy0=.f2e5c187-63bb-4cd1-9092-f31d09d670c7@github.com>

On Mon, 28 Mar 2022 14:24:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Currency data update already backported to OpenJDK 11u, 13u, 15u & 17u as well as Oracle forks of 7,  8, 11 & 17.
> 
> Patch applies mostly clean once shuffled. A few header changes had to be applied manually due to differing bug IDs and `FILEVERSION` in `tablea1.txt`.
> 
> Testing:
> - [X] `jdk/test/java/util/Currency` tests pass
> - [X] `jdk/test/sun/text/resources` tests pass

I see `jdk8u-fix-yes` now

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/24

From andrew at openjdk.java.net  Tue Mar 29 15:21:52 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 29 Mar 2022 15:21:52 GMT
Subject: [jdk8u-dev] Integrated: 8274658: ISO 4217 Amendment 170 Update
In-Reply-To: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
References: <xvhskTu4jXYcqPhfJdkFsMWr0nLxBowyKfWWFRa-1lw=.5c113135-9d39-40a3-a0b3-94bcc81f2fc9@github.com>
Message-ID: <mlax17MOZe-CK6CUu37yji1igRa834F5_hxmGkMKifA=.00d7f9fc-62af-4961-a27e-f0f1f1ca4f6b@github.com>

On Mon, 28 Mar 2022 14:24:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Currency data update already backported to OpenJDK 11u, 13u, 15u & 17u as well as Oracle forks of 7,  8, 11 & 17.
> 
> Patch applies mostly clean once shuffled. A few header changes had to be applied manually due to differing bug IDs and `FILEVERSION` in `tablea1.txt`.
> 
> Testing:
> - [X] `jdk/test/java/util/Currency` tests pass
> - [X] `jdk/test/sun/text/resources` tests pass

This pull request has now been integrated.

Changeset: f8a6695a
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/f8a6695a4ca79d922d357a971af183deda41e799
Stats:     15 lines in 6 files changed: 3 ins; 0 del; 12 mod

8274658: ISO 4217 Amendment 170 Update

Reviewed-by: sgehwolf
Backport-of: f2404d60de2b58c590bf885f5cce50c289073673

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/24

From andrew at openjdk.java.net  Tue Mar 29 15:59:51 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Tue, 29 Mar 2022 15:59:51 GMT
Subject: [jdk8u-dev] RFR: 8255239: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
Message-ID: <JTX1pLKGoiGznyPELeo6AKKcvwgEN7nZeJSmTB8gjJI=.7bb4d990-2f3c-438d-a735-92ac6b4b379f@github.com>

On Tue, 22 Mar 2022 07:04:16 GMT, ktakakuri <duke at openjdk.java.net> wrote:

> This is a backport of JDK-8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale.
> 
> I would like to backport the patch to openjdk8u. 
> Original patch does not apply cleanly to 8u.
> Because the format of time zone in hs_err_pid log is different from 11u and later.
> The following is the example of time zone info:
>   jdk11:
>      Time: Sat Mar 12 00:14:03 2022 Tokyo Standard Time elapsed time: 0 seconds (0d 0h 0m 0s)
>   jdk8:
>      time: Sat Mar 12 00:09:26 2022
>      timezone: Tokyo Standard Time
>      elapsed time: 2.736524 seconds (0d 0h 0m 2s)
> 
> Testing:
>  build on Windows x86_64
>  hotspot/runtime on Windows x86_64
>  a specific test to confirm the fix in Japanese locale
> 
> Could you please review this PR?

Thanks. The backport looks ok to me. Do you have access to the OpenJDK bug system? If not, I can add the `jdk8u-fix-request` label on your behalf.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From hohensee at amazon.com  Tue Mar 29 19:17:47 2022
From: hohensee at amazon.com (Hohensee, Paul)
Date: Tue, 29 Mar 2022 19:17:47 +0000
Subject: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
Message-ID: <8FEA5111-EC80-4031-AC2F-85D35443DBB1@amazon.com>

Np. And of course we're on GitHub now and have moved to PRs!

Thanks,
Paul

?-----Original Message-----
From: Serguei Spitsyn <serguei.spitsyn at oracle.com>
Date: Monday, March 28, 2022 at 11:10 PM
To: "Hohensee, Paul" <hohensee at amazon.com>, hedongbo <hedongbo at huawei.com>, jdk8u-dev <jdk8u-dev at openjdk.java.net>
Cc: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: RE: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

Hi Paul,

It seems I missed to reply to you.
Thank you for the explanation!

Thanks,
Serguei

On 1/5/22, 8:23 AM, "Hohensee, Paul" <hohensee at amazon.com> wrote:

    Hi, Serguei,

    For 8u, we're still using mailing lists, not PRs. We'll move to PRs when 8u moves to github, which I believe is scheduled for real soon now (for 8u332). Hedong (I think I got his first name right!) just needs to tag the JBS issue with jdk8u-fix-request and add a Fix Request comment pointing to your review email (at https://mail.openjdk.java.net/pipermail/jdk8u-dev/). hg-updater will create a backport JBS issue after the commit.

    Thanks,
    Paul

    -----Original Message-----
    From: serviceability-dev <serviceability-dev-retn at openjdk.java.net> on behalf of Serguei Spitsyn <serguei.spitsyn at oracle.com>
    Date: Tuesday, January 4, 2022 at 3:05 PM
    To: hedongbo <hedongbo at huawei.com>, jdk8u-dev <jdk8u-dev at openjdk.java.net>
    Cc: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
    Subject: Re: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

    Hi Hedongbo,

    The backport looks okay to me.
    But I do not see where I can mark it as approved.
    Do you have a PR (Pool Request) or a backport bug number?

    Thanks,
    Serguei


    On 12/29/21, 7:58 PM, "jdk8u-dev on behalf of hedongbo" <jdk8u-dev-retn at openjdk.java.net on behalf of hedongbo at huawei.com> wrote:

        This problem has affected the customer's use at present. Can anyone help to take a look? Thanks.

        Thanks,
        hedongbo

        From: hedongbo
        Sent: Friday, December 17, 2021 9:35 AM
        To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
        Cc: 'serviceability-dev at openjdk.java.net' <serviceability-dev at openjdk.java.net>
        Subject: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load


        Hi,

        Please review the backport of JDK-8173361 to 8u.
        Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
        11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
        8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/

        This patch doesn't apply cleanly.
        I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
        I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
        I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.

        Tested with tier1. No regression in tests.
        Follow-up fix JDK-8235218[4] is planned to be backported as well.

        [1] https://bugs.openjdk.java.net/browse/JDK-8146690
        [2] https://bugs.openjdk.java.net/browse/JDK-8047290
        [3] https://bugs.openjdk.java.net/browse/JDK-8154580
        [4] https://bugs.openjdk.java.net/browse/JDK-8235218


        Thanks,

        hedongbo











From phh at openjdk.java.net  Tue Mar 29 20:12:51 2022
From: phh at openjdk.java.net (Paul Hohensee)
Date: Tue, 29 Mar 2022 20:12:51 GMT
Subject: [jdk8u-dev] RFR: 8261107: ArrayIndexOutOfBoundsException in the
 ICC_Profile.getInstance(InputStream)
In-Reply-To: <B1ga2v1dh4btwF-HOyMgBpTHM7caIeUu5EiV3CGEG6E=.9db8d760-2817-49e5-b37a-8628dade6fca@github.com>
References: <B1ga2v1dh4btwF-HOyMgBpTHM7caIeUu5EiV3CGEG6E=.9db8d760-2817-49e5-b37a-8628dade6fca@github.com>
Message-ID: <FGTq9ORdRba6F5jyt2n8dPxasPIzmQLjszHl5TQPgOo=.a0839d0f-bd46-480e-a33f-eaf1b48d33fc@github.com>

On Thu, 24 Mar 2022 03:35:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [06b33a0a](https://github.com/openjdk/jdk/commit/06b33a0ad78d1577711af22020cf5fdf25112523) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository.
> The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan.
> 
> The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests.
> To apply the patch I had to change the paths and some patch context. The changed lines are the same.
> 
> Thanks!

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/21

From serb at openjdk.java.net  Wed Mar 30 01:03:47 2022
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 30 Mar 2022 01:03:47 GMT
Subject: [jdk8u-dev] Integrated: 8274751: Drag And Drop hangs on Windows
In-Reply-To: <eUL3VxgTAo12NOAS9jUUDqXlf2j6ecCgfTTZbklAX4Y=.71240260-de7a-49ec-80aa-4f844c3a8d5c@github.com>
References: <eUL3VxgTAo12NOAS9jUUDqXlf2j6ecCgfTTZbklAX4Y=.71240260-de7a-49ec-80aa-4f844c3a8d5c@github.com>
Message-ID: <KcBm0_bE7QpPhJZED9tmhYsWlSKTRCGHfnrcFePBbtA=.c8c7d3c8-ecd4-40c5-b00b-42b617d7dd83@github.com>

On Mon, 28 Mar 2022 05:01:41 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository.
> The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov.
> Thanks!

This pull request has now been integrated.

Changeset: e403fd51
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/e403fd517ae3d76ec75ba3409c4478e467d8aa12
Stats:     19 lines in 4 files changed: 2 ins; 0 del; 17 mod

8274751: Drag And Drop hangs on Windows

Backport-of: 7a0a6c95a53c6cb3340328d6543a97807320b740

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/23

From duke at openjdk.java.net  Wed Mar 30 06:23:43 2022
From: duke at openjdk.java.net (ktakakuri)
Date: Wed, 30 Mar 2022 06:23:43 GMT
Subject: [jdk8u-dev] RFR: 8255239: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <JTX1pLKGoiGznyPELeo6AKKcvwgEN7nZeJSmTB8gjJI=.7bb4d990-2f3c-438d-a735-92ac6b4b379f@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
 <JTX1pLKGoiGznyPELeo6AKKcvwgEN7nZeJSmTB8gjJI=.7bb4d990-2f3c-438d-a735-92ac6b4b379f@github.com>
Message-ID: <haM324dGgJ9g-r_nt2pwzaSc_XuCLy8NOux4PczJr9M=.36f73bdd-ae08-4b6c-bc6b-1b2292fb9797@github.com>

On Tue, 29 Mar 2022 15:56:19 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Thanks. The backport looks ok to me. Do you have access to the OpenJDK bug system? If not, I can add the `jdk8u-fix-request` label on your behalf.

Thank you for your cooperation.
Could you add the label?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From duke at openjdk.java.net  Wed Mar 30 11:30:07 2022
From: duke at openjdk.java.net (wxiang)
Date: Wed, 30 Mar 2022 11:30:07 GMT
Subject: [jdk8u-dev] RFR: 8146523: VirtualMemoryTracker::remove_released_region
 double count unmapped CDS shared memory
Message-ID: <MxXCxAlYTUYPneBHRMIpj6SaCUoNd9mxWOVRRj2iiQQ=.202b28f3-cea2-46ba-ba51-e58a64d268fb@github.com>

8146523: VirtualMemoryTracker::remove_released_region double count unmapped CDS shared memory
Skip tracking release for unmapped CDS shared space.

JDK8u can reproduce this prolbem in some special case, for example the timestamp of jar file in jdk build is changed. 

To reproduce the issue with JDK8: 
1. Dump class list? java -XX:DumpLoadedClassList=my.list -version 
2. Generate jsa?java -XX:+UnlockDiagnosticVMOptions -Xshare:dump -XX:SharedClassListFile=my.list -XX:SharedArchiveFile=my.jsa 
3. Touch some jar files in JDK build? touch jre/lib/resources.jar eg 
4. Run with the jsa:java -XX:+UnlockDiagnosticVMOptions -Xshare:on -XX:SharedArchiveFile=nmt_version.jsa -XX:NativeMemoryTracking=summary -XX:-RequireSharedSpaces -version 

Then crash as below: 

# 
# A fatal error has been detected by the Java Runtime Environment: 
# 
# SIGSEGV (0xb) at pc=0x00007fc08dee0195, pid=21887, tid=0x00007fc08f024700 
# 
# JRE version: (8.0_322-b06) (build ) 
# Java VM: OpenJDK 64-Bit Server VM (25.322-b06 mixed mode linux-amd64 compressed oops) 
# Problematic frame: 
# V [libjvm.so+0xb32195] VirtualMemoryTracker::add_committed_region(unsigned char*, unsigned long, NativeCallStack const&)+0x1a5 
# 
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again 
# 
# An error report file with more information is saved as: 
# /data/work/test/nmtissue/hs_err_pid21887.log 
# 
# If you would like to submit a bug report, please visit: 
# https://github.com/adoptium/adoptium-support/issues 
# 

To solve the issue, we?d like to back port this fix to jdk8u

-------------

Commit messages:
 - 8146523: VirtualMemoryTracker::remove_released_region double count unmapped CDS shared memory

Changes: https://git.openjdk.java.net/jdk8u-dev/pull/27/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=27&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8146523
  Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/27.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/27/head:pull/27

PR: https://git.openjdk.java.net/jdk8u-dev/pull/27

From andrew at openjdk.java.net  Wed Mar 30 11:56:46 2022
From: andrew at openjdk.java.net (Andrew John Hughes)
Date: Wed, 30 Mar 2022 11:56:46 GMT
Subject: [jdk8u-dev] RFR: 8255239: The timezone of the hs_err_pid log file
 is corrupted in Japanese locale
In-Reply-To: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
References: <YdlKl47FT4-gIQZSFIYI1tJ8UwfOgeWlCStFW8h0WAo=.d36f639d-3261-442b-85ed-9eb1920319ab@github.com>
Message-ID: <p_Ec9-JQEEA6tqVukN4n7H6FS4cw8nidppecrqZQRCQ=.1a599f5b-04d9-403e-af8b-592dfd32ce1d@github.com>

On Tue, 22 Mar 2022 07:04:16 GMT, ktakakuri <duke at openjdk.java.net> wrote:

> This is a backport of JDK-8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale.
> 
> I would like to backport the patch to openjdk8u. 
> Original patch does not apply cleanly to 8u.
> Because the format of time zone in hs_err_pid log is different from 11u and later.
> The following is the example of time zone info:
>   jdk11:
>      Time: Sat Mar 12 00:14:03 2022 Tokyo Standard Time elapsed time: 0 seconds (0d 0h 0m 0s)
>   jdk8:
>      time: Sat Mar 12 00:09:26 2022
>      timezone: Tokyo Standard Time
>      elapsed time: 2.736524 seconds (0d 0h 0m 2s)
> 
> Testing:
>  build on Windows x86_64
>  hotspot/runtime on Windows x86_64
>  a specific test to confirm the fix in Japanese locale
> 
> Could you please review this PR?

Done. `jdk8u-fix-request` label added and approval given via `jdk8u-fix-yes`.  I'll sponsor this once it's submitted for integration.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/20

From gnu.andrew at redhat.com  Wed Mar 30 19:26:03 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 30 Mar 2022 20:26:03 +0100
Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <b15d825e-b69a-7832-868f-0f1378762474@oracle.com>
 <YjvHsgeJ1iBrgg8n@hex.discworld.ac.uk>
 <84424e44-6577-3084-5604-a356ddf404ec@oracle.com>
Message-ID: <YkSuy9+tDUWQtbVd@hex.discworld.ac.uk>

On 05:07 Thu 24 Mar     , Kevin Rushforth wrote:
> 
> > I'm not sure how you see this as "more work", as the existing task
> > of flagging the issue for approval would now be handled by the bot,
> > rather than the committer.
> 
> I meant more work in Skara to develop and implement this new feature 
> (although Erik could confirm whether my assessment is accurate). I can 
> see some advantages for the maintainers, but we need to balance to 
> potential benefit against the cost to implement.
> 
> -- Kevin
> 

Ah ok, one of my main motivations behind the change was to reduce the
work required in SKARA. After reading the code and discussing this with
Erik, I got the impression that it was easier to implement if the
process was mostly self-contained within the PR, with SKARA only reaching
out to JBS to make changes.

To implement the existing system would require SKARA to be constantly
polling the referenced bugs to see if someone had added jdk<x>-fix-yes
to the bug. I believe this is already something that is proving
problematic with CSRs, where the SKARA PR can become out of sync with
the CSR bug item.

There are some additional benefits to developers, such as removing the
need for someone to have JBS access to request approval, but the
primary one was to avoid a large amount of SKARA development work if a
simple change could be made to where the approval process takes place.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From gnu.andrew at redhat.com  Wed Mar 30 19:46:22 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 30 Mar 2022 20:46:22 +0100
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com>
Message-ID: <YkSzjvPjNFACUSzQ@hex.discworld.ac.uk>

On 14:05 Thu 24 Mar     , Severin Gehwolf wrote:

snip...

> 
> My worry would be that "Fix Request" comments would be spread across
> different PRs if a single bug gets backported to, many update releases.
> JDK 18u, 17u, 11u and 8u, for example. It would move the "approval"
> conversation to the source control system (and per backport PR) rather
> than the bug database. From a maintenance perspective it makes sense to
> have all the info related to backports in one place (on the bug). If
> something gets requested for 8u, say, I can see immediately in the bug
> database that it has been backported to later releases too and can see
> the approval flags (and who approved it). Moving this to skare makes
> the info much more dispersed.

I see this as an advantage. It doesn't make sense to me for the
approval conversation to be separated from the rest of the PR process.
It's even more of a problem when the patch submitter can't comment on
JBS, so there is a level of indirection between the person requesting
approval on the bug and the actual author of the patch.

This came to mind again today when I found myself effectively having a
conversation with myself for
https://bugs.openjdk.java.net/browse/JDK-8255239

Do you really find the fix request comments that useful? I usually
find I have to dig out the original patch review if I need anything
more detailed than whether it went in cleanly or not.

For me, I find more often that they create noise on the bug which
makes it harder for me to find the original diagnosis of the issue
itself.

As to the approval labels (I assume that's what you mean by flags),
they would still be set, but by the SKARA bot, so e.g. filters would
continue to work.  Even without them, the links to backport issues
already demonstrate whether the fix is already in another release.

> 
> Besides, we've had the issue of update project committers being able to
> integrate without formal approval in JBS before. It's only much more
> visible now (which is a good thing). I.e. the problem doesn't change
> with Skara. The difference really is bot guidance. In general, the
> process is fairly well understood and I don't anticipate this to be a
> huge problem in practise.

As I mentioned in my original e-mail, it's less an issue of technical
possibility than ease and the bot guidance.

Yes, someone could commit a bug without approval under Mercurial, but
it was a bit more work to go back to the patch, check it still
applied and worked (no easy branches or rebasing with Mercurial),
and then push it yourself. Even with approval, I always felt a bit
of trepidation doing the actual push.

With SKARA, all it takes is for someone to type '/integrate'. This is
why I have been holding back a formal review (as recognised by the
bot) until the bug is approved, but another reviewer may have done
that instead. The bot currently encourages someone to push without
approval.

8u on GitHub already seems to be attracting more attention than we've
had over the last six months. I'm not sure anyone who can open such a
PR is going to be aware of every aspect of the process, especially
when it contradicts what they are being told by the bot.

> 
> Thanks,
> Severin
> 

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From aph at redhat.com  Thu Mar 31 10:56:44 2022
From: aph at redhat.com (Andrew Haley)
Date: Thu, 31 Mar 2022 11:56:44 +0100
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
Message-ID: <3e9ff967-8b32-3fb3-014d-41fc3a71b353@redhat.com>

On 3/24/22 14:01, erik.joelsson at oracle.com wrote:
> The official process could still be the labels in the JBS
> issues, but the Skara 'integrator'-only /approve command on a PR could
> also add the appropriate *-fix-yes label to all associated bugs. There
> would also be a Skara bot monitoring JBS and automatically updating the
> approval status on PRs based on labels in JBS. This would shortcut the
> process for integrators that prefer working through PRs, while
> integrators that prefer to work through JBS can continue the same way as
> before.

That has much to commend it. It's a proposal that doesn't require
everyone to change how they work, keeps the core authority in the
bug database where it belongs, and provides a useful time-saver for
maintainers.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


From gnu.andrew at redhat.com  Thu Mar 31 13:01:23 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 31 Mar 2022 14:01:23 +0100
Subject: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
Message-ID: <YkWmI4niEzgUmOm8@hex.discworld.ac.uk>

On 07:01 Thu 24 Mar     , erik.joelsson at oracle.com wrote:
> Hello,
> 
> I agree that solving SKARA-1199 would provide quite a bit of benefit to 
> the update releases. The current process works, but it requires 
> knowledge and manual care to not make mistakes. One of the main ideas 
> with Skara was to codify our processes to make them more foolproof and 
> easy to follow. I definitely think this approval process fits the bill 
> as something we should support better with tooling.
>

I completely agree with this and it's one of the things I like about
switching to using SKARA.

> Breaking apart the problem a bit, from the perspective of a user 
> developing a fix for an update release that requires approval, I agree 
> with Kevin that the current state of the approval should be reflected as 
> a "progress" on the PR. That makes it very clear if the PR is ready for 
> integration or not and fits in with how Skara tracks and treats other 
> integration blockers. Basing this functionality around the model of the 
> /sponsor command would be a pretty major shift in my opinion. It moves 
> the ability to actually integrate, and as such the control of the 
> timing, from the contributor to the integrator. This mimics how some 
> other big open source projects handle things (e.g. the Linux kernel). I 
> think it makes sense to do this when sponsoring, because we are then 
> helping new and inexperienced (in OpenJDK processes at least) users, 
> which helps prevent mistakes. For contributors of committer status or 
> above, I think we should retain their ability to control the timing of 
> integration. Implementation wise, I don't think it makes a big difference.
>

I have no issue with this at all. I merely used the 'sponsor' example
because it was the most obvious example of something that seemed similar
in the code. As you know the details of SKARA far better than I do, I'm
happy to follow your lead on the best place to implement this.

> The other part of the problem, which I think is what this discussion 
> should really focus on, is where the official approval takes place. We 
> can keep it in JBS like today, or we can move it to the PR, as suggested 
> by Andrew. From an implementation point of view, moving it to the PR is 
> less work, but I don't think we should base this decision on process on 
> if it takes an extra day to implement. The tooling should support the 
> process we want.
>

I'll confess that my initial motivation in rethinking the process was
to see if we could simplify the implementation of this, given it seemed
to have stalled since we first discussed it last year. But, having
taking a step back to analyse what we're doing with approvals and why,
I think there are several other benefits to integrating the process
more into the SKARA way of doing things, which I hopefully outlined
in my initial e-mail.

Probably the main issue is that the JBS method of approval remains
inaccessible for those who aren't OpenJDK authors, and for everyone
when the bug itself is not public (we tend to encounter more of them
in 8u, it seems). Making approvals easier in these cases would
definitely be a benefit.

> Without having spent a lot of time thinking about it so please tell me 
> if I'm missing something, would it be possible to support a hybrid/dual 
> solution? The official process could still be the labels in the JBS 
> issues, but the Skara 'integrator'-only /approve command on a PR could 
> also add the appropriate *-fix-yes label to all associated bugs. There 
> would also be a Skara bot monitoring JBS and automatically updating the 
> approval status on PRs based on labels in JBS. This would shortcut the 
> process for integrators that prefer working through PRs, while 
> integrators that prefer to work through JBS can continue the same way as 
> before. I think this should alleviate the issue of backporting many bugs 
> with one PR. This is of course also the biggest change to implement, but 
> not that much more than what I had already outlined in SKARA-1199.
>

This does sound like an even better option, providing the best of both
worlds as we do with the ability to use SKARA via both the GitHub
website and e-mail.

My main concern is the work involved, but if you are happy to do this,
then I would be very grateful to have this in place and willing to help
out where I can.

> /Erik
> 
> 

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From erik.joelsson at oracle.com  Thu Mar 31 13:41:04 2022
From: erik.joelsson at oracle.com (erik.joelsson at oracle.com)
Date: Thu, 31 Mar 2022 06:41:04 -0700
Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA
In-Reply-To: <YkWmI4niEzgUmOm8@hex.discworld.ac.uk>
References: <Yjt/h0zy84qfCmX6@hex.discworld.ac.uk>
 <639d9498-c764-2005-30ef-87351d639d9d@oracle.com>
 <YkWmI4niEzgUmOm8@hex.discworld.ac.uk>
Message-ID: <5d4e35b7-d745-5c63-045c-424fb4f7c38a@oracle.com>

Hello,

On 2022-03-31 06:01, Andrew Hughes wrote:
> This does sound like an even better option, providing the best of both
> worlds as we do with the ability to use SKARA via both the GitHub
> website and e-mail.
>
> My main concern is the work involved, but if you are happy to do this,
> then I would be very grateful to have this in place and willing to help
> out where I can.
>
At least in the short term, the work involved is of course limiting. I 
can't promise when I would be able to spend time on this, maybe in a few 
weeks if things go well.

/Erik