[jdk8u-dev] RFR: 8282552: Bump update version of OpenJDK: 8u342 [v2]

Andrew John Hughes andrew at openjdk.java.net
Wed Mar 2 18:45:12 UTC 2022


On Wed, 2 Mar 2022 18:35:04 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Bump update version of jdk8u-dev to 8u342
>> 
>> ------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> 
>> 
>> ### Reviewing
>> <details><summary>Using <code>git</code></summary>
>> 
>> Checkout this PR locally: \
>> `$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/1/head:pull/1` \
>> `$ git checkout pull/1`
>> 
>> Update a local copy of the PR: \
>> `$ git checkout pull/1` \
>> `$ git pull https://git.openjdk.java.net/jdk8u-dev pull/1/head`
>> 
>> </details>
>> <details><summary>Using Skara CLI tools</summary>
>> 
>> Checkout this PR locally: \
>> `$ git pr checkout 1`
>> 
>> View PR using the GUI difftool: \
>> `$ git pr show -t 1`
>> 
>> </details>
>> <details><summary>Using diff file</summary>
>> 
>> Download this PR as a diff file: \
>> <a href="https://git.openjdk.java.net/jdk8u-dev/pull/1.diff">https://git.openjdk.java.net/jdk8u-dev/pull/1.diff</a>
>> 
>> </details>
>
> Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8282552: Bump update version of OpenJDK: 8u342

Marked as reviewed by andrew (Reviewer).

This is the thread I was referring to: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-June/009598.html

Re-reading it, I think Gil's main objection was to change the default to "fcs" with a release. I don't see any objection to setting the update version and there seems to have been none to this on 11u.

They also seem to be doing the same bump in 13u - https://github.com/openjdk/jdk13u-dev/commit/9e30b3d316dcbbb1e31fafac6d622cba77a7629f - so I can't see an objection to this. I was probably going too far with my change (though I still think it was the right thing)

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/1


More information about the jdk8u-dev mailing list