[jdk8u-dev] RFR: 8041523: Xerces Update: Serializer improvements from Xalan

[Andrew John Hughes]

On Tue, 15 Mar 2022 16:53:00 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> I'd like to backport JDK-8041523 to 8u.
> This backport fixes jck8 api/xinclude test failures that occur after JDK-8037259 backport to 8u.
> Аffected tests:
> api/xinclude/Nist/Nist-include-38.html#Nist-include-38
> api/xinclude/Nist/Nist-include-37.html#Nist-include-37
> api/xinclude/Harold/harold-64.html#harold-64
> 
> Original patch from jdk9 [894ae6562453](http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/894ae6562453) applies almost cleanly except for some copyright differences and imports reshuffling.
> 
> Tested with jdk_tier1, jdk_other (that includes javax/xml) and jck8 api/xinclude.

Hi,

Thanks for the backport. I don't see a link between JDK-8041523 & JDK-8037259 in the bug database. If the latter does indeed introduce a TCK failure corrected by the former, can you please link the two together? I guess that's why this wasn't spotted when JDK-8037259 was backported.

If it is indeed fixing a TCK failure introduced in 8u332, I think this should be a `jdk8u-critical-request` and go directly into the [monojdk8u](https://hg.openjdk.java.net/jdk8u/monojdk8u) Mercurial repository once approved, rather than merging this PR.

As to the patch itself:

* `jaxp/src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java` copyright change is already present from JDK-8068842
* `jaxp/src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java`: same
* `jaxp/src/com/sun/org/apache/xml/internal/serializer/EmptySerializer.java`: same
* `jaxp/src/com/sun/org/apache/xml/internal/serializer/ToStream.java`: the structure of the diff doesn't align well with the 9u version so it's hard to tell if these changes are the same. Were any additional changes needed here? It may just be whitespace differences confusing things.

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/7