[jdk8u-dev] RFR: 8207011: Remove uses of the register storage class specifier

[Dongbo He]

On Thu, 17 Mar 2022 18:09:52 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> his is an enhancement/cleanup fix and not appropriate for backporting to 8u.
> 
> Besides, this isn't the actual issue here. The baseline for 8u is C++98 (well, gnu++98 for GCC) where `register` is not deprecated. Newer versions of GCC have a later C++ standard as default so it has to be explicitly set (see [JDK-8151841](https://bugs.openjdk.java.net/browse/JDK-8151841))
> 
> The problem you're seeing here is that the ADLC code is not being passed that option. Indeed, it is not passed any of the extra C and C++ flags that may be specified to the build. This has gone unnoticed thus far because ADLC is a build tool that is used to generate files during the build and is not part of the shipped product.

Thanks for reminding me of this and explaining the issue in detail.


> I already have a bug for this - [JDK-8281098](https://bugs.openjdk.java.net/browse/JDK-8281098) - and a tested fix. I've not yet submitted it upstream as I'd like at least the build testing on PRs to be in place - PR #3 - so we can reduce the (already unlikely) chance it breaks anything.
> 
> I would appreciate it if you would withdraw this PR and wait for JDK-8281098 to be integrated. That should happen soon.

Glad to hear that, I'll close this PR now and look forward to JDK-8281098 being integrated.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/11