[jdk8u-dev] RFR: 8129572: Cleanup usage of getResourceAsStream in jaxp [v4]

Andrew John Hughes andrew at openjdk.java.net
Tue Mar 22 19:04:40 UTC 2022


On Wed, 16 Mar 2022 17:05:04 GMT, Alex Kasko <akasko at openjdk.org> wrote:

>> Please review a backport of a JAXP cleanup.
>> 
>> Original commit [17b47acf5b3d](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/17b47acf5b3d) in jdk9.
>> 
>> Commit [4ebbfc9](https://github.com/openjdk/jdk11u-dev/commit/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75) in jdk11u-dev.
>> 
>> This cleanup should allow to backport other JAXP changes (like [JDK-8163121](https://bugs.openjdk.java.net/browse/JDK-8163121)) easier.
>> 
>> All code changes apply cleanly (with reshuffled paths) except [LSSerializerTest.java](https://github.com/openjdk/jdk11u-dev/blob/4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75/jaxp/test/javax/xml/jaxp/unittest/org/w3c/dom/ls/LSSerializerTest.java) that was excluded. LSSerializerTest.java is not present in 8u, it was added with JDK-8043084 (not public, jdk9 commit [29ba77ad2a87](https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/29ba77ad2a87)).
>> 
>> Testing:
>> 
>>  - [x] jtreg:javax/xml/jaxp
>>  - [x] jck:api/javax_xml
>
> Alex Kasko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8129572: Cleanup usage of getResourceAsStream in jaxp
>   
>   Reviewed-by: alanb, joehw, mchung, redestad
>   Backport-of: 4ebbfc918f558e73c05f471cfd3ab2b11dcf5a75

Marked as reviewed. I was holding off as SKARA doesn't yet check for `jdk8u-fix-yes` (see SKARA-1199)

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/4


More information about the jdk8u-dev mailing list