[jdk8u-dev] RFR: 8281814: Debuginfo.diz contains redundant build path after backport JDK-8025936

[Andrew John Hughes]

On Wed, 30 Mar 2022 07:45:08 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> I would like to backport 8035134 to fix debuginfo regression, introduced by [JDK-8025936](https://bugs.openjdk.java.net/browse/JDK-8025936).
> As discussed on [JDK-8281814](https://bugs.openjdk.java.net/browse/JDK-8281814), we cannot see the details of the original patch.
> It is only a different context, no risk.
> 
> Testing: worked correctly after patch.

It looks like it is largely reverted again in [this 11u commit](https://github.com/openjdk/jdk11u-dev/commit//a350f3bda730bc3276e#diff-805224b793cfe47bf6bebf62286f34adb363f0352a9dac3689825b823886e534L882). I'll look at backporting just the changes to that file, as the rest is intrusive or not relevant.

On Mac, `$1_DEBUGINFO_FILES` contains just a directory, `$$($1_OBJECT_DIR)/$$($1_BASENAME).dSYM` and so ends up empty when this is filtered out. That patch changes the MacOS setup of `$1_DEBUGINFO_FILES` to refer to files.

It's not clear to me why this `notdir` fix was applied in the first place. The `subst` change in the later commit was identified in [JDK-8281814](https://bugs.openjdk.java.net/browse/JDK-8281814) but not applied.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/26