[jdk8u-dev] RFR: 8280963: Incorrect PrintFlags formatting on Windows [v2]

Alex Kasko akasko at openjdk.java.net
Fri May 13 17:38:41 UTC 2022


> A fix to 8u-only Windows-specific problem with -XX:+PrintFlags* output.
> 
> Problem description on Stack Overflow by Andrei Pangin: https://stackoverflow.com/a/63309395
> 
> The problem was fixed in jdk9 as part of [JDK-8042893](https://bugs.openjdk.java.net/browse/JDK-8042893), but this [jdk9 change](https://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/115188e14c15) doesn't look like a good candidate for the 8u backport according to [8u Best Practices](https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012002.html). Still the problem manifests itself as a customer-visible bug on Windows because people do use -XX:+PrintFlagsFinal to find out the actual flags picked up by JVM and can be confused by unexpected zeros in the output. Proposed patch cherry-picks the minimal change from [JDK-8042893 commit](https://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/115188e14c15#l53.1).
> 
> Mailing list review: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014532.html
> 
> Testing:
> 
>  - [x] regression test is included with the proposed patch
>  - [x] checked that it builds on Windows 64-bit and 32-bit on VS2017 and VS2010
>  - [x] ran jtreg:hotspot/test/runtime on Windows and Linux

Alex Kasko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  8280963: Incorrect PrintFlags formatting on Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk8u-dev/pull/45/files
  - new: https://git.openjdk.java.net/jdk8u-dev/pull/45/files/5ef280c4..a312b2ce

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=45&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk8u-dev&pr=45&range=00-01

  Stats: 3887 lines in 74 files changed: 2718 ins; 731 del; 438 mod
  Patch: https://git.openjdk.java.net/jdk8u-dev/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk8u-dev pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk8u-dev/pull/45


More information about the jdk8u-dev mailing list