[jdk8u-dev] RFR: 8286989: Build failure on macOS after 8281814

[Dongbo He]

On Wed, 18 May 2022 17:48:08 GMT, zzambers <duke at openjdk.java.net> wrote:

> This fixes wrong paths to debuginfo files passed to zip command, causing build failure on MacOS in github workflow. Problem was introduced by JDK-8281814 [1] (integrated, while github workflow PR was still in progress). 
> 
> I have done some experiments [2] and found out, that on macos, debuginfo files are stored in additional directories, relative to directory where object files are stored. Removing all directory components is therefore not correct on macos. Two seemingly equivalent fixes were were considered in JDK-8281814 (using notdir and using subst), but chosen one was not the correct one.
> 
> Follows example which illustrates difference of different variants of said zip command:
> 
> **Prior to JDK-8281814:**
> $(ZIP) -q $$@ $$($1_DEBUGINFO_FILES)
> - macos:

@zzambers I opened an issue [JDK-8286989](https://bugs.openjdk.java.net/browse/JDK-8286989) on JBS, you can use it in your PR(ie, change the PR title to `8286989: Build failure on macOS after 8281814`), then the bot can recognize this PR.

This change looks fine to me.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/61