[jdk8u-dev] Integrated: 8286989: Build failure on macOS after 8281814

zzambers duke at openjdk.java.net
Tue May 24 13:31:00 UTC 2022


On Wed, 18 May 2022 17:48:08 GMT, zzambers <duke at openjdk.java.net> wrote:

> This fixes wrong paths to debuginfo files passed to zip command, causing build failure on MacOS in github workflow. Problem was introduced by JDK-8281814 [1] (integrated, while github workflow PR was still in progress). 
> 
> I have done some experiments [2] and found out, that on macos, debuginfo files are stored in additional directories, relative to directory where object files are stored. Removing all directory components is therefore not correct on macos. Two seemingly equivalent fixes were were considered in JDK-8281814 (using notdir and using subst), but chosen one was not the correct one.
> 
> Follows example which illustrates difference of different variants of said zip command:
> 
> **Prior to JDK-8281814:**
> `$(ZIP) -q $$@ $$($1_DEBUGINFO_FILES)`
> - macos:

This pull request has now been integrated.

Changeset: c5f96be5
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.java.net/jdk8u-dev/commit/c5f96be5e370f01fbb8677049e2feeeeb3b3012d
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8286989: Build failure on macOS after 8281814

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/61


More information about the jdk8u-dev mailing list