From duke at openjdk.org  Tue Nov  1 07:39:04 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Tue, 1 Nov 2022 07:39:04 GMT
Subject: [jdk8u-dev] RFR: 8295322: Tests for JDK-8271459 were not backported to
 11u
Message-ID: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>

Hi!

Here is the backport of [JDK-8295322](https://bugs.openjdk.org/browse/JDK-8295322) that adds missed tests for [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459). Except the path shuffling the following changes were done to the original https://github.com/openjdk/jdk11u-dev/commit/70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015

- visibility of test class and methods was changed to `public` to support older JTReg
- `requires` annotation was removed to support older JTReg

Verification (amd64/20.04 LTS): running new `hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java`

7 of 7 PASS on https://github.com/openjdk/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a (integration of [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459))
4 of 7 FAIL on the previous https://github.com/openjdk/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b

-------------

Commit messages:
 - removing unwanted delta
 - support an older JTReg

Changes: https://git.openjdk.org/jdk8u-dev/pull/152/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=152&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295322
  Stats: 186 lines in 1 file changed: 186 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/152.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/152/head:pull/152

PR: https://git.openjdk.org/jdk8u-dev/pull/152

From dcherepanov at openjdk.org  Tue Nov  1 09:28:51 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Tue, 1 Nov 2022 09:28:51 GMT
Subject: [jdk8u-dev] RFR: 8295982: Failure in
 sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the
 file because it is being used by another process
In-Reply-To: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
References: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>
Message-ID: <qHapwCdtp5QxrQg_z3CoauYwNxj9CJ4ylCLQgg9zN-c=.5f1e8a34-796d-44f1-9c48-2208864889d9@github.com>

On Sat, 29 Oct 2022 21:25:40 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Test sun/security/tools/keytool/WeakAlg.java occasionally fails on Windows 64 bit (win2016, win11) with the following message "java.nio.file.FileSystemException: ks: The process cannot access the file because it is being used by another process".
> 
> The root cause of the problem is "ks" file is still open by FileInputStream instance used by KeyStore in the test code. Perhaps, forcing GC to run may avoid this issue, but I guess explicit closing of the input stream is more suitable here.
> 
> No regression, only the test code is changed.
> The test passes on Windows and Linux now.

Marked as reviewed by dcherepanov (Reviewer).

Looks good.  It seems that it's introduced by the patch for 8182879 (confidential bug). Just for the reference, 8u patch with this issue https://github.com/openjdk/jdk8u-dev/commit/a2d837f50cc792cbbce56aa3892a169ff5f7b297 and 11u patch without this issue https://github.com/openjdk/jdk11u-dev/commit/7cf3c0ff1482d23494f88a0eaf13a821adc0bc47

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/150

From jdowland at openjdk.org  Tue Nov  1 10:35:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 10:35:54 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v3]
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <QdS7eY4sir6NGCe_551Hi5kUGBFz89TWXCLd_1boq8Y=.0e6cf44b-df33-4e0f-a28a-1377aef5e2e8@github.com>

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  8237479: 8230305 causes slowdebug build failure
  
  Declare methods as pure virtual.
  
  Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/128/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/128/files/ce82cd31..8193b8bb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=01-02

  Stats: 4984 lines in 71 files changed: 2697 ins; 1632 del; 655 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Tue Nov  1 10:35:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 10:35:54 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v3]
In-Reply-To: <QdS7eY4sir6NGCe_551Hi5kUGBFz89TWXCLd_1boq8Y=.0e6cf44b-df33-4e0f-a28a-1377aef5e2e8@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <QdS7eY4sir6NGCe_551Hi5kUGBFz89TWXCLd_1boq8Y=.0e6cf44b-df33-4e0f-a28a-1377aef5e2e8@github.com>
Message-ID: <bMrnMPBOD0jZCIJkM4iAIzHLgWTl-bKA-ekuTDG5ZKI=.eb3d1b78-54a0-4b09-9388-b13ccda70485@github.com>

On Tue, 1 Nov 2022 10:32:17 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8237479: 8230305 causes slowdebug build failure
>   
>   Declare methods as pure virtual.
>   
>   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp line 60:

> 58: class CgroupController: public CHeapObj<mtInternal> {
> 59:   public:
> 60:     virtual char *subsystem_path() = 0;

I wonder if this will fall foul of the pre C++11 ARM32 compiler problem that 
https://github.com/openjdk/jdk8u-dev/pull/127 had

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Tue Nov  1 10:37:33 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 10:37:33 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v2]
In-Reply-To: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
Message-ID: <uiP--vB49Dol_IUEcMomQUgacHmGOS1eM0XXnSsw62I=.9da14fa4-3e60-4be4-8ad8-27c21490f713@github.com>

> This is a backport of a cgroupsv2 related change for jdk8u-dev.
> 
> ----
> 
> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
> 
> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
> 
> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/130/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/130/files/f1344e0e..f1344e0e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/130.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/130/head:pull/130

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Tue Nov  1 10:50:52 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 10:50:52 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v3]
In-Reply-To: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
Message-ID: <EOZAnv9L4oq81kSmH6RY-VWP13gSxkMOYlgtFPMFiII=.5dcb3edd-4759-425a-9af0-b558d7e523ed@github.com>

> This is a backport of a cgroupsv2 related change for jdk8u-dev.
> 
> ----
> 
> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
> 
> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
> 
> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  
  The early implementation of cgroups v2 support was done with
  crun 0.8 and it contained a bug which set memory.high over
  memory.low when --memory-reservation was being used as a CLI
  option.
  
  This bug has been fixed in later crun versions, starting with
  crun 0.11. Use memory.low in OpenJDK as well.
  
  Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/130/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/130/files/f1344e0e..b6adc371

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=01-02

  Stats: 4984 lines in 71 files changed: 2697 ins; 1632 del; 655 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/130.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/130/head:pull/130

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Tue Nov  1 10:57:31 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 10:57:31 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v6]
In-Reply-To: <A71S8y4wNWUOQ6wqtUZsWyIpf5YofsbS1nAmAlOvH6k=.b70e8e0d-9180-4707-8f83-71069ac13cfc@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <A71S8y4wNWUOQ6wqtUZsWyIpf5YofsbS1nAmAlOvH6k=.b70e8e0d-9180-4707-8f83-71069ac13cfc@github.com>
Message-ID: <7bAPvl_z1HDGeRMyIOaYggt_fp3AzHecy_KcUC-DmIA=.f51d5cf8-c825-47fc-b33b-53c25ee5e9e1@github.com>

On Mon, 31 Oct 2022 14:42:41 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:
> 
>  - Remove C++11-style non-static member initialisation
>    
>    This causes issues with pre-C++11 compilers (of which jdk8u-dev
>    ostensibly supports). Issue has materialised on ARM32.
>    
>    I haven't introduced initialiser lists to the constructor because
>    all of these are assigned to in the body of the constructor.
>  - Guard two more tty->print_cr with PrintContainerInfo
>  - Whitespace and braces around PrintContainerInfo
>  - substitute os::strerror for strerror
>    
>    os::strerror was introduced in 8148425 (strerror() function is not
>    thread-safe), which is probably out of scope for backporting (at least
>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>    (thread unsafe) strerror, in common with the rest of JDK8u.
>  - Rework use of newer logging API to tty->print_cr
>    
>    Remove includes of log.hpp that doesn't exist in jdk8u
>    
>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>  - 8230305: Cgroups v2: Container awareness
>    
>    Implement Cgroups v2 container awareness in hotspot
>    
>    Reviewed-by: bobv, dholmes
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...6947cdb7

After reparenting this PR to master last night, I've inadvertently pulled in the commits from the previous base (PR for 8231111). I'm working on filtering them out now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Tue Nov  1 14:25:06 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 14:25:06 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v7]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <R2VDjxbhuXjplQ2ftxGvQHj2F8x-yUgjGHEQj368ggo=.9c96a75f-53e2-48c9-a474-3ef96c1d8ec2@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains six new commits since the last revision:

 - Remove C++11-style non-static member initialisation
   
   This causes issues with pre-C++11 compilers (of which jdk8u-dev
   ostensibly supports). Issue has materialised on ARM32.
   
   I haven't introduced initialiser lists to the constructor because
   all of these are assigned to in the body of the constructor.
 - Guard two more tty->print_cr with PrintContainerInfo
 - Whitespace and braces around PrintContainerInfo
 - substitute os::strerror for strerror
   
   os::strerror was introduced in 8148425 (strerror() function is not
   thread-safe), which is probably out of scope for backporting (at least
   as part of this cgroups v2 effort). Replace uses of os::strerror with
   (thread unsafe) strerror, in common with the rest of JDK8u.
 - Rework use of newer logging API to tty->print_cr
   
   Remove includes of log.hpp that doesn't exist in jdk8u
   
   log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
 - 8230305: Cgroups v2: Container awareness
   
   Implement Cgroups v2 container awareness in hotspot
   
   Reviewed-by: bobv, dholmes

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/127/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/127/files/6947cdb7..198cd274

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=05-06

  Stats: 5334 lines in 33 files changed: 1581 ins; 3620 del; 133 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From phh at openjdk.org  Tue Nov  1 14:42:45 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 1 Nov 2022 14:42:45 GMT
Subject: [jdk8u-dev] RFR: 8295322: Tests for JDK-8271459 were not
 backported to 11u
In-Reply-To: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
References: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
Message-ID: <pA4Iq-jfb1kJCk3cKSyprQoppikxyPhQrGmmdq09ARA=.f704c728-4ef0-40a9-86e1-c080528aafb0@github.com>

On Tue, 1 Nov 2022 07:31:19 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the backport of [JDK-8295322](https://bugs.openjdk.org/browse/JDK-8295322) that adds missed tests for [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459). Except the path shuffling the following changes were done to the original https://github.com/openjdk/jdk11u-dev/commit/70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015
> 
> - visibility of test class and methods was changed to `public` to support older JTReg
> - `requires` annotation was removed to support older JTReg
> 
> Verification (amd64/20.04 LTS): running new `hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java`
> 
> 7 of 7 PASS on https://github.com/openjdk/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a (integration of [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459))
> 4 of 7 FAIL on the previous https://github.com/openjdk/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/152

From jdowland at openjdk.org  Tue Nov  1 14:43:38 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 14:43:38 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v4]
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <XW9x8y2P5YNzj9S97EP8xKIQcfC1ziEN323hqJGB9Lc=.961b072d-16fa-414d-9ad3-29c2b1627a2b@github.com>

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8237479: 8230305 causes slowdebug build failure
  
  Declare methods as pure virtual.
  
  Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/128/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=03
  Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From duke at openjdk.org  Tue Nov  1 14:56:32 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Tue, 1 Nov 2022 14:56:32 GMT
Subject: [jdk8u-dev] RFR: 8295322: Tests for JDK-8271459 were not
 backported to 11u
In-Reply-To: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
References: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
Message-ID: <PP1GqsPFp0ZOs2oUKNX6pmYqh-Tr4GVDyvoboEcF4e8=.e5502c36-eeda-4763-9d90-0630fa0f8821@github.com>

On Tue, 1 Nov 2022 07:31:19 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the backport of [JDK-8295322](https://bugs.openjdk.org/browse/JDK-8295322) that adds missed tests for [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459). Except the path shuffling the following changes were done to the original https://github.com/openjdk/jdk11u-dev/commit/70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015
> 
> - visibility of test class and methods was changed to `public` to support older JTReg
> - `requires` annotation was removed to support older JTReg
> 
> Verification (amd64/20.04 LTS): running new `hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java`
> 
> 7 of 7 PASS on https://github.com/openjdk/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a (integration of [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459))
> 4 of 7 FAIL on the previous https://github.com/openjdk/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b

Thank you for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/152

From jdowland at openjdk.org  Tue Nov  1 15:17:42 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 15:17:42 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v4]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <YIo6WXYVM7iU__dq_vaAWDrexCwPhy5m6rxNIWuWcxY=.838cefbc-7edb-4e16-934e-2edd46a5d42b@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/135/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=03
  Stats: 703 lines in 6 files changed: 527 ins; 95 del; 81 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Tue Nov  1 15:19:51 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 15:19:51 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v2]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <qykWPourYS0Kpr-44WCmwQr8nSrProOP5LanJsnV9KY=.6c0e5d77-6c76-4057-82f1-aef4d98d9ace@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/136/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/136/files/d1951ba9..d1951ba9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Tue Nov  1 15:26:13 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 15:26:13 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v3]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <NP92GeydFnoEfS7Fd9QRlV_SdIQiC3LV3YlqYkZ3eho=.9eeef780-914b-4972-8ebe-935fd5972112@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/136/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=02
  Stats: 292 lines in 2 files changed: 263 ins; 21 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Tue Nov  1 15:30:33 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 15:30:33 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v2]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <4SCpXWva4TrY6GEEN2BXOQojsSX-7GPs01tVzpkm5mI=.e0187d66-074f-428f-bf7d-aaaaf05ffad4@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/142/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/142/files/0536c56d..0536c56d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Tue Nov  1 20:41:22 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 20:41:22 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v4]
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <f1_fUYUmcTzmkB5XkYtQ2MNoA2NERmpjTgCnaR35bK0=.1700313c-c689-4680-b0d6-a6acc7abdc8c@github.com>

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  Address style nit

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/121/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/121/files/0ea3c608..d0352fcf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=02-03

  Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/121.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/121/head:pull/121

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Tue Nov  1 20:45:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 1 Nov 2022 20:45:49 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v3]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <09QPMZBPOvvSkvMbS8CieoaXmFlEjgimyzdFeBz0jCE=.09015777-a530-49f8-9b7f-976cc2788973@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/142/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=02
  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From btaylor at openjdk.org  Tue Nov  1 20:54:04 2022
From: btaylor at openjdk.org (Ben Taylor)
Date: Tue, 1 Nov 2022 20:54:04 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get macOS
 version
Message-ID: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>

This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 

The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.

Change applied with:
- `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
- `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
- `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60gig` (re-apply JDK-826985)
- `git rebase -i HEAD~3` (squash commits)

-------------

Commit messages:
 - Backport d4c7db5060978302382549246f9ad6831f19377d

Changes: https://git.openjdk.org/jdk8u-dev/pull/153/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=153&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8257620
  Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/153.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/153/head:pull/153

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From duke at openjdk.org  Wed Nov  2 11:16:33 2022
From: duke at openjdk.org (duke)
Date: Wed, 2 Nov 2022 11:16:33 GMT
Subject: [jdk8u-dev] Withdrawn: 8275535: Retrying a failed authentication on
 multiple LDAP servers can lead to users blocked
In-Reply-To: <ghkADvJxH_lv86lJqc9fhxP6__DEwZeeovmUmRYGr28=.da2ee3a6-e55d-4f93-8d88-8ccf8e473b4c@github.com>
References: <ghkADvJxH_lv86lJqc9fhxP6__DEwZeeovmUmRYGr28=.da2ee3a6-e55d-4f93-8d88-8ccf8e473b4c@github.com>
Message-ID: <P8YMf6Q1mTO2E413wNMNSqUbXrVvPBm-2f8qZAOaEnQ=.ba4a1ff5-92f4-4f7d-8859-6fa85b50e81c@github.com>

On Tue, 6 Sep 2022 19:30:06 GMT, Ryan Flegel <duke at openjdk.org> wrote:

> Backport [8275535](https://bugs.openjdk.org/browse/JDK-8275535).
> 
> Fixes authentication issue introduced by [8160768](https://bugs.openjdk.org/browse/JDK-8160768).

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/117

From akozlov at openjdk.org  Wed Nov  2 14:31:40 2022
From: akozlov at openjdk.org (Anton Kozlov)
Date: Wed, 2 Nov 2022 14:31:40 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <L7Oq_uoRnuG3IrLJ0Gym_YXbMcveSBk7FVLAqr5C5WA=.89534207-cdab-48b9-946f-90231d86b7dc@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-826985)
> - `git rebase -i HEAD~3` (squash commits)

Marked as reviewed by akozlov (no project role).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From andrew at openjdk.org  Wed Nov  2 15:12:45 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 2 Nov 2022 15:12:45 GMT
Subject: [jdk8u-dev] RFR: 8294357: (tz) Update Timezone Data to 2022d
In-Reply-To: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
References: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
Message-ID: <vuDPCu0qnhhAihOhiXELJPTa9Qi9WC7cFTjHIWQ-xsY=.8f5791c6-1973-45c9-856a-c358730c940b@github.com>

On Sun, 16 Oct 2022 01:34:47 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Mostly clean backport of tzdata2022d update from 11u, with paths adjusted and files duplicated for `jdk/test`. There are no tzdata differences between the vanguard and rearguard update.
> 
> In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970
> 
> Tests in `java/util/TimeZone` and `sun/util/calendar` all pass.

I see `jdk8u-fix-yes` now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/138

From andrew at openjdk.org  Wed Nov  2 15:16:41 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 2 Nov 2022 15:16:41 GMT
Subject: [jdk8u-dev] Integrated: 8294357: (tz) Update Timezone Data to 2022d
In-Reply-To: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
References: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
Message-ID: <0VBAIqLFvjDBf9F6yzmqazJ_amkM0hkVfHsAST_Bgso=.badca61f-cfec-4b14-b2c8-429b2ab72640@github.com>

On Sun, 16 Oct 2022 01:34:47 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Mostly clean backport of tzdata2022d update from 11u, with paths adjusted and files duplicated for `jdk/test`. There are no tzdata differences between the vanguard and rearguard update.
> 
> In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970
> 
> Tests in `java/util/TimeZone` and `sun/util/calendar` all pass.

This pull request has now been integrated.

Changeset: 28cc8358
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/28cc835812298471e2b62d0ddd4d57edfd70d72d
Stats:     202 lines in 17 files changed: 63 ins; 103 del; 36 mod

8294357: (tz) Update Timezone Data to 2022d

Reviewed-by: sgehwolf
Backport-of: f67b4de8a07b8158be1dfb5b09cdb4cc5b7ac93b

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/138

From andrew at openjdk.org  Wed Nov  2 15:22:04 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 2 Nov 2022 15:22:04 GMT
Subject: [jdk8u-dev] RFR: 8295173: (tz) Update Timezone Data to 2022e [v2]
In-Reply-To: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
References: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
Message-ID: <qBr4CN19IHFWguauNoSFLcnn1IdzJ4JcqHNgv0HHbGk=.f515daf7-b056-403b-9f23-4002f02a8026@github.com>

> Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.
> 
> Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/139/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/139/files/44ea8322..44ea8322

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=139&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=139&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/139.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/139/head:pull/139

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From andrew at openjdk.org  Wed Nov  2 15:28:19 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 2 Nov 2022 15:28:19 GMT
Subject: [jdk8u-dev] RFR: 8295173: (tz) Update Timezone Data to 2022e [v3]
In-Reply-To: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
References: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
Message-ID: <iO7CY96KbZNpKO_wZ4yC6PegBCtXbmV5Ti2HveiEzIA=.fb1b6029-9698-4f4d-91a7-bd4094a4d748@github.com>

> Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.
> 
> Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport 21407dec0156301871a83328615e4d975c4287c4

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/139/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=139&range=02
  Stats: 161 lines in 10 files changed: 44 ins; 26 del; 91 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/139.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/139/head:pull/139

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From andrew at openjdk.org  Wed Nov  2 16:45:17 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 2 Nov 2022 16:45:17 GMT
Subject: [jdk8u-dev] Integrated: 8295173: (tz) Update Timezone Data to 2022e
In-Reply-To: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
References: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
Message-ID: <szedfc0paCW9umhCBs5c8o0VYpLssbME319Nue8uzyg=.6f9e89e0-a44e-4cb6-996b-e2378717f3a8@github.com>

On Sun, 16 Oct 2022 02:39:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.
> 
> Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.

This pull request has now been integrated.

Changeset: 64faf400
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/64faf4000c81982119a54b86926786d076989b9d
Stats:     161 lines in 10 files changed: 44 ins; 26 del; 91 mod

8295173: (tz) Update Timezone Data to 2022e

Reviewed-by: sgehwolf
Backport-of: 21407dec0156301871a83328615e4d975c4287c4

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From phh at openjdk.org  Wed Nov  2 23:48:36 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 2 Nov 2022 23:48:36 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <rNIhM9RjL5p6Rwwc2XYzqBBD5wliw9RcqDwoMBvUqQc=.48c43468-1ea3-4f24-aafc-12aaaf4eb498@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-826985)
> - `git rebase -i HEAD~3` (squash commits)

Clean except for referenced context changes. Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From omikhaltcova at openjdk.org  Thu Nov  3 11:32:09 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Thu, 3 Nov 2022 11:32:09 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <7mjhVOZ2AmMldUxSvH6s9Acjlp7KIks4oYkJ0qnD8Ok=.7e83f735-7206-4d55-864b-7f1d922a78a3@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-826985)
> - `git rebase -i HEAD~3` (squash commits)

Patched file location difference:
JDK:   `./src/java.base/macosx/native/libjava/java_props_macosx.c`
JDK8: `./jdk/src/solaris/native/java/lang/java_props_macosx.c`

It seems it's not possible to apply this patch avoiding manual merge in a way described, right?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From abakhtin at openjdk.org  Thu Nov  3 15:42:54 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 3 Nov 2022 15:42:54 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs
Message-ID: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>

I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]

The patch is based on the OpenJDK11 backport [2]

The changes are the following:

1. java.security.* files are changed on the base of java.security
2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh

All java/security/Security sun/security/tools regression tests passed

[1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
[2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

-------------

Commit messages:
 - Backport 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7

Changes: https://git.openjdk.org/jdk8u-dev/pull/154/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8269039
  Stats: 643 lines in 27 files changed: 305 ins; 213 del; 125 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/154.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/154/head:pull/154

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From sgehwolf at openjdk.org  Thu Nov  3 16:36:05 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 3 Nov 2022 16:36:05 GMT
Subject: [jdk8u-dev] RFR: 8295950: Enable langtools/tier1 in GHA for 8u
In-Reply-To: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>
References: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>
Message-ID: <0SKwYw1MfT7OjdHKYwtISykrpRA2XgH5Y3RE0cbtmbc=.ee8a6bf6-8ca2-41a9-b491-29103b44970e@github.com>

On Wed, 26 Oct 2022 16:15:22 GMT, zzambers <duke at openjdk.org> wrote:

> It is now possible to enable langtools/tier1 in Github actions for jdk8u as the only failure there has been resolved [1].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8265527

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/149

From duke at openjdk.org  Thu Nov  3 16:41:49 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 3 Nov 2022 16:41:49 GMT
Subject: [jdk8u-dev] RFR: 8295950: Enable langtools/tier1 in GHA for 8u
In-Reply-To: <0SKwYw1MfT7OjdHKYwtISykrpRA2XgH5Y3RE0cbtmbc=.ee8a6bf6-8ca2-41a9-b491-29103b44970e@github.com>
References: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>
 <0SKwYw1MfT7OjdHKYwtISykrpRA2XgH5Y3RE0cbtmbc=.ee8a6bf6-8ca2-41a9-b491-29103b44970e@github.com>
Message-ID: <zK7RJhqp298-YxBdrWo3u7wFSvGVusA6GrDB7qiDtoU=.cb2e09e7-5a13-453b-8a10-746cf75c9664@github.com>

On Thu, 3 Nov 2022 16:33:39 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> It is now possible to enable langtools/tier1 in Github actions for jdk8u as the only failure there has been resolved [1].
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8265527
>
> Looks good.

@jerboaa thanks for review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/149

From duke at openjdk.org  Thu Nov  3 16:48:38 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 3 Nov 2022 16:48:38 GMT
Subject: [jdk8u-dev] Integrated: 8295950: Enable langtools/tier1 in GHA for 8u
In-Reply-To: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>
References: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>
Message-ID: <O-dyihPhhQ_BjyaUD3JE5I-3NhLi03Hu_8GfWrUn_-w=.626ef234-6908-4032-a195-20195eec3b78@github.com>

On Wed, 26 Oct 2022 16:15:22 GMT, zzambers <duke at openjdk.org> wrote:

> It is now possible to enable langtools/tier1 in Github actions for jdk8u as the only failure there has been resolved [1].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8265527

This pull request has now been integrated.

Changeset: ae6d30db
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/ae6d30dba462ee53eb89999b7b24a72693737c03
Stats:     15 lines in 1 file changed: 0 ins; 0 del; 15 mod

8295950: Enable langtools/tier1 in GHA for 8u

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/149

From sgehwolf at openjdk.org  Thu Nov  3 16:50:45 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 3 Nov 2022 16:50:45 GMT
Subject: [jdk8u-dev] RFR: 8270344: Session resumption errors
In-Reply-To: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
References: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
Message-ID: <-0JebydhO3Pib5xDtKTgW63F7Vc9g_uu-isg6V7q0fY=.a11acd69-9734-4b3d-b25a-58e9d775b774@github.com>

On Mon, 31 Oct 2022 13:32:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> It is an almost clean backport.
> TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
> Fixed library path for the InvalidateSession test
> 
> sun/security/ssl and javax/net/ssl regression tests are passed

@martinuy Could you please review this? Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/151

From jdowland at openjdk.org  Fri Nov  4 10:00:29 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:00:29 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v5]
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <6lXhRna-dOR-VP2LrFuUl9AuMP2tvtJI4KFXMwa0jko=.a85c3c7e-81bf-430a-96f6-76f9fad13801@github.com>

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:

 - Merge remote-tracking branch 'jdk8u-dev/master' into 8231111-jdk8u-dev
 - 8295950: Enable langtools/tier1 in GHA for 8u
   
   Reviewed-by: sgehwolf
 - 8295173: (tz) Update Timezone Data to 2022e
   
   Reviewed-by: sgehwolf
   Backport-of: 21407dec0156301871a83328615e4d975c4287c4
 - 8294357: (tz) Update Timezone Data to 2022d
   
   Reviewed-by: sgehwolf
   Backport-of: f67b4de8a07b8158be1dfb5b09cdb4cc5b7ac93b
 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
   
   The main hunk from 8275713 was rolled up in the changes for 8231111.
   This line is also necessary.
 - ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/76192af6...f56af77f

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/121/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/121/files/d0352fcf..f56af77f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=03-04

  Stats: 5213 lines in 67 files changed: 2762 ins; 1757 del; 694 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/121.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/121/head:pull/121

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Fri Nov  4 10:03:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:03:56 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v6]
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <UTATcyPYXzNsQrMmRXBPSsR3vP9xvC-TMmMy6rial5k=.dbb550c5-1175-43b3-b2eb-feb4dfb95c60@github.com>

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains 16 new commits since the last revision:

 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
   
   The main hunk from 8275713 was rolled up in the changes for 8231111.
   This line is also necessary.
 - update mapfile for new JNI method name
 - tests for the backport
   
   two files had fairly significant merge conflicts, eyeball only to resolve
   
   haven't run any of them yet -- will depend on the rest of the patch
 - CgroupSubsystemFactory: remove logging lines
   
   jdk8u doesn't have java.lang.System.Logger. There's no existing logging
   in place for other classes in the Metrics/platform/etc family that I can
   see, so remove it.
 - Metrics => CgroupV1Subsystem.java
   
   unshuffle, rename, resolve unclean hunks although I'm not sure why they
   didn't apply, they look trivial and the context is the same, will look
   closer
 - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/f56af77f...a2bb1693

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/121/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/121/files/f56af77f..a2bb1693

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=04-05

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/121.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/121/head:pull/121

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Fri Nov  4 10:07:26 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:07:26 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v2]
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <qFHxGaZDtq-3ZHQ2SrDljD14Xf5LieyTkB05BKzLW8U=.c43b78b7-5a67-4724-ac47-142de943c572@github.com>

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/124/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/124/files/7dc6d86f..7dc6d86f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/124.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/124/head:pull/124

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Fri Nov  4 10:21:45 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:21:45 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v7]
In-Reply-To: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
Message-ID: <275g9lxn1Wfyw4igwrikPIPliTJejxkXOv5kZCvWsPg=.42deed04-8516-4b2c-98e5-9128880ed6e1@github.com>

> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
> 
> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
> 
> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
> 
>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
> 
> I think this is fixed in a further patch to backport, and will confirm.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:

 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
   
   The main hunk from 8275713 was rolled up in the changes for 8231111.
   This line is also necessary.
 - update mapfile for new JNI method name
 - tests for the backport
   
   two files had fairly significant merge conflicts, eyeball only to resolve
   
   haven't run any of them yet -- will depend on the rest of the patch
 - CgroupSubsystemFactory: remove logging lines
   
   jdk8u doesn't have java.lang.System.Logger. There's no existing logging
   in place for other classes in the Metrics/platform/etc family that I can
   see, so remove it.
 - Metrics => CgroupV1Subsystem.java
   
   unshuffle, rename, resolve unclean hunks although I'm not sure why they
   didn't apply, they look trivial and the context is the same, will look
   closer
 - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/198cd274...58498718

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/121/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=121&range=06
  Stats: 5335 lines in 33 files changed: 3621 ins; 1582 del; 132 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/121.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/121/head:pull/121

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From jdowland at openjdk.org  Fri Nov  4 10:23:04 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:23:04 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v5]
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:

 - 8237479: 8230305 causes slowdebug build failure
   
   Declare methods as pure virtual.
   
   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
 - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
   
   The early implementation of cgroups v2 support was done with
   crun 0.8 and it contained a bug which set memory.high over
   memory.low when --memory-reservation was being used as a CLI
   option.
   
   This bug has been fixed in later crun versions, starting with
   crun 0.11. Use memory.low in OpenJDK as well.
   
   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
   
   The main hunk from 8275713 was rolled up in the changes for 8231111.
   This line is also necessary.
 - update mapfile for new JNI method name
 - tests for the backport
   
   two files had fairly significant merge conflicts, eyeball only to resolve
   
   haven't run any of them yet -- will depend on the rest of the patch
 - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/128/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=04
  Stats: 7429 lines in 43 files changed: 5082 ins; 2178 del; 169 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Fri Nov  4 10:23:45 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:23:45 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
Message-ID: <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>

> This is a backport of a cgroupsv2 related change for jdk8u-dev.
> 
> ----
> 
> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
> 
> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
> 
> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  
  The early implementation of cgroups v2 support was done with
  crun 0.8 and it contained a bug which set memory.high over
  memory.low when --memory-reservation was being used as a CLI
  option.
  
  This bug has been fixed in later crun versions, starting with
  crun 0.11. Use memory.low in OpenJDK as well.
  
  Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/130/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/130/files/b6adc371..c6fad8b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=02-03

  Stats: 22 lines in 3 files changed: 0 ins; 0 del; 22 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/130.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/130/head:pull/130

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at openjdk.org  Fri Nov  4 10:24:00 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:24:00 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v4]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <tdv3tP-mgGPNCgrFsGoaAQeLnpFYhQplTK2U6kRBUvc=.9953b7f9-ad19-4341-83fc-a92adf043ac1@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:

 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922
 - 8237479: 8230305 causes slowdebug build failure
   
   Declare methods as pure virtual.
   
   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
 - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
   
   The early implementation of cgroups v2 support was done with
   crun 0.8 and it contained a bug which set memory.high over
   memory.low when --memory-reservation was being used as a CLI
   option.
   
   This bug has been fixed in later crun versions, starting with
   crun 0.11. Use memory.low in OpenJDK as well.
   
   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - ... and 19 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...0cfe1277

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/142/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=03
  Stats: 7873 lines in 48 files changed: 5524 ins; 2179 del; 170 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Fri Nov  4 10:25:11 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:25:11 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:

 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922
 - 8237479: 8230305 causes slowdebug build failure
   
   Declare methods as pure virtual.
   
   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
 - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
   
   The early implementation of cgroups v2 support was done with
   crun 0.8 and it contained a bug which set memory.high over
   memory.low when --memory-reservation was being used as a CLI
   option.
   
   This bug has been fixed in later crun versions, starting with
   crun 0.11. Use memory.low in OpenJDK as well.
   
   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
 - Address style nit
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/198cd274...e4a44241

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/135/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=04
  Stats: 6053 lines in 40 files changed: 4148 ins; 1677 del; 228 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Fri Nov  4 10:32:20 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:32:20 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v3]
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <bM1dpfvbgCkwpeFhktghZ8NAvBWBCBYZuDMTKtbd6tQ=.7627a2ea-5e4d-4b61-a7e2-29fcd461e9fa@github.com>

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
  
  Reviewed-by: mdoerr
  Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/124/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=02
  Stats: 145 lines in 5 files changed: 46 ins; 28 del; 71 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/124.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/124/head:pull/124

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Fri Nov  4 10:34:11 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 10:34:11 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v4]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:

 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Move test to a more 8u-appropriate location
   
   Container (cgroups, docker) tests in 8u reside in
   hotspot/test/runtime/containers
 - remove duplicate include of osContainer_linux
   
   With the backport of 8189762, the include of osContainer_linux was
   moved to a later #ifdef stanza, relative to the original. This caused
   a context problem with this backport.
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
   
   Return NULL subsystem if no cgroup controllers are mounted.
   
   Reviewed-by: sgehwolf
   Backport-of: add18914fb1294999877b563c734a25b4c17b922
 - 8237479: 8230305 causes slowdebug build failure
   
   Declare methods as pure virtual.
   
   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
 - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
   
   The early implementation of cgroups v2 support was done with
   crun 0.8 and it contained a bug which set memory.high over
   memory.low when --memory-reservation was being used as a CLI
   option.
   
   This bug has been fixed in later crun versions, starting with
   crun 0.11. Use memory.low in OpenJDK as well.
   
   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
 - ... and 48 more: https://git.openjdk.org/jdk8u-dev/compare/f0ac3199...45ec61df

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/136/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=03
  Stats: 13049 lines in 114 files changed: 8449 ins; 3811 del; 789 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Fri Nov  4 11:03:22 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 4 Nov 2022 11:03:22 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails on
 Ubuntu 21.10
Message-ID: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>

This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.

Dependent PRs are in use.

It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/136

Commit messages:
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Changes: https://git.openjdk.org/jdk8u-dev/pull/155/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8278951
  Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From sgehwolf at openjdk.org  Fri Nov  4 11:07:36 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 11:07:36 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <hSPpoeOI1LcpjQMJlAlHl4pB0zWWVGBK8sFnAWO4mCQ=.b6d8e966-b979-4969-89cd-bc7bd1fd7ec4@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>
 <hSPpoeOI1LcpjQMJlAlHl4pB0zWWVGBK8sFnAWO4mCQ=.b6d8e966-b979-4969-89cd-bc7bd1fd7ec4@github.com>
Message-ID: <DK2vGq6lBnRBgE3oNFQxNUG-4rORNbyAAxqaqp8Xaeo=.778b7df5-ddf4-4c42-8eb5-5ddd12c08021@github.com>

On Mon, 31 Oct 2022 11:30:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp line 447:
>> 
>> 
>> This is actually code added with [JDK-8232207](https://bugs.openjdk.org/browse/JDK-8232207) which shouldn't affect JDK 8. So I'm not sure about this. Add it to 8u anyway (and have less divergence) or remove and deal with the code difference.
>> 
>> Whatever the way, we need to make this clear by: a) adding the issue using `/issue add` or b) restructuring this code to account for it. I'm slightly in favor of b).
>
> I tried a very basic JMH bench with/without the memory caching in place and it had no obvious impact one way or another, but I'm leaning towards a) because removing it means re-working quite a few bits, including switching _memory from a CachingCgroupController to CgroupController (or CgroupV1Controller etc) so the macros GET_CONTAINER_INFO and friends still work. The deltas will be across at least four source files.

Thanks. My thinking was for b) to use a patch like:


commit 9546da23b777625cb2bdd397080dae280e91b854 (HEAD -> pull/127-rebased)
Author: Severin Gehwolf <sgehwolf at redhat.com>
Date:   Thu Nov 3 19:55:20 2022 +0100

    Only cache CPU metrics

diff --git a/hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp b/hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp
index b93c8b308b..923ad7838a 100644
--- a/hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp
+++ b/hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp
@@ -440,13 +440,6 @@ int CgroupSubsystem::active_processor_count() {
  *    OSCONTAINER_ERROR for not supported
  */
 jlong CgroupSubsystem::memory_limit_in_bytes() {
-  CachingCgroupController* contrl = memory_controller();
-  CachedMetric* memory_limit = contrl->metrics_cache();
-  if (!memory_limit->should_check_metric()) {
-    return memory_limit->value();
-  }
   jlong mem_limit = read_memory_limit_in_bytes();
-  // Update cached metric to avoid re-reading container settings too often
-  memory_limit->set_value(mem_limit, OSCONTAINER_CACHE_TIMEOUT);
   return mem_limit;
 }


But my basic experiments don't suggest this makes a whole lot of difference. Given that `available_memory()` is being used in `hotspot/src/share/vm/jfr/periodic/jfrPeriodic.cpp` for the physical memory event, I'm OK with leaving it in as it might be beneficial for the JFR tracing. If that turns out to be a problem, we can revisit this later. OK with keeping it as is.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From sgehwolf at openjdk.org  Fri Nov  4 13:30:35 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 13:30:35 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v5]
In-Reply-To: <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <I-L2k9rqN9qCGiUZoAVp7OnuEkmscHO29tjPXfiw_N8=.f34d9704-dd8f-409f-8df8-6e69d20de367@github.com>
Message-ID: <a_ZlDD16K17aLX0O2aGJmuL7_tVGThA4B38VQopVBfY=.258f4972-de84-4e55-b03a-a25e14d854e6@github.com>

On Fri, 4 Nov 2022 10:23:04 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96c...463f7511

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From sgehwolf at openjdk.org  Fri Nov  4 13:30:37 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 13:30:37 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v3]
In-Reply-To: <bMrnMPBOD0jZCIJkM4iAIzHLgWTl-bKA-ekuTDG5ZKI=.eb3d1b78-54a0-4b09-9388-b13ccda70485@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
 <QdS7eY4sir6NGCe_551Hi5kUGBFz89TWXCLd_1boq8Y=.0e6cf44b-df33-4e0f-a28a-1377aef5e2e8@github.com>
 <bMrnMPBOD0jZCIJkM4iAIzHLgWTl-bKA-ekuTDG5ZKI=.eb3d1b78-54a0-4b09-9388-b13ccda70485@github.com>
Message-ID: <FGvmiJWPKOONMkUxd3gpthPQdNHEbmwGizjvTqiN8TY=.764fa8c8-ff46-4b9d-bc01-1adb3668e5e4@github.com>

On Tue, 1 Nov 2022 10:32:17 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase.
>
> hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp line 60:
> 
>> 58: class CgroupController: public CHeapObj<mtInternal> {
>> 59:   public:
>> 60:     virtual char *subsystem_path() = 0;
> 
> I wonder if this will fall foul of the pre C++11 ARM32 compiler problem that 
> https://github.com/openjdk/jdk8u-dev/pull/127 had

Maybe. Until we see issues with it, I'd leave the patch as is.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From sgehwolf at openjdk.org  Fri Nov  4 13:33:48 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 13:33:48 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v7]
In-Reply-To: <R2VDjxbhuXjplQ2ftxGvQHj2F8x-yUgjGHEQj368ggo=.9c96a75f-53e2-48c9-a474-3ef96c1d8ec2@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <R2VDjxbhuXjplQ2ftxGvQHj2F8x-yUgjGHEQj368ggo=.9c96a75f-53e2-48c9-a474-3ef96c1d8ec2@github.com>
Message-ID: <5AetnQJr57SXotRdo-7IqL0BmIpBmbyxDILf6-pS6Ws=.be6c9b0f-cdb8-4760-9dd2-3f23d87f10d5@github.com>

On Tue, 1 Nov 2022 14:25:06 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains six new commits since the last revision:
> 
>  - Remove C++11-style non-static member initialisation
>    
>    This causes issues with pre-C++11 compilers (of which jdk8u-dev
>    ostensibly supports). Issue has materialised on ARM32.
>    
>    I haven't introduced initialiser lists to the constructor because
>    all of these are assigned to in the body of the constructor.
>  - Guard two more tty->print_cr with PrintContainerInfo
>  - Whitespace and braces around PrintContainerInfo
>  - substitute os::strerror for strerror
>    
>    os::strerror was introduced in 8148425 (strerror() function is not
>    thread-safe), which is probably out of scope for backporting (at least
>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>    (thread unsafe) strerror, in common with the rest of JDK8u.
>  - Rework use of newer logging API to tty->print_cr
>    
>    Remove includes of log.hpp that doesn't exist in jdk8u
>    
>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>  - 8230305: Cgroups v2: Container awareness
>    
>    Implement Cgroups v2 container awareness in hotspot
>    
>    Reviewed-by: bobv, dholmes

This seems fine now.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From sgehwolf at openjdk.org  Fri Nov  4 14:52:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 14:52:33 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v7]
In-Reply-To: <275g9lxn1Wfyw4igwrikPIPliTJejxkXOv5kZCvWsPg=.42deed04-8516-4b2c-98e5-9128880ed6e1@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <275g9lxn1Wfyw4igwrikPIPliTJejxkXOv5kZCvWsPg=.42deed04-8516-4b2c-98e5-9128880ed6e1@github.com>
Message-ID: <TvL94jmgcFzXL1UB1m68-hkPTdMdSkyaJVp5DwKtSFE=.73c7fc93-c622-4ee2-9688-01f10abc733d@github.com>

On Fri, 4 Nov 2022 10:21:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
>> 
>> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
>> 
>> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
>> 
>>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
>> 
>> I think this is fixed in a further patch to backport, and will confirm.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
> 
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - CgroupSubsystemFactory: remove logging lines
>    
>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>    in place for other classes in the Metrics/platform/etc family that I can
>    see, so remove it.
>  - Metrics => CgroupV1Subsystem.java
>    
>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>    didn't apply, they look trivial and the context is the same, will look
>    closer
>  - ... and 6 more: https://git.openjdk.org/jdk8u-dev/compare/198cd274...58498718

Looks good to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From sgehwolf at openjdk.org  Fri Nov  4 16:01:04 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 16:01:04 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit
 incorrectly using memory.high [v4]
In-Reply-To: <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
References: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>
 <8n0lFjYJzANI0BgrTJudZktSBHRfemfMmnpH1Wsofso=.bb06cc3e-7674-469f-9cbe-fc92470369f4@github.com>
Message-ID: <nqFf9cq3V8Rrj5E49nmYeBRCANkCAyIoorjlH23hkLI=.167ab105-659b-4cbb-8c48-b28bfcfbb5a0@github.com>

On Fri, 4 Nov 2022 10:23:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of a cgroupsv2 related change for jdk8u-dev.
>> 
>> ----
>> 
>> The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.
>> 
>> This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.
>> 
>> Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>   
>   The early implementation of cgroups v2 support was done with
>   crun 0.8 and it contained a bug which set memory.high over
>   memory.low when --memory-reservation was being used as a CLI
>   option.
>   
>   This bug has been fixed in later crun versions, starting with
>   crun 0.11. Use memory.low in OpenJDK as well.
>   
>   Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

This is a clean backport and only shuffles paths. Marking as such.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From sgehwolf at openjdk.org  Fri Nov  4 17:38:21 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 17:38:21 GMT
Subject: [jdk8u-dev] RFR: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails
 with exitValue = 137
Message-ID: <qj9ChC3mApjlzSw9ZEvmXjV4RTVsiYNnI0U147m26Q4=.5f3ea7dc-ee3f-4d76-a9c8-c2a66e5cb53c@github.com>

Clean backport from 11u which helps testing of cgroups v2 work.

-------------

Commit messages:
 - Backport 1719c0cc12e094856955c2a3294521b79b17ba7c

Changes: https://git.openjdk.org/jdk8u-dev/pull/156/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=156&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8224506
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/156.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/156/head:pull/156

PR: https://git.openjdk.org/jdk8u-dev/pull/156

From sgehwolf at openjdk.org  Fri Nov  4 17:44:27 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 4 Nov 2022 17:44:27 GMT
Subject: [jdk8u-dev] RFR: 8224506: [TESTBUG] TestDockerMemoryMetrics.java
 fails with exitValue = 137
In-Reply-To: <qj9ChC3mApjlzSw9ZEvmXjV4RTVsiYNnI0U147m26Q4=.5f3ea7dc-ee3f-4d76-a9c8-c2a66e5cb53c@github.com>
References: <qj9ChC3mApjlzSw9ZEvmXjV4RTVsiYNnI0U147m26Q4=.5f3ea7dc-ee3f-4d76-a9c8-c2a66e5cb53c@github.com>
Message-ID: <mOAbJkwjg2t8htnese8nQgeGKY5U0ZYFReSOTjMGy-U=.4ba2db9a-a1e0-46e1-bb8a-be5a6826e17b@github.com>

On Fri, 4 Nov 2022 17:30:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport from 11u which helps testing of cgroups v2 work.

Marking as clean on the basis that the 11u backport also didn't include the problem list (it was never problem listed on 8u).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/156

From mbalao at openjdk.org  Sat Nov  5 01:15:33 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Sat, 5 Nov 2022 01:15:33 GMT
Subject: [jdk8u-dev] RFR: 8270344: Session resumption errors
In-Reply-To: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
References: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
Message-ID: <26r_SLUbcFlcktb-Mi8Omhp-CAwyB6OaP091IUrK07M=.83c04d4a-e88e-434e-9aa1-0e0e4e39d7b7@github.com>

On Mon, 31 Oct 2022 13:32:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> It is an almost clean backport.
> TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
> Fixed library path for the InvalidateSession test
> 
> sun/security/ssl and javax/net/ssl regression tests are passed

Thanks for proposing this backport. Looks good to me. The changed lib paths in sun/security/ssl/SSLSessionImpl/InvalidateSession.java are correct and the test passes.

-------------

Marked as reviewed by mbalao (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/151

From jdowland at openjdk.org  Mon Nov  7 10:09:22 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 7 Nov 2022 10:09:22 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in a
 Container
Message-ID: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>

This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/155

Commit messages:
 - 8252359: HotSpot Not Identifying it is Running in a Container

Changes: https://git.openjdk.org/jdk8u-dev/pull/157/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8252359
  Stats: 15 lines in 2 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Mon Nov  7 10:31:18 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 7 Nov 2022 10:31:18 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash if
 manually mounted cpusets exist
Message-ID: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>

This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/157

Commit messages:
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist

Changes: https://git.openjdk.org/jdk8u-dev/pull/158/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8253435
  Stats: 40 lines in 2 files changed: 37 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From sgehwolf at openjdk.org  Mon Nov  7 10:35:15 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 10:35:15 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <hHBVCjo5qWMHDZpTkVy1HCydtoFSBhPEx3TXMZsGE-c=.a0fbf91b-b230-4ffe-956a-606fcf425fcf@github.com>

On Mon, 7 Nov 2022 10:22:13 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

This one will need changes. Build fails with:

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Mon Nov  7 10:37:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 7 Nov 2022 10:37:54 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on some
 systems (still reproducible)
Message-ID: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>

A backport of 8245543 to jdk8u-dev for cgroups v2 support.

Not clean: needed minor adjusting for 8u approach to log output.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/158

Commit messages:
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

Changes: https://git.openjdk.org/jdk8u-dev/pull/159/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8245543
  Stats: 97 lines in 4 files changed: 91 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From abakhtin at openjdk.org  Mon Nov  7 11:50:36 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 7 Nov 2022 11:50:36 GMT
Subject: [jdk8u-dev] RFR: 8270344: Session resumption errors
In-Reply-To: <26r_SLUbcFlcktb-Mi8Omhp-CAwyB6OaP091IUrK07M=.83c04d4a-e88e-434e-9aa1-0e0e4e39d7b7@github.com>
References: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
 <26r_SLUbcFlcktb-Mi8Omhp-CAwyB6OaP091IUrK07M=.83c04d4a-e88e-434e-9aa1-0e0e4e39d7b7@github.com>
Message-ID: <5z_ElzR3Q5JV6ER0mdYRuipD-ZRkjahpUO2ErFN-GRE=.664545e2-8f32-4dd2-a76e-d109ab1236f3@github.com>

On Sat, 5 Nov 2022 01:12:02 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> It is an almost clean backport.
>> TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
>> Fixed library path for the InvalidateSession test
>> 
>> sun/security/ssl and javax/net/ssl regression tests are passed
>
> Thanks for proposing this backport. Looks good to me. The changed lib paths in sun/security/ssl/SSLSessionImpl/InvalidateSession.java are correct and the test passes.

@martinuy Thank you a lot for the review!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/151

From abakhtin at openjdk.org  Mon Nov  7 11:52:45 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 7 Nov 2022 11:52:45 GMT
Subject: [jdk8u-dev] Integrated: 8270344: Session resumption errors
In-Reply-To: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
References: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>
Message-ID: <ZdLbkdu1eri9M8F4QxqwMe_TR1_iVzSlkJolnv73PQI=.40748280-8738-43ab-8aea-ce3cdc320c7b@github.com>

On Mon, 31 Oct 2022 13:32:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> It is an almost clean backport.
> TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
> Fixed library path for the InvalidateSession test
> 
> sun/security/ssl and javax/net/ssl regression tests are passed

This pull request has now been integrated.

Changeset: 2cd66fb9
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2cd66fb929dd6716dae33cd05d112ec2fb0ea6f3
Stats:     182 lines in 3 files changed: 160 ins; 20 del; 2 mod

8270344: Session resumption errors

Reviewed-by: mbalao
Backport-of: 04a806ec86a388b8de31d42f904c4321beb69e14

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/151

From sgehwolf at openjdk.org  Mon Nov  7 14:37:44 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 14:37:44 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
Message-ID: <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>

On Fri, 4 Nov 2022 10:25:11 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
>> 
>> It does not apply clean:
>> 
>>  * context issues for changes made for the different approach for logging in 8u
>>  * copyright lines
>> 
>> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
> 
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/26db7880...e4a44241

Did you run the newly added test `hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java`? It didn't work for me and required a patch like this to actually work:


commit 74dbb1af01d367194a3638b52a286909e78c38b6
Author: Severin Gehwolf <sgehwolf at redhat.com>
Date:   Mon Nov 7 15:25:27 2022 +0100

    Test updates for JDK-8239785

diff --git a/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java b/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
index c08b64dcda..036eae9156 100644
--- a/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
+++ b/hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java
@@ -24,9 +24,9 @@
 /*
  * @test CgroupSubsystemFactory
  * @requires os.family == "linux"
- * @library /testlibrary /test/lib
- * @build sun.hotspot.WhiteBox
- * @run driver ClassFileInstaller sun.hotspot.WhiteBox
+ * @library /testlibrary /testlibrary/whitebox
+ * @build CgroupSubsystemFactory
+ * @run main ClassFileInstaller sun.hotspot.WhiteBox
  *                              sun.hotspot.WhiteBox$WhiteBoxPermission
  * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI CgroupSubsystemFactory
  */
@@ -36,10 +36,12 @@ import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.nio.file.FileVisitResult;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
 
-import jdk.test.lib.Asserts;
-import jdk.test.lib.Utils;
-import jdk.test.lib.util.FileUtils;
+import com.oracle.java.testlibrary.Asserts;
+import com.oracle.java.testlibrary.Utils;
 import sun.hotspot.WhiteBox;
 
 /*
@@ -129,35 +131,35 @@ public class CgroupSubsystemFactory {
         try {
             existingDirectory = Utils.createTempDirectory(CgroupSubsystemFactory.class.getSimpleName());
             Path cgroupsZero = Paths.get(existingDirectory.toString(), "cgroups_zero");
-            Files.writeString(cgroupsZero, cgroupsZeroHierarchy, StandardCharsets.UTF_8);
+            Files.write(cgroupsZero, cgroupsZeroHierarchy.getBytes(StandardCharsets.UTF_8));
             cgroupv1CgInfoZeroHierarchy = cgroupsZero;
             cgroupv2CgInfoZeroHierarchy = cgroupsZero;
             cgroupv1MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_empty");
-            Files.writeString(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty);
+            Files.write(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty.getBytes());
 
             cgroupv2MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_cgroupv2");
-            Files.writeString(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only);
+            Files.write(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only.getBytes());
 
             cgroupv1CgInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "cgroups_non_zero");
-            Files.writeString(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy);
+            Files.write(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy.getBytes());
 
             cgroupv1MntInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_non_zero");
-            Files.writeString(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid);
+            Files.write(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid.getBytes());
 
             cgroupv1MntInfoNonZeroHierarchyOtherOrder = Paths.get(existingDirectory.toString(), "mountinfo_non_zero_cgroupv2_last");
-            Files.writeString(cgroupv1MntInfoNonZeroHierarchyOtherOrder, mntInfoHybridFlippedOrder);
+            Files.write(cgroupv1MntInfoNonZeroHierarchyOtherOrder, mntInfoHybridFlippedOrder.getBytes());
 
             cgroupV1SelfCgroup = Paths.get(existingDirectory.toString(), "cgroup_self_hybrid");
-            Files.writeString(cgroupV1SelfCgroup, procSelfCgroupHybridContent);
+            Files.write(cgroupV1SelfCgroup, procSelfCgroupHybridContent.getBytes());
 
             cgroupV2SelfCgroup = Paths.get(existingDirectory.toString(), "cgroup_self_v2");
-            Files.writeString(cgroupV2SelfCgroup, procSelfCgroupV2UnifiedContent);
+            Files.write(cgroupV2SelfCgroup, procSelfCgroupV2UnifiedContent.getBytes());
 
             cgroupv1MntInfoMissingMemoryController = Paths.get(existingDirectory.toString(), "mnt_info_missing_memory");
-            Files.writeString(cgroupv1MntInfoMissingMemoryController, mntInfoHybridMissingMemory);
+            Files.write(cgroupv1MntInfoMissingMemoryController, mntInfoHybridMissingMemory.getBytes());
 
             cgroupV2MntInfoMissingCgroupv2 = Paths.get(existingDirectory.toString(), "mnt_info_missing_cgroup2");
-            Files.writeString(cgroupV2MntInfoMissingCgroupv2, mntInfoHybridStub);
+            Files.write(cgroupV2MntInfoMissingCgroupv2, mntInfoHybridStub.getBytes());
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
@@ -165,12 +167,31 @@ public class CgroupSubsystemFactory {
 
     private void teardown() {
         try {
-            FileUtils.deleteFileTreeWithRetry(existingDirectory);
+            deleteFileTree(existingDirectory);
         } catch (IOException e) {
             System.err.println("Teardown failed. " + e.getMessage());
         }
     }
 
+    private static void deleteFileTree(Path dir) throws IOException {
+        java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<Path>() {
+            @Override
+            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
+                Files.delete(file);
+                return FileVisitResult.CONTINUE;
+            }
+            @Override
+            public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
+                Files.delete(dir);
+                return FileVisitResult.CONTINUE;
+            }
+            @Override
+            public FileVisitResult visitFileFailed(Path file, IOException exc) {
+                return FileVisitResult.CONTINUE;
+            }
+        });
+    }
+
     private boolean isValidCgroup(int value) {
         return value == CGROUPS_V1 || value == CGROUPS_V2;
     }
diff --git a/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java b/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
index 902e3b1383..0e79599d20 100644
--- a/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
+++ b/hotspot/test/testlibrary/com/oracle/java/testlibrary/Utils.java
@@ -32,6 +32,10 @@ import java.io.IOException;
 import java.net.InetAddress;
 import java.net.ServerSocket;
 import java.net.UnknownHostException;
+import java.nio.file.Path;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.nio.file.attribute.FileAttribute;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Arrays;
@@ -370,4 +374,25 @@ public final class Utils {
         }
         return new String(hexView);
     }
+
+    /**
+     * Creates an empty directory in "user.dir" or "."
+     * <p>
+     * This method is meant as a replacement for {@code Files#createTempDirectory(String, String, FileAttribute...)}
+     * that doesn't leave files behind in /tmp directory of the test machine
+     * <p>
+     * If the property "user.dir" is not set, "." will be used.
+     *
+     * @param prefix
+     * @param attrs
+     * @return the path to the newly created directory
+     * @throws IOException
+     *
+     * @see {@link Files#createTempDirectory(String, String, FileAttribute...)}
+     */
+    public static Path createTempDirectory(String prefix, FileAttribute<?>... attrs) throws IOException {
+        Path dir = Paths.get(System.getProperty("user.dir", "."));
+        return Files.createTempDirectory(dir, prefix);
+    }
+
 }
diff --git a/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java b/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
index 24632c037e..393f3b1ca8 100644
--- a/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
+++ b/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java
@@ -256,5 +256,8 @@ public class WhiteBox {
   // Container testing
   public native boolean isContainerized();
   public native void printOsInfo();
+  public native int validateCgroup(String procCgroups,
+                                   String procSelfCgroup,
+                                   String procSelfMountinfo);
 
 }
diff --git a/jdk/test/lib/sun/hotspot/WhiteBox.java b/jdk/test/lib/sun/hotspot/WhiteBox.java
index da3a617661..9497c95305 100644
--- a/jdk/test/lib/sun/hotspot/WhiteBox.java
+++ b/jdk/test/lib/sun/hotspot/WhiteBox.java
@@ -443,9 +443,6 @@ public class WhiteBox {
 
   // Container testing
   public native boolean isContainerized();
-  public native int validateCgroup(String procCgroups,
-                                   String procSelfCgroup,
-                                   String procSelfMountinfo);
   public native void printOsInfo();
 
   // Decoder

hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java line 50:

> 48: public class CgroupSubsystemFactory {
> 49: 
> 50:     // Mirrored from src/hotspot/os/linux/cgroupSubsystem_linux.hpp

The JDK 8u path seems to be `hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp`. We should update that comment in the backport.

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Mon Nov  7 15:02:46 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 15:02:46 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v4]
In-Reply-To: <tdv3tP-mgGPNCgrFsGoaAQeLnpFYhQplTK2U6kRBUvc=.9953b7f9-ad19-4341-83fc-a92adf043ac1@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
 <tdv3tP-mgGPNCgrFsGoaAQeLnpFYhQplTK2U6kRBUvc=.9953b7f9-ad19-4341-83fc-a92adf043ac1@github.com>
Message-ID: <fQ-90E-fVEOw_3C2XuNARpXUjzA42sk8eteXJw9aOSs=.0f2a5b2a-9190-4358-8f28-c4e0fa7b382e@github.com>

On Fri, 4 Nov 2022 10:24:00 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
>> 
>> It's a test-only change.
>> 
>> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision:
> 
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - Address style nit
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - ... and 19 more: https://git.openjdk.org/jdk8u-dev/compare/a62109c5...0cfe1277

This really is a no-op change when it comes to tests. It only syncs the code to include the Metrics debugging for this test. This is fine, though, since the actual changes to `hotspot/test/runtime/containers/docker/TestMemoryAwareness.java` got included with [JDK-8250984](https://github.com/openjdk/jdk8u/commit/af9ea420d32146896eee035e06802daada52aab5)

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Mon Nov  7 15:42:34 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 7 Nov 2022 15:42:34 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v5]
In-Reply-To: <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <umT7bPFldE58AZB3EstDbAUk9vXZyeCilvy-kBm0sWE=.f1851b51-3afd-4277-ba6c-3eba700061cd@github.com>
 <0Jl3jdA-AzVYu37P34N8HJEHlW5YNPd7zV6U-mmTWzI=.19d77744-04cb-41e1-9e3f-c82a7dc00f60@github.com>
Message-ID: <O_iXj1CUNjnhlDnt61dFMxWR3DA_JVFp9YyJHh8eC_A=.d1a125c5-2f49-4898-883b-7139ddf65788@github.com>

On Mon, 7 Nov 2022 14:33:39 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Did you run the newly added test hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java?

I guess not. I began the patch series running all the touched tests, but since review wasn't going to start for a while, and also some tests are known-broken until later patches are applied, I decided to focus on the non-test hunks and watch the status of test pass/fail via GHA on the "tip" of the backport effort.

Now that review has started I should switch to paying attention to them!

> It didn't work for me and required a patch like this to actually work:

Thanks for fixing this one. I'll look at the rest downstream of this PR.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Mon Nov  7 15:57:27 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 15:57:27 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v3]
In-Reply-To: <bM1dpfvbgCkwpeFhktghZ8NAvBWBCBYZuDMTKtbd6tQ=.7627a2ea-5e4d-4b61-a7e2-29fcd461e9fa@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
 <bM1dpfvbgCkwpeFhktghZ8NAvBWBCBYZuDMTKtbd6tQ=.7627a2ea-5e4d-4b61-a7e2-29fcd461e9fa@github.com>
Message-ID: <UWJ0W-1LW2ONWylmYF4XPFTmQ2ZEzAPx2Cet1JAxubM=.60a1502d-8c00-4caa-b67f-ff13831cec54@github.com>

On Fri, 4 Nov 2022 10:32:20 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
>> 
>> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
>> 
>> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
>> 
>> I'll report back testing results to this PR, I have to untangle them a bit first.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>   
>   Reviewed-by: mdoerr
>   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From sgehwolf at openjdk.org  Mon Nov  7 16:00:43 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 16:00:43 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v4]
In-Reply-To: <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>
Message-ID: <BqYtA7fgC3ojm8WRjdvGn574oxUW6W1AU6dqX_sEip0=.466de12e-e8fc-434b-a10d-91c5061414c5@github.com>

On Fri, 4 Nov 2022 10:34:11 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
>> 
>> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
>> 
>> I also had to Optional.isEmpty which is not present in 8u's Optional.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:
> 
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - ... and 48 more: https://git.openjdk.org/jdk8u-dev/compare/f0ac3199...45ec61df

@jmtd Could you please fix the merge conflict in this PR? Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From sgehwolf at openjdk.org  Mon Nov  7 17:35:38 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 17:35:38 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v4]
In-Reply-To: <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>
Message-ID: <TFtfbPWsdHpd900u-Leb3eDCERymfwpSqX-YBByYhGs=.ec74ce25-257f-4319-8113-454a508b291e@github.com>

On Fri, 4 Nov 2022 10:34:11 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
>> 
>> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
>> 
>> I also had to Optional.isEmpty which is not present in 8u's Optional.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:
> 
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Move test to a more 8u-appropriate location
>    
>    Container (cgroups, docker) tests in 8u reside in
>    hotspot/test/runtime/containers
>  - remove duplicate include of osContainer_linux
>    
>    With the backport of 8189762, the include of osContainer_linux was
>    moved to a later #ifdef stanza, relative to the original. This caused
>    a context problem with this backport.
>  - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>    
>    Return NULL subsystem if no cgroup controllers are mounted.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: add18914fb1294999877b563c734a25b4c17b922
>  - 8237479: 8230305 causes slowdebug build failure
>    
>    Declare methods as pure virtual.
>    
>    Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76
>  - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>    
>    The early implementation of cgroups v2 support was done with
>    crun 0.8 and it contained a bug which set memory.high over
>    memory.low when --memory-reservation was being used as a CLI
>    option.
>    
>    This bug has been fixed in later crun versions, starting with
>    crun 0.11. Use memory.low in OpenJDK as well.
>    
>    Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc
>  - ... and 48 more: https://git.openjdk.org/jdk8u-dev/compare/f0ac3199...45ec61df

Looks good other than the test change that's necessary.

jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 47:

> 45:  * @requires os.family == "linux"
> 46:  * @modules java.base/jdk.internal.platform
> 47:  * @library /test/lib

This test also doesn't run on JDK 8u. I had to use this patch:


commit 3b4140fac83f628d15fee8e8044480a2692f3a24
Author: Severin Gehwolf <sgehwolf at redhat.com>
Date:   Mon Nov 7 18:30:39 2022 +0100

    Fix test for JDK 8u

diff --git a/jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java b/jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java
index 6f47ea0602..dfec2af0f1 100644
--- a/jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java
+++ b/jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java
@@ -36,15 +36,15 @@ import org.junit.Test;
 
 import jdk.internal.platform.CgroupSubsystemFactory;
 import jdk.internal.platform.CgroupSubsystemFactory.CgroupTypeResult;
-import jdk.test.lib.Utils;
-import jdk.test.lib.util.FileUtils;
+import jdk.testlibrary.Utils;
+import jdk.testlibrary.FileUtils;
 
 
 /*
  * @test
  * @requires os.family == "linux"
  * @modules java.base/jdk.internal.platform
- * @library /test/lib
+ * @library /lib/testlibrary
  * @run junit/othervm TestCgroupSubsystemFactory
  */
 public class TestCgroupSubsystemFactory {
@@ -104,20 +104,20 @@ public class TestCgroupSubsystemFactory {
         try {
             existingDirectory = Utils.createTempDirectory(TestCgroupSubsystemFactory.class.getSimpleName());
             Path cgroupsZero = Paths.get(existingDirectory.toString(), "cgroups_zero");
-            Files.writeString(cgroupsZero, cgroupsZeroHierarchy, StandardCharsets.UTF_8);
+            Files.write(cgroupsZero, cgroupsZeroHierarchy.getBytes(StandardCharsets.UTF_8));
             cgroupv1CgInfoZeroHierarchy = cgroupsZero;
             cgroupv2CgInfoZeroHierarchy = cgroupsZero;
             cgroupv1MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_empty");
-            Files.writeString(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty);
+            Files.write(cgroupv1MntInfoZeroHierarchy, mntInfoEmpty.getBytes());
 
             cgroupv2MntInfoZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_cgroupv2");
-            Files.writeString(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only);
+            Files.write(cgroupv2MntInfoZeroHierarchy, mntInfoCgroupsV2Only.getBytes());
 
             cgroupv1CgInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "cgroups_non_zero");
-            Files.writeString(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy);
+            Files.write(cgroupv1CgInfoNonZeroHierarchy, cgroupsNonZeroHierarchy.getBytes());
 
             cgroupv1MntInfoNonZeroHierarchy = Paths.get(existingDirectory.toString(), "mountinfo_non_zero");
-            Files.writeString(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid);
+            Files.write(cgroupv1MntInfoNonZeroHierarchy, mntInfoHybrid.getBytes());
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
@@ -149,7 +149,7 @@ public class TestCgroupSubsystemFactory {
         String mountInfo = cgroupv1MntInfoZeroHierarchy.toString();
         Optional<CgroupTypeResult> result = CgroupSubsystemFactory.determineType(mountInfo, cgroups);
 
-        assertTrue("zero hierarchy ids with no mounted controllers => empty result", result.isEmpty());
+        assertTrue("zero hierarchy ids with no mounted controllers => empty result", Optional.empty().equals(result));
     }
 
     @Test
diff --git a/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java b/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java
index 5979815d41..31bfeea36c 100644
--- a/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java
+++ b/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java
@@ -38,7 +38,11 @@ import java.util.ArrayList;
 import java.util.List;
 import java.util.Arrays;
 import java.util.LinkedList;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.nio.file.attribute.FileAttribute;
+
 import java.util.Collections;
 import java.util.Objects;
 import java.util.regex.Pattern;
@@ -440,4 +444,24 @@ public final class Utils {
     public static String getTestSourcePath(String fileName) {
         return Paths.get(System.getProperty("test.src")).resolve(fileName).toString();
     }
+
+    /**
+     * Creates an empty directory in "user.dir" or "."
+     * <p>
+     * This method is meant as a replacement for {@code Files#createTempDirectory(String, String, FileAttribute...)}
+     * that doesn't leave files behind in /tmp directory of the test machine
+     * <p>
+     * If the property "user.dir" is not set, "." will be used.
+     *
+     * @param prefix
+     * @param attrs
+     * @return the path to the newly created directory
+     * @throws IOException
+     *
+     * @see {@link Files#createTempDirectory(String, String, FileAttribute...)}
+     */
+    public static Path createTempDirectory(String prefix, FileAttribute<?>... attrs) throws IOException {
+        Path dir = Paths.get(System.getProperty("user.dir", "."));
+        return Files.createTempDirectory(dir, prefix);
+    }
 }

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From sgehwolf at openjdk.org  Mon Nov  7 18:27:37 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 7 Nov 2022 18:27:37 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <1EPnWhpeVgAIF1hXKTEBhOSdYzgtwZ7rZPhBhZNqMQM=.1057dfbd-877f-42fa-82de-f7af097148b1@github.com>

On Fri, 4 Nov 2022 10:56:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

While this backport likely does no harm, `PlainRead.java` test mentioned in the bug got introduced with [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408), which is *not* in 8u. We should add that first before adding a "fix" for that test ;-) Note: we seem to have most of the changes of JDK-8197408 already in 8u.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From duke at openjdk.org  Mon Nov  7 20:14:27 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 7 Nov 2022 20:14:27 GMT
Subject: [jdk8u-dev] RFR: 8295915: Problemlist compiler/rtm failures
 specific to 8u
In-Reply-To: <-muX1wkKtzR45HojvZ-gvLDlhpUGZyv_IdaYLJJESEk=.ffd0716c-11f2-4625-b632-0b5dffc6d45e@github.com>
References: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
 <-muX1wkKtzR45HojvZ-gvLDlhpUGZyv_IdaYLJJESEk=.ffd0716c-11f2-4625-b632-0b5dffc6d45e@github.com>
Message-ID: <ftOQXGdiqWQ7MD6Uhgu6SPvAo3qkSry5NXrDILIF71E=.892ff54b-6d71-41ff-8ca6-edddd9b4aa51@github.com>

On Mon, 31 Oct 2022 22:49:08 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
>> List of tests follows:
>> 
>> compiler/rtm/locking/TestRTMTotalCountIncrRate.java
>> compiler/rtm/locking/TestUseRTMAfterLockInflation.java
>> compiler/rtm/locking/TestUseRTMForInflatedLocks.java
>> compiler/rtm/locking/TestUseRTMForStackLocks.java
>> compiler/rtm/method_options/TestUseRTMLockElidingOption.java
>> 
>> These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.
>> 
>> Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8183263
>> [2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test
>
> Lgtm.

@phohensee thank you for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/148

From vrudomet at openjdk.org  Tue Nov  8 01:30:56 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 8 Nov 2022 01:30:56 GMT
Subject: [jdk8u-dev] RFR: 7124218: [TEST_BUG] [macosx] Space should select cell
 in the JTable
Message-ID: <7d2_c31CvMNTk85XnVHGnjAprlmyhiK84l2XZFNTWEE=.c0382cc6-9709-4b6d-acb6-f8a92bbcab3a@github.com>

Backport of 2e94af3f3d7010e89852721d1fda7a226e8ffb6c 
[JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218) [TEST_BUG] [macosx] Space should select cell in the JTable

Clean backport. 
Test expectedly fails during manual run, it is fixed by upcoming backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551)

-------------

Commit messages:
 - 7124218: Space should select cell in the JTable

Changes: https://git.openjdk.org/jdk8u-dev/pull/160/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=160&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-7124218
  Stats: 201 lines in 1 file changed: 201 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/160.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/160/head:pull/160

PR: https://git.openjdk.org/jdk8u-dev/pull/160

From yyang at openjdk.org  Tue Nov  8 02:37:20 2022
From: yyang at openjdk.org (Yi Yang)
Date: Tue, 8 Nov 2022 02:37:20 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
Message-ID: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>

8159720: Failure of C2 compilation with tiered prevents some C1 compilations

-------------

Commit messages:
 - 8159720: Failure of C2 compilation with tiered prevents some C1 compilations

Changes: https://git.openjdk.org/jdk8u-dev/pull/161/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=161&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8159720
  Stats: 14 lines in 4 files changed: 0 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/161.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/161/head:pull/161

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From vrudomet at openjdk.org  Tue Nov  8 04:44:59 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 8 Nov 2022 04:44:59 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails on
 MacOS
Message-ID: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>

Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS

Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
No risk, only a test change.
Clean backport except for ProblemList.
Test passes during manual run.

This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

-------------

Commit messages:
 - Backport 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898
 - 7124218: Space should select cell in the JTable

Changes: https://git.openjdk.org/jdk8u-dev/pull/162/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=162&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8233551
  Stats: 209 lines in 1 file changed: 209 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/162.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/162/head:pull/162

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From sgehwolf at openjdk.org  Tue Nov  8 08:53:48 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 08:53:48 GMT
Subject: [jdk8u-dev] RFR: 8295915: Problemlist compiler/rtm failures
 specific to 8u
In-Reply-To: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
References: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
Message-ID: <ZPFjuGGZFaI_mGHB3QnZXNmuELVbHWR8vNx5EbqDW_U=.afafc819-58b6-475a-94df-6a07780e26a2@github.com>

On Tue, 25 Oct 2022 20:18:45 GMT, zzambers <duke at openjdk.org> wrote:

> I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
> List of tests follows:
> 
> compiler/rtm/locking/TestRTMTotalCountIncrRate.java
> compiler/rtm/locking/TestUseRTMAfterLockInflation.java
> compiler/rtm/locking/TestUseRTMForInflatedLocks.java
> compiler/rtm/locking/TestUseRTMForStackLocks.java
> compiler/rtm/method_options/TestUseRTMLockElidingOption.java
> 
> These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.
> 
> Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8183263
> [2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test

OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/148

From sgehwolf at openjdk.org  Tue Nov  8 08:59:35 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 08:59:35 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
Message-ID: <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>

On Tue, 8 Nov 2022 02:29:19 GMT, Yi Yang <yyang at openjdk.org> wrote:

> 8u backport request: Spark observes a significant performance deterioration between jdk17 and jdk8, too many live locals prevent C2 from compilation and it refreshes all tiers of results, please see [SPARK-40303](https://issues.apache.org/jira/browse/SPARK-40303?focusedCommentId=17619978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619978) for more details and explanations. This fix makes C2 compilation failure not affect C1. Low risk and apply clean.
> 
> Please help review it, thanks in advance.

@rwestrel Could you please review this? Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From roland at openjdk.org  Tue Nov  8 10:34:25 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Tue, 8 Nov 2022 10:34:25 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
 <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>
Message-ID: <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>

On Tue, 8 Nov 2022 08:57:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> @rwestrel Could you please review this? Thanks!

The backport is clean so no review required?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From sgehwolf at openjdk.org  Tue Nov  8 11:05:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 11:05:33 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
 <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>
 <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>
Message-ID: <nWuMJx5OhgYiBmUf9GRBOKAnBfeucxKQXav2k7uv4jw=.52f144a8-bfab-4ce0-b464-52c63ef7b7bb@github.com>

On Tue, 8 Nov 2022 10:30:58 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> > @rwestrel Could you please review this? Thanks!
> 
> The backport is clean so no review required?

Technically, yes. But for C2 backports to 8u I'd like for an C2 expert to be OK with it before approving. Is that a reasonable backport to have?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From jdowland at openjdk.org  Tue Nov  8 11:17:39 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 11:17:39 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v6]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <IKvuwwCwuPTEZeKILEWoLuQtK-9XlYIn-cHD7kw-Vao=.be9cdd1f-1c99-4c18-b908-538a25d56969@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Update file path in comment
 - Severin's test fixes. Thanks!

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/135/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/135/files/e4a44241..953e2d21

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=04-05

  Stats: 71 lines in 4 files changed: 50 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Tue Nov  8 11:25:35 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 11:25:35 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v2]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <lOof3YraAt_mHnCWML_Cq_VBWnUt4kOGEQrMJyo5nHM=.22149251-70b9-49f7-a806-055d7daba28b@github.com>

> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Replace log_warning with tty->print_cr

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/158/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/158/files/14ff347d..acf8fc25

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=00-01

  Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From duke at openjdk.org  Tue Nov  8 11:48:21 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 8 Nov 2022 11:48:21 GMT
Subject: [jdk8u-dev] RFR: 8295915: Problemlist compiler/rtm failures
 specific to 8u
In-Reply-To: <ZPFjuGGZFaI_mGHB3QnZXNmuELVbHWR8vNx5EbqDW_U=.afafc819-58b6-475a-94df-6a07780e26a2@github.com>
References: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
 <ZPFjuGGZFaI_mGHB3QnZXNmuELVbHWR8vNx5EbqDW_U=.afafc819-58b6-475a-94df-6a07780e26a2@github.com>
Message-ID: <PxIRA0MKx01v3_ynnflW3uBYed6zV3imL4FUN72koyg=.cd56e1f0-93e0-4bf0-9bce-f3596d834bd3@github.com>

On Tue, 8 Nov 2022 08:50:59 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
>> List of tests follows:
>> 
>> compiler/rtm/locking/TestRTMTotalCountIncrRate.java
>> compiler/rtm/locking/TestUseRTMAfterLockInflation.java
>> compiler/rtm/locking/TestUseRTMForInflatedLocks.java
>> compiler/rtm/locking/TestUseRTMForStackLocks.java
>> compiler/rtm/method_options/TestUseRTMLockElidingOption.java
>> 
>> These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.
>> 
>> Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8183263
>> [2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test
>
> OK.

@jerboaa thank you for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/148

From k.takakuri at fujitsu.com  Tue Nov  8 12:25:40 2022
From: k.takakuri at fujitsu.com (Kazuhisa Takakuri (Fujitsu))
Date: Tue, 8 Nov 2022 12:25:40 +0000
Subject: Please backport JDK-8074883 to 8u.
Message-ID: <OS0PR01MB5778B4B905C37F5C26210752883F9@OS0PR01MB5778.jpnprd01.prod.outlook.com>

Hello.
I want to backport JDK-8074883 to OpenJDK8.

This fix modifies the API exposed in JDK9, so it cannot be backported cleanly.
On JBS it appears to be backported to 8u with JDK-8279783, but it is only in OracleJDK.
There is still the JDK-8074883 issue with the focus behavior of javax.swing.JRadioButton in OpenJDK8.

The fix in OracleJDK is not visible to me.
Is it possible for someone to put in the same backport as Oracle?

Regards,
K. Takakuri

From duke at openjdk.org  Tue Nov  8 12:51:39 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 8 Nov 2022 12:51:39 GMT
Subject: [jdk8u-dev] Integrated: 8295915: Problemlist compiler/rtm failures
 specific to 8u
In-Reply-To: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
References: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
Message-ID: <GnpTcKBVvULkxMx0iEzUjXGVgiz6MLpPRHTu4a4TN7M=.b99d1ad7-28c7-431f-bf59-076f922f4a9f@github.com>

On Tue, 25 Oct 2022 20:18:45 GMT, zzambers <duke at openjdk.org> wrote:

> I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
> List of tests follows:
> 
> compiler/rtm/locking/TestRTMTotalCountIncrRate.java
> compiler/rtm/locking/TestUseRTMAfterLockInflation.java
> compiler/rtm/locking/TestUseRTMForInflatedLocks.java
> compiler/rtm/locking/TestUseRTMForStackLocks.java
> compiler/rtm/method_options/TestUseRTMLockElidingOption.java
> 
> These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.
> 
> Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8183263
> [2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test

This pull request has now been integrated.

Changeset: fb984187
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/fb98418773b63dcbf9fea17d5e660bf4a135017e
Stats:     5 lines in 1 file changed: 5 ins; 0 del; 0 mod

8295915: Problemlist compiler/rtm failures specific to 8u

Reviewed-by: phh, sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/148

From sgehwolf at openjdk.org  Tue Nov  8 13:00:07 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 13:00:07 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v2]
In-Reply-To: <lOof3YraAt_mHnCWML_Cq_VBWnUt4kOGEQrMJyo5nHM=.22149251-70b9-49f7-a806-055d7daba28b@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <lOof3YraAt_mHnCWML_Cq_VBWnUt4kOGEQrMJyo5nHM=.22149251-70b9-49f7-a806-055d7daba28b@github.com>
Message-ID: <zHdTW2k2-KCxdMztBnjD2I9uty6Jt6Fy6l_GzGeT5R8=.5872400f-6a3b-48fe-a08d-857435cd2c24@github.com>

On Tue, 8 Nov 2022 11:25:35 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace log_warning with tty->print_cr

hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java line 168:

> 166: 
> 167:             cgroupv1MntInfoDoubleCpuset = Paths.get(existingDirectory.toString(), "mnt_info_cgroupv1_double_cpuset");
> 168:             Files.writeString(cgroupv1MntInfoDoubleCpuset, mntInfoCgroupv1DoubleCpuset);

Without actually testing the patch. This looks like API not available in 8u. `s/Files.writeString/Files.write/`. Once the depending PR gets updated this would likely need some fix-up as well. I'll looking at recent changes from #135.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Tue Nov  8 14:05:50 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 14:05:50 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v4]
In-Reply-To: <BqYtA7fgC3ojm8WRjdvGn574oxUW6W1AU6dqX_sEip0=.466de12e-e8fc-434b-a10d-91c5061414c5@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <aZ9vErKTdvT07xE6gdfQmJfoVp-dydNeuMPp001rIok=.9e7a2835-0328-4651-86e7-38e32ecf1d97@github.com>
 <BqYtA7fgC3ojm8WRjdvGn574oxUW6W1AU6dqX_sEip0=.466de12e-e8fc-434b-a10d-91c5061414c5@github.com>
Message-ID: <m4Jz5m3atot3EmN0qiOYAX7kcfiE5dT8nlFhLjR1vZ8=.4933ddac-3b07-48cc-baf7-a6a40899e852@github.com>

On Mon, 7 Nov 2022 15:58:13 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> @jmtd Could you please fix the merge conflict in this PR? Thanks!

I don't think there is one any more; the openjdk bot labelled the issue when there was, but has got out of sync with my (unavoidable) rebasing so the label is stale.

> This test also doesn't run on JDK 8u. I had to use this patch:

Thank you, I've pushed that.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Tue Nov  8 14:05:50 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 14:05:50 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v5]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <ZGDl5HAwnkGkSMVhP1Caophb516JIddRAAZ-3Q5wu88=.93465180-d3b1-4e0d-a8d3-f5b35adf08f3@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  Test fix by Severin. Thanks!

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/136/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/136/files/45ec61df..221ef6a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=03-04

  Stats: 33 lines in 2 files changed: 24 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Tue Nov  8 14:09:43 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 14:09:43 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v3]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>

> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request incrementally with three additional commits since the last revision:

 - Merge branch '8239785-jdk8u-dev' into 8253435-jdk8u-dev
 - Update file path in comment
 - Severin's test fixes. Thanks!

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/158/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/158/files/acf8fc25..9b225830

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=01-02

  Stats: 73 lines in 4 files changed: 50 ins; 4 del; 19 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Tue Nov  8 14:49:53 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 8 Nov 2022 14:49:53 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <C_ToFKT8l1rUlKJaDq1WokZA7cgt85xkjvC7HRARXOo=.6dd9e385-5c11-49a4-9b35-7c5c28bd8c6a@github.com>

On Fri, 4 Nov 2022 10:56:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

I've started a backport of the pre-requisite 8197408 (<https://github.com/jmtd/jdk8u-dev/tree/8197408-jdk8u-dev>) but it's not quite finished. It should slot into this sequence between this PR and its current parent (8239559 / pr/136).

As a reminder to myself, once I raise the PR for 8197408 I should /add 8198833

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From duke at openjdk.org  Tue Nov  8 16:52:13 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 8 Nov 2022 16:52:13 GMT
Subject: [jdk8u-dev] RFR: 8296555: Enable hotspot/tier1 for 64-bit builds in
 GHA for 8u
Message-ID: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>

It is now possible to enable hostspot/tier1 in Github Actions at least for 64-bit builds as problematic compiler/rcm tests have been problem listed [1]. So far only for 64-bit builds, as there are still some tests failing for 32-bit builds, which need to be fixed, before it (hotspot/tier1) can be enabled there.

All tests passed.

[1] https://bugs.openjdk.org/browse/JDK-8295915

-------------

Commit messages:
 - Enable hotspot/tier1 for 64-bit builds in GHA for 8u

Changes: https://git.openjdk.org/jdk8u-dev/pull/163/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=163&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296555
  Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/163.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/163/head:pull/163

PR: https://git.openjdk.org/jdk8u-dev/pull/163

From phh at openjdk.org  Tue Nov  8 17:44:21 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 8 Nov 2022 17:44:21 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails
 on MacOS
In-Reply-To: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
Message-ID: <CJOMCvN1yIl_w6Y7s_GBgSrJvbUsKnmeM3p8xkkAv9E=.c51a99f2-dceb-42c8-8bf3-17f1f8e938d9@github.com>

On Tue, 8 Nov 2022 04:36:28 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
> 
> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
> No risk, only a test change.
> Clean backport except for ProblemList.
> Test passes during manual run.
> 
> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

This PR contains the entirety of SelectEditTableCell.java. The latter was created by JDK-7124218 (which you're backporting first), so this PR should include only the edits.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From sgehwolf at openjdk.org  Tue Nov  8 18:55:18 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 18:55:18 GMT
Subject: [jdk8u-dev] Integrated: 8224506: [TESTBUG]
 TestDockerMemoryMetrics.java fails with exitValue = 137
In-Reply-To: <qj9ChC3mApjlzSw9ZEvmXjV4RTVsiYNnI0U147m26Q4=.5f3ea7dc-ee3f-4d76-a9c8-c2a66e5cb53c@github.com>
References: <qj9ChC3mApjlzSw9ZEvmXjV4RTVsiYNnI0U147m26Q4=.5f3ea7dc-ee3f-4d76-a9c8-c2a66e5cb53c@github.com>
Message-ID: <XQsEmzq7sJWT67-tTehnlQOso7zzlYNnzODFIC0_vBM=.1a1af404-876f-4d49-bcb6-a3656e5c3841@github.com>

On Fri, 4 Nov 2022 17:30:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport from 11u which helps testing of cgroups v2 work.

This pull request has now been integrated.

Changeset: 01f7d1e3
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/01f7d1e3735ddddd4bd1796b962cf14395d6f4b2
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137

Backport-of: 1719c0cc12e094856955c2a3294521b79b17ba7c

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/156

From phh at openjdk.org  Tue Nov  8 18:08:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 8 Nov 2022 18:08:39 GMT
Subject: [jdk8u-dev] RFR: 8296555: Enable hotspot/tier1 for 64-bit builds
 in GHA for 8u
In-Reply-To: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
References: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
Message-ID: <7_k6QIdPBK8qpwIeMz0bpOysc-BSU3GobzgwIb1A6vY=.55087de1-2dd6-4aa6-a5ff-d849bd659cc2@github.com>

On Tue, 8 Nov 2022 16:45:36 GMT, zzambers <duke at openjdk.org> wrote:

> It is now possible to enable hostspot/tier1 in Github Actions at least for 64-bit builds as problematic compiler/rtm tests have been problem listed [1]. So far only for 64-bit builds, as there are still some tests failing for 32-bit builds, which need to be fixed, before it (hotspot/tier1) can be enabled there.
> 
> All tests passed.
> 
> [1] https://bugs.openjdk.org/browse/JDK-8295915

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/163

From sgehwolf at openjdk.org  Tue Nov  8 19:35:09 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 8 Nov 2022 19:35:09 GMT
Subject: [jdk8u-dev] RFR: 8296555: Enable hotspot/tier1 for 64-bit builds
 in GHA for 8u
In-Reply-To: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
References: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
Message-ID: <ba7fWwfqc3Kecevcchx94BOYFCMlOIUPIUfTEuZRW54=.b3ba81cb-bed6-44e8-afa9-37ea6a68bd84@github.com>

On Tue, 8 Nov 2022 16:45:36 GMT, zzambers <duke at openjdk.org> wrote:

> It is now possible to enable hostspot/tier1 in Github Actions at least for 64-bit builds as problematic compiler/rtm tests have been problem listed [1]. So far only for 64-bit builds, as there are still some tests failing for 32-bit builds, which need to be fixed, before it (hotspot/tier1) can be enabled there.
> 
> All tests passed.
> 
> [1] https://bugs.openjdk.org/browse/JDK-8295915

Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/163

From duke at openjdk.org  Tue Nov  8 19:35:10 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 8 Nov 2022 19:35:10 GMT
Subject: [jdk8u-dev] Integrated: 8296555: Enable hotspot/tier1 for 64-bit
 builds in GHA for 8u
In-Reply-To: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
References: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
Message-ID: <0XLcbYRd4CZdW9kn9VSwOsTXOMjL7c9KaKEGdle2h5g=.1dfa1d3e-bd4b-4062-9e36-20b213a84aed@github.com>

On Tue, 8 Nov 2022 16:45:36 GMT, zzambers <duke at openjdk.org> wrote:

> It is now possible to enable hostspot/tier1 in Github Actions at least for 64-bit builds as problematic compiler/rtm tests have been problem listed [1]. So far only for 64-bit builds, as there are still some tests failing for 32-bit builds, which need to be fixed, before it (hotspot/tier1) can be enabled there.
> 
> All tests passed.
> 
> [1] https://bugs.openjdk.org/browse/JDK-8295915

This pull request has now been integrated.

Changeset: c605aa3f
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c605aa3f5aa3e2370edcc9b3feb01f6f16541e2e
Stats:     9 lines in 1 file changed: 0 ins; 0 del; 9 mod

8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u

Reviewed-by: phh, sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/163

From duke at openjdk.org  Tue Nov  8 19:35:09 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 8 Nov 2022 19:35:09 GMT
Subject: [jdk8u-dev] RFR: 8296555: Enable hotspot/tier1 for 64-bit builds
 in GHA for 8u
In-Reply-To: <ba7fWwfqc3Kecevcchx94BOYFCMlOIUPIUfTEuZRW54=.b3ba81cb-bed6-44e8-afa9-37ea6a68bd84@github.com>
References: <cpwDXzJJ1AxCHqxlmydloHa5pyMdPckflerVElYsedQ=.ae88dace-3481-48f0-b0ba-9e0a77604a33@github.com>
 <ba7fWwfqc3Kecevcchx94BOYFCMlOIUPIUfTEuZRW54=.b3ba81cb-bed6-44e8-afa9-37ea6a68bd84@github.com>
Message-ID: <wkfAfjfk-88koRvOy7l97ZRf3BSC90X6zNK0wJVE0wg=.39f2814b-38d8-4dc7-9ea4-01a742389e9a@github.com>

On Tue, 8 Nov 2022 18:44:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> It is now possible to enable hostspot/tier1 in Github Actions at least for 64-bit builds as problematic compiler/rtm tests have been problem listed [1]. So far only for 64-bit builds, as there are still some tests failing for 32-bit builds, which need to be fixed, before it (hotspot/tier1) can be enabled there.
>> 
>> All tests passed.
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8295915
>
> Thanks!

@jerboaa @phohensee  Thank you for reviews

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/163

From phh at openjdk.org  Tue Nov  8 19:57:41 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 8 Nov 2022 19:57:41 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
Message-ID: <dGC3cP_Oe9olnqbJ6e3mQVmCppejBeHljWKUFF7gj_U=.687d9aec-6f6c-4a3f-ab81-b8b3f233ee2e@github.com>

On Tue, 8 Nov 2022 02:29:19 GMT, Yi Yang <yyang at openjdk.org> wrote:

> 8u backport request: Spark observes a significant performance deterioration between jdk17 and jdk8, too many live locals prevent C2 from compilation and it refreshes all tiers of results, please see [SPARK-40303](https://issues.apache.org/jira/browse/SPARK-40303?focusedCommentId=17619978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619978) for more details and explanations. This fix makes C2 compilation failure not affect C1. Low risk and apply clean.
> 
> Please help review it, thanks in advance.

Lgtm. This backport doesn't affect C2 itself, it just allows C1 to compile methods that C2 can't.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From xliu at openjdk.org  Tue Nov  8 20:32:30 2022
From: xliu at openjdk.org (Xin Liu)
Date: Tue, 8 Nov 2022 20:32:30 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <7mjhVOZ2AmMldUxSvH6s9Acjlp7KIks4oYkJ0qnD8Ok=.7e83f735-7206-4d55-864b-7f1d922a78a3@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
 <7mjhVOZ2AmMldUxSvH6s9Acjlp7KIks4oYkJ0qnD8Ok=.7e83f735-7206-4d55-864b-7f1d922a78a3@github.com>
Message-ID: <dGcKm-sKK1iauMAJDQAsOsW1TZQEz18zLvI7C2hb1Lc=.b1f98fc9-d14c-4205-b387-6fce99e584d8@github.com>

On Thu, 3 Nov 2022 09:59:14 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> Patched file location difference: JDK: `./src/java.base/macosx/native/libjava/java_props_macosx.c` JDK8: `./jdk/src/solaris/native/java/lang/java_props_macosx.c`
> 
> It seems it's not possible to apply this patch avoiding manual merge in a way described, right?

You are right. From my reading, @benty-amzn just reverted what you did(step-1) and re-applied it(step-3) after JDK-8257620.  There's a typo in his description. It should be 'JDK-8269850' rather than 'JDK-826985' in step-3.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From vrudomet at openjdk.org  Tue Nov  8 20:35:34 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 8 Nov 2022 20:35:34 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails
 on MacOS [v2]
In-Reply-To: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
Message-ID: <GgYGvxBBLeyAuiRr2ot9jjeIM_TGCjwP2hFYGgT37qM=.e0d1385e-c9bc-4316-8085-d23fdaba0811@github.com>

> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
> 
> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
> No risk, only a test change.
> Clean backport except for ProblemList.
> Test passes during manual run.
> 
> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/162/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/162/files/0a870669..0a870669

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=162&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=162&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/162.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/162/head:pull/162

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From vrudomet at openjdk.org  Tue Nov  8 20:35:34 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 8 Nov 2022 20:35:34 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails
 on MacOS
In-Reply-To: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
Message-ID: <kmUPKPvQv5qbexeh1OJm7EUHg7GHIcI9GXdS1FWFT8g=.74aff1f9-ac46-4940-a5b6-c8eca562feb8@github.com>

On Tue, 8 Nov 2022 04:36:28 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
> 
> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
> No risk, only a test change.
> Clean backport except for ProblemList.
> Test passes during manual run.
> 
> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

Thank you. I've changed the base of this PR to pr160, so the only changes seen here are the actual pr162 changes.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From phh at openjdk.org  Tue Nov  8 21:40:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 8 Nov 2022 21:40:39 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails
 on MacOS [v2]
In-Reply-To: <GgYGvxBBLeyAuiRr2ot9jjeIM_TGCjwP2hFYGgT37qM=.e0d1385e-c9bc-4316-8085-d23fdaba0811@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
 <GgYGvxBBLeyAuiRr2ot9jjeIM_TGCjwP2hFYGgT37qM=.e0d1385e-c9bc-4316-8085-d23fdaba0811@github.com>
Message-ID: <IY7nd3S9tyGadXfoITmEUQFDFejLIWJZWdihUdhSERg=.2e21461e-78c6-41bf-a87a-39c9b9c97955@github.com>

On Tue, 8 Nov 2022 20:35:34 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

>> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
>> 
>> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
>> No risk, only a test change.
>> Clean backport except for ProblemList.
>> Test passes during manual run.
>> 
>> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160
>
> Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Thanks, Victor. Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From phh at openjdk.org  Tue Nov  8 21:42:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 8 Nov 2022 21:42:39 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
Message-ID: <WAI0uQOqNipa-J6RFAMMAxcSq55EkULj3JmJk-8a-Ok=.4fde49c5-88e9-48b0-9471-904ea6b92d40@github.com>

On Tue, 8 Nov 2022 02:29:19 GMT, Yi Yang <yyang at openjdk.org> wrote:

> 8u backport request: Spark observes a significant performance deterioration between jdk17 and jdk8, too many live locals prevent C2 from compilation and it refreshes all tiers of results, please see [SPARK-40303](https://issues.apache.org/jira/browse/SPARK-40303?focusedCommentId=17619978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619978) for more details and explanations. This fix makes C2 compilation failure not affect C1. Low risk and apply clean.
> 
> Please help review it, thanks in advance.

Tagged the JBS issue.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From yyang at openjdk.org  Wed Nov  9 01:20:16 2022
From: yyang at openjdk.org (Yi Yang)
Date: Wed, 9 Nov 2022 01:20:16 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
Message-ID: <Canu7rB0qPwFR87-OUGIxFPS9A-lzeqmwbeJF-25LlQ=.1e9dfd95-fc08-4dc2-bdde-c7003a680d12@github.com>

On Tue, 8 Nov 2022 02:29:19 GMT, Yi Yang <yyang at openjdk.org> wrote:

> 8u backport request: Spark observes a significant performance deterioration between jdk17 and jdk8, too many live locals prevent C2 from compilation and it refreshes all tiers of results, please see [SPARK-40303](https://issues.apache.org/jira/browse/SPARK-40303?focusedCommentId=17619978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619978) for more details and explanations. This fix makes C2 compilation failure not affect C1. Low risk and apply clean.
> 
> Please help review it, thanks in advance.

Thanks for reviews.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From jdowland at openjdk.org  Wed Nov  9 10:32:19 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 9 Nov 2022 10:32:19 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup in
 os_linux.cpp
Message-ID: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>

This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)

Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.

Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/136

Commit messages:
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp

Changes: https://git.openjdk.org/jdk8u-dev/pull/164/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8197408
  Stats: 82 lines in 2 files changed: 81 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/164.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/164/head:pull/164

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Wed Nov  9 11:11:36 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 9 Nov 2022 11:11:36 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <JrqxzoHgVOHzw37wd6Dn_nkHmO3LgsgjqEOR3QiGx4w=.b2700a40-55b3-4d7e-bdff-2adc28241e8c@github.com>

On Wed, 9 Nov 2022 10:25:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

Test builds, runs and fails with

STATUS:Failed.`main' threw exception: java.lang.RuntimeException: '^.*CPU Shares is: *(\\d+|-1|Unlimited).*$' missing from stdout/stderr

which I think is resolved by 8278951 (confirming)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From roland at openjdk.org  Wed Nov  9 12:03:40 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Wed, 9 Nov 2022 12:03:40 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
 <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>
 <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>
Message-ID: <fmMEgWKMJ-m_NXRcBG6AkFD0e61voLC1EMt1nCiJ8IU=.e4a78712-ede8-4ebd-9a56-bc5fbe825bf8@github.com>

On Tue, 8 Nov 2022 10:30:58 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> @rwestrel Could you please review this? Thanks!
>
>> @rwestrel Could you please review this? Thanks!
> 
> The backport is clean so no review required?

> > > @rwestrel Could you please review this? Thanks!
> > 
> > 
> > The backport is clean so no review required?
> 
> Technically, yes. But for C2 backports to 8u I'd like for an C2 expert to be OK with it before approving. Is that a reasonable backport to have?

I agree with @kelthuzadx that it's low risk and as it was seen to help in the "real world", then backporting makes sense.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From sgehwolf at openjdk.org  Wed Nov  9 13:25:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 9 Nov 2022 13:25:33 GMT
Subject: [jdk8u-dev] RFR: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <fmMEgWKMJ-m_NXRcBG6AkFD0e61voLC1EMt1nCiJ8IU=.e4a78712-ede8-4ebd-9a56-bc5fbe825bf8@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
 <tEP67XLu3WN2E-ydzVbZ3brO3z7BjagcI207rBSLaeY=.ed685a53-dd61-453c-a6ee-d8de18d67d59@github.com>
 <CdrRJ2WetttitFhTn2rXJmL46L5ZOJg4eyv1tex_QBA=.255d593e-3d17-48da-b616-c8b082356a85@github.com>
 <fmMEgWKMJ-m_NXRcBG6AkFD0e61voLC1EMt1nCiJ8IU=.e4a78712-ede8-4ebd-9a56-bc5fbe825bf8@github.com>
Message-ID: <-aizbMyCaS21UWsRm2dFaV1nMw1WGjFpLXn5ASU9IGA=.20b4a6d0-bcd8-4172-ae23-c39069821c8a@github.com>

On Wed, 9 Nov 2022 11:59:56 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> > Technically, yes. But for C2 backports to 8u I'd like for an C2 expert to be OK with it before approving. Is that a reasonable backport to have?
> 
> I agree with @kelthuzadx that it's low risk and as it was seen to help in the "real world", then backporting makes sense.

Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From yyang at openjdk.org  Wed Nov  9 15:34:33 2022
From: yyang at openjdk.org (Yi Yang)
Date: Wed, 9 Nov 2022 15:34:33 GMT
Subject: [jdk8u-dev] Integrated: 8159720: Failure of C2 compilation with tiered
 prevents some C1 compilations
In-Reply-To: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
References: <psJ6Fzsb2vsi-_2RxpFlZz34TCUXN4W2bBbLaP8cbeg=.9a063a4e-e757-48ca-8187-c1cabfb98d53@github.com>
Message-ID: <JMbzQ8tWELgbhDFb50sfQOQgu1lt65pMmc7Okd8-rN0=.6334fd8f-291e-4946-b74b-f592ed58cfe0@github.com>

On Tue, 8 Nov 2022 02:29:19 GMT, Yi Yang <yyang at openjdk.org> wrote:

> 8u backport request: Spark observes a significant performance deterioration between jdk17 and jdk8, too many live locals prevent C2 from compilation and it refreshes all tiers of results, please see [SPARK-40303](https://issues.apache.org/jira/browse/SPARK-40303?focusedCommentId=17619978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619978) for more details and explanations. This fix makes C2 compilation failure not affect C1. Low risk and apply clean.
> 
> Please help review it, thanks in advance.

This pull request has now been integrated.

Changeset: 6e563e59
Author:    Yi Yang <yyang at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6e563e59f3b4a9b25b4d52975daf4047f52d5b61
Stats:     14 lines in 4 files changed: 0 ins; 4 del; 10 mod

8159720: Failure of C2 compilation with tiered prevents some C1 compilations

If C2 fails to compile a method with tiered compilation, then it should mark the method as not compileable on the C2 tier only.

Reviewed-by: phh
Backport-of: cc10eca0b07f03d4765713d86eae39959f555c1f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/161

From andrew at openjdk.org  Wed Nov  9 16:02:45 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 9 Nov 2022 16:02:45 GMT
Subject: [jdk8u-dev] RFR: 8255559: Leak File Descriptors Because of
 ResolverLocalFilesystem#engineResolveURI()
Message-ID: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>

Clean backport from 11u which fixes a resource leak.

Although the indentation changes in the diff make it a little unclear, the only change is to wrap the block in a `try-finally` clause (more visible with `git diff -b`)

-------------

Commit messages:
 - Backport d53072236c503295b893efa6372c869ac84fa688

Changes: https://git.openjdk.org/jdk8u-dev/pull/165/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=165&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8255559
  Stats: 44 lines in 1 file changed: 17 ins; 11 del; 16 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/165.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/165/head:pull/165

PR: https://git.openjdk.org/jdk8u-dev/pull/165

From duke at openjdk.org  Wed Nov  9 17:26:49 2022
From: duke at openjdk.org (Dan Lutker)
Date: Wed, 9 Nov 2022 17:26:49 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use old/deprecated
 image on AArch64
Message-ID: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>

Backport trivial test fix to use correct base image architecture for aarch64.

Patch applied cleanly.

-------------

Commit messages:
 - Backport of 71ac3d952b6d5bf9eb08ec7daf07225b1ab66216

Changes: https://git.openjdk.org/jdk8u-dev/pull/166/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=166&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8221529
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/166.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/166/head:pull/166

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From vrudomet at openjdk.org  Wed Nov  9 17:46:45 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Wed, 9 Nov 2022 17:46:45 GMT
Subject: [jdk8u-dev] Integrated: 7124218: [TEST_BUG] [macosx] Space should
 select cell in the JTable
In-Reply-To: <7d2_c31CvMNTk85XnVHGnjAprlmyhiK84l2XZFNTWEE=.c0382cc6-9709-4b6d-acb6-f8a92bbcab3a@github.com>
References: <7d2_c31CvMNTk85XnVHGnjAprlmyhiK84l2XZFNTWEE=.c0382cc6-9709-4b6d-acb6-f8a92bbcab3a@github.com>
Message-ID: <jruoceFCFUASXZhZg8uizhqIbEL_-4Area1E86mhGCk=.a655c6f4-dd72-4923-a734-0e4ac362303a@github.com>

On Tue, 8 Nov 2022 01:23:51 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport of 2e94af3f3d7010e89852721d1fda7a226e8ffb6c 
> [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218) [TEST_BUG] [macosx] Space should select cell in the JTable
> 
> Clean backport. 
> Test expectedly fails during manual run, it is fixed by upcoming backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) https://github.com/openjdk/jdk8u-dev/pull/162

This pull request has now been integrated.

Changeset: 0f9095fb
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0f9095fbc3f61cc376ef6d6c793b5761eb64433b
Stats:     201 lines in 1 file changed: 201 ins; 0 del; 0 mod

7124218: [TEST_BUG] [macosx] Space should select cell in the JTable

Backport-of: 2e94af3f3d7010e89852721d1fda7a226e8ffb6c

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/160

From vrudomet at openjdk.org  Wed Nov  9 18:04:12 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Wed, 9 Nov 2022 18:04:12 GMT
Subject: [jdk8u-dev] RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails
 on MacOS [v3]
In-Reply-To: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
Message-ID: <bAwO1pVqV-rmlA9uNGvCvn968s_4BVEYmIBRvaK_IkU=.7b5a64eb-5296-4bda-a8d8-d6a97e86f61c@github.com>

> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
> 
> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
> No risk, only a test change.
> Clean backport except for ProblemList.
> Test passes during manual run.
> 
> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8233551
 - Backport 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898
 - 7124218: Space should select cell in the JTable
   
   Reviewed-by: rchamyal, alexsch
   (cherry picked from commit 2e94af3f3d7010e89852721d1fda7a226e8ffb6c)

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/162/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/162/files/0a870669..b4d24d37

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=162&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=162&range=01-02

  Stats: 212 lines in 10 files changed: 165 ins; 24 del; 23 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/162.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/162/head:pull/162

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From sgehwolf at openjdk.org  Wed Nov  9 18:39:38 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 9 Nov 2022 18:39:38 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v6]
In-Reply-To: <IKvuwwCwuPTEZeKILEWoLuQtK-9XlYIn-cHD7kw-Vao=.be9cdd1f-1c99-4c18-b908-538a25d56969@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
 <IKvuwwCwuPTEZeKILEWoLuQtK-9XlYIn-cHD7kw-Vao=.be9cdd1f-1c99-4c18-b908-538a25d56969@github.com>
Message-ID: <Qbn43eWx6GJ9_p3ZQO8uCSvc4SHcxKy4mMqCYt7sIIc=.3505401e-db95-43bb-af4d-b1459113db48@github.com>

On Tue, 8 Nov 2022 11:17:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
>> 
>> It does not apply clean:
>> 
>>  * context issues for changes made for the different approach for logging in 8u
>>  * copyright lines
>> 
>> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Update file path in comment
>  - Severin's test fixes. Thanks!

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Wed Nov  9 18:51:32 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 9 Nov 2022 18:51:32 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64
In-Reply-To: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
Message-ID: <mkda1e-dlzmCl9ieQ4t80OJ_1aAZ0myMSr_fwRtbTIw=.b9e05ba3-5f77-4b58-b0d0-db2a3e31c559@github.com>

On Wed, 9 Nov 2022 17:12:46 GMT, Dan Lutker <duke at openjdk.org> wrote:

> Backport trivial test fix to use correct base image architecture for aarch64.
> 
> Patch applied cleanly.

There is another instance of this for the hotspot container tests in `hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java`. Do you want to fix that too?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From duke at openjdk.org  Wed Nov  9 19:14:26 2022
From: duke at openjdk.org (Dan Lutker)
Date: Wed, 9 Nov 2022 19:14:26 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64 [v2]
In-Reply-To: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
Message-ID: <N5YCV5Z7PZl3mjEU90Pf7vcc-tfkRQUkfLmt7QZllHc=.433a615d-9c20-4a22-a294-c536951b5c2f@github.com>

> Backport trivial test fix to use correct base image architecture for aarch64.
> 
> Patch applied cleanly.

Dan Lutker has updated the pull request incrementally with one additional commit since the last revision:

  8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/166/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/166/files/a9d120c9..091b69c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=166&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=166&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/166.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/166/head:pull/166

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From duke at openjdk.org  Wed Nov  9 19:14:27 2022
From: duke at openjdk.org (Dan Lutker)
Date: Wed, 9 Nov 2022 19:14:27 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64 [v2]
In-Reply-To: <mkda1e-dlzmCl9ieQ4t80OJ_1aAZ0myMSr_fwRtbTIw=.b9e05ba3-5f77-4b58-b0d0-db2a3e31c559@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
 <mkda1e-dlzmCl9ieQ4t80OJ_1aAZ0myMSr_fwRtbTIw=.b9e05ba3-5f77-4b58-b0d0-db2a3e31c559@github.com>
Message-ID: <zyQp1w_GwCwXdkLfcWBq-9hBXkpal4FqcvN0zEkaaD0=.3d24bf97-2c5c-4e61-b241-10aa5862394d@github.com>

On Wed, 9 Nov 2022 18:49:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> There is another instance of this for the hotspot container tests in `hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java`. Do you want to fix that too?

Thanks for calling that out. Added a 2nd commit fixing that file, I think the bot will squash on commit, correct?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From duke at openjdk.org  Wed Nov  9 19:14:47 2022
From: duke at openjdk.org (Joshua Cao)
Date: Wed, 9 Nov 2022 19:14:47 GMT
Subject: [jdk8u-dev] Integrated: 8295288: Some vm_flags tests associate with a
 wrong BugID
In-Reply-To: <Ff_cRFUnkmIeHWv5mVJZZqPzv-XZoTGLKVwqmq4O4KY=.08e33bf2-6c96-46de-b4af-b0d0af4d93ad@github.com>
References: <Ff_cRFUnkmIeHWv5mVJZZqPzv-XZoTGLKVwqmq4O4KY=.08e33bf2-6c96-46de-b4af-b0d0af4d93ad@github.com>
Message-ID: <2f9Qb4mPR_7luNkUzg5cEPa92kwNGwfCl5xfe7Ff5Dw=.f3b6c065-e563-42fc-978a-60f9bfbcd9cf@github.com>

On Tue, 25 Oct 2022 00:28:07 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Backport is not clean. Test header is different between JDK8 and JDK11. All changed tests passing.

This pull request has now been integrated.

Changeset: 736c1fb1
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/736c1fb18fd8a5ee146ac0437193c4d59317161b
Stats:     5 lines in 5 files changed: 0 ins; 0 del; 5 mod

8295288: Some vm_flags tests associate with a wrong BugID

Backport-of: 3dbc38a2c903f533ace847a3bc0d2687f263fafd

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/147

From vrudomet at openjdk.org  Wed Nov  9 19:42:09 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Wed, 9 Nov 2022 19:42:09 GMT
Subject: [jdk8u-dev] Integrated: 8233551: [TESTBUG] SelectEditTableCell.java
 fails on MacOS
In-Reply-To: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
References: <NQsLqwLvmDYb3g84LO18GXjCO39KWVPWSN17Sa2y3jI=.936577ab-656e-4ecc-9175-a32f8cceeab2@github.com>
Message-ID: <ea44V4CgLM3Dn3_O4zjtmCNP_uockTFHCtrAhwTr4DU=.b2c3e650-99c3-4181-8cd5-2bdcfc8a46b5@github.com>

On Tue, 8 Nov 2022 04:36:28 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for [JDK-8233551](https://bugs.openjdk.org/browse/JDK-8233551) [TESTBUG] SelectEditTableCell.java fails on MacOS (https://github.com/openjdk/jdk/commit/9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898)
> 
> Backport for test fix from [JDK-7124218](https://bugs.openjdk.org/browse/JDK-7124218).
> No risk, only a test change.
> Clean backport except for ProblemList.
> Test passes during manual run.
> 
> This PR depends on https://github.com/openjdk/jdk8u-dev/pull/160

This pull request has now been integrated.

Changeset: 3a1a2e02
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/3a1a2e02d6f410a59fa163da2f1d30204beaa379
Stats:     21 lines in 1 file changed: 9 ins; 1 del; 11 mod

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

Reviewed-by: phh
Backport-of: 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/162

From duke at openjdk.org  Wed Nov  9 23:42:27 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 9 Nov 2022 23:42:27 GMT
Subject: [jdk8u-dev] RFR: 8284622: Update versions of some Github Actions used
 in JDK workflow
Message-ID: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>

This backport fixes warnings generated in summary page of GHA tests by updating version of some actions.

**Backport fixes warnings of following form:**

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout


The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/


**Backport does not fix warnings of following form:**

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

These will be fixed in separate PR as backport of JDK-8295714 [1].

[1] https://bugs.openjdk.org/browse/JDK-8295714

-------------

Commit messages:
 - Backport 61b8c91249fb4c6d594d4a0240c92e8607caf171

Changes: https://git.openjdk.org/jdk8u-dev/pull/167/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=167&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284622
  Stats: 75 lines in 1 file changed: 0 ins; 0 del; 75 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/167.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/167/head:pull/167

PR: https://git.openjdk.org/jdk8u-dev/pull/167

From sgehwolf at openjdk.org  Thu Nov 10 09:04:19 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 09:04:19 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64 [v2]
In-Reply-To: <N5YCV5Z7PZl3mjEU90Pf7vcc-tfkRQUkfLmt7QZllHc=.433a615d-9c20-4a22-a294-c536951b5c2f@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
 <N5YCV5Z7PZl3mjEU90Pf7vcc-tfkRQUkfLmt7QZllHc=.433a615d-9c20-4a22-a294-c536951b5c2f@github.com>
Message-ID: <JIZZ-2qaW5aMgOTSUPHpRHPgZSnTTc8B0edzo9BrFHg=.bb3ca264-67bd-4808-bf4b-9bf9824b69cb@github.com>

On Wed, 9 Nov 2022 19:14:26 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Backport trivial test fix to use correct base image architecture for aarch64.
>> 
>> Patch applied cleanly.
>
> Dan Lutker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64

Looks fine.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From sgehwolf at openjdk.org  Thu Nov 10 09:04:21 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 09:04:21 GMT
Subject: [jdk8u-dev] RFR: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64 [v2]
In-Reply-To: <zyQp1w_GwCwXdkLfcWBq-9hBXkpal4FqcvN0zEkaaD0=.3d24bf97-2c5c-4e61-b241-10aa5862394d@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
 <mkda1e-dlzmCl9ieQ4t80OJ_1aAZ0myMSr_fwRtbTIw=.b9e05ba3-5f77-4b58-b0d0-db2a3e31c559@github.com>
 <zyQp1w_GwCwXdkLfcWBq-9hBXkpal4FqcvN0zEkaaD0=.3d24bf97-2c5c-4e61-b241-10aa5862394d@github.com>
Message-ID: <ovY2a0j3qr-6ObXcSSkEVGF04WAEbo1HdUWYK6TsQ7M=.45387baa-1161-4b1b-8afe-dbe924b3bae0@github.com>

On Wed, 9 Nov 2022 19:10:42 GMT, Dan Lutker <duke at openjdk.org> wrote:

> Added a 2nd commit fixing that file, I think the bot will squash on commit, correct?

Yes.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From sgehwolf at openjdk.org  Thu Nov 10 09:11:49 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 09:11:49 GMT
Subject: [jdk8u-dev] RFR: 8284622: Update versions of some Github Actions
 used in JDK workflow
In-Reply-To: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>
References: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>
Message-ID: <VdUpUz_sakWKRGySmordKcfPh-kUbGCFQp3A4_aUsNA=.cd24df19-6a06-49d8-9475-ebd444972ea7@github.com>

On Wed, 9 Nov 2022 23:33:40 GMT, zzambers <duke at openjdk.org> wrote:

> This backport fixes warnings generated in summary page of GHA tests by updating version of some actions.
> 
> **Backport fixes warnings of following form:**
> 
> Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout
> 
> 
> The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
> 
> 
> **Backport does not fix warnings of following form:**
> 
> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
> 
> These will be fixed in separate PR as backport of JDK-8295714 [1].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8295714

Looks fine.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/167

From jdowland at openjdk.org  Thu Nov 10 10:41:43 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 10 Nov 2022 10:41:43 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <0LWslP4TJ_Ea2qBPk1-bXwEOZXoqpzsTDy5qDhHVTIE=.30cf5a83-b13a-4636-9522-2822fd2b4364@github.com>

On Wed, 9 Nov 2022 10:25:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

The test passes for me in a cgroups v1 host. I think the state (passes on v1, fails on v2) is consistent with the state of things when this patch was committed. I think a later patch might fix this for v2, but it's moot if we consider backporting 8281181, which removes the check against CPU Shares entirely.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Thu Nov 10 10:50:32 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 10 Nov 2022 10:50:32 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <S8mH-_n4Y5TixifsHGxKEFXo9mJ4QL2Ld-ghlCf-dTs=.76600d20-8a5b-4eae-ba11-b9f84cda6253@github.com>

On Fri, 4 Nov 2022 10:56:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

Same test behaviour as the parent PR: passes on cgroups v1, fails on v2.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From duke at openjdk.org  Thu Nov 10 12:40:27 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 10 Nov 2022 12:40:27 GMT
Subject: [jdk8u-dev] RFR: 8284622: Update versions of some Github Actions
 used in JDK workflow
In-Reply-To: <VdUpUz_sakWKRGySmordKcfPh-kUbGCFQp3A4_aUsNA=.cd24df19-6a06-49d8-9475-ebd444972ea7@github.com>
References: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>
 <VdUpUz_sakWKRGySmordKcfPh-kUbGCFQp3A4_aUsNA=.cd24df19-6a06-49d8-9475-ebd444972ea7@github.com>
Message-ID: <5TK0KaZ6jodrfsFTgn-6MiW2wkpwBnrhCkZk5GddsC8=.34caa698-1f57-4840-ab70-e81c435d0def@github.com>

On Thu, 10 Nov 2022 09:07:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This backport fixes warnings generated in summary page of GHA tests by updating version of some actions.
>> 
>> **Backport fixes warnings of following form:**
>> 
>> Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout
>> 
>> 
>> The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
>> 
>> 
>> **Backport does not fix warnings of following form:**
>> 
>> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
>> 
>> These will be fixed in separate PR as backport of JDK-8295714 [1].
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8295714
>
> Looks fine.

@jerboaa Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/167

From duke at openjdk.org  Thu Nov 10 13:00:40 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 10 Nov 2022 13:00:40 GMT
Subject: [jdk8u-dev] Integrated: 8284622: Update versions of some Github
 Actions used in JDK workflow
In-Reply-To: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>
References: <NxQIQWYii2XZ2S2Wmjnm965V0iPs_VDM2lKqeTmXBHY=.286113b7-a5db-4a17-8c2b-3880854fecd5@github.com>
Message-ID: <ScTBZ8382irl0PrsMMane7nT7bYi7mkBwO4Md67DHys=.3dbae824-f1d0-4fa4-8eb1-1b8669033952@github.com>

On Wed, 9 Nov 2022 23:33:40 GMT, zzambers <duke at openjdk.org> wrote:

> This backport fixes warnings generated in summary page of GHA tests by updating version of some actions.
> 
> **Backport fixes warnings of following form:**
> 
> Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout
> 
> 
> The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
> 
> 
> **Backport does not fix warnings of following form:**
> 
> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
> 
> These will be fixed in separate PR as backport of JDK-8295714 [1].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8295714

This pull request has now been integrated.

Changeset: 3bfde7d0
Author:    Christoph Langer <clanger at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/3bfde7d03d594ea37dab54c73ee24c13c29b1150
Stats:     75 lines in 1 file changed: 0 ins; 0 del; 75 mod

8284622: Update versions of some Github Actions used in JDK workflow

Reviewed-by: sgehwolf
Backport-of: 61b8c91249fb4c6d594d4a0240c92e8607caf171

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/167

From sgehwolf at openjdk.org  Thu Nov 10 13:21:39 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 13:21:39 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp
In-Reply-To: <0LWslP4TJ_Ea2qBPk1-bXwEOZXoqpzsTDy5qDhHVTIE=.30cf5a83-b13a-4636-9522-2822fd2b4364@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
 <0LWslP4TJ_Ea2qBPk1-bXwEOZXoqpzsTDy5qDhHVTIE=.30cf5a83-b13a-4636-9522-2822fd2b4364@github.com>
Message-ID: <D3g561y6ozp42zY4mGm4uH4X4i2PjLDMHvm_-7tvdf4=.140148dc-7981-4254-aef2-28a903ea7906@github.com>

On Thu, 10 Nov 2022 10:39:19 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> The test passes for me in a cgroups v1 host. I think the state (passes on v1, fails on v2) is consistent with the state of things when this patch was committed. I think a later patch might fix this for v2

This perhaps? https://bugs.openjdk.org/browse/JDK-8291570

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From sgehwolf at openjdk.org  Thu Nov 10 14:05:31 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 14:05:31 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v5]
In-Reply-To: <ZGDl5HAwnkGkSMVhP1Caophb516JIddRAAZ-3Q5wu88=.93465180-d3b1-4e0d-a8d3-f5b35adf08f3@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <ZGDl5HAwnkGkSMVhP1Caophb516JIddRAAZ-3Q5wu88=.93465180-d3b1-4e0d-a8d3-f5b35adf08f3@github.com>
Message-ID: <JJUpRwv3Cj82Ca78p8bRVniqshb1fsW1iuII7q67u1o=.c836514c-1dfc-498a-ae01-3f4beeda8893@github.com>

On Tue, 8 Nov 2022 14:05:50 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
>> 
>> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
>> 
>> I also had to Optional.isEmpty which is not present in 8u's Optional.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Test fix by Severin. Thanks!

This looks good now.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Thu Nov 10 14:20:34 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 10 Nov 2022 14:20:34 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp
In-Reply-To: <D3g561y6ozp42zY4mGm4uH4X4i2PjLDMHvm_-7tvdf4=.140148dc-7981-4254-aef2-28a903ea7906@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
 <0LWslP4TJ_Ea2qBPk1-bXwEOZXoqpzsTDy5qDhHVTIE=.30cf5a83-b13a-4636-9522-2822fd2b4364@github.com>
 <D3g561y6ozp42zY4mGm4uH4X4i2PjLDMHvm_-7tvdf4=.140148dc-7981-4254-aef2-28a903ea7906@github.com>
Message-ID: <Ah2IvvdxS593DfB8mQ3CKVLfEmSAf_clCW8W8fyuwX4=.e12e43ab-bc5d-4d6b-a0f9-6115a8384a0e@github.com>

On Thu, 10 Nov 2022 13:17:43 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> This perhaps? https://bugs.openjdk.org/browse/JDK-8291570

That's the one! I think we should add this to our cgroups v2 8u list.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From sgehwolf at openjdk.org  Thu Nov 10 16:16:02 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 16:16:02 GMT
Subject: [jdk8u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits reported
 incorrectly
Message-ID: <Q-KEOu8M2rYgapZvIwnwWSUb_4ZFQb0eIKjXWqYp2Og=.9e0cbb72-5659-43bb-83b3-8e684f94d7c1@github.com>

Clean backport to the 11u version. Only path changes.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/130

Commit messages:
 - 8253727: [cgroups v2] Memory and swap limits reported incorrectly

Changes: https://git.openjdk.org/jdk8u-dev/pull/168/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=168&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8253727
  Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/168.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/168/head:pull/168

PR: https://git.openjdk.org/jdk8u-dev/pull/168

From andrew at openjdk.org  Thu Nov 10 17:13:37 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 10 Nov 2022 17:13:37 GMT
Subject: [jdk8u-dev] RFR: 8255559: Leak File Descriptors Because of
 ResolverLocalFilesystem#engineResolveURI()
In-Reply-To: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
References: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
Message-ID: <3Sa3SNVfUusoMuMA8kVGtwjSgY5YfFEQAZ8CL1S0xqo=.051c31c1-38f0-4c46-82ef-1a952c01f66e@github.com>

On Wed, 9 Nov 2022 15:52:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Clean backport from 11u which fixes a resource leak.
> 
> Although the indentation changes in the diff make it a little unclear, the only change is to wrap the block in a `try-finally` clause (more visible with `git diff -b`)

Approval requested on the bug.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/165

From sgehwolf at openjdk.org  Thu Nov 10 17:24:25 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 17:24:25 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <lubM-E_piJmTj5YEOdwe-PLkbEgmGzFmGaf6K6FjIWs=.3d5fec35-4aa3-486f-b0f0-775c7641a293@github.com>

On Wed, 9 Nov 2022 10:25:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

Looks OK to me. Code changes missing from the patch are already in 8u (and came there with the initial integration 392e56e410728a1776e5b211b3d811f9af44143a).

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From sgehwolf at openjdk.org  Thu Nov 10 17:37:44 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 10 Nov 2022 17:37:44 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <fMyype0FEokIU-o2yDGOsjqUrGyWamSGF075sWSMpT4=.629eae2f-bf9e-4c52-8486-da69c4d49478@github.com>

On Fri, 4 Nov 2022 10:56:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From duke at openjdk.org  Fri Nov 11 00:47:40 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 11 Nov 2022 00:47:40 GMT
Subject: [jdk8u-dev] RFR: 8159599: [TEST_BUG]
 java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
In-Reply-To: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
References: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
Message-ID: <LE-pjg5cvcKlngMr1HfQ0mfORb3srGeGS_CEb2Sw7PU=.af9331af-740e-4f4b-b1e1-97b92a5721f1@github.com>

On Tue, 11 Oct 2022 17:19:59 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Backport for parity with Oracle.
> 
> Backport does not apply to ProblemList.txt because the affected test is not there in JDK8. Cleanly applies to SimpleWindowActivationTest.java after fixing paths.

no `jdk-8u-fix-request-yes` yet. leaving this open.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/134

From sgehwolf at openjdk.org  Fri Nov 11 10:58:08 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 10:58:08 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <ULe9ympgDgTbMG2PVKt1zCOV0MBGl2sd23Y5zbHQHHw=.27cc3e8c-6458-45a8-9321-f5232b2522a1@github.com>

On Mon, 7 Nov 2022 10:03:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Clean backport, only path changes. Marking as such.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From sgehwolf at openjdk.org  Fri Nov 11 13:14:38 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 13:14:38 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v3]
In-Reply-To: <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
Message-ID: <3kWNphsIip3J8xVF1vhmmnwKQd78sQ6TL87cdEE_wxY=.3cbc0b2e-8f62-478a-a262-e48818937f39@github.com>

On Tue, 8 Nov 2022 14:09:43 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Merge branch '8239785-jdk8u-dev' into 8253435-jdk8u-dev
>  - Update file path in comment
>  - Severin's test fixes. Thanks!

There seems to be a problem with this PR. It shows commits [not part of this PR](https://github.com/openjdk/jdk8u-dev/pull/158/commits/f81f0a51f183d38248fdee4242f012257076d6ab), but others (e.g. #135). The bot is also not happy about it. Before this can get properly reviewed, this would need some fixup.

hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java line 259:

> 257:   public native boolean isContainerized();
> 258:   public native void printOsInfo();
> 259:   public native int validateCgroup(String procCgroups,

This doesn't look right. It's part of #135. See: https://github.com/openjdk/jdk8u-dev/pull/135/files#diff-840578f66556c33204f36e83d8c5a6b6b91c0280ffdbbea6121847a5b6b1afe7R259

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Fri Nov 11 14:15:38 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 14:15:38 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v3]
In-Reply-To: <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
Message-ID: <8E3cYbA5wg_2MG4IvY6AA5vPPhzrUx2pXYnHwSegq4I=.c1802028-cfa4-4c0a-ab51-dca510eee08a@github.com>

On Tue, 8 Nov 2022 14:09:43 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Merge branch '8239785-jdk8u-dev' into 8253435-jdk8u-dev
>  - Update file path in comment
>  - Severin's test fixes. Thanks!

> There seems to be a problem with this PR. It shows commits [not part of this PR](https://github.com/openjdk/jdk8u-dev/pull/158/commits/f81f0a51f183d38248fdee4242f012257076d6ab), but others (e.g. https://github.com/openjdk/jdk8u-dev/pull/135). The bot is also not happy about it. Before this can get properly reviewed, this would need some fixup.

Sorry about that. I think the merge hasn't worked. (I can't confirm that at the time I did it because we have to wait for the bot to update the pr/ branch in the main repository for the web view to show the proper comparison). I'll do a rebase and see what it looks like.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Fri Nov 11 14:39:53 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 14:39:53 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v2]
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <JEIZ0n8sHKMDJhWGVMzaSl8XwQXP4lIercNhkTPM-Dk=.368e361c-5152-48fd-88b1-4ee88203f268@github.com>

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/155/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/155/files/bfc817ed..e6c38804

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=00-01

  Stats: 115 lines in 4 files changed: 105 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From jdowland at openjdk.org  Fri Nov 11 14:45:07 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 14:45:07 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v2]
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <8szJoAeRMrAjnZ6flhfbIyvo-Yk7RWET4pHT0M5Akm4=.28302f8f-e8e6-4f3a-90d6-c171de964aa6@github.com>

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/157/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/157/files/936609c5..936609c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Fri Nov 11 15:41:57 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 15:41:57 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v3]
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <7_iEV7wLWxUXyAxfX2rkmAm09f-yxpTnq8i_moFcslk=.151ab138-b878-4bc4-93f8-8661172de479@github.com>

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  8252359: HotSpot Not Identifying it is Running in a Container
  
  Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/157/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/157/files/936609c5..793364d2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=01-02

  Stats: 115 lines in 4 files changed: 105 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From sgehwolf at openjdk.org  Fri Nov 11 15:43:48 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 15:43:48 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible)
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <RmqTN4AdvVE61CjGtTPjQ0ZoWzHZiGgpE2APeayx7rU=.9d9db272-f471-48d6-ba01-69d49dc110f2@github.com>

On Mon, 7 Nov 2022 10:30:16 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Tests will need adjustment for this one.

hotspot/test/runtime/containers/cgroup/CgroupSubsystemFactory.java line 178:

> 176: 
> 177:             cgroupv1MntInfoSystemdOnly = Paths.get(existingDirectory.toString(), "mnt_info_cgroupv1_systemd_only");
> 178:             Files.writeString(cgroupv1MntInfoSystemdOnly, mntInfoCgroupsV1SystemdOnly);

`s/Files.writeString/Files.write`

jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 127:

> 125: 
> 126:             cgroupv1MntInfoSystemdOnly = Paths.get(existingDirectory.toString(), "mountinfo_cgroupv1_systemd_only");
> 127:             Files.writeString(cgroupv1MntInfoSystemdOnly, mntInfoCgroupsV1SystemdOnly);

Same here. Adjust to 8u API (`Files.writeString` not available).

jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 148:

> 146:         Optional<CgroupTypeResult> result = CgroupSubsystemFactory.determineType(mountInfo, cgroups);
> 147: 
> 148:         assertTrue("zero hierarchy ids with no *relevant* controllers mounted", result.isEmpty());

`Optional.isEmpty()` not available in 8u.

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From sgehwolf at openjdk.org  Fri Nov 11 16:07:43 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 16:07:43 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <tAftb6MzvYK19d5CoRO7pHuLAtGqTqPN8L1OLZN2zZo=.60e05ddb-edc9-411a-a917-3c193745e11f@github.com>

On Thu, 3 Nov 2022 15:34:01 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

@martinuy Could you please help review this? Thank you!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From sgehwolf at openjdk.org  Fri Nov 11 16:10:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 16:10:33 GMT
Subject: [jdk8u-dev] RFR: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
In-Reply-To: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
References: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>
Message-ID: <4S-tZtB2Y9CFng34IzFz8Q6weHTghuUOL0V_EY1wHyY=.16e8a711-9144-4392-936b-7c2fcf0a63d2@github.com>

On Tue, 4 Oct 2022 13:25:24 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> There are two copies of the test utility class FileUtils.java in the jdk8u-dev source tree:
> 
> 
> $ find . -name FileUtils.java
> ./jdk/test/lib/testlibrary/jdk/testlibrary/FileUtils.java
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> 
> 
> One of them is not used by anything. It also uses language features that are not present in 8u:
> 
> 
> $ $JAVA_HOME/bin/javac ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
> # snip
> ./jdk/test/lib/jdk/test/lib/util/FileUtils.java:166: error: cannot infer type arguments for SimpleFileVisitor<T>
>             java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<>() {
>                                                                        ^
>   reason: cannot use '<>' with anonymous inner classes
> 
> 
> The soluton for this case is simple, just remove the above file.
> 
> This is part of a wider issue of duplicated test material, but I'm filing for the one I found for now. 
> 
> * https://bugs.openjdk.org/browse/JDK-8294767

OK with me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From jdowland at openjdk.org  Fri Nov 11 16:23:10 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:23:10 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v4]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <Bhn62etNKy-dfIsl3ShmOcnC0dAOgj_OHkLIHiMFGZA=.2fdd4cbf-2c92-4ef0-8c0e-506a48ce3bc5@github.com>

> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Update file path in comment
 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/158/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=03
  Stats: 109 lines in 3 files changed: 88 ins; 1 del; 20 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Fri Nov 11 16:23:13 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:23:13 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v3]
In-Reply-To: <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <uVbIHaANnRSkVSQStHsFcpgxid61PvAwv1huOvTSdKY=.4747d623-3625-424f-8531-b5c76ee42fcf@github.com>
Message-ID: <ERN7jnFyBC_QUVCNSP4hY5TMPQXFipiQe9fUe5MUtgI=.314a4b51-1eb4-44f3-a2ad-2c93d3aed301@github.com>

On Tue, 8 Nov 2022 14:09:43 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available.

I've rebased but PR 135's commits are still missing in the chain for this one so further work is required to find out where things have gone out of sync.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From jdowland at openjdk.org  Fri Nov 11 16:25:29 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:25:29 GMT
Subject: [jdk8u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing
 after JDK-8231111 [v4]
In-Reply-To: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
References: <xMzwOwQNLqXe-C5x9_Vhg7oKETlwaMvxTxwDOmzd2iM=.1f8a3396-c7a0-4cdc-af4e-49837439b4e6@github.com>
Message-ID: <z_AjEWrIJynlKKNRP1Sn0kSXnQN9Q4Ed-BZ2hSNm4GI=.bcb72ce0-133f-4625-b295-bac9f2468581@github.com>

> This is a back port of 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
> for jdk8u-dev as part of an effort to backport support for Cgroups V2.
> 
> The intention is for this PR to depend upon [8231111: 2Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy](https://github.com/openjdk/jdk8u-dev/pull/121), which in turn depends upon [8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems](https://github.com/openjdk/jdk8u-dev/pull/123), both of which are dependencies for this patch-set.
> 
> This backport is one commit on top of pr/121. It does not apply clean after path unshuffling: some of the patch contexts around `MetricsMemoryTester.java`,  `MetricsTesterCgroupV1.java` and  `MetricsTesterCgroupV2.java` differ due to changes made in pr/121 to adjust for jdk8u-dev support (replacing `Arrays.compare` with `Arrays.equals`)
> 
> I'll report back testing results to this PR, I have to untangle them a bit first.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Update file path in comment
 - Severin's test fixes. Thanks!

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/124/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=124&range=03
  Stats: 225 lines in 10 files changed: 105 ins; 32 del; 88 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/124.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/124/head:pull/124

PR: https://git.openjdk.org/jdk8u-dev/pull/124

From jdowland at openjdk.org  Fri Nov 11 16:25:51 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:25:51 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java [v5]
In-Reply-To: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
References: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>
Message-ID: <gkLUHz4NmJ7v94SAXxJf-6FxBHkdYpZ155M5bsrdr2s=.c38f101e-2950-403d-94fd-2d793af810dc@github.com>

> This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.
> 
> It's a test-only change.
> 
> The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/142/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/142/files/0cfe1277..ccb9c108

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=03-04

  Stats: 71 lines in 4 files changed: 50 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Fri Nov 11 16:27:07 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:27:07 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v6]
In-Reply-To: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
Message-ID: <oFS71BOfFT55LAG1bLnm6tipLpJhw1XIgFNZCYAb_DY=.5130e779-b631-4df3-950f-22c2beb93ea5@github.com>

> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
> 
> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
> 
> I also had to Optional.isEmpty which is not present in 8u's Optional.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Update file path in comment
 - Severin's test fixes. Thanks!

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/136/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/136/files/221ef6a5..54407433

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=04-05

  Stats: 71 lines in 4 files changed: 50 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Fri Nov 11 16:27:12 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:27:12 GMT
Subject: [jdk8u-dev] RFR: 8197408: Bad pointer comparison and small cleanup
 in os_linux.cpp [v2]
In-Reply-To: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
References: <cwJnfKPQqgAXYIcDm8oaizxhBXlHADQAhoz6hs6v5N8=.a5ed060b-2a17-4b6d-9761-6189bad14ccd@github.com>
Message-ID: <qvOJC76-7U8T4Qe3mKEJe74rBKio2BxkQ9lCj22XHwo=.1416039b-7b1c-4504-9e82-68b4954b2fd9@github.com>

> This is a backport of [JDK-8197408](https://bugs.openjdk.org/browse/JDK-8197408) to jdk8u-dev as part of cgroups v2. I've backported it as a pre-requisite for 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 (<https://github.com/openjdk/jdk8u-dev/pull/155>)
> 
> Most of the original patch has been integrated already: I've left a whitespace change in for os_linux.cpp to hopefully avoid context problems later on. The majority of this patch is introducing the test PlainRead.java.
> 
> Not clean: test adjustments to jtreg metadata, imports, and JVM flags needed.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
   
   When the kernel doesn't support swap limits, expect host values instead.
   
   Reviewed-by: sgehwolf
   Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
 - Update file path in comment
 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/3ef0d0e0...74d73c96

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/164/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/164/files/3ef0d0e0..74d73c96

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=164&range=00-01

  Stats: 71 lines in 4 files changed: 50 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/164.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/164/head:pull/164

PR: https://git.openjdk.org/jdk8u-dev/pull/164

From jdowland at openjdk.org  Fri Nov 11 16:27:24 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:27:24 GMT
Subject: [jdk8u-dev] RFR: 8252359: HotSpot Not Identifying it is Running in
 a Container [v4]
In-Reply-To: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
References: <SPDT0oK5BpgS3zSwK1MKiMJFky5CbPRk_N_HsfUesWw=.5f228abb-18cd-4bb9-86f5-99affdba1a3c@github.com>
Message-ID: <4BxSkz8IlxdVDWwb7qiK5EODTCbfRZ-bLGhy2JV9Wn0=.898cb06d-357e-416e-904a-3065926ce43f@github.com>

> This is a clean backport of 8252359  to jdk8u-dev, as part of cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/e4a44241...34b0259f

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/157/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=157&range=03
  Stats: 645 lines in 18 files changed: 477 ins; 53 del; 115 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/157/head:pull/157

PR: https://git.openjdk.org/jdk8u-dev/pull/157

From jdowland at openjdk.org  Fri Nov 11 16:28:59 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:28:59 GMT
Subject: [jdk8u-dev] RFR: 8278951: containers/cgroup/PlainRead.java fails
 on Ubuntu 21.10 [v3]
In-Reply-To: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
References: <ZrVPi0cyyDai7XTq8Rt-TPRfehx6lLKEy3FWT-zPIKo=.8a92fddb-d200-447b-b311-364160aec763@github.com>
Message-ID: <qt6OmwgXaFe5T9eab4hKPzs_pHsfvz8FIiMwz6qxn04=.f633f503-c788-417d-8f9a-2161f4cd9c12@github.com>

> This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.
> 
> Dependent PRs are in use.
> 
> It was clean (modulo path shuffles). The use of `log_trace` needed adjusting for jdk8u-dev.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:

 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems
   
   Adjust heuristic with cgroup mounts according to mountinfo
   
   Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
 - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
   
   Reviewed-by: mdoerr
   Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
 - Don't pass --add-exports to jdk8u java inside docker
   
   These are JDK9+ module specific parameters.
 - ... and 3 more: https://git.openjdk.org/jdk8u-dev/compare/e6c38804...7fc8633b

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/155/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/155/files/e6c38804..7fc8633b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=155&range=01-02

  Stats: 71 lines in 4 files changed: 50 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155

PR: https://git.openjdk.org/jdk8u-dev/pull/155

From jdowland at openjdk.org  Fri Nov 11 16:29:04 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:29:04 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v2]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <9f69N67asMXf93yiPooS7hox9qjb3eHkmhIKxXUN7UY=.22e093b2-7953-4264-a4ba-f3e4138e24ea@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/159/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/159/files/9c008bc1..9c008bc1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Fri Nov 11 16:29:25 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 11 Nov 2022 16:29:25 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v5]
In-Reply-To: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
Message-ID: <IchTUmpp_hF3uXE9hXIyQ_Hfjyk8jvFeDkJF4nls4E0=.685326da-6498-4fdb-bef3-0b73a16249d6@github.com>

> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:

 - Severin's test fixes. Thanks!
 - Replace log_warning with tty->print_cr
 - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
   
   Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
 - 8252359: HotSpot Not Identifying it is Running in a Container
   
   Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
 - replace log_trace with tty->print_cr
 - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
   
   Reviewed-by: sgehwolf
   Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
 - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
 - adjust jtreg settings and imports for 8u
 - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
   
   Reviewed-by: bobv, stuefe
 - Test fix by Severin. Thanks!
 - ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/e4a44241...00dc64aa

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/158/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=158&range=04
  Stats: 688 lines in 18 files changed: 518 ins; 53 del; 117 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/158.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/158/head:pull/158

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From duke at openjdk.org  Fri Nov 11 16:51:37 2022
From: duke at openjdk.org (Dan Lutker)
Date: Fri, 11 Nov 2022 16:51:37 GMT
Subject: [jdk8u-dev] Integrated: 8221529: [TESTBUG] Docker tests use
 old/deprecated image on AArch64
In-Reply-To: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
References: <OILhcMLoPqyG5r21c1PG24jvU0cgDr4SSk3dUDTH8wE=.1e90021f-5e6d-4e27-bdfd-c1dbfc5386b1@github.com>
Message-ID: <KVwBZtTYPVeJoBFYOCfEzojTYOooiqIfHM_6Az2njoA=.04c98230-53e4-4c0a-8872-bd425737143e@github.com>

On Wed, 9 Nov 2022 17:12:46 GMT, Dan Lutker <duke at openjdk.org> wrote:

> Backport trivial test fix to use correct base image architecture for aarch64.
> 
> Patch applied cleanly.

This pull request has now been integrated.

Changeset: f6d869f0
Author:    Dan Lutker <lutkerd at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/f6d869f02569754431e4eaf69e4f66ee357ba425
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64

Reviewed-by: sgehwolf
Backport-of: 71ac3d952b6d5bf9eb08ec7daf07225b1ab66216

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/166

From duke at openjdk.org  Fri Nov 11 17:13:32 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 11 Nov 2022 17:13:32 GMT
Subject: [jdk8u-dev] Integrated: 8159599: [TEST_BUG]
 java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
In-Reply-To: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
References: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
Message-ID: <MDP78QEilFOV4M1N9vRTIeR7SDSLxyOGUOjQxa00txo=.714ae37b-f22d-4d16-a04f-36682b1fdaa0@github.com>

On Tue, 11 Oct 2022 17:19:59 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Backport for parity with Oracle.
> 
> Backport does not apply to ProblemList.txt because the affected test is not there in JDK8. Cleanly applies to SimpleWindowActivationTest.java after fixing paths.

This pull request has now been integrated.

Changeset: 2f509c70
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2f509c7070b96e2de02b27d5f752e775980cb75c
Stats:     22 lines in 1 file changed: 13 ins; 2 del; 7 mod

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewed-by: phh
Backport-of: f5beafa53f93a6ec03278dfd7063d7b3b0b9d241

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/134

From sgehwolf at openjdk.org  Fri Nov 11 17:30:34 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 17:30:34 GMT
Subject: [jdk8u-dev] RFR: 8253435: Cgroup: 'stomping of _mount_path' crash
 if manually mounted cpusets exist [v5]
In-Reply-To: <IchTUmpp_hF3uXE9hXIyQ_Hfjyk8jvFeDkJF4nls4E0=.685326da-6498-4fdb-bef3-0b73a16249d6@github.com>
References: <mgmz2CetTrGgQbAX6o2Fz6G8y1lRLkOB9uUMqd5KaCs=.a58949d5-95f6-44b9-ae87-160bc459c54f@github.com>
 <IchTUmpp_hF3uXE9hXIyQ_Hfjyk8jvFeDkJF4nls4E0=.685326da-6498-4fdb-bef3-0b73a16249d6@github.com>
Message-ID: <N4XHbaEfTkUu42PmjpbXZrR04boFIEdQXVge1_DQkQI=.484aac1c-ad6a-4c32-8ae8-a444afd2343e@github.com>

On Fri, 11 Nov 2022 16:29:25 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a clean backport of 8253435 to jdk8u-dev for cgroups v2 support.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
> 
>  - Severin's test fixes. Thanks!
>  - Replace log_warning with tty->print_cr
>  - 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
>    
>    Backport-of: 0054c15f60cce6470be05d29bfacbdb74cfb7bc9
>  - 8252359: HotSpot Not Identifying it is Running in a Container
>    
>    Backport-of: 76f0588aaf265439a589cceb924e3ea9d3fda8f1
>  - replace log_trace with tty->print_cr
>  - 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 35172cdaf38d83cd3ed57a5436bf985dde2d802b
>  - PlainRead: ProcessBuilder: jdk8u-appropriate command line flags
>  - adjust jtreg settings and imports for 8u
>  - 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
>    
>    Reviewed-by: bobv, stuefe
>  - Test fix by Severin. Thanks!
>  - ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/e4a44241...00dc64aa

This looks good now. Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/158

From sgehwolf at openjdk.org  Fri Nov 11 17:34:32 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 11 Nov 2022 17:34:32 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v2]
In-Reply-To: <9f69N67asMXf93yiPooS7hox9qjb3eHkmhIKxXUN7UY=.22e093b2-7953-4264-a4ba-f3e4138e24ea@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
 <9f69N67asMXf93yiPooS7hox9qjb3eHkmhIKxXUN7UY=.22e093b2-7953-4264-a4ba-f3e4138e24ea@github.com>
Message-ID: <ykBLk1O8itKza6E7EY8pvYmlkadeIfx4kupHPU7CJM8=.52b8933d-2b0f-4acb-b8e7-537405e765a6@github.com>

On Fri, 11 Nov 2022 16:29:04 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
>> 
>> Not clean: needed minor adjusting for 8u approach to log output.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

@jmtd For some reason this patch now looks weird and would need fixing before I can review. Thanks.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Nov 14 10:06:18 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 10:06:18 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v3]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <eMp_nd4gt-SXWhSuHf-5eAva_8l45yj_ApwLjaD_4CQ=.28505aba-567b-4c98-b27a-4cd9f1be0611@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
  
  Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/159/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=02
  Stats: 97 lines in 4 files changed: 91 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Nov 14 10:09:00 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 10:09:00 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v4]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <E1edNHyRsVXnm8Fbgr-DfvLqTy_NcKGccGLEoqeG7h0=.d52df64b-75ba-4247-88ef-497e19b8f240@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  replace use of Optional.isEmpty

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/159/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/159/files/4eb0b00e..86a169cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Nov 14 10:14:04 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 10:14:04 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v5]
In-Reply-To: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
Message-ID: <KQDIw-OAgvrJaNXpec89n68Qe0zyBn_OTGuaEp59u9E=.13c8f3cf-64ca-4b74-a6dd-43ac4f7da165@github.com>

> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
> 
> Not clean: needed minor adjusting for 8u approach to log output.

Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - replace use of Optional.isEmpty
 - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
   
   Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/159/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/159/files/86a169cc..0b56b96c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=159&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/159/head:pull/159

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Nov 14 10:26:01 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 10:26:01 GMT
Subject: [jdk8u-dev] RFR: 8253939: [TESTBUG] Increase coverage of the cgroups
 detection code
Message-ID: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>

This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.

It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/159

Commit messages:
 - 8253939: [TESTBUG] Increase coverage of the cgroups detection code

Changes: https://git.openjdk.org/jdk8u-dev/pull/169/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=169&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8253939
  Stats: 147 lines in 2 files changed: 134 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/169.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/169/head:pull/169

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From sgehwolf at openjdk.org  Mon Nov 14 10:28:47 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 10:28:47 GMT
Subject: [jdk8u-dev] RFR: 8245543: Cgroups: Incorrect detection logic on
 some systems (still reproducible) [v5]
In-Reply-To: <KQDIw-OAgvrJaNXpec89n68Qe0zyBn_OTGuaEp59u9E=.13c8f3cf-64ca-4b74-a6dd-43ac4f7da165@github.com>
References: <CO2fiHIsLyBcEPnav4C_suIGkLQcVXQGRx7uX9_05Fs=.f2b9840f-8c1f-4444-885c-f20c82ae37d1@github.com>
 <KQDIw-OAgvrJaNXpec89n68Qe0zyBn_OTGuaEp59u9E=.13c8f3cf-64ca-4b74-a6dd-43ac4f7da165@github.com>
Message-ID: <Zx5y5oq0iDitYIC76e1vAMp7fS7jL1NL7JUxx72TZE4=.8759eaca-0480-477a-939d-9a291ae79ab6@github.com>

On Mon, 14 Nov 2022 10:14:04 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A backport of 8245543 to jdk8u-dev for cgroups v2 support.
>> 
>> Not clean: needed minor adjusting for 8u approach to log output.
>
> Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - replace use of Optional.isEmpty
>  - 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
>    
>    Backport-of: 2bbf8a2a964a64d88298a3dd184459af506e58ed

Looks good now.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/159

From jdowland at openjdk.org  Mon Nov 14 10:59:35 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 10:59:35 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection
Message-ID: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>

This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.

It's not clean: some context issues around import lines and `Files.writeString` replacements.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/169

Commit messages:
 - 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

Changes: https://git.openjdk.org/jdk8u-dev/pull/170/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=170&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8254001
  Stats: 595 lines in 5 files changed: 321 ins; 142 del; 132 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/170.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/170/head:pull/170

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From jdowland at openjdk.org  Mon Nov 14 11:30:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 11:30:44 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v6]
In-Reply-To: <oFS71BOfFT55LAG1bLnm6tipLpJhw1XIgFNZCYAb_DY=.5130e779-b631-4df3-950f-22c2beb93ea5@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <oFS71BOfFT55LAG1bLnm6tipLpJhw1XIgFNZCYAb_DY=.5130e779-b631-4df3-950f-22c2beb93ea5@github.com>
Message-ID: <UUA2kIrlX2mAxpPNlhGJef1wZQqWssOg0V0sCCi1BYg=.cc63b2e9-9959-4ce0-a37b-5ad56007027b@github.com>

On Fri, 11 Nov 2022 16:27:07 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.
>> 
>> It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.
>> 
>> I also had to Optional.isEmpty which is not present in 8u's Optional.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Test fix by Severin. Thanks!
>  - replace post-jdk8u Optional.isEmpty
>  - 8239559: Cgroups: Incorrect detection logic on some systems
>    
>    Adjust heuristic with cgroup mounts according to mountinfo
>    
>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>    
>    Reviewed-by: mdoerr
>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>  - Don't pass --add-exports to jdk8u java inside docker
>    
>    These are JDK9+ module specific parameters.
>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>    
>    When the kernel doesn't support swap limits, expect host values instead.
>    
>    Reviewed-by: sgehwolf
>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>  - Update file path in comment
>  - Severin's test fixes. Thanks!

jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 46:

> 44:  * @test
> 45:  * @requires os.family == "linux"
> 46:  * @modules java.base/jdk.internal.platform

this is benign but potentially misleading in 8u, should we remove it? I only hesitate because it might mean rebasing up to 8 pull requests on top

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From jdowland at openjdk.org  Mon Nov 14 11:33:17 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 14 Nov 2022 11:33:17 GMT
Subject: [jdk8u-dev] RFR: 8262379: Add regression test for JDK-8257746
Message-ID: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>

This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/170

Commit messages:
 - 8262379: Add regression test for JDK-8257746

Changes: https://git.openjdk.org/jdk8u-dev/pull/171/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=171&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8262379
  Stats: 55 lines in 1 file changed: 55 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/171.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/171/head:pull/171

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From sgehwolf at openjdk.org  Mon Nov 14 13:38:19 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 13:38:19 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on
 some systems [v6]
In-Reply-To: <UUA2kIrlX2mAxpPNlhGJef1wZQqWssOg0V0sCCi1BYg=.cc63b2e9-9959-4ce0-a37b-5ad56007027b@github.com>
References: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>
 <oFS71BOfFT55LAG1bLnm6tipLpJhw1XIgFNZCYAb_DY=.5130e779-b631-4df3-950f-22c2beb93ea5@github.com>
 <UUA2kIrlX2mAxpPNlhGJef1wZQqWssOg0V0sCCi1BYg=.cc63b2e9-9959-4ce0-a37b-5ad56007027b@github.com>
Message-ID: <qjpZPCQxsBxN6xFB2Ur5nZy2MLN4yZLxjekd0jaN3Go=.606c126c-85a4-40ff-a7da-45e84d0a5621@github.com>

On Mon, 14 Nov 2022 11:28:42 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Test fix by Severin. Thanks!
>>  - replace post-jdk8u Optional.isEmpty
>>  - 8239559: Cgroups: Incorrect detection logic on some systems
>>    
>>    Adjust heuristic with cgroup mounts according to mountinfo
>>    
>>    Backport-of: 53ee0c4963007b86db7979312b81f990e6ce271a
>>  - 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
>>    
>>    Reviewed-by: mdoerr
>>    Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa
>>  - Don't pass --add-exports to jdk8u java inside docker
>>    
>>    These are JDK9+ module specific parameters.
>>  - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
>>    
>>    When the kernel doesn't support swap limits, expect host values instead.
>>    
>>    Reviewed-by: sgehwolf
>>    Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e
>>  - Update file path in comment
>>  - Severin's test fixes. Thanks!
>
> jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 46:
> 
>> 44:  * @test
>> 45:  * @requires os.family == "linux"
>> 46:  * @modules java.base/jdk.internal.platform
> 
> this is benign but potentially misleading in 8u, should we remove it? I only hesitate because it might mean rebasing up to 8 pull requests on top

Let's not fix this in this integration batch. If we really want to, we can remove those with a single 8u-only bug. FWIW, there are more of those `@modules` lines in tests elsewhere (only two of them are from container tests):


$ grep -rn '@modules' jdk/test/ | wc -l
77

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From duke at openjdk.org  Mon Nov 14 14:01:42 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 14 Nov 2022 14:01:42 GMT
Subject: [jdk8u-dev] RFR: 8295714: GHA ::set-output is deprecated and will be
 removed
Message-ID: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>

Fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`

All tests passed (no warnings).

-------------

Commit messages:
 - Backport 12ede6d6c6139db4ad1820f61236f9cfc81a874a

Changes: https://git.openjdk.org/jdk8u-dev/pull/172/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=172&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295714
  Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/172.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/172/head:pull/172

PR: https://git.openjdk.org/jdk8u-dev/pull/172

From sgehwolf at openjdk.org  Mon Nov 14 14:23:10 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 14:23:10 GMT
Subject: [jdk8u-dev] RFR: 8295714: GHA ::set-output is deprecated and will
 be removed
In-Reply-To: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>
References: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>
Message-ID: <_D-InpaTNhFg8jLOG15OHKWEKDNOQGM9OiiWJCML5cs=.319dccfe-abe1-418d-aaaa-d84d3ce4117c@github.com>

On Mon, 14 Nov 2022 13:56:19 GMT, zzambers <duke at openjdk.org> wrote:

> Fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:
> 
> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
> 
> All tests passed (no warnings).

LGTM

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/172

From duke at openjdk.org  Mon Nov 14 14:33:25 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 14 Nov 2022 14:33:25 GMT
Subject: [jdk8u-dev] RFR: 8295714: GHA ::set-output is deprecated and will
 be removed
In-Reply-To: <_D-InpaTNhFg8jLOG15OHKWEKDNOQGM9OiiWJCML5cs=.319dccfe-abe1-418d-aaaa-d84d3ce4117c@github.com>
References: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>
 <_D-InpaTNhFg8jLOG15OHKWEKDNOQGM9OiiWJCML5cs=.319dccfe-abe1-418d-aaaa-d84d3ce4117c@github.com>
Message-ID: <nO5-tSrRy0IxDGDLeUwjmWM_x6_zsVj7rmABpB6IVJU=.10f5a987-280c-4e9e-aec9-66bd657f44a6@github.com>

On Mon, 14 Nov 2022 14:19:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:
>> 
>> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
>> 
>> All tests passed (no warnings).
>
> LGTM

@jerboaa Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/172

From sgehwolf at openjdk.org  Mon Nov 14 14:51:36 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 14:51:36 GMT
Subject: [jdk8u-dev] RFR: 8253939: [TESTBUG] Increase coverage of the
 cgroups detection code
In-Reply-To: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
References: <dYPEgmHKhn69tLbt52VLYmJ2ypPf0TQRoaKSS-i7vdM=.df8dd0d3-29cf-45c8-813c-3026ce20c116@github.com>
Message-ID: <N2bngvbj4VE55GVNtFyMjcO9LGSvGJbpYth3H3oTKLc=.ef6b9cf9-1407-4be6-8d61-b45441140779@github.com>

On Mon, 14 Nov 2022 10:19:29 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8253939  to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: several `Files.writeString` ? `Files.write(?,.getBytes())` changes needed.

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/169

From duke at openjdk.org  Mon Nov 14 15:16:46 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 14 Nov 2022 15:16:46 GMT
Subject: [jdk8u-dev] Integrated: 8295714: GHA ::set-output is deprecated and
 will be removed
In-Reply-To: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>
References: <j1RQoVm9XxlS1GVcZnnI47NGY5AgQooGJqSQqzSm21Y=.adc25022-9795-4785-8596-32c9b3b12865@github.com>
Message-ID: <woCkfL9PIt2ZcMD88caJF49-ZCsYAMneRDaYnIzYHHA=.56dca650-df6b-4b44-9241-f2aaf7096f95@github.com>

On Mon, 14 Nov 2022 13:56:19 GMT, zzambers <duke at openjdk.org> wrote:

> Fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:
> 
> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
> 
> All tests passed (no warnings).

This pull request has now been integrated.

Changeset: 17fd40ac
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/17fd40ac17b1bbcee302797961c67e38986a3ffd
Stats:     9 lines in 1 file changed: 0 ins; 0 del; 9 mod

8295714: GHA ::set-output is deprecated and will be removed

Reviewed-by: sgehwolf
Backport-of: b35922be6de7b848a2982d6a278dbd205fc39e6a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/172

From sgehwolf at openjdk.org  Mon Nov 14 16:46:36 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 16:46:36 GMT
Subject: [jdk8u-dev] RFR: 8254001: [Metrics] Enhance parsing of cgroup
 interface files for version detection
In-Reply-To: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
References: <PP2f9scIGys7GxR51PHbTrwzYlW5t1KWdOF8YVMkq3Q=.c1c64001-e51b-427f-b579-564cf00b0b01@github.com>
Message-ID: <RHOyFLScwlX0co-9c6vBg5ydZfIUxqF5KEsaSzeMaW0=.4afacc32-f47b-4307-9a34-455a8c2cd7ad@github.com>

On Mon, 14 Nov 2022 10:51:48 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8254001 to jdk8u-dev for cgroups v2 support.
> 
> It's not clean: some context issues around import lines and `Files.writeString` replacements.

OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/170

From sgehwolf at openjdk.org  Mon Nov 14 16:59:37 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 14 Nov 2022 16:59:37 GMT
Subject: [jdk8u-dev] RFR: 8262379: Add regression test for JDK-8257746
In-Reply-To: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
References: <AUjvc6fgHrk80T8rTap5uR-6Sjza_aZFK7vTfzvBMtM=.10ac857e-a29d-46be-952f-bc8100e0dafd@github.com>
Message-ID: <e5L3bt0irD_l_SesXoLcH929FMdU0mEhzDIA3qfnWu8=.2e936862-d7d6-4c9a-ab43-8b3c3215ef67@github.com>

On Mon, 14 Nov 2022 11:26:26 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8262379: Add regression test for JDK-8257746 for jdk8u-dev as part of cgroups v2 support.

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/171

From duke at openjdk.org  Mon Nov 14 20:18:22 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 14 Nov 2022 20:18:22 GMT
Subject: [jdk8u-dev] RFR: 8296959: Fix hotspot shell tests of 8u on multilib
 systems
Message-ID: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>

Few hotspot tests (from hotspot/tier1) currently fail for x86 (32-bit) builds on 64-bit system (Linux).

compiler/criticalnatives/argumentcorruption/Test8167409.sh 
runtime/jni/CallWithJNIWeak/test.sh 
runtime/jni/ReturnJNIWeak/test.sh

**Problem:**
Tests build 64-bit JNI libraries and trying to use them for 32-bit jdk, resulting in error:

Exception in thread "main" java.lang.UnsatisfiedLinkError: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch)

These tests only target Linux and (some) Solaris.

**Solution:**
Fixed by supplying appropriate compiler argument (-m32) to build 32-bit libraries for 32-bit JDK. (Some tests already did that, but not in uniform way). I verified in manpage of gcc that -m32 argument is supported for all 32-bit variants of architectures supported by JDK 8 [1]. Solaris cc also seems to support -m32 [2].
This fix is JDK 8 only as newer JDK use new approach, where JNI test libraries are build are build system and tests not longer build them themselfs.

**Testing:**
Change fixed these tests on linux-x86. (tested here [3])
Tests are part of hotspot/tier1. This is one of problems, which needs to be fixed, so that hotspot/tier1 can be enabled in GHA on linux-x86. Other one is JDK-8295952 [3] (will need to get fixed and backported).

[1]  https://man7.org/linux/man-pages/man1/gcc.1.html
[2] https://docs.oracle.com/cd/E37069_01/html/E54439/cc-1.html
[3] https://github.com/zzambers/jdk8u-dev/actions/runs/3441392968
[4] https://bugs.openjdk.org/browse/JDK-8295952

-------------

Commit messages:
 - Fixed shell tests on multilib systems

Changes: https://git.openjdk.org/jdk8u-dev/pull/173/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=173&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296959
  Stats: 22 lines in 8 files changed: 6 ins; 9 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/173.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/173/head:pull/173

PR: https://git.openjdk.org/jdk8u-dev/pull/173

From duke at openjdk.org  Mon Nov 14 20:41:53 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 14 Nov 2022 20:41:53 GMT
Subject: [jdk8u-dev] RFR: 8284389: Improve stability of GHA Pre-submit testing
 by caching cygwin installer
Message-ID: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>

Adds cygwin installer caching.

Few notes:
- Cache also added for windows-x86, which is not present on JDK 11.
- Used actions/cache at v3 (I have already done backport updating GHA actions, out of order, before this)

-------------

Commit messages:
 - Backport 869b25975288398a1d60601daacf00a99f51cd56

Changes: https://git.openjdk.org/jdk8u-dev/pull/174/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=174&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284389
  Stats: 60 lines in 1 file changed: 52 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/174.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/174/head:pull/174

PR: https://git.openjdk.org/jdk8u-dev/pull/174

From sgehwolf at openjdk.org  Tue Nov 15 08:19:06 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 15 Nov 2022 08:19:06 GMT
Subject: [jdk8u-dev] RFR: 8286582: Build fails on macos aarch64 when using
 --with-zlib=bundled [v2]
In-Reply-To: <z6vPWHAj3nJK3O4rTzli00bKFDrL5xNgZ4y57dzZeQM=.89d38087-3a30-4c07-bef7-c6feedda09ae@github.com>
References: <ImYzQRJ5mteFVjl4P0piwd0_GTLWZBNXegC-CM9YPGw=.476a9301-d6fe-4821-ae6a-144a00a2015a@github.com>
 <z6vPWHAj3nJK3O4rTzli00bKFDrL5xNgZ4y57dzZeQM=.89d38087-3a30-4c07-bef7-c6feedda09ae@github.com>
Message-ID: <lYAg28gEhyZBbMIe7ZtK6RivX1XMRsJVFuQmZizavXQ=.8e7fdc41-0c02-47d7-b4d2-d3967c24e4a7@github.com>

On Sun, 30 Oct 2022 00:12:55 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
>> 
>> The patch for JDK8 is slightly different:
>>  * The main code patch is moved from the `make/autoconf/lib-bundled.m4` to the `jdk/make/lib/CoreLibraries.gmk` the same place where `":= -lz"` option is set.
>>  * All disabled warnings are removed from the patch, seems we do not have such DISABLED_WARNINGS_XX in JDK8
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8286582
>  - Simplify the change
>  - Merge branch 'master' into JDK-8286582
>  - 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Looks OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/80

From sgehwolf at openjdk.org  Tue Nov 15 08:59:10 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 15 Nov 2022 08:59:10 GMT
Subject: [jdk8u-dev] RFR: 8296959: Fix hotspot shell tests of 8u on
 multilib systems
In-Reply-To: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>
References: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>
Message-ID: <c4AclEx1q_q45WKV6Q0p3XX8xxfX7LwwmOE5fqzAjhc=.f3afb238-2b02-40fb-809b-a83108d34e65@github.com>

On Mon, 14 Nov 2022 20:12:10 GMT, zzambers <duke at openjdk.org> wrote:

> Few hotspot tests (from hotspot/tier1) currently fail for x86 (32-bit) builds on 64-bit system (Linux).
> 
> compiler/criticalnatives/argumentcorruption/Test8167409.sh 
> runtime/jni/CallWithJNIWeak/test.sh 
> runtime/jni/ReturnJNIWeak/test.sh
> 
> **Problem:**
> Tests build 64-bit JNI libraries and trying to use them for 32-bit jdk, resulting in error:
> 
> Exception in thread "main" java.lang.UnsatisfiedLinkError: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch)
> 
> These tests only target Linux and (some) Solaris.
> 
> **Solution:**
> Fixed by supplying appropriate compiler argument (-m32) to build 32-bit libraries for 32-bit JDK. (Some tests already did that, but not in uniform way). I verified in manpage of gcc that -m32 argument is supported for all 32-bit variants of architectures supported by JDK 8 [1]. Solaris cc also seems to support -m32 [2].
> This fix is JDK 8 only as newer JDK use new approach, where JNI test libraries are build are build system and tests not longer build them themselfs.
> 
> **Testing:**
> Change fixed these tests on linux-x86. (tested here [3])
> Tests are part of hotspot/tier1. This is one of problems, which needs to be fixed, so that hotspot/tier1 can be enabled in GHA on linux-x86. Other one is JDK-8295952 [4] (will need to get fixed and backported).
> 
> [1]  https://man7.org/linux/man-pages/man1/gcc.1.html
> [2] https://docs.oracle.com/cd/E37069_01/html/E54439/cc-1.html
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3441392968
> [4] https://bugs.openjdk.org/browse/JDK-8295952

Seems OK to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/173

From sgehwolf at openjdk.org  Tue Nov 15 09:07:13 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 15 Nov 2022 09:07:13 GMT
Subject: [jdk8u-dev] RFR: 8284389: Improve stability of GHA Pre-submit
 testing by caching cygwin installer
In-Reply-To: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>
References: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>
Message-ID: <EjDWRh74shyHMaJ2TpyRUZ-JvpDVZ2qySBtRoUNeR90=.c447f0fe-2e5f-452a-9da5-d8ebb50f6163@github.com>

On Mon, 14 Nov 2022 20:33:23 GMT, zzambers <duke at openjdk.org> wrote:

> Adds cygwin installer caching.
> 
> Few notes:
> - Cache also added for windows-x86, which is not present on JDK 11.
> - Used actions/cache at v3 (I have already done backport updating GHA actions, out of order, before this)

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/174

From jdowland at openjdk.org  Tue Nov 15 10:19:04 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 15 Nov 2022 10:19:04 GMT
Subject: [jdk8u-dev] RFR: 8291570: [TESTBUG] Part of JDK-8250984 absent from
 11u
Message-ID: <37RigSmjiXfQ216QBRI2ew1ln2GVMWFa3q0Da3RTVC8=.90472b38-3ea7-481e-add1-f9a607dfc203@github.com>

This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.

The affected test passes for me after the patch.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/171

Commit messages:
 - 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u

Changes: https://git.openjdk.org/jdk8u-dev/pull/175/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=175&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8291570
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/175.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/175/head:pull/175

PR: https://git.openjdk.org/jdk8u-dev/pull/175

From duke at openjdk.org  Tue Nov 15 13:00:16 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 15 Nov 2022 13:00:16 GMT
Subject: [jdk8u-dev] RFR: 8296959: Fix hotspot shell tests of 8u on
 multilib systems
In-Reply-To: <c4AclEx1q_q45WKV6Q0p3XX8xxfX7LwwmOE5fqzAjhc=.f3afb238-2b02-40fb-809b-a83108d34e65@github.com>
References: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>
 <c4AclEx1q_q45WKV6Q0p3XX8xxfX7LwwmOE5fqzAjhc=.f3afb238-2b02-40fb-809b-a83108d34e65@github.com>
Message-ID: <MhhBXtr37Wz7xjWdQKTNMLUQyIVrAEarCv08iM6BOqE=.bfeb97f7-402b-4be3-82aa-6190a7899899@github.com>

On Tue, 15 Nov 2022 08:56:42 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Few hotspot tests (from hotspot/tier1) currently fail for x86 (32-bit) builds on 64-bit system (Linux).
>> 
>> compiler/criticalnatives/argumentcorruption/Test8167409.sh 
>> runtime/jni/CallWithJNIWeak/test.sh 
>> runtime/jni/ReturnJNIWeak/test.sh
>> 
>> **Problem:**
>> Tests build 64-bit JNI libraries and trying to use them for 32-bit jdk, resulting in error:
>> 
>> Exception in thread "main" java.lang.UnsatisfiedLinkError: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch)
>> 
>> These tests only target Linux and (some) Solaris.
>> 
>> **Solution:**
>> Fixed by supplying appropriate compiler argument (-m32) to build 32-bit libraries for 32-bit JDK. (Some tests already did that, but not in uniform way). I verified in manpage of gcc that -m32 argument is supported for all 32-bit variants of architectures supported by JDK 8 [1]. Solaris cc also seems to support -m32 [2].
>> This fix is JDK 8 only as newer JDK use new approach, where JNI test libraries are build are build system and tests not longer build them themselfs.
>> 
>> **Testing:**
>> Change fixed these tests on linux-x86. (tested here [3])
>> Tests are part of hotspot/tier1. This is one of problems, which needs to be fixed, so that hotspot/tier1 can be enabled in GHA on linux-x86. Other one is JDK-8295952 [4] (will need to get fixed and backported).
>> 
>> [1]  https://man7.org/linux/man-pages/man1/gcc.1.html
>> [2] https://docs.oracle.com/cd/E37069_01/html/E54439/cc-1.html
>> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3441392968
>> [4] https://bugs.openjdk.org/browse/JDK-8295952
>
> Seems OK to me.

@jerboaa thank you for review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/173

From duke at openjdk.org  Tue Nov 15 13:06:06 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 15 Nov 2022 13:06:06 GMT
Subject: [jdk8u-dev] Integrated: 8296959: Fix hotspot shell tests of 8u on
 multilib systems
In-Reply-To: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>
References: <0nNalqL3nRR7W6n2VJ7rOknlNt0pGhANfhJzjQXaCAg=.ccbd12fc-739f-457e-a9fc-925667ab8739@github.com>
Message-ID: <TjHwUE_kxfOwngBUhRtrpdOF1n8p1RoNYsFXML-Xa5I=.52796821-1838-41a2-8557-917e42cafbc4@github.com>

On Mon, 14 Nov 2022 20:12:10 GMT, zzambers <duke at openjdk.org> wrote:

> Few hotspot tests (from hotspot/tier1) currently fail for x86 (32-bit) builds on 64-bit system (Linux).
> 
> compiler/criticalnatives/argumentcorruption/Test8167409.sh 
> runtime/jni/CallWithJNIWeak/test.sh 
> runtime/jni/ReturnJNIWeak/test.sh
> 
> **Problem:**
> Tests build 64-bit JNI libraries and trying to use them for 32-bit jdk, resulting in error:
> 
> Exception in thread "main" java.lang.UnsatisfiedLinkError: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/libCNCheckLongArgs.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch)
> 
> These tests only target Linux and (some) Solaris.
> 
> **Solution:**
> Fixed by supplying appropriate compiler argument (-m32) to build 32-bit libraries for 32-bit JDK. (Some tests already did that, but not in uniform way). I verified in manpage of gcc that -m32 argument is supported for all 32-bit variants of architectures supported by JDK 8 [1]. Solaris cc also seems to support -m32 [2].
> This fix is JDK 8 only as newer JDK use new approach, where JNI test libraries are build are build system and tests not longer build them themselfs.
> 
> **Testing:**
> Change fixed these tests on linux-x86. (tested here [3])
> Tests are part of hotspot/tier1. This is one of problems, which needs to be fixed, so that hotspot/tier1 can be enabled in GHA on linux-x86. Other one is JDK-8295952 [4] (will need to get fixed and backported).
> 
> [1]  https://man7.org/linux/man-pages/man1/gcc.1.html
> [2] https://docs.oracle.com/cd/E37069_01/html/E54439/cc-1.html
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3441392968
> [4] https://bugs.openjdk.org/browse/JDK-8295952

This pull request has now been integrated.

Changeset: 7024bf0a
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7024bf0af8169ea8e36d812860072c40d5371327
Stats:     22 lines in 8 files changed: 6 ins; 9 del; 7 mod

8296959: Fix hotspot shell tests of 8u on multilib systems

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/173

From duke at openjdk.org  Tue Nov 15 13:10:10 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 15 Nov 2022 13:10:10 GMT
Subject: [jdk8u-dev] RFR: 8284389: Improve stability of GHA Pre-submit
 testing by caching cygwin installer
In-Reply-To: <EjDWRh74shyHMaJ2TpyRUZ-JvpDVZ2qySBtRoUNeR90=.c447f0fe-2e5f-452a-9da5-d8ebb50f6163@github.com>
References: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>
 <EjDWRh74shyHMaJ2TpyRUZ-JvpDVZ2qySBtRoUNeR90=.c447f0fe-2e5f-452a-9da5-d8ebb50f6163@github.com>
Message-ID: <Qdc0SRWTm4yyREUx_vVC4qs1GRG935Q7Y0qCXJeC2_Q=.352a6369-202f-4f8d-a134-a01532802d56@github.com>

On Tue, 15 Nov 2022 09:03:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Adds cygwin installer caching.
>> 
>> Few notes:
>> - Cache also added for windows-x86, which is not present on JDK 11.
>> - Used actions/cache at v3 (I have already done backport updating GHA actions, out of order, before this)
>
> Marked as reviewed by sgehwolf (Reviewer).

@jerboaa Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/174

From duke at openjdk.org  Tue Nov 15 13:32:29 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 15 Nov 2022 13:32:29 GMT
Subject: [jdk8u-dev] Integrated: 8284389: Improve stability of GHA Pre-submit
 testing by caching cygwin installer
In-Reply-To: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>
References: <MsJKIFGBJp4NvC81zTpKQ7f8LEoGXuf6k7WB6-2D2vw=.43f9aa4c-8b0e-4a73-a318-144f27a0a9e2@github.com>
Message-ID: <du8Hbl-WYjxRzwFLG373afuFn-l8ONi1VNg3CRpKAxQ=.3ac78dbb-377d-4de5-b1e3-b3cd687d5394@github.com>

On Mon, 14 Nov 2022 20:33:23 GMT, zzambers <duke at openjdk.org> wrote:

> Adds cygwin installer caching.
> 
> Few notes:
> - Cache also added for windows-x86, which is not present on JDK 11.
> - Used actions/cache at v3 (I have already done backport updating GHA actions, out of order, before this)

This pull request has now been integrated.

Changeset: 6849667e
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6849667e9be3f46d91ff8c2a645b9435a2b420de
Stats:     60 lines in 1 file changed: 52 ins; 8 del; 0 mod

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewed-by: sgehwolf
Backport-of: 869b25975288398a1d60601daacf00a99f51cd56

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/174

From mbalao at openjdk.org  Tue Nov 15 16:55:39 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 15 Nov 2022 16:55:39 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <PBFabi9GA66dNRIlwsZywfFcB4ggsTsrwK7Zdu18X-A=.e4568613-2c01-48db-8578-a63629bf12ca@github.com>

On Thu, 3 Nov 2022 15:34:01 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

Hi @alexeybakhtin ,

Thanks for proposing this backport.

In addition to the inlined comments, I have this additional observation:

 * `jdk/test/sun/security/tools/jarsigner/oldsig.sh` is using SHA1, as well as JDK-11's OldSig.java. The security properties file that is now passed has the following comment: "Re-enable SHA-1 since OldSig.java test uses it". You mentioned 8217375 as the reason why changes are not required for the backport, but I'm having difficulties to find the connection and wonder if we should re-enable SHA1 for `oldsig.sh`. Can you please elaborate a bit on this?

Thanks,
Martin.-

jdk/test/java/security/Security/signedfirst/DynStatic.java line 36:

> 34: import java.util.List;
> 35: 
> 36: import jdk.test.lib.process.ProcessTools;

The `ProcessTools` class in JDK-8 has always been `jdk.testlibrary.ProcessTools`. To use it, you would only need `@library /lib/testlibrary` in the test's JTREG header. Unfortunately, one backport -which I presume to be JFR- introduced the same class, from a newer JDK release, at a different location. So we now have duplicated code for this test library and it is causing confusion: I can now see a couple of TLS test using this library when they shouldn't. Until we get rid of this technical debt, I suggest that all JDK-8 tests keep using `jdk.testlibrary.ProcessTools`.

jdk/test/sun/security/tools/jarsigner/TimestampCheck.java line 461:

> 459:                         .shouldMatch("Timestamp.*digest.*SHA-1.*(disabled)");
> 460: 
> 461:                 // Disabled algorithms

Isn't this comment removed?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From serb at openjdk.org  Wed Nov 16 02:55:59 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 16 Nov 2022 02:55:59 GMT
Subject: [jdk8u-dev] Integrated: 8286582: Build fails on macos aarch64 when
 using --with-zlib=bundled
In-Reply-To: <ImYzQRJ5mteFVjl4P0piwd0_GTLWZBNXegC-CM9YPGw=.476a9301-d6fe-4821-ae6a-144a00a2015a@github.com>
References: <ImYzQRJ5mteFVjl4P0piwd0_GTLWZBNXegC-CM9YPGw=.476a9301-d6fe-4821-ae6a-144a00a2015a@github.com>
Message-ID: <TQpxB7CbteK5ASftjipY55U5cp1x-qK19bDTyg90wwI=.ada389ca-1d58-4773-a8d4-cea5c2793112@github.com>

On Mon, 27 Jun 2022 00:33:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
> 
> The patch for JDK8 is slightly different:
>  * The main code patch is moved from the `make/autoconf/lib-bundled.m4` to the `jdk/make/lib/CoreLibraries.gmk` the same place where `":= -lz"` option is set.
>  * All disabled warnings are removed from the patch, seems we do not have such DISABLED_WARNINGS_XX in JDK8

This pull request has now been integrated.

Changeset: 7ae002ca
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7ae002caba9ef17db5c105f76478424ce4cde04a
Stats:     4 lines in 1 file changed: 3 ins; 0 del; 1 mod

8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Reviewed-by: phh, sgehwolf
Backport-of: 8363d9db801314f13e708db62993da5b73634f69

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/80

From jdowland at openjdk.org  Wed Nov 16 10:46:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 10:46:03 GMT
Subject: [jdk8u-dev] RFR: 8252957: Wrong comment in
 CgroupV1Subsystem::cpu_quota
Message-ID: <HMBOxy7GXn7eWD1jZOra2oSlYzKQkl8HR0I3-M16egk=.1bccef4a-4aa4-4a44-b0af-e439dafab265@github.com>

Simple, comment-only backport for cgroups v2 support in jdk8u. Clean.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/175

Commit messages:
 - 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota

Changes: https://git.openjdk.org/jdk8u-dev/pull/176/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=176&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8252957
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/176.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/176/head:pull/176

PR: https://git.openjdk.org/jdk8u-dev/pull/176

From jdowland at openjdk.org  Wed Nov 16 10:54:55 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 10:54:55 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics
Message-ID: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>

A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/176

Commit messages:
 - 8266391: Replace use of reflection in jdk.internal.platform.Metrics

Changes: https://git.openjdk.org/jdk8u-dev/pull/177/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=177&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8266391
  Stats: 103 lines in 4 files changed: 93 ins; 8 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/177.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/177/head:pull/177

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From jdowland at openjdk.org  Wed Nov 16 11:04:17 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 11:04:17 GMT
Subject: [jdk8u-dev] RFR: 8284756: [11u] Remove unused isUseContainerSupport in
 CgroupV1Subsystem
Message-ID: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>

Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/177

Commit messages:
 - 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem

Changes: https://git.openjdk.org/jdk8u-dev/pull/178/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=178&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284756
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/178.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/178/head:pull/178

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From jdowland at openjdk.org  Wed Nov 16 11:13:18 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 11:13:18 GMT
Subject: [jdk8u-dev] RFR: 8284102: [TESTBUG] [11u] Retroactively add regression
 test for JDK-8272124
Message-ID: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>

Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/178

Commit messages:
 - adjust Files.writeString?write for jdk8u
 - 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124

Changes: https://git.openjdk.org/jdk8u-dev/pull/179/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=179&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284102
  Stats: 53 lines in 1 file changed: 53 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/179.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/179/head:pull/179

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From jdowland at openjdk.org  Wed Nov 16 11:51:24 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 11:51:24 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may exceed
 physical machine memory
Message-ID: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>

This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/179

Commit messages:
 - Fix Asserts library for hotspot test in 8u
 - replace log_(trace|debug) for jdk8u
 - 8292083: Detected container memory limit may exceed physical machine memory

Changes: https://git.openjdk.org/jdk8u-dev/pull/180/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=180&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8292083
  Stats: 102 lines in 7 files changed: 66 ins; 28 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/180.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/180/head:pull/180

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From jdowland at openjdk.org  Wed Nov 16 11:51:25 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 11:51:25 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <D1k3tNmurRyYE6pECdusgGb3_r2dpjk8TNvtN92A9fI=.662e536b-b74d-49f6-a4e6-e99f6067f9f9@github.com>

On Wed, 16 Nov 2022 11:44:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

The test builds and runs for me, and currently fails on my  cgroup v2 system with


JavaTest Message: Test threw exception: java.lang.RuntimeException: 'OperatingSystemMXBean.getTotalSwapSpaceSize: [0-9]+' missing from stdout/stderr 


the relevant log line is reporting a negative value


OperatingSystemMXBean.getTotalSwapSpaceSize: -52428800


I will investigate further

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From sgehwolf at openjdk.org  Wed Nov 16 13:27:08 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 13:27:08 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics
In-Reply-To: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
Message-ID: <iZFjfb7AcEW5VmqaPJOBwPmm0E2TVnpghTtTBHAhkLs=.72be42fa-9f2f-4dd3-a82b-096c31ba71b6@github.com>

On Wed, 16 Nov 2022 10:47:37 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

@jmtd Clean backport but breaks the macosx build. I think we need another `null` returning `SystemMetrics` class in `jdk/src/macosx/classes` folder.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From sgehwolf at openjdk.org  Wed Nov 16 13:52:30 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 13:52:30 GMT
Subject: [jdk8u-dev] RFR: 8284756: [11u] Remove unused
 isUseContainerSupport in CgroupV1Subsystem
In-Reply-To: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
References: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
Message-ID: <Cb4DGbNs_rQgK1WjLySaFgJjq3558lWIab5MOhK8ECs=.45be2173-9307-486a-a9da-cfd5686e8370@github.com>

On Wed, 16 Nov 2022 10:55:51 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.

Agreed. Clean backport. Marking as such.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From duke at openjdk.org  Wed Nov 16 14:02:48 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 14:02:48 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
Message-ID: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>

Following test (from hotspot/tier1) currently fails on Windows x86:
`hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`

**Test output:**

...
 stdout: [];
 stderr: [openjdk version "1.8.0_362-internal"
OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
OpenJDK Server VM (build 25.362-b00, mixed mode)
]
 exitValue = 0

java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 

	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
	at java.lang.Thread.run(Thread.java:750)
...


**Problem:**
Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).

**Fix:**
Test runs java with `-version` argument, which can print something similar to:

openjdk version "1.8.0_362-internal"
OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
OpenJDK Client VM (build 25.362-b00, mixed mode)

This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.

**Testing:**
With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)

[1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
[2] https://bugs.openjdk.org/browse/JDK-8154204
[3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
[4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672

-------------

Commit messages:
 - Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java

Changes: https://git.openjdk.org/jdk8u-dev/pull/181/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=181&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297141
  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/181.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/181/head:pull/181

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From duke at openjdk.org  Wed Nov 16 14:10:07 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 14:10:07 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java is
 failing on 32bit Windows
Message-ID: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>

Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.

-------------

Commit messages:
 - Backport 0cf828153cf8ee337645645b0632e77b8733a734

Changes: https://git.openjdk.org/jdk8u-dev/pull/182/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=182&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8241086
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/182.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/182/head:pull/182

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From jdowland at openjdk.org  Wed Nov 16 14:51:31 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 14:51:31 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v2]
In-Reply-To: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
Message-ID: <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>

> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Add a macosx platform specific SystemMetrics class

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/177/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/177/files/d458c605..86708c07

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=177&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=177&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/177.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/177/head:pull/177

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From sgehwolf at openjdk.org  Wed Nov 16 15:26:15 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 15:26:15 GMT
Subject: [jdk8u-dev] RFR: 8266391: Replace use of reflection in
 jdk.internal.platform.Metrics [v2]
In-Reply-To: <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
References: <g7RG2DZHfz5Fo7fxo56Q4FIsUdQlABEvbthK8k3xOwU=.74f82cd8-e4eb-4db1-a5c8-eb2a1a19d391@github.com>
 <k2EWx15uzhpGQWYRzB_XmiMBH4a5paKeFt7HzEO3hws=.f6473142-56b6-4653-91a3-3534238079e9@github.com>
Message-ID: <riouuM_mfR9dnorbVLox2e-GfJudnztdd5ooD-dGjXg=.059ba18f-7722-44a0-8a8d-2757416d3277@github.com>

On Wed, 16 Nov 2022 14:51:31 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a macosx platform specific SystemMetrics class

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/177

From sgehwolf at openjdk.org  Wed Nov 16 15:34:19 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 15:34:19 GMT
Subject: [jdk8u-dev] RFR: 8284102: [TESTBUG] [11u] Retroactively add
 regression test for JDK-8272124
In-Reply-To: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
References: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
Message-ID: <LLsxq4ysPZ0AnXI-SA21Qrg3Q_bQ9upMk5gsCf9oHkU=.a18e97e1-f68e-45a9-a610-f350b62a1f33@github.com>

On Wed, 16 Nov 2022 11:05:10 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From abakhtin at openjdk.org  Wed Nov 16 15:58:23 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 16 Nov 2022 15:58:23 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  test fixes

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/154/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/154/files/0cccb13a..2f2e7b20

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/154.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/154/head:pull/154

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Wed Nov 16 15:58:25 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 16 Nov 2022 15:58:25 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <PBFabi9GA66dNRIlwsZywfFcB4ggsTsrwK7Zdu18X-A=.e4568613-2c01-48db-8578-a63629bf12ca@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <PBFabi9GA66dNRIlwsZywfFcB4ggsTsrwK7Zdu18X-A=.e4568613-2c01-48db-8578-a63629bf12ca@github.com>
Message-ID: <h8a13ZIj6w4yheJ5InjkAOcUXIp5YFELxePZIzGYc8w=.a213ad0f-3ea4-4e59-98a7-70298f1e5c21@github.com>

On Tue, 15 Nov 2022 16:52:35 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fixes
>
> Hi @alexeybakhtin ,
> 
> Thanks for proposing this backport.
> 
> In addition to the inlined comments, I have this additional observation:
> 
>  * `jdk/test/sun/security/tools/jarsigner/oldsig.sh` is using SHA1, as well as JDK-11's OldSig.java. The security properties file that is now passed has the following comment: "Re-enable SHA-1 since OldSig.java test uses it". You mentioned 8217375 as the reason why changes are not required for the backport, but I'm having difficulties to find the connection and wonder if we should re-enable SHA1 for `oldsig.sh`. Can you please elaborate a bit on this?
> 
> Thanks,
> Martin.-

Hello @martinuy

> jdk/test/java/security/Security/signedfirst/DynStatic.java line 36:
> 
>> 34: import java.util.List;
>> 35: 
>> 36: import jdk.test.lib.process.ProcessTools;
> 
> The `ProcessTools` class in JDK-8 has always been `jdk.testlibrary.ProcessTools`. To use it, you would only need `@library /lib/testlibrary` in the test's JTREG header. Unfortunately, one backport -which I presume to be JFR- introduced the same class, from a newer JDK release, at a different location. So we now have duplicated code for this test library and it is causing confusion: I can now see a couple of TLS test using this library when they shouldn't. Until we get rid of this technical debt, I suggest that all JDK-8 tests keep using `jdk.testlibrary.ProcessTools`.

Thank you. You are right. jdk.testlibrary.ProcessTools is a better choice even if some modifications are required.
Fixed

> jdk/test/sun/security/tools/jarsigner/TimestampCheck.java line 461:
> 
>> 459:                         .shouldMatch("Timestamp.*digest.*SHA-1.*(disabled)");
>> 460: 
>> 461:                 // Disabled algorithms
> 
> Isn't this comment removed?

Thank you. Fixed

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From sgehwolf at openjdk.org  Wed Nov 16 16:02:13 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 16:02:13 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <D1k3tNmurRyYE6pECdusgGb3_r2dpjk8TNvtN92A9fI=.662e536b-b74d-49f6-a4e6-e99f6067f9f9@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
 <D1k3tNmurRyYE6pECdusgGb3_r2dpjk8TNvtN92A9fI=.662e536b-b74d-49f6-a4e6-e99f6067f9f9@github.com>
Message-ID: <Tpkg-fTLReOwsGzTJ2__YFh2IN16RE0ATAnOAagGC40=.376565ba-ed15-4ca9-b2dd-5ac73a34aa4e@github.com>

On Wed, 16 Nov 2022 11:45:20 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> -52428800

I cannot reproduce on my cg v2 system. Is this a system with `swapaccount=0`?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From jdowland at openjdk.org  Wed Nov 16 16:26:15 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 16:26:15 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <jeNlICIwdlM-GSNpR2RQ2oX3Qg-6MADmeqqpfIOjyQ4=.97cc4588-97ef-4678-bb7b-63be32fb9e52@github.com>

On Wed, 16 Nov 2022 11:44:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

The test runs in a `oraclelinux:7.6` container which has glibc 2.17, versus my build machine which has 2.33, so I can't run it as-is. I'd previously aliased the name `oraclelinux:7.6` to something with a matching ABI (an Ubuntu image iirc) which explains the discrepancy here.

I'd made a mental note in the past to raise the issue of what was a reasonable baseline libc ABI for jdk8u-dev, and look at backports that change the base image for the tests (I don't think 11u or newer are using `oraclelinux:7.6` but ICBW)

If you can run the test and it passes, I'm satisfied :)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From jdowland at openjdk.org  Wed Nov 16 16:28:20 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 16 Nov 2022 16:28:20 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <c0P97Wh1fjUsRF28EvfPUgeoxy2AAUVyb_Qme6fb61A=.55c513ca-f337-461e-913e-41ab746eb29b@github.com>

On Wed, 16 Nov 2022 11:44:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

?and running `CheckOperatingSystemMXBean` locally (not through jtreg, not in the `oraclelinux:7.6` container) I see a reasonable value

OperatingSystemMXBean.getTotalSwapSpaceSize: 1023406080

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From sgehwolf at openjdk.org  Wed Nov 16 17:09:07 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 17:09:07 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <jeNlICIwdlM-GSNpR2RQ2oX3Qg-6MADmeqqpfIOjyQ4=.97cc4588-97ef-4678-bb7b-63be32fb9e52@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
 <jeNlICIwdlM-GSNpR2RQ2oX3Qg-6MADmeqqpfIOjyQ4=.97cc4588-97ef-4678-bb7b-63be32fb9e52@github.com>
Message-ID: <dGLaXy-yrDMT3hhmE8IOzHx_4v-jZUvAcCK7MDKupIw=.58e8d6b7-f05b-4549-a41f-8a901d1c2d78@github.com>

On Wed, 16 Nov 2022 16:22:28 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> The test runs in a `oraclelinux:7.6` container which has glibc 2.17, versus my build machine which has 2.33, so I can't run it as-is. I'd previously aliased the name `oraclelinux:7.6` to something with a matching ABI (an Ubuntu image iirc) which explains the discrepancy here.

Ugh. I'd recommend running tests with ` -Djdk.test.docker.image.name=<base-image>` and `-Djdk.test.docker.image.version=<image-version>` that matches the JDK build you've done.  For example on F37 I use `-Djdk.test.docker.image.name=fedora -Djdk.test.docker.image.version=37`

I'm surprised this works for you at all ;-)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From sgehwolf at openjdk.org  Wed Nov 16 17:31:09 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 17:31:09 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
In-Reply-To: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
Message-ID: <fGGoh8xeJVbIyRjykSlOF8wgPosfVjBiWZRCCR28MGg=.5f3fd4f7-9135-452b-83ef-f363559ce6b4@github.com>

On Wed, 16 Nov 2022 13:55:19 GMT, zzambers <duke at openjdk.org> wrote:

> Following test (from hotspot/tier1) currently fails on Windows x86:
> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
> 
> **Test output:**
> 
> ...
>  stdout: [];
>  stderr: [openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
> OpenJDK Server VM (build 25.362-b00, mixed mode)
> ]
>  exitValue = 0
> 
> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
> 
> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
> 	at java.lang.Thread.run(Thread.java:750)
> ...
> 
> 
> **Problem:**
> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
> 
> **Fix:**
> Test runs java with `-version` argument, which can print something similar to:
> 
> openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
> OpenJDK Client VM (build 25.362-b00, mixed mode)
> 
> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
> 
> **Testing:**
> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
> 
> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
> [2] https://bugs.openjdk.org/browse/JDK-8154204
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672

Shouldn't we just amend the condition on lines 41-45 to something like:


boolean is32BitWindowsClientVm = (Platform.isWindows() && Platform.is32bit() && Platform.isClient());
if (!is32BitWindowsClientVm) {
    System.out.println("Test only applicable on 32-bit Windows Client VM. Skipping");
    return;
}

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From duke at openjdk.org  Wed Nov 16 17:45:11 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 17:45:11 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
In-Reply-To: <fGGoh8xeJVbIyRjykSlOF8wgPosfVjBiWZRCCR28MGg=.5f3fd4f7-9135-452b-83ef-f363559ce6b4@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
 <fGGoh8xeJVbIyRjykSlOF8wgPosfVjBiWZRCCR28MGg=.5f3fd4f7-9135-452b-83ef-f363559ce6b4@github.com>
Message-ID: <6RXAT2qJaestX-xRvdf6ViHgm9PrcyzRJoQ-vHZCuWE=.ab010e37-394e-4c96-b31a-6bfb88bb70f2@github.com>

On Wed, 16 Nov 2022 17:27:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Following test (from hotspot/tier1) currently fails on Windows x86:
>> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
>> 
>> **Test output:**
>> 
>> ...
>>  stdout: [];
>>  stderr: [openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
>> OpenJDK Server VM (build 25.362-b00, mixed mode)
>> ]
>>  exitValue = 0
>> 
>> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
>> 
>> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
>> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ...
>> 
>> 
>> **Problem:**
>> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
>> 
>> **Fix:**
>> Test runs java with `-version` argument, which can print something similar to:
>> 
>> openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
>> OpenJDK Client VM (build 25.362-b00, mixed mode)
>> 
>> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
>> 
>> **Testing:**
>> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
>> 
>> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
>> [2] https://bugs.openjdk.org/browse/JDK-8154204
>> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
>> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672
>
> Shouldn't we just amend the condition on lines 41-45 to something like:
> 
> 
> boolean is32BitWindowsClientVm = (Platform.isWindows() && Platform.is32bit() && Platform.isClient());
> if (!is32BitWindowsClientVm) {
>     System.out.println("Test only applicable on 32-bit Windows Client VM. Skipping");
>     return;
> }

@jerboaa Oh, that is indeed cleaner. I have not checked Platform class and I did not know it is capable of that. I'll update my PR. Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From duke at openjdk.org  Wed Nov 16 17:50:21 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 17:50:21 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
In-Reply-To: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
Message-ID: <Ey5NfovrYwT5c-XtkoM0tWFRC9IVhFSSm1TdkKgdph0=.4bb8ba91-95a8-4111-be2a-b226f02d315d@github.com>

On Wed, 16 Nov 2022 13:55:19 GMT, zzambers <duke at openjdk.org> wrote:

> Following test (from hotspot/tier1) currently fails on Windows x86:
> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
> 
> **Test output:**
> 
> ...
>  stdout: [];
>  stderr: [openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
> OpenJDK Server VM (build 25.362-b00, mixed mode)
> ]
>  exitValue = 0
> 
> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
> 
> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
> 	at java.lang.Thread.run(Thread.java:750)
> ...
> 
> 
> **Problem:**
> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
> 
> **Fix:**
> Test runs java with `-version` argument, which can print something similar to:
> 
> openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
> OpenJDK Client VM (build 25.362-b00, mixed mode)
> 
> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
> 
> **Testing:**
> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
> 
> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
> [2] https://bugs.openjdk.org/browse/JDK-8154204
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672

Even though, I should test that VM launched with "-client" uses Client VM (maybe case where it has Client VM but it is not default). I would then probably need to run test in othervm and with -client arg as well.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From sgehwolf at openjdk.org  Wed Nov 16 17:52:29 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 17:52:29 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows
In-Reply-To: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
Message-ID: <GcA-RuRYN6qg_dYUHc36Mn83ut9IRtlq_LJCjgnr6S0=.4ae0984e-ffd6-4a8c-befd-14217fd1ffb8@github.com>

On Wed, 16 Nov 2022 14:02:48 GMT, zzambers <duke at openjdk.org> wrote:

> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.

hotspot/test/runtime/NMT/HugeArenaTracking.java line 28:

> 26:  * @key nmt jcmd
> 27:  * @library /testlibrary /testlibrary/whitebox
> 28:  * @requires vm.bits == 64

I don't think this has any effect on JDK 8. AFAIK, `vm.bits` is being set in JDK 11+ via `test/jtreg-ext/requires/VMProps.java` which isn't available in JDK 8. Have you tested this works?

I think something like this would be suitable here:


if (!Platform.is64Bit()) {
   System.out.println("Test requires 64 bits. Skipping...");
   return;
}

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From sgehwolf at openjdk.org  Wed Nov 16 18:00:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 16 Nov 2022 18:00:33 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <j97bZRUtfFo9bqISbaC9A7LQD8jE8KT0eRrWIf32FRk=.3d8128d7-344c-4dab-a477-74b065b4cb8a@github.com>

On Wed, 16 Nov 2022 11:44:39 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

Looks good to me.

Aside: @jmtd Could you please ensure the `SystemMetrics` fix for macosx of #177 gets into the depending PRs so that we get better GHA results. Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From phh at openjdk.org  Wed Nov 16 18:22:31 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 16 Nov 2022 18:22:31 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
Message-ID: <zUtwRoZkQvQOdYsjdStPkCXoNpDfpP3Pg2Bw1oWwfsM=.96f5ea3f-7a9b-4204-8365-cc78de2774af@github.com>

On Fri, 2 Sep 2022 07:08:22 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removing generated-configure.sh from PR

The copyright date should stay at 2018 because that's what the original commit had. Other than that, lgtm.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From duke at openjdk.org  Wed Nov 16 18:37:41 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 16 Nov 2022 18:37:41 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v4]
In-Reply-To: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
Message-ID: <mM4ENQXSjDhBC0NFXPXUKx-7mdn6z808MAHyEgxbLQU=.758162df-b1bd-4e61-998b-f7d8515f7855@github.com>

> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
> 
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
> 
> Verification: 2019 build (both 32/64) now fails with 
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> error (to be fixed by backport of 8043492)
> 
> Regression: 2017/2013/2012/2010 full build - ok
> 
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  fixing copyright date

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/77/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/77/files/a7c2b48d..c86b9dac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/77.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/77/head:pull/77

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From duke at openjdk.org  Wed Nov 16 18:37:42 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 16 Nov 2022 18:37:42 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <zUtwRoZkQvQOdYsjdStPkCXoNpDfpP3Pg2Bw1oWwfsM=.96f5ea3f-7a9b-4204-8365-cc78de2774af@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
 <zUtwRoZkQvQOdYsjdStPkCXoNpDfpP3Pg2Bw1oWwfsM=.96f5ea3f-7a9b-4204-8365-cc78de2774af@github.com>
Message-ID: <77lGBKs92TxdefG8BK7bVza-x9_rLMpAaSk9JZAFqBo=.820a4187-680f-4e11-8365-71e790429219@github.com>

On Wed, 16 Nov 2022 18:20:00 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> The copyright date should stay at 2018 because that's what the original commit had. Other than that, lgtm.

fixed

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From duke at openjdk.org  Wed Nov 16 18:39:42 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 18:39:42 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows
In-Reply-To: <GcA-RuRYN6qg_dYUHc36Mn83ut9IRtlq_LJCjgnr6S0=.4ae0984e-ffd6-4a8c-befd-14217fd1ffb8@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <GcA-RuRYN6qg_dYUHc36Mn83ut9IRtlq_LJCjgnr6S0=.4ae0984e-ffd6-4a8c-befd-14217fd1ffb8@github.com>
Message-ID: <quKVbslZLEK4068PzLIzPXp4BunySjIkn67yr-tfB10=.f82d855b-fc29-4fc6-a75e-10ffa2cfee88@github.com>

On Wed, 16 Nov 2022 17:49:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.
>
> hotspot/test/runtime/NMT/HugeArenaTracking.java line 28:
> 
>> 26:  * @key nmt jcmd
>> 27:  * @library /testlibrary /testlibrary/whitebox
>> 28:  * @requires vm.bits == 64
> 
> I don't think this has any effect on JDK 8. AFAIK, `vm.bits` is being set in JDK 11+ via `test/jtreg-ext/requires/VMProps.java` which isn't available in JDK 8. Have you tested this works?
> 
> I think something like this would be suitable here:
> 
> 
> if (!Platform.is64Bit()) {
>    System.out.println("Test requires 64 bits. Skipping...");
>    return;
> }

Oh, you are right. I ran tests with 32-bit OSes enabled [1] and failure there disappeared, so I considered it working. I haven't realized test was also excluded on 64-bits. (condition was basically treated as always false) Nice find, I'll fix it. Thanks

[1] https://github.com/zzambers/jdk8u-dev/actions/runs/3471605048/jobs/5802167187

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From duke at openjdk.org  Wed Nov 16 18:58:57 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 16 Nov 2022 18:58:57 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows
In-Reply-To: <quKVbslZLEK4068PzLIzPXp4BunySjIkn67yr-tfB10=.f82d855b-fc29-4fc6-a75e-10ffa2cfee88@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <GcA-RuRYN6qg_dYUHc36Mn83ut9IRtlq_LJCjgnr6S0=.4ae0984e-ffd6-4a8c-befd-14217fd1ffb8@github.com>
 <quKVbslZLEK4068PzLIzPXp4BunySjIkn67yr-tfB10=.f82d855b-fc29-4fc6-a75e-10ffa2cfee88@github.com>
Message-ID: <brAIuXigorzQmgghOgWZBqcAZ1PVZXhhpoNFrBEdRJ0=.a59085c3-8772-4508-9610-773f2fa63546@github.com>

On Wed, 16 Nov 2022 18:36:26 GMT, zzambers <duke at openjdk.org> wrote:

>> hotspot/test/runtime/NMT/HugeArenaTracking.java line 28:
>> 
>>> 26:  * @key nmt jcmd
>>> 27:  * @library /testlibrary /testlibrary/whitebox
>>> 28:  * @requires vm.bits == 64
>> 
>> I don't think this has any effect on JDK 8. AFAIK, `vm.bits` is being set in JDK 11+ via `test/jtreg-ext/requires/VMProps.java` which isn't available in JDK 8. Have you tested this works?
>> 
>> I think something like this would be suitable here:
>> 
>> 
>> if (!Platform.is64Bit()) {
>>    System.out.println("Test requires 64 bits. Skipping...");
>>    return;
>> }
>
> Oh, you are right (not supported on JDK 8). I ran tests with 32-bit OSes enabled [1] and failure there disappeared, so I considered it working. I haven't realized test was also excluded on 64-bits. (condition was basically treated as always false) Nice find, I'll fix it. Thanks
> 
> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3471605048/jobs/5802167187

But that reminds me, when I doing this backport, I  was actually wondering if it is supported on 8, so I grepped jdk8u-dev repo to see if there is some other tests doing this. There is one [2]. And it is indeed also skipped everywhere. So one more test to be fixed was discovered... :)

[2] https://github.com/openjdk/jdk8u-dev/blob/7ae002caba9ef17db5c105f76478424ce4cde04a/hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java#L29

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From phh at openjdk.org  Wed Nov 16 19:27:15 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 16 Nov 2022 19:27:15 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v4]
In-Reply-To: <mM4ENQXSjDhBC0NFXPXUKx-7mdn6z808MAHyEgxbLQU=.758162df-b1bd-4e61-998b-f7d8515f7855@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <mM4ENQXSjDhBC0NFXPXUKx-7mdn6z808MAHyEgxbLQU=.758162df-b1bd-4e61-998b-f7d8515f7855@github.com>
Message-ID: <NCqil0vnrKl8jGrDE9CV3g-VmS-1qEJ11v2sWzQziF8=.28f75705-34ae-4814-848c-49a921eedc3a@github.com>

On Wed, 16 Nov 2022 18:37:41 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixing copyright date

Thanks, lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From duke at openjdk.org  Wed Nov 16 19:42:51 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 16 Nov 2022 19:42:51 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v4]
In-Reply-To: <mM4ENQXSjDhBC0NFXPXUKx-7mdn6z808MAHyEgxbLQU=.758162df-b1bd-4e61-998b-f7d8515f7855@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <mM4ENQXSjDhBC0NFXPXUKx-7mdn6z808MAHyEgxbLQU=.758162df-b1bd-4e61-998b-f7d8515f7855@github.com>
Message-ID: <Stu_3-g1bxOWyzsnd3bRWIj9lYZwU4yoi29mHjGsYUE=.65189286-334f-401b-819c-a13c16380bb4@github.com>

On Wed, 16 Nov 2022 18:37:41 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixing copyright date

Thank you for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From mbalao at openjdk.org  Wed Nov 16 23:01:47 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Wed, 16 Nov 2022 23:01:47 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <h8a13ZIj6w4yheJ5InjkAOcUXIp5YFELxePZIzGYc8w=.a213ad0f-3ea4-4e59-98a7-70298f1e5c21@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <PBFabi9GA66dNRIlwsZywfFcB4ggsTsrwK7Zdu18X-A=.e4568613-2c01-48db-8578-a63629bf12ca@github.com>
 <h8a13ZIj6w4yheJ5InjkAOcUXIp5YFELxePZIzGYc8w=.a213ad0f-3ea4-4e59-98a7-70298f1e5c21@github.com>
Message-ID: <bt-gJSSgIVk1iVDETr8i1ss1g1q_9fDsDyV5MiAyoa0=.5184208b-92ce-4ad5-a79b-e6f224b17101@github.com>

On Wed, 16 Nov 2022 15:52:45 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> jdk/test/java/security/Security/signedfirst/DynStatic.java line 36:
>> 
>>> 34: import java.util.List;
>>> 35: 
>>> 36: import jdk.test.lib.process.ProcessTools;
>> 
>> The `ProcessTools` class in JDK-8 has always been `jdk.testlibrary.ProcessTools`. To use it, you would only need `@library /lib/testlibrary` in the test's JTREG header. Unfortunately, one backport -which I presume to be JFR- introduced the same class, from a newer JDK release, at a different location. So we now have duplicated code for this test library and it is causing confusion: I can now see a couple of TLS test using this library when they shouldn't. Until we get rid of this technical debt, I suggest that all JDK-8 tests keep using `jdk.testlibrary.ProcessTools`.
>
> Thank you. You are right. jdk.testlibrary.ProcessTools is a better choice even if some modifications are required.
> Fixed

Good, thanks.

>> jdk/test/sun/security/tools/jarsigner/TimestampCheck.java line 461:
>> 
>>> 459:                         .shouldMatch("Timestamp.*digest.*SHA-1.*(disabled)");
>>> 460: 
>>> 461:                 // Disabled algorithms
>> 
>> Isn't this comment removed?
>
> Thank you. Fixed

Good, thanks.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From mbalao at openjdk.org  Thu Nov 17 07:00:42 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 17 Nov 2022 07:00:42 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>
Message-ID: <myt4JsiP7W4iIPmOXKOikj0843OJGQYSeCyU7VsFgMw=.71cd9d6b-a460-4972-99bb-1334362c2676@github.com>

On Wed, 16 Nov 2022 15:58:23 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test fixes

I've verified that test `oldsig.sh` passes with and without SHA1. This is because even if a disabled algorithm is used for signing or if a disabled algorithm is found when verifying a signature, `jarsigner` returns `0`. While the jar is actually signed, the verification fails and the jar is considered unsigned. The test should do better in the assertion statement, for example by checking `sm  ... B.class` in a verbose output. The test in later JDK releases has been fixed and the assertion statement improved.

@alexeybakhtin, my suggestion would be to backport the JDK-11 OldSig.java test to JDK-8. I agree with you that doing all the .sh -> .Java test conversions is out of the scope of this backport, but I would make an exception for the case discussed here because, otherwise, we would be having a broken/useless test in JDK-8. I'm also open consider adding a better assertion statement to the current .sh test. What do you think?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Thu Nov 17 08:27:53 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 17 Nov 2022 08:27:53 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v3]
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <QlcPHB4fKHKm7YteTdGfHW-OR46KIBxMglwXCLgJ7pQ=.86796831-b4bd-404b-a714-f8da4074e9f1@github.com>

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  Update oldsig test

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/154/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/154/files/2f2e7b20..57d0b0ba

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=01-02

  Stats: 12 lines in 2 files changed: 9 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/154.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/154/head:pull/154

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Thu Nov 17 08:32:38 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 17 Nov 2022 08:32:38 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <myt4JsiP7W4iIPmOXKOikj0843OJGQYSeCyU7VsFgMw=.71cd9d6b-a460-4972-99bb-1334362c2676@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>
 <myt4JsiP7W4iIPmOXKOikj0843OJGQYSeCyU7VsFgMw=.71cd9d6b-a460-4972-99bb-1334362c2676@github.com>
Message-ID: <G52OVV6BYFM3MCH85FQtOUwF1Bf8m8mf7J_-fKSn7KE=.30d46638-aa6b-4970-bac4-27277bffad88@github.com>

On Thu, 17 Nov 2022 06:58:36 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fixes
>
> I've verified that test `oldsig.sh` passes with and without SHA1. This is because even if a disabled algorithm is used for signing or if a disabled algorithm is found when verifying a signature, `jarsigner` returns `0`. While the jar is actually signed, the verification fails and the jar is considered unsigned. The test should do better in the assertion statement, for example by checking `sm  ... B.class` in a verbose output. The test in later JDK releases has been fixed and the assertion statement improved.
> 
> @alexeybakhtin, my suggestion would be to backport the JDK-11 OldSig.java test to JDK-8. I agree with you that doing all the .sh -> .Java test conversions is out of the scope of this backport, but I would make an exception for the case discussed here because, otherwise, we would be having a broken/useless test in JDK-8. I'm also open to consider adding a better assertion statement to the current .sh test. What do you think?

@martinuy, thank you for the review again.
I've updated the existing oldsig.sh and added OldSig.props file. Now test validates the signature.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From duke at openjdk.org  Thu Nov 17 09:05:41 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Thu, 17 Nov 2022 09:05:41 GMT
Subject: [jdk8u-dev] Integrated: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp
In-Reply-To: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
Message-ID: <4FLx3oW3z3x7pLwJk1o0DuHCkPtMXmn96s885VUQdys=.6102e121-d89b-4cf6-8f93-ae7f136f1b2b@github.com>

On Wed, 22 Jun 2022 08:31:36 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
> 
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
> 
> Verification: 2019 build (both 32/64) now fails with 
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> error (to be fixed by backport of 8043492)
> 
> Regression: 2017/2013/2012/2010 full build - ok
> 
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated

This pull request has now been integrated.

Changeset: b98d485d
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b98d485df4db6b5adf074444f9a94d2510faf5a0
Stats:     47 lines in 1 file changed: 6 ins; 34 del; 7 mod

8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp

Use <stdint.h> and <inttypes.h> on Windows instead of emulation.

Reviewed-by: phh
Backport-of: b8ab854bdcf625772e965a5e476e0a9db1b91f3f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From simonis at openjdk.org  Thu Nov 17 10:12:50 2022
From: simonis at openjdk.org (Volker Simonis)
Date: Thu, 17 Nov 2022 10:12:50 GMT
Subject: [jdk8u-dev] RFR: 6885993: Named Thread: introduce print() and
 print_on(outputStream* st) methods
Message-ID: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>

[6885993-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030314/6885993-jdk8-vs-jdk9.txt)
This is a backport of "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)". I request the downport for parity with Oracle JDK 8 where it was backported to 8u351 (see [JDK-8285702](https://bugs.openjdk.org/browse/JDK-8285702)). The change is required as dependency of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I'll be requesting next ([JDK-8073464](https://bugs.openjdk.org/browse/JDK-8073464) has also been downported to Oracle jdk8u351).

Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry
[6885993-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030290/6885993-jdk8-vs-jdk9.txt)
 (i.e. "Unknown").

The patch applies cleanly except for a single context mismatch in `vmThread.cpp`. I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience.

-------------

Commit messages:
 - 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods

Changes: https://git.openjdk.org/jdk8u-dev/pull/183/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=183&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-6885993
  Stats: 75 lines in 14 files changed: 13 ins; 61 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/183.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/183/head:pull/183

PR: https://git.openjdk.org/jdk8u-dev/pull/183

From simonis at openjdk.org  Thu Nov 17 10:41:26 2022
From: simonis at openjdk.org (Volker Simonis)
Date: Thu, 17 Nov 2022 10:41:26 GMT
Subject: [jdk8u-dev] RFR: 8073464: GC workers do not have thread names
Message-ID: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>

This is a backport of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see [JDK-8285732](https://bugs.openjdk.org/browse/JDK-8285732)). This downport depends on "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)" for which a [pull request already exists](https://github.com/openjdk/jdk8u-dev/pull/183).

Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").

The patch applies cleanly except for two copyright year mismatches in `concurrentGCThread.cpp` and `thread.hpp`.   I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [8073464-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030509/8073464-jdk8-vs-jdk9.txt))

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/183

Commit messages:
 - 8073464: GC workers do not have thread names

Changes: https://git.openjdk.org/jdk8u-dev/pull/184/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=184&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8073464
  Stats: 16 lines in 7 files changed: 8 ins; 2 del; 6 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/184.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/184/head:pull/184

PR: https://git.openjdk.org/jdk8u-dev/pull/184

From mbalao at openjdk.org  Thu Nov 17 15:55:28 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 17 Nov 2022 15:55:28 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <G52OVV6BYFM3MCH85FQtOUwF1Bf8m8mf7J_-fKSn7KE=.30d46638-aa6b-4970-bac4-27277bffad88@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>
 <myt4JsiP7W4iIPmOXKOikj0843OJGQYSeCyU7VsFgMw=.71cd9d6b-a460-4972-99bb-1334362c2676@github.com>
 <G52OVV6BYFM3MCH85FQtOUwF1Bf8m8mf7J_-fKSn7KE=.30d46638-aa6b-4970-bac4-27277bffad88@github.com>
Message-ID: <NQDpp0b23FmvRa8fxGpwqcBI5zTNYfJ1jOO_WwsNqR0=.41fd0c90-ddc2-4caa-a5db-c5d86ae43223@github.com>

On Thu, 17 Nov 2022 08:30:01 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I've verified that test `oldsig.sh` passes with and without SHA1. This is because even if a disabled algorithm is used for signing or if a disabled algorithm is found when verifying a signature, `jarsigner` returns `0`. While the jar is actually signed, the verification fails and the jar is considered unsigned. The test should do better in the assertion statement, for example by checking `sm  ... B.class` in a verbose output. The test in later JDK releases has been fixed and the assertion statement improved.
>> 
>> @alexeybakhtin, my suggestion would be to backport the JDK-11 OldSig.java test to JDK-8. I agree with you that doing all the .sh -> .Java test conversions is out of the scope of this backport, but I would make an exception for the case discussed here because, otherwise, we would be having a broken/useless test in JDK-8. I'm also open to consider adding a better assertion statement to the current .sh test. What do you think?
>
> @martinuy, thank you for the review again.
> I've updated the existing oldsig.sh and added OldSig.props file. Now test validates the signature.

@alexeybakhtin , thanks for addressing this concern.

What do you think about the following (minor) change to your proposal?

diff --git a/jdk/test/sun/security/tools/jarsigner/oldsig.sh b/jdk/test/sun/security/tools/jarsigner/oldsig.sh
index fcc2293d5d..5c8e328367 100644
--- a/jdk/test/sun/security/tools/jarsigner/oldsig.sh
+++ b/jdk/test/sun/security/tools/jarsigner/oldsig.sh
@@ -79,7 +79,8 @@ ${TESTJAVA}${FS}bin${FS}jarsigner \
     -digestalg SHA1 \
     B.jar c
 
-echo "${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar"
-LINES=`${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar | grep smk | grep B.class | wc -l`
+JAR_VERIFY_CMD="${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar"
+echo ${JAR_VERIFY_CMD}
+LINES=`${JAR_VERIFY_CMD} | grep smk | grep B.class | wc -l`
 [ $LINES = 1 ] || exit 1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Thu Nov 17 16:06:39 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 17 Nov 2022 16:06:39 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  oldsig test updated again

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/154/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/154/files/57d0b0ba..57637b6b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=154&range=02-03

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/154.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/154/head:pull/154

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Thu Nov 17 16:06:40 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 17 Nov 2022 16:06:40 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v2]
In-Reply-To: <NQDpp0b23FmvRa8fxGpwqcBI5zTNYfJ1jOO_WwsNqR0=.41fd0c90-ddc2-4caa-a5db-c5d86ae43223@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <Nwcd3_xOAxXSdQjGGxRFtgnH_AJ4DNx-V77RbG1O1yM=.8cbb1641-60bb-4373-a9f2-fc5d8324d9a7@github.com>
 <myt4JsiP7W4iIPmOXKOikj0843OJGQYSeCyU7VsFgMw=.71cd9d6b-a460-4972-99bb-1334362c2676@github.com>
 <G52OVV6BYFM3MCH85FQtOUwF1Bf8m8mf7J_-fKSn7KE=.30d46638-aa6b-4970-bac4-27277bffad88@github.com>
 <NQDpp0b23FmvRa8fxGpwqcBI5zTNYfJ1jOO_WwsNqR0=.41fd0c90-ddc2-4caa-a5db-c5d86ae43223@github.com>
Message-ID: <3p5yk-xoQCr0XUPKR29ZaJvKgwXfKQv4RtkWmjA22Tw=.5968f1fa-e7ba-40a0-81e3-e4cbd5e53734@github.com>

On Thu, 17 Nov 2022 15:51:46 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> @martinuy, thank you for the review again.
>> I've updated the existing oldsig.sh and added OldSig.props file. Now test validates the signature.
>
> @alexeybakhtin , thanks for addressing this concern.
> 
> What do you think about the following (minor) change to your proposal?
> 
> diff --git a/jdk/test/sun/security/tools/jarsigner/oldsig.sh b/jdk/test/sun/security/tools/jarsigner/oldsig.sh
> index fcc2293d5d..5c8e328367 100644
> --- a/jdk/test/sun/security/tools/jarsigner/oldsig.sh
> +++ b/jdk/test/sun/security/tools/jarsigner/oldsig.sh
> @@ -79,7 +79,8 @@ ${TESTJAVA}${FS}bin${FS}jarsigner \
>      -digestalg SHA1 \
>      B.jar c
>  
> -echo "${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar"
> -LINES=`${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar | grep smk | grep B.class | wc -l`
> +JAR_VERIFY_CMD="${TESTJAVA}${FS}bin${FS}jarsigner -verify ${KS_ARGS} ${PROP_ARGS} -verbose B.jar"
> +echo ${JAR_VERIFY_CMD}
> +LINES=`${JAR_VERIFY_CMD} | grep smk | grep B.class | wc -l`
>  [ $LINES = 1 ] || exit 1

@martinuy, Thank you! Sure it is better. Test updated

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From mbalao at openjdk.org  Thu Nov 17 16:15:29 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 17 Nov 2022 16:15:29 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <_wH9WqObRle4_l_tAJjUeeNbZ-dafpTGMfWhpjR5_90=.ce95afae-1627-455d-9a4b-d5404634036d@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

Looks good to me. Thanks for this contribution.

-------------

Marked as reviewed by mbalao (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From mbalao at openjdk.org  Thu Nov 17 16:19:31 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 17 Nov 2022 16:19:31 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <3ykeAJO9thuyBK3eYGCunyTgeObLfJlavhAvhPxdNMc=.20501126-a9f3-463b-bb86-d09909063696@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

One last note/reminder, this change has a CSR so 8u maintainers will look into that to approve this change.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From duke at openjdk.org  Thu Nov 17 23:05:28 2022
From: duke at openjdk.org (Joshua Cao)
Date: Thu, 17 Nov 2022 23:05:28 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <3S2iHgosgjVTl2-OQtjBAaeG5qjb1yxZmff4pQ1cKcs=.3a5569d5-c08f-4145-b273-623bd58012d5@github.com>

On Sun, 16 Oct 2022 05:39:23 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

ping so the PR is still active. waiting on `jdk-8u-fix-yes` label

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From jdowland at openjdk.org  Fri Nov 18 10:03:13 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 18 Nov 2022 10:03:13 GMT
Subject: [jdk8u-dev] RFR: 8253797: [cgroups v2] Account for the fact that swap
 accounting is disabled on some systems
Message-ID: <yV0TTtmloYwEpPcxo1xeYZj-R3vJNJ_M0muQ1T4kthM=.57959f64-9110-49ab-8738-3f4efc8b131d@github.com>

This is a clean backport of 8253797 (via 11u) for jdk8u-dev for cgroups v2 support.

The changed files are exercised by the jtreg test `TestSystemMetrics.java` which passes on my cgroups v2 system.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/168

Commit messages:
 - 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems

Changes: https://git.openjdk.org/jdk8u-dev/pull/185/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=185&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8253797
  Stats: 45 lines in 2 files changed: 24 ins; 1 del; 20 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/185.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/185/head:pull/185

PR: https://git.openjdk.org/jdk8u-dev/pull/185

From jdowland at openjdk.org  Fri Nov 18 10:03:20 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 18 Nov 2022 10:03:20 GMT
Subject: [jdk8u-dev] RFR: 8284756: [11u] Remove unused
 isUseContainerSupport in CgroupV1Subsystem [v2]
In-Reply-To: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
References: <CSeL_FK3dHwojSZ7B6LFKMd4QYJzTVhHbyXrQ_vzJ8M=.09f25f84-d591-47aa-9665-9798dfe188c2@github.com>
Message-ID: <o5CyY4CBlEW-DbNBlF5EUXRznO38wbX5R3ceQ2fKcbY=.0769f2d1-c9a7-4d49-86d0-c590b26a6c40@github.com>

> Clean simple backport of 8284756 for jdk8u-dev cgroups v2 support.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/178/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=178&range=01
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/178.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/178/head:pull/178

PR: https://git.openjdk.org/jdk8u-dev/pull/178

From jdowland at openjdk.org  Fri Nov 18 10:03:54 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 18 Nov 2022 10:03:54 GMT
Subject: [jdk8u-dev] RFR: 8284102: [TESTBUG] [11u] Retroactively add
 regression test for JDK-8272124 [v2]
In-Reply-To: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
References: <1aQIRgA-ktwzsk5i51vX99eXhtCukODGWapG3-PkMhM=.8e97f620-701c-486a-8db8-15e77b586804@github.com>
Message-ID: <dsv7v4cEG990hWHC0DZwgqGejuD4QRB6wkHeG_REwj0=.19c31e78-4f5a-495a-ab2e-94ec7268eed3@github.com>

> Backport of 8284102 for jdk8u-dev for cgroups v2 support. Not clean, needed `Files.writeString` adjustment. Test builds and passes for me afterwards.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - adjust Files.writeString?write for jdk8u
 - 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
   
   Reviewed-by: andrew
 - 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
 - Add a macosx platform specific SystemMetrics class

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/179/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/179/files/391d4203..9377fbd9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=179&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=179&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/179.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/179/head:pull/179

PR: https://git.openjdk.org/jdk8u-dev/pull/179

From jdowland at openjdk.org  Fri Nov 18 10:05:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 18 Nov 2022 10:05:44 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory [v2]
In-Reply-To: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
Message-ID: <144DLRZHauILUBPXosFLiuQiOCSxxtH3z7nh80nyCmY=.c840c7b0-8414-46ad-bca2-991f60f48e4f@github.com>

> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Fix Asserts library for hotspot test in 8u
 - replace log_(trace|debug) for jdk8u
 - 8292083: Detected container memory limit may exceed physical machine memory
   
   Reviewed-by: sgehwolf
   Backport-of: f694f8a7671002559e7d23fdb65d5e9c768f9c03

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/180/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=180&range=01
  Stats: 102 lines in 7 files changed: 66 ins; 28 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/180.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/180/head:pull/180

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From jdowland at openjdk.org  Fri Nov 18 10:05:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 18 Nov 2022 10:05:44 GMT
Subject: [jdk8u-dev] RFR: 8292083: Detected container memory limit may
 exceed physical machine memory
In-Reply-To: <c0P97Wh1fjUsRF28EvfPUgeoxy2AAUVyb_Qme6fb61A=.55c513ca-f337-461e-913e-41ab746eb29b@github.com>
References: <_VPgixnH7U28Y9KRvt9XrGB2j-Swo-d5QiZOpkwbCfg=.6c0cfd95-b981-4cf8-a9a6-45e48032fe1c@github.com>
 <c0P97Wh1fjUsRF28EvfPUgeoxy2AAUVyb_Qme6fb61A=.55c513ca-f337-461e-913e-41ab746eb29b@github.com>
Message-ID: <yycnWtgBejjnIrF8ZUTNoYgrPat09ifir2C3dbwDYzo=.863173a9-a6d1-470a-9c87-f835121959c6@github.com>

On Wed, 16 Nov 2022 16:26:09 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.
>
> ?and running `CheckOperatingSystemMXBean` locally (not through jtreg, not in the `oraclelinux:7.6` container) I see a reasonable value
> 
> OperatingSystemMXBean.getTotalSwapSpaceSize: 1023406080

> Aside: @jmtd Could you please ensure the SystemMetrics fix for macosx of https://github.com/openjdk/jdk8u-dev/pull/177 gets into the depending PRs so that we get better GHA results. Thanks!

Sure, I've rebased PR's 178, 179 and 180.  I think the GitHub view will look askew until the PR/xx branches are updated (by openjdk-bot?)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/180

From phh at openjdk.org  Fri Nov 18 13:36:33 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 18 Nov 2022 13:36:33 GMT
Subject: [jdk8u-dev] RFR: 6885993: Named Thread: introduce print() and
 print_on(outputStream* st) methods
In-Reply-To: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
References: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
Message-ID: <6w9-VeE6eE5bs0CrUGO9FFhODaIuDslQaOpQFYG49po=.0259c78f-9dbb-487c-8d8e-7025b0b9acc1@github.com>

On Thu, 17 Nov 2022 10:06:12 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)". I request the downport for parity with Oracle JDK 8 where it was backported to 8u351 (see [JDK-8285702](https://bugs.openjdk.org/browse/JDK-8285702)). The change is required as dependency of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I'll be requesting next ([JDK-8073464](https://bugs.openjdk.org/browse/JDK-8073464) has also been downported to Oracle jdk8u351).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for a single context mismatch in `vmThread.cpp`. I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [6885993-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030290/6885993-jdk8-vs-jdk9.txt)).

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/183

From phh at openjdk.org  Fri Nov 18 13:42:36 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 18 Nov 2022 13:42:36 GMT
Subject: [jdk8u-dev] RFR: 8073464: GC workers do not have thread names
In-Reply-To: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
References: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
Message-ID: <tgSxNMFHEczV8GTs0WWP3mzLPtEkBaqcUf7nIvbT_Hc=.478f0d24-842f-4a42-950f-90c1d30db937@github.com>

On Thu, 17 Nov 2022 10:32:59 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see [JDK-8285732](https://bugs.openjdk.org/browse/JDK-8285732)). This downport depends on "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)" for which a [pull request already exists](https://github.com/openjdk/jdk8u-dev/pull/183).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for two copyright year mismatches in `concurrentGCThread.cpp` and `thread.hpp`.   I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [8073464-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030509/8073464-jdk8-vs-jdk9.txt))

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/184

From duke at openjdk.org  Fri Nov 18 15:04:31 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 18 Nov 2022 15:04:31 GMT
Subject: [jdk8u-dev] Integrated: 8079255: [TEST_BUG] [macosx] Test
 closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
In-Reply-To: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
References: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
Message-ID: <Vv50ExR5Rp9HHgbdfXUc-ibn9Xjahaa37gTypF6Brsc=.5735781c-c02e-4cb4-8569-0dfb1d723952@github.com>

On Sun, 16 Oct 2022 05:31:33 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. Clean backport. Also submitting a PR for https://bugs.openjdk.org/browse/JDK-8129827.

This pull request has now been integrated.

Changeset: 9cb87521
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/9cb87521c3eb693f4131fe575de50028eed2a8d9
Stats:     83 lines in 1 file changed: 83 ins; 0 del; 0 mod

8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Backport-of: e52bc6a831807006a20720f849e975428353cd17

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/140

From duke at openjdk.org  Fri Nov 18 15:09:51 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 18 Nov 2022 15:09:51 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails [v2]
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <PhCMRUdUuKwmHgudvueAxXgyZs45T-E0NFqoFXI0YIo=.e0ff2116-ba16-4481-a0cb-e6589a51cd2a@github.com>

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/141/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/141/files/f144ec00..f144ec00

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/141.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/141/head:pull/141

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From duke at openjdk.org  Fri Nov 18 18:06:56 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 18 Nov 2022 18:06:56 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails [v3]
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <Xczj4PpkAkrK6wfUUhXmsmBXKmcQvJn1_zY3bXxwfRA=.33f1b4ee-180b-4992-9694-578e79bb3f08@github.com>

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8129827
 - 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
 - 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/141/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/141/files/f144ec00..df904813

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=01-02

  Stats: 5334 lines in 91 files changed: 2981 ins; 1611 del; 742 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/141.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/141/head:pull/141

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From duke at openjdk.org  Fri Nov 18 20:17:59 2022
From: duke at openjdk.org (Joshua Cao)
Date: Fri, 18 Nov 2022 20:17:59 GMT
Subject: [jdk8u-dev] Integrated: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <w_3mT5N2mzOEsCoZVMJaEAAfMirsk0h65F4li-NFaXE=.3384b440-71b5-4c46-9516-dc155bbf2504@github.com>

On Sun, 16 Oct 2022 05:39:23 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

This pull request has now been integrated.

Changeset: 91d8b89a
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5
Stats:     42 lines in 1 file changed: 32 ins; 5 del; 5 mod

8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Reviewed-by: phh
Backport-of: a1efb95536fb3995780336604cc727f921770c63

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From duke at openjdk.org  Sat Nov 19 00:04:29 2022
From: duke at openjdk.org (Dan Lutker)
Date: Sat, 19 Nov 2022 00:04:29 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
Message-ID: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>

Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.

-------------

Commit messages:
 - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

Changes: https://git.openjdk.org/jdk8u-dev/pull/186/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=186&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8229182
  Stats: 29 lines in 3 files changed: 18 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/186.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/186/head:pull/186

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From duke at openjdk.org  Mon Nov 21 10:20:12 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 21 Nov 2022 10:20:12 GMT
Subject: [jdk8u-dev] RFR: 8297329: [8u] hotspot needs to recognise VS2019
Message-ID: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>

Hi!

Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and apply build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error

ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
jvm.dll : fatal error LNK1120: 1 unresolved externals


Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with

awt_DCHolder.cpp
C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
make[2]: *** Waiting for unfinished jobs....

that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)

Regression: MSVS2017 (32/64-bits, release/debug) build - Ok

-------------

Commit messages:
 - 8297329: [8u] hotspot needs to recognise VS2019

Changes: https://git.openjdk.org/jdk8u-dev/pull/187/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=187&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297329
  Stats: 23 lines in 3 files changed: 22 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/187.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/187/head:pull/187

PR: https://git.openjdk.org/jdk8u-dev/pull/187

From duke at openjdk.org  Mon Nov 21 12:34:40 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 21 Nov 2022 12:34:40 GMT
Subject: [jdk8u-dev] RFR: 8297329: [8u] hotspot needs to recognise VS2019
 [v2]
In-Reply-To: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
References: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
Message-ID: <OsyFLzKVHo_TeiKmcwBtaH2pr0TpRii9dd6L7jFv2cQ=.edf3b54d-89f8-4a54-aec4-16a336c847e1@github.com>

> Hi!
> 
> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and apply build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> 
> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
> 
> awt_DCHolder.cpp
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
> 
> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  fix line alignment to be compliant with the baseline

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/187/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/187/files/38050b1f..a7a11fdc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=187&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=187&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/187.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/187/head:pull/187

PR: https://git.openjdk.org/jdk8u-dev/pull/187

From duke at openjdk.org  Mon Nov 21 14:19:35 2022
From: duke at openjdk.org (Joshua Cao)
Date: Mon, 21 Nov 2022 14:19:35 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
Message-ID: <Hx-wUGvaSxqVMbrR_jOCuL4C_Ti5W-BrYY1OYxPUpUM=.d3276d61-4b3c-4836-a6c6-26ced540fd75@github.com>

On Thu, 20 Oct 2022 19:33:00 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
> 
> * fix file paths
> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
> * conflict in copyright year
> 
> Rest is clean.

waiting on `jdk8u-fix-yes` tag

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From aoqi at openjdk.org  Mon Nov 21 16:10:09 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 21 Nov 2022 16:10:09 GMT
Subject: [jdk8u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails with
 SunCertPathBuilderException
Message-ID: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>

I request the backport for parity with Oracle JDK 8. The patch applies clean after the fix of the copyright year and the import part. This backport is only a test change and fixes the test failure.

-------------

Commit messages:
 - Backport 520db1eeb18797c782ddfad90467e19bbdd424ac

Changes: https://git.openjdk.org/jdk8u-dev/pull/188/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=188&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296485
  Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/188.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/188/head:pull/188

PR: https://git.openjdk.org/jdk8u-dev/pull/188

From aoqi at openjdk.org  Mon Nov 21 16:10:20 2022
From: aoqi at openjdk.org (Ao Qi)
Date: Mon, 21 Nov 2022 16:10:20 GMT
Subject: [jdk8u-dev] RFR: 8296480:
 java/security/cert/pkix/policyChanges/TestPolicy.java is failing
Message-ID: <Eobym4MMbA4sIvCZ9LKyHpWhjFmFaa7irTElhjJXgVI=.f1fb70be-d04b-4a00-bcdf-255de8631783@github.com>

I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.

-------------

Commit messages:
 - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34

Changes: https://git.openjdk.org/jdk8u-dev/pull/189/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=189&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296480
  Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/189.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/189/head:pull/189

PR: https://git.openjdk.org/jdk8u-dev/pull/189

From duke at openjdk.org  Mon Nov 21 17:32:04 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 21 Nov 2022 17:32:04 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u [v2]
In-Reply-To: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
Message-ID: <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>

> Following test (from hotspot/tier1) currently fails on Windows x86:
> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
> 
> **Test output:**
> 
> ...
>  stdout: [];
>  stderr: [openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
> OpenJDK Server VM (build 25.362-b00, mixed mode)
> ]
>  exitValue = 0
> 
> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
> 
> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
> 	at java.lang.Thread.run(Thread.java:750)
> ...
> 
> 
> **Problem:**
> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
> 
> **Fix:**
> Test runs java with `-version` argument, which can print something similar to:
> 
> openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
> OpenJDK Client VM (build 25.362-b00, mixed mode)
> 
> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
> 
> **Testing:**
> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
> 
> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
> [2] https://bugs.openjdk.org/browse/JDK-8154204
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672

zzambers has updated the pull request incrementally with one additional commit since the last revision:

  Changed detection of client VM

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/181/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/181/files/72999289..e95b9564

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=181&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=181&range=00-01

  Stats: 8 lines in 1 file changed: 0 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/181.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/181/head:pull/181

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From duke at openjdk.org  Mon Nov 21 17:40:43 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 21 Nov 2022 17:40:43 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u [v2]
In-Reply-To: <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
 <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>
Message-ID: <L-P53j5GT7zyRZIhjZ0_8j04Y2vufBn6WR2wusD2Zos=.b729621c-dd31-4559-b918-3efbaa13a021@github.com>

On Mon, 21 Nov 2022 17:32:04 GMT, zzambers <duke at openjdk.org> wrote:

>> Following test (from hotspot/tier1) currently fails on Windows x86:
>> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
>> 
>> **Test output:**
>> 
>> ...
>>  stdout: [];
>>  stderr: [openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
>> OpenJDK Server VM (build 25.362-b00, mixed mode)
>> ]
>>  exitValue = 0
>> 
>> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
>> 
>> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
>> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ...
>> 
>> 
>> **Problem:**
>> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
>> 
>> **Fix:**
>> Test runs java with `-version` argument, which can print something similar to:
>> 
>> openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
>> OpenJDK Client VM (build 25.362-b00, mixed mode)
>> 
>> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
>> 
>> **Testing:**
>> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
>> 
>> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
>> [2] https://bugs.openjdk.org/browse/JDK-8154204
>> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
>> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed detection of client VM

Updated detection code. Tested on both default build [5] (without Client VM) and build with Client VM [6] with windows-x86 testing enabled. Passed both.

[5] https://github.com/zzambers/jdk8u-dev/actions/runs/3482764139
[6] https://github.com/zzambers/jdk8u-dev/actions/runs/3483679375

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From btaylor at openjdk.org  Mon Nov 21 18:00:36 2022
From: btaylor at openjdk.org (Ben Taylor)
Date: Mon, 21 Nov 2022 18:00:36 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <eUpCK1TZXAuZpw8J6fk2uzWzA3fmhK1X7ee2pPMDAmU=.9ee43f24-a8dd-4636-9f89-8c096d5b69ef@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
> - `git rebase -i HEAD~3` (squash commits)

Xin is right, edited the PR to use the correct bug id.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From duke at openjdk.org  Mon Nov 21 18:02:09 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 21 Nov 2022 18:02:09 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows [v2]
In-Reply-To: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
Message-ID: <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>

> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.

zzambers has updated the pull request incrementally with one additional commit since the last revision:

  Fixed detection for 64-bit JVM

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/182/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/182/files/b700a30f..d513aeb6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=182&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=182&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/182.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/182/head:pull/182

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From duke at openjdk.org  Mon Nov 21 18:06:14 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 21 Nov 2022 18:06:14 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows [v2]
In-Reply-To: <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
Message-ID: <--wyyLaPJD8jDweOiNTfY9NCAnk5Tbdo-xbtWfILmro=.607ef289-b27c-485f-81e7-481d3adb35bb@github.com>

On Mon, 21 Nov 2022 18:02:09 GMT, zzambers <duke at openjdk.org> wrote:

>> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed detection for 64-bit JVM

Fixed. Tested with 32-bit testing enabled.  Passes. (Skipped on 32-bits, no longer skipped on 64-bits.)

https://github.com/zzambers/jdk8u-dev/actions/runs/3482910658

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From phh at openjdk.org  Mon Nov 21 21:35:32 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 21 Nov 2022 21:35:32 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
In-Reply-To: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
Message-ID: <Rsh43ddlvssDlCfHOK7MS6o7y-YJMIHCyIUJFiXUO7Q=.a292f9db-c2a8-4cc5-a987-916e5859bed6@github.com>

On Fri, 18 Nov 2022 23:48:11 GMT, Dan Lutker <duke at openjdk.org> wrote:

> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.

The copyright line in TestMemoryAwareness and DockerRunOptions.java	 should be

 * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.

Otherwise, lgtm.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From phh at openjdk.org  Mon Nov 21 23:11:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 21 Nov 2022 23:11:39 GMT
Subject: [jdk8u-dev] RFR: 8297329: [8u] hotspot needs to recognise VS2019
 [v2]
In-Reply-To: <OsyFLzKVHo_TeiKmcwBtaH2pr0TpRii9dd6L7jFv2cQ=.edf3b54d-89f8-4a54-aec4-16a336c847e1@github.com>
References: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
 <OsyFLzKVHo_TeiKmcwBtaH2pr0TpRii9dd6L7jFv2cQ=.edf3b54d-89f8-4a54-aec4-16a336c847e1@github.com>
Message-ID: <yjqmYF6qMD-XPhTqWv39oLgh6NKVPa09gDXaRQePfOs=.54f981a2-e6e0-4966-b083-3406c3a6be45@github.com>

On Mon, 21 Nov 2022 12:34:40 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and applies build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> 
>> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
>> 
>> awt_DCHolder.cpp
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
>> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> 
>> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
>> 
>> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix line alignment to be compliant with the baseline

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/187

From duke at openjdk.org  Tue Nov 22 02:56:36 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Tue, 22 Nov 2022 02:56:36 GMT
Subject: [jdk8u-dev] RFR: 8297329: [8u] hotspot needs to recognise VS2019
 [v2]
In-Reply-To: <OsyFLzKVHo_TeiKmcwBtaH2pr0TpRii9dd6L7jFv2cQ=.edf3b54d-89f8-4a54-aec4-16a336c847e1@github.com>
References: <HpPvyLcF630QeKaVLvQSOK7GL9izaIXtPR4H_ZJWETE=.525d0fa4-5e13-4df3-9f0c-7089f036821b@github.com>
 <OsyFLzKVHo_TeiKmcwBtaH2pr0TpRii9dd6L7jFv2cQ=.edf3b54d-89f8-4a54-aec4-16a336c847e1@github.com>
Message-ID: <LMv60eC94fRLyoUNU6afP4b3TNdaa33ewUrxcRCaKYE=.72eb1d1b-6cdf-448f-b7c7-d53daa1f8f7a@github.com>

On Mon, 21 Nov 2022 12:34:40 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and applies build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> 
>> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
>> 
>> awt_DCHolder.cpp
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
>> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
>> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> 
>> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
>> 
>> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix line alignment to be compliant with the baseline

Paul, thank you for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/187

From duke at openjdk.org  Tue Nov 22 05:34:36 2022
From: duke at openjdk.org (psoujany)
Date: Tue, 22 Nov 2022 05:34:36 GMT
Subject: [jdk8u-dev] RFR: 8209052: Low contrast in
 docs/api/constant-values.html [v2]
In-Reply-To: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
References: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
Message-ID: <7eg5NPYQOsgrKlbCgN81OUsDVuSs4gYS-pY9RTcyjfw=.c9afbb5b-1ac0-431e-acf3-3458838f7128@github.com>

> Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
> Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/114/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/114/files/9c757dd9..be419286

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=00-01

  Stats: 32 lines in 1 file changed: 1 ins; 18 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/114.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/114/head:pull/114

PR: https://git.openjdk.org/jdk8u-dev/pull/114

From duke at openjdk.org  Tue Nov 22 06:03:03 2022
From: duke at openjdk.org (psoujany)
Date: Tue, 22 Nov 2022 06:03:03 GMT
Subject: [jdk8u-dev] RFR: 8209052: Low contrast in
 docs/api/constant-values.html [v3]
In-Reply-To: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
References: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
Message-ID: <mwbTtNcVN93bq7Qi-fr0WcPv2DW4mhC8Wf26j3mQ0lo=.09521488-5b2f-4b2a-9aa7-50b66b96b703@github.com>

> Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
> Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/114/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/114/files/be419286..45c2cd5d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=01-02

  Stats: 18 lines in 1 file changed: 5 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/114.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/114/head:pull/114

PR: https://git.openjdk.org/jdk8u-dev/pull/114

From duke at openjdk.org  Tue Nov 22 06:05:52 2022
From: duke at openjdk.org (psoujany)
Date: Tue, 22 Nov 2022 06:05:52 GMT
Subject: [jdk8u-dev] RFR: 8209052: Low contrast in
 docs/api/constant-values.html [v4]
In-Reply-To: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
References: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
Message-ID: <uoALdIE3WBAiywsDLLq90tRD_2UbAtwUCMQJ5rsd1dw=.4bb542d1-79a8-4bb4-af1d-1a5edd7c8bcd@github.com>

> Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
> Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/114/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/114/files/45c2cd5d..8dcf1764

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=114&range=02-03

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/114.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/114/head:pull/114

PR: https://git.openjdk.org/jdk8u-dev/pull/114

From sgehwolf at openjdk.org  Tue Nov 22 09:57:29 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 22 Nov 2022 09:57:29 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u [v2]
In-Reply-To: <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
 <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>
Message-ID: <EV_vEWmtcSEMkaw1_yGx5TwNfjagkPkelIk17-cL3RU=.d7512f79-1f86-4e53-a825-38fcbe2db02b@github.com>

On Mon, 21 Nov 2022 17:32:04 GMT, zzambers <duke at openjdk.org> wrote:

>> Following test (from hotspot/tier1) currently fails on Windows x86:
>> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
>> 
>> **Test output:**
>> 
>> ...
>>  stdout: [];
>>  stderr: [openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
>> OpenJDK Server VM (build 25.362-b00, mixed mode)
>> ]
>>  exitValue = 0
>> 
>> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
>> 
>> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
>> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ...
>> 
>> 
>> **Problem:**
>> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
>> 
>> **Fix:**
>> Test runs java with `-version` argument, which can print something similar to:
>> 
>> openjdk version "1.8.0_362-internal"
>> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
>> OpenJDK Client VM (build 25.362-b00, mixed mode)
>> 
>> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
>> 
>> **Testing:**
>> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
>> 
>> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
>> [2] https://bugs.openjdk.org/browse/JDK-8154204
>> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
>> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed detection of client VM

Looks fine to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From sgehwolf at openjdk.org  Tue Nov 22 11:45:25 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 22 Nov 2022 11:45:25 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows [v2]
In-Reply-To: <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
Message-ID: <Pz65mBPxrKIWjCaqVvNqMFYIsj1sgUbie6UaqvKHWtk=.fabb9efa-3dba-4566-aad6-c6e20d6d05cb@github.com>

On Mon, 21 Nov 2022 18:02:09 GMT, zzambers <duke at openjdk.org> wrote:

>> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed detection for 64-bit JVM

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From duke at openjdk.org  Tue Nov 22 14:35:14 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 22 Nov 2022 14:35:14 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows [v2]
In-Reply-To: <Pz65mBPxrKIWjCaqVvNqMFYIsj1sgUbie6UaqvKHWtk=.fabb9efa-3dba-4566-aad6-c6e20d6d05cb@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
 <Pz65mBPxrKIWjCaqVvNqMFYIsj1sgUbie6UaqvKHWtk=.fabb9efa-3dba-4566-aad6-c6e20d6d05cb@github.com>
Message-ID: <aYuR3ZPEmhXgCO2ol4HwXC6rwJErtC6F3axShKCK8ic=.7031e2b2-4b0a-4e3f-a9a5-c674eae806c0@github.com>

On Tue, 22 Nov 2022 11:43:07 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> zzambers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed detection for 64-bit JVM
>
> LGTM.

@jerboaa thanks for the review

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From duke at openjdk.org  Tue Nov 22 14:35:15 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 22 Nov 2022 14:35:15 GMT
Subject: [jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java
 is failing on 32bit Windows [v2]
In-Reply-To: <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
References: <kg3GlSeojbgF791BWPKrlVBvu-Lh-jHJ94M-j-HW5wM=.40f263b4-9cb0-4dd7-9c02-b4af0059452f@github.com>
 <uWj7CVA8MhBjAPgRT-lnAkZqSGmHPsLL2uWB0IACMOE=.6076f379-f79b-4447-82c6-4756163ae342@github.com>
Message-ID: <Akg1lVu7cro1Giw03GX5C2zywR81-UzXdSaPSMmBT84=.39d8c661-f15a-4309-adee-9a8fddc5355c@github.com>

On Mon, 21 Nov 2022 18:02:09 GMT, zzambers <duke at openjdk.org> wrote:

>> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed detection for 64-bit JVM

Oh, it does not yet have jdk8u-fix-yes (will need before sponsor)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182

From duke at openjdk.org  Tue Nov 22 14:39:23 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 22 Nov 2022 14:39:23 GMT
Subject: [jdk8u-dev] RFR: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u [v2]
In-Reply-To: <EV_vEWmtcSEMkaw1_yGx5TwNfjagkPkelIk17-cL3RU=.d7512f79-1f86-4e53-a825-38fcbe2db02b@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
 <8TM8264iXFKLRQPWvT898yfTodcAG27nobgvcfv6DCE=.2f33ea47-78d8-4f78-8251-ca3e200c882c@github.com>
 <EV_vEWmtcSEMkaw1_yGx5TwNfjagkPkelIk17-cL3RU=.d7512f79-1f86-4e53-a825-38fcbe2db02b@github.com>
Message-ID: <c3xro9SesByymUVZToFq3gkMdQ7ohp6BEBw7WSp0K14=.b90ad73f-c97a-4044-aa86-7881eba28d48@github.com>

On Tue, 22 Nov 2022 09:55:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> zzambers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed detection of client VM
>
> Looks fine to me.

@jerboaa Thanks for the review

(but still needs jdk8u-fix-yes)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From duke at openjdk.org  Tue Nov 22 15:27:38 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Tue, 22 Nov 2022 15:27:38 GMT
Subject: [jdk8u-dev] RFR: 8241087: Build failure with VS 2019 (16.5.0) due to
 C2039 and C2873
Message-ID: <XUpOOW2zC4goGr3SqrQTM5NZJLTRy7vKVw0XpSPiMTs=.58ef184d-30eb-472b-81c2-7b798046dd42@github.com>

Hi!

Here is one more backport from MSVS2019 seria. This one fixes build failure in AWT due to C2039 and C2873. The patch from jdk-11 https://github.com/openjdk/jdk11u-dev/commit/7166e13838a545b1e75307defc2cfa173dc38d20 is applied cleanly.

Verification MSVS2019 full build succedded
Regression: MSVS2017 / 2015 (requires `--with-extra-cflags="/wd4005 /wd4091"`) / 2013 / 2012 / 2010 - ok

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/187

Commit messages:
 - Backport 7166e13838a545b1e75307defc2cfa173dc38d20

Changes: https://git.openjdk.org/jdk8u-dev/pull/190/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=190&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8241087
  Stats: 9 lines in 3 files changed: 2 ins; 5 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/190.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/190/head:pull/190

PR: https://git.openjdk.org/jdk8u-dev/pull/190

From phh at openjdk.org  Tue Nov 22 15:42:32 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 22 Nov 2022 15:42:32 GMT
Subject: [jdk8u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails
 with SunCertPathBuilderException
In-Reply-To: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
References: <8yq4gpfHabsQEKOqSC-8BVJh-5GXQQPL965JAenQNcs=.e31bf92c-494b-4ecc-a10e-8a9eb48dcc35@github.com>
Message-ID: <i3mQfpQAkTKaH9LSmH5ZCDtykA0enuaMxF0IS4YHg2A=.5b16615c-f3ea-4dba-b145-59ba91d9827e@github.com>

On Mon, 21 Nov 2022 15:31:36 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> I request the backport for parity with Oracle JDK 8. The patch applies clean after the fix of the copyright year and the import part. This backport is only a test change and fixes the test failure.

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/188

From duke at openjdk.org  Tue Nov 22 15:52:35 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 22 Nov 2022 15:52:35 GMT
Subject: [jdk8u-dev] Integrated: 8297141: Fix
 hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
In-Reply-To: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
References: <Zts4DXweynIdu8EPpvNmwb_tpcktSXnfyz08mkItVIs=.608f4fa5-ba2c-49ac-a666-7441f21e4119@github.com>
Message-ID: <Wm-DCBTfp9BQm6n1ajuEuF35qb6NODwSHJeaQ60L-Zw=.1529ab12-39c8-4564-bc6b-4f9358837718@github.com>

On Wed, 16 Nov 2022 13:55:19 GMT, zzambers <duke at openjdk.org> wrote:

> Following test (from hotspot/tier1) currently fails on Windows x86:
> `hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java`
> 
> **Test output:**
> 
> ...
>  stdout: [];
>  stderr: [openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-54a485c13e59fa68ea9dc088f320520eedbe33fe-b00)
> OpenJDK Server VM (build 25.362-b00, mixed mode)
> ]
>  exitValue = 0
> 
> java.lang.RuntimeException: 'UseSharedSpaces:' missing from stdout/stderr 
> 
> 	at com.oracle.java.testlibrary.OutputAnalyzer.shouldContain(OutputAnalyzer.java:134)
> 	at DefaultUseWithClient.main(DefaultUseWithClient.java:68)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
> 	at java.lang.Thread.run(Thread.java:750)
> ...
> 
> 
> **Problem:**
> Test is Windows 32-bit only, only applies to Client VM and checks default behaviour of shared archive feature. Problem is, that default build of 32-bit windows JDK does not include Client VM, so Server VM is used (so -client arg does nothing). With Server VM tests fails. I tried to make build which has Client VM and then this test passes (It breaks other tests which expect default to be Server VM though).
> 
> **Fix:**
> Test runs java with `-version` argument, which can print something similar to:
> 
> openjdk version "1.8.0_362-internal"
> OpenJDK Runtime Environment (build 1.8.0_362-internal-zzambers-2bbffac3199782df1f9b81867fdfeb3d72889fcd-b00)
> OpenJDK Client VM (build 25.362-b00, mixed mode)
> 
> This output can be used to check if Client VM and skip other checks, if Client VM is not used. Fix is JDK 8 only as test has been removed on newer JDKs by JDK-8154204 by [2]. But I decided to fix it for JDK 8.
> 
> **Testing:**
> With this change test passes on Windows 32-bit. (both with Server [3] and Client [4] Vms)
> 
> [1] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844
> [2] https://bugs.openjdk.org/browse/JDK-8154204
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3462926725
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3462887672

This pull request has now been integrated.

Changeset: 5a32484f
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5a32484f0f3be91ccaef76271361ef2fbfdf7558
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/181

From omikhaltcova at openjdk.org  Tue Nov 22 16:13:35 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Tue, 22 Nov 2022 16:13:35 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <n4AMOGy4aqqHjIJurj8W9sGP52eF7Q6umqtjk1e4uSU=.2b7f57e9-5147-4a7c-a2b0-13cced50e0bf@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
> - `git rebase -i HEAD~3` (squash commits)

I meant not that but the following:

jdk8u-dev-fork % git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b
[master 9957f9f8aef] Revert "8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0"
 1 file changed, 18 insertions(+), 13 deletions(-)

jdk8u-dev-fork % git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d
Fetching ...
Cherry picking ...
CONFLICT (modify/delete): src/java.base/macosx/native/libjava/java_props_macosx.c deleted in HEAD and modified in d4c7db50609 (8257620: Do not use objc_msgSend_stret to get macOS version). Version d4c7db50609 (8257620: Do not use objc_msgSend_stret to get macOS version) of src/java.base/macosx/native/libjava/java_props_macosx.c left in tree.
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 66423 and retry the command.
error: could not apply d4c7db50609... 8257620: Do not use objc_msgSend_stret to get macOS version
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'

It seems it's impossible to apply this patch following the way in this description.
I get conflicts because of the location difference of the patched file `java_props_macosx.c`:
JDK: `./src/java.base/macosx/native/libjava/java_props_macosx.c`
JDK8: `./jdk/src/solaris/native/java/lang/java_props_macosx.c`
So it seems to me you needn't blackout JDK-8269850 because the diffs (JDK-8269850 and JDK-8257620) are not intersected and additionally you have to resolve conflicts manually (or to apply patch manually) any way.
Am I right? Or I understand something wrong?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From btaylor at openjdk.org  Tue Nov 22 17:21:36 2022
From: btaylor at openjdk.org (Ben Taylor)
Date: Tue, 22 Nov 2022 17:21:36 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <1lZMSGGWTr5ZOA8URldfde2vxmb1FBAJ7j2ddSDvVLs=.f197e9e1-379e-417b-8541-b5f4d0cd67fd@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
> - `git rebase -i HEAD~3` (squash commits)

I think the reason your backport was unclean is related to these 2 lines:

warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 66423 and retry the command.

I believe if you follow the instructions in the warning and raise the rename limit, inexact rename detection will find the correct file and no manual resolution will be required - that's what happened for me, at least.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From duke at openjdk.org  Tue Nov 22 18:01:16 2022
From: duke at openjdk.org (Dan Lutker)
Date: Tue, 22 Nov 2022 18:01:16 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
Message-ID: <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>

> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.

Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Fix copyright
 - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/186/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/186/files/6d7e325a..3c86d09b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=186&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=186&range=00-01

  Stats: 11 lines in 4 files changed: 4 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/186.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/186/head:pull/186

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From duke at openjdk.org  Tue Nov 22 18:01:17 2022
From: duke at openjdk.org (Dan Lutker)
Date: Tue, 22 Nov 2022 18:01:17 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <Rsh43ddlvssDlCfHOK7MS6o7y-YJMIHCyIUJFiXUO7Q=.a292f9db-c2a8-4cc5-a987-916e5859bed6@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <Rsh43ddlvssDlCfHOK7MS6o7y-YJMIHCyIUJFiXUO7Q=.a292f9db-c2a8-4cc5-a987-916e5859bed6@github.com>
Message-ID: <btc-dTi5H5Cy_efWtk-Xe6HJxONg5lfL5-S1WK_HNzA=.de90bef9-4051-42c0-b15c-7116c5f3f85e@github.com>

On Mon, 21 Nov 2022 21:31:43 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> The copyright line in TestMemoryAwareness and DockerRunOptions.java should be
> 
>     * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.

Thanks, fixed!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From omikhaltcova at openjdk.org  Tue Nov 22 18:03:24 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Tue, 22 Nov 2022 18:03:24 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
Message-ID: <daxYAA9OYs33p7YcU0J4YoZztZ_Bf8kifc5MWV1zHHk=.3f2ef08d-af87-4d6a-9f58-94854784f6c5@github.com>

On Tue, 1 Nov 2022 20:44:38 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
> 
> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
> 
> Change applied with:
> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
> - `git rebase -i HEAD~3` (squash commits)

Marked as reviewed by omikhaltcova (no project role).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From omikhaltcova at openjdk.org  Tue Nov 22 18:03:25 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Tue, 22 Nov 2022 18:03:25 GMT
Subject: [jdk8u-dev] RFR: 8257620: Do not use objc_msgSend_stret to get
 macOS version
In-Reply-To: <1lZMSGGWTr5ZOA8URldfde2vxmb1FBAJ7j2ddSDvVLs=.f197e9e1-379e-417b-8541-b5f4d0cd67fd@github.com>
References: <cjRS81boNVTfCzZvx-S_027js6Z9NHwLuAQvfUC1OGk=.aeb40b34-74c8-45c3-91ee-472c1bfef4ca@github.com>
 <1lZMSGGWTr5ZOA8URldfde2vxmb1FBAJ7j2ddSDvVLs=.f197e9e1-379e-417b-8541-b5f4d0cd67fd@github.com>
Message-ID: <0El72C4gaKXhRoxk2Ga8GVyZJTAsIz7yt8hXtq1N_Ro=.e393cfdb-ee42-4c24-86f1-539385bc658e@github.com>

On Tue, 22 Nov 2022 17:18:56 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

>> This backports [JDK-8257620](https://bugs.openjdk.org/browse/JDK-8257620) for parity with Oracle JDK8 and OpenJDK 11+. 
>> 
>> The backport is not clean because [JDK-8269850](https://bugs.openjdk.org/browse/JDK-8269850) was applied first in 8u. If that change is backed out and reapplied after this backport, both are clean.
>> 
>> Change applied with:
>> - `git revert 43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b` (backout JDK-8269850)
>> - `git backport --from https://github.com/openjdk/jdk d4c7db5060978302382549246f9ad6831f19377d` (apply JDK-8257620)
>> - `git backport --from https://github.com/openjdk/jdk 3b1b8fc646493eae5f4df828afe29abb75fa5e60` (re-apply JDK-8269850)
>> - `git rebase -i HEAD~3` (squash commits)
>
> I think the reason your backport was unclean is related to these 2 lines:
> 
> warning: inexact rename detection was skipped due to too many files.
> warning: you may want to set your merge.renamelimit variable to at least 66423 and retry the command.
> 
> I believe if you follow the instructions in the warning and raise the rename limit, inexact rename detection will find the correct file and no manual resolution will be required - that's what happened for me, at least.

@benty-amzn Thanks for this tip!
`git config merge.renameLimit 70000` really helps to avoid manual resolving.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/153

From phh at openjdk.org  Tue Nov 22 18:04:47 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 22 Nov 2022 18:04:47 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
Message-ID: <A0FnCp_NnhNvdTY6pQoyftOnNrTF0mP3uycFuZn7Dgg=.e6550e03-d98a-417a-96f8-35cb3411b44e@github.com>

On Tue, 22 Nov 2022 18:01:16 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.
>
> Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Fix copyright
>  - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From duke at openjdk.org  Wed Nov 23 00:07:38 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 23 Nov 2022 00:07:38 GMT
Subject: [jdk8u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also
 on x86
Message-ID: <tA2t6MeeJUTzjggQ6InGf95NkmyEj8MyfgYVjIKtm6U=.29c92380-a676-4cfe-b8d6-f51e78cb0555@github.com>

Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected.

-------------

Commit messages:
 - Backport 3f2f128af6ec2f9097af7758bfd41aeaa4354d40

Changes: https://git.openjdk.org/jdk8u-dev/pull/191/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=191&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295952
  Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/191.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/191/head:pull/191

PR: https://git.openjdk.org/jdk8u-dev/pull/191

From duke at openjdk.org  Wed Nov 23 00:33:23 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 23 Nov 2022 00:33:23 GMT
Subject: [jdk8u-dev] RFR: 8226236: win32:
 gc/metaspace/TestCapacityUntilGCWrapAround.java fails
Message-ID: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>

Following tests from hotspot/tier1 currently fails on Windows x86:
`gc/metaspace/TestCapacityUntilGCWrapAround.java` 

This backport fixes that failure.

Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 

Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).

[1] https://github.com/openjdk/jdk/commit/038f58d4
[2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
[3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
[4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225

-------------

Commit messages:
 - Backport 038f58d4f0782f885547d2b052a47fdf2229cfe3

Changes: https://git.openjdk.org/jdk8u-dev/pull/192/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=192&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8226236
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/192.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/192/head:pull/192

PR: https://git.openjdk.org/jdk8u-dev/pull/192

From sgehwolf at openjdk.org  Wed Nov 23 09:31:32 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 23 Nov 2022 09:31:32 GMT
Subject: [jdk8u-dev] RFR: 8226236: win32:
 gc/metaspace/TestCapacityUntilGCWrapAround.java fails
In-Reply-To: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
References: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
Message-ID: <-q3ljwDSRb8ZVGhlOppB3-WwWGwm2E5fNW3vO1Tss5Q=.69153f63-2f29-456d-be75-f892b2c5ccb5@github.com>

On Wed, 23 Nov 2022 00:25:55 GMT, zzambers <duke at openjdk.org> wrote:

> Following tests from hotspot/tier1 currently fails on Windows x86:
> `gc/metaspace/TestCapacityUntilGCWrapAround.java` 
> 
> This backport fixes that failure.
> 
> Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 
> 
> Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).
> 
> [1] https://github.com/openjdk/jdk/commit/038f58d4
> [2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225

This needs to go into OpenJDK 11u first. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/192

From aph at openjdk.org  Wed Nov 23 10:23:32 2022
From: aph at openjdk.org (Andrew Haley)
Date: Wed, 23 Nov 2022 10:23:32 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <fIKuQI8af_xHB4F3zmweMZHT9ozQFKXa0L36rhJMI5I=.27309dcc-97b1-4842-a3c5-ae020d3c2515@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

This is scary stuff. Clearly it isn't a backwards-compatible change. I guess the way this works is that JARs timestamped prior to January 01, 2019 are accepted, but only until the signing certificate expires. Right?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From sgehwolf at openjdk.org  Wed Nov 23 10:45:33 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 23 Nov 2022 10:45:33 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <a-aET0Up4txHdVtBmOC-UO7M3MKhLLJXQ87OprR6z3U=.5f81908b-e899-49f6-87f7-4cfad5204717@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

The [crypto roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html) mentions it's been included in Oracle JDK 8u351 (October 2022 CPU). While not 100% backwards compatible it's the *default* that is changing, right? So we should have it in OpenJDK 8u too and the [CSR mentions](https://bugs.openjdk.org/browse/JDK-8264362) it can be worked around by modifying `java.security` file. Is my understanding correct?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From duke at openjdk.org  Wed Nov 23 11:09:37 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 23 Nov 2022 11:09:37 GMT
Subject: [jdk8u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll
Message-ID: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>

Hi!

Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch from 11u is applied with the following changes:

- make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
- make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
- make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
- make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
- make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
- make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
- make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
- make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`

Verification: MSVS2019 32/64-bit builds populate vcrunt~1.dll  and vcrunt~2.dll to JRE images, these are vcruntime140.dll and vcruntime140_1.dll accordingly (in jdk8 the make script renames the DLL's to avoid 8.3 conflict)
Regression: MSVS2017 builds populate only vcrunt~1.dll

Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR, and that is why I do not commit common/autoconf/generated-configure.sh here

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/190

Commit messages:
 - Backport 2548ed31aeb255a61644885c501667a74f90ebc7

Changes: https://git.openjdk.org/jdk8u-dev/pull/193/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8242468
  Stats: 62 lines in 7 files changed: 58 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/193.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/193/head:pull/193

PR: https://git.openjdk.org/jdk8u-dev/pull/193

From abakhtin at openjdk.org  Wed Nov 23 11:17:39 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 23 Nov 2022 11:17:39 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <_5-ueNCQWdQXaDnlDUMOuOhmyq1Vyd3ZrSH_gtt4tBU=.4025b5f3-6654-44b7-bdb1-2f1776dc3cd6@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

Right, it can be easily workarounded by removing SHA1 restriction from java.security file

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From duke at openjdk.org  Wed Nov 23 11:19:32 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Wed, 23 Nov 2022 11:19:32 GMT
Subject: [jdk8u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll
 [v2]
In-Reply-To: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
References: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
Message-ID: <YzqqiSoJNZ8fbWiNL91MaHqAy7S1PbnAsfi-WzdKRw4=.9e557883-f149-4e9a-bb95-b4d2db4ee0eb@github.com>

> Hi!
> 
> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch from 11u is applied with the following changes:
> 
> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
> 
> Verification: MSVS2019 32/64-bit builds populate vcrunt~1.dll  and vcrunt~2.dll to JRE images, these are vcruntime140.dll and vcruntime140_1.dll accordingly (in jdk8 the make script renames the DLL's to avoid 8.3 conflict)
> Regression: MSVS2017 builds populate only vcrunt~1.dll
> 
> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR, and that is why I do not commit common/autoconf/generated-configure.sh here

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  populating generated-configure.sh

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/193/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/193/files/d64fe1bf..f471ed99

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=00-01

  Stats: 1442 lines in 1 file changed: 1417 ins; 0 del; 25 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/193.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/193/head:pull/193

PR: https://git.openjdk.org/jdk8u-dev/pull/193

From sgehwolf at openjdk.org  Wed Nov 23 13:52:31 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 23 Nov 2022 13:52:31 GMT
Subject: [jdk8u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests
 also on x86
In-Reply-To: <tA2t6MeeJUTzjggQ6InGf95NkmyEj8MyfgYVjIKtm6U=.29c92380-a676-4cfe-b8d6-f51e78cb0555@github.com>
References: <tA2t6MeeJUTzjggQ6InGf95NkmyEj8MyfgYVjIKtm6U=.29c92380-a676-4cfe-b8d6-f51e78cb0555@github.com>
Message-ID: <7FeqnYNw5ycLcWlE58NFyOVQxkUrkbNBajUYbV7jTic=.651e645e-3448-4d70-8e0d-d62b38f6dc72@github.com>

On Wed, 23 Nov 2022 00:00:07 GMT, zzambers <duke at openjdk.org> wrote:

> Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected.

Clean patch modulo context changes.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/191

From abakhtin at openjdk.org  Wed Nov 23 13:52:30 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 23 Nov 2022 13:52:30 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <fIKuQI8af_xHB4F3zmweMZHT9ozQFKXa0L36rhJMI5I=.27309dcc-97b1-4842-a3c5-ae020d3c2515@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
 <fIKuQI8af_xHB4F3zmweMZHT9ozQFKXa0L36rhJMI5I=.27309dcc-97b1-4842-a3c5-ae020d3c2515@github.com>
Message-ID: <B3yQoqkrR3b-uOMX-KL_WPlNWNxIWISigKlXKSNqrG8=.6308af87-7171-4210-9aac-360584760af9@github.com>

On Wed, 23 Nov 2022 10:21:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

> This is scary stuff. Clearly it isn't a backwards-compatible change. I guess the way this works is that JARs timestamped prior to January 01, 2019 are accepted, but only until the signing certificate expires. Right?

The behavior of the SHA-1 signed certificates before January 01, 2019 is not changed. They are still valid even if the signer certificate expires. The changes apply to JARs signed after January 01, 2019

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From sgehwolf at openjdk.org  Wed Nov 23 14:00:55 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 23 Nov 2022 14:00:55 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
Message-ID: <D3pSCP3dTvEYVO1_bSXjsG9JpZssFQnwq_LG-TXHQAY=.909c5835-a73f-4fc5-9298-470d5019a1d8@github.com>

On Tue, 22 Nov 2022 18:01:16 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.
>
> Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Fix copyright
>  - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

This seems fine, but could this wait until after 8u-dev forks to 8u372 (probably next week) and we integrate the cg v2 backports as this conflicts with the patch set?

Note, the work-around seems to be to add `cgroup_enable=memory swapaccount=1` to the kernel command line on the test host.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From mbalao at openjdk.org  Wed Nov 23 14:13:42 2022
From: mbalao at openjdk.org (Martin Balao)
Date: Wed, 23 Nov 2022 14:13:42 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <2rYZDGBw-R-PYlouVh_BB4hyMIEpH-AbO9JwEEvQosM=.0a60a5f8-5f0e-4a6d-9b25-935df4b93857@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

Notice that for the 2019-01-01 max date to work, the JAR has to be timestamped by a TSA (Time Stamp Authority).

While the default behavior is changed (there is a [CSR attached to this bug](https://bugs.openjdk.org/browse/JDK-8272155) that has to be proposed for 8u as I commented before), the user can restore backward compatibility by re-enabling the use of the SHA-1 algorithm without conditions for JAR signing. You can verify how this works in the fix for [this test](https://github.com/openjdk/jdk8u-dev/pull/154/commits/57d0b0ba5a93c5ca2a88b2d8abc7f6f24a56a853). Also, the Release Note attached to this bug indicates how to [restore backward compatibility](https://bugs.openjdk.org/browse/JDK-8274081).

These crypto changes are part of the [crypto roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html) as @jerboaa  mentioned. I think it's good to be aligned on that roadmap for parity with other JDKs and for security. The change has been backported to other JDK releases too, such as 11u. While I understand the concerns discussed here, I think that we have countermeasures to mitigate that and my recommendation to 8u maintainers is to approve this change.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Wed Nov 23 15:20:20 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 23 Nov 2022 15:20:20 GMT
Subject: [jdk8u-dev] Integrated: 8269039: Disable SHA-1 Signed JARs
In-Reply-To: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
Message-ID: <hKu9p24-Ft_TRnKOT76V2CtKta_NNdYV6X8PUxuRw8E=.02b5d127-c222-46f4-bb6d-1c325c49fab7@github.com>

On Thu, 3 Nov 2022 15:34:01 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
> 
> The patch is based on the OpenJDK11 backport [2]
> 
> The changes are the following:
> 
> 1. java.security.* files are changed on the base of java.security
> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
> 
> All java/security/Security sun/security/tools regression tests passed
> 
> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8

This pull request has now been integrated.

Changeset: c501bfaa
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c501bfaa5fc2502942b228c907372dccd58c4a20
Stats:     657 lines in 29 files changed: 315 ins; 215 del; 127 mod

8269039: Disable SHA-1 Signed JARs

Reviewed-by: mbalao
Backport-of: 6d91a3eb7bd1e1403cfb67f7eb8ce06d7e08e7a7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From andrew at openjdk.org  Fri Nov 25 03:51:26 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 25 Nov 2022 03:51:26 GMT
Subject: [jdk8u-dev] RFR: 6885993: Named Thread: introduce print() and
 print_on(outputStream* st) methods
In-Reply-To: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
References: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
Message-ID: <_OJAaLsIDvcQPZNYzsPX45Naky_JuB0HYj80AjaevxI=.3e8bbd50-128f-4195-9ed9-7019ea16f37b@github.com>

On Thu, 17 Nov 2022 10:06:12 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)". I request the downport for parity with Oracle JDK 8 where it was backported to 8u351 (see [JDK-8285702](https://bugs.openjdk.org/browse/JDK-8285702)). The change is required as dependency of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I'll be requesting next ([JDK-8073464](https://bugs.openjdk.org/browse/JDK-8073464) has also been downported to Oracle jdk8u351).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for a single context mismatch in `vmThread.cpp`. I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [6885993-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030290/6885993-jdk8-vs-jdk9.txt)).

Looks good to me.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/183

From andrew at openjdk.org  Fri Nov 25 03:57:10 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 25 Nov 2022 03:57:10 GMT
Subject: [jdk8u-dev] RFR: 8073464: GC workers do not have thread names
In-Reply-To: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
References: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
Message-ID: <fPwGbLnc2Vyws8M39d4WVfqvolEmWxSIk_FwLUSDhXI=.c97096b9-4c7e-4765-babf-0ec398e02ee9@github.com>

On Thu, 17 Nov 2022 10:32:59 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see [JDK-8285732](https://bugs.openjdk.org/browse/JDK-8285732)). This downport depends on "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)" for which a [pull request already exists](https://github.com/openjdk/jdk8u-dev/pull/183).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for two copyright year mismatches in `concurrentGCThread.cpp` and `thread.hpp`.   I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [8073464-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030509/8073464-jdk8-vs-jdk9.txt))

Looks good to me.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/184

From volker.simonis at gmail.com  Fri Nov 25 10:52:58 2022
From: volker.simonis at gmail.com (Volker Simonis)
Date: Fri, 25 Nov 2022 11:52:58 +0100
Subject: Problems with GitHub/Skara/JBS/8u-dev integrations?
Message-ID: <CA+3eh11cRTX-rywZyfRonW7r08vN+HXHcQAyFiL+mK+0QZma6g@mail.gmail.com>

Hi,

I've tried to "/integrate" an approved backport to
https://github.com/openjdk/jdk8u-dev but after more than two hours
still nothing happened. Are there any known problems with
GitHub/Skara/JBS or the specific 8u-dev repo. Usually integrations
happen within minutes.

Is there any way to monitor whats going on behind the scenes (i.e.
what the Skara bots are doing)?

Thank you and best regards,
Volker

PS: my PR is https://github.com/openjdk/jdk8u-dev/pull/183

From volker.simonis at gmail.com  Fri Nov 25 10:57:07 2022
From: volker.simonis at gmail.com (Volker Simonis)
Date: Fri, 25 Nov 2022 11:57:07 +0100
Subject: Problems with GitHub/Skara/JBS/8u-dev integrations?
In-Reply-To: <CA+3eh11cRTX-rywZyfRonW7r08vN+HXHcQAyFiL+mK+0QZma6g@mail.gmail.com>
References: <CA+3eh11cRTX-rywZyfRonW7r08vN+HXHcQAyFiL+mK+0QZma6g@mail.gmail.com>
Message-ID: <CA+3eh13MhG_BbPTgm=NiK=eb5urMQym-WF9MkzNfVrPdKp00YA@mail.gmail.com>

Wow, it seems like this mail has helped.
Once I sent it out, my PR was integrated immediately :)
Looks like the system was just overloaded.

So the only remaining questions is if there's a way to monitor whats
going on behind the scenes (i.e. what the Skara bots are doing) if
this happens again in the future?

Regards,
Volker

On Fri, Nov 25, 2022 at 11:52 AM Volker Simonis
<volker.simonis at gmail.com> wrote:
>
> Hi,
>
> I've tried to "/integrate" an approved backport to
> https://github.com/openjdk/jdk8u-dev but after more than two hours
> still nothing happened. Are there any known problems with
> GitHub/Skara/JBS or the specific 8u-dev repo. Usually integrations
> happen within minutes.
>
> Is there any way to monitor whats going on behind the scenes (i.e.
> what the Skara bots are doing)?
>
> Thank you and best regards,
> Volker
>
> PS: my PR is https://github.com/openjdk/jdk8u-dev/pull/183

From simonis at openjdk.org  Fri Nov 25 11:08:38 2022
From: simonis at openjdk.org (Volker Simonis)
Date: Fri, 25 Nov 2022 11:08:38 GMT
Subject: [jdk8u-dev] Integrated: 6885993: Named Thread: introduce print() and
 print_on(outputStream* st) methods
In-Reply-To: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
References: <bHC5IHTCua5oAGyNbwdb_4-u7AXqn5wGge2avHiwm10=.102d3269-bf4e-405f-8f10-af437605732d@github.com>
Message-ID: <DnRkFNrUJ5r2ME83_-jyf3TLd9WiZ_1G-TofjWeyKII=.c6f713df-67f5-4157-ac42-cdee26dafabc@github.com>

On Thu, 17 Nov 2022 10:06:12 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)". I request the downport for parity with Oracle JDK 8 where it was backported to 8u351 (see [JDK-8285702](https://bugs.openjdk.org/browse/JDK-8285702)). The change is required as dependency of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I'll be requesting next ([JDK-8073464](https://bugs.openjdk.org/browse/JDK-8073464) has also been downported to Oracle jdk8u351).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for a single context mismatch in `vmThread.cpp`. I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [6885993-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030290/6885993-jdk8-vs-jdk9.txt)).

This pull request has now been integrated.

Changeset: 9f2f0c22
Author:    Volker Simonis <simonis at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/9f2f0c220b44d0693dc05c915fe62e824bceaddf
Stats:     75 lines in 14 files changed: 13 ins; 61 del; 1 mod

6885993: Named Thread: introduce print() and print_on(outputStream* st) methods

Eliminating duplicated code by introducing print_on(outputStream* st) methods in NamedThread

Reviewed-by: phh, andrew
Backport-of: 16a3e2f16d3ffc4dd66e93aa9d75055279499282

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/183

From serb at openjdk.org  Fri Nov 25 11:09:31 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 25 Nov 2022 11:09:31 GMT
Subject: [jdk8u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents
 large memory allocation
Message-ID: <SgGzFGkk2MJraD92GsJg8KkX9QSHl3BvFbOStFbNsgE=.c21d4fe6-6123-47e7-9fea-27500e758257@github.com>

Hi all,
This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev.
Thanks!

-------------

Commit messages:
 - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86

Changes: https://git.openjdk.org/jdk8u-dev/pull/194/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=194&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296496
  Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/194.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/194/head:pull/194

PR: https://git.openjdk.org/jdk8u-dev/pull/194

From simonis at openjdk.org  Fri Nov 25 11:23:05 2022
From: simonis at openjdk.org (Volker Simonis)
Date: Fri, 25 Nov 2022 11:23:05 GMT
Subject: [jdk8u-dev] RFR: 8073464: GC workers do not have thread names [v2]
In-Reply-To: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
References: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
Message-ID: <Bvk53U6rL-h8Cevbc6-8E0SBy_t4yoREpwSv-yW6hpM=.06fa6983-a9c1-4783-9071-d8476c63abee@github.com>

> This is a backport of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see [JDK-8285732](https://bugs.openjdk.org/browse/JDK-8285732)). This downport depends on "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)" for which a [pull request already exists](https://github.com/openjdk/jdk8u-dev/pull/183).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for two copyright year mismatches in `concurrentGCThread.cpp` and `thread.hpp`.   I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [8073464-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030509/8073464-jdk8-vs-jdk9.txt))

Volker Simonis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/184/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/184/files/8b4a0541..8b4a0541

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=184&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=184&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/184.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/184/head:pull/184

PR: https://git.openjdk.org/jdk8u-dev/pull/184

From simonis at openjdk.org  Fri Nov 25 11:53:36 2022
From: simonis at openjdk.org (Volker Simonis)
Date: Fri, 25 Nov 2022 11:53:36 GMT
Subject: [jdk8u-dev] Integrated: 8073464: GC workers do not have thread names
In-Reply-To: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
References: <rrWJdNkrChVmPVwa-DMMMZ8JcDxS7VOtZhaEucgMuu8=.fb8886f7-ce26-4e2e-9fbd-f9ef9e722c01@github.com>
Message-ID: <Eusr_XjspGXlUy8PCcbHqjC3lPGzIN-Y4OzcudavoTk=.8ea630d5-da11-4b32-a705-87f1891523d1@github.com>

On Thu, 17 Nov 2022 10:32:59 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> This is a backport of "[JDK-8073464: GC workers do not have thread names](https://bugs.openjdk.org/browse/JDK-8073464)" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see [JDK-8285732](https://bugs.openjdk.org/browse/JDK-8285732)). This downport depends on "[JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods](https://bugs.openjdk.org/browse/JDK-6885993)" for which a [pull request already exists](https://github.com/openjdk/jdk8u-dev/pull/183).
> 
> Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "[InternalThreadCpuTimes](https://stackoverflow.com/questions/3947467/with-recent-sun-jvms-1-6-is-it-possible-to-get-gc-thread-information/4113407#4113407)". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").
> 
> The patch applies cleanly except for two copyright year mismatches in `concurrentGCThread.cpp` and `thread.hpp`.   I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see [8073464-jdk8-vs-jdk9.txt](https://github.com/openjdk/jdk8u-dev/files/10030509/8073464-jdk8-vs-jdk9.txt))

This pull request has now been integrated.

Changeset: df44cbff
Author:    Volker Simonis <simonis at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/df44cbff663e6415ff75a5cf1a59d9836961ef27
Stats:     16 lines in 7 files changed: 8 ins; 2 del; 6 mod

8073464: GC workers do not have thread names

Reviewed-by: phh, andrew
Backport-of: a827cdfa1047ee0af30bb454aad2067420103bae

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/184

From andrew at openjdk.org  Fri Nov 25 16:27:28 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 25 Nov 2022 16:27:28 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <2rYZDGBw-R-PYlouVh_BB4hyMIEpH-AbO9JwEEvQosM=.0a60a5f8-5f0e-4a6d-9b25-935df4b93857@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
 <2rYZDGBw-R-PYlouVh_BB4hyMIEpH-AbO9JwEEvQosM=.0a60a5f8-5f0e-4a6d-9b25-935df4b93857@github.com>
Message-ID: <gtOgiMt6-AcqdpXrCJj2i8ZkfvcRBbAImpSM-ke61Xs=.79896231-0deb-41c1-82df-1cd5807d0f6c@github.com>

On Wed, 23 Nov 2022 14:11:42 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Notice that for the 2019-01-01 max date to work, the JAR has to be timestamped by a TSA (Time Stamp Authority).
> 
> While the default behavior is changed (there is a [CSR attached to this bug](https://bugs.openjdk.org/browse/JDK-8272155) that has to be proposed for 8u as I commented before), the user can restore backward compatibility by re-enabling the use of the SHA-1 algorithm without conditions for JAR signing. You can verify how this works in the fix for [this test](https://github.com/openjdk/jdk8u-dev/pull/154/commits/57d0b0ba5a93c5ca2a88b2d8abc7f6f24a56a853). Also, the Release Note attached to this bug indicates how to [restore backward compatibility](https://bugs.openjdk.org/browse/JDK-8274081).
> 
> These crypto changes are part of the [crypto roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html) as @jerboaa mentioned. I think it's good to be aligned on that roadmap for parity with other JDKs and for security. The change has been backported to other JDK releases too, such as 11u. While I understand the concerns discussed here, I think that we have countermeasures to mitigate that and my recommendation to 8u maintainers is to approve this change.

I agree it needs to be done, but I think, at this stage, it should have been delayed to 8u372. There are follow-on issues for this - e.g. https://bugs.openjdk.org/browse/JDK-8275887 - which will  now have to be resolved during rampdown.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From andrew at openjdk.org  Fri Nov 25 16:36:58 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 25 Nov 2022 16:36:58 GMT
Subject: [jdk8u-dev] RFR: 8255559: Leak File Descriptors Because of
 ResolverLocalFilesystem#engineResolveURI()
In-Reply-To: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
References: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
Message-ID: <neRR0TIU77dNQPPgfFEbdnpG3uzpc4l5WPAiUb6uDE4=.3130b852-4b60-49f6-8a18-12cb8b9a7fb0@github.com>

On Wed, 9 Nov 2022 15:52:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Clean backport from 11u which fixes a resource leak.
> 
> Although the indentation changes in the diff make it a little unclear, the only change is to wrap the block in a `try-finally` clause (more visible with `git diff -b`)

I see `jdk8u-fix-yes`

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/165

From andrew at openjdk.org  Fri Nov 25 16:36:59 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 25 Nov 2022 16:36:59 GMT
Subject: [jdk8u-dev] Integrated: 8255559: Leak File Descriptors Because of
 ResolverLocalFilesystem#engineResolveURI()
In-Reply-To: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
References: <Wa81dt4sXjIIcfCJD2ahsxShM8U0UAJHTzadoNACQyQ=.4a883ac8-f5a3-4bef-a6b5-61eca4c33d6c@github.com>
Message-ID: <bGQ1My6s69Z7p8ddpAxEur9CQeslVvaaF9Sh2SdIoO0=.e2bb9637-9b21-45b7-8801-2f8a8a3f199e@github.com>

On Wed, 9 Nov 2022 15:52:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Clean backport from 11u which fixes a resource leak.
> 
> Although the indentation changes in the diff make it a little unclear, the only change is to wrap the block in a `try-finally` clause (more visible with `git diff -b`)

This pull request has now been integrated.

Changeset: 41159a51
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/41159a51b418405e634aa08deed07d47611af37f
Stats:     44 lines in 1 file changed: 17 ins; 11 del; 16 mod

8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()

Backport-of: d53072236c503295b893efa6372c869ac84fa688

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/165

From sgehwolf at openjdk.org  Fri Nov 25 16:47:20 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 25 Nov 2022 16:47:20 GMT
Subject: [jdk8u-dev] RFR: 8226236: win32:
 gc/metaspace/TestCapacityUntilGCWrapAround.java fails
In-Reply-To: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
References: <RpujPbCIVt-QHe89s8lK0a5YpfCx545LNPjQLb3aTVk=.52ff5adc-8cbd-4d6c-8129-8d313694c856@github.com>
Message-ID: <GT8ox0RRB00IkYWboYC3ffzcNu2IwtSOVo4G9bcbnw4=.40bd7a3b-2920-4895-9f02-63de9b5aaae9@github.com>

On Wed, 23 Nov 2022 00:25:55 GMT, zzambers <duke at openjdk.org> wrote:

> Following tests from hotspot/tier1 currently fails on Windows x86:
> `gc/metaspace/TestCapacityUntilGCWrapAround.java` 
> 
> This backport fixes that failure.
> 
> Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 
> 
> Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).
> 
> [1] https://github.com/openjdk/jdk/commit/038f58d4
> [2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225

This looks clean to me (only path changes).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/192

From david.holmes at oracle.com  Mon Nov 28 00:36:29 2022
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 28 Nov 2022 10:36:29 +1000
Subject: Problems with GitHub/Skara/JBS/8u-dev integrations?
In-Reply-To: <CA+3eh13MhG_BbPTgm=NiK=eb5urMQym-WF9MkzNfVrPdKp00YA@mail.gmail.com>
References: <CA+3eh11cRTX-rywZyfRonW7r08vN+HXHcQAyFiL+mK+0QZma6g@mail.gmail.com>
 <CA+3eh13MhG_BbPTgm=NiK=eb5urMQym-WF9MkzNfVrPdKp00YA@mail.gmail.com>
Message-ID: <1165759e-961f-3038-12e7-3834d9c424c9@oracle.com>

Hi Volker,

On 25/11/2022 8:57 pm, Volker Simonis wrote:
> Wow, it seems like this mail has helped.
> Once I sent it out, my PR was integrated immediately :)
> Looks like the system was just overloaded.

There was a JBS maintenance window around that time which could have 
impacted the bots ability to update the issue prior to integration.

> So the only remaining questions is if there's a way to monitor whats
> going on behind the scenes (i.e. what the Skara bots are doing) if
> this happens again in the future?

Perhaps ask on skara-dev at openjdk.org.

Cheers,
David

> Regards,
> Volker
> 
> On Fri, Nov 25, 2022 at 11:52 AM Volker Simonis
> <volker.simonis at gmail.com> wrote:
>>
>> Hi,
>>
>> I've tried to "/integrate" an approved backport to
>> https://github.com/openjdk/jdk8u-dev but after more than two hours
>> still nothing happened. Are there any known problems with
>> GitHub/Skara/JBS or the specific 8u-dev repo. Usually integrations
>> happen within minutes.
>>
>> Is there any way to monitor whats going on behind the scenes (i.e.
>> what the Skara bots are doing)?
>>
>> Thank you and best regards,
>> Volker
>>
>> PS: my PR is https://github.com/openjdk/jdk8u-dev/pull/183

From duke at openjdk.org  Mon Nov 28 07:59:23 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 28 Nov 2022 07:59:23 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on 32-bit
 Windows
Message-ID: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>

Hi!

Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing

Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/193

Commit messages:
 - populating generated-configure.sh
 - Backport 78ba1e5a5f69909ddf073cb014784127b09dd47d

Changes: https://git.openjdk.org/jdk8u-dev/pull/195/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=195&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8247676
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/195.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/195/head:pull/195

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From serb at openjdk.org  Mon Nov 28 11:04:44 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 28 Nov 2022 11:04:44 GMT
Subject: [jdk8u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
Message-ID: <RfX6lPy1qDiPOBRJSTBo5jcpRZS7t7BTaBpafYfmjj0=.b20bb399-e5ce-43fd-9cbc-a0b8f8fed508@github.com>

Hi all,
This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov.
Thanks!

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/194

Commit messages:
 - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8

Changes: https://git.openjdk.org/jdk8u-dev/pull/196/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=196&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296957
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/196.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/196/head:pull/196

PR: https://git.openjdk.org/jdk8u-dev/pull/196

From abakhtin at openjdk.org  Mon Nov 28 13:33:24 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 28 Nov 2022 13:33:24 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <gtOgiMt6-AcqdpXrCJj2i8ZkfvcRBbAImpSM-ke61Xs=.79896231-0deb-41c1-82df-1cd5807d0f6c@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
 <2rYZDGBw-R-PYlouVh_BB4hyMIEpH-AbO9JwEEvQosM=.0a60a5f8-5f0e-4a6d-9b25-935df4b93857@github.com>
 <gtOgiMt6-AcqdpXrCJj2i8ZkfvcRBbAImpSM-ke61Xs=.79896231-0deb-41c1-82df-1cd5807d0f6c@github.com>
Message-ID: <QvtT__ihzh8saA0j5zozOqxgv7NRBDJesi2pG0wKLQg=.51f13f69-9242-4a56-994d-eaf0cf5a438c@github.com>

On Fri, 25 Nov 2022 16:24:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Notice that for the 2019-01-01 max date to work, the JAR has to be timestamped by a TSA (Time Stamp Authority).
>> 
>> While the default behavior is changed (there is a [CSR attached to this bug](https://bugs.openjdk.org/browse/JDK-8272155) that has to be proposed for 8u as I commented before), the user can restore backward compatibility by re-enabling the use of the SHA-1 algorithm without conditions for JAR signing. You can verify how this works in the fix for [this test](https://github.com/openjdk/jdk8u-dev/pull/154/commits/57d0b0ba5a93c5ca2a88b2d8abc7f6f24a56a853). Also, the Release Note attached to this bug indicates how to [restore backward compatibility](https://bugs.openjdk.org/browse/JDK-8274081).
>> 
>> These crypto changes are part of the [crypto roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html) as @jerboaa  mentioned. I think it's good to be aligned on that roadmap for parity with other JDKs and for security. The change has been backported to other JDK releases too, such as 11u. While I understand the concerns discussed here, I think that we have countermeasures to mitigate that and my recommendation to 8u maintainers is to approve this change.
>
>> Notice that for the 2019-01-01 max date to work, the JAR has to be timestamped by a TSA (Time Stamp Authority).
>> 
>> While the default behavior is changed (there is a [CSR attached to this bug](https://bugs.openjdk.org/browse/JDK-8272155) that has to be proposed for 8u as I commented before), the user can restore backward compatibility by re-enabling the use of the SHA-1 algorithm without conditions for JAR signing. You can verify how this works in the fix for [this test](https://github.com/openjdk/jdk8u-dev/pull/154/commits/57d0b0ba5a93c5ca2a88b2d8abc7f6f24a56a853). Also, the Release Note attached to this bug indicates how to [restore backward compatibility](https://bugs.openjdk.org/browse/JDK-8274081).
>> 
>> These crypto changes are part of the [crypto roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html) as @jerboaa mentioned. I think it's good to be aligned on that roadmap for parity with other JDKs and for security. The change has been backported to other JDK releases too, such as 11u. While I understand the concerns discussed here, I think that we have countermeasures to mitigate that and my recommendation to 8u maintainers is to approve this change.
> 
> I agree it needs to be done, but I think, at this stage, it should have been delayed to 8u372. There are follow-on issues for this - e.g. https://bugs.openjdk.org/browse/JDK-8275887 - which will  now have to be resolved during rampdown.

@gnu-andrew, Thank you for the comment. I've submitted [PR](https://github.com/openjdk/jdk8u-dev/pull/197 ) for the backport of JDK-8275887

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Mon Nov 28 13:34:58 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 28 Nov 2022 13:34:58 GMT
Subject: [jdk8u-dev] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
Message-ID: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>

Backported as a follow-on issue for JDK-8269039

Based on the JDK11u patch
I had to resolve some merge issues in a few places:
- TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
- ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
- DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398 
- SignerInfo.java - use explicit type instead of var

All corresponding tests passed

-------------

Commit messages:
 - Backport 03f8c0fb9363dc1bb07bed1ae0359c029caa0130

Changes: https://git.openjdk.org/jdk8u-dev/pull/197/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=197&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8275887
  Stats: 125 lines in 9 files changed: 42 ins; 30 del; 53 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/197.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/197/head:pull/197

PR: https://git.openjdk.org/jdk8u-dev/pull/197

From andrew at openjdk.org  Mon Nov 28 15:14:51 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 28 Nov 2022 15:14:51 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
Message-ID: <DK96r5GmwaEneYtM7TZHgfIlh89e55zX8MB4-UCgWiU=.b2393f5e-43be-4b8f-934c-a3c77bfa061a@github.com>

On Thu, 17 Nov 2022 16:06:39 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> I'd like to backport this enhancement for parity with Oracle and the security roadmap [1]
>> 
>> The patch is based on the OpenJDK11 backport [2]
>> 
>> The changes are the following:
>> 
>> 1. java.security.* files are changed on the base of java.security
>> 2. jdk/src/share/classes/sun/security/tools/jarsigner/Main.java : signJar method is merged manually because of differences in the JDK-8172404 backport. 
>> 3. jdk/test/java/security/Security/signedfirst/DynStatic.java : modules dependency removed, changed path to utility classes
>> 4. jdk/test/sun/security/tools/jarsigner/Test4431684.java : changed library path. List.of() is not available in JDK8, so it is replaced with Arrays.asList()
>> 5. jdk/test/lib/security/SecurityUtils.java is updated to make removeFromDisabledAlgs method public. It is required by newly added test Test4431684.java
>> 6. jdk/test/sun/security/tools/jarsigner/DefaultOptions.java is skipped, it was introduced in JDK9 by JDK-8049834 as default_options.sh but never backported to JDK8
>> 7. JDK8 has jdk/test/sun/security/tools/jarsigner/diffend.sh test instead of jdk/test/sun/security/tools/jarsigner/DiffEnd.java. diffend.sh was not renamed to DiffEnd.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. diffend.sh updated accordingly - SHA1 replaced to SHA-256
>> 8. JDK8 has jdk/test/sun/security/tools/jarsigner/ec.sh test instead of jdk/test/sun/security/tools/jarsigner/EC.java. ec.sh was not renamed to EC.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. ec.sh has all required changes by JDK-8172404
>> 9. JDK8 has jdk/test/sun/security/tools/jarsigner/nameclash.sh test instead of jdk/test/sun/security/tools/jarsigner/NameClash.java. nameclash.sh was not renamed to NameClash.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. nameclash.sh has all required changes by JDK-8172404
>> 10. JDK8 has jdk/test/sun/security/tools/jarsigner/oldsig.sh test instead of  jdk/test/sun/security/tools/jarsigner/OldSig.java. oldsig.sh was not renamed to OldSig.java because of JDK-8180573 is not backported to JDK8. JDK-8180573 is a big refactoring and out of scope for this issue. The changes in the oldsig.sh are not required because of JDK-8217375 is not backported to JDK8.
>> 11. jdk/test/sun/security/tools/jarsigner/OldSig.props is not backported as it is not used in the  jdk/test/sun/security/tools/jarsigner/oldsig.sh
>> 
>> All java/security/Security sun/security/tools regression tests passed
>> 
>> [1] - https://www.java.com/en/jre-jdk-cryptoroadmap.html
>> [2] - https://github.com/openjdk/jdk11u-dev/commit/5a0824ba813ceda47847c9162c8a10bb0b8898e8
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oldsig test updated again

Thanks. It'll need to be against https://github.com/openjdk/jdk8u once I've finished promoting b05 to make 8u362. jdk8u-dev is now for 8u372 changes.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From duke at openjdk.org  Mon Nov 28 17:24:45 2022
From: duke at openjdk.org (Dan Lutker)
Date: Mon, 28 Nov 2022 17:24:45 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
Message-ID: <K6bFwRxronllnOTzgSbsqZBG1pMP_qFzRQ63bMa-HL4=.7d619c82-22ae-4346-a353-b55285e08080@github.com>

On Tue, 22 Nov 2022 18:01:16 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.
>
> Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Fix copyright
>  - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

Sure, we can wait.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From sgehwolf at openjdk.org  Mon Nov 28 17:31:01 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 28 Nov 2022 17:31:01 GMT
Subject: [jdk8u-dev] RFR: 8229182: [TESTBUG]
 runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 [v2]
In-Reply-To: <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
References: <AReidlsEscE0n7lTUuWQWewAPV30L5ZQwlBpw3cjQR4=.0c2f7a7c-3a86-4746-872f-bbe2ec22916e@github.com>
 <p-Ajj4JnpaiuFvIeKeaoOQhoPRx9UJJ_G7EsqmIfMKY=.fc35ebbd-57a5-469c-be6e-f08ee935524c@github.com>
Message-ID: <iiSPHQ6TKHNZ8XwUj56X928w82NtWpGYoU3bfbtWE34=.5986203d-164c-4c4b-ab5b-b78a9451ef42@github.com>

On Tue, 22 Nov 2022 18:01:16 GMT, Dan Lutker <duke at openjdk.org> wrote:

>> Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.
>
> Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Fix copyright
>  - Backport a41b9a71acdf69b78104677a1ca899ff36293a60

Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/186

From phh at openjdk.org  Tue Nov 29 00:03:39 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 00:03:39 GMT
Subject: [jdk8u-dev] RFR: 8275887: jarsigner prints invalid
 digest/signature algorithm warnings if keysize is weak/disabled
In-Reply-To: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
References: <umtI6fNRqIuplRD52H8VXI4ElAWk47zsD1M0B5tv3iA=.9102c954-81fd-4d7e-b888-bfe0514b46d4@github.com>
Message-ID: <D7FOQu9CqzqrLZUP04JRufvZPxMu3t4J3FtUkmWp_fE=.db8d7edd-aa56-43b8-9cc6-97bf99423481@github.com>

On Mon, 28 Nov 2022 13:25:42 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> - TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> - ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> - DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398 
> - SignerInfo.java - use explicit type instead of var
> 
> All corresponding tests passed

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/197

From gnu.andrew at redhat.com  Tue Nov 29 01:34:52 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 29 Nov 2022 01:34:52 +0000
Subject: [RAMPDOWN] 8u362 now in Rampdown Stage
Message-ID: <Y4VhvH7DlVO5ANRq@hex.discworld.ac.uk>

8u362 is now in rampdown for release in January.

jdk8u-dev is CLOSED for commits until further notice, while the branch
is prepared for the 8u372 release cycle.

For critical fixes (i.e. regressions or urgent fixes) for 8u362,
please file a PR against https://github.com/openjdk/jdk8u and use
jdk8u-critical-request to obtain approval to push.

Thanks, 
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221129/7d4c1d1c/signature.asc>

From gnu.andrew at redhat.com  Tue Nov 29 01:41:27 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 29 Nov 2022 01:41:27 +0000
Subject: CFV: New OpenJDK 8 Updates =?utf-8?Q?Commi?=
 =?utf-8?B?dHRlcjogWmRlbsSbayDFvWFtYmVyc2vDvQ==?=
Message-ID: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>

I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
Committer.

Zden?k is doing active backporting work for 8u [1], primarily in the
areas of PKCS11 support and testing infrastructure. Having the
committer role would aid this backporting work by avoiding the need to
wait for sponsorship of fixes, after review & approval.

Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.

Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
to vote on this nomination.

Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3].

[0] https://openjdk.java.net/census#zzambers
[1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
[2] http://openjdk.java.net/census#jdk8u
[3] http://openjdk.java.net/projects/#committer-vote

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221129/f0e96509/signature-0001.asc>

From gnu.andrew at redhat.com  Tue Nov 29 01:55:31 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 29 Nov 2022 01:55:31 +0000
Subject: OpenJDK 8u362-b0{1,2,3,4,5} EA Released
Message-ID: <Y4Vmk7YEYzkhcmYk@hex.discworld.ac.uk>

I've made available early access source bundles for each 8u362 build
promotion up to rampdown (jdk8u362-b05):

https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b01-ea.tar.xz
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b02-ea.tar.xz
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b03-ea.tar.xz
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b04-ea.tar.xz
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b05-ea.tar.xz

Each tarball is accompanied by a digital signature available at:

https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b01-ea.tar.xz.sig
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b02-ea.tar.xz.sig
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b03-ea.tar.xz.sig
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b04-ea.tar.xz.sig
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b05-ea.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint: CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

b54d96f7d8efc0c9e850ad6537c8fd1cc6f09e013d6440800cda34ee8e517b7f  openjdk8u362-b01-ea.tar.xz
e60a1463c06e4d135b67dc3d2141708512446f065e795d6502cf2f73ff109346  openjdk8u362-b01-ea.tar.xz.sig

3261816e2bf0c96342a7f1fb930bc343540364de0dc8645b4780dea68a98bd55  openjdk8u362-b02-ea.tar.xz
3526cdb091e2280b58297707509c661a7d6d3081b391feb370c7a556f22556e2  openjdk8u362-b02-ea.tar.xz.sig

d60cd140a924e27eb6b6d0eb524b77ed1889645c115d6294ebb13da524c7610b  openjdk8u362-b03-ea.tar.xz
9dc4bec79ddcb3fefad798c643242686b4e44d69d401c2efb6bf03381c22e248  openjdk8u362-b03-ea.tar.xz.sig

2857ed4fce64f58ebce83675da47571963b59b85655ac141b277122a3bc5a47c  openjdk8u362-b04-ea.tar.xz
4da1211e8f12952e9e7ad00febe39e4fe2b95c6a9c3f0f09158da8507f74d274  openjdk8u362-b04-ea.tar.xz.sig

f003d820db7de6ed56b81f29b44e7018a13680f01fc5f86e9bc376deeba23c70  openjdk8u362-b05-ea.tar.xz
769ed9fece43fc7e4e1f374c3eeb412fe6ced3ee1ce22b959ca1d2c04130b43d  openjdk8u362-b05-ea.tar.xz.sig

They are listed at
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b01-ea.sha256
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b02-ea.sha256
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b03-ea.sha256
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b04-ea.sha256
https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b05-ea.sha256

The tarballs were built on RHEL 6 (x86, x86_64) and RHEL 7 (aarch64,
ppc, ppc64, ppc64le, s390x, x86, x86_64)

Changes in 8u362-b01:
  - JDK-8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout
  - JDK-8067941: [TESTBUG] Fix tests for OS with 64K page size.
  - JDK-8071530: Update OS detection code to reflect Windows 10 version change
  - JDK-8148005: One byte may be corrupted by get_datetime_string()
  - JDK-8195607: sun/security/pkcs11/Secmod/TestNssDbSqlite.java failed with "NSS initialization failed" on NSS 3.34.1
  - JDK-8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems
  - JDK-8253702: BigSur version number reported as 10.16, should be 11.nn
  - JDK-8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport
  - JDK-8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  - JDK-8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  - JDK-8273176: handle latest VS2019 in abstract_vm_version
  - JDK-8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
  - JDK-8274840: Update OS detection code to recognize Windows 11
  - JDK-8283903: GetContainerCpuLoad does not return the correct result in share mode
  - JDK-8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041)
  - JDK-8292762: Remove .jcheck directories from jdk8u subcomponents
  - JDK-8293181: Bump update version of OpenJDK: 8u362
  - JDK-8293461: Add a test for JDK-8290832
  - JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
  - JDK-8294863: Enable partial tier1 testing in GHA for JDK8
  - JDK-8295164: JDK 8 jdi tests should not use tasklist command on Windows

Changes in 8u362-b02:
  - JDK-8294357: (tz) Update Timezone Data to 2022d
  - JDK-8295173: (tz) Update Timezone Data to 2022e
  - JDK-8295950: Enable langtools/tier1 in GHA for 8u

Changes in 8u362-b03:
  - JDK-7124218: [TEST_BUG] [macosx] Space should select cell in the JTable
  - JDK-8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  - JDK-8159720: Failure of C2 compilation with tiered prevents some C1 compilations
  - JDK-8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
  - JDK-8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
  - JDK-8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  - JDK-8270344: Session resumption errors
  - JDK-8284622: Update versions of some Github Actions used in JDK workflow
  - JDK-8295288: Some vm_flags tests associate with a wrong BugID
  - JDK-8295915: Problemlist compiler/rtm failures specific to 8u
  - JDK-8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u

Changes in 8u362-b04:
  - JDK-8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
  - JDK-8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  - JDK-8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
  - JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
  - JDK-8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  - JDK-8295714: GHA ::set-output is deprecated and will be removed
  - JDK-8296959: Fix hotspot shell tests of 8u on multilib systems

Changes in 8u362-b05:
  - JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
  - JDK-8073464: GC workers do not have thread names
  - JDK-8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
  - JDK-8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()
  - JDK-8269039: Disable SHA-1 Signed JARs
  - JDK-8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221129/87d25d9c/signature.asc>

From vrudomet at openjdk.org  Tue Nov 29 03:17:37 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 29 Nov 2022 03:17:37 GMT
Subject: [jdk8u-dev] RFR: 8296632: Write a test to verify the content change of
 TextArea sends TextEvent
Message-ID: <3iBoe9F74XwEmBrC3MyA3HVJcVGClcWeaLwZgSIDAmw=.6cd549af-59c0-4abc-9d91-231a7b689b94@github.com>

Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent 

Clean Backport.
New test, low risk.
Test passes during manual run on linux and mac.

-------------

Commit messages:
 - Backport 14592778b19af792f7394be381c3e23bf216372d

Changes: https://git.openjdk.org/jdk8u-dev/pull/198/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=198&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296632
  Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/198.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/198/head:pull/198

PR: https://git.openjdk.org/jdk8u-dev/pull/198

From vrudomet at openjdk.org  Tue Nov 29 05:01:09 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 29 Nov 2022 05:01:09 GMT
Subject: [jdk8u-dev] RFR: 8286624: Regression Test CoordinateTruncationBug.java
 fails on OL8.3
Message-ID: <EiX9B0PlsYBmmKlp8eLgjB2WfpZeM5bISoPsUCb4HW4=.5eb2feed-8ea2-485b-ad8f-b76554e26c5d@github.com>

Backport for [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3


Clean Backport, but the test needs to be moved due to 8 directory structure
New test, low risk.
Test passes during manual run on linux and mac.

-------------

Commit messages:
 - Backport 7964440dd3274b84713c0debe1846092bb6d6d68

Changes: https://git.openjdk.org/jdk8u-dev/pull/199/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=199&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8286624
  Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/199.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/199/head:pull/199

PR: https://git.openjdk.org/jdk8u-dev/pull/199

From abakhtin at openjdk.org  Tue Nov 29 07:18:39 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 29 Nov 2022 07:18:39 GMT
Subject: [jdk8u-dev] RFR: 8269039: Disable SHA-1 Signed JARs [v4]
In-Reply-To: <DK96r5GmwaEneYtM7TZHgfIlh89e55zX8MB4-UCgWiU=.b2393f5e-43be-4b8f-934c-a3c77bfa061a@github.com>
References: <LhuLqKXQpY3oL-RDdRXdEPe0Qr_J9k8VZY3OOG_BBe4=.eddbb893-6d57-4913-a453-06b26684512b@github.com>
 <CskO4AczGXONqTYQsjD3c20TO386fszAjdKYSNyfV0M=.77367fcd-f818-4cff-8a57-8ba8b0927264@github.com>
 <DK96r5GmwaEneYtM7TZHgfIlh89e55zX8MB4-UCgWiU=.b2393f5e-43be-4b8f-934c-a3c77bfa061a@github.com>
Message-ID: <Scv8uTnOI1w6-7yI2xp4htB7izrLrrO0szNRQ78GFuo=.00a96da7-56bf-495e-bca5-b94b866c9f6f@github.com>

On Mon, 28 Nov 2022 15:12:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   oldsig test updated again
>
> Thanks. It'll need to be against https://github.com/openjdk/jdk8u once I've finished promoting b05 to make 8u362. jdk8u-dev is now for 8u372 changes.

@gnu-andrew, New pull request against jdk8u was created : https://github.com/openjdk/jdk8u/pull/24

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/154

From abakhtin at openjdk.org  Tue Nov 29 07:20:37 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 29 Nov 2022 07:20:37 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
Message-ID: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>

Backported as a follow-on issue for JDK-8269039

Based on the JDK11u patch
I had to resolve some merge issues in a few places:

TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
SignerInfo.java - use explicit type instead of var
All corresponding tests passed

-------------

Commit messages:
 - Backport 03f8c0fb9363dc1bb07bed1ae0359c029caa0130

Changes: https://git.openjdk.org/jdk8u/pull/24/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=24&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8275887
  Stats: 125 lines in 9 files changed: 42 ins; 30 del; 53 mod
  Patch: https://git.openjdk.org/jdk8u/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/24/head:pull/24

PR: https://git.openjdk.org/jdk8u/pull/24

From adinn at redhat.com  Tue Nov 29 10:12:07 2022
From: adinn at redhat.com (Andrew Dinn)
Date: Tue, 29 Nov 2022 10:12:07 +0000
Subject: =?UTF-8?Q?Re=3a_CFV=3a_New_OpenJDK_8_Updates_Committer=3a_Zden?=
 =?UTF-8?B?xJtrIMW9YW1iZXJza8O9?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <8e2106a0-606a-c4d3-6fc8-5a64155f2c3a@redhat.com>

Vote: yes

On 29/11/2022 01:41, Andrew Hughes wrote:
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
> 
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
> 
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
> 
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
> 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> [0] https://openjdk.java.net/census#zzambers
> [1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
> 
> Thanks,

-- 
regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill


From sgehwolf at redhat.com  Tue Nov 29 10:30:31 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Tue, 29 Nov 2022 11:30:31 +0100
Subject: CFV: New OpenJDK 8 Updates Committer: =?UTF-8?Q?Zden=C4=9Bk?=
 =?UTF-8?Q?_=C5=BDambersk=C3=BD?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <aa4fb7ce9ef7ec3a0fa1cafca2f5e72439e6e65f.camel@redhat.com>

Vote: yes

On Tue, 2022-11-29 at 01:41 +0000, Andrew Hughes wrote:
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.


From dcherepanov at openjdk.org  Tue Nov 29 15:35:28 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Tue, 29 Nov 2022 15:35:28 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
Message-ID: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>

Please review the timezone data update to 2022f

The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).

Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).

Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

-------------

Commit messages:
 - Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d

Changes: https://git.openjdk.org/jdk8u-dev/pull/200/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=200&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296108
  Stats: 2350 lines in 36 files changed: 951 ins; 1247 del; 152 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/200.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/200/head:pull/200

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From gnu.andrew at redhat.com  Tue Nov 29 16:22:22 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 29 Nov 2022 16:22:22 +0000
Subject: CFV: New OpenJDK 8 Updates =?utf-8?Q?C?=
 =?utf-8?B?b21taXR0ZXI6IFpkZW7Em2sgxb1hbWJlcnNrw70=?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <Y4YxvvpuNzPrXVR0@hex.discworld.ac.uk>

On 01:41 Tue 29 Nov     , Andrew Hughes wrote:
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
> 
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
> 
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
> 
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
> 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> [0] https://openjdk.java.net/census#zzambers
> [1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
> 
> Thanks,
> -- 
> Andrew :)
> Pronouns: he / him or they / them
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Vote: Yes
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221129/861156c0/signature.asc>

From stooke at redhat.com  Tue Nov 29 18:56:09 2022
From: stooke at redhat.com (Simon Tooke)
Date: Tue, 29 Nov 2022 13:56:09 -0500
Subject: =?UTF-8?Q?Re=3a_CFV=3a_New_OpenJDK_8_Updates_Committer=3a_Zden?=
 =?UTF-8?B?xJtrIMW9YW1iZXJza8O9?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <8eb38f7b-db4e-fca3-7f44-dfd50fcde837@redhat.com>

vote: yes

On 2022-11-28 20:41, Andrew Hughes wrote:
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
>
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
>
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
>
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
>
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> [0] https://openjdk.java.net/census#zzambers
> [1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
>
> Thanks,

-- 
Simon Tooke
Principal Software Engineer - Java Platform
Red Hat Canada, Inc.
stooke at redhat.com


From phh at openjdk.org  Tue Nov 29 22:13:32 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 22:13:32 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
Message-ID: <QIDD-NZV8CTZSnvzG9l81ky7HLWft-0c6ruaU8ov_vc=.e3471451-b0eb-4f8e-b4d6-372f6ac4adef@github.com>

On Tue, 29 Nov 2022 07:10:58 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> 
> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
> SignerInfo.java - use explicit type instead of var
> All corresponding tests passed

Please configure pre-submit testing on your repo. Other than that, lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/24

From phh at openjdk.org  Tue Nov 29 22:34:23 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 22:34:23 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
Message-ID: <IIYUm9fc96n9JSiko9N4VQl8D3etHP9igsJi3SBuHcc=.2f2b92af-594d-4ff8-bcc5-e5067546d263@github.com>

On Tue, 29 Nov 2022 15:25:18 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the timezone data update to 2022f
> 
> The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From phh at openjdk.org  Tue Nov 29 22:46:22 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 22:46:22 GMT
Subject: [jdk8u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll
 [v2]
In-Reply-To: <YzqqiSoJNZ8fbWiNL91MaHqAy7S1PbnAsfi-WzdKRw4=.9e557883-f149-4e9a-bb95-b4d2db4ee0eb@github.com>
References: <l1GeRxei1QKwBrvWonMZgK3lIuxzfMFaiJV5DTSvZfg=.c77c5c4f-72fb-440c-b7ba-f635a31f0b0b@github.com>
 <YzqqiSoJNZ8fbWiNL91MaHqAy7S1PbnAsfi-WzdKRw4=.9e557883-f149-4e9a-bb95-b4d2db4ee0eb@github.com>
Message-ID: <SHxnr-yCTBjppo9PyHOQd65IOEyr0zZFmAPjimO7S2g=.8d731d21-ef62-4d24-b7d8-524215021a3d@github.com>

On Wed, 23 Nov 2022 11:19:32 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi!
>> 
>> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch https://github.com/openjdk/jdk11u-dev/commit/2548ed31aeb255a61644885c501667a74f90ebc7 is applied with the following changes:
>> 
>> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
>> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
>> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
>> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
>> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
>> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
>> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
>> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
>> 
>> Verification: MSVS2019 32/64-bit builds populate `vcrunt~1.dll`  and `vcrunt~2.dll` to JRE images, these are `vcruntime140.dll` and `vcruntime140_1.dll` accordingly (in jdk8 `configure` script renames the DLL's to avoid 8.3 conflict. I have no idea, do we still need for this).
>> Regression: MSVS2017 builds populate only vcrunt~1.dll
>> 
>> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   populating generated-configure.sh

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/193

From phh at openjdk.org  Tue Nov 29 22:48:29 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 22:48:29 GMT
Subject: [jdk8u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on
 32-bit Windows
In-Reply-To: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
References: <Jzt4Oav3AmFad6k6_IX9Px61QJLtgzyNanC6A9evNpE=.67a9a827-7840-4fcf-9025-248c7579f246@github.com>
Message-ID: <mL28MCzxjgf0Wz6ye_wDbQY8zXBlg9NFs3AkDLb8hjc=.bad24a35-7405-4764-a8ce-1ec0bee2e759@github.com>

On Mon, 28 Nov 2022 07:50:30 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the last backport of MSVS2019 seria. This one fixes unnecessary populating of 32-bit images with vcruntime140_1.dll. The patch from 11u applied cleanly except `generated-configure.sh` refreshing
> 
> Verification: MSVS2019 32-bit build -> JRE image contains only `vcrunt~1.dll` (`vcruntime140.dll`)
> Regression: MSVS2019 64-bit build -> JRE image still contains both `vcrunt~1.dll` (`vcruntime140.dll`) and `vcrunt~2.dll` (`vcruntime140_1.dll`)

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/195

From phh at openjdk.org  Tue Nov 29 22:52:44 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 29 Nov 2022 22:52:44 GMT
Subject: [jdk8u-dev] RFR: 8295322: Tests for JDK-8271459 were not
 backported to 11u
In-Reply-To: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
References: <RRg_ifc6dYFqJGJsAO4i7NFiyPELsvEPTQCzVRDXS44=.d092be68-b44c-4a5c-83d9-b896c9d5805e@github.com>
Message-ID: <bpKjrblWysMncHUEvs6jEJld6meC3bcK5FtYEVPJIh0=.35e28d35-9cad-49cb-9c81-8eeaad88dd8b@github.com>

On Tue, 1 Nov 2022 07:31:19 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is the backport of [JDK-8295322](https://bugs.openjdk.org/browse/JDK-8295322) that adds missed tests for [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459). Except the path shuffling the following changes were done to the original https://github.com/openjdk/jdk11u-dev/commit/70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015
> 
> - visibility of test class and methods was changed to `public` to support older JTReg
> - `requires` annotation was removed to support older JTReg
> 
> Verification (amd64/20.04 LTS): running new `hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java`
> 
> 7 of 7 PASS on https://github.com/openjdk/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a (integration of [JDK-8271459](https://bugs.openjdk.org/browse/JDK-8271459))
> 4 of 7 FAIL on the previous https://github.com/openjdk/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b

I'd ping a maintainer directly.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/152

From andrew at openjdk.org  Wed Nov 30 02:11:38 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 02:11:38 GMT
Subject: [jdk8u-dev] RFR: 8297739: Bump update version of OpenJDK: 8u372
Message-ID: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>

Rampdown for 8u362 has begun. 8u-dev needs to transition to 8u372.

-------------

Commit messages:
 - 8297739: Bump update version of OpenJDK: 8u372

Changes: https://git.openjdk.org/jdk8u-dev/pull/201/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=201&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297739
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/201.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/201/head:pull/201

PR: https://git.openjdk.org/jdk8u-dev/pull/201

From andrew at openjdk.org  Wed Nov 30 02:20:28 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 02:20:28 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
Message-ID: <IUR_eure47KV44gOalrj9Ub9RivoZbdNued3y-qx-y8=.01056c4b-b2c3-46d8-8492-645099339094@github.com>

On Tue, 29 Nov 2022 15:25:18 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the timezone data update to 2022f
> 
> The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

Thanks for doing this. I've been meaning to get to it myself, but not had chance. I've verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.

However, we should have this PR against https://github.com/openjdk/jdk8u so it will make 8u362. The changes are already overdue and 2022g will likely need to be integrated as well before we freeze 8u362 (https://bugs.openjdk.org/browse/JDK-8297804)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From sgehwolf at openjdk.org  Wed Nov 30 09:22:45 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 30 Nov 2022 09:22:45 GMT
Subject: [jdk8u-dev] RFR: 8297739: Bump update version of OpenJDK: 8u372
In-Reply-To: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
References: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
Message-ID: <xAwty26MWo0QrOrk1_X-s0czvUBSAORpdNPRT3pJlJ4=.4ceabc54-95ef-47ed-b53f-b40d92a0d55e@github.com>

On Wed, 30 Nov 2022 02:03:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u362 has begun. 8u-dev needs to transition to 8u372.

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/201

From dcherepanov at openjdk.org  Wed Nov 30 09:23:27 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 09:23:27 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <IUR_eure47KV44gOalrj9Ub9RivoZbdNued3y-qx-y8=.01056c4b-b2c3-46d8-8492-645099339094@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
 <IUR_eure47KV44gOalrj9Ub9RivoZbdNued3y-qx-y8=.01056c4b-b2c3-46d8-8492-645099339094@github.com>
Message-ID: <7HdjKAWTyjjfxHSRWX-2Nr0J6zCmskEBxcr7ncwgz30=.8b675683-bf58-46d4-9346-ba3ea2db9133@github.com>

On Wed, 30 Nov 2022 02:16:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Thanks for doing this. I've been meaning to get to it myself, but not had chance. I've verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.
> 
> However, we should have this PR against https://github.com/openjdk/jdk8u so it will make 8u362. The changes are already overdue and 2022g will likely need to be integrated as well before we freeze 8u362 (https://bugs.openjdk.org/browse/JDK-8297804)

Thanks. I've created new PR against jdk8u - https://github.com/openjdk/jdk8u/pull/25

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From dcherepanov at openjdk.org  Wed Nov 30 09:27:05 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 09:27:05 GMT
Subject: [jdk8u] RFR: 8296108: (tz) Update Timezone Data to 2022f
Message-ID: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>

The same as https://github.com/openjdk/jdk8u-dev/pull/200

It's created against jdk8u so that this update can be included in 8u362.

All relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

-------------

Commit messages:
 - Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d

Changes: https://git.openjdk.org/jdk8u/pull/25/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=25&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296108
  Stats: 2350 lines in 36 files changed: 951 ins; 1247 del; 152 mod
  Patch: https://git.openjdk.org/jdk8u/pull/25.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u pull/25/head:pull/25

PR: https://git.openjdk.org/jdk8u/pull/25

From jdowland at redhat.com  Wed Nov 30 10:15:40 2022
From: jdowland at redhat.com (Jonathan Dowland)
Date: Wed, 30 Nov 2022 10:15:40 +0000
Subject: CFV: New OpenJDK 8 Updates Committer: =?utf-8?Q?Zden=C4=9Bk_?=
 =?utf-8?B?xb1hbWJlcnNrw70=?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <20221130101540.bgod5rrz2ciuk2bf@qusp>

Vote: yes

On Tue, Nov 29, 2022 at 01:41:27AM +0000, Andrew Hughes wrote:
>I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
>Committer.
>
>Zden?k is doing active backporting work for 8u [1], primarily in the
>areas of PKCS11 support and testing infrastructure. Having the
>committer role would aid this backporting work by avoiding the need to
>wait for sponsorship of fixes, after review & approval.
>
>Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
>
>Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
>to vote on this nomination.
>
>Votes must be cast in the open by replying to this mailing list.
>
>For Lazy Consensus voting instructions, see [3].
>
>[0] https://openjdk.java.net/census#zzambers
>[1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
>[2] http://openjdk.java.net/census#jdk8u
>[3] http://openjdk.java.net/projects/#committer-vote
>
>Thanks,
>-- 
>Andrew :)
>Pronouns: he / him or they / them
>Senior Free Java Software Engineer
>OpenJDK Package Owner
>Red Hat, Inc. (http://www.redhat.com)
>
>PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



-- 
?? Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat


From neugens at redhat.com  Wed Nov 30 11:14:55 2022
From: neugens at redhat.com (Mario Torre)
Date: Wed, 30 Nov 2022 12:14:55 +0100
Subject: =?UTF-8?Q?Re=3A_CFV=3A_New_OpenJDK_8_Updates_Committer=3A_Zden=C4=9Bk_=C5=BD?=
 =?UTF-8?Q?ambersk=C3=BD?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <CAJwKKmZGk3GK=77yHMuagTriGSB5dP7UfLsEg=bNCz-5d0YbPQ@mail.gmail.com>

Vote: Yes,

Cheers,
Mario

On Tue, Nov 29, 2022 at 2:42 AM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>
> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
>
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
>
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
>
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
>
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> [0] https://openjdk.java.net/census#zzambers
> [1] https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
>
> Thanks,
> --
> Andrew :)
> Pronouns: he / him or they / them
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



-- 
Mario Torre
Manager, Software Engineering, OpenJDK
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898

Red Hat GmbH, Registered seat: Werner von Siemens Ring 12, D-85630
Grasbrunn, Germany

Commercial register: Amtsgericht Muenchen/Munich, HRB 153243,
Managing Directors: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross


From andrew at openjdk.org  Wed Nov 30 14:53:37 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 14:53:37 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
Message-ID: <QFKs3NzyKXIGPS2p1MSEU8dcEmmWHoT3EXMDIDpaBPs=.3134e134-1c19-4c32-8ec6-7a3928518cb8@github.com>

On Tue, 29 Nov 2022 15:25:18 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the timezone data update to 2022f
> 
> The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.

Please label the bug with jdk8u-critical-request and add an approval request comment.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From andrew at openjdk.org  Wed Nov 30 14:55:32 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 14:55:32 GMT
Subject: [jdk8u-dev] RFR: 8297739: Bump update version of OpenJDK: 8u372
In-Reply-To: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
References: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
Message-ID: <-DTouYPHq0ad1jMAl-vQj0uItQPDvmUtSSrYM0ZnLlM=.176b94a7-1929-4bc3-9dec-52e96b97fb59@github.com>

On Wed, 30 Nov 2022 02:03:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u362 has begun. 8u-dev needs to transition to 8u372.

I see `jdk8u-fix-yes`.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/201

From andrew at openjdk.org  Wed Nov 30 14:57:44 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 14:57:44 GMT
Subject: [jdk8u] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
References: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
Message-ID: <oy4TKedYKC-Vbr4WxtJZWh3SVBOGpJj5tgtzHUYUt3o=.87c94ff0-c79f-4cc4-96c0-616991e6a09b@github.com>

On Wed, 30 Nov 2022 09:16:14 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/200
> 
> It's created against jdk8u so that this update can be included in 8u362.
> 
> All relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.

Please label the bug with jdk8u-critical-request and add an approval request comment.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/25

From andrew at openjdk.org  Wed Nov 30 14:58:45 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 14:58:45 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <QFKs3NzyKXIGPS2p1MSEU8dcEmmWHoT3EXMDIDpaBPs=.3134e134-1c19-4c32-8ec6-7a3928518cb8@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
 <QFKs3NzyKXIGPS2p1MSEU8dcEmmWHoT3EXMDIDpaBPs=.3134e134-1c19-4c32-8ec6-7a3928518cb8@github.com>
Message-ID: <wjq7MSk59KdI8UFUDmSIk84aD5G4DeByIb4_Yc7-OsY=.6c51c503-0978-48d4-af2c-c1c4c2492bc9@github.com>

On Wed, 30 Nov 2022 14:51:03 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.
> 
> Please label the bug with jdk8u-critical-request and add an approval request comment.

Ugh, wrong PR. Done the same on openjdk/jdk8u#25 now.

Note that you need to enable actions on your 8u fork. It doesn't matter for this one, as it passed tests here, but good to sort for any future PRs.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From andrew at openjdk.org  Wed Nov 30 14:59:05 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 14:59:05 GMT
Subject: [jdk8u-dev] Integrated: 8297739: Bump update version of OpenJDK: 8u372
In-Reply-To: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
References: <I62Q09sOJgCowa2nfzi6Cj3C_VRSMFLtQT4mXiYM52Q=.2f66f20d-3263-4d7c-8bc0-6baa275ac659@github.com>
Message-ID: <YYiqceqa2OBR_yfIZEWHrmf7czVtlzju_Hmg0uNDykk=.c266fd13-9f31-4aa0-894b-3daaa48b0a3c@github.com>

On Wed, 30 Nov 2022 02:03:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u362 has begun. 8u-dev needs to transition to 8u372.

This pull request has now been integrated.

Changeset: 3b1bbef3
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/3b1bbef37be666017bd86b725e1e218dd11f5da6
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8297739: Bump update version of OpenJDK: 8u372

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/201

From dcherepanov at openjdk.org  Wed Nov 30 15:09:49 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 15:09:49 GMT
Subject: [jdk8u] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <oy4TKedYKC-Vbr4WxtJZWh3SVBOGpJj5tgtzHUYUt3o=.87c94ff0-c79f-4cc4-96c0-616991e6a09b@github.com>
References: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
 <oy4TKedYKC-Vbr4WxtJZWh3SVBOGpJj5tgtzHUYUt3o=.87c94ff0-c79f-4cc4-96c0-616991e6a09b@github.com>
Message-ID: <mwbktePNMdDGep0Y9yQbiCPxBy0be6-jZEkOrEEeoWU=.e1d288cc-789c-4c45-add2-8cad01c550e4@github.com>

On Wed, 30 Nov 2022 14:55:07 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.
> 
> Please label the bug with jdk8u-critical-request and add an approval request comment.

Thanks for verifying. Added jdk8u-critical-request and new approval request comment.

-------------

PR: https://git.openjdk.org/jdk8u/pull/25

From andrew at openjdk.org  Wed Nov 30 15:12:31 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 15:12:31 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
Message-ID: <l6EhGll_ubwXroMzcfTH9Wny8Gjf_k4SdiaC6K9Zxs0=.72baa114-a704-41e0-ae7d-671b1e47a5da@github.com>

On Tue, 29 Nov 2022 07:10:58 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> 
> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
> SignerInfo.java - use explicit type instead of var
> All corresponding tests passed

Backport looks good to me.

The text `"the value is a record"` is wrong, given the change from a record to `AlgorithmInfo`, but that mistake was also in the 11u version so this backport isn't the place to fix it. It's a internal class so I don't think it matters much anyway.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u/pull/24

From andrew at openjdk.org  Wed Nov 30 15:17:46 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 15:17:46 GMT
Subject: [jdk8u] RFR: 8275887: jarsigner prints invalid digest/signature
 algorithm warnings if keysize is weak/disabled
In-Reply-To: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
References: <BSQjXPQheDPTTG00DezXj_kuj1TEq9-6Me-dngya8bE=.b1b0875e-134a-4a9d-8e32-ff5e42b3f6c7@github.com>
Message-ID: <iLBqf8xbCnPLHRYOaq7PPksziEBWKBsnx58nuI48P4o=.efcd9f4a-6089-4f3a-a04c-26d574f183c1@github.com>

On Tue, 29 Nov 2022 07:10:58 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Backported as a follow-on issue for JDK-8269039
> 
> Based on the JDK11u patch
> I had to resolve some merge issues in a few places:
> 
> TimestampCheck.java - simple merge because of no JDK-8171319 in JDK8
> ManifestEntryVerifier.java - Manually updated because of different arguments of the permits() method
> DisabledAlgorithmConstraints.java - permits() method manually updated because of no JDK-8285398
> SignerInfo.java - use explicit type instead of var
> All corresponding tests passed

Added `jdk8u-critical-yes` for approval.

-------------

PR: https://git.openjdk.org/jdk8u/pull/24

From dcherepanov at openjdk.org  Wed Nov 30 15:31:32 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 15:31:32 GMT
Subject: [jdk8u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <wjq7MSk59KdI8UFUDmSIk84aD5G4DeByIb4_Yc7-OsY=.6c51c503-0978-48d4-af2c-c1c4c2492bc9@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
 <QFKs3NzyKXIGPS2p1MSEU8dcEmmWHoT3EXMDIDpaBPs=.3134e134-1c19-4c32-8ec6-7a3928518cb8@github.com>
 <wjq7MSk59KdI8UFUDmSIk84aD5G4DeByIb4_Yc7-OsY=.6c51c503-0978-48d4-af2c-c1c4c2492bc9@github.com>
Message-ID: <idSK9sEiQLgc1IOQciZ5OGx3vpdoPyVq-CR7HYEUbH4=.13403b87-7ebf-45ac-be15-709c36f16946@github.com>

On Wed, 30 Nov 2022 14:56:30 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Note that you need to enable actions on your 8u fork. It doesn't matter for this one, as it passed tests here, but good to sort for any future PRs.

Sorry, I forgot about actions when created a new fork (enabled now). I'll close this PR given that the change will go to the jdk8u repo.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From dcherepanov at openjdk.org  Wed Nov 30 15:33:14 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 15:33:14 GMT
Subject: [jdk8u-dev] Withdrawn: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
References: <Pg7C4E2c0SDh12G1cx_63gQ2_nuVFHpd4LVAmZOgS7w=.55176349-d052-4fa6-aef2-cce7f7041de5@github.com>
Message-ID: <u3AWpXWz9bZS0NKORGyTqT1xPBPVfAbmwFJVBprI8L4=.fd511548-367c-4a1a-9808-03feb77f322d@github.com>

On Tue, 29 Nov 2022 15:25:18 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review the timezone data update to 2022f
> 
> The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
> 
> Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).
> 
> Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/200

From andrew at openjdk.org  Wed Nov 30 15:37:25 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 15:37:25 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v7]
In-Reply-To: <R2VDjxbhuXjplQ2ftxGvQHj2F8x-yUgjGHEQj368ggo=.9c96a75f-53e2-48c9-a474-3ef96c1d8ec2@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <R2VDjxbhuXjplQ2ftxGvQHj2F8x-yUgjGHEQj368ggo=.9c96a75f-53e2-48c9-a474-3ef96c1d8ec2@github.com>
Message-ID: <hkQAfcYln5vybPR3Id7_MU9iQZbdOwEU0jsF9mxBLp8=.74295983-9778-44be-8adf-d93bb1b9f8d8@github.com>

On Tue, 1 Nov 2022 14:25:06 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains six new commits since the last revision:
> 
>  - Remove C++11-style non-static member initialisation
>    
>    This causes issues with pre-C++11 compilers (of which jdk8u-dev
>    ostensibly supports). Issue has materialised on ARM32.
>    
>    I haven't introduced initialiser lists to the constructor because
>    all of these are assigned to in the body of the constructor.
>  - Guard two more tty->print_cr with PrintContainerInfo
>  - Whitespace and braces around PrintContainerInfo
>  - substitute os::strerror for strerror
>    
>    os::strerror was introduced in 8148425 (strerror() function is not
>    thread-safe), which is probably out of scope for backporting (at least
>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>    (thread unsafe) strerror, in common with the rest of JDK8u.
>  - Rework use of newer logging API to tty->print_cr
>    
>    Remove includes of log.hpp that doesn't exist in jdk8u
>    
>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>  - 8230305: Cgroups v2: Container awareness
>    
>    Implement Cgroups v2 container awareness in hotspot
>    
>    Reviewed-by: bobv, dholmes

Backport looks good. It's not clear to me why JDK-8254997 needed to be bundled into this change rather than a follow-up, but it's not worth changing now.

Approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From andrew at openjdk.org  Wed Nov 30 16:15:53 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 30 Nov 2022 16:15:53 GMT
Subject: [jdk8u] RFR: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
References: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
Message-ID: <Z0mmnYSjYqcQ-6gdz1pxsN82ctGN8wcwMMSlZZhCJME=.b2093f98-147a-4b26-98fb-ebdb5c87f0b5@github.com>

On Wed, 30 Nov 2022 09:16:14 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/200
> 
> It's created against jdk8u so that this update can be included in 8u362.
> 
> All relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

Thanks. Approved for 8u.

-------------

PR: https://git.openjdk.org/jdk8u/pull/25

From dcherepanov at openjdk.org  Wed Nov 30 16:30:10 2022
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 30 Nov 2022 16:30:10 GMT
Subject: [jdk8u] Integrated: 8296108: (tz) Update Timezone Data to 2022f
In-Reply-To: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
References: <q1Bnwtxcbmoke2iE9YmDsZTNSMP6dMdKJGD0LqFkTXw=.fc24ad45-fb26-48f7-95f2-ce69f1bedf4a@github.com>
Message-ID: <prTqXRJwOIJkkoV8gulk2KfYv5npLQFRqN5AJY2ZRXY=.a8a05910-39df-4836-ae5a-2d28423d9e88@github.com>

On Wed, 30 Nov 2022 09:16:14 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/200
> 
> It's created against jdk8u so that this update can be included in 8u362.
> 
> All relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test

This pull request has now been integrated.

Changeset: 7297bdfc
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/7297bdfcaeb55da8c14560ff352407d114a38bd7
Stats:     2350 lines in 36 files changed: 951 ins; 1247 del; 152 mod

8296108: (tz) Update Timezone Data to 2022f

Reviewed-by: andrew
Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d

-------------

PR: https://git.openjdk.org/jdk8u/pull/25

From gnu.andrew at redhat.com  Wed Nov 30 16:40:39 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 30 Nov 2022 16:40:39 +0000
Subject: [RAMPDOWN] 8u372 now OPEN
Message-ID: <Y4eHh8eZlv5w1yTb@hex.discworld.ac.uk>

The version has been bumped [0] so 8u-dev is now open for
commits for 8u372 (April 2023 release)

[0] https://github.com/openjdk/jdk8u-dev/commit/3b1bbef37be666017bd86b725e1e218dd11f5da6

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221130/c4923445/signature.asc>

From jdowland at openjdk.org  Wed Nov 30 20:12:57 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 30 Nov 2022 20:12:57 GMT
Subject: [jdk8u-dev] Integrated: 8230305: Cgroups v2: Container awareness
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <3SNaYrsMHKdQnvVnhAFON_3sJntX7ttpp1G0TCw0kNY=.1170f17d-24f8-4265-a3e8-0ec1482c0076@github.com>

On Mon, 3 Oct 2022 09:57:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

This pull request has now been integrated.

Changeset: 7eb2803b
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7eb2803b5b3c769827cf02cc40a15b13b74bf588
Stats:     2094 lines in 10 files changed: 1461 ins; 596 del; 37 mod

8230305: Cgroups v2: Container awareness
8216366: Add rationale to PER_CPU_SHARES define
8229202: Docker reporting causes secondary crashes in error handling
8232207: Linux os::available_memory re-reads cgroup configuration on every invocation
8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes

Implement Cgroups v2 container awareness in hotspot

Reviewed-by: sgehwolf, andrew
Backport-of: d462a6b5c9bd3dae5257cca42ea38c19cb742e3c

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From mbalao at redhat.com  Wed Nov 30 21:02:15 2022
From: mbalao at redhat.com (Martin Balao)
Date: Wed, 30 Nov 2022 16:02:15 -0500
Subject: =?UTF-8?Q?Re=3A_CFV=3A_New_OpenJDK_8_Updates_Committer=3A_Zden=C4=9Bk_=C5=BD?=
 =?UTF-8?Q?ambersk=C3=BD?=
In-Reply-To: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
References: <Y4VjR8Ch8bkY08mQ@hex.discworld.ac.uk>
Message-ID: <CAKZz+gdbMFF=v4aQsYbxY289B04hWGnncRYoPaydf++EZ1xptw@mail.gmail.com>

Vote: Yes.

On Mon, Nov 28, 2022 at 8:42 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:

> I hereby nominate Zden?k ?ambersk? (zzambers) [0] to OpenJDK 8 Updates
> Committer.
>
> Zden?k is doing active backporting work for 8u [1], primarily in the
> areas of PKCS11 support and testing infrastructure. Having the
> committer role would aid this backporting work by avoiding the need to
> wait for sponsorship of fixes, after review & approval.
>
> Votes are due by 00h00 UTC on Tuesday, the 13th of December, 2022.
>
> Only current OpenJDK 8 Updates Committers (and above) [2] are eligible
> to vote on this nomination.
>
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> [0] https://openjdk.java.net/census#zzambers
> [1]
> https://github.com/openjdk/jdk8u-dev/search?q=author:zzambers&type=commits
> [2] http://openjdk.java.net/census#jdk8u
> [3] http://openjdk.java.net/projects/#committer-vote
>
> Thanks,
> --
> Andrew :)
> Pronouns: he / him or they / them
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221130/e2b7237c/attachment.htm>