[jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure [v3]

Jonathan Dowland jdowland at openjdk.org
Tue Nov 1 10:35:54 UTC 2022


On Tue, 1 Nov 2022 10:32:17 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
>> 
>> Apart from path shuffling, it applies clean.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8237479: 8230305 causes slowdebug build failure
>   
>   Declare methods as pure virtual.
>   
>   Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp line 60:

> 58: class CgroupController: public CHeapObj<mtInternal> {
> 59:   public:
> 60:     virtual char *subsystem_path() = 0;

I wonder if this will fall foul of the pre C++11 ARM32 compiler problem that 
https://github.com/openjdk/jdk8u-dev/pull/127 had

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/128


More information about the jdk8u-dev mailing list