[jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp [v4]
Alexey Pavlyutkin
duke at openjdk.org
Wed Nov 16 18:37:41 UTC 2022
> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
>
> Verification: 2019 build (both 32/64) now fails with
>
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
>
> error (to be fixed by backport of 8043492)
>
> Regression: 2017/2013/2012/2010 full build - ok
>
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
fixing copyright date
-------------
Changes:
- all: https://git.openjdk.org/jdk8u-dev/pull/77/files
- new: https://git.openjdk.org/jdk8u-dev/pull/77/files/a7c2b48d..c86b9dac
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=02-03
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/77.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/77/head:pull/77
PR: https://git.openjdk.org/jdk8u-dev/pull/77
More information about the jdk8u-dev
mailing list