[jdk8u-dev] RFR: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows

[zzambers]

On Wed, 16 Nov 2022 17:49:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Test `hotspot/test/runtime/NMT/HugeArenaTracking.java` (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.
>
> hotspot/test/runtime/NMT/HugeArenaTracking.java line 28:
> 
>> 26:  * @key nmt jcmd
>> 27:  * @library /testlibrary /testlibrary/whitebox
>> 28:  * @requires vm.bits == 64
> 
> I don't think this has any effect on JDK 8. AFAIK, `vm.bits` is being set in JDK 11+ via `test/jtreg-ext/requires/VMProps.java` which isn't available in JDK 8. Have you tested this works?
> 
> I think something like this would be suitable here:
> 
> 
> if (!Platform.is64Bit()) {
>    System.out.println("Test requires 64 bits. Skipping...");
>    return;
> }

Oh, you are right. I ran tests with 32-bit OSes enabled [1] and failure there disappeared, so I considered it working. I haven't realized test was also excluded on 64-bits. (condition was basically treated as always false) Nice find, I'll fix it. Thanks

[1] https://github.com/zzambers/jdk8u-dev/actions/runs/3471605048/jobs/5802167187

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/182