[jdk8u-dev] Integrated: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp

[Alexey Pavlyutkin]

On Wed, 22 Jun 2022 08:31:36 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
> 
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - INT64_C & UINT64_C declarations removed cuz they duplicate ones done by `stdint.h`
> 
> Verification: 2019 build (both 32/64) now fails with 
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> error (to be fixed by backport of 8043492)
> 
> Regression: 2017/2013/2012/2010 full build - ok
> 
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated

This pull request has now been integrated.

Changeset: b98d485d
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b98d485df4db6b5adf074444f9a94d2510faf5a0
Stats:     47 lines in 1 file changed: 6 ins; 34 del; 7 mod

8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp

Use <stdint.h> and <inttypes.h> on Windows instead of emulation.

Reviewed-by: phh
Backport-of: b8ab854bdcf625772e965a5e476e0a9db1b91f3f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77