[jdk8u-dev] RFR: 8297329: [8u] hotspot needs to recognise VS2019 [v2]

[Alexey Pavlyutkin]

> Hi!
> 
> Please review another portion of changes to add MSVS2019 support to jdk-8. This one adds recognition of MSVS2019 compiler/linker to the hotspot build scripts and apply build rules accordingly. Before the patch the scripts didn't not know how to link precompiled headers and builds failed with the error
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> 
> Verification: MSVS2019 (32/64-bits, release/debug) builds now fail with
> 
> awt_DCHolder.cpp
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2039: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(46): error C2873: 'Do_Not_Use_calloc_Use_safe_Calloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2039: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': is not a member of '`global namespace''
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(52): error C2873: 'Do_Not_Use_malloc_Use_safe_Malloc_Instead': symbol cannot be used in a using-declaration
> C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.29.30133\include\cstdlib(58): error C2039: 'Do_Not_Use_realloc_Use_safe_Realloc_Instead': is not a member of '`global namespace''
> slowdebug/jdk/objs/libawt/awt_DCHolder.obj] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> that will be fixed by backporting of [JDK-8241087](https://bugs.openjdk.org/browse/JDK-8241087)
> 
> Regression: MSVS2017 (32/64-bits, release/debug) build - Ok

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  fix line alignment to be compliant with the baseline

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/187/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/187/files/38050b1f..a7a11fdc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=187&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=187&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/187.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/187/head:pull/187

PR: https://git.openjdk.org/jdk8u-dev/pull/187