[jdk8u-dev] RFR: 8242468: VS2019 build missing vcruntime140_1.dll [v2]
Alexey Pavlyutkin
duke at openjdk.org
Wed Nov 23 11:19:32 UTC 2022
> Hi!
>
> Here is another backport from MSVS2019 seria. It fixes bundling of new vcruntime140_1.dll for MSVS2019 builds. The patch from 11u is applied with the following changes:
>
> - make/CreateJmods.gmk -> SKIPPED, cuz jdk8 does not support Jmod
> - make/hotspot/test/GtestImage.gmk -> SKIPPED, cuz jdk8 does not use GTest
> - make/autoconf/basic.m4 -> common/autoconf/basics.m4 (no conflicts)
> - make/autoconf/toolchain_windows.m4 -> common/autoconf/toolchain_windows.m4 (no conflicts)
> - make/autoconf/spec.gmk.in -> common/autoconf/spec.gmk.in (no conflicts)
> - make/lib/CoreLibraries.gmk -> jdk/make/lib/CoreLibraries.gmk (no conflicts)
> - make/devkit/createWindowsDevkit2019.sh -> make/devkit/createWindowsDevkit2019.sh (no conflicts)
> - make/copy/Copy-java.base.gmk -> jdk/make/CopyFiles.gmk: at [line#276](https://github.com/openjdk/jdk8u-dev/pull/193/files#diff-5abbf26d940be8e271c3b80169ef290847b39f577dbbf6cdfed216ca13f78d03R276) jdk11 uses `TARGETS` to hold concatenated value but jdk8 uses `COPY_FILES`
>
> Verification: MSVS2019 32/64-bit builds populate vcrunt~1.dll and vcrunt~2.dll to JRE images, these are vcruntime140.dll and vcruntime140_1.dll accordingly (in jdk8 the make script renames the DLL's to avoid 8.3 conflict)
> Regression: MSVS2017 builds populate only vcrunt~1.dll
>
> Note: accordingly to [JDK-8247676](https://bugs.openjdk.org/browse/JDK-8247676) 32-bit builds do not need to populate new runtime library. The backport will be done on top of this one as dependent PR, and that is why I do not commit common/autoconf/generated-configure.sh here
Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
populating generated-configure.sh
-------------
Changes:
- all: https://git.openjdk.org/jdk8u-dev/pull/193/files
- new: https://git.openjdk.org/jdk8u-dev/pull/193/files/d64fe1bf..f471ed99
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=193&range=00-01
Stats: 1442 lines in 1 file changed: 1417 ins; 0 del; 25 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/193.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/193/head:pull/193
PR: https://git.openjdk.org/jdk8u-dev/pull/193
More information about the jdk8u-dev
mailing list