[jdk8u-dev] RFR: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails

Severin Gehwolf sgehwolf at openjdk.org
Fri Nov 25 16:47:20 UTC 2022


On Wed, 23 Nov 2022 00:25:55 GMT, zzambers <duke at openjdk.org> wrote:

> Following tests from hotspot/tier1 currently fails on Windows x86:
> `gc/metaspace/TestCapacityUntilGCWrapAround.java` 
> 
> This backport fixes that failure.
> 
> Backport is not clear as there was some renaming done in `metaspace.cpp` file. However apart from some renames (e.g. `align_size_down` -> `align_down`, `capacity_until_GC` -> `old_capacity_until_GC`) and location of the file surrounding method looks practically the same (See original change [1]). 
> 
> Tested on branch with hotspot/tier1 testing enabled for x86 OSes [2]. Fixed that one test, caused no regressions (Compare [3][4]).
> 
> [1] https://github.com/openjdk/jdk/commit/038f58d4
> [2] https://github.com/zzambers/jdk8u-dev/commits/metaspace-fix-test
> [3] https://github.com/zzambers/jdk8u-dev/actions/runs/3438556844/jobs/5735312562
> [4] https://github.com/zzambers/jdk8u-dev/actions/runs/3471835524/jobs/5803573225

This looks clean to me (only path changes).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/192


More information about the jdk8u-dev mailing list