From jdowland at openjdk.org  Mon Oct  3 10:04:29 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 3 Oct 2022 10:04:29 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness
Message-ID: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>

This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.

The patch does not apply clean after unshuffling and path fixing:

 * mostly copyright line issues
 * different package name for jdk.test.lib.process.OutputAnalyzer
 * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)

A few other changes were made

 *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
 *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)

patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

-------------

Commit messages:
 - substitute os::strerror for strerror
 - Rework use of newer logging API to tty->print_cr
 - 8230305: Cgroups v2: Container awareness

Changes: https://git.openjdk.org/jdk8u-dev/pull/127/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8230305
  Stats: 2056 lines in 10 files changed: 1423 ins; 596 del; 37 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Mon Oct  3 10:08:35 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 3 Oct 2022 10:08:35 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>

On Mon, 3 Oct 2022 09:57:22 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Local test failure observed in runtime/containers/docker/TestMemoryAwareness.java:

JavaTest Message: Test threw exception: java.lang.RuntimeException: 'Memory Soft Limit.*524288000' missing from stdout/stderr 

this might be [JDK-8253714](https://bugs.openjdk.org/browse/JDK-8253714), which is on the list to backport, I'll look at this next.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at redhat.com  Mon Oct  3 15:30:00 2022
From: jdowland at redhat.com (Jonathan Dowland)
Date: Mon, 3 Oct 2022 16:30:00 +0100
Subject: Backport to JDK8
In-Reply-To: <CAKcZAWz696h9eMaA9t9OjWj0hq11VRzg1csNCgCBE5B1BirvGA@mail.gmail.com>
References: <CAKcZAWz696h9eMaA9t9OjWj0hq11VRzg1csNCgCBE5B1BirvGA@mail.gmail.com>
Message-ID: <20221003153000.5654la4i7nownzri@coil>

Hi,

On Tue, Sep 13, 2022 at 07:02:29AM +0900, Mitsuhiro Yamamoto wrote:
>The following bugs in JDK8 have already been fixed in ORACLE JDK.
>Will these fixes not be backported to OpenJDK?
>
>https://bugs.openjdk.org/browse/JDK-8253702
>https://bugs.openjdk.org/browse/JDK-8251377

I sometimes work on macOS bugs: I'll put them on my backlog, however, at
the moment I am focussing on cgroups v2 backports, so it may be a couple
of weeks before I manage to take a look.


Best wishes,

-- 
?? Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat


From duke at openjdk.org  Tue Oct  4 09:09:22 2022
From: duke at openjdk.org (psoujany)
Date: Tue, 4 Oct 2022 09:09:22 GMT
Subject: [jdk8u-dev] RFR: 8209052: Low contrast in
 docs/api/constant-values.html
In-Reply-To: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
References: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
Message-ID: <yj6td7xHqn-rIXxYRINkRU_DCajZ7pP1P9NwzDAEvdY=.3eecc2a0-ff77-415a-9746-1f119c3e2b40@github.com>

On Thu, 25 Aug 2022 07:48:19 GMT, psoujany <duke at openjdk.org> wrote:

> Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
> Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052

@theRealAph Could you please review this PR.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/114

From jdowland at openjdk.org  Tue Oct  4 09:53:49 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 4 Oct 2022 09:53:49 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
Message-ID: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>

This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.

Apart from path shuffling, it applies clean.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/127

Commit messages:
 - 8237479: 8230305 causes slowdebug build failure

Changes: https://git.openjdk.org/jdk8u-dev/pull/128/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8237479
  Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Tue Oct  4 13:35:47 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 4 Oct 2022 13:35:47 GMT
Subject: [jdk8u-dev] RFR: 8294767: 8u contains two copies of
 test/../FileUtils.java, one uses JDK9+ features
Message-ID: <KiYXSKr9LwNCnJkL5nqcIaLCynP4yMkAtvdqi6JGSbU=.2f495b0f-1f81-4447-bd58-1f4568ad2c80@github.com>

There are two copies of the test utility class FileUtils.java in the jdk8u-dev source tree:


$ find . -name FileUtils.java
./jdk/test/lib/testlibrary/jdk/testlibrary/FileUtils.java
./jdk/test/lib/jdk/test/lib/util/FileUtils.java


One of them is not used by anything. It also uses language features that are not present in 8u:


$ $JAVA_HOME/bin/javac ./jdk/test/lib/jdk/test/lib/util/FileUtils.java
# snip
./jdk/test/lib/jdk/test/lib/util/FileUtils.java:166: error: cannot infer type arguments for SimpleFileVisitor<T>
            java.nio.file.Files.walkFileTree(dir, new SimpleFileVisitor<>() {
                                                                       ^
  reason: cannot use '<>' with anonymous inner classes


The soluton for this case is simple, just remove the above file.

This is part of a wider issue of duplicated test material, but I'm filing for the one I found for now. 

* https://bugs.openjdk.org/browse/JDK-8294767

-------------

Commit messages:
 - 8294767: 8u contains two copies of test/../FileUtils.java, one uses JDK9+ features

Changes: https://git.openjdk.org/jdk8u-dev/pull/129/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=129&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8294767
  Stats: 276 lines in 1 file changed: 0 ins; 276 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/129.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/129/head:pull/129

PR: https://git.openjdk.org/jdk8u-dev/pull/129

From poonam.bajaj at oracle.com  Tue Oct  4 20:52:14 2022
From: poonam.bajaj at oracle.com (Poonam Parhar)
Date: Tue, 4 Oct 2022 20:52:14 +0000
Subject: Backport cgroups v2 to 8u
Message-ID: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>

Hello Severin, Andrew,

We, Oracle, are in the process of backporting a bunch of cgroups v2 fixes to Oracle jdk8u. We have started with backporting the following 6 issues first.

1. JDK-8230305: Cgroups v2: Container awareness
2. JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
3. JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
4. JDK-8237479: 8230305 causes slowdebug build failure
5. JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
6. JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 

I see that Jonathan Dowland has already submitted PRs to jdk8u-dev for the first 2 issues. 

I think we can collaborate our efforts here. In a few days, we will be completing our work on backporting the above fixes to Oracle jdk8u. After that, we can contribute the changes for the remaining four issues to jdk8u-dev. Please let me know your thoughts.

Thanks,
Poonam


On 9/30/22, 8:27 AM, "jdk8u-dev on behalf of Severin Gehwolf" <jdk8u-dev-retn at openjdk.org on behalf of sgehwolf at redhat.com> wrote:

    On Fri, 2022-09-30 at 16:20 +0100, Andrew Hughes wrote:
    > On 19:03 Wed 28 Sep     , Severin Gehwolf wrote:
    > 
    > snip...
    > 
    > > > 
    > > > Do you plan to target these all to one particular release, or just
    > > > when they happen to be integrated?
    > > 
    > > It'll depend on when PRs for them become available. We cannot integrate
    > > them as we go along, as most of them are interrelated or fix bugs in
    > > earlier versions. So the plan would be to integrate (the set of) them
    > > for the January 2023 or April 2023 release whichever we can make.
    > > 
    > 
    > So would it be worth doing this on a branch as we did with JFR? That
    > might be easier to setup now we're using git as well, but I don't
    > know how it would work with Skara.
    
    We didn't need one for 11u, so my hope would be that we don't need one
    for 8u.
    
    > We could also just use dependent PRs and only push everything when
    > it's all ready. That might be simpler.
    
    Yes, dependent PRs worked fine for 11. It should work for 8u as well.
    Your concern was about integration (reviews can happen at any time).
    This would be controlled by the approval labels, so we have a mechanism
    to control time of integration. That's my thinking.
    
    Thanks,
    Severin
    
    


From jdowland at openjdk.org  Wed Oct  5 08:25:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 5 Oct 2022 08:25:03 GMT
Subject: [jdk8u-dev] RFR: 8237479: 8230305 causes slowdebug build failure
 [v2]
In-Reply-To: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
References: <LK3Ng3T1W72TuQaIXXkgM8o0YBl2YRYYdxeVtO4h0Os=.c4b95dc2-20f6-4f8d-8d44-70f467b32a77@github.com>
Message-ID: <wa80Pz5O1dt9MLrvOjzSP-PpVcBGey08ZlTJUtORZTk=.950abdd0-a17b-42e6-a684-5a639eae1a30@github.com>

> This is a backport of 8237479 to jdk8u-dev, as part of cgroups v2 support. It deepnds on 8230305 (pr/127) and I've set up the GitHub PR accordingly.
> 
> Apart from path shuffling, it applies clean.

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8237479: 8230305 causes slowdebug build failure
  
  Declare methods as pure virtual.
  
  Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/128/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=128&range=01
  Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/128.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/128/head:pull/128

PR: https://git.openjdk.org/jdk8u-dev/pull/128

From jdowland at openjdk.org  Wed Oct  5 08:26:01 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 5 Oct 2022 08:26:01 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - substitute os::strerror for strerror
   
   os::strerror was introduced in 8148425 (strerror() function is not
   thread-safe), which is probably out of scope for backporting (at least
   as part of this cgroups v2 effort). Replace uses of os::strerror with
   (thread unsafe) strerror, in common with the rest of JDK8u.
 - Rework use of newer logging API to tty->print_cr
   
   Remove includes of log.hpp that doesn't exist in jdk8u
   
   log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
 - 8230305: Cgroups v2: Container awareness
   
   Implement Cgroups v2 container awareness in hotspot
   
   Reviewed-by: bobv, dholmes

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/127/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=01
  Stats: 2056 lines in 10 files changed: 1423 ins; 596 del; 37 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From sgehwolf at redhat.com  Wed Oct  5 08:33:34 2022
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Wed, 05 Oct 2022 10:33:34 +0200
Subject: Backport cgroups v2 to 8u
In-Reply-To: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
References: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
Message-ID: <f52d2f32b76e1598ddb6a906b65a0185be843270.camel@redhat.com>

Hi Poonam,

On Tue, 2022-10-04 at 20:52 +0000, Poonam Parhar wrote:
> Hello Severin, Andrew,
> 
> We, Oracle, are in the process of backporting a bunch of cgroups v2 fixes to Oracle jdk8u. We have started with backporting the following 6 issues first.
> 
> 1. JDK-8230305: Cgroups v2: Container awareness
> 2. JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
> 3. JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
> 4. JDK-8237479: 8230305 causes slowdebug build failure
> 5. JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
> 6. JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 
> 
> I see that Jonathan Dowland has already submitted PRs to jdk8u-dev
> for the first 2 issues. 
> 
> I think we can collaborate our efforts here. In a few days, we will
> be completing our work on backporting the above fixes to Oracle
> jdk8u. After that, we can contribute the changes for the remaining
> four issues to jdk8u-dev. Please let me know your thoughts.

Thanks for reaching out. We welcome contributions of course! I think 1,
2, 4 are already covered by Jon's PRs.

In order to reduce the risk of regressions in 8u, we have 22 bugs on
our list to do (in no particular order):

JDK-8284102: [TESTBUG] Retroactively add regression test for JDK-8272124
JDK-8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem     
JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics
JDK-8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
JDK-8252957: Wrong comment in CgroupV1Subsystem::cpu_quota      
JDK-8262379: Add regression test for JDK-8257746
JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly   
JDK-8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111  
JDK-8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
JDK-8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java  
JDK-8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)    
JDK-8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist  
JDK-8254001: [Metrics] Enhance parsing of cgroup interface files for version detection  
JDK-8252359: HotSpot Not Identifying it is Running in a Container
JDK-8239785: Cgroups: Incorrect detection logic on old systems in hotspot
JDK-8239559: Cgroups: Incorrect detection logic on some systems
JDK-8253939: [TESTBUG] Increase coverage of the cgroups detection code  
JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10     
JDK-8230305: Cgroups v2: Container awareness    
JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
JDK-8237479: 8230305 causes slowdebug build failure     
JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high

Feel free to help with any of those. If you do, please add a comment on
the bug so that we know who's working on what.

Thanks,
Severin


From jdowland at openjdk.org  Wed Oct  5 08:49:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 5 Oct 2022 08:49:56 GMT
Subject: [jdk8u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly
 using memory.high
Message-ID: <75Uj6o-UbuuNGx8Ju9mw7mGe3KfIxee8oWDnGrENYPg=.c3d2994f-858c-4665-ad3b-574fdb382be7@github.com>

This is a backport of a cgroupsv2 related change for jdk8u-dev.

----

The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option.

This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well.

Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/128

Commit messages:
 - 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high

Changes: https://git.openjdk.org/jdk8u-dev/pull/130/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=130&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8253714
  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/130.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/130/head:pull/130

PR: https://git.openjdk.org/jdk8u-dev/pull/130

From jdowland at redhat.com  Wed Oct  5 10:40:11 2022
From: jdowland at redhat.com (Jonathan Dowland)
Date: Wed, 5 Oct 2022 11:40:11 +0100
Subject: Backport cgroups v2 to 8u
In-Reply-To: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
References: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
Message-ID: <20221005104011.2iegyjb3kp7h5vmk@coil>

Hi Poonam,

On Tue, Oct 04, 2022 at 08:52:14PM +0000, Poonam Parhar wrote:
>We, Oracle, are in the process of backporting a bunch of cgroups v2 fixes to Oracle jdk8u.

Great to hear!

> We have started with backporting the following 6 issues first.
>
>1. JDK-8230305: Cgroups v2: Container awareness
>2. JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
>3. JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
>4. JDK-8237479: 8230305 causes slowdebug build failure
>5. JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
>6. JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

>I see that Jonathan Dowland has already submitted PRs to jdk8u-dev for the first 2 issues.

I've only just seen your mail. I've so far done 1, 2, 3, 4, but not 5
and 6.

>I think we can collaborate our efforts here. In a few days, we will be
>completing our work on backporting the above fixes to Oracle jdk8u.
>After that, we can contribute the changes for the remaining four issues
>to jdk8u-dev. Please let me know your thoughts.

Severin has shared the "hit list" of things we think should be
backported, which is largely in the order they need to happen. Please
point out if there's anything missing, or out of order.

Where possible, I've been using Skara's "dependent PR" support to chain
the PRs together: so for example pr/128 (8237479) depends upon pr/127
(8230305).

I've had to make some of the PRs artificially depend on others, in order
to flatten out multiple-dependencies: so pr/127 (8230305) depends upon
pr/121 (8231111) even though the patches do not, but that's to support
pr/130 (8253714) depending on both.

To avoid us repeating each other's work, how about we use the jdk8u
convention of labelling bugs in progress with jdk8u-<name>? E.g.
jdk8u-jdowland in my case.

I don't think any review work has started, and I haven't done heavy test
runs for any of the existing PRs yet.


Best wishes,

-- 
?? Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat


From jdowland at redhat.com  Wed Oct  5 10:50:40 2022
From: jdowland at redhat.com (Jonathan Dowland)
Date: Wed, 5 Oct 2022 11:50:40 +0100
Subject: Backport cgroups v2 to 8u
In-Reply-To: <20221005104011.2iegyjb3kp7h5vmk@coil>
References: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
 <20221005104011.2iegyjb3kp7h5vmk@coil>
Message-ID: <20221005105040.pjiswqmkf72yldga@coil>

On Wed, Oct 05, 2022 at 11:40:11AM +0100, Jonathan Dowland wrote:
>Severin has shared the "hit list" of things we think should be
>backported, which is largely in the order they need to happen. Please
>point out if there's anything missing, or out of order.

Ah Severin's list was not ordered. This is approximately the order we
think they need to be done in:

JDK-8230305: Cgroups v2: Container awareness
JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
JDK-8237479: 8230305 causes slowdebug build failure
JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
JDK-8239785: Cgroups: Incorrect detection logic on old systems in hotspot
JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
JDK-8239559: Cgroups: Incorrect detection logic on some systems
JDK-8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
JDK-8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
JDK-8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
JDK-8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
JDK-8252359: HotSpot Not Identifying it is Running in a Container
JDK-8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
JDK-8253939: [TESTBUG] Increase coverage of the cgroups detection code
JDK-8262379: Add regression test for JDK-8257746

These ones I'm not sure about ordering

JDK-8284102: [TESTBUG] Retroactively add regression test for JDK-8272124
JDK-8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics
JDK-8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
JDK-8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
JDK-8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111

And I did this one to ease one of the earlier backports, it was not
strictly necessary but resolved conflicts that would otherwise occur,
and looked like a good idea

JDK-8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems

-- 
?? Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat


From duke at openjdk.org  Wed Oct  5 15:43:53 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 5 Oct 2022 15:43:53 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for JDK8
Message-ID: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>

This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.

**Tier1 status:**

jdk_tier1
- enabled on linuxes and macos (passes there)
- disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing

langtools_tier1
- disabled everywhere
- 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])

hotspot_tier1
- disabled everywhere
- there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
- on x86 (32-bit) platforms there are few additional failures

[1] https://bugs.openjdk.org/browse/JDK-8265527
[2] https://bugs.openjdk.org/browse/JDK-8183263
[3] https://bugs.openjdk.org/browse/JDK-8226899

-------------

Commit messages:
 - Enable initial tier1 testing

Changes: https://git.openjdk.org/jdk8u-dev/pull/131/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=131&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8294863
  Stats: 484 lines in 1 file changed: 170 ins; 212 del; 102 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/131.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/131/head:pull/131

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From duke at openjdk.org  Wed Oct  5 15:59:15 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 5 Oct 2022 15:59:15 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
Message-ID: <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>

> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
> 
> **Tier1 status:**
> 
> jdk_tier1
> - enabled on linuxes and macos (passes there)
> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
> 
> langtools_tier1
> - disabled everywhere
> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
> 
> hotspot_tier1
> - disabled everywhere
> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
> - on x86 (32-bit) platforms there are few additional failures
> 
> [1] https://bugs.openjdk.org/browse/JDK-8265527
> [2] https://bugs.openjdk.org/browse/JDK-8183263
> [3] https://bugs.openjdk.org/browse/JDK-8226899

zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Enable initial tier1 testing

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/131/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/131/files/fb964499..d18b0138

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=131&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=131&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/131.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/131/head:pull/131

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From sgehwolf at openjdk.org  Wed Oct  5 16:31:21 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 5 Oct 2022 16:31:21 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
Message-ID: <MRl-XIQTv9uTcGchx7U36v1xnOni72G__tVRx0hL50Y=.a988ddcd-3b13-4619-b591-fc433446d99a@github.com>

On Wed, 5 Oct 2022 15:59:15 GMT, zzambers <duke at openjdk.org> wrote:

>> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
>> 
>> **Tier1 status:**
>> 
>> jdk_tier1
>> - enabled on linuxes and macos (passes there)
>> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
>> 
>> langtools_tier1
>> - disabled everywhere
>> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
>> 
>> hotspot_tier1
>> - disabled everywhere
>> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
>> - on x86 (32-bit) platforms there are few additional failures
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8265527
>> [2] https://bugs.openjdk.org/browse/JDK-8183263
>> [3] https://bugs.openjdk.org/browse/JDK-8226899
>
> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Enable initial tier1 testing

@zzambers Very nice! Yes, please. Could you enable GHA for this PR so that test results are visible here? At least I don't see builds being done via GHA.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From duke at openjdk.org  Wed Oct  5 16:38:33 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 5 Oct 2022 16:38:33 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <MRl-XIQTv9uTcGchx7U36v1xnOni72G__tVRx0hL50Y=.a988ddcd-3b13-4619-b591-fc433446d99a@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
 <MRl-XIQTv9uTcGchx7U36v1xnOni72G__tVRx0hL50Y=.a988ddcd-3b13-4619-b591-fc433446d99a@github.com>
Message-ID: <DHutJuSldDLTatnK496ITAEQNq_iObB7zB-w_taaSXk=.6e37cedd-9e61-4662-bd43-7dfd010ac115@github.com>

On Wed, 5 Oct 2022 16:27:51 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Enable initial tier1 testing
>
> @zzambers Very nice! Yes, please. Could you enable GHA for this PR so that test results are visible here? At least I don't see builds being done via GHA.

@jerboaa, thanks, GHA are currently running on branch, from which PR was made, in my repo. I hope, they will then show up here. (If not, I am not sure what to do to make them show up.)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From poonam.bajaj at oracle.com  Wed Oct  5 17:19:02 2022
From: poonam.bajaj at oracle.com (Poonam Parhar)
Date: Wed, 5 Oct 2022 17:19:02 +0000
Subject: [External] : Re: Backport cgroups v2 to 8u
In-Reply-To: <20221005105040.pjiswqmkf72yldga@coil>
References: <CC7C276F-DBF2-4357-A761-64AEB73832CA@oracle.com>
 <20221005104011.2iegyjb3kp7h5vmk@coil> <20221005105040.pjiswqmkf72yldga@coil>
Message-ID: <25B4AD1D-C08D-4EFE-927F-A4E5A6CB0923@oracle.com>

Hi Jonathan,

As I mentioned before, we are working on the 6 issues first in this order:

1. JDK-8230305: Cgroups v2: Container awareness
2. JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
3. JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
4. JDK-8237479: 8230305 causes slowdebug build failure
5. JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
6. JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

We will be backporting other issues after these are integrated. 

We have all of the issues that you listed below on our list except for these:
    JDK-8262379: Add regression test for JDK-8257746
    JDK-8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
    JDK-8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
    JDK-8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems

I like your suggestion of adding labels jdk8u-<name> in the bugs that we are working on. Ivan Bereziuk is working on these backports, and we will add jdk8u-ibereziuk to the bugs in progress from our side.

Thanks,
Poonam



On 10/5/22, 3:50 AM, "Jonathan Dowland" <jdowland at redhat.com> wrote:

    On Wed, Oct 05, 2022 at 11:40:11AM +0100, Jonathan Dowland wrote:
    >Severin has shared the "hit list" of things we think should be
    >backported, which is largely in the order they need to happen. Please
    >point out if there's anything missing, or out of order.
    
    Ah Severin's list was not ordered. This is approximately the order we
    think they need to be done in:
    
    JDK-8230305: Cgroups v2: Container awareness
    JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
    JDK-8237479: 8230305 causes slowdebug build failure
    JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
    JDK-8239785: Cgroups: Incorrect detection logic on old systems in hotspot
    JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly
    JDK-8239559: Cgroups: Incorrect detection logic on some systems
    JDK-8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
    JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
    JDK-8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
    JDK-8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
    JDK-8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
    JDK-8252359: HotSpot Not Identifying it is Running in a Container
    JDK-8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
    JDK-8253939: [TESTBUG] Increase coverage of the cgroups detection code
    JDK-8262379: Add regression test for JDK-8257746
    
    These ones I'm not sure about ordering
    
    JDK-8284102: [TESTBUG] Retroactively add regression test for JDK-8272124
    JDK-8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
    JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics
    JDK-8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
    JDK-8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
    JDK-8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111
    
    And I did this one to ease one of the earlier backports, it was not
    strictly necessary but resolved conflicts that would otherwise occur,
    and looked like a good idea
    
    JDK-8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems
    
    -- 
    ?? Jonathan Dowland <jdowland at redhat.com>
    Senior Software Engineer, OpenJDK, Red Hat
    
    


From duke at openjdk.org  Wed Oct  5 17:34:23 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 5 Oct 2022 17:34:23 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
Message-ID: <zQ3eV8vLxCgqBVd7-xZ5VIEzKegCLOwsgZpxsPfJr-Q=.a70afccd-5293-40ce-b348-1dfc4565a7ca@github.com>

On Wed, 5 Oct 2022 15:59:15 GMT, zzambers <duke at openjdk.org> wrote:

>> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
>> 
>> **Tier1 status:**
>> 
>> jdk_tier1
>> - enabled on linuxes and macos (passes there)
>> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
>> 
>> langtools_tier1
>> - disabled everywhere
>> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
>> 
>> hotspot_tier1
>> - disabled everywhere
>> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
>> - on x86 (32-bit) platforms there are few additional failures
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8265527
>> [2] https://bugs.openjdk.org/browse/JDK-8183263
>> [3] https://bugs.openjdk.org/browse/JDK-8226899
>
> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Enable initial tier1 testing

I think that was maybe some glitch by GH. Results were not showing up at first, later started to (somewhat randomly) appear. However now it seems they are displaying correctly.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From poonam at openjdk.org  Fri Oct  7 18:15:27 2022
From: poonam at openjdk.org (Poonam Bajaj)
Date: Fri, 7 Oct 2022 18:15:27 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
Message-ID: <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>

On Wed, 5 Oct 2022 08:26:01 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - substitute os::strerror for strerror
>    
>    os::strerror was introduced in 8148425 (strerror() function is not
>    thread-safe), which is probably out of scope for backporting (at least
>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>    (thread unsafe) strerror, in common with the rest of JDK8u.
>  - Rework use of newer logging API to tty->print_cr
>    
>    Remove includes of log.hpp that doesn't exist in jdk8u
>    
>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>  - 8230305: Cgroups v2: Container awareness
>    
>    Implement Cgroups v2 container awareness in hotspot
>    
>    Reviewed-by: bobv, dholmes

hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp line 103:

> 101:     CgroupV1Controller* _cpuset = NULL;
> 102:     CachingCgroupController* _cpu = NULL;
> 103:     CgroupV1Controller* _cpuacct = NULL;

For arm32 platform, if the c++ compiler version being used is earlier than 11, then the non-static member initialization will cause compilation failure.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From phh at openjdk.org  Fri Oct  7 18:45:34 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 7 Oct 2022 18:45:34 GMT
Subject: [jdk8u-dev] RFR: 8148005: One byte may be corrupted by
 get_datetime_string()
In-Reply-To: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
References: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
Message-ID: <zkPvWEimyVtBayKv8_PeM6Md2emhoqPZwXIzA81qcGA=.419db196-e8cc-4ae0-b0b5-5cda04a866dd@github.com>

On Thu, 11 Aug 2022 06:44:18 GMT, Nikita <duke at openjdk.org> wrote:

> The bug has been fixed in jdk9, but it wasn't backported to jdk8u.

For jdk8u process, see https://wiki.openjdk.org/display/jdk8u/Main. For later updates, see https://openjdk.org/projects/jdk-updates/approval.html. In general, you must tag the root JBS issue with, for jdk8u, a "jdk8u-fix-request" label and add a "Fix Request (8u)" comment stating the reason for the backport, testing done, whether it's "clean" (no changes required: this one is clean), and a risk assessment.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/97

From phh at openjdk.org  Fri Oct  7 18:49:33 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 7 Oct 2022 18:49:33 GMT
Subject: [jdk8u-dev] RFR: 8148005: One byte may be corrupted by
 get_datetime_string()
In-Reply-To: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
References: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
Message-ID: <FTtw0Qo35oaywoa6z98nfHYfQjP3QzFqKd2ry03r6N4=.5257413f-9277-44b3-916a-60580a44ea13@github.com>

On Thu, 11 Aug 2022 06:44:18 GMT, Nikita <duke at openjdk.org> wrote:

> The bug has been fixed in jdk9, but it wasn't backported to jdk8u.

Tagged the JBS issue.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/97

From duke at openjdk.org  Sat Oct  8 15:44:50 2022
From: duke at openjdk.org (Nikita)
Date: Sat, 8 Oct 2022 15:44:50 GMT
Subject: [jdk8u-dev] RFR: 8148005: One byte may be corrupted by
 get_datetime_string()
In-Reply-To: <FTtw0Qo35oaywoa6z98nfHYfQjP3QzFqKd2ry03r6N4=.5257413f-9277-44b3-916a-60580a44ea13@github.com>
References: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
 <FTtw0Qo35oaywoa6z98nfHYfQjP3QzFqKd2ry03r6N4=.5257413f-9277-44b3-916a-60580a44ea13@github.com>
Message-ID: <a0gJSSU0GsOnkNHcULB-hLg3fsRYXavjUQwqkoqgCxk=.54c38681-380f-4cc1-9417-d70e40b09a01@github.com>

On Fri, 7 Oct 2022 18:47:27 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> The bug has been fixed in jdk9, but it wasn't backported to jdk8u.
>
> Tagged the JBS issue.

@phohensee Thanks for your help!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/97

From serb at openjdk.org  Mon Oct 10 03:00:11 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 10 Oct 2022 03:00:11 GMT
Subject: [jdk8u-dev] RFR: 8284690: [macos] VoiceOver : Getting
 java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
Message-ID: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>

Hi all,
This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
Thanks!

-------------

Commit messages:
 - Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1

Changes: https://git.openjdk.org/jdk8u-dev/pull/132/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=132&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8284690
  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/132.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/132/head:pull/132

PR: https://git.openjdk.org/jdk8u-dev/pull/132

From sgehwolf at openjdk.org  Tue Oct 11 09:01:41 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 11 Oct 2022 09:01:41 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
Message-ID: <umdb3RcAOFnpTxFYG6Wyd1iM3QS44chA51RTC3-FsTE=.be08bddc-9bb0-400c-8125-4f38aebd41a5@github.com>

On Tue, 23 Aug 2022 12:47:26 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
> 
> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
> 
> Regression: hotspot/test/runtime

@rwestrel Could you please review this? Does that look OK to you for 8u inclusion?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From sgehwolf at openjdk.org  Tue Oct 11 09:08:44 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 11 Oct 2022 09:08:44 GMT
Subject: [jdk8u-dev] RFR: 8269850: Most JDK releases report macOS version
 12 as 10.16 instead of 12.0
In-Reply-To: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
References: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
Message-ID: <q8bBiud69RGodvStRKjxkhBxMl54pvjoEGY06ns21aU=.7a9693bb-b235-4fea-8fd3-a88e2f4f14f8@github.com>

On Fri, 30 Sep 2022 20:45:54 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I'd like to backport JDK-8269850 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> src/java.base/macosx/native/libjava/java_props_macosx.c (source)
> jdk/src/solaris/native/java/lang/java_props_macosx.c (destination)
> But it's small and low risk. The changes are related only to one function void setOSNameAndVersion(..) within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Monterey:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

Path changes only can be marked as clean.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/126

From sgehwolf at openjdk.org  Tue Oct 11 09:10:43 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 11 Oct 2022 09:10:43 GMT
Subject: [jdk8u-dev] RFR: 8253702: BigSur version number reported as 10.16, 
 should be 11.nn [v2]
In-Reply-To: <XIqdG5Q-umIKdvMdKGfzRSqTh0sQ-rUMbCQaJhIlepg=.40c8b394-a392-4389-a4c3-38dac4250252@github.com>
References: <ovyCMptqYNfmQ61OeCrvby_0htvqXySZ0JVu6qvd5dU=.0f0e8a5c-058b-4b3f-a3a0-acd56972c103@github.com>
 <XIqdG5Q-umIKdvMdKGfzRSqTh0sQ-rUMbCQaJhIlepg=.40c8b394-a392-4389-a4c3-38dac4250252@github.com>
Message-ID: <RaQjB_LfGNV-XxBnAbnRpSdiShPMkJur8jMqbECZbso=.7641718e-61f5-4cd8-92db-35e74225266a@github.com>

On Fri, 30 Sep 2022 14:23:28 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

>> I'd like to backport JDK-8253702 to jdk8u in order to fix the incorrect version detection for macOS.
>> 
>> The patch applied manually due to the location difference:
>> `src/java.base/macosx/native/libjava/java_props_macosx.c` (source)
>> `jdk/src/solaris/native/java/lang/java_props_macosx.c` (destination)
>> But it's small and low risk. The changes are related only to one function `void setOSNameAndVersion(..)` within the single file. The patch is identical to the original one.
>> 
>> Tested with a simple test printing the OS version on macOS Big Sur:
>> 
>> public class Main {
>>     public static void main(String[] args) {
>>         System.out.println(System.getProperty("os.version"));
>>     }
>> }
>
> Olga Mikhaltsova has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit:
> 
>   Backport 66757750a2adf0739d0f5bf98a3f50a123b7adcf

Path changes only, marking as clean.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/125

From sgehwolf at openjdk.org  Tue Oct 11 09:22:09 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 11 Oct 2022 09:22:09 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable initial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
Message-ID: <7JnPhIXufZq9Ge9MJDJFDejkYBmiQ20C6gNnHE7DEKo=.fbc2dcdc-2020-4115-9ea4-983e1245e0c9@github.com>

On Wed, 5 Oct 2022 15:59:15 GMT, zzambers <duke at openjdk.org> wrote:

>> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
>> 
>> **Tier1 status:**
>> 
>> jdk_tier1
>> - enabled on linuxes and macos (passes there)
>> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
>> 
>> langtools_tier1
>> - disabled everywhere
>> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
>> 
>> hotspot_tier1
>> - disabled everywhere
>> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
>> - on x86 (32-bit) platforms there are few additional failures
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8265527
>> [2] https://bugs.openjdk.org/browse/JDK-8183263
>> [3] https://bugs.openjdk.org/browse/JDK-8226899
>
> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Enable initial tier1 testing

Thanks! This is an improvement to the current status quo (no tests via GHA). No risk for product code as it's only changing `.github` directory files. Looking forward to getting more tests enabled.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From duke at openjdk.org  Tue Oct 11 11:27:46 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 11 Oct 2022 11:27:46 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable partial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <MRl-XIQTv9uTcGchx7U36v1xnOni72G__tVRx0hL50Y=.a988ddcd-3b13-4619-b591-fc433446d99a@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
 <MRl-XIQTv9uTcGchx7U36v1xnOni72G__tVRx0hL50Y=.a988ddcd-3b13-4619-b591-fc433446d99a@github.com>
Message-ID: <XeMlUyCrNp7V2OXLFzWeWXRSJcU7R8NbgXZGUdfoH2E=.18af627f-aee0-48b3-a510-6cf571009b4d@github.com>

On Wed, 5 Oct 2022 16:27:51 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Enable initial tier1 testing
>
> @zzambers Very nice! Yes, please. Could you enable GHA for this PR so that test results are visible here? At least I don't see builds being done via GHA.

@jerboaa thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From duke at openjdk.org  Tue Oct 11 12:17:18 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 11 Oct 2022 12:17:18 GMT
Subject: [jdk8u-dev] Integrated: 8294863: Enable partial tier1 testing in GHA
 for JDK8
In-Reply-To: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
Message-ID: <rhLjC7W0UK9aGi-hIv8eIX5iz4y4VCZPmb0-TPma_Xw=.431ce943-af6d-4f12-8a19-7372092ee8be@github.com>

On Wed, 5 Oct 2022 15:36:47 GMT, zzambers <duke at openjdk.org> wrote:

> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
> 
> **Tier1 status:**
> 
> jdk_tier1
> - enabled on linuxes and macos (passes there)
> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
> 
> langtools_tier1
> - disabled everywhere
> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
> 
> hotspot_tier1
> - disabled everywhere
> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
> - on x86 (32-bit) platforms there are few additional failures
> 
> [1] https://bugs.openjdk.org/browse/JDK-8265527
> [2] https://bugs.openjdk.org/browse/JDK-8183263
> [3] https://bugs.openjdk.org/browse/JDK-8226899

This pull request has now been integrated.

Changeset: a93344b2
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a93344b27d4b3df6cbca7185bcfca1410b51a984
Stats:     488 lines in 1 file changed: 170 ins; 217 del; 101 mod

8294863: Enable partial tier1 testing in GHA for JDK8

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From phh at openjdk.org  Tue Oct 11 12:26:27 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 11 Oct 2022 12:26:27 GMT
Subject: [jdk8u-dev] RFR: 8148005: One byte may be corrupted by
 get_datetime_string()
In-Reply-To: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
References: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
Message-ID: <pMQXrMO0i8hPvix-AzkI7JjTD91Hi2fXYcqkmu4Ncdc=.06d83690-6f23-43e6-92c0-d2844fcd6bbe@github.com>

On Thu, 11 Aug 2022 06:44:18 GMT, Nikita <duke at openjdk.org> wrote:

> The bug has been fixed in jdk9, but it wasn't backported to jdk8u.

Backport approved, please add a "/integrate" comment.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/97

From duke at openjdk.org  Tue Oct 11 14:18:32 2022
From: duke at openjdk.org (Nikita)
Date: Tue, 11 Oct 2022 14:18:32 GMT
Subject: [jdk8u-dev] Integrated: 8148005: One byte may be corrupted by
 get_datetime_string()
In-Reply-To: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
References: <xjOEd9784MXsEfOSUJ7GYL7-SR4l79EHduKjATePqfI=.4359280b-344b-4773-b9da-70c9ab68df18@github.com>
Message-ID: <x_1bvSM-5vDTkxLuSCkkvIVRYj_mIM0DwFeYIK1AqZQ=.29471531-815d-4424-9ef4-37b28665ba24@github.com>

On Thu, 11 Aug 2022 06:44:18 GMT, Nikita <duke at openjdk.org> wrote:

> The bug has been fixed in jdk9, but it wasn't backported to jdk8u.

This pull request has now been integrated.

Changeset: 859c057c
Author:    Nikita Ivanov <nivanov at cloudlinux.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/859c057c87ad15920c28f495094f8de6953b2e99
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8148005: One byte may be corrupted by get_datetime_string()

Reviewed-by: phh
Backport-of: 395a248587b5bd16c3e61c4cefb73799ade0af95

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/97

From duke at openjdk.org  Tue Oct 11 15:12:21 2022
From: duke at openjdk.org (Joshua Cao)
Date: Tue, 11 Oct 2022 15:12:21 GMT
Subject: [jdk8u-dev] Integrated: 8274563:
 jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not
 happening
In-Reply-To: <zxP0XepYAY_9_2OZYyWRbtqi1b61tpviTYmTVFBEmH4=.34f93c1b-08b7-4254-8664-a587d546ee00@github.com>
References: <zxP0XepYAY_9_2OZYyWRbtqi1b61tpviTYmTVFBEmH4=.34f93c1b-08b7-4254-8664-a587d546ee00@github.com>
Message-ID: <q4Ap0BdoWIbm-dyENbRslxScCV5bDwR47Lga0UTBVTg=.91ba70d4-8401-4903-8e96-43cb274a4294@github.com>

On Wed, 21 Sep 2022 06:08:28 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Not a clean backport. This change does not need to remove this line because it does not exist:
> 
> 
> * @requires vm.gc != "Serial"
> 
> 
> passing tests on my local machine. I've seen reports that max heap size needs to be decreased further for more consistent tests on other machines, so we should also backport https://bugs.openjdk.org/browse/JDK-8293828 after this.

This pull request has now been integrated.

Changeset: 4a25b00a
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4a25b00aba29dd45529be805c4ec135f20228d80
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewed-by: phh
Backport-of: 47bfc8aa9367ff852ea5d901f1fa3c6ef316913e

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/120

From roland at openjdk.org  Tue Oct 11 15:43:42 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Tue, 11 Oct 2022 15:43:42 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
Message-ID: <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>

On Tue, 23 Aug 2022 12:47:26 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
> 
> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
> 
> Regression: hotspot/test/runtime

That looks good to me. Why not include the test case?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From roland at openjdk.org  Tue Oct 11 15:43:42 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Tue, 11 Oct 2022 15:43:42 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
 <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>
Message-ID: <uwaxupvZ_y7DJwpSDR_lZ3FATOOQxGI17tizidO8kRA=.173ffb49-fa46-4db5-96d6-a46207f48bf2@github.com>

On Tue, 11 Oct 2022 15:38:08 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Hi!
>> 
>> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
>> 
>> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
>> 
>> Regression: hotspot/test/runtime
>
> That looks good to me. Why not include the test case?

> @rwestrel Could you please review this? Does that look OK to you for 8u inclusion?

@jerboaa backporting this is reasonable I think.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From sgehwolf at openjdk.org  Tue Oct 11 15:43:43 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 11 Oct 2022 15:43:43 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <umdb3RcAOFnpTxFYG6Wyd1iM3QS44chA51RTC3-FsTE=.be08bddc-9bb0-400c-8125-4f38aebd41a5@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
 <umdb3RcAOFnpTxFYG6Wyd1iM3QS44chA51RTC3-FsTE=.be08bddc-9bb0-400c-8125-4f38aebd41a5@github.com>
Message-ID: <UV73jkaybOqMYpgaTjFL6wu4ZCBgESYf_QOs-UFpAOU=.57c6ce68-7213-4321-91f8-37db747dd289@github.com>

On Tue, 11 Oct 2022 08:59:13 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi!
>> 
>> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
>> 
>> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
>> 
>> Regression: hotspot/test/runtime
>
> @rwestrel Could you please review this? Does that look OK to you for 8u inclusion?

> @jerboaa backporting this is reasonable I think.

Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From duke at openjdk.org  Tue Oct 11 16:12:10 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 11 Oct 2022 16:12:10 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK8 jdi tests should not use tasklist
 command on Windows
Message-ID: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>

Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.

**Problem:**
Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].

**Solution:**
Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)

**Testing:**
With this fix jdk_tier1 passes for me on Windows.

[1] https://github.com/msys2/MSYS2-packages/issues/1724
[2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
[3] https://www.cygwin.com/cygwin-ug-net/ps.html
[4] https://bugs.openjdk.org/browse/JDK-8209109
[5] https://bugs.openjdk.org/browse/JDK-8209604
[6] https://bugs.openjdk.org/browse/JDK-8210243
[7] https://bugs.openjdk.org/browse/JDK-8210760

-------------

Commit messages:
 - ShellScaffold.sh should not use tasklist on windows

Changes: https://git.openjdk.org/jdk8u-dev/pull/133/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=133&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295164
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/133.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/133/head:pull/133

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Tue Oct 11 17:27:14 2022
From: duke at openjdk.org (Joshua Cao)
Date: Tue, 11 Oct 2022 17:27:14 GMT
Subject: [jdk8u-dev] RFR: 8159599: [TEST_BUG]
 java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
Message-ID: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>

Backport for parity with Oracle.

Backport does not apply to ProblemList.txt because the affected test is not there in JDK8. Cleanly applies to SimpleWindowActivationTest.java after fixing paths.

-------------

Commit messages:
 - 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Changes: https://git.openjdk.org/jdk8u-dev/pull/134/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=134&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8159599
  Stats: 22 lines in 1 file changed: 13 ins; 2 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/134.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/134/head:pull/134

PR: https://git.openjdk.org/jdk8u-dev/pull/134

From vrudomet at openjdk.org  Tue Oct 11 17:35:21 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 11 Oct 2022 17:35:21 GMT
Subject: [jdk8u-dev] RFR: 8293828: JFR:
 jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are
 not happening [v2]
In-Reply-To: <hstr0KxbUffcGDOybZ1R4aYeRBlUBxmXSzAZ5UkaX_g=.1d505608-9a90-4705-be71-479a556ef3f9@github.com>
References: <hstr0KxbUffcGDOybZ1R4aYeRBlUBxmXSzAZ5UkaX_g=.1d505608-9a90-4705-be71-479a556ef3f9@github.com>
Message-ID: <MejTLHOjpeoAN9bH8Z6ixERb-FVQjI-SRAXacZ6MmyI=.610f9fa0-33ad-4680-9353-5b518aa822e4@github.com>

> Backport for JDK-8293828

Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge branch 'master' into Backport-JDK-8293828
 - Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/122/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=122&range=01
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/122.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/122/head:pull/122

PR: https://git.openjdk.org/jdk8u-dev/pull/122

From phh at openjdk.org  Tue Oct 11 19:35:16 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 11 Oct 2022 19:35:16 GMT
Subject: [jdk8u-dev] RFR: 8159599: [TEST_BUG]
 java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
In-Reply-To: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
References: <tPu5A5icjy5Wiu15fhHApTpjteWmhMSm2dryEVdZ5IE=.8323a737-c5d1-4731-8ea6-6f4c5015c199@github.com>
Message-ID: <9DFspaoz8kaJ7bovBYYjWACBpgIZEpGIaj3RFPbTAEA=.7794cb6d-0778-4ea7-943f-bdd2b264116b@github.com>

On Tue, 11 Oct 2022 17:19:59 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Backport for parity with Oracle.
> 
> Backport does not apply to ProblemList.txt because the affected test is not there in JDK8. Cleanly applies to SimpleWindowActivationTest.java after fixing paths.

Lgtm.

JBS issue tagged.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/134

From vrudomet at openjdk.org  Tue Oct 11 19:55:46 2022
From: vrudomet at openjdk.org (Victor Rudometov)
Date: Tue, 11 Oct 2022 19:55:46 GMT
Subject: [jdk8u-dev] Integrated: 8293828: JFR:
 jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are
 not happening
In-Reply-To: <hstr0KxbUffcGDOybZ1R4aYeRBlUBxmXSzAZ5UkaX_g=.1d505608-9a90-4705-be71-479a556ef3f9@github.com>
References: <hstr0KxbUffcGDOybZ1R4aYeRBlUBxmXSzAZ5UkaX_g=.1d505608-9a90-4705-be71-479a556ef3f9@github.com>
Message-ID: <H6H6LIzvfZcuIHvV3VSBB8hkz2maPYRZavMJJaD4d4w=.5a6f55d6-15ba-4a82-9b69-1e89a963d2f0@github.com>

On Wed, 21 Sep 2022 20:25:58 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

> Backport for JDK-8293828

This pull request has now been integrated.

Changeset: 861ac32e
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/861ac32e43a425b682d18a2cc748a8b82435148f
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewed-by: phh
Backport-of: 5002eaa5cc7301b91a45f8c0f65b5943fea225d8

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/122

From jdowland at openjdk.org  Wed Oct 12 10:26:48 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 12 Oct 2022 10:26:48 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old
 systems in hotspot
Message-ID: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>

This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.

It does not apply clean:

 * context issues for changes made for the different approach for logging in 8u
 * copyright lines

Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/130

Commit messages:
 - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot

Changes: https://git.openjdk.org/jdk8u-dev/pull/135/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8239785
  Stats: 707 lines in 6 files changed: 534 ins; 100 del; 73 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From jdowland at openjdk.org  Wed Oct 12 10:37:24 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Wed, 12 Oct 2022 10:37:24 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>
Message-ID: <dwhqhEGC5VLBGESVdDZXrw83Dadmc74x6ipKtaUO7JA=.e21e4615-d06e-49b3-a7e1-55f7e2cbd315@github.com>

On Fri, 7 Oct 2022 18:11:14 GMT, Poonam Bajaj <poonam at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - substitute os::strerror for strerror
>>    
>>    os::strerror was introduced in 8148425 (strerror() function is not
>>    thread-safe), which is probably out of scope for backporting (at least
>>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>>    (thread unsafe) strerror, in common with the rest of JDK8u.
>>  - Rework use of newer logging API to tty->print_cr
>>    
>>    Remove includes of log.hpp that doesn't exist in jdk8u
>>    
>>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>>  - 8230305: Cgroups v2: Container awareness
>>    
>>    Implement Cgroups v2 container awareness in hotspot
>>    
>>    Reviewed-by: bobv, dholmes
>
> hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp line 103:
> 
>> 101:     CgroupV1Controller* _cpuset = NULL;
>> 102:     CachingCgroupController* _cpu = NULL;
>> 103:     CgroupV1Controller* _cpuacct = NULL;
> 
> For arm32 platform, if the c++ compiler version being used is earlier than 11, then the non-static member initialization will cause compilation failure.

Thanks for pointing this out! I'll investigate how to best address that in this patch series.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From sgehwolf at openjdk.org  Wed Oct 12 16:27:15 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 12 Oct 2022 16:27:15 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK8 jdi tests should not use tasklist
 command on Windows
In-Reply-To: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
Message-ID: <LmRo2qdmCnag650_k5xQAAcc8KDqbKboi4YVO_6czEE=.fd5c7a86-cd53-4c01-bcb0-a56b0f58f1b6@github.com>

On Tue, 11 Oct 2022 16:03:40 GMT, zzambers <duke at openjdk.org> wrote:

> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
> 
> **Problem:**
> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
> 
> **Solution:**
> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
> 
> **Testing:**
> With this fix jdk_tier1 passes for me on Windows.
> 
> [1] https://github.com/msys2/MSYS2-packages/issues/1724
> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
> [4] https://bugs.openjdk.org/browse/JDK-8209109
> [5] https://bugs.openjdk.org/browse/JDK-8209604
> [6] https://bugs.openjdk.org/browse/JDK-8210243
> [7] https://bugs.openjdk.org/browse/JDK-8210760

@zzambers Shouldn't this also enable windows tier1 tests on GHA?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Wed Oct 12 16:32:32 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 12 Oct 2022 16:32:32 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK8 jdi tests should not use tasklist
 command on Windows
In-Reply-To: <LmRo2qdmCnag650_k5xQAAcc8KDqbKboi4YVO_6czEE=.fd5c7a86-cd53-4c01-bcb0-a56b0f58f1b6@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <LmRo2qdmCnag650_k5xQAAcc8KDqbKboi4YVO_6czEE=.fd5c7a86-cd53-4c01-bcb0-a56b0f58f1b6@github.com>
Message-ID: <fe8Sjzc06AWsTQek-A5hpQKBAUCDXR1zeQoOotqFkpA=.c286911f-935a-4a7f-aafb-d99e8844edda@github.com>

On Wed, 12 Oct 2022 16:23:22 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
>> 
>> **Problem:**
>> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
>> 
>> **Solution:**
>> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
>> 
>> **Testing:**
>> With this fix jdk_tier1 passes for me on Windows.
>> 
>> [1] https://github.com/msys2/MSYS2-packages/issues/1724
>> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
>> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
>> [4] https://bugs.openjdk.org/browse/JDK-8209109
>> [5] https://bugs.openjdk.org/browse/JDK-8209604
>> [6] https://bugs.openjdk.org/browse/JDK-8210243
>> [7] https://bugs.openjdk.org/browse/JDK-8210760
>
> @zzambers Shouldn't this also enable windows tier1 tests on GHA?

@jerboaa, I planned to do separate PR to enable windows jdk_tier1 in GHA. Should I add it to this PR?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From sgehwolf at openjdk.org  Wed Oct 12 17:25:17 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 12 Oct 2022 17:25:17 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK8 jdi tests should not use tasklist
 command on Windows
In-Reply-To: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
Message-ID: <5Bvh2hjgqvKUKW9gV1LDkew9xrcL-fGqrQltyffabyk=.fb8745dd-e4b3-427c-a32d-83ac4efcaedc@github.com>

On Tue, 11 Oct 2022 16:03:40 GMT, zzambers <duke at openjdk.org> wrote:

> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
> 
> **Problem:**
> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
> 
> **Solution:**
> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
> 
> **Testing:**
> With this fix jdk_tier1 passes for me on Windows.
> 
> [1] https://github.com/msys2/MSYS2-packages/issues/1724
> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
> [4] https://bugs.openjdk.org/browse/JDK-8209109
> [5] https://bugs.openjdk.org/browse/JDK-8209604
> [6] https://bugs.openjdk.org/browse/JDK-8210243
> [7] https://bugs.openjdk.org/browse/JDK-8210760

It would make sense to add it here, since it would show what you say (i.e. that it's passing now)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Wed Oct 12 18:54:17 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 12 Oct 2022 18:54:17 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
Message-ID: <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>

> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
> 
> **Problem:**
> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
> 
> **Solution:**
> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
> 
> **Testing:**
> With this fix jdk_tier1 passes for me on Windows.
> 
> [1] https://github.com/msys2/MSYS2-packages/issues/1724
> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
> [4] https://bugs.openjdk.org/browse/JDK-8209109
> [5] https://bugs.openjdk.org/browse/JDK-8209604
> [6] https://bugs.openjdk.org/browse/JDK-8210243
> [7] https://bugs.openjdk.org/browse/JDK-8210760

zzambers has updated the pull request incrementally with one additional commit since the last revision:

  Enable jdk_tier1 testing on Windows in GHA

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/133/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/133/files/a6328edc..959a2f3d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=133&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=133&range=00-01

  Stats: 14 lines in 1 file changed: 0 ins; 2 del; 12 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/133.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/133/head:pull/133

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Wed Oct 12 21:39:17 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 12 Oct 2022 21:39:17 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
Message-ID: <A5gVaQI2lEvGRxGyJEH_8NH8_jSIC7yP6Cfbaj8O3kc=.1cb08dce-171e-4dbb-9c12-21945624416c@github.com>

On Wed, 12 Oct 2022 18:54:17 GMT, zzambers <duke at openjdk.org> wrote:

>> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
>> 
>> **Problem:**
>> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
>> 
>> **Solution:**
>> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
>> 
>> **Testing:**
>> With this fix jdk_tier1 passes for me on Windows.
>> 
>> [1] https://github.com/msys2/MSYS2-packages/issues/1724
>> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
>> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
>> [4] https://bugs.openjdk.org/browse/JDK-8209109
>> [5] https://bugs.openjdk.org/browse/JDK-8209604
>> [6] https://bugs.openjdk.org/browse/JDK-8210243
>> [7] https://bugs.openjdk.org/browse/JDK-8210760
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable jdk_tier1 testing on Windows in GHA

Interesting, one test failed on Windows x64. I have not seen this failure before (when testing this change).

TEST: com/sun/jdi/DoubleAgentTest.java

java.lang.Exception: Debuggee does not have ERROR in the output: EError occurred during initialization of VM
agent library failed to initRROR: Cannot load this JVM TI agent twice, check your java command line for duplicate jdwp options.
: jdwp

	at DoubleAgentTest.main(DoubleAgentTest.java:146)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
	at java.lang.Thread.run(Thread.java:750)

JavaTest Message: Test threw exception: java.lang.Exception
JavaTest Message: shutting down test


It is failure of jdi test, but not shell one, and it does not seem related to bug being fixed by this PR. Looks like output got interleaved as result of race condition. Actually this is most probably result of bad design of that particular test, where stdout and stderr are being concurrently collected into single string field named "outputText" [1]. Seems like word "ERROR" got split by text from the other stream, resulting in test failure [2]. Bad luck that "ERROR" word get split :) , but test should definitely be fixed (I'll look at that later).

[1] https://github.com/openjdk/jdk8u-dev/blob/861ac32e43a425b682d18a2cc748a8b82435148f/jdk/test/com/sun/jdi/DoubleAgentTest.java#L78
[2] https://github.com/openjdk/jdk8u-dev/blob/861ac32e43a425b682d18a2cc748a8b82435148f/jdk/test/com/sun/jdi/DoubleAgentTest.java#L145

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Wed Oct 12 22:13:11 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 12 Oct 2022 22:13:11 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
Message-ID: <hOYBz3_JluvoC2upqfE6hmrMyn9ioImIgAoDvBS4XuM=.63db8a1f-a5c7-48f6-ae18-d0627cc0efaf@github.com>

On Wed, 12 Oct 2022 18:54:17 GMT, zzambers <duke at openjdk.org> wrote:

>> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
>> 
>> **Problem:**
>> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
>> 
>> **Solution:**
>> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
>> 
>> **Testing:**
>> With this fix jdk_tier1 passes for me on Windows.
>> 
>> [1] https://github.com/msys2/MSYS2-packages/issues/1724
>> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
>> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
>> [4] https://bugs.openjdk.org/browse/JDK-8209109
>> [5] https://bugs.openjdk.org/browse/JDK-8209604
>> [6] https://bugs.openjdk.org/browse/JDK-8210243
>> [7] https://bugs.openjdk.org/browse/JDK-8210760
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable jdk_tier1 testing on Windows in GHA

I'll try to reschedule tests to see, what happens.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Wed Oct 12 23:42:20 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 12 Oct 2022 23:42:20 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
Message-ID: <neP-fzmYFj5U5vryS5zBfBhKoKY5EwqV7iSx0Lr0mQ0=.e845aee4-debc-4965-81e0-f70d8414bfcb@github.com>

On Wed, 12 Oct 2022 18:54:17 GMT, zzambers <duke at openjdk.org> wrote:

>> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
>> 
>> **Problem:**
>> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
>> 
>> **Solution:**
>> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
>> 
>> **Testing:**
>> With this fix jdk_tier1 passes for me on Windows.
>> 
>> [1] https://github.com/msys2/MSYS2-packages/issues/1724
>> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
>> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
>> [4] https://bugs.openjdk.org/browse/JDK-8209109
>> [5] https://bugs.openjdk.org/browse/JDK-8209604
>> [6] https://bugs.openjdk.org/browse/JDK-8210243
>> [7] https://bugs.openjdk.org/browse/JDK-8210760
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable jdk_tier1 testing on Windows in GHA

Ok, all tests passed this time. I'll keep this PR as it is and deal with that racy sporadically failing test in another PR.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From sgehwolf at openjdk.org  Thu Oct 13 08:32:15 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 13 Oct 2022 08:32:15 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
Message-ID: <wP5ONjyZ0Q4oYLlhYnCsADl8HeSffcRZumA4LgNvA1M=.a69f9f40-5354-4430-8099-d02c49f48356@github.com>

On Wed, 12 Oct 2022 18:54:17 GMT, zzambers <duke at openjdk.org> wrote:

>> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
>> 
>> **Problem:**
>> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
>> 
>> **Solution:**
>> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
>> 
>> **Testing:**
>> With this fix jdk_tier1 passes for me on Windows.
>> 
>> [1] https://github.com/msys2/MSYS2-packages/issues/1724
>> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
>> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
>> [4] https://bugs.openjdk.org/browse/JDK-8209109
>> [5] https://bugs.openjdk.org/browse/JDK-8209604
>> [6] https://bugs.openjdk.org/browse/JDK-8210243
>> [7] https://bugs.openjdk.org/browse/JDK-8210760
>
> zzambers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable jdk_tier1 testing on Windows in GHA

This looks fine to me. Thanks for doing this.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From jdowland at openjdk.org  Thu Oct 13 08:45:34 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 13 Oct 2022 08:45:34 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v2]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <JA9Wgn0BKBGM2LX5CiY6kKu2l6ezALdmx3Jg8f8DKFw=.634f184d-1e52-4943-908d-b2bfd91a896c@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  remove duplicate include of osContainer_linux
  
  With the backport of 8189762, the include of osContainer_linux was
  moved to a later #ifdef stanza, relative to the original. This caused
  a context problem with this backport.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/135/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/135/files/755b5319..880244fd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Thu Oct 13 08:54:13 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 13 Oct 2022 08:54:13 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <neP-fzmYFj5U5vryS5zBfBhKoKY5EwqV7iSx0Lr0mQ0=.e845aee4-debc-4965-81e0-f70d8414bfcb@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
 <neP-fzmYFj5U5vryS5zBfBhKoKY5EwqV7iSx0Lr0mQ0=.e845aee4-debc-4965-81e0-f70d8414bfcb@github.com>
Message-ID: <HJdCYiCzvbD2LpVsn4tDxgCHqwGH-gdUrG8yB4OfZWc=.25e9c51a-98a3-46c7-82ad-5559449714e0@github.com>

On Wed, 12 Oct 2022 23:39:49 GMT, zzambers <duke at openjdk.org> wrote:

>> zzambers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Enable jdk_tier1 testing on Windows in GHA
>
> Ok, all tests passed this time. I'll keep this PR as it is and deal with that racy sporadically failing test in another PR.

@zzambers Please add the summary. Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From jdowland at openjdk.org  Thu Oct 13 09:41:56 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 13 Oct 2022 09:41:56 GMT
Subject: [jdk8u-dev] RFR: 8239559: Cgroups: Incorrect detection logic on some
 systems
Message-ID: <d-njuxGCtdWmSl-srUe0SX5EietRiA5Hdl9ZGso5FWI=.4bcb4972-30e1-4fc8-b9d7-4a5bbee6f0bf@github.com>

This is a backport of 53ee0c4963007b86db7979312b81f990e6ce271a via the 11u backport 53ee0c4963007b86db7979312b81f990e6ce271a for cgroups v2 support in jdk8u-dev.

It isn't clean: context differences in CgroupSubsystemFactory.java around the use of post-8u logging in the original patch.

I also had to Optional.isEmpty which is not present in 8u's Optional.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/135

Commit messages:
 - replace post-jdk8u Optional.isEmpty
 - 8239559: Cgroups: Incorrect detection logic on some systems

Changes: https://git.openjdk.org/jdk8u-dev/pull/136/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=136&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8239559
  Stats: 292 lines in 2 files changed: 263 ins; 21 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/136/head:pull/136

PR: https://git.openjdk.org/jdk8u-dev/pull/136

From omikhaltcova at openjdk.org  Thu Oct 13 10:02:18 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Thu, 13 Oct 2022 10:02:18 GMT
Subject: [jdk8u-dev] Integrated: 8253702: BigSur version number reported as
 10.16, should be 11.nn
In-Reply-To: <ovyCMptqYNfmQ61OeCrvby_0htvqXySZ0JVu6qvd5dU=.0f0e8a5c-058b-4b3f-a3a0-acd56972c103@github.com>
References: <ovyCMptqYNfmQ61OeCrvby_0htvqXySZ0JVu6qvd5dU=.0f0e8a5c-058b-4b3f-a3a0-acd56972c103@github.com>
Message-ID: <KU3AIruC_z971O9vSW0dBFNZJKuzWRW0u-J3r6TtIm8=.c65f7e39-a973-4a7f-a6a0-13fc5e995e02@github.com>

On Thu, 29 Sep 2022 13:42:15 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I'd like to backport JDK-8253702 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> `src/java.base/macosx/native/libjava/java_props_macosx.c` (source)
> `jdk/src/solaris/native/java/lang/java_props_macosx.c` (destination)
> But it's small and low risk. The changes are related only to one function `void setOSNameAndVersion(..)` within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Big Sur:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

This pull request has now been integrated.

Changeset: 05b249d6
Author:    Olga Mikhaltsova <omikhaltcova at openjdk.org>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/05b249d61aac56c1d4bb346649b6cb8d157deaef
Stats:     30 lines in 1 file changed: 22 ins; 2 del; 6 mod

8253702: BigSur version number reported as 10.16, should be 11.nn

Backport-of: 66757750a2adf0739d0f5bf98a3f50a123b7adcf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/125

From omikhaltcova at openjdk.org  Thu Oct 13 10:09:13 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Thu, 13 Oct 2022 10:09:13 GMT
Subject: [jdk8u-dev] RFR: 8269850: Most JDK releases report macOS version
 12 as 10.16 instead of 12.0 [v2]
In-Reply-To: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
References: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
Message-ID: <s3NJrL6oEndAUi8nBTm0HYCfhSS1Bb72wGYUCnBNyoo=.5767e80e-dafe-4bf3-964d-69522a7df33b@github.com>

> I'd like to backport JDK-8269850 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> src/java.base/macosx/native/libjava/java_props_macosx.c (source)
> jdk/src/solaris/native/java/lang/java_props_macosx.c (destination)
> But it's small and low risk. The changes are related only to one function void setOSNameAndVersion(..) within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Monterey:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

Olga Mikhaltsova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/126/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/126/files/275e333b..275e333b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/126.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/126/head:pull/126

PR: https://git.openjdk.org/jdk8u-dev/pull/126

From duke at openjdk.org  Thu Oct 13 11:21:15 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 13 Oct 2022 11:21:15 GMT
Subject: [jdk8u-dev] RFR: 8295164: JDK 8 jdi tests should not use tasklist
 command on Windows [v2]
In-Reply-To: <HJdCYiCzvbD2LpVsn4tDxgCHqwGH-gdUrG8yB4OfZWc=.25e9c51a-98a3-46c7-82ad-5559449714e0@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
 <QJv2hWQ_ugIN1MMEJ2oh_Y9aIna6N2iE0Yb10ZXW4f0=.de964fe1-39c2-44e3-a433-8ea62e32a15f@github.com>
 <neP-fzmYFj5U5vryS5zBfBhKoKY5EwqV7iSx0Lr0mQ0=.e845aee4-debc-4965-81e0-f70d8414bfcb@github.com>
 <HJdCYiCzvbD2LpVsn4tDxgCHqwGH-gdUrG8yB4OfZWc=.25e9c51a-98a3-46c7-82ad-5559449714e0@github.com>
Message-ID: <EuJDTKEFKOJrXfjZcBZtS1Blzgr_09ZeS9QnXaoCKJw=.f5dcccba-1b83-474b-b277-846ee0056d29@github.com>

On Thu, 13 Oct 2022 08:51:54 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Ok, all tests passed this time. I'll keep this PR as it is and deal with that racy sporadically failing test in another PR.
>
> @zzambers Please add the summary. Thanks!

@jerboaa Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From duke at openjdk.org  Thu Oct 13 12:13:19 2022
From: duke at openjdk.org (zzambers)
Date: Thu, 13 Oct 2022 12:13:19 GMT
Subject: [jdk8u-dev] Integrated: 8295164: JDK 8 jdi tests should not use
 tasklist command on Windows
In-Reply-To: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
References: <uJFWQi_4bx-kOvzr7SFvN4ZjY7obPXhh4daFYXQrPXs=.329f7c54-e908-42f9-b341-7618d28065ca@github.com>
Message-ID: <CTj_WW6VtQ3hv-BsAO-vwodZT7v-WkBjbiHyln_fHEM=.a9a570ac-ad11-48d7-82f8-a22260cddb6e@github.com>

On Tue, 11 Oct 2022 16:03:40 GMT, zzambers <duke at openjdk.org> wrote:

> Shell jdi tests are currently failing on windows. These tests are part of jdk_tier1.
> 
> **Problem:**
> Tests fail because ShellScaffold.sh uses (native) tasklist command to check if process with given PID is alive. However this no longer works, since PIDs by Cygwin/Msys2 are no longer same as native Windows PIDs [1][2].
> 
> **Solution:**
> Fixed by switching to ps command. Original comment says tasklist was used due to ps sometimes missing some processes. This could be because ps, by default, only shows cygwin processes. I added -W argument to also show native windows processes [3] and I have seen no problems. Fix is targeted for JDK8, since newer JDKs migrated to java based tests (in several steps [4][5][6][7]...), but i think backporting all of that work, just to fix this issue would be overkill. (However nothing prevents anyone from doing so in the future, if desired.)
> 
> **Testing:**
> With this fix jdk_tier1 passes for me on Windows.
> 
> [1] https://github.com/msys2/MSYS2-packages/issues/1724
> [2] https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=b5e1003722cb14235c4f166be72c09acdffc62ea
> [3] https://www.cygwin.com/cygwin-ug-net/ps.html
> [4] https://bugs.openjdk.org/browse/JDK-8209109
> [5] https://bugs.openjdk.org/browse/JDK-8209604
> [6] https://bugs.openjdk.org/browse/JDK-8210243
> [7] https://bugs.openjdk.org/browse/JDK-8210760

This pull request has now been integrated.

Changeset: 8280a89a
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/8280a89a1e4748ca6b7534dceca8c2b1fd17697a
Stats:     18 lines in 2 files changed: 0 ins; 2 del; 16 mod

8295164: JDK 8 jdi tests should not use tasklist command on Windows

Also enable jdk_tier1 GHA tests on Windows

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/133

From omikhaltcova at openjdk.org  Thu Oct 13 12:55:11 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Thu, 13 Oct 2022 12:55:11 GMT
Subject: [jdk8u-dev] RFR: 8269850: Most JDK releases report macOS version
 12 as 10.16 instead of 12.0 [v3]
In-Reply-To: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
References: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
Message-ID: <VwaGX14UL_eX51cheXVIcwzps50B7JZ3XrFH5IOlXzY=.537650a6-be81-4f06-9a24-700569e60270@github.com>

> I'd like to backport JDK-8269850 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> src/java.base/macosx/native/libjava/java_props_macosx.c (source)
> jdk/src/solaris/native/java/lang/java_props_macosx.c (destination)
> But it's small and low risk. The changes are related only to one function void setOSNameAndVersion(..) within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Monterey:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

Olga Mikhaltsova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge master
 - Backport 3b1b8fc646493eae5f4df828afe29abb75fa5e60
 - Backport 66757750a2adf0739d0f5bf98a3f50a123b7adcf

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/126/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/126/files/275e333b..99e6a341

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=01-02

  Stats: 497 lines in 4 files changed: 169 ins; 218 del; 110 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/126.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/126/head:pull/126

PR: https://git.openjdk.org/jdk8u-dev/pull/126

From omikhaltcova at openjdk.org  Thu Oct 13 15:24:46 2022
From: omikhaltcova at openjdk.org (Olga Mikhaltsova)
Date: Thu, 13 Oct 2022 15:24:46 GMT
Subject: [jdk8u-dev] Integrated: 8269850: Most JDK releases report macOS
 version 12 as 10.16 instead of 12.0
In-Reply-To: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
References: <1rS3d-Gu_GQs_hmN4B8FR_HQdZeb8Tfa-_RIl42vDNM=.432616e0-23f6-453b-a839-77cb434d5108@github.com>
Message-ID: <eNyMMf6PsoRdntbwXqoSeBWj16xkgXoZsmzvTwUml9s=.8d007928-8b71-4137-8364-51c51b5ef53e@github.com>

On Fri, 30 Sep 2022 20:45:54 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I'd like to backport JDK-8269850 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> src/java.base/macosx/native/libjava/java_props_macosx.c (source)
> jdk/src/solaris/native/java/lang/java_props_macosx.c (destination)
> But it's small and low risk. The changes are related only to one function void setOSNameAndVersion(..) within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Monterey:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

This pull request has now been integrated.

Changeset: 43cfe27f
Author:    Olga Mikhaltsova <omikhaltcova at openjdk.org>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b
Stats:     25 lines in 1 file changed: 7 ins; 12 del; 6 mod

8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

Backport-of: 3b1b8fc646493eae5f4df828afe29abb75fa5e60

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/126

From duke at openjdk.org  Fri Oct 14 06:41:49 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Fri, 14 Oct 2022 06:41:49 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
 <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>
Message-ID: <SQynvBxgLk_5gmmuW4xxzClWXLF43ywXedqvT-I9CA0=.abf57bf7-2087-45a8-9cf6-1554f6810fb3@github.com>

On Tue, 11 Oct 2022 15:38:08 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> That looks good to me. Why not include the test case?

Original tests were not backported to the 11 because they are based on IR test framework that does not exists in the 11. I raised JDK-8295322 to re-factor the tests and incorporate them into the 11 and the 8.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From roland at openjdk.org  Fri Oct 14 07:04:50 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Fri, 14 Oct 2022 07:04:50 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
Message-ID: <o-XCUNuvESa9YMqrfwHPYcteyhcNGuIw_lGdulCYGdg=.02ba1e0c-7fcb-48c2-9643-72d31312141f@github.com>

On Tue, 23 Aug 2022 12:47:26 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
> 
> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
> 
> Regression: hotspot/test/runtime

Marked as reviewed by roland (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From roland at openjdk.org  Fri Oct 14 07:04:50 2022
From: roland at openjdk.org (Roland Westrelin)
Date: Fri, 14 Oct 2022 07:04:50 GMT
Subject: [jdk8u-dev] RFR: 8271459: C2: Missing NegativeArraySizeException
 when creating StringBuilder with negative capacity
In-Reply-To: <SQynvBxgLk_5gmmuW4xxzClWXLF43ywXedqvT-I9CA0=.abf57bf7-2087-45a8-9cf6-1554f6810fb3@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
 <ELJghdQcU8vd-RD5GGgY8_QMIcVyTLpyQFtTdVfKeN0=.dbeb3adf-1962-4d38-b129-618c2b28a53b@github.com>
 <SQynvBxgLk_5gmmuW4xxzClWXLF43ywXedqvT-I9CA0=.abf57bf7-2087-45a8-9cf6-1554f6810fb3@github.com>
Message-ID: <f_hylOgIrewUmTGyPxmvfQnclXX0JeA0aPwvUFPlT-U=.95f4c4ae-63e3-46cc-8050-82c95e729204@github.com>

On Fri, 14 Oct 2022 06:38:30 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> > That looks good to me. Why not include the test case?
> 
> Original tests were not backported to the 11 because they are based on IR test framework that does not exists in the 11. I raised JDK-8295322 to re-factor the tests and incorporate them into the 11 and the 8.

Makes sense.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From duke at openjdk.org  Fri Oct 14 09:27:08 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Fri, 14 Oct 2022 09:27:08 GMT
Subject: [jdk8u-dev] Integrated: 8271459: C2: Missing
 NegativeArraySizeException when creating StringBuilder with negative capacity
In-Reply-To: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
References: <66i35lbKmLWSgfEB8gMZP9Do8-eCtZmAQn9DUJvPRxU=.63fb7152-58f6-4cea-8994-2b8d2367daf8@github.com>
Message-ID: <mokNfxZCqsMCx-o3ZfXJm_k7mi4CyU-ODoA9TlQUFqg=.9ebb0242-061e-4f34-a58e-b1bc6ba4bf74@github.com>

On Tue, 23 Aug 2022 12:47:26 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is a backport of JDK-8271459 that fixes lost NegativeArraySizeException on using StringBuilder of negative capacity. The patch from jdk-11 is applied cleanly except the path suffling.
> 
> Verification (amd64/Ubuntu 20.04): the reproducer from JBS throws 10000 of 10000 exceptions, and only ~55% (behaviour is non-deterministic) before the patch is applied
> 
> Regression: hotspot/test/runtime

This pull request has now been integrated.

Changeset: dfeeceb2
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/dfeeceb224a62bd7ffbe5adfd36eebe6c853935a
Stats:     51 lines in 1 file changed: 49 ins; 0 del; 2 mod

8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

Reviewed-by: roland
Backport-of: 844c504bc18fa8a79ceacc6b6f235650f5e643bf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/111

From andrew at openjdk.org  Fri Oct 14 20:35:06 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Oct 2022 20:35:06 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable partial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
Message-ID: <FY0qd1V8c3c73BtgBzLrrAQgg9XwPMgROCJFGxf4Lzc=.8c07e618-c2cd-425b-a2dc-3844c4b2951e@github.com>

On Wed, 5 Oct 2022 15:59:15 GMT, zzambers <duke at openjdk.org> wrote:

>> This change adds support for tier1 testing in github actions by fixing workflow to work  with JDK8. (Changes were needed due to build system difference compared to newer JDK.) Support for running tests is done for all systems. This includes adding code to run tests on windows x86, which was missing. Currently only jdk_tier1 on linuxes and macos is enabled, as currently only this is passing without failures (see details lower). Testing on windows is currently disabled (no tier1 groups are passing there currently). Disabled tests can be easily enabled once, they are fixed. Ultimate goal is of course to run all tier1 groups (jdk_tier1, langtools_tier1, hotspot_tier1) on all platforms.
>> 
>> **Tier1 status:**
>> 
>> jdk_tier1
>> - enabled on linuxes and macos (passes there)
>> - disabled on on windows, where `com/sun/jdi/*.sh` shell tests are currently failing
>> 
>> langtools_tier1
>> - disabled everywhere
>> - 1 failure: `tools/javac/diags/CheckExamples.java` (all platforms, see: [1])
>> 
>> hotspot_tier1
>> - disabled everywhere
>> - there are several faiures of `compiler/rtm/*` tests. These tests seem to broken on some systems (see: [2]), including machines used by GHA. Some tests are already excluded [3], but there are few more. Also exclusions were made only on x64 but it also affects x86.
>> - on x86 (32-bit) platforms there are few additional failures
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8265527
>> [2] https://bugs.openjdk.org/browse/JDK-8183263
>> [3] https://bugs.openjdk.org/browse/JDK-8226899
>
> zzambers has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Enable initial tier1 testing

Hmm, just seen this. I'm not keen on how much this is diverging from the other JDKs. We'll likely need to revert some of this when backporting bundle support.

Do we not need a test bundle for running the tests? I had a feeling that was the case, as 8u doesn't have GTest, but wasn't 100%

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From andrew at openjdk.org  Fri Oct 14 20:52:09 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Oct 2022 20:52:09 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <usdcrM3Kc6Ms1jWspnjQzXSnN7IG8Q0ReBV6uXVFHaY=.e314a68f-6ee5-4f7a-b890-17619e9f3126@github.com>

Bring in b06 & b07.

-------------

Commit messages:
 - Merge jdk8u:master
 - 8292579: (tz) Update Timezone Data to 2022c
 - 8028265: Add legacy tz tests to OpenJDK

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/137/files
  Stats: 3199 lines in 33 files changed: 1703 ins; 1214 del; 282 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/137.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/137/head:pull/137

PR: https://git.openjdk.org/jdk8u-dev/pull/137

From andrew at openjdk.org  Sat Oct 15 00:31:06 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 15 Oct 2022 00:31:06 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <usdcrM3Kc6Ms1jWspnjQzXSnN7IG8Q0ReBV6uXVFHaY=.e314a68f-6ee5-4f7a-b890-17619e9f3126@github.com>
References: <usdcrM3Kc6Ms1jWspnjQzXSnN7IG8Q0ReBV6uXVFHaY=.e314a68f-6ee5-4f7a-b890-17619e9f3126@github.com>
Message-ID: <RdRv0IBQBFNp93-CyMa3j4g-efnQjJMSdWxm3vFfGVA=.4fbb7ec5-eadf-4787-9a24-4434a1e8bb97@github.com>

On Fri, 14 Oct 2022 20:43:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Bring in b06 & b07.

This pull request has now been integrated.

Changeset: 5b5e548f
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5b5e548fba1073a1f87df3c71f0d09b63e033ced
Stats:     3199 lines in 33 files changed: 1703 ins; 1214 del; 282 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/137

From andrew at openjdk.org  Sun Oct 16 01:43:34 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sun, 16 Oct 2022 01:43:34 GMT
Subject: [jdk8u-dev] RFR: 8294357: (tz) Update Timezone Data to 2022d
Message-ID: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>

Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for `jdk/test`. There are no tzdata differences between the vanguard and rearguard update.

In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970

Tests in `java/util/TimeZone` and `sun/util/calendar` all pass.

-------------

Commit messages:
 - Backport f67b4de8a07b8158be1dfb5b09cdb4cc5b7ac93b

Changes: https://git.openjdk.org/jdk8u-dev/pull/138/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=138&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8294357
  Stats: 202 lines in 17 files changed: 63 ins; 103 del; 36 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/138.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/138/head:pull/138

PR: https://git.openjdk.org/jdk8u-dev/pull/138

From andrew at openjdk.org  Sun Oct 16 02:49:02 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sun, 16 Oct 2022 02:49:02 GMT
Subject: [jdk8u-dev] RFR: 8295173: (tz) Update Timezone Data to 2022e
Message-ID: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>

Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.

Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/138

Commit messages:
 - Backport 21407dec0156301871a83328615e4d975c4287c4

Changes: https://git.openjdk.org/jdk8u-dev/pull/139/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=139&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295173
  Stats: 161 lines in 10 files changed: 44 ins; 26 del; 91 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/139.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/139/head:pull/139

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From duke at openjdk.org  Sun Oct 16 05:38:20 2022
From: duke at openjdk.org (Joshua Cao)
Date: Sun, 16 Oct 2022 05:38:20 GMT
Subject: [jdk8u-dev] RFR: 8079255: [TEST_BUG] [macosx] Test
 closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
Message-ID: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>

Parity with Oracle. Clean backport. Also submitting a PR for https://bugs.openjdk.org/browse/JDK-8129827.

-------------

Commit messages:
 - 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Changes: https://git.openjdk.org/jdk8u-dev/pull/140/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=140&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8079255
  Stats: 83 lines in 1 file changed: 83 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/140.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/140/head:pull/140

PR: https://git.openjdk.org/jdk8u-dev/pull/140

From duke at openjdk.org  Sun Oct 16 05:45:09 2022
From: duke at openjdk.org (Joshua Cao)
Date: Sun, 16 Oct 2022 05:45:09 GMT
Subject: [jdk8u-dev] RFR: 8079255: [TEST_BUG] [macosx] Test
 closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
In-Reply-To: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
References: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
Message-ID: <DoKKiL1faRPC-Y_KNBNHWtH8YmMWxiEm0runMo93_ug=.41322fe8-0a16-42e8-ab43-2431bbf1f849@github.com>

On Sun, 16 Oct 2022 05:31:33 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. Clean backport. Also submitting a PR for https://bugs.openjdk.org/browse/JDK-8129827.

Added https://github.com/openjdk/jdk8u-dev/pull/141 as follow up PR.

Windows failure does not look related to this change.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/140

From duke at openjdk.org  Sun Oct 16 05:47:37 2022
From: duke at openjdk.org (Joshua Cao)
Date: Sun, 16 Oct 2022 05:47:37 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
Message-ID: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>

Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:

* https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
* https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)

Only one serious conflict. We cannot use


private static int wheelSign = Platform.isOSX() ? -1 : 1;


Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 


import jdk.test.lib.Platform;


Alternatively, I use the old code to get OS:


private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/140

Commit messages:
 - 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Changes: https://git.openjdk.org/jdk8u-dev/pull/141/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8129827
  Stats: 42 lines in 1 file changed: 32 ins; 5 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/141.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/141/head:pull/141

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From duke at openjdk.org  Mon Oct 17 05:09:03 2022
From: duke at openjdk.org (duke)
Date: Mon, 17 Oct 2022 05:09:03 GMT
Subject: [jdk8u-dev] Withdrawn: 8251551: Use .md filename extension for README
In-Reply-To: <R-sF5coJgFH-Vhx1TexI_HokiwRiwvWvPFukJbdU3xs=.8d8ba90b-a684-4871-aa5b-00b5918e1a36@github.com>
References: <R-sF5coJgFH-Vhx1TexI_HokiwRiwvWvPFukJbdU3xs=.8d8ba90b-a684-4871-aa5b-00b5918e1a36@github.com>
Message-ID: <PyWS4ZgIn4eh1LUFcZ4Gk4UQIIGFgXa46ARsiVTJi5A=.caba5fef-1b51-4db8-b4e2-8f3ef1790f80@github.com>

On Tue, 21 Jun 2022 07:52:23 GMT, George Adams <duke at openjdk.org> wrote:

> Backports https://bugs.openjdk.org/browse/JDK-8251551 as it's a low-risk change and generally improves the readability/usability in GitHub.
> 
> Currently, I've just converted the README to markdown format and added a little syntax highlighting. I'm not sure if people would like me to go one step further and rip out the mercurial/nested repo references?

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/75

From jdowland at openjdk.org  Mon Oct 17 08:24:36 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 17 Oct 2022 08:24:36 GMT
Subject: [jdk8u-dev] RFR: 8244500: jtreg test error in
 test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
Message-ID: <J4Rcyk8_jlY9R9dq6R_4nk92gt9llHNNeNU2N2kImZ0=.971214d0-a7cb-460d-8cbe-780aa5a4db2f@github.com>

This is a backport of 8244500 to jdk8u-dev as part of cgroups v2 support.

It's a test-only change.

The patch needed adjusting for jdk8u, mostly to JDK-module-specific things.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/136

Commit messages:
 - Don't pass --add-exports to jdk8u java inside docker
 - 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java

Changes: https://git.openjdk.org/jdk8u-dev/pull/142/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=142&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8244500
  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/142.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/142/head:pull/142

PR: https://git.openjdk.org/jdk8u-dev/pull/142

From jdowland at openjdk.org  Mon Oct 17 09:00:02 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 17 Oct 2022 09:00:02 GMT
Subject: [jdk8u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on
 old systems in hotspot [v3]
In-Reply-To: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
References: <2CF72jwy7fqwLrcv-T7pHGF8ovRF5f-dZkT3qwcxsho=.e1eed67c-2773-452e-be25-9b38d4031606@github.com>
Message-ID: <q_LS2cg7jQb6wvg6RYey0dwl9H722KCciN6ZoU1lqbw=.cc728ab2-ab20-4a6b-9f59-b9564d5697cf@github.com>

> This is a backport of add18914fb1294999877b563c734a25b4c17b922 for cgroups v2 support injdk8u-dev, via the 11u backport.
> 
> It does not apply clean:
> 
>  * context issues for changes made for the different approach for logging in 8u
>  * copyright lines
> 
> Small amount of re-working of new code that used `log_trace`/`log_debug` to use the 8u approach.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Move test to a more 8u-appropriate location
  
  Container (cgroups, docker) tests in 8u reside in
  hotspot/test/runtime/containers

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/135/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/135/files/880244fd..9af9bd47

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=135&range=01-02

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/135.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/135/head:pull/135

PR: https://git.openjdk.org/jdk8u-dev/pull/135

From sgehwolf at openjdk.org  Mon Oct 17 13:21:09 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 17 Oct 2022 13:21:09 GMT
Subject: [jdk8u-dev] RFR: 8206456: [TESTBUG] docker jtreg tests fail on
 systems without cpuset.effective_cpus / cpuset.effective_mems
In-Reply-To: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
References: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
Message-ID: <cMV55GxHX1hSOnWNsqUqHLrwUqPn0RdMn_HAPFR9RzU=.5f3eacb2-890f-409e-a31d-aa51f1a8f73d@github.com>

On Thu, 22 Sep 2022 13:55:48 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 6fc4db4799599df66a2cf5207068336ce68136ff to jdk8u-dev.
> 
> It's a test-only change, that I wish to backport as part of cgroups v2 support. Whilst not directly cgroups v2 specific, this will ease further backports by reducing merge conflicts.
> 
> The original commit touched two files: MetricsCpuTester.java and MetricsTester.java. This backport only touches MetricsCpuTester.java. The changes from the original comit to MetricsTester.java were already merged into jdk8u-dev with "8223147: JFR Backport...".

Looks good to me. Please add a `/summary` mentioning that `MetricsTester.java` changes got included with JDK-8223147 (JFR backport).

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/123

From sgehwolf at openjdk.org  Mon Oct 17 13:21:11 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 17 Oct 2022 13:21:11 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness
In-Reply-To: <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>
Message-ID: <Vg-PS9QsHjGz1bKEQR1jyf4zMtFOJXmhHPp3M1sIRsc=.cc002f4d-96d9-4d8f-a153-cdeef4399197@github.com>

On Mon, 3 Oct 2022 10:05:05 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Local test failure observed in runtime/containers/docker/TestMemoryAwareness.java:
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException: 'Memory Soft Limit.*524288000' missing from stdout/stderr 
> 
> this might be [JDK-8253714](https://bugs.openjdk.org/browse/JDK-8253714), which is on the list to backport, I'll look at this next.

@jmtd Any particular reason this PR depends on the Metrics PR? In JDK 11u and JDK head this was the first one of the cg v2 patch series. If you agree, please drop the dependency, targeting `master` directly.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From duke at openjdk.org  Mon Oct 17 16:31:52 2022
From: duke at openjdk.org (zzambers)
Date: Mon, 17 Oct 2022 16:31:52 GMT
Subject: [jdk8u-dev] RFR: 8294863: Enable partial tier1 testing in GHA for
 JDK8 [v2]
In-Reply-To: <FY0qd1V8c3c73BtgBzLrrAQgg9XwPMgROCJFGxf4Lzc=.8c07e618-c2cd-425b-a2dc-3844c4b2951e@github.com>
References: <q8MaY0pHjMlEjaUL0YTKK7hqzV71woAO0I0AW8kRoQU=.b5a2a5cd-1579-4e05-852d-40d4a11dbebf@github.com>
 <AldIfjhxht6ai1DXJVd9vLv1-54KPTIrJM3W_A2DB6w=.d21a9b87-14af-4ca2-b44e-478ded6df952@github.com>
 <FY0qd1V8c3c73BtgBzLrrAQgg9XwPMgROCJFGxf4Lzc=.8c07e618-c2cd-425b-a2dc-3844c4b2951e@github.com>
Message-ID: <3611t4aPm_0OOFF0IGkX-c-yy85IJk_Fx9GA5Vs_uNU=.5e2edf4c-149e-469e-84d0-f563e99f4551@github.com>

On Fri, 14 Oct 2022 20:31:25 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Hmm, just seen this. I'm not keen on how much this is diverging from the other JDKs. We'll likely need to revert some of this when backporting bundle support.

Sorry if I was interfering with something, you are working on. Just wanted to have tier1 testing enabled in GHA as it makes backporting much more convenient. If you do some backports, making JDK8 closer to newer JDKs, feel free to revert (update) parts of my changes concerning this matter.

> Do we not need a test bundle for running the tests? I had a feeling that was the case, as 8u doesn't have GTest, but wasn't 100%
 
When it comes to test bundle/image support, I am not sure there is currently use for this in JDK8 (tests in their current form). As far as I understand it, test image is mostly for tests, which make use of JNI. Native test libraries in newer JDKs are then built by build system and path to built libraries is then passed to jtreg using -nativepath argument [1]. Test image allows to (pre)build these, so they don't have to be built at test time.

However from what I can tell, JDK8 does not (yet) use this approach (building native test libraries by built system in makefiles). Instead tests which make use of JNI are implemented as shell tests and they build native libraries as part of test run. [2] (Other tests using JNI mostly follow similar boilerplate, with some modifications)

When testing GHA is concerned, I don't think, tests using JNI are causing any big problems. You just need working C/C++ compiler at test time. This is not really an issue especially when all tests using JNI seem excluded on Windows [3]. Only problem I have seen was multilib configuration (32-bit JDK on 64-bit linux). While some tests can handle this case correctly using appropriate C/C++ compiler arguments [4], few have a problem of building 64bit JNI library for 32bit JDK and fail. There are only 3 tests affected by this in tier1 (concretely in hotspot_tier1) and they should be easy enough to fix. 

compiler/criticalnatives/argumentcorruption/Test8167409.sh 
runtime/jni/CallWithJNIWeak/test.sh 
runtime/jni/ReturnJNIWeak/test.sh 

So while newer JDK probably use cleaner approach for building native test libraries, I don't see it as a high priority in JDK8 (At least when it comes to GHA).

[1] https://github.com/openjdk/jdk/blob/ae60599e2ba75d80c3b4279903137b2c549f8066/make/RunTests.gmk#L801
[2] https://github.com/openjdk/jdk8u-dev/blob/5b5e548fba1073a1f87df3c71f0d09b63e033ced/hotspot/test/runtime/jni/CallWithJNIWeak/test.sh#L71
[3] https://github.com/openjdk/jdk8u-dev/blob/5b5e548fba1073a1f87df3c71f0d09b63e033ced/hotspot/test/runtime/jni/CallWithJNIWeak/test.sh#L60
[4] https://github.com/openjdk/jdk8u-dev/blob/5b5e548fba1073a1f87df3c71f0d09b63e033ced/hotspot/test/runtime/6929067/Test6929067.sh#L42

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/131

From sgehwolf at openjdk.org  Mon Oct 17 16:43:55 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 17 Oct 2022 16:43:55 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
Message-ID: <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>

On Wed, 5 Oct 2022 08:26:01 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - substitute os::strerror for strerror
>    
>    os::strerror was introduced in 8148425 (strerror() function is not
>    thread-safe), which is probably out of scope for backporting (at least
>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>    (thread unsafe) strerror, in common with the rest of JDK8u.
>  - Rework use of newer logging API to tty->print_cr
>    
>    Remove includes of log.hpp that doesn't exist in jdk8u
>    
>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>  - 8230305: Cgroups v2: Container awareness
>    
>    Implement Cgroups v2 container awareness in hotspot
>    
>    Reviewed-by: bobv, dholmes

This seems promising, thanks. Please use explicit parenthesis for `PrintContainerInfo` log lines throughout. Also with a space before and after the `if`. We need to account for https://bugs.openjdk.org/browse/JDK-8227006 (which is in 8u) and https://bugs.openjdk.org/browse/JDK-8232207 (not currently in 8u), though. This patch would include both.

hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp line 112:

> 110:     // one or more controllers disabled, disable container support
> 111:     if(PrintContainerInfo)
> 112:       tty->print_cr("One or more required controllers disabled at kernel level.");

Style: Please use:


if (PrintContainerInfo) {
    tty-print_cr("...");
}


This repeats many times.

hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp line 367:

> 365:   // [See 8227006].
> 366:   CachingCgroupController* contrl = cpu_controller();
> 367:   CachedMetric* cpu_limit = contrl->metrics_cache();

For the processor counts we do want the caching so as to not regress JDK-8227006. For memory on the other hand we should probably remove it in the 8u backport.

hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp line 431:

> 429:   if (!memory_limit->should_check_metric()) {
> 430:     return memory_limit->value();
> 431:   }

This is actually code added with [JDK-8232207](https://bugs.openjdk.org/browse/JDK-8232207) which shouldn't affect JDK 8. So I'm not sure about this. Add it to 8u anyway (and have less divergence) or remove and deal with the code difference.

Whatever the way, we need to make this clear by: a) adding the issue using `/issue add` or b) restructuring this code to account for it. I'm slightly in favor of b).

hotspot/src/os/linux/vm/cgroupSubsystem_linux.hpp line 52:

> 50:  * [2] https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ContainerDefinition.html
> 51:  * [3] https://github.com/apache/mesos/blob/3478e344fb77d931f6122980c6e94cd3913c441d/src/docker/docker.cpp#L648
> 52:  *     https://github.com/apache/mesos/blob/3478e344fb77d931f6122980c6e94cd3913c441d/src/slave/containerizer/mesos/isolators/cgroups/constants.hpp#L30

This is part of `JDK-8216366` which isn't yet in 8u. Please add the issue to the commit message by doing:

hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp line 42:

> 40:   // Convert default value of 100 to no shares setup
> 41:   if (shares == 100) {
> 42:     tty->print_cr("CPU Shares is: %d", -1);

This line should be guarded with `if (PrintContainerInfo) { ... }`

hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp line 62:

> 60:   if ( x <= PER_CPU_SHARES ) {
> 61:      // will always map to 1 CPU
> 62:      tty->print_cr("CPU Shares is: %d", x);

Same here: Missing guard of `PrintContainerInfo`.

hotspot/src/os/linux/vm/osContainer_linux.hpp line 69:

> 67: 
> 68: inline bool OSContainer::is_containerized() {
> 69:   assert(_is_initialized, "OSContainer not initialized");

This hunk got removed with `JDK-8229202` which is not yet part of 8u. Please add this issue by:

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Tue Oct 18 09:54:08 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 18 Oct 2022 09:54:08 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness
In-Reply-To: <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>
Message-ID: <8zqjA9mjhLZgsP6kwILu91n7n56gwQGjBFArLK05aV8=.92a3bf88-5329-4109-8ab4-d07c87b60c7c@github.com>

On Mon, 3 Oct 2022 10:05:05 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Local test failure observed in runtime/containers/docker/TestMemoryAwareness.java:
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException: 'Memory Soft Limit.*524288000' missing from stdout/stderr 
> 
> this might be [JDK-8253714](https://bugs.openjdk.org/browse/JDK-8253714), which is on the list to backport, I'll look at this next.

> @jmtd Any particular reason this PR depends on the Metrics PR? In JDK 11u and JDK head this was the first one of the cg v2 patch series. If you agree, please drop the dependency, targeting master directly.

I collapsed the patch dependency tree into a linear list, and as a consequence some patches have GitHub PR dependencies which are artificial. This one (depending on  8231111 (pr/121)) is an example; it's because the downstream bug 8253714 (pr/130) depends on both.

I could flip the artifical dependency around, and make 8231111 (metrics, pr/121) depend on this (8230305, pr/127) instead (and follow that change down the chain). Would you prefer that?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From sgehwolf at openjdk.org  Tue Oct 18 10:13:08 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 18 Oct 2022 10:13:08 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness
In-Reply-To: <8zqjA9mjhLZgsP6kwILu91n7n56gwQGjBFArLK05aV8=.92a3bf88-5329-4109-8ab4-d07c87b60c7c@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <bWLlLzuzJz_UY7TEhJKIyIhOK7S5Wmc-6zUBaO3VKUQ=.672e4dec-1a5a-4e6c-bb60-dd2114ad59da@github.com>
 <8zqjA9mjhLZgsP6kwILu91n7n56gwQGjBFArLK05aV8=.92a3bf88-5329-4109-8ab4-d07c87b60c7c@github.com>
Message-ID: <NupJrao9t6uJN_0eTTBJBS2EQvRPaaiY5i3IEWo9A8Y=.05f7ae3c-85b1-45d3-b686-ce1240074690@github.com>

On Tue, 18 Oct 2022 09:50:38 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> I could flip the artifical dependency around, and make 8231111 (metrics, pr/121) depend on this (8230305, pr/127) instead (and follow that change down the chain). Would you prefer that?

Yes, please. That's matching how patches got integrated in JDK head and JDK 11 updates.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Tue Oct 18 10:17:23 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 18 Oct 2022 10:17:23 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v3]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <z0t3uzhUZpAUo4IHdjAE21nK4BWQQepwRNYwZQzFuZc=.b69ca2c8-cc91-4fe8-8c55-b88ca630d86d@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Whitespace and braces around PrintContainerInfo

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/127/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/127/files/d217ab9d..5e8a203c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=01-02

  Stats: 69 lines in 4 files changed: 34 ins; 0 del; 35 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Tue Oct 18 10:17:23 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 18 Oct 2022 10:17:23 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>
Message-ID: <5jbo6WXUMLCBMSx_M6JqATa74mPbF28UFVOaqsS2i58=.b9af34cd-2927-4216-9226-01c5791bc4bb@github.com>

On Mon, 17 Oct 2022 16:40:32 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please use explicit parenthesis for PrintContainerInfo log lines throughout. Also with a space before and after the if

Sure! I'm assuming you mean spaces and braces like this


@@ -64,9 +64,10 @@ CgroupSubsystem* CgroupSubsystemFactory::create() {
    */
   cgroups = fopen("/proc/cgroups", "r");
   if (cgroups == NULL) {
-      if(PrintContainerInfo)
+      if (PrintContainerInfo) {
         tty->print_cr("Can't open /proc/cgroups, %s",
                                  strerror(errno));
+      }
       return NULL;
   }


(although I'm not sure what you mean by spaces before the `if`) and I'm working that through now.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Tue Oct 18 10:36:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Tue, 18 Oct 2022 10:36:44 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v4]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <1Qq5YUZiVOC3MFphxSTycWX6Nt7rNZqMjo8gc5FGbQk=.7bfd3638-5585-467c-b339-a94e44c38736@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Guard two more tty->print_cr with PrintContainerInfo

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/127/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/127/files/5e8a203c..739788d2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=02-03

  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From duke at openjdk.org  Tue Oct 18 17:33:55 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 18 Oct 2022 17:33:55 GMT
Subject: [jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails with
 timeout
Message-ID: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>

Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.

**Few notes about this backport:**
There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.

**Testing:**
Test is part of jdk_tier1 and passes testing in GHA (results should appear here).

[1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
[2] https://bugs.openjdk.org/browse/JDK-6622468
[3] https://bugs.openjdk.org/browse/JDK-8143583

-------------

Commit messages:
 - Backport 3e3dcfb635bb7dc956f406ca2db6f375ee1b76a8

Changes: https://git.openjdk.org/jdk8u-dev/pull/143/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=143&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8054066
  Stats: 131 lines in 1 file changed: 11 ins; 109 del; 11 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/143.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/143/head:pull/143

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From dsamersoff at openjdk.org  Tue Oct 18 17:59:07 2022
From: dsamersoff at openjdk.org (Dmitry Samersoff)
Date: Tue, 18 Oct 2022 17:59:07 GMT
Subject: [jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails
 with timeout
In-Reply-To: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
References: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
Message-ID: <vw_y6nEylypjFrflk8cazz82B77oqmWnQIUDFMnVemw=.00bfc094-e302-4ddc-8b46-32f4b2653459@github.com>

On Tue, 18 Oct 2022 17:27:26 GMT, zzambers <duke at openjdk.org> wrote:

> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
> 
> **Few notes about this backport:**
> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
> 
> **Testing:**
> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
> [2] https://bugs.openjdk.org/browse/JDK-6622468
> [3] https://bugs.openjdk.org/browse/JDK-8143583

Marked as reviewed by dsamersoff (Committer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From sgehwolf at openjdk.org  Tue Oct 18 19:49:03 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 18 Oct 2022 19:49:03 GMT
Subject: [jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails
 with timeout
In-Reply-To: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
References: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
Message-ID: <fc0IF4D9SswskHOVX6hzYK2VYuY-4Y3bZxdOLIxEw7Y=.b3470887-bcf7-4c83-a1d5-d48f8178d5c0@github.com>

On Tue, 18 Oct 2022 17:27:26 GMT, zzambers <duke at openjdk.org> wrote:

> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
> 
> **Few notes about this backport:**
> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
> 
> **Testing:**
> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
> [2] https://bugs.openjdk.org/browse/JDK-6622468
> [3] https://bugs.openjdk.org/browse/JDK-8143583

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From sgehwolf at openjdk.org  Tue Oct 18 20:30:11 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 18 Oct 2022 20:30:11 GMT
Subject: [jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails
 with timeout
In-Reply-To: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
References: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
Message-ID: <QhVhpKSIRXZSr_qH26KPnLBo-SXtXwo2prAMbzdtcM8=.1293d741-c9a5-43d3-b80a-be1e17704f55@github.com>

On Tue, 18 Oct 2022 17:27:26 GMT, zzambers <duke at openjdk.org> wrote:

> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
> 
> **Few notes about this backport:**
> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
> 
> **Testing:**
> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
> [2] https://bugs.openjdk.org/browse/JDK-6622468
> [3] https://bugs.openjdk.org/browse/JDK-8143583

@zzambers the `/summary` has a typo:


The test chaged to use testlibrary


Should be:


The test changed to use testlibrary

Well, part of the original commit, so nvm. Feel free to fix (or not).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From duke at openjdk.org  Tue Oct 18 21:56:59 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 18 Oct 2022 21:56:59 GMT
Subject: [jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails
 with timeout
In-Reply-To: <QhVhpKSIRXZSr_qH26KPnLBo-SXtXwo2prAMbzdtcM8=.1293d741-c9a5-43d3-b80a-be1e17704f55@github.com>
References: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
 <QhVhpKSIRXZSr_qH26KPnLBo-SXtXwo2prAMbzdtcM8=.1293d741-c9a5-43d3-b80a-be1e17704f55@github.com>
Message-ID: <EntkN9Gxl5iY8GWzLVQ-XAls-gu92Z10zYKRYnH3kss=.e13525a0-6903-4349-89ce-590e042c6dd8@github.com>

On Tue, 18 Oct 2022 20:28:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
>> 
>> **Few notes about this backport:**
>> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
>> 
>> **Testing:**
>> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
>> 
>> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
>> [2] https://bugs.openjdk.org/browse/JDK-6622468
>> [3] https://bugs.openjdk.org/browse/JDK-8143583
>
> Well, part of the original commit, so nvm. Feel free to fix (or not).

@jerboaa @dsamersoff Thanks

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From duke at openjdk.org  Wed Oct 19 08:59:43 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 19 Oct 2022 08:59:43 GMT
Subject: [jdk8u-dev] Integrated: 8054066: com/sun/jdi/DoubleAgentTest.java
 fails with timeout
In-Reply-To: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
References: <DhPvqlaCBbUPobShI5-oAUNqS-L4iC34V2RNqijaVY4=.93c5825e-72a6-48a9-b182-5fd3c70f19bb@github.com>
Message-ID: <vu10pvhil8Q15VZ23ONiHzZj6NnNaNiWCZEFtuDS3g8=.65131293-67bd-4a4f-9bc1-bde8094af44c@github.com>

On Tue, 18 Oct 2022 17:27:26 GMT, zzambers <duke at openjdk.org> wrote:

> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
> 
> **Few notes about this backport:**
> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
> 
> **Testing:**
> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
> [2] https://bugs.openjdk.org/browse/JDK-6622468
> [3] https://bugs.openjdk.org/browse/JDK-8143583

This pull request has now been integrated.

Changeset: 58d0281c
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/58d0281c52f8c1e9642c6fc5bd696235498b0ae2
Stats:     131 lines in 1 file changed: 11 ins; 109 del; 11 mod

8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout

The test changed to use testlibrary

Reviewed-by: dsamersoff, sgehwolf
Backport-of: 3e3dcfb635bb7dc956f406ca2db6f375ee1b76a8

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143

From duke at openjdk.org  Wed Oct 19 13:55:14 2022
From: duke at openjdk.org (duke)
Date: Wed, 19 Oct 2022 13:55:14 GMT
Subject: [jdk8u-dev] Withdrawn: 8035467: Xerces Update: Move to Xalan based DOM
 L3 serializer. Deprecate Xerces' native serializer.
In-Reply-To: <Lx7dn5rK4UFSvKjhh9iv8DbQDcGnxGZ3Ct28bAcVl_k=.851d6cbb-526f-4635-9564-ef7722d31e3c@github.com>
References: <Lx7dn5rK4UFSvKjhh9iv8DbQDcGnxGZ3Ct28bAcVl_k=.851d6cbb-526f-4635-9564-ef7722d31e3c@github.com>
Message-ID: <5NPZSB-3II710khGQwFAdtuInlWbh1CBVZTdSdYLiug=.df3316b0-193a-497c-9f83-72d333a8511e@github.com>

On Fri, 22 Jul 2022 22:13:07 GMT, Elliott Baron <ebaron at openjdk.org> wrote:

> This backport is part of the effort to update Xerces in 8u to 2.12 ([JDK-8238164](https://bugs.openjdk.org/browse/JDK-8238164).
> 
> The JDK 9 commit does not apply cleanly, but only required cosmetic changes. These are due to differences in some copyright headers, and not having a `@version` Javadoc tag in the 8u version of these files.
> 
> I am concerned over deprecating the Xerces serializer. As noted in [JDK-8219692](https://bugs.openjdk.org/browse/JDK-8219692), there are behavioural changes caused by this new serializer.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/89

From andrew at openjdk.org  Wed Oct 19 19:57:46 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Oct 2022 19:57:46 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <D6N6DeDVXs-bEdmK79og4B5jSzt6Nt6k0yEBl9tcSZ0=.4ee3cf20-8c1b-4e38-9ad9-a64e13f38360@github.com>

Bring security patches from 2022-10 security update into 8u-dev

-------------

Commit messages:
 - Merge jdk8u:master
 - 8288508: Enhance ECDSA usage
 - 8286918: Better HttpServer service
 - 8147862: Null check too late in sun.net.httpserver.ServerImpl
 - 8286910: Improve JNDI lookups
 - 8286533: Key X509 usages
 - 8286526: Improve NTLM support
 - 8286519: Better memory handling
 - 8286511: Improve macro allocation
 - 8285662: Better permission resolution
 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/5b5e548f...8dc04696

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/144/files
  Stats: 933 lines in 22 files changed: 654 ins; 85 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/144.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/144/head:pull/144

PR: https://git.openjdk.org/jdk8u-dev/pull/144

From andrew at openjdk.org  Wed Oct 19 20:11:21 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Oct 2022 20:11:21 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <D6N6DeDVXs-bEdmK79og4B5jSzt6Nt6k0yEBl9tcSZ0=.4ee3cf20-8c1b-4e38-9ad9-a64e13f38360@github.com>
References: <D6N6DeDVXs-bEdmK79og4B5jSzt6Nt6k0yEBl9tcSZ0=.4ee3cf20-8c1b-4e38-9ad9-a64e13f38360@github.com>
Message-ID: <-YfrQawRw4lczBievL-ZQmad9H2lhOeXa4rJyhdiAJo=.cd25e78b-a530-4121-8c75-7be3c5a7458f@github.com>

On Wed, 19 Oct 2022 19:48:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Bring security patches from 2022-10 security update into 8u-dev

This pull request has now been integrated.

Changeset: 60930770
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/60930770b9238e55d72689092b9e127bc619ce87
Stats:     933 lines in 22 files changed: 654 ins; 85 del; 194 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/144

From gnu.andrew at redhat.com  Thu Oct 20 01:51:39 2022
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 20 Oct 2022 02:51:39 +0100
Subject: OpenJDK 8u352 Released
Message-ID: <Y1CpqzsqSkzinNKr@hex.discworld.ac.uk>

We are pleased to announce the release of OpenJDK 8u352.

The source tarball is available from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u352-b08.tar.xz

The tarball is accompanied by a digital signature available at:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u352-b08.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint = CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

d6f5e9142b3d0d5ad05f51d5f3aa3aa2b2f196b60cf4dd505369de63fbddc518  openjdk8u352-b08.tar.xz
d53f0a8e3fd9d0bc986a44e3f5b54a97427467407ac488e89d270d091336698a  openjdk8u352-b08.tar.xz.sig

The checksums can be downloaded from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u352-b08.sha256

New in release OpenJDK 8u352 (2022-10-18):
===========================================
Live versions of these release notes can be found at:
  * https://bit.ly/openjdk8u352
  * https://builds.shipilev.net/backports-monitor/release-notes-openjdk8u352.html

* Security fixes
  - JDK-8282252: Improve BigInteger/Decimal validation
  - JDK-8285662: Better permission resolution
  - JDK-8286511: Improve macro allocation
  - JDK-8286519: Better memory handling
  - JDK-8286526, CVE-2022-21619: Improve NTLM support
  - JDK-8286533, CVE-2022-21626: Key X509 usages
  - JDK-8286910, CVE-2022-21624: Improve JNDI lookups
  - JDK-8286918, CVE-2022-21628: Better HttpServer service
  - JDK-8288508: Enhance ECDSA usage
* Other changes
  - JDK-7131823: bug in GIFImageReader
  - JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate
  - JDK-8028265: Add legacy tz tests to OpenJDK
  - JDK-8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
  - JDK-8049228: Improve multithreaded scalability of InetAddress cache
  - JDK-8071507: (ref) Clear phantom reference as soft and weak references do
  - JDK-8087283: Add support for the XML Signature here() function to the JDK XPath implementation
  - JDK-8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9
  - JDK-8136354: [TEST_BUG] Test  java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
  - JDK-8139668: Generate README-build.html from markdown
  - JDK-8143847: Remove REF_CLEANER reference category
  - JDK-8147862: Null check too late in sun.net.httpserver.ServerImpl
  - JDK-8150669: C1 intrinsic for Class.isPrimitive
  - JDK-8155742: [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows
  - JDK-8173339: AArch64: Fix minimum stack size computations
  - JDK-8173361: various crashes in JvmtiExport::post_compiled_method_load
  - JDK-8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  - JDK-8178832: (ref) jdk.lang.ref.disableClearBeforeEnqueue property is ignored
  - JDK-8183107: PKCS11 regression regarding checkKeySize
  - JDK-8193780: (ref) Remove the undocumented "jdk.lang.ref.disableClearBeforeEnqueue" system property
  - JDK-8194873: right ALT key hotkeys no longer work in Swing components
  - JDK-8201793: (ref) Reference object should not support cloning
  - JDK-8214427: probable bug in logic of ConcurrentHashMap.addCount()
  - JDK-8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
  - JDK-8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit
  - JDK-8235218: Minimal VM is broken after JDK-8173361
  - JDK-8235385: Crash on aarch64 JDK due to long offset
  - JDK-8245263: Enable TLSv1.3 by default on JDK 8u for Client roles
  - JDK-8254178: Remove .hgignore
  - JDK-8254318: Remove .hgtags
  - JDK-8256722: handle VC++:1927 VS2019 in  abstract_vm_version
  - JDK-8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  - JDK-8280963: Incorrect PrintFlags formatting on Windows
  - JDK-8282538: PKCS11 tests fail on CentOS Stream 9
  - JDK-8283849: AsyncGetCallTrace may crash JVM on guarantee
  - JDK-8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3
  - JDK-8285497: Add system property for Java SE specification maintenance version
  - JDK-8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE
  - JDK-8287508: The tests added to jdk-8 by 8235385 are to be ported to jdk-11
  - JDK-8287521: Bump update version of OpenJDK: 8u352
  - JDK-8288763: Pack200 extraction failure with invalid size
  - JDK-8288865: [aarch64] LDR instructions must use legitimized addresses
  - JDK-8290000: Bump macOS GitHub actions to macOS 11
  - JDK-8292579: (tz) Update Timezone Data to 2022c
  - JDK-8292688: Support Security properties in security.testlibrary.Proc

Notes on individual issues:
===========================

core-libs/java.lang:

JDK-8201793: (ref) Reference object should not support cloning
==============================================================
`java.lang.ref.Reference::clone` method always throws
`CloneNotSupportedException`. `Reference` objects cannot be
meaningfully cloned. To create a new Reference object, call the
constructor to create a `Reference` object with the same referent and
reference queue instead.

JDK-8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
===============================================================================================
`java.lang.ref.Reference.enqueue` method clears the reference object
before it is added to the registered queue. When the `enqueue` method
is called, the reference object is cleared and `get()` method will
return null in OpenJDK 8u352.

Typically when a reference object is enqueued, it is expected that the
reference object is cleared explicitly via the `clear` method to avoid
memory leak because its referent is no longer referenced. In other
words the `get` method is expected not to be called in common cases
once the `enqueue`method is called. In the case when the `get` method
from an enqueued reference object and existing code attempts to access
members of the referent, `NullPointerException` may be thrown. Such
code will need to be updated.

JDK-8071507: (ref) Clear phantom reference as soft and weak references do
=========================================================================
This enhancement changes phantom references to be automatically
cleared by the garbage collector as soft and weak references.

An object becomes phantom reachable after it has been finalized. This
change may cause the phantom reachable objects to be GC'ed earlier -
previously the referent is kept alive until PhantomReference objects
are GC'ed or cleared by the application. This potential behavioral
change might only impact existing code that would depend on
PhantomReference being enqueued rather than when the referent be freed
from the heap.

core-libs/java.net:

JDK-8286918: Better HttpServer service
======================================
The HttpServer can be optionally configured with a maximum connection
limit by setting the jdk.httpserver.maxConnections system property. A
value of 0 or a negative integer is ignored and considered to
represent no connection limit. In the case of a positive integer
value, any newly accepted connections will be first checked against
the current count of established connections and, if the configured
limit has been reached, then the newly accepted connection will be
closed immediately.

security-libs/javax.net.ssl:

JDK-8282859: Enable TLSv1.3 by Default on JDK 8 for Client Roles
================================================================
The TLSv1.3 implementation is now enabled by default for client roles
in 8u352. It has been enabled by default for server roles since 8u272.

Note that TLS 1.3 is not directly compatible with previous
versions. Enabling it on the client may introduce compatibility issues
on either the server or the client side. Here are some more details on
potential compatibility issues that you should be aware of:

* TLS 1.3 uses a half-close policy, while TLS 1.2 and prior versions
  use a duplex-close policy. For applications that depend on the
  duplex-close policy, there may be compatibility issues when
  upgrading to TLS 1.3.

* The signature_algorithms_cert extension requires that pre-defined
  signature algorithms are used for certificate authentication. In
  practice, however, an application may use non-supported signature
  algorithms.

* The DSA signature algorithm is not supported in TLS 1.3. If a server
  is configured to only use DSA certificates, it cannot upgrade to TLS
  1.3.

* The supported cipher suites for TLS 1.3 are not the same as TLS 1.2
  and prior versions. If an application hard-codes cipher suites which
  are no longer supported, it may not be able to use TLS 1.3 without
  modifying the application code.

* The TLS 1.3 session resumption and key update behaviors are
  different from TLS 1.2 and prior versions. The compatibility should
  be minimal, but it could be a risk if an application depends on the
  handshake details of the TLS protocols.

The TLS 1.3 protocol can be disabled by using the jdk.tls.client.protocols
system property:

java -Djdk.tls.client.protocols="TLSv1.2" ...

Alternatively, an application can explicitly set the enabled protocols
with the javax.net.ssl APIs e.g.

sslSocket.setEnabledProtocols(new String[] {"TLSv1.2"});

or:

SSLParameters params = sslSocket.getSSLParameters();
params.setProtocols(new String[] {"TLSv1.2"});
sslSocket.setSSLParameters(params);

Happy hacking,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221020/4410e13d/signature-0001.asc>

From phh at openjdk.org  Thu Oct 20 16:45:58 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 20 Oct 2022 16:45:58 GMT
Subject: [jdk8u-dev] RFR: 8079255: [TEST_BUG] [macosx] Test
 closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
In-Reply-To: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
References: <FflxHeQrfrgsvn5iPguVZqRUGsNwJKo2d7Jk0x3MRNE=.3aa5db0c-d903-438f-b059-4561627cc467@github.com>
Message-ID: <MlZnCZxjMCnPA61pszs0qTasYp1Sn5ZPin-eaDZPVV4=.dfee5090-2987-4679-b0ee-8fbc02df48a9@github.com>

On Sun, 16 Oct 2022 05:31:33 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. Clean backport. Also submitting a PR for https://bugs.openjdk.org/browse/JDK-8129827.

Tagged JBS issue.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/140

From phh at openjdk.org  Thu Oct 20 17:04:03 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 20 Oct 2022 17:04:03 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <uvI5Izekp01OKnaaY_mr0vaHiL9b-ECBd9ehH2D815w=.c0cd7294-4b28-4006-bc18-a69f99d23155@github.com>

On Sun, 16 Oct 2022 05:39:23 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From phh at openjdk.org  Thu Oct 20 17:11:31 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 20 Oct 2022 17:11:31 GMT
Subject: [jdk8u-dev] RFR: 8129827: [TEST_BUG] Test
 java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
In-Reply-To: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
References: <P3W5cux9wga_pLq3q6sgJvIXB3IOlQobbUapulM-kG0=.c116d401-f174-4a58-8481-45c928ee2f90@github.com>
Message-ID: <K6MU8KnJ_ED6faSRnwTgoHXftJmDiQ3j0GwXaT3Clik=.be982231-8e04-49ac-a8f9-ee206ee34de7@github.com>

On Sun, 16 Oct 2022 05:39:23 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

Tagged the JBS issue.

Consider backporting JDK-8210039. It has been backported to 11u in order to make subsequent backports easier. Same for 8u.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/141

From duke at openjdk.org  Thu Oct 20 19:42:49 2022
From: duke at openjdk.org (Joshua Cao)
Date: Thu, 20 Oct 2022 19:42:49 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
Message-ID: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>

Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:

* fix file paths
* affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
* conflict in copyright year

Rest is clean.

-------------

Commit messages:
 - 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

Changes: https://git.openjdk.org/jdk8u-dev/pull/145/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=145&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-6829250
  Stats: 9 lines in 1 file changed: 6 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/145.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/145/head:pull/145

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From duke at openjdk.org  Thu Oct 20 20:19:01 2022
From: duke at openjdk.org (Joshua Cao)
Date: Thu, 20 Oct 2022 20:19:01 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
Message-ID: <FfnUSTku3kOUPM4UK_kWxc-KJS4xcE2npecRf1fc73I=.762585ad-4c9f-4fd7-a9c0-2a3901bad6bb@github.com>

On Thu, 20 Oct 2022 19:33:00 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
> 
> * fix file paths
> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
> * conflict in copyright year
> 
> Rest is clean.

Windows tier1 failure is unrelated to this change.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From phh at openjdk.org  Thu Oct 20 20:46:58 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 20 Oct 2022 20:46:58 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
Message-ID: <OlMOiG_vXw7t77N-3Gv3NHUxHBTJ9OyYVD761Abepgc=.9073f8aa-aaaf-477b-832b-f0bbeaff4fa4@github.com>

On Thu, 20 Oct 2022 19:33:00 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
> 
> * fix file paths
> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
> * conflict in copyright year
> 
> Rest is clean.

Lgtm, but please check the windows-x64 test failure: com/sun/jdi/DoubleAgentTest.java

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From peterz at openjdk.org  Fri Oct 21 09:33:29 2022
From: peterz at openjdk.org (Peter Zhelezniakov)
Date: Fri, 21 Oct 2022 09:33:29 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java fails
 after JDK-8078024 8u backport
Message-ID: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>

This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.

The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

-------------

Commit messages:
 - 8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Changes: https://git.openjdk.org/jdk8u-dev/pull/146/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=146&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8265527
  Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/146.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/146/head:pull/146

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From sgehwolf at openjdk.org  Fri Oct 21 10:16:01 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 21 Oct 2022 10:16:01 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
Message-ID: <eaDFrCcIdG1KjDQWNBoQc4g5gCw3hS5VpYQo-aRToB0=.198dcec0-ba2d-4b4e-9a35-1ec1696e9a85@github.com>

On Fri, 21 Oct 2022 09:28:11 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
> 
> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

@petermz Thanks, please enable testing on your fork (it won't run this test, but anyway).

@zzambers Please take a look when you get a chance.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From phh at openjdk.org  Fri Oct 21 13:07:43 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 21 Oct 2022 13:07:43 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
Message-ID: <2Q7-aqj1kLHLBJQVp4Fwhb4Vvtmiyh4yNFBKOouQBL0=.f9dc21c0-a8fb-4760-bde7-23dc042369d0@github.com>

On Thu, 20 Oct 2022 19:33:00 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
> 
> * fix file paths
> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
> * conflict in copyright year
> 
> Rest is clean.

And I see you've already checked, so all good. :)

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From sgehwolf at openjdk.org  Fri Oct 21 14:37:26 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 21 Oct 2022 14:37:26 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
Message-ID: <82WJpUxXGtqDHEN-ArmUWh2__Tjpg7qGstYSLwBUnzg=.8345eb93-722f-4786-8e42-734b91597a8b@github.com>

On Fri, 2 Sep 2022 07:08:22 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removing generated-configure.sh from PR

It would be good if some Windows build person could review this patch as well.

hotspot/src/share/vm/utilities/globalDefinitions_visCPP.hpp line 87:

> 85: #ifndef UINT64_C
> 86: #define UINT64_C(c) (c ## ui64)
> 87: #endif

These removals aren't in the original changeset. See JDK-8272714 and JDK-8272214. I guess we should conditionalize on the VS version in use if that's a problem?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From sgehwolf at openjdk.org  Fri Oct 21 14:39:06 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 21 Oct 2022 14:39:06 GMT
Subject: [jdk8u-dev] RFR: 8206456: [TESTBUG] docker jtreg tests fail on
 systems without cpuset.effective_cpus / cpuset.effective_mems
In-Reply-To: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
References: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
Message-ID: <mgIfRygRE0dORzzwvxAQ6yOU0pJwQy_M9W96RUhYpm4=.942b496a-1004-41cb-b45d-125f3f2fe476@github.com>

On Thu, 22 Sep 2022 13:55:48 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 6fc4db4799599df66a2cf5207068336ce68136ff to jdk8u-dev.
> 
> It's a test-only change, that I wish to backport as part of cgroups v2 support. Whilst not directly cgroups v2 specific, this will ease further backports by reducing merge conflicts.
> 
> The original commit touched two files: MetricsCpuTester.java and MetricsTester.java. This backport only touches MetricsCpuTester.java. The changes from the original comit to MetricsTester.java were already merged into jdk8u-dev with "8223147: JFR Backport...".

@jmtd This seems to have the approval flags. Feel free to integrate.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/123

From sgehwolf at openjdk.org  Fri Oct 21 14:56:08 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 21 Oct 2022 14:56:08 GMT
Subject: [jdk8u-dev] RFR: 8294357: (tz) Update Timezone Data to 2022d
In-Reply-To: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
References: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
Message-ID: <TZAOwYTGLIXN0_y4KgbKO1nqSAM7ceL6-XTAoIunyaU=.2b0a0452-4077-4c2b-bbca-068420933cc6@github.com>

On Sun, 16 Oct 2022 01:34:47 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Mostly clean backport of tzdata2022d update from 11u, with paths adjusted and files duplicated for `jdk/test`. There are no tzdata differences between the vanguard and rearguard update.
> 
> In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970
> 
> Tests in `java/util/TimeZone` and `sun/util/calendar` all pass.

Looks OK to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/138

From sgehwolf at openjdk.org  Fri Oct 21 15:04:00 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 21 Oct 2022 15:04:00 GMT
Subject: [jdk8u-dev] RFR: 8295173: (tz) Update Timezone Data to 2022e
In-Reply-To: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
References: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
Message-ID: <gcfKWFNjnTEI7syA8hZYlSWXinD26C23Z4UyhP9rD9w=.80af7591-ba58-42f9-bf62-23e2867c010e@github.com>

On Sun, 16 Oct 2022 02:39:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.
> 
> Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From jdowland at openjdk.org  Fri Oct 21 16:33:57 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Fri, 21 Oct 2022 16:33:57 GMT
Subject: [jdk8u-dev] Integrated: 8206456: [TESTBUG] docker jtreg tests fail on
 systems without cpuset.effective_cpus / cpuset.effective_mems
In-Reply-To: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
References: <VlZ4sWF8VfCqG492NujqEI-SJZdRZshHUqZvaMLo9Z0=.7a2ad58d-b523-4052-a901-f2381b1cf1c7@github.com>
Message-ID: <h3twTty9taLHy9Sj3EKYoqfLi43FB_OTQov7qEmkMgY=.e51b833d-36bf-4457-925d-b9e0b2a3808a@github.com>

On Thu, 22 Sep 2022 13:55:48 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 6fc4db4799599df66a2cf5207068336ce68136ff to jdk8u-dev.
> 
> It's a test-only change, that I wish to backport as part of cgroups v2 support. Whilst not directly cgroups v2 specific, this will ease further backports by reducing merge conflicts.
> 
> The original commit touched two files: MetricsCpuTester.java and MetricsTester.java. This backport only touches MetricsCpuTester.java. The changes from the original comit to MetricsTester.java were already merged into jdk8u-dev with "8223147: JFR Backport...".

This pull request has now been integrated.

Changeset: 1f8eafd8
Author:    Jonathan Dowland <jdowland at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1f8eafd8a05ce979eefd9ed45f5e7c6fb5fc5f2d
Stats:     14 lines in 1 file changed: 6 ins; 0 del; 8 mod

8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems

The changes to MetricsTester.java in the original commit were merged in "8223147: JFR Backport".

Reviewed-by: sgehwolf
Backport-of: 6fc4db4799599df66a2cf5207068336ce68136ff

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/123

From duke at openjdk.org  Fri Oct 21 16:59:54 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Fri, 21 Oct 2022 16:59:54 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
Message-ID: <QEds7lEdLs4CNNDaQrX9E0v-HEZgis46MvnbeO4osls=.db496a1b-13b5-4746-930f-d0656e7d7b2d@github.com>

On Fri, 2 Sep 2022 07:08:22 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removing generated-configure.sh from PR

The definitions now are done by including of `stdint.h` that is surely available even in msvs 2010 (as I remember a far earlier). I have no idea why they were declared localy. Looks like I forgot to mention this deviation from the original changeset.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From duke at openjdk.org  Fri Oct 21 19:40:52 2022
From: duke at openjdk.org (zzambers)
Date: Fri, 21 Oct 2022 19:40:52 GMT
Subject: [jdk8u-dev] RFR: 6829250: Reg test:
 java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
In-Reply-To: <FfnUSTku3kOUPM4UK_kWxc-KJS4xcE2npecRf1fc73I=.762585ad-4c9f-4fd7-a9c0-2a3901bad6bb@github.com>
References: <vYo8xnt2GA6jyezcthEVhMJIumpcgTIzW3BeoND0W2Q=.676694b2-8069-4aa3-8c49-96e19565c05f@github.com>
 <FfnUSTku3kOUPM4UK_kWxc-KJS4xcE2npecRf1fc73I=.762585ad-4c9f-4fd7-a9c0-2a3901bad6bb@github.com>
Message-ID: <E9FKFo5LlRwQZmG4z7wwZGAfIfLngxlFuOpkKEshy7U=.5e59e9cc-a363-4dfd-9b80-c0c86b38fc56@github.com>

On Thu, 20 Oct 2022 20:16:47 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> Passes `jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java` on my Windows machine. Not a clean backport due to:
>> 
>> * fix file paths
>> * affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
>> * conflict in copyright year
>> 
>> Rest is clean.
>
> Windows tier1 failure is unrelated to this change.

@caojoshua @phohensee, There was a problem with com/sun/jdi/DoubleAgentTest.java test being unreliable. Problem was already addressed by backport [1].

[1] https://github.com/openjdk/jdk8u-dev/pull/143

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/145

From t.glaser at tarent.de  Fri Oct 21 20:09:59 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Fri, 21 Oct 2022 22:09:59 +0200 (CEST)
Subject: 8u352 regression: segfaults around javadoc
In-Reply-To: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
References: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
Message-ID: <c44736cf-29a7-5cca-bc7c-1905cad4a8b@tarent.de>

On Fri, 21 Oct 2022, Thorsten Glaser wrote:

> Hi,
> 
> I?ve been building 8u352-ga on i386 for Debian unstable, 11, 10, 9,
> 8 and 7, and out of these, some failed to build:
> 
> ? unstable
> ? bullseye (11)
> ? wheezy (7)
> 
> The latter is basically out of support, so I?d be willing to wave
> that away. Unstable uses GCC 12 now instead of GCC 11; nobody replied
> to my earlier inquiry whether that works, but I assumed so.
> 
> But bullseye is Debian stable, using GCC 10, and the previous build
> very much worked.
> 
> I can?t shake the feeling that there?s a systematic error somewhere,
> even if that doesn?t explain why the other releases built.
> 
> I?m attaching:

This hit the mailing list size limit. Instead,
$ wget https://evolvis.org/~tg/8u352-ftbfs.txz

> ? for the three failed builds, the full corresponding build log,
>   the hs_err_pid*.log files, and the successful build logs for i386
>   of the 8u342-b07 version which was the previous build
> ? for buster (10) the successful build log of 8u352-ga
> 
> The latter are for comparison, in case that helps.
> 
> I?ve also still got the build chroots available and can extract more
> data and run commands in them, and I can keep them available for some
> time. Maybe that helps.
> 
> I?m a bit wary of the failed times?
> 
> I: Current time: Thu Oct 20 23:13:36 UTC 2022
> I: Current time: Thu Oct 20 22:00:22 UTC 2022
> I: Current time: Thu Oct 20 23:13:37 UTC 2022
> 
> ? as two happened at the same time. (The successful builds were
> finished at around 02:02?02:10 that night; I started the sid build
> first, the others (with nocheck) later.) However, there is nothing
> in dmesg at all, and nothing in syslog around that time.
> 
> Thanks in advance,
> //mirabilos
> -- 
> Infrastrukturexperte ? tarent solutions GmbH
> Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
> Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
> HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
> Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
> 
>                         ****************************************************
> /?\ The UTF-8 Ribbon
> ??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
> ??? HTML eMail! Also,     https://www.tarent.de/newsletter
> ??? header encryption!
>                         ****************************************************

//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From t.glaser at tarent.de  Fri Oct 21 20:19:06 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Fri, 21 Oct 2022 22:19:06 +0200 (CEST)
Subject: 8u352 regression: segfaults around javadoc
In-Reply-To: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
References: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
Message-ID: <89bc1148-ce30-e9e1-13d1-29c5e219d3bd@tarent.de>

On Fri, 21 Oct 2022, Thorsten Glaser wrote:

> I?ve also still got the build chroots available and can extract more
> data and run commands in them, and I can keep them available for some
> time. Maybe that helps.

corekeeper also saved these:

  2105544  82932 -rw-------   1 pbuilder nogroup  84918272 Okt 20 21:19 /var/crash/1234/2560-1234-1234-6-1666293592-tglase.lan.tarent.de--tmp-buildd-openjdk-8-8u352-ga-build-bootcycle-build-images-j2sdk-image-bin-java.core
  2105547 489276 -rw-------   1 pbuilder nogroup  501014528 Okt 21 01:13 /var/crash/1234/26100-1234-1234-6-1666307589-tglase.lan.tarent.de--usr-lib-jvm-java-8-openjdk-i386-jre-bin-java.core
  2097350  87924 -rw-------   1 pbuilder nogroup   90030080 Okt 20 20:18 /var/crash/1234/19168-1234-1234-6-1666289925-tglase.lan.tarent.de--tmp-buildd-openjdk-8-8u352-ga-build-bootcycle-build-images-j2sdk-image-bin-java.core
  2105543  82932 -rw-------   1 pbuilder nogroup   84918272 Okt 20 21:19 /var/crash/1234/2527-1234-1234-6-1666293592-tglase.lan.tarent.de--tmp-buildd-openjdk-8-8u352-ga-build-bootcycle-build-images-j2sdk-image-bin-java.core
  2105545 887884 -rw-------   1 pbuilder nogroup  909189120 Okt 21 00:00 /var/crash/1234/18409-1234-1234-6-1666303209-tglase.lan.tarent.de--usr-lib-jvm-java-8-openjdk-i386-jre-bin-java.core
  2102190  90000 -rw-------   1 pbuilder nogroup   92160000 Okt 20 20:19 /var/crash/1234/19723-1234-1234-6-1666289943-tglase.lan.tarent.de--tmp-buildd-openjdk-8-8u352-ga-build-bootcycle-build-images-j2sdk-image-bin-java.core
  2105546 525904 -rw-------   1 pbuilder nogroup  538521600 Okt 21 01:13 /var/crash/1234/25831-1234-1234-6-1666307573-tglase.lan.tarent.de--tmp-buildd-openjdk-8-8u352-ga-build-images-j2sdk-image-bin-java.core

It?s probably tricky to figure out the mapping of these
to the individual cowbuilder chroots though?

bye,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From duke at openjdk.org  Sat Oct 22 02:26:20 2022
From: duke at openjdk.org (zzambers)
Date: Sat, 22 Oct 2022 02:26:20 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
Message-ID: <p5g_UiYHrO1DutQwUjsuWCTP_XZl40kjqvyBMxXghuY=.d38f1f61-ab81-4a8b-8d0b-6314c2da488a@github.com>

On Fri, 21 Oct 2022 09:28:11 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
> 
> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

@petermz Thanks for taking time looking at this

@jerboaa I tested this change by creating branch in my fork where I applied this changeset and enabled langtools_tier1 testing in GHA. It passed on all platforms [1] (including problematic test).

When it comes to compiler messages. I checked compiler messages for jdk8 and jdk11, they are indeed different, but both variants seem OK to me. For reference:
jdk8

javac WhereIntersection.java
WhereIntersection.java:36: error: incompatible types: inference variable T has incompatible bounds
        return f(a, b);
                ^
    upper bounds: Object[],Object
    lower bounds: Float,Integer
  where T is a type-variable:
    T extends Object declared in method <T>f(T,T)
1 error

jdk11

javac WhereIntersection.java
WhereIntersection.java:36: error: incompatible types: inferred type does not conform to upper bound(s)
        return f(a, b);
                ^
    inferred: INT#1
    upper bound(s): Object[],Object
  where INT#1,INT#2 are intersection types:
    INT#1 extends Number,Comparable<? extends INT#2>
    INT#2 extends Number,Comparable<?>
1 error


[1] https://github.com/zzambers/jdk8u-dev/commits/check-examples-test

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From t.glaser at tarent.de  Sat Oct 22 22:28:18 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Sun, 23 Oct 2022 00:28:18 +0200 (CEST)
Subject: 8u352 regression: segfaults around javadoc
In-Reply-To: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
References: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
Message-ID: <ccf8b985-53f3-b87e-2670-4435fd49fa@tarent.de>

Hi,

in a second attempt, 7 (wheezy) again failed, again in javadoc,
but 11 (bullseye) built; unstable is still building for a couple
of hours because it tries the tests (even if some are known to
fail).

This kind of fragility is? not reassuring.

I can think of one possible cause that would make sense. Does
anything in the tests influence other Java processes on the same
machine? The build chroots are just that and also run as the same
Unix user, so they?re not isolatted from each other (on my machine;
those official Debian build machines that run more than one instance
hopefully isolate more but I build on my dev tower).

? otoh, even that?d not explain the SIGSEGV now, would it?

bye,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From peterz at openjdk.org  Mon Oct 24 08:48:45 2022
From: peterz at openjdk.org (Peter Zhelezniakov)
Date: Mon, 24 Oct 2022 08:48:45 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
Message-ID: <alzlihGK8z6dU19g-PKLAQoRjc2JZuSrfutSR_OZlbY=.f5e9493c-6d4b-427c-a32d-891c4f4b6596@github.com>

On Fri, 21 Oct 2022 09:28:11 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
> 
> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

Enabled and ran tests. DoubleAgentTest fails on Windows, but this is a known problem I guess?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From sgehwolf at openjdk.org  Mon Oct 24 09:48:59 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 24 Oct 2022 09:48:59 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <alzlihGK8z6dU19g-PKLAQoRjc2JZuSrfutSR_OZlbY=.f5e9493c-6d4b-427c-a32d-891c4f4b6596@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
 <alzlihGK8z6dU19g-PKLAQoRjc2JZuSrfutSR_OZlbY=.f5e9493c-6d4b-427c-a32d-891c4f4b6596@github.com>
Message-ID: <X1iSsSHYGobLc11Z-Ap9Lq2RtBFBFKXHg0pDQIUvM4k=.c3ea21bb-db18-4c7e-9c65-4464e6e0e776@github.com>

On Mon, 24 Oct 2022 08:45:20 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

> Enabled and ran tests. DoubleAgentTest fails on Windows, but this is a known problem I guess?

Yes, thanks! Should be fixed with: https://github.com/openjdk/jdk8u-dev/commit/58d0281c52f8c1e9642c6fc5bd696235498b0ae2 If you do a merge from master, it should go away.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From t.glaser at tarent.de  Mon Oct 24 13:44:33 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Mon, 24 Oct 2022 15:44:33 +0200 (CEST)
Subject: 8u352 regression: segfaults around javadoc
In-Reply-To: <ccf8b985-53f3-b87e-2670-4435fd49fa@tarent.de>
References: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
 <ccf8b985-53f3-b87e-2670-4435fd49fa@tarent.de>
Message-ID: <eaf52aca-a758-d56d-1fdf-b7bc98fa31b8@tarent.de>

On Sun, 23 Oct 2022, Thorsten Glaser wrote:

> in a second attempt, 7 (wheezy) again failed, again in javadoc,
> but 11 (bullseye) built; unstable is still building for a couple
> of hours because it tries the tests (even if some are known to
> fail).

I?ve uploaded to Debian unstable, and it built on most buildds
(with one new failure that?s unrelated and which I?ll report in
a separate mail).

> This kind of fragility is? not reassuring.

So if there?s nothing systematically wrong let?s hope it?s either
something with my desktop or that it doesn?t like to be built in
this much parallelity.

bye,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From t.glaser at tarent.de  Mon Oct 24 13:45:56 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Mon, 24 Oct 2022 15:45:56 +0200 (CEST)
Subject: 8u352 regression: FTBFS on MIPS
Message-ID: <d32edacc-69c4-c193-8e68-eb63d5b428c@tarent.de>

https://buildd.debian.org/status/fetch.php?pkg=openjdk-8&arch=mipsel&ver=8u352-ga-1&stamp=1666535711&raw=0

[?]D -MP -MF ../generated/dependencies/classLoader.o.d -fpch-deps -o classLoader.o /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/classfile/classLoader.cpp
{standard input}: Assembler messages:
{standard input}:196886: Error: branch out of range

I can only assume something got bigger and therefore a short branch
must be converted to a long branch, or something.

bye,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From peterz at openjdk.org  Mon Oct 24 14:38:54 2022
From: peterz at openjdk.org (Peter Zhelezniakov)
Date: Mon, 24 Oct 2022 14:38:54 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport [v2]
In-Reply-To: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
Message-ID: <1qu35s9_3ztoHI4n638sap8gyA6os5o6EzC8AodOAAM=.67c50dd4-3517-4535-9f94-7e0289e1f824@github.com>

> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
> 
> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

Peter Zhelezniakov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/146/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=146&range=01
  Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/146.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/146/head:pull/146

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From t.glaser at tarent.de  Mon Oct 24 19:11:00 2022
From: t.glaser at tarent.de (Thorsten Glaser)
Date: Mon, 24 Oct 2022 21:11:00 +0200 (CEST)
Subject: 8u352 regression: segfaults around javadoc
In-Reply-To: <ccf8b985-53f3-b87e-2670-4435fd49fa@tarent.de>
References: <a5fff4e2-1ce1-42f2-fcc2-d2581fc8b9d8@tarent.de>
 <ccf8b985-53f3-b87e-2670-4435fd49fa@tarent.de>
Message-ID: <2762faae-5b8c-e4a8-2831-df2367dc9cb6@tarent.de>

On Sun, 23 Oct 2022, Thorsten Glaser wrote:

> Does
> anything in the tests influence other Java processes on the same
> machine? The build chroots are just that and also run as the same
> Unix user, so they?re not isolatted from each other (on my machine;
> those official Debian build machines that run more than one instance
> hopefully isolate more but I build on my dev tower).
> 
> ? otoh, even that?d not explain the SIGSEGV now, would it?

This theory gets closer.

I rebuilt unstable(+tests),11,7 another time. 11 and unstable passed
while 7 required a third run.

Then I built 11,10,9,8,7 for amd64 all at once, but none of them
running the testsuite. They all passed, easily.

So either something broke i386 or the testsuite breaks other
parallel builds. Given i386 also builds fine, on the first try,
in the Debian buildd infrastructure, I lean towards the latter.

Meow,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

From duke at openjdk.org  Tue Oct 25 00:40:40 2022
From: duke at openjdk.org (Joshua Cao)
Date: Tue, 25 Oct 2022 00:40:40 GMT
Subject: [jdk8u-dev] RFR: 8295288: Some vm_flags tests associate with a wrong
 BugID
Message-ID: <Ff_cRFUnkmIeHWv5mVJZZqPzv-XZoTGLKVwqmq4O4KY=.08e33bf2-6c96-46de-b4af-b0d0af4d93ad@github.com>

Backport is not clean. Test header is different between JDK8 and JDK11. All changed tests passing.

-------------

Commit messages:
 - 8295288: Some vm_flags tests associate with a wrong BugID

Changes: https://git.openjdk.org/jdk8u-dev/pull/147/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=147&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295288
  Stats: 5 lines in 5 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/147.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/147/head:pull/147

PR: https://git.openjdk.org/jdk8u-dev/pull/147

From peterz at openjdk.org  Tue Oct 25 04:24:51 2022
From: peterz at openjdk.org (Peter Zhelezniakov)
Date: Tue, 25 Oct 2022 04:24:51 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport [v2]
In-Reply-To: <1qu35s9_3ztoHI4n638sap8gyA6os5o6EzC8AodOAAM=.67c50dd4-3517-4535-9f94-7e0289e1f824@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
 <1qu35s9_3ztoHI4n638sap8gyA6os5o6EzC8AodOAAM=.67c50dd4-3517-4535-9f94-7e0289e1f824@github.com>
Message-ID: <jiZkCZ9dMqgcffc3SLfgVJRFSiqjeK6k_IJUZLrBf1s=.0fa1d41a-ca9c-466a-8740-86e49a08134c@github.com>

On Mon, 24 Oct 2022 14:38:54 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

>> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
>> 
>> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.
>
> Peter Zhelezniakov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Yep, that worked!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From sgehwolf at openjdk.org  Tue Oct 25 08:49:25 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Oct 2022 08:49:25 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport [v2]
In-Reply-To: <1qu35s9_3ztoHI4n638sap8gyA6os5o6EzC8AodOAAM=.67c50dd4-3517-4535-9f94-7e0289e1f824@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
 <1qu35s9_3ztoHI4n638sap8gyA6os5o6EzC8AodOAAM=.67c50dd4-3517-4535-9f94-7e0289e1f824@github.com>
Message-ID: <PVkrMyUUe582dox16h2D5SlbI2p4nULoGpiKxi3gTWs=.a64849ab-2252-4a94-8c6d-6c43ae59aa52@github.com>

On Mon, 24 Oct 2022 14:38:54 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

>> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
>> 
>> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.
>
> Peter Zhelezniakov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From sgehwolf at openjdk.org  Tue Oct 25 08:49:26 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Oct 2022 08:49:26 GMT
Subject: [jdk8u-dev] RFR: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <X1iSsSHYGobLc11Z-Ap9Lq2RtBFBFKXHg0pDQIUvM4k=.c3ea21bb-db18-4c7e-9c65-4464e6e0e776@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
 <alzlihGK8z6dU19g-PKLAQoRjc2JZuSrfutSR_OZlbY=.f5e9493c-6d4b-427c-a32d-891c4f4b6596@github.com>
 <X1iSsSHYGobLc11Z-Ap9Lq2RtBFBFKXHg0pDQIUvM4k=.c3ea21bb-db18-4c7e-9c65-4464e6e0e776@github.com>
Message-ID: <Jka_ER-O4h2m3w8cr078VFpN0Vko1EZrrVacDaFPefQ=.f3128891-f6e1-4e08-9da8-2cf71500282c@github.com>

On Mon, 24 Oct 2022 09:46:35 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Enabled and ran tests. DoubleAgentTest fails on Windows, but this is a known problem I guess?
>
>> Enabled and ran tests. DoubleAgentTest fails on Windows, but this is a known problem I guess?
> 
> Yes, thanks! Should be fixed with: https://github.com/openjdk/jdk8u-dev/commit/58d0281c52f8c1e9642c6fc5bd696235498b0ae2 If you do a merge from master, it should go away.

> @jerboaa I tested this change by creating branch in my fork where I applied this changeset and enabled langtools_tier1 testing in GHA. It passed on all platforms [1] (including problematic test).
> 
> When it comes to compiler messages. I checked compiler messages for jdk8 and jdk11, they are indeed different, but both variants seem OK to me. For reference: jdk8
> 
> ```
> javac WhereIntersection.java
> WhereIntersection.java:36: error: incompatible types: inference variable T has incompatible bounds
>         return f(a, b);
>                 ^
>     upper bounds: Object[],Object
>     lower bounds: Float,Integer
>   where T is a type-variable:
>     T extends Object declared in method <T>f(T,T)
> 1 error
> ```
> 
> jdk11
> 
> ```
> javac WhereIntersection.java
> WhereIntersection.java:36: error: incompatible types: inferred type does not conform to upper bound(s)
>         return f(a, b);
>                 ^
>     inferred: INT#1
>     upper bound(s): Object[],Object
>   where INT#1,INT#2 are intersection types:
>     INT#1 extends Number,Comparable<? extends INT#2>
>     INT#2 extends Number,Comparable<?>
> 1 error
> ```
> 
> [1] https://github.com/zzambers/jdk8u-dev/commits/check-examples-test

Thanks!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From sgehwolf at openjdk.org  Tue Oct 25 13:24:48 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Oct 2022 13:24:48 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <QEds7lEdLs4CNNDaQrX9E0v-HEZgis46MvnbeO4osls=.db496a1b-13b5-4746-930f-d0656e7d7b2d@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
 <QEds7lEdLs4CNNDaQrX9E0v-HEZgis46MvnbeO4osls=.db496a1b-13b5-4746-930f-d0656e7d7b2d@github.com>
Message-ID: <RzwySKGpVKTabZOzP-SYGtqrsBgfzWHic3Tk9lWaNUw=.3f064fe1-207e-404c-bf88-cca4bc36bc33@github.com>

On Fri, 21 Oct 2022 16:56:21 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> The definitions now are done by including of `stdint.h` that is surely available even in msvs 2010 (as I remember a far earlier). I have no idea why they were declared localy. Looks like I forgot to mention this deviation from the original changeset.

OK, thanks.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From sgehwolf at openjdk.org  Tue Oct 25 15:20:57 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Oct 2022 15:20:57 GMT
Subject: [jdk8u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base
 so as to recognize unified hierarchy [v3]
In-Reply-To: <FLlA7PrspxFAfPK8MEPaC8zxm4jAtcVJbDJe-rW81_E=.4fdd32af-f73c-42e3-884d-eb20ac8f3c9d@github.com>
References: <EjFBNmZQPgyzMqkDVGk_gvFKyhhxRjrFPOD40OFDkAw=.ee88997c-64b8-46d0-b82d-eec02f0d45b3@github.com>
 <FLlA7PrspxFAfPK8MEPaC8zxm4jAtcVJbDJe-rW81_E=.4fdd32af-f73c-42e3-884d-eb20ac8f3c9d@github.com>
Message-ID: <d1yfgdJ_elWor5TLPo_pe1fNtE2-qQHAwxyEWMc-cU4=.817ecbe4-268f-43b5-8fba-6de61c85f288@github.com>

On Mon, 26 Sep 2022 10:13:25 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of [4def210a22faaec6b47912dd314e6365ea48d28f](https://github.com/openjdk/jdk/commit/4def210a22faaec6b47912dd314e6365ea48d28f) for jdk8u-dev as part of an effort to backport cgroups v2 support.
>> 
>> It does not apply clean. Paths need unshuffling. A number of changes were needed for 8u support. I've structured the PR as separate commits, with each change made in a separate commit for (hopefully) ease of review.
>> 
>> Not all the new tests pass:     TestDockerMemoryMetrics  failing one, specifically:
>> 
>>     Exception in thread "main" java.lang.RuntimeException: Memory and swap limit not equal, expected : [209715200, 1073741824], got : [209715200, 864026624]
>> 
>> I think this is fixed in a further patch to backport, and will confirm.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - TestCgroupSubsystemController: rework use of Files.writeString
>  - CgroupSubsystemController: fix library paths
>    
>    We need the testlibrary copy of FileUtils but the test.lib.util copy of
>    Utils (method createTempDirectory is missing from the testlib copy)
>  - TestCgroupSubsystemController: fix jtreg @library path
>  - Replace Arrays.compare with Arrays.equals
>    
>    jdk8u does not have Arrays.compare()
>  - incorporate (part of) 8275713: TestDockerMemoryMetrics test fails on recent runc
>    
>    The main hunk from 8275713 was rolled up in the changes for 8231111.
>    This line is also necessary.
>  - update mapfile for new JNI method name
>  - tests for the backport
>    
>    two files had fairly significant merge conflicts, eyeball only to resolve
>    
>    haven't run any of them yet -- will depend on the rest of the patch
>  - CgroupSubsystemFactory: remove logging lines
>    
>    jdk8u doesn't have java.lang.System.Logger. There's no existing logging
>    in place for other classes in the Metrics/platform/etc family that I can
>    see, so remove it.
>  - Metrics => CgroupV1Subsystem.java
>    
>    unshuffle, rename, resolve unclean hunks although I'm not sure why they
>    didn't apply, they look trivial and the context is the same, will look
>    closer
>  - Metrics.java: easy commit, mostly doc-only hunks
>  - ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/91dc4a09...0ea3c608

Looks mostly good. A couple of suggestions.

jdk/test/jdk/internal/platform/docker/MetricsMemoryTester.java line 32:

> 30: 
> 31:     private static final long UNLIMITED = -1;
> 32: 

This hunk is part of JDK-8275713, which gets backported as part of this patch. Please do `/issue add JDK-8275713` so it gets a record of it being backported in JBS.

jdk/test/jdk/internal/platform/docker/MetricsMemoryTester.java line 133:

> 131:             // limit back.
> 132:             if (kmemlimit != UNLIMITED && limit != kmemlimit) {
> 133:                 throw new RuntimeException("Kernel Memory limit not equal, expected : ["

Also code from JDK-8275713.

jdk/test/lib/jdk/test/lib/containers/cgroup/CgroupMetricsTester.java line 56:

> 54:             if (b.compareTo(BigInteger.valueOf(Long.MAX_VALUE)) > 0) {
> 55:                 return overflowRetval;
> 56:             }

This is code from JDK-8228585 which wasn't previously part of 8u. Please add `/issue add JDK-8228585` to this backport since this backport will bring code of that bug with it.

jdk/test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 424:

> 422:         Integer[] newVal = CgroupMetricsTester.convertCpuSetsToArray(cpusstr);
> 423:         Arrays.sort(newVal);
> 424:         if (! Arrays.equals(oldVal, newVal)) {

Style nit: `!Arrays.equals(..)` over `! Arrays.equals(...)`. Drop the space. This repeats a couple of times in this file.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/121

From duke at openjdk.org  Tue Oct 25 21:04:43 2022
From: duke at openjdk.org (zzambers)
Date: Tue, 25 Oct 2022 21:04:43 GMT
Subject: [jdk8u-dev] RFR: 8295915: Problemlist compiler/rtm failures specific
 to 8u
Message-ID: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>

I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
List of tests follows:

compiler/rtm/locking/TestRTMTotalCountIncrRate.java
compiler/rtm/locking/TestUseRTMAfterLockInflation.java
compiler/rtm/locking/TestUseRTMForInflatedLocks.java
compiler/rtm/locking/TestUseRTMForStackLocks.java
compiler/rtm/method_options/TestUseRTMLockElidingOption.java

These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.

Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].

[1] https://bugs.openjdk.org/browse/JDK-8183263
[2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test

-------------

Commit messages:
 - Problemlist rtm failures specific to 8u

Changes: https://git.openjdk.org/jdk8u-dev/pull/148/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=148&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295915
  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/148.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/148/head:pull/148

PR: https://git.openjdk.org/jdk8u-dev/pull/148

From andrew at openjdk.org  Wed Oct 26 04:53:38 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 26 Oct 2022 04:53:38 GMT
Subject: [jdk8u-dev] RFR: 8294357: (tz) Update Timezone Data to 2022d
In-Reply-To: <TZAOwYTGLIXN0_y4KgbKO1nqSAM7ceL6-XTAoIunyaU=.2b0a0452-4077-4c2b-bbca-068420933cc6@github.com>
References: <TZRyaYQZ4dZD8dtaqy6z25bBMhglPs9dft1_JwTFFBs=.a98fe657-d362-4d6e-8524-d12f1d7c94d4@github.com>
 <TZAOwYTGLIXN0_y4KgbKO1nqSAM7ceL6-XTAoIunyaU=.2b0a0452-4077-4c2b-bbca-068420933cc6@github.com>
Message-ID: <Kc2bAo-TljqjjgFFfYEYnnz2-FftwhEKlU554uuvZ5g=.00f3595d-33ae-4e2f-bb66-51627c7babee@github.com>

On Fri, 21 Oct 2022 14:52:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Mostly clean backport of tzdata2022d update from 11u, with paths adjusted and files duplicated for `jdk/test`. There are no tzdata differences between the vanguard and rearguard update.
>> 
>> In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970
>> 
>> Tests in `java/util/TimeZone` and `sun/util/calendar` all pass.
>
> Looks OK to me.

Thanks @jerboaa . Bug flagged with `jdk8u-fix-request`.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/138

From andrew at openjdk.org  Wed Oct 26 04:53:39 2022
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 26 Oct 2022 04:53:39 GMT
Subject: [jdk8u-dev] RFR: 8295173: (tz) Update Timezone Data to 2022e
In-Reply-To: <gcfKWFNjnTEI7syA8hZYlSWXinD26C23Z4UyhP9rD9w=.80af7591-ba58-42f9-bf62-23e2867c010e@github.com>
References: <SjXlJsl6FsFsvvmLJAtHe_6W97g88XKADweHdO9bKEU=.b1cceafb-1d85-41dc-bcda-084caa77a39b@github.com>
 <gcfKWFNjnTEI7syA8hZYlSWXinD26C23Z4UyhP9rD9w=.80af7591-ba58-42f9-bf62-23e2867c010e@github.com>
Message-ID: <pqe9m9nLKEooPVB_6MVAaMMkgXJCkM-u4Jdt5f7sySs=.1fe7b01e-f5c5-4b7e-9c6b-b8b5f2ded74f@github.com>

On Fri, 21 Oct 2022 15:00:30 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Mostly clean backport of tzdata2022e update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.
>> 
>> Tests in `java/util/TimeZone`, `java/time/test` and `sun/util/calendar` all pass.
>
> Marked as reviewed by sgehwolf (Reviewer).

Thanks @jerboaa . Bug flagged with `jdk8u-fix-request`.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/139

From peterz at openjdk.org  Wed Oct 26 05:40:39 2022
From: peterz at openjdk.org (Peter Zhelezniakov)
Date: Wed, 26 Oct 2022 05:40:39 GMT
Subject: [jdk8u-dev] Integrated: 8265527: tools/javac/diags/CheckExamples.java
 fails after JDK-8078024 8u backport
In-Reply-To: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
References: <6QFXPKNZWJI24UXFRcENO5QzHoG-85WwLvHww2Qt640=.41e40712-d7b7-46d8-b5d1-33feee6fc497@github.com>
Message-ID: <ln8yH8jUd1DsPJH9UA7UGAfEePy_fDpPxf30PTtCDXI=.dd59c7d9-0af2-4619-9ff5-79d5f6818e9e@github.com>

On Fri, 21 Oct 2022 09:28:11 GMT, Peter Zhelezniakov <peterz at openjdk.org> wrote:

> This fix reverts some of the changes made to jtreg tests by the 8078024 backport. Changes to javac itself are not reverted.
> 
> The failing test checks error messages emitted by javac while compiling invalid code. The exact messages differ in JDKs 8 and 9, where 8078024 fix was backported from. So this fix updates the expected messages to match those issued by JDK8.

This pull request has now been integrated.

Changeset: f04ad96c
Author:    Peter Zhelezniakov <peterz at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/f04ad96cf53385c9f8aa071a4167ad7790cb8466
Stats:     5 lines in 2 files changed: 1 ins; 1 del; 3 mod

8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/146

From duke at openjdk.org  Wed Oct 26 16:21:16 2022
From: duke at openjdk.org (zzambers)
Date: Wed, 26 Oct 2022 16:21:16 GMT
Subject: [jdk8u-dev] RFR: 8295950: Enable langtools/tier1 in GHA for 8u
Message-ID: <RFMYiFVPX_EIUR6yTWK6fNYo0D2X84ihb5JmCItDbeQ=.e3ab7f5e-dd64-472b-b0b8-5c444b01284c@github.com>

It is now possible to enable langtools/tier1 in Github actions for jdk8u as the only failure there has been resolved [1].

[1] https://bugs.openjdk.org/browse/JDK-8265527

-------------

Commit messages:
 - Enabled langtools/tier1 in GHA

Changes: https://git.openjdk.org/jdk8u-dev/pull/149/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=149&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295950
  Stats: 15 lines in 1 file changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/149.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/149/head:pull/149

PR: https://git.openjdk.org/jdk8u-dev/pull/149

From duke at openjdk.org  Wed Oct 26 20:56:46 2022
From: duke at openjdk.org (duke)
Date: Wed, 26 Oct 2022 20:56:46 GMT
Subject: [jdk8u-dev] Withdrawn: JDK-8292998: Clean Secmod temporary NSS DB
 directory before test execution
In-Reply-To: <piR9O4mG4K0YMl1iwnQVSjl9yswmeISoUJfH0Ba-1Pw=.473c9e1c-8345-493b-b233-2bda5e9a91fd@github.com>
References: <piR9O4mG4K0YMl1iwnQVSjl9yswmeISoUJfH0Ba-1Pw=.473c9e1c-8345-493b-b233-2bda5e9a91fd@github.com>
Message-ID: <-mMXLtLoShOeuaro1-2L3nzaIlzZtPB_H9dBNdPGQUY=.04cc00ef-e3c3-4f75-b406-983c2e0be922@github.com>

On Fri, 26 Aug 2022 22:26:06 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hello,
> 
> I'd like to propose this fix as described in https://bugs.openjdk.org/browse/JDK-8292998
> 
> The temporary directory used by Secmod tests to copy NSS DB files is deleted (which includes all its files and, potentially, subdirectories) and created empty again before running the test. I decided to implement the recursive delete function here for 3 reasons: 1) it's a short and simple function,  2) convenience (we don't have to link every current Secmod test to a test library) and 3) increase chances of backporting future Secmod tests cleanly. Contrary to the approach of setting a minimum jtreg version required, the scope of this change are Secmod tests only and the risk should be minimal.
> 
> Thanks,
> Martin.-

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/115

From jdowland at openjdk.org  Thu Oct 27 10:26:45 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Thu, 27 Oct 2022 10:26:45 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <dwhqhEGC5VLBGESVdDZXrw83Dadmc74x6ipKtaUO7JA=.e21e4615-d06e-49b3-a7e1-55f7e2cbd315@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>
 <dwhqhEGC5VLBGESVdDZXrw83Dadmc74x6ipKtaUO7JA=.e21e4615-d06e-49b3-a7e1-55f7e2cbd315@github.com>
Message-ID: <0C4XQTYeRA8vdKeOXGMjDtV5FB0hCly7f3IEGqOuibQ=.77680fb3-12f7-443e-956d-e2b7d6a1f1e7@github.com>

On Wed, 12 Oct 2022 10:35:01 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp line 103:
>> 
>>> 101:     CgroupV1Controller* _cpuset = NULL;
>>> 102:     CachingCgroupController* _cpu = NULL;
>>> 103:     CgroupV1Controller* _cpuacct = NULL;
>> 
>> For arm32 platform, if the c++ compiler version being used is earlier than 11, then the non-static member initialization will cause compilation failure.
>
> Thanks for pointing this out! I'll investigate how to best address that in this patch series.

I've spent some time trying to understand this issue, and this is my current understanding of it. ARM32 is the circumstance which surfaced the problem, but this is not an ARM32 problem. The syntax here was introduced in C++11. The minimal (GCC) compiler version stated for JDK8u is GCC 4.3, which has only partial, experimental support for C++11. You didn't state what compiler you were using but I'm going to assume it's one in the supported list for jdk8u. What I take from this is, JDK8u can't use all C++11 features, since some of the supported compiler-versions don't have all C++11 features; and in particular this feature.

These lines of code are unchanged in jdk mainline at the moment, however, jdk has moved forward the minimal supported compiler version. I doubt that a fix for this would be received favourably in jdk mainline, so we probably need to address it in jdk8u-dev directly (not via backport).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From poonam at openjdk.org  Fri Oct 28 21:15:46 2022
From: poonam at openjdk.org (Poonam Bajaj)
Date: Fri, 28 Oct 2022 21:15:46 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <0C4XQTYeRA8vdKeOXGMjDtV5FB0hCly7f3IEGqOuibQ=.77680fb3-12f7-443e-956d-e2b7d6a1f1e7@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>
 <dwhqhEGC5VLBGESVdDZXrw83Dadmc74x6ipKtaUO7JA=.e21e4615-d06e-49b3-a7e1-55f7e2cbd315@github.com>
 <0C4XQTYeRA8vdKeOXGMjDtV5FB0hCly7f3IEGqOuibQ=.77680fb3-12f7-443e-956d-e2b7d6a1f1e7@github.com>
Message-ID: <t0nZ0M7bBzQJrzqgbJFm4QB0QUdRntrRqnBfUZgVvKs=.87aa4bd7-383a-47f3-91ee-8df2d71faa77@github.com>

On Thu, 27 Oct 2022 10:24:40 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Thanks for pointing this out! I'll investigate how to best address that in this patch series.
>
> I've spent some time trying to understand this issue, and this is my current understanding of it. ARM32 is the circumstance which surfaced the problem, but this is not an ARM32 problem. The syntax here was introduced in C++11. The minimal (GCC) compiler version stated for JDK8u is GCC 4.3, which has only partial, experimental support for C++11. You didn't state what compiler you were using but I'm going to assume it's one in the supported list for jdk8u. What I take from this is, JDK8u can't use all C++11 features, since some of the supported compiler-versions don't have all C++11 features; and in particular this feature.
> 
> These lines of code are unchanged in jdk mainline at the moment, however, jdk has moved forward the minimal supported compiler version. I doubt that a fix for this would be received favourably in jdk mainline, so we probably need to address it in jdk8u-dev directly (not via backport).

The build where I saw compilation failures was on a 32-bit platform with C++ compiler version 4.7.2. Here's the error message: 
error: non-static data member initializers only available with -std=c++11 or -std=gnu++11 [-Werror]

In our jdk8 backport, we initialize these data members using constructor initializer-list.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From rmarchenko at openjdk.org  Sat Oct 29 21:33:50 2022
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Sat, 29 Oct 2022 21:33:50 GMT
Subject: [jdk8u-dev] RFR: 8295982: Failure in
 sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the
 file because it is being used by another process
Message-ID: <Fz5E8csQ8Utp6DgA1MQml67c0jCPkvcZe8E5TJyid7U=.2decc7ff-e5ad-4444-918b-23edc56cd576@github.com>

Test sun/security/tools/keytool/WeakAlg.java occasionally fails on Windows 64 bit (win2016, win11) with the following message "java.nio.file.FileSystemException: ks: The process cannot access the file because it is being used by another process".

The root cause of the problem is "ks" file is still open by FileInputStream instance used by KeyStore in the test code. Perhaps, forcing GC to run may avoid this issue, but I guess explicit closing of the input stream is more suitable here.

No regression, only the test code is changed.
The test passes on Windows and Linux now.

-------------

Commit messages:
 - Forcing closing of input streams

Changes: https://git.openjdk.org/jdk8u-dev/pull/150/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=150&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295982
  Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/150.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/150/head:pull/150

PR: https://git.openjdk.org/jdk8u-dev/pull/150

From serb at openjdk.org  Sun Oct 30 00:08:52 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 30 Oct 2022 00:08:52 GMT
Subject: [jdk8u-dev] RFR: 8284690: [macos] VoiceOver : Getting
 java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
 [v2]
In-Reply-To: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>
References: <nEKWNOJZ8TtOhNhCkfx7o_CLw-ihEAUYGwsUd5trUk8=.b7ba5810-5af5-46df-a66e-3f8eb2292a93@github.com>
Message-ID: <tnRICaU2yXxPpxJuwg_lKzaxst3-4W-KoJVt5diXctk=.893177c3-72dd-4dfb-b384-b7b997452364@github.com>

> Hi all,
> This pull request contains a backport of commit [ebfa27b9](https://github.com/openjdk/jdk/commit/ebfa27b9f06aee8ceceabc564a78a351903ce9a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
> Thanks!

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into JDK-8284690
 - Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/132/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/132/files/cb5344af..01f5b598

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=132&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=132&range=00-01

  Stats: 4864 lines in 65 files changed: 2613 ins; 1632 del; 619 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/132.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/132/head:pull/132

PR: https://git.openjdk.org/jdk8u-dev/pull/132

From serb at openjdk.org  Sun Oct 30 00:12:55 2022
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 30 Oct 2022 00:12:55 GMT
Subject: [jdk8u-dev] RFR: 8286582: Build fails on macos aarch64 when using
 --with-zlib=bundled [v2]
In-Reply-To: <ImYzQRJ5mteFVjl4P0piwd0_GTLWZBNXegC-CM9YPGw=.476a9301-d6fe-4821-ae6a-144a00a2015a@github.com>
References: <ImYzQRJ5mteFVjl4P0piwd0_GTLWZBNXegC-CM9YPGw=.476a9301-d6fe-4821-ae6a-144a00a2015a@github.com>
Message-ID: <z6vPWHAj3nJK3O4rTzli00bKFDrL5xNgZ4y57dzZeQM=.89d38087-3a30-4c07-bef7-c6feedda09ae@github.com>

> Hi all,
> This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen.
> 
> The patch for JDK8 is slightly different:
>  * The main code patch is moved from the `make/autoconf/lib-bundled.m4` to the `jdk/make/lib/CoreLibraries.gmk` the same place where `":= -lz"` option is set.
>  * All disabled warnings are removed from the patch, seems we do not have such DISABLED_WARNINGS_XX in JDK8

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into JDK-8286582
 - Simplify the change
 - Merge branch 'master' into JDK-8286582
 - 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/80/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/80/files/5b2db66e..cd2f7444

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=80&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=80&range=00-01

  Stats: 23492 lines in 272 files changed: 6927 ins; 14280 del; 2285 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/80.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/80/head:pull/80

PR: https://git.openjdk.org/jdk8u-dev/pull/80

From jdowland at openjdk.org  Mon Oct 31 09:44:03 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 31 Oct 2022 09:44:03 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v5]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <naEXRzjcIqjY2W4QIQymaJoDNuwSdQDi_kdeu9WctZ0=.65f2a464-baf6-42b2-a335-ee4533f3f295@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Remove C++11-style non-static member initialisation
  
  This causes issues with pre-C++11 compilers (of which jdk8u-dev
  ostensibly supports). Issue has materialised on ARM32.
  
  I haven't introduced initialiser lists to the constructor because
  all of these are assigned to in the body of the constructor.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/127/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/127/files/739788d2..e6fcc668

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Mon Oct 31 09:44:06 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 31 Oct 2022 09:44:06 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <t0nZ0M7bBzQJrzqgbJFm4QB0QUdRntrRqnBfUZgVvKs=.87aa4bd7-383a-47f3-91ee-8df2d71faa77@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <oaaPAydqJliKH_McCB8skuUmKp_AaI5RU4t36NTP5MM=.2a7c01dc-9547-4de2-badb-7c5d8bbaaa2f@github.com>
 <dwhqhEGC5VLBGESVdDZXrw83Dadmc74x6ipKtaUO7JA=.e21e4615-d06e-49b3-a7e1-55f7e2cbd315@github.com>
 <0C4XQTYeRA8vdKeOXGMjDtV5FB0hCly7f3IEGqOuibQ=.77680fb3-12f7-443e-956d-e2b7d6a1f1e7@github.com>
 <t0nZ0M7bBzQJrzqgbJFm4QB0QUdRntrRqnBfUZgVvKs=.87aa4bd7-383a-47f3-91ee-8df2d71faa77@github.com>
Message-ID: <3g4QLvy2h-8byt-m8MRpoMpNiFFjkg3Z-8vl_RHbfOQ=.e0a6e61a-812f-41bd-bd56-a887ddb6a682@github.com>

On Fri, 28 Oct 2022 21:11:45 GMT, Poonam Bajaj <poonam at openjdk.org> wrote:

>> I've spent some time trying to understand this issue, and this is my current understanding of it. ARM32 is the circumstance which surfaced the problem, but this is not an ARM32 problem. The syntax here was introduced in C++11. The minimal (GCC) compiler version stated for JDK8u is GCC 4.3, which has only partial, experimental support for C++11. You didn't state what compiler you were using but I'm going to assume it's one in the supported list for jdk8u. What I take from this is, JDK8u can't use all C++11 features, since some of the supported compiler-versions don't have all C++11 features; and in particular this feature.
>> 
>> These lines of code are unchanged in jdk mainline at the moment, however, jdk has moved forward the minimal supported compiler version. I doubt that a fix for this would be received favourably in jdk mainline, so we probably need to address it in jdk8u-dev directly (not via backport).
>
> The build where I saw compilation failures was on a 32-bit platform with C++ compiler version 4.7.2. Here's the error message: 
> error: non-static data member initializers only available with -std=c++11 or -std=gnu++11 [-Werror]
> 
> In our jdk8 backport, we initialize these data members using constructor initializer-list.

I've just pushed a commit that should resolve this (e6fcc66863e). Thanks for bringing it up!

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Mon Oct 31 11:32:44 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 31 Oct 2022 11:32:44 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]
In-Reply-To: <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <F7biTaP_mmSBIm7Rznw3LgQgaz-JccBRcmJD2NkS0Vw=.abe5cf7b-23f3-4af9-a6a5-61c26c20c5a7@github.com>
 <WZRd5yXqMNO1ZcE2iGpZayhm-0cVJtd9nJeyvti1yoY=.93a58633-7888-4d60-b23d-03398428ee5b@github.com>
Message-ID: <hSPpoeOI1LcpjQMJlAlHl4pB0zWWVGBK8sFnAWO4mCQ=.b6d8e966-b979-4969-89cd-bc7bd1fd7ec4@github.com>

On Mon, 17 Oct 2022 16:25:31 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - substitute os::strerror for strerror
>>    
>>    os::strerror was introduced in 8148425 (strerror() function is not
>>    thread-safe), which is probably out of scope for backporting (at least
>>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>>    (thread unsafe) strerror, in common with the rest of JDK8u.
>>  - Rework use of newer logging API to tty->print_cr
>>    
>>    Remove includes of log.hpp that doesn't exist in jdk8u
>>    
>>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>>  - 8230305: Cgroups v2: Container awareness
>>    
>>    Implement Cgroups v2 container awareness in hotspot
>>    
>>    Reviewed-by: bobv, dholmes
>
> hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp line 431:
> 
>> 429:   if (!memory_limit->should_check_metric()) {
>> 430:     return memory_limit->value();
>> 431:   }
> 
> This is actually code added with [JDK-8232207](https://bugs.openjdk.org/browse/JDK-8232207) which shouldn't affect JDK 8. So I'm not sure about this. Add it to 8u anyway (and have less divergence) or remove and deal with the code difference.
> 
> Whatever the way, we need to make this clear by: a) adding the issue using `/issue add` or b) restructuring this code to account for it. I'm slightly in favor of b).

I tried a very basic JMH bench with/without the memory caching in place and it had no obvious impact one way or another, but I'm leaning towards a) because removing it means re-working quite a few bits, including switching _memory from a CachingCgroupController to CgroupController (or CgroupV1Controller etc) so the macros GET_CONTAINER_INFO and friends still work. The deltas will be across at least four source files.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From duke at openjdk.org  Mon Oct 31 12:31:31 2022
From: duke at openjdk.org (Alexey Pavlyutkin)
Date: Mon, 31 Oct 2022 12:31:31 GMT
Subject: [jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX
 definition in globalDefinitions_VisCPP.hpp [v3]
In-Reply-To: <RzwySKGpVKTabZOzP-SYGtqrsBgfzWHic3Tk9lWaNUw=.3f064fe1-207e-404c-bf88-cca4bc36bc33@github.com>
References: <WCZSnJWqvZqlMsQizOTcP0iaua8g2s4Kk2Ce5mOj6a0=.0b7e5a68-af18-4784-8570-8fdbebff7bdc@github.com>
 <NB7zAI07MQCDWfB0ZIblF4fuWsYaUgBp2se5wt89KdQ=.6504f16b-57d4-42c3-a1ac-c4917cfc9d04@github.com>
 <QEds7lEdLs4CNNDaQrX9E0v-HEZgis46MvnbeO4osls=.db496a1b-13b5-4746-930f-d0656e7d7b2d@github.com>
 <RzwySKGpVKTabZOzP-SYGtqrsBgfzWHic3Tk9lWaNUw=.3f064fe1-207e-404c-bf88-cca4bc36bc33@github.com>
Message-ID: <sPaHCbcs_Y-MHsf7d7kZfX2V8DxKwvlHXSQEOBGUc5A=.eb769e97-d11b-4f71-9f5e-9f84246f10e2@github.com>

On Tue, 25 Oct 2022 13:22:46 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > The definitions now are done by including of `stdint.h` that is surely available even in msvs 2010 (as I remember a far earlier). I have no idea why they were declared localy. Looks like I forgot to mention this deviation from the original changeset.
> 
> OK, thanks.

Luckily the guys from my old job still use msvs-2008. I asked them to check presense of `stdint.h`, and the header was introduced exactly in msvs-2010. Looks like jdk-8 didn't use the header to provide compatibility with the compilers older than 2010, but now it does not make a sense

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77

From abakhtin at openjdk.org  Mon Oct 31 13:39:19 2022
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 31 Oct 2022 13:39:19 GMT
Subject: [jdk8u-dev] RFR: 8270344: Session resumption errors
Message-ID: <RmO44rKQDxIeJsbEuLNA6HrvR0kQB81O_zt1fLbdhUU=.22019f64-7946-4b64-956d-d1870fa1d9d1@github.com>

It is an almost clean backport.
TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
Fixed library path for the InvalidateSession test

sun/security/ssl and javax/net/ssl regression tests are passed

-------------

Commit messages:
 - Backport 04a806ec86a388b8de31d42f904c4321beb69e14

Changes: https://git.openjdk.org/jdk8u-dev/pull/151/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=151&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8270344
  Stats: 182 lines in 3 files changed: 160 ins; 20 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/151.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/151/head:pull/151

PR: https://git.openjdk.org/jdk8u-dev/pull/151

From jdowland at openjdk.org  Mon Oct 31 14:42:41 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 31 Oct 2022 14:42:41 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v6]
In-Reply-To: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
Message-ID: <A71S8y4wNWUOQ6wqtUZsWyIpf5YofsbS1nAmAlOvH6k=.b70e8e0d-9180-4707-8f83-71069ac13cfc@github.com>

> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
> 
> The patch does not apply clean after unshuffling and path fixing:
> 
>  * mostly copyright line issues
>  * different package name for jdk.test.lib.process.OutputAnalyzer
>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
> 
> A few other changes were made
> 
>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
> 
> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)

Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:

 - Remove C++11-style non-static member initialisation
   
   This causes issues with pre-C++11 compilers (of which jdk8u-dev
   ostensibly supports). Issue has materialised on ARM32.
   
   I haven't introduced initialiser lists to the constructor because
   all of these are assigned to in the body of the constructor.
 - Guard two more tty->print_cr with PrintContainerInfo
 - Whitespace and braces around PrintContainerInfo
 - substitute os::strerror for strerror
   
   os::strerror was introduced in 8148425 (strerror() function is not
   thread-safe), which is probably out of scope for backporting (at least
   as part of this cgroups v2 effort). Replace uses of os::strerror with
   (thread unsafe) strerror, in common with the rest of JDK8u.
 - Rework use of newer logging API to tty->print_cr
   
   Remove includes of log.hpp that doesn't exist in jdk8u
   
   log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
 - 8230305: Cgroups v2: Container awareness
   
   Implement Cgroups v2 container awareness in hotspot
   
   Reviewed-by: bobv, dholmes
 - TestCgroupSubsystemController: rework use of Files.writeString
 - CgroupSubsystemController: fix library paths
   
   We need the testlibrary copy of FileUtils but the test.lib.util copy of
   Utils (method createTempDirectory is missing from the testlib copy)
 - TestCgroupSubsystemController: fix jtreg @library path
 - Replace Arrays.compare with Arrays.equals
   
   jdk8u does not have Arrays.compare()
 - ... and 11 more: https://git.openjdk.org/jdk8u-dev/compare/7afa1ea1...6947cdb7

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/127/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/127/files/e6fcc668..6947cdb7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=127&range=04-05

  Stats: 4905 lines in 66 files changed: 2659 ins; 1632 del; 614 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/127.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/127/head:pull/127

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From jdowland at openjdk.org  Mon Oct 31 14:42:41 2022
From: jdowland at openjdk.org (Jonathan Dowland)
Date: Mon, 31 Oct 2022 14:42:41 GMT
Subject: [jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v5]
In-Reply-To: <naEXRzjcIqjY2W4QIQymaJoDNuwSdQDi_kdeu9WctZ0=.65f2a464-baf6-42b2-a335-ee4533f3f295@github.com>
References: <DjAl1hjbO6Etfwr47Pg4VbIcjtRQXfAN0lSBpQoPl9M=.8b0641e0-8730-405b-8dc0-eef4339d1658@github.com>
 <naEXRzjcIqjY2W4QIQymaJoDNuwSdQDi_kdeu9WctZ0=.65f2a464-baf6-42b2-a335-ee4533f3f295@github.com>
Message-ID: <X-l3d1t3Wunl3rJf5G-2K60vTHXC70gO4zByQ419IVI=.08d1b691-e264-4a3f-be1c-c92782ae1e52@github.com>

On Mon, 31 Oct 2022 09:44:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>> 
>> The patch does not apply clean after unshuffling and path fixing:
>> 
>>  * mostly copyright line issues
>>  * different package name for jdk.test.lib.process.OutputAnalyzer
>>  * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>> 
>> A few other changes were made
>> 
>>  *  Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>>  *  replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>> 
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove C++11-style non-static member initialisation
>   
>   This causes issues with pre-C++11 compilers (of which jdk8u-dev
>   ostensibly supports). Issue has materialised on ARM32.
>   
>   I haven't introduced initialiser lists to the constructor because
>   all of these are assigned to in the body of the constructor.

As discussed, and now that all open review notes were addressed, I've re-parented this PR onto master.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127

From phh at openjdk.org  Mon Oct 31 22:00:23 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 31 Oct 2022 22:00:23 GMT
Subject: [jdk8u-dev] RFR: 8209052: Low contrast in
 docs/api/constant-values.html
In-Reply-To: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
References: <yztAKtjMJ_YAgyt7quuYRCdTunoOWTBYhJKtxHKlRWo=.35a740b2-2470-4c22-94e9-87ebaa4f8639@github.com>
Message-ID: <noSRGN2fU9XeDPBejBfzq936JthzubFdlACXFKmtW0M=.06e4fbe2-7592-48e0-bdb6-d16354e25f9c@github.com>

On Thu, 25 Aug 2022 07:48:19 GMT, psoujany <duke at openjdk.org> wrote:

> Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
> Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052

This backport has quite a few more changes to stylesheet.cs than the original commit. Is there another issue to backport first?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/114

From phh at openjdk.org  Mon Oct 31 22:51:32 2022
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 31 Oct 2022 22:51:32 GMT
Subject: [jdk8u-dev] RFR: 8295915: Problemlist compiler/rtm failures
 specific to 8u
In-Reply-To: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
References: <DXy5Nr1GhWzxv_f76QAzhD78YslP1HvC79MpwMlZBAA=.15a3415e-1238-4609-a77e-0331f5386899@github.com>
Message-ID: <-muX1wkKtzR45HojvZ-gvLDlhpUGZyv_IdaYLJJESEk=.ffd0716c-11f2-4625-b632-0b5dffc6d45e@github.com>

On Tue, 25 Oct 2022 20:18:45 GMT, zzambers <duke at openjdk.org> wrote:

> I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
> List of tests follows:
> 
> compiler/rtm/locking/TestRTMTotalCountIncrRate.java
> compiler/rtm/locking/TestUseRTMAfterLockInflation.java
> compiler/rtm/locking/TestUseRTMForInflatedLocks.java
> compiler/rtm/locking/TestUseRTMForStackLocks.java
> compiler/rtm/method_options/TestUseRTMLockElidingOption.java
> 
> These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.
> 
> Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].
> 
> [1] https://bugs.openjdk.org/browse/JDK-8183263
> [2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/148