[jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2]

[Jonathan Dowland]

On Fri, 7 Oct 2022 18:11:14 GMT, Poonam Bajaj <poonam at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - substitute os::strerror for strerror
>>    
>>    os::strerror was introduced in 8148425 (strerror() function is not
>>    thread-safe), which is probably out of scope for backporting (at least
>>    as part of this cgroups v2 effort). Replace uses of os::strerror with
>>    (thread unsafe) strerror, in common with the rest of JDK8u.
>>  - Rework use of newer logging API to tty->print_cr
>>    
>>    Remove includes of log.hpp that doesn't exist in jdk8u
>>    
>>    log_(debug|trace) to tty->print_cr guarded by PrintContainerInfo
>>  - 8230305: Cgroups v2: Container awareness
>>    
>>    Implement Cgroups v2 container awareness in hotspot
>>    
>>    Reviewed-by: bobv, dholmes
>
> hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.hpp line 103:
> 
>> 101:     CgroupV1Controller* _cpuset = NULL;
>> 102:     CachingCgroupController* _cpu = NULL;
>> 103:     CgroupV1Controller* _cpuacct = NULL;
> 
> For arm32 platform, if the c++ compiler version being used is earlier than 11, then the non-static member initialization will cause compilation failure.

Thanks for pointing this out! I'll investigate how to best address that in this patch series.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/127