[jdk8u-dev] RFR: 8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout

[Dmitry Samersoff]

On Tue, 18 Oct 2022 17:27:26 GMT, zzambers <duke at openjdk.org> wrote:

> Current form of `com/sun/jdi/DoubleAgentTest.java` has some problems, which should be fixed by this backport. Apart from problem mentioned in backported bug, test in current form also suffers race condition causing random failures (See my comment here: [1]) and should be fixed.
> 
> **Few notes about this backport:**
> There was one intermediate change to DoubleAgentTest.java by JDK-6622468 [2]. But as that changeset modifies lot of files and only modifies DoubleAgentTest.java slightly, only to be basically rewritten from scratch by following changeset (the backported one). I decided to skip it (intermediate changeset) and go directly to rewritten test. Also there is a typo in changeset being backported, which was later fixed as part of JDK-8143583 [3] (which also does other stuff). I fixed this typo right away in this backport. I don't think backporting these 2 whole additional changesets (and dependent changesets) just because of this backport would be reasonable. Also I don't think including tiny part of these other changesets here would cause much problems even if someone decides backport them in the future.
> 
> **Testing:**
> Test is part of jdk_tier1 and passes testing in GHA (results should appear here).
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/133#issuecomment-1276759194
> [2] https://bugs.openjdk.org/browse/JDK-6622468
> [3] https://bugs.openjdk.org/browse/JDK-8143583

Marked as reviewed by dsamersoff (Committer).

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/143