[jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp [v3]

[Severin Gehwolf]

On Fri, 2 Sep 2022 07:08:22 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

>> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
>> 
>> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
>> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
>> 
>> Verification: 2019 build (both 32/64) now fails with 
>> 
>> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
>> jvm.dll : fatal error LNK1120: 1 unresolved externals
>> 
>> error (to be fixed by backport of 8043492)
>> 
>> Regression: 2017/2013/2012/2010 full build - ok
>> 
>> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removing generated-configure.sh from PR

It would be good if some Windows build person could review this patch as well.

hotspot/src/share/vm/utilities/globalDefinitions_visCPP.hpp line 87:

> 85: #ifndef UINT64_C
> 86: #define UINT64_C(c) (c ## ui64)
> 87: #endif

These removals aren't in the original changeset. See JDK-8272714 and JDK-8272214. I guess we should conditionalize on the VS version in use if that's a problem?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/77