[jdk8u-dev] RFR: 8230305: Cgroups v2: Container awareness [v5]
Jonathan Dowland
jdowland at openjdk.org
Mon Oct 31 14:42:41 UTC 2022
On Mon, 31 Oct 2022 09:44:03 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:
>> This is a backport of 8230305 (Cgroups v2: Container awareness) for JDK8u, working from the jdk11u-dev backport as part of an effort to backport cgroups v2 to jdk8u-dev.
>>
>> The patch does not apply clean after unshuffling and path fixing:
>>
>> * mostly copyright line issues
>> * different package name for jdk.test.lib.process.OutputAnalyzer
>> * Most of hotspot/src/os/linux/vm/cgroupSubsystem_linux.cpp failed due to context changes, manually resolved (mostly deletions)
>>
>> A few other changes were made
>>
>> * Rework use of newer logging API (log_debug etc) to use guarded tty->print_cr
>> * replace os::strerror with the libc strerror (which is thread unsafe, but that should be addressed by backporting 8148425 separately)
>>
>> patch touched hotspot/test/runtime/containers/docker/TestCPUAwareness.java which passes afterwards; I'm running further tests now (and awaiting GitHub CI doing the same)
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove C++11-style non-static member initialisation
>
> This causes issues with pre-C++11 compilers (of which jdk8u-dev
> ostensibly supports). Issue has materialised on ARM32.
>
> I haven't introduced initialiser lists to the constructor because
> all of these are assigned to in the body of the constructor.
As discussed, and now that all open review notes were addressed, I've re-parented this PR onto master.
-------------
PR: https://git.openjdk.org/jdk8u-dev/pull/127
More information about the jdk8u-dev
mailing list