[jdk8u-dev] RFR: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp [v3]

Alexey Pavlyutkin duke at openjdk.org
Fri Sep 2 07:08:22 UTC 2022


> Hi! Please review another backport from MSVS2019 seria. This one fixes type declarations made by globalDefinitions_VisCPP.hpp. The patch from 11u applied with the following changes:
> 
> - inttypes.h is included conditionally under `_MSC_VER >= 1800` because the header was introduced only in MSVS 2013 but we have to keep support of the earlier MSVS versions 
> - the duplicates of declarations made in inttypes.h are not just removed but quoted with `_MSC_VER < 1800`
> - common\autoconf\generated-configure.sh is regenerated to add MSVS2019 recognition (I forgot to do that in https://github.com/openjdk/jdk8u-dev/pull/33)
> 
> Verification: 2019 build (both 32/64) now fails with 
> 
> ad_x86_64_pipeline.obj : error LNK2011: precompiled object not linked in; image may not run
> jvm.dll : fatal error LNK1120: 1 unresolved externals
> 
> error (to be fixed by backport of 8043492)
> 
> Regression: 2017/2013/2012/2010 full build - ok
> 
> @kimbarrett @dholmes-ora if you took a look at that it would be very much appreciated

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  removing generated-configure.sh from PR

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/77/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/77/files/31b809b2..a7c2b48d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=77&range=01-02

  Stats: 11603 lines in 1 file changed: 466 ins; 2624 del; 8513 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/77.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/77/head:pull/77

PR: https://git.openjdk.org/jdk8u-dev/pull/77


More information about the jdk8u-dev mailing list