multiple copies of test file FileUtils.java in 8u tree

Jonathan Dowland jdowland at redhat.com
Wed Sep 21 09:50:48 UTC 2022


Whilst working on a backport, I discovered the following two files in
the 8u source tree

     ./jdk/test/lib/testlibrary/jdk/testlibrary/FileUtils.java
     ./jdk/test/lib/jdk/test/lib/util/FileUtils.java

There is one copy of this in upstream jdk.

It moved from test/lib/testlibrary/jdk/testlibrary/FileUtils.java to
test/lib/jdk/test/lib/util/FileUtils.java in the JDK10 era with

     8180887: move FileUtils to top level testlibrary

The newer-path copy in 8u was introduced with

     df7e0904339 8223147: JFR Backport

Should we move to one copy in the 8u tree?

Do we choose the old or new path? From the POV of further backports, I'd
guess the newer path is likely to be more common. In my specific case
(backporting 8231111) the patches use the newer path (which is trivial
to change of course) but the code also uses methods that are only
present in 8u's copy at the new path and not the old one.

FileUtils.java is just one such file, I think there are likely more.



Thanks,

-- 
👱🏻 Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat



More information about the jdk8u-dev mailing list