[jdk8u-dev] RFR: 8298108: Add a regression test for JDK-8297684

[Andrew John Hughes]

On Mon, 27 Feb 2023 19:13:58 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this backport of the regression test for a critical fix which we've included with the January CPU update. The fix was https://bugs.openjdk.org/browse/JDK-8280890
> 
> This patch adds an additional regression test which was seen in the wild with JDK 17. The patch isn't clean since the test library in jdk8u is different so needed a bit of a different setup routine for getting the jar with the provider created. Additionally, in jdk 8 the property to add providers is setting `java.ext.dirs=...` over `java.locale.providers=SPI` in later JDKs.
> 
> Testing: The test passes for me on the current dev tree and fails with the fix from JDK-8280890 reverted.
> 
> Thoughts?

I've queried a couple of minor issues, but generally looks like a good conversion to 8u. It does seem that installing the provider in 8u is quite awkward. Is there no way to do it with just the JAR?

jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java line 95:

> 93:             Files.createDirectory(SERVICES_DIR_TARGET);
> 94:             Files.copy(PROVIDER_SOURCE, PROVIDER_TARGET);
> 95:             JarUtils.createJarFile(UNSIGNED_JAR, PROVIDER_DIR);

I take it the JAR file does not need to be updated with the META-INF directory (11u has `JarUtils.updateJarFile(UNSIGNED_JAR, META_INF_DIR);`) because it is instead located via `-Djava.ext.dirs`?

jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java line 108:

> 106:             List<String> testRun = new ArrayList<>();
> 107:             String extDir = System.getProperty("java.home") + File.separator + "lib" + File.separator + "ext";
> 108:             testRun.add("-Djava.ext.dirs=" + System.getProperty("java.home") + extDir + File.pathSeparator + MODS_DIR.toAbsolutePath().toString());

Doesn't this add `System.getProperty("java.home")` to the front of `extDir` which already begins with `System.getProperty("java.home")`?

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/269#pullrequestreview-1371520382
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/269#discussion_r1157600286
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/269#discussion_r1157599525