[jdk8u-ri] RFR: 8305681: Allow additional characters for GB18030-2022 (Level 2) support [v2]

Iris Clark iris at openjdk.org
Fri Apr 7 17:31:51 UTC 2023


On Fri, 7 Apr 2023 17:22:51 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> jdk/src/share/classes/java/lang/Character.java line 2582:
>> 
>>> 2580:          * character block.
>>> 2581:          * @apiNote This field is defined in Java SE 8 Maintenance Release 5.
>>> 2582:          * @since 1.8
>> 
>> Shouldn't this be `8` instead of `1.8`?
>
> IIUC, `@since` tags for JDK 8 all use `1.8`, but happy to revise it if MRs prefer `8` instead.

Sounds good.  As I wrote my comment that thought did occur to me.  We should be consistent with the existing tags so `1.8` it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-ri/pull/13#discussion_r1160850024


More information about the jdk8u-dev mailing list