[jdk8u-dev] RFR: 8276841: Add support for Visual Studio 2022 [v2]
Alexander Scherbatiy
alexsch at openjdk.org
Wed Apr 12 12:19:37 UTC 2023
> This is a backport of the fix from jdk11u-dev repository: https://github.com/openjdk/jdk11u-dev/commit/0ba5a81e7c0117855665a28a43f9589635e94222
> The fix is a parity fix for JDK-8298996 in 8u371 from Oracle.
>
> The fix is manually merged with jdk8u-dev because it has conflicts in lines before the fix:
> jdk11u-dev: `VALID_VS_VERSIONS="2017 2019 2013 2015 2012 2010"`
> jdk8u-dev: `VALID_VS_VERSIONS="2010 2012 2013 2015 2017 2019"`
> The conflict is resolved so `2022` year is placed after `2019` in jdk8u-dev.
>
> The other part is backported as is into jdk8u-dev. The `generated-configure.sh` file is updated as well.
>
> To test the fix the jdk8u-dev was built on Windows Server 2012 R2 with:
>
> * Toolchain: microsoft (Microsoft Visual Studio 2022 17.5.2 (devkit))
> * C Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl)
> * C++ Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl)
>
> and hotspot and compact3 tests were run. There were only 3 new failed tests comparing to the build without the fix.
> ```
> jdk/internal/platform/cgroup/TestCgroupMetrics.java.TestCgroupMetrics
> jdk/internal/platform/docker/TestDockerMemoryMetrics.java.TestDockerMemoryMetrics
> jdk/internal/platform/docker/TestSystemMetrics.java.TestSystemMetrics
>
> The first test passes after the second run.
> I rerun the tests with build without the fix and these 3 tests failed as well.
> It looks like that these failures actually are not related to the fix.
Alexander Scherbatiy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
8276841: Add support for Visual Studio 2022
-------------
Changes: https://git.openjdk.org/jdk8u-dev/pull/295/files
Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=295&range=01
Stats: 32 lines in 2 files changed: 30 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/295.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/295/head:pull/295
PR: https://git.openjdk.org/jdk8u-dev/pull/295
More information about the jdk8u-dev
mailing list