[jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v2]

[Andrew John Hughes]

On Thu, 13 Apr 2023 12:06:30 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> The backport from 11u was not clean because:
>> 
>> 1. the change to PKCS11Test.java affects code that does not exist in 8u, so is not included
>> 2. the new test, TestP11KeyFactoryGetRSAKeySpec.java, uses /lib/testlibrary instead of /test/lib
>> 
>> The new test and the modified existing tests pass, and the jdk/test/sun/security/pkcs11 tests pass as well as they did before this change.
>
> Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update p11-nss-sensitive.txt to match 11u

Backport looks correct, apart from the removal of the SHA3 definitions. Those values are defined in 8u by [JDK-8244154](https://bugs.openjdk.org/browse/JDK-8244154), even if they are not used by the PKCS11 provider, so I see no reason to diverge the configuration, unless it causes a test failure.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/302#pullrequestreview-1383609827