[jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v2]

[Paul Hohensee]

On Thu, 13 Apr 2023 12:06:30 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> The backport from 11u was not clean because:
>> 
>> 1. the change to PKCS11Test.java affects code that does not exist in 8u, so is not included
>> 2. the new test, TestP11KeyFactoryGetRSAKeySpec.java, uses /lib/testlibrary instead of /test/lib
>> 
>> The new test and the modified existing tests pass, and the jdk/test/sun/security/pkcs11 tests pass as well as they did before this change.
>
> Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update p11-nss-sensitive.txt to match 11u

The 8u JDK-8244154 backport https://hg.openjdk.org/jdk8u/jdk8u/hotspot/rev/803cbdf0f152 includes just the readme comment update, while the 11u backport https://hg.openjdk.org/jdk-updates/jdk11u/rev/87e85e5123dd includes much else. 8u and 11u both define the SHA3 mechanisms in share/native/sun/security/pkcs11/wrapper/pkcs11t.h, but the 11u JDK-8263404 backport doesn't include them in p11-nss-sensitive.txt.

In light of the above, shall we stay with 11u backport compatibility or add the SHA3 mechanisms back to p11-nss-sensitive.txt?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/302#issuecomment-1507146603