[jdk8u-dev] RFR: 8151460: Metaspace counters can have inconsistent values [v2]

Severin Gehwolf sgehwolf at openjdk.org
Fri Apr 14 08:34:41 UTC 2023


On Fri, 14 Apr 2023 06:43:39 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> To reduce intermittent errors from TestPerfCountersAndMemoryPools, I'd like to backport "8151460: Metaspace counters can have inconsistent values".
>> 
>> This does not backport cleanly since JEP 280 [1] modified the test, and I won't backport that one of course. Therefore I also added the test-specific fix JEP 280 did (https://github.com/openjdk/jdk8u-dev/commit/24773b47512b522c9bfa346559a34138d900b77e).
>> 
>> Tests: I manually ran gc/metaspace jtreg tests on Linux x64 with fastdebug and release builds.
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8148483
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into TestPerfCountersAndMemoryPools
>  - JDK-8151460: Metaspace counters can have inconsistent values
>  - JEP 280 portion

Seems fine to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/301#pullrequestreview-1384924870


More information about the jdk8u-dev mailing list