[jdk8u-dev] RFR: 8282345: handle latest VS2022 in abstract_vm_version
Zdenek Zambersky
zzambers at openjdk.org
Tue Apr 18 23:10:49 UTC 2023
On Wed, 12 Apr 2023 14:31:35 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:
>> This is a backport of the [JDK-8282345 handle latest VS2022 in abstract_vm_version](https://bugs.openjdk.org/browse/JDK-8282345) from jdk11u-dev repository.
>>
>> It is a parity fix for [JDK-8299000 handle latest VS2022 in abstract_vm_version](https://bugs.openjdk.org/browse/JDK-8299000) in Oracle 8u371
>>
>> There is only one conflict resolved with the copyright year.
>> jdk11u-dev:
>>
>> - * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 1998, 2022, Oracle and/or its affiliates. All rights reserved.
>>
>> jdk8u-dev:
>>
>> - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 1998, 2022, Oracle and/or its affiliates. All rights reserved.
>>
>>
>> I would like to backport it as additional fix for the https://github.com/openjdk/jdk8u-dev/pull/295 `8276841: Add support for Visual Studio 2022`
>>
>> Both backports the current one and the `8276841` were built on Windows Server 2012 R2 with:
>>
>> * Toolchain: microsoft (Microsoft Visual Studio 2022 17.5.2 (devkit))
>> * C Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl)
>> * C++ Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl)
>>
>> and hotspot and compact3 tests were run. There were no failed tests comparing to the build without the fix.
>
> I do not see the workflow for JDK-8282345 in https://github.com/AlexanderScherbatiy/jdk8u-dev/actions/workflows/submit.yml
>
> I think it is because workflows have not been enabled in my fork when the pull request has been submitted.
>
> I will force-push an empty commit.
@AlexanderScherbatiy you should be able to reschedule GHA runs on your fork even without push. You (as fork owner) should see "Re-run all jobs" button in top right corner here:
https://github.com/AlexanderScherbatiy/jdk8u-dev/actions/runs/4679558326
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/299#issuecomment-1513894745
More information about the jdk8u-dev
mailing list