From duke at openjdk.org Tue Aug 1 07:34:51 2023 From: duke at openjdk.org (Tobias Gesellchen) Date: Tue, 1 Aug 2023 07:34:51 GMT Subject: [jdk8u-dev] RFR: 8214046: [macosx] Undecorated Frame does not Iconify when set to [v2] In-Reply-To: References:

Message-ID: On Wed, 26 Jul 2023 22:13:04 GMT, Paul Hohensee wrote: >> Tobias Gesellchen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: >> >> 8214046: [macosx] Undecorated Frame does not Iconify when set to >> >> Reviewed-by: dmarkov >> Backport-of: ab97f65242dad6ad1a7bfb8284954f202eb37369 > > Yes, wait for jdk8u-fix-yes to add /integrate. No, the other ticket isn't blocking anything. :) @phohensee @mrserb not sure if this is the best place to ask: when looking at https://wiki.openjdk.org/display/jdk8u#Main-RepositoryStatus I can see that OpenJDK 8u392 is in "First build promotion". Would this fix have a chance to be included in 8u392 or is it more realistic that it will land in 8u402? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/341#issuecomment-1659731502 From phh at openjdk.org Tue Aug 1 17:06:59 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Aug 2023 17:06:59 GMT Subject: [jdk8u-dev] RFR: 8214046: [macosx] Undecorated Frame does not Iconify when set to [v2] In-Reply-To: References:

Message-ID: On Tue, 1 Aug 2023 17:04:08 GMT, Paul Hohensee wrote: > According to https://wiki.openjdk.org/display/jdk8u/Main, 8u392 freeze date is Aug 25th, so I'd expect it to land there. Thanks! ? :) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/341#issuecomment-1660803767 From phh at openjdk.org Wed Aug 2 23:11:55 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 2 Aug 2023 23:11:55 GMT Subject: [jdk8u-dev] RFR: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException [v2] In-Reply-To: References:

Message-ID: On Thu, 20 Jul 2023 03:14:16 GMT, sendaoYan wrote: >> 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException >> >> Reviewed-by: Yi Yang > > sendaoYan has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport eccfec498d4062b582282f3b73bba84206a36046 > > 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException > > Reviewed-by: Yi Yang > Signed-off-by: sendaoYan Tagged the JBS issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/337#issuecomment-1663082111 From duke at openjdk.org Thu Aug 3 07:21:55 2023 From: duke at openjdk.org (ktakakuri) Date: Thu, 3 Aug 2023 07:21:55 GMT Subject: [jdk8u-dev] RFR: 8210560: [TEST] convert com/sun/jdi redefineClass-related tests Message-ID: This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests. Original patch does not apply cleanly to 8u, because: 1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib. 2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager). So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager. I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64. ------------- Commit messages: - Backport 0b3f46efe1db4516949d12a7bdfe67d4ca5eddef Changes: https://git.openjdk.org/jdk8u-dev/pull/350/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=350&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210560 Stats: 9711 lines in 74 files changed: 5264 ins; 4443 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/350.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/350/head:pull/350 PR: https://git.openjdk.org/jdk8u-dev/pull/350 From duke at openjdk.org Thu Aug 3 08:04:42 2023 From: duke at openjdk.org (duke) Date: Thu, 3 Aug 2023 08:04:42 GMT Subject: [jdk8u-dev] Withdrawn: 8159690: [TESTBUG] Mark headful tests with @key headful. In-Reply-To: <38KGfdgNjyk4aAa_04Fcg3PUJmgKxrlErG_ybmEqRtE=.740ad6d8-c65c-422e-bd5f-71e51199f06b@github.com> References: <38KGfdgNjyk4aAa_04Fcg3PUJmgKxrlErG_ybmEqRtE=.740ad6d8-c65c-422e-bd5f-71e51199f06b@github.com> Message-ID: On Thu, 20 Apr 2023 03:04:25 GMT, yaqsun wrote: > The patch is not clean because the 31 tests are omitted, and because of various context differences. The only substantive change is the addition of @headful, which doesn?t affect running any of the tests. > > There are 30 tests that were in the original patch that are not present in 8u. And there is 1 test that does not need to handle headful. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/306 From abakhtin at openjdk.org Thu Aug 3 20:55:09 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 3 Aug 2023 20:55:09 GMT Subject: [jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2] In-Reply-To: References: Message-ID: > Please review the backport of sspi bridge to JDK8 > > The backport is based on the JDK11 version and is almost clean. > The copyright years are updated manually: > - NativeFunc.h already has a newer copyright year > - SunNativeProvider.java updated manually > The main difference is a build script for sspi_bridge. It is located in SecurityLibraries.gmk > > No regressions on the sun/security/krb5 tests (Windows and Linux platforms) Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge upstream/master into JDK-6722928 - Backport 475996adc2aaa7af920f2e9711d0ace2ddd2430e ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/340/files - new: https://git.openjdk.org/jdk8u-dev/pull/340/files/449294b9..8cf4d667 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=340&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=340&range=00-01 Stats: 888719 lines in 193 files changed: 888626 ins; 20 del; 73 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/340.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/340/head:pull/340 PR: https://git.openjdk.org/jdk8u-dev/pull/340 From abakhtin at openjdk.org Thu Aug 3 23:08:36 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 3 Aug 2023 23:08:36 GMT Subject: [jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2] In-Reply-To: References:

Message-ID: On Mon, 7 Aug 2023 12:18:39 GMT, Tobias Gesellchen wrote: > Yet, I don't know why the fix isn't part of the main branch of [openjdk/jdk8u-dev](https://github.com/openjdk/jdk8u-dev). I'm curious if there's a specfic reason or if the commit simply slipped through. Is `8u271` different from `openjdk8u271`? Yes. `8u271` is *Oracle JDK 8u271*. `openjdk8u271` would be the corresponding OpenJDK 8u bug version. It isn't fixed in OpenJDK 8u, though, as you note. See the master bug https://bugs.openjdk.org/browse/JDK-8214046 (specifically the "Backports" section and "Fixed in Version" values). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/341#issuecomment-1667862995 From andrew at openjdk.org Mon Aug 7 13:51:39 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 7 Aug 2023 13:51:39 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 Where are we with this one? Is it waiting on #285? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-1667894132 From duke at openjdk.org Mon Aug 7 15:10:44 2023 From: duke at openjdk.org (Tobias Gesellchen) Date: Mon, 7 Aug 2023 15:10:44 GMT Subject: [jdk8u-dev] RFR: 8214046: [macosx] Undecorated Frame does not Iconify when set to [v2] In-Reply-To: References:

Message-ID: <-Iu9NbfwGggQ-zCfgMxWlK3KTGH7EDVg1aMW2x-w94E=.8d8ef3cd-06a9-42ca-b9fc-fd5f6229b4e4@github.com> On Tue, 13 Jun 2023 06:58:31 GMT, ktakakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f Copyright date updates should be taken from the original commit rather than use the current year. If the existing file has a later copyright date than the file in the original commit, leave the copyright date alone. Other than that, lgtm. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-1565808241 From phh at openjdk.org Mon Aug 7 17:11:40 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 7 Aug 2023 17:11:40 GMT Subject: [jdk8u-dev] RFR: 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:37 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8040887 for parity with Oracle 8u. > > Removes a flaky test. Backport is clean. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/351#pullrequestreview-1565815870 From duke at openjdk.org Mon Aug 7 17:58:42 2023 From: duke at openjdk.org (Tobias Gesellchen) Date: Mon, 7 Aug 2023 17:58:42 GMT Subject: [jdk8u-dev] Integrated: 8214046: [macosx] Undecorated Frame does not Iconify when set to In-Reply-To: References: Message-ID: On Fri, 14 Jul 2023 19:36:56 GMT, Tobias Gesellchen wrote: > See https://bugs.openjdk.org/browse/JDK-8214046 with the original patch at https://hg.openjdk.org/jdk/jdk/rev/769dbf384c44. I used https://github.com/openjdk/jdk11u-dev/commit/ab97f65242dad6ad1a7bfb8284954f202eb37369 as backport commit. This pull request has now been integrated. Changeset: a039c8a5 Author: Tobias Gesellchen Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/a039c8a5d98abb2223a02a9591e805891259221f Stats: 13 lines in 2 files changed: 9 ins; 2 del; 2 mod 8214046: [macosx] Undecorated Frame does not Iconify when set to Reviewed-by: phh, serb Backport-of: ab97f65242dad6ad1a7bfb8284954f202eb37369 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/341 From duke at openjdk.org Mon Aug 7 18:16:45 2023 From: duke at openjdk.org (Tobias Gesellchen) Date: Mon, 7 Aug 2023 18:16:45 GMT Subject: [jdk8u-dev] RFR: 8214046: [macosx] Undecorated Frame does not Iconify when set to [v2] In-Reply-To: References:

Message-ID: On Tue, 25 Jul 2023 18:03:04 GMT, Tobias Gesellchen wrote: >> See https://bugs.openjdk.org/browse/JDK-8214046 with the original patch at https://hg.openjdk.org/jdk/jdk/rev/769dbf384c44. I used https://github.com/openjdk/jdk11u-dev/commit/ab97f65242dad6ad1a7bfb8284954f202eb37369 as backport commit. > > Tobias Gesellchen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8214046: [macosx] Undecorated Frame does not Iconify when set to > > Reviewed-by: dmarkov > Backport-of: ab97f65242dad6ad1a7bfb8284954f202eb37369 Thanks to everyone involved and helping me with the Contributing process! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/341#issuecomment-1668367547 From xliu at openjdk.org Tue Aug 8 04:04:39 2023 From: xliu at openjdk.org (Xin Liu) Date: Tue, 8 Aug 2023 04:04:39 GMT Subject: [jdk8u-dev] RFR: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: <4tlUbu7SQyhktdUn_UDGo2v2uowO0fbRDP7fi1KURIw=.7850c90a-8d6b-40ee-bcaf-15f998fd31a6@github.com> On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. Hi, Reviewers, Could you take a look at this PR? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/349#issuecomment-1668869948 From sgehwolf at openjdk.org Wed Aug 9 12:35:29 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 9 Aug 2023 12:35:29 GMT Subject: [jdk8u-dev] RFR: 8239365: ProcessBuilder test modifications for AIX execution In-Reply-To: References: Message-ID: On Tue, 25 Jul 2023 13:51:18 GMT, Ilarion Nakonechnyy wrote: > Applied cleanly, fixes JTREG failed test java/lang/ProcessBuilder/Basic.java on AIX 7.2 Please enable GHA on your fork and trigger a run with this patch. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/348#issuecomment-1671218655 From sgehwolf at openjdk.org Wed Aug 9 12:35:58 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 9 Aug 2023 12:35:58 GMT Subject: [jdk8u-dev] RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com> References: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com> Message-ID: On Tue, 25 Jul 2023 11:39:05 GMT, Ilarion Nakonechnyy wrote: > This backport fixes the tier2 test: > FAILED: java/net/MulticastSocket/JoinLeave.java -- The socket name is not available on this system. (Error setting socket option) > > Changes are applied non-cleanly. > Tested on AIX 7.2 Please enable GHA on your fork and trigger a test run with this. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/347#issuecomment-1671227408 From duke at openjdk.org Wed Aug 9 16:26:32 2023 From: duke at openjdk.org (sendaoYan) Date: Wed, 9 Aug 2023 16:26:32 GMT Subject: [jdk8u-dev] Integrated: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException In-Reply-To: References: Message-ID: On Fri, 7 Jul 2023 08:43:34 GMT, sendaoYan wrote: > 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException > > Reviewed-by: Yi Yang This pull request has now been integrated. Changeset: 710481f9 Author: sendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/710481f9da9ed5253ed8db02320bd38e551caf46 Stats: 33 lines in 1 file changed: 24 ins; 0 del; 9 mod 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException Reviewed-by: phh Backport-of: eccfec498d4062b582282f3b73bba84206a36046 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/337 From btaylor at openjdk.org Wed Aug 9 16:26:33 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 9 Aug 2023 16:26:33 GMT Subject: [jdk8u-dev] Integrated: 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:37 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8040887 for parity with Oracle 8u. > > Removes a flaky test. Backport is clean. This pull request has now been integrated. Changeset: 893340a7 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/893340a78b23b6dd6086a79d4d07cf220caaedc4 Stats: 190 lines in 1 file changed: 0 ins; 190 del; 0 mod 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java Removed test/runtime/6925573/SortMethodsTest.java Reviewed-by: phh Backport-of: db9dcbd63b412cbc9cbbf537585b63a5ccbe8d46 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/351 From serb at openjdk.org Wed Aug 9 16:56:59 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 9 Aug 2023 16:56:59 GMT Subject: [jdk8u-dev] Integrated: 8232225: Rework the fix for JDK-8071483 In-Reply-To: References: Message-ID: On Tue, 25 Jul 2023 01:47:27 GMT, Sergey Bylokhov wrote: > This patch prevents possible name clashes for future backports. Right now the jdk8u-dev has the "Color" folder while the jdk11+ use the "color" folder. So depending on what file system backport is done the resulting folder could be different. > > This is a proposal to backport the patch which had split the "Color" folder into "color" and "ColorClass". The patch is mostly clean except: > - AlphaColorTest and XRenderTranslucentColorDrawTest are not present in JDK 8, both related fixes caused a couple of regressions, so no plans to backport it. > - GetInstanceBrokenStream is added to the patch. In the upstream it was pushed after this fix, now we should place it in the correct folder "color" instead of "Color" > > commit in [openjdk/jdk](https://github.com/openjdk/jdk/commit/e4b73897adf47467461634ceb786540f46aa9eb7) > > All tests green. This pull request has now been integrated. Changeset: ab2d4274 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/ab2d4274459fe503bded639de5e8b80aca056454 Stats: 0 lines in 6 files changed: 0 ins; 0 del; 0 mod 8232225: Rework the fix for JDK-8071483 Reviewed-by: phh Backport-of: e4b73897adf47467461634ceb786540f46aa9eb7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/346 From phh at openjdk.org Thu Aug 10 16:23:58 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 10 Aug 2023 16:23:58 GMT Subject: [jdk8u-dev] RFR: 8212677: X11 default visual support for IM status window on VNC In-Reply-To: References: Message-ID: On Mon, 24 Jul 2023 20:23:40 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/86cf7f8768977aea7b9ea1c90da498a1d91d2891 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ichiroh Takiguchi on Feb 1, 2019 and was reviewed by Naoto Sato and Sergey Bylokhov > > @takiguc please take a look. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/345#pullrequestreview-1572282596 From phh at openjdk.org Thu Aug 10 23:20:59 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 10 Aug 2023 23:20:59 GMT Subject: [jdk8u-dev] RFR: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/349#pullrequestreview-1572839320 From serb at openjdk.org Thu Aug 10 23:35:28 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 10 Aug 2023 23:35:28 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v2] In-Reply-To: References:

Message-ID: On Tue, 13 Jun 2023 06:58:31 GMT, ktakakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f Sorry I did not have a time to look at this PR, will try to look soon. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-1674046094 From andrew at openjdk.org Fri Aug 11 02:43:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 02:43:29 GMT Subject: [jdk8u-dev] RFR: 8308788: [8u] Remove duplicate HaricaCA.java test In-Reply-To: References: Message-ID: On Fri, 26 May 2023 09:35:16 GMT, Severin Gehwolf wrote: > Could I get a review of this trivial patch please? It only removes a file which is present elsewhere. > > Removes file: > > jdk/test/jdk/security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > > ... as the same file is present where other CA tests live: > > jdk/test/security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > > > See the bug for details. Thoughts? Ah, a lack of path shuffling on the test filename. My bad during the embargoed changes I think. Thanks for fixing. Approved for 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/322#pullrequestreview-1572936923 From andrew at openjdk.org Fri Aug 11 02:59:28 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 02:59:28 GMT Subject: [jdk8u-dev] RFR: 8287663: Add a regression test for JDK-8287073 In-Reply-To: References: Message-ID: On Fri, 26 May 2023 14:44:12 GMT, Severin Gehwolf wrote: > Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences): > > - Bug line in test. Fixed manually > - `Files.writeString()` => `Files.write()` changes in test. > > Testing: > - [x] New regression test fails without the product fix of JDK-8287073, passes with it. > - [x] Linux container tests on x86_64 and cg1 The `@bug` line difference seems to have occurred because JDK-8293540 was backported before JDK-8287107 and JDK-8287073 in 8u. Can we use this opportunity to get the bug line into numerical order, so any later patches apply cleanly? i.e. `@bug 8287107 8287073 8293540` as in https://github.com/openjdk/jdk/commit/6d83482a6b5f1898514fd450d8143dbfef57e362 ? Thanks. We should probably be removing the `@modules` line in 8u, but I'm happy to let that stay if it makes backports easier. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/323#pullrequestreview-1572942676 From andrew at openjdk.org Fri Aug 11 03:14:58 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 03:14:58 GMT Subject: [jdk8u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Tue, 6 Jun 2023 09:33:06 GMT, Alexey Pavlyutkin wrote: > Hi! > > I'd like to backport **[JDK-8274471: Add support for RSASSA-PSS in OCSP Response](https://bugs.openjdk.org/browse/JDK-8274471)** for parity with Oracle JDK. > > The patch from `11u` applied with the following changes (except the path shuffling): > > **`jdk/src/share/classes/sun/security/provider/certpath/OCSP.java`** > - `URLEncoder.encode()` accepts desired charset as a string, charset constants are not supported in `8`, so import of `java.nio.charset.StandardCharsets` also skipped > - resolved little baseline conflict > > **`jdk/src/share/classes/sun/security/x509/AlgorithmId.java`** > - required `public static String getDefaultSigAlgForKey(PrivateKey k)` and `private static String ecStrength (int bitLength)` copied from `11` > > Verification (amd64/20.04): `jdk/test/javax/net/ssl/Stapling/HttpsUrlConnClient.java` with new `RSASSA-PSS` case > Regression (amd64/20.04): `jdk_security` As with the dependency, I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/331#pullrequestreview-1572945384 From andrew at openjdk.org Fri Aug 11 03:14:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 03:14:59 GMT Subject: [jdk8u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: References:

Message-ID: On Tue, 6 Jun 2023 06:24:08 GMT, Alexey Pavlyutkin wrote: >> Hi! >> >> I would like to backport **[JDK-8179503: Java should support GET OCSP calls](https://bugs.openjdk.org/browse/JDK-8179503)** for parity with Oracle JDK. >> >> Except the path suffling the following changes were done to original patch: >> >> **`jdk/src/share/classes/sun/security/provider/certpath/OCSP.java`** >> - still reads the response piece by piece using `InputStream.read()` method because `IOUtils.readExactlyNBytes()` is not available >> >> **`jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java`** >> - unsupported `List.of()`, `Set.of()`, `Map.of()` replaced with equivalents >> - `algorithm` parameter dropped from instantiation `PKCS8EncodedKeySpec` >> >> **`jdk/test/javax/net/ssl/templates/SSLSocketTemplate.java`** >> - required `public static enum SSLSocketTemplate.Cert` copied from `11u` >> >> Verification (amd64/20.04LTS): newly added `jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java` >> Regression (amd64/20.04LTS): `jdk_security` > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > restore lost newlines at the end of files I don't see where the 'parity with Oracle' is coming from with this issue. The bug is an enhancement and only currently in 17. I would need a very strong reason to consider this for 8u and it would certainly need to be in 11u first. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/330#pullrequestreview-1572944456 From andrew at openjdk.org Fri Aug 11 03:28:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 03:28:29 GMT Subject: [jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2] In-Reply-To: References:

Message-ID: <5YMArd_WtNed7EkGrg0AdksU-UHx2BlksDCqTkahMDg=.f6f01795-be34-48a1-869a-6acd14585889@github.com> On Fri, 11 Aug 2023 03:05:31 GMT, Andrew John Hughes wrote: > Backport verified clean and approved for 8u. Thanks! > A question on the general patch out of interest; do we know that `infos.values().iterator().next()` will return non-null or is it just a lot less likely? At the point when we pick a controller we already know that at least one of them is available, but we don't know which. Previously we hard-coded to memory, which isn't true when only a cpu controller is in effect. To answer your question, I'm pretty sure we cannot see any `null` values using `infos.values().iterator().next()` (or it's a bug, which we've yet to see). HTH. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/324#issuecomment-1674415762 From sgehwolf at openjdk.org Fri Aug 11 09:20:00 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 11 Aug 2023 09:20:00 GMT Subject: [jdk8u-dev] Integrated: 8287073: NPE from CgroupV2Subsystem.getInstance() In-Reply-To: References: Message-ID: On Fri, 26 May 2023 14:46:38 GMT, Severin Gehwolf wrote: > Simple low-risk backport avoiding a potential NPE on some cgroups v2 systems. Patch applies clean after path unshuffeling. > > Testing: > - [x] Container tests on Linux x86_64. Pass. > - [x] Regression test from #323 This pull request has now been integrated. Changeset: 949d8e77 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/949d8e7783112977b644294620585513b7d63ae7 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8287073: NPE from CgroupV2Subsystem.getInstance() Reviewed-by: andrew Backport-of: 744b822ab194a0f7ef4e7a4053be32c6a0889efc ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/324 From sgehwolf at openjdk.org Fri Aug 11 09:25:29 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 11 Aug 2023 09:25:29 GMT Subject: [jdk8u-dev] RFR: 8287663: Add a regression test for JDK-8287073 [v2] In-Reply-To: References: Message-ID: > Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences): > > - Bug line in test. Fixed manually > - `Files.writeString()` => `Files.write()` changes in test. > > Testing: > - [x] New regression test fails without the product fix of JDK-8287073, passes with it. > - [x] Linux container tests on x86_64 and cg1 Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Fix bug line - Merge branch 'master' into jdk-8287663-backport - Backport 2d8c6490540e3ccea23b81129b2e4073915071e0 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/323/files - new: https://git.openjdk.org/jdk8u-dev/pull/323/files/63a56c99..6a4dca71 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=323&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=323&range=00-01 Stats: 890336 lines in 233 files changed: 889234 ins; 849 del; 253 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/323.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/323/head:pull/323 PR: https://git.openjdk.org/jdk8u-dev/pull/323 From sgehwolf at openjdk.org Fri Aug 11 09:26:28 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 11 Aug 2023 09:26:28 GMT Subject: [jdk8u-dev] RFR: 8287663: Add a regression test for JDK-8287073 In-Reply-To: References: Message-ID: On Fri, 26 May 2023 14:44:12 GMT, Severin Gehwolf wrote: > Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences): > > - Bug line in test. Fixed manually > - `Files.writeString()` => `Files.write()` changes in test. > > Testing: > - [x] New regression test fails without the product fix of JDK-8287073, passes with it. > - [x] Linux container tests on x86_64 and cg1 > Can we use this opportunity to get the bug line into numerical order, so any later patches apply cleanly? i.e. `@bug 8287107 8287073 8293540` as in [openjdk/jdk at 6d83482](https://github.com/openjdk/jdk/commit/6d83482a6b5f1898514fd450d8143dbfef57e362) ? Thanks. Fixed. More thoughts? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/323#issuecomment-1674424531 From sgehwolf at openjdk.org Fri Aug 11 09:49:29 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 11 Aug 2023 09:49:29 GMT Subject: [jdk8u-dev] RFR: 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:37 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8040887 for parity with Oracle 8u. > > Removes a flaky test. Backport is clean. @benty-amzn After this integration I see this when running tests: jdk8u-dev/hotspot/test/TEST.groups: group needs_jdk: file not found: runtime/6925573/SortMethodsTest.java Please remove the removed test from the `TEST.groups` file. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/351#issuecomment-1674466116 From andrew at openjdk.org Fri Aug 11 16:41:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 16:41:30 GMT Subject: [jdk8u-dev] RFR: 8287073: NPE from CgroupV2Subsystem.getInstance() In-Reply-To: <5YMArd_WtNed7EkGrg0AdksU-UHx2BlksDCqTkahMDg=.f6f01795-be34-48a1-869a-6acd14585889@github.com> References:

<5YMArd_WtNed7EkGrg0AdksU-UHx2BlksDCqTkahMDg=.f6f01795-be34-48a1-869a-6acd14585889@github.com> Message-ID: On Fri, 11 Aug 2023 08:56:04 GMT, Severin Gehwolf wrote: > > A question on the general patch out of interest; do we know that `infos.values().iterator().next()` will return non-null or is it just a lot less likely? > > At the point when we pick a controller we already know that at least one of them is available, but we don't know which. Previously we hard-coded to memory, which isn't true when only a cpu controller is in effect. To answer your question, I'm pretty sure we cannot see any `null` values using `infos.values().iterator().next()` (or it's a bug, which we've yet to see). > > HTH. It does, thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/324#issuecomment-1675057465 From abakhtin at openjdk.org Fri Aug 11 18:54:28 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 11 Aug 2023 18:54:28 GMT Subject: [jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2] In-Reply-To: References:

Message-ID: On Fri, 11 Aug 2023 03:17:58 GMT, Andrew John Hughes wrote: > While I'm not a fan of doing these kind of unrelated changes in the patch, it was in the original fix. Was the compiler unable to derive this type in 8u or was it just an accidental omission? Hi @gnu-andrew Thank you for review! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/340#issuecomment-1675220744 From andrew at openjdk.org Fri Aug 11 22:51:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 22:51:29 GMT Subject: [jdk8u-dev] RFR: 8212677: X11 default visual support for IM status window on VNC In-Reply-To: References: Message-ID: <-XzAw_UvRDKQLSxrVmSeZ82WTO54hWlJCNW5QYkfyXs=.1a2af7d1-7387-4449-80a6-9188aee05aa7@github.com> On Mon, 24 Jul 2023 20:23:40 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/86cf7f8768977aea7b9ea1c90da498a1d91d2891 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ichiroh Takiguchi on Feb 1, 2019 and was reviewed by Naoto Sato and Sergey Bylokhov > > @takiguc please take a look. > > Thanks! Patch looks like a clean backport to me. Please flag with `jdk8u-fix-request` for approval. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/345#pullrequestreview-1574455072 From andrew at openjdk.org Fri Aug 11 22:51:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 22:51:30 GMT Subject: [jdk8u-dev] RFR: 8287663: Add a regression test for JDK-8287073 [v2] In-Reply-To: References:

Message-ID: On Fri, 11 Aug 2023 09:25:29 GMT, Severin Gehwolf wrote: >> Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences): >> >> - Bug line in test. Fixed manually >> - `Files.writeString()` => `Files.write()` changes in test. >> >> Testing: >> - [x] New regression test fails without the product fix of JDK-8287073, passes with it. >> - [x] Linux container tests on x86_64 and cg1 > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Fix bug line > - Merge branch 'master' into jdk-8287663-backport > - Backport 2d8c6490540e3ccea23b81129b2e4073915071e0 No, that was the only issue I could see. Approved for 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/323#pullrequestreview-1574456052 From andrew at openjdk.org Fri Aug 11 22:51:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 11 Aug 2023 22:51:30 GMT Subject: [jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2] In-Reply-To: References:

Message-ID: On Thu, 3 Aug 2023 20:55:09 GMT, Alexey Bakhtin wrote: >> Please review the backport of sspi bridge to JDK8 >> >> The backport is based on the JDK11 version and is almost clean. >> The copyright years are updated manually: >> - NativeFunc.h already has a newer copyright year >> - SunNativeProvider.java updated manually >> The main difference is a build script for sspi_bridge. It is located in SecurityLibraries.gmk >> >> No regressions on the sun/security/krb5 tests (Windows and Linux platforms) > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge upstream/master into JDK-6722928 > - Backport 475996adc2aaa7af920f2e9711d0ace2ddd2430e Ah, I thought it might be something like that. Ok, patch looks good as is to me, let's get this in. Approved for 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/340#pullrequestreview-1574460870 From abakhtin at openjdk.org Fri Aug 11 23:17:33 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 11 Aug 2023 23:17:33 GMT Subject: [jdk8u-dev] Integrated: 6722928: Provide a default native GSS-API library on Windows In-Reply-To: References: Message-ID: On Thu, 13 Jul 2023 06:18:34 GMT, Alexey Bakhtin wrote: > Please review the backport of sspi bridge to JDK8 > > The backport is based on the JDK11 version and is almost clean. > The copyright years are updated manually: > - NativeFunc.h already has a newer copyright year > - SunNativeProvider.java updated manually > The main difference is a build script for sspi_bridge. It is located in SecurityLibraries.gmk > > No regressions on the sun/security/krb5 tests (Windows and Linux platforms) This pull request has now been integrated. Changeset: 5f62e559 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk8u-dev/commit/5f62e559fb5040c5d0021de4c3ee49e6fca6b087 Stats: 1720 lines in 8 files changed: 1612 ins; 14 del; 94 mod 6722928: Provide a default native GSS-API library on Windows Reviewed-by: phh, andrew Backport-of: 475996adc2aaa7af920f2e9711d0ace2ddd2430e ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/340 From abakhtin at openjdk.org Sat Aug 12 00:51:28 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Sat, 12 Aug 2023 00:51:28 GMT Subject: [jdk8u-dev] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors Message-ID: This is a follow-up fix for JDK-6722928. Clean backport from JDK11 ------------- Commit messages: - Backport e03c2a270b291e7b1edcf4df491d6d386a882a87 Changes: https://git.openjdk.org/jdk8u-dev/pull/353/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=353&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8225687 Stats: 127 lines in 3 files changed: 42 ins; 1 del; 84 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/353.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/353/head:pull/353 PR: https://git.openjdk.org/jdk8u-dev/pull/353 From serb at openjdk.org Sat Aug 12 01:31:02 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 12 Aug 2023 01:31:02 GMT Subject: [jdk8u-dev] RFR: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Message-ID: Hi all, This pull request contains a backport of commit [abeddab9](https://github.com/openjdk/jdk/commit/abeddab991d71f4ea54665082ffcb284267d7f44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen. Thanks! ------------- Commit messages: - 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Changes: https://git.openjdk.org/jdk8u-dev/pull/354/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=354&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6528710 Stats: 51 lines in 1 file changed: 51 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/354.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/354/head:pull/354 PR: https://git.openjdk.org/jdk8u-dev/pull/354 From serb at openjdk.org Sat Aug 12 01:43:59 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 12 Aug 2023 01:43:59 GMT Subject: [jdk8u-dev] RFR: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/349#pullrequestreview-1574633537 From andrew at openjdk.org Sat Aug 12 12:56:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 12 Aug 2023 12:56:59 GMT Subject: [jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 In-Reply-To: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> References: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> Message-ID: On Thu, 30 Mar 2023 21:12:59 GMT, Zdenek Zambersky wrote: > I would like to start effort to unify test libraries in openjdk 8 into one unified library. This is first step of that effort, which moves newest copy of jdk test library (added with jfr backport) from `jdk/test/lib` to `test/lib`. For more details please continue reading. > > **Problem:** > Test libraries in jdk8 are a bit messy. > There are currently 3 different test libraries: > - hotspot testlibrary - placed in [hotspot/test/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary), (pkgs `com.oracle.java.testlibrary`, `sun.hotspot...` ), includes testlibrary tests in [hotspot/test/testlibrary_tests](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary_tests) > - jdk testlibrary (old) - placed in [jdk/test/lib/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib/testlibrary), (pkgs `jdk.testlibrary`, `com.oracle.testlibrary.jsr292`) > - jdk test lib - placed directly in [jdk/test/lib](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib), was added with [jfr backport](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e), (pkgs `jdk.test.lib` `sun.hotspot...`) > > Many test library classes exist in multiple different copies (using different pkgs). Few examples: > - Platform.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/Platform.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/Platform.java)) > - OutputAnalyzer.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/process/OutputAnalyzer.java)) > - WhiteBox.java - 2 copies ([hotspot](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/sun/hotspot/WhiteBox.java)) > > Few additional obse... Should have put my above comment under a review... This is something I'm aware of and I've thought about tackling it in a similar way to you a few times. Thanks for finding the time to do so which has eluded me so far. I don't have any real issue with this PR, but then I guess this is the easy one. I'm a bit concerned about steps 2 & 3, because you seem to be suggesting that the existing HotSpot & JDK test libraries should be migrated to work with the ones from the JFR library. This seems like the wrong direction to me and a lot more work than migrating the JFR ones to work with the existing libraries (which is what the JFR backport should have done in the first place). As you say yourself, some of the JFR imported library code doesn't even compile and it includes stuff for newer JDKs which isn't appropriate in 8u. This PR would seem like a good opportunity to remove rather than move any of these files that don't compile (which presumably also means they aren't being used by the JFR tests). Have you verified that all the moved files actually compile? And if not, can we check that and delete any that don't? Then, in the HotSpot stage, we can merge in the HotSpot library and replace any duplicates with the 8u versions, and see what (if anything) breaks in the JFR tests. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/294#pullrequestreview-1575109615 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1675897397 From andrew at openjdk.org Sat Aug 12 13:11:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 12 Aug 2023 13:11:59 GMT Subject: [jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 In-Reply-To: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> References: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> Message-ID: On Thu, 30 Mar 2023 21:12:59 GMT, Zdenek Zambersky wrote: > I would like to start effort to unify test libraries in openjdk 8 into one unified library. This is first step of that effort, which moves newest copy of jdk test library (added with jfr backport) from `jdk/test/lib` to `test/lib`. For more details please continue reading. > > **Problem:** > Test libraries in jdk8 are a bit messy. > There are currently 3 different test libraries: > - hotspot testlibrary - placed in [hotspot/test/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary), (pkgs `com.oracle.java.testlibrary`, `sun.hotspot...` ), includes testlibrary tests in [hotspot/test/testlibrary_tests](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary_tests) > - jdk testlibrary (old) - placed in [jdk/test/lib/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib/testlibrary), (pkgs `jdk.testlibrary`, `com.oracle.testlibrary.jsr292`) > - jdk test lib - placed directly in [jdk/test/lib](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib), was added with [jfr backport](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e), (pkgs `jdk.test.lib` `sun.hotspot...`) > > Many test library classes exist in multiple different copies (using different pkgs). Few examples: > - Platform.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/Platform.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/Platform.java)) > - OutputAnalyzer.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/process/OutputAnalyzer.java)) > - WhiteBox.java - 2 copies ([hotspot](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/sun/hotspot/WhiteBox.java)) > > Few additional obse... I think we should also probably have a step 4 to actually move the tests. That will then solve the backporting problem where tests keep being introduced in the wrong location. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1675899040 From sgehwolf at openjdk.org Mon Aug 14 07:40:59 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 14 Aug 2023 07:40:59 GMT Subject: [jdk8u-dev] Integrated: 8287663: Add a regression test for JDK-8287073 In-Reply-To: References: Message-ID: On Fri, 26 May 2023 14:44:12 GMT, Severin Gehwolf wrote: > Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences): > > - Bug line in test. Fixed manually > - `Files.writeString()` => `Files.write()` changes in test. > > Testing: > - [x] New regression test fails without the product fix of JDK-8287073, passes with it. > - [x] Linux container tests on x86_64 and cg1 This pull request has now been integrated. Changeset: fc379423 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/fc379423b48eef9d6aee2a0cda7c87353dd31f71 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod 8287663: Add a regression test for JDK-8287073 Reviewed-by: phh, andrew Backport-of: 2d8c6490540e3ccea23b81129b2e4073915071e0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/323 From zzambers at openjdk.org Mon Aug 14 13:41:58 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 14 Aug 2023 13:41:58 GMT Subject: [jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 In-Reply-To: References: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> Message-ID: On Sat, 12 Aug 2023 12:50:22 GMT, Andrew John Hughes wrote: >> I would like to start effort to unify test libraries in openjdk 8 into one unified library. This is first step of that effort, which moves newest copy of jdk test library (added with jfr backport) from `jdk/test/lib` to `test/lib`. For more details please continue reading. >> >> **Problem:** >> Test libraries in jdk8 are a bit messy. >> There are currently 3 different test libraries: >> - hotspot testlibrary - placed in [hotspot/test/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary), (pkgs `com.oracle.java.testlibrary`, `sun.hotspot...` ), includes testlibrary tests in [hotspot/test/testlibrary_tests](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary_tests) >> - jdk testlibrary (old) - placed in [jdk/test/lib/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib/testlibrary), (pkgs `jdk.testlibrary`, `com.oracle.testlibrary.jsr292`) >> - jdk test lib - placed directly in [jdk/test/lib](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib), was added with [jfr backport](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e), (pkgs `jdk.test.lib` `sun.hotspot...`) >> >> Many test library classes exist in multiple different copies (using different pkgs). Few examples: >> - Platform.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/Platform.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/Platform.java)) >> - OutputAnalyzer.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/process/OutputAnalyzer.java)) >> - WhiteBox.java - 2 copies ([hotspot](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/sun/hotspot/WhiteBox.j... > > I think we should also probably have a step 4 to actually move the tests. That will then solve the backporting problem where tests keep being introduced in the wrong location. Hi @gnu-andrew, thank you for your review, > This is something I'm aware of and I've thought about tackling it in a similar way to you a few times. Thanks for finding the time to do so which has eluded me so far. > > I don't have any real issue with this PR, but then I guess this is the easy one. I'm a bit concerned about steps 2 & 3, because you seem to be suggesting that the existing HotSpot & JDK test libraries should be migrated to work with the ones from the JFR library. This seems like the wrong direction to me and a lot more work than migrating the JFR ones to work with the existing libraries (which is what the JFR backport should have done in the first place). > I haven't looked in too much detail, on how they should be merged, but probably on case by case basis. I think, in case of some more generic classes, rather than trying to merge `hs` and `jdk` versions (and fixing java package), it could make sense to just go with `jfr` version (if it looks ok for 8). I mean more generic classes like `Asserts.java`, `OutputAnalyzer.java`, maybe `Platform.java`. In other cases like broken/risky(low-level) stuff it would probably be better to go with `hs` (or `jdk`) version. (e.g. `whitebox` stuff) > As you say yourself, some of the JFR imported library code doesn't even compile and it includes stuff for newer JDKs which isn't appropriate in 8u. This PR would seem like a good opportunity to remove rather than move any of these files that don't compile (which presumably also means they aren't being used by the JFR tests). > > Have you verified that all the moved files actually compile? And if not, can we check that and delete any that don't? I have not excluded any files, just moved all of them. However excluding broken stuff here is probably good idea. Keeping and trying to fix unused broken code, would probably be waste of time, as they can be re-added later, if needed by future backport. (I'll take a look at that) > > Then, in the HotSpot stage, we can merge in the HotSpot library and replace any duplicates with the 8u versions, and see what (if anything) breaks in the JFR tests. For hotspot-specific or low-level stuff it is probably safest approach. In case of more generic classes (which are also used by `jdk` tests), keeping `jfr` version may be easier and safer option. Also we could use this opportunity to move whitebox classes to `jdk.test.lib` package (used by jdk 17+, see [JDK-8067223](https://bugs.openjdk.org/browse/JDK-8067223), probably can be backported to 11) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1677326906 From zzambers at openjdk.org Mon Aug 14 14:57:01 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 14 Aug 2023 14:57:01 GMT Subject: [jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 In-Reply-To: References: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> Message-ID: On Sat, 12 Aug 2023 12:50:22 GMT, Andrew John Hughes wrote: > I think we should also probably have a step 4 to actually move the tests. That will then solve the backporting problem where tests keep being introduced in the wrong location. Even though, it would be good for backporting, I have so far excluded tests themselfs from move, as there are some additional difficulties with that. While changing test library location can be done more or less transparently, in case of tests there are some complications: - It would be more invasive change needing changes to build system (makefiles) - It would break existing CI testing (would require changes), in cases, where jtreg is being called directly, rater than through main makefile, (e.g. Adoptium aqa-tests, see: [openjdk.mk](https://github.com/adoptium/aqa-tests/blob/07cac1895144ecb63a2ad03c3214a52fb108cfbc/openjdk/openjdk.mk#L122) [playlist.xml](https://github.com/adoptium/aqa-tests/blob/07cac1895144ecb63a2ad03c3214a52fb108cfbc/openjdk/playlist.xml#L717).) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1677441725 From btaylor at openjdk.org Mon Aug 14 16:26:30 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 14 Aug 2023 16:26:30 GMT Subject: [jdk8u-dev] RFR: 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:37 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8040887 for parity with Oracle 8u. > > Removes a flaky test. Backport is clean. Looks like that was done in [JDK-8042726](https://bugs.openjdk.org/browse/JDK-8042726), I'll create a separate PR for the backport. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/351#issuecomment-1677644543 From btaylor at openjdk.org Mon Aug 14 17:27:59 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 14 Aug 2023 17:27:59 GMT Subject: [jdk8u-dev] RFR: 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal Message-ID: Backport [JDK-8042726](https://bugs.openjdk.org/browse/JDK-8042726) as a follow-up to #351, to resolve a bug in that backport. Change has merge conflicts due to changes in context line, but the change itself is clean as it is a single-line deletion. ------------- Commit messages: - 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal Changes: https://git.openjdk.org/jdk8u-dev/pull/355/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=355&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8042726 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/355.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/355/head:pull/355 PR: https://git.openjdk.org/jdk8u-dev/pull/355 From dongbohe at openjdk.org Tue Aug 15 01:12:30 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Tue, 15 Aug 2023 01:12:30 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v2] In-Reply-To: References: Message-ID: > I would like to backport this patch to fix crash during C2 compilation. > > This patch doesn't apply cleanly due to context differences, and > I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. > > Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. Dongbo He has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into 8202952 - Backport 50e3aa4150dc1dd18870c5725666188ab38ab7d5 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/291/files - new: https://git.openjdk.org/jdk8u-dev/pull/291/files/ef05c21c..b86159a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=291&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=291&range=00-01 Stats: 908048 lines in 377 files changed: 904339 ins; 1874 del; 1835 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/291/head:pull/291 PR: https://git.openjdk.org/jdk8u-dev/pull/291 From dongbohe at openjdk.org Tue Aug 15 01:31:24 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Tue, 15 Aug 2023 01:31:24 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v3] In-Reply-To: References: Message-ID: > I would like to backport this patch to fix crash during C2 compilation. > > This patch doesn't apply cleanly due to context differences, and > I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. > > Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. Dongbo He has updated the pull request incrementally with one additional commit since the last revision: use X86_ONLY(LP64_ONLY(x)) instead of LP64_ONLY ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/291/files - new: https://git.openjdk.org/jdk8u-dev/pull/291/files/b86159a7..575aa534 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=291&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=291&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/291/head:pull/291 PR: https://git.openjdk.org/jdk8u-dev/pull/291 From dongbohe at openjdk.org Tue Aug 15 01:42:13 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Tue, 15 Aug 2023 01:42:13 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v3] In-Reply-To: References:

Message-ID: <19PMcAIdnWs_IuySMVfwoLTCoGlysvkVzFM3VCQ_vrE=.de98e955-6664-40b8-81d2-da04d193065a@github.com> On Mon, 14 Aug 2023 16:19:01 GMT, Ben Taylor wrote: > Looks like that was done in [JDK-8042726](https://bugs.openjdk.org/browse/JDK-8042726), I'll create a separate PR for the backport. Thank you! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/351#issuecomment-1680229757 From sgehwolf at openjdk.org Wed Aug 16 09:05:14 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 16 Aug 2023 09:05:14 GMT Subject: [jdk8u-dev] RFR: 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal In-Reply-To: References: Message-ID: <36yA-VT8n4cCynj2eI5iA6iLoBAoLw19C2qxK4IcQEk=.c2458573-bb41-44ac-bc14-b39d9b61a6b4@github.com> On Mon, 14 Aug 2023 17:01:40 GMT, Ben Taylor wrote: > Backport [JDK-8042726](https://bugs.openjdk.org/browse/JDK-8042726) as a follow-up to #351, to resolve a bug in that backport. Change has merge conflicts due to changes in context line, but the change itself is clean as it is a single-line deletion. LGTM. I've also approved the bug for 8u. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/355#pullrequestreview-1580138328 From btaylor at openjdk.org Wed Aug 16 18:17:17 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 16 Aug 2023 18:17:17 GMT Subject: [jdk8u-dev] Integrated: 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 17:01:40 GMT, Ben Taylor wrote: > Backport [JDK-8042726](https://bugs.openjdk.org/browse/JDK-8042726) as a follow-up to #351, to resolve a bug in that backport. Change has merge conflicts due to changes in context line, but the change itself is clean as it is a single-line deletion. This pull request has now been integrated. Changeset: 32324003 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/3232400385ca3797247bfba20a54616cf893c50f Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal Removed runtime/6925573/SortMethodsTest.java from TEST.groups Reviewed-by: sgehwolf Backport-of: 3e6986fb58400193cf02ce4566afcf8bd24b92de ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/355 From t.glaser at tarent.de Wed Aug 16 19:05:35 2023 From: t.glaser at tarent.de (Thorsten Glaser) Date: Wed, 16 Aug 2023 21:05:35 +0200 (CEST) Subject: [SECURITY] [DSA 5478-1] openjdk-11 security update In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023, Moritz Muehlenhoff wrote: >Debian Security Advisory DSA-5478-1 security at debian.org >Package : openjdk-11 >CVE ID : CVE-2023-21930 CVE-2023-21937 CVE-2023-21938 CVE-2023-21939 > CVE-2023-21954 CVE-2023-21967 CVE-2023-21968 CVE-2023-22006 > CVE-2023-22036 CVE-2023-22041 CVE-2023-22045 CVE-2023-22049 Do we have a corresponding update to jdk8u? Thanks in advance, //mirabilos -- Infrastrukturexperte ? tarent solutions GmbH Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941 Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg **************************************************** /?\ The UTF-8 Ribbon ??? Campaign against Mit dem tarent-Newsletter nichts mehr verpassen: ??? HTML eMail! Also, https://www.tarent.de/newsletter ??? header encryption! **************************************************** From sgehwolf at redhat.com Wed Aug 16 19:45:17 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Wed, 16 Aug 2023 21:45:17 +0200 Subject: [SECURITY] [DSA 5478-1] openjdk-11 security update In-Reply-To: References:

Message-ID: On Wed, 2023-08-16 at 21:05 +0200, Thorsten Glaser wrote: > On Wed, 16 Aug 2023, Moritz Muehlenhoff wrote: > > > Debian Security Advisory DSA-5478-1?????????????????? > > security at debian.org > > > Package??????? : openjdk-11 > > CVE ID???????? : CVE-2023-21930 CVE-2023-21937 CVE-2023-21938 CVE-2023-21939 > > ??????????????? CVE-2023-21954 CVE-2023-21967 CVE-2023-21968 CVE-2023-22006 > > ??????????????? CVE-2023-22036 CVE-2023-22041 CVE-2023-22045 CVE-2023-22049 > > Do we have a corresponding update to jdk8u? https://openjdk.org/groups/vulnerability/advisories/2023-07-18 Suggests this has been addressed in the 8u382 update in July. HTH. Thanks, Severin From t.glaser at tarent.de Wed Aug 16 19:57:11 2023 From: t.glaser at tarent.de (Thorsten Glaser) Date: Wed, 16 Aug 2023 21:57:11 +0200 (CEST) Subject: [SECURITY] [DSA 5478-1] openjdk-11 security update In-Reply-To: References:

Message-ID: On Wed, 16 Aug 2023, Severin Gehwolf wrote: >> Do we have a corresponding update to jdk8u? > >https://openjdk.org/groups/vulnerability/advisories/2023-07-18 > >Suggests this has been addressed in the 8u382 update in July. Thanks, that does indeed help. bye, //mirabilos -- Infrastrukturexperte ? tarent solutions GmbH Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941 Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg **************************************************** /?\ The UTF-8 Ribbon ??? Campaign against Mit dem tarent-Newsletter nichts mehr verpassen: ??? HTML eMail! Also, https://www.tarent.de/newsletter ??? header encryption! **************************************************** From abakhtin at openjdk.org Wed Aug 23 03:15:53 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 23 Aug 2023 03:15:53 GMT Subject: [jdk8u-dev] RFR: 8285398: Cache the results of constraint checks Message-ID: Backport applies almost cleanly. Small merge fixes in the import section caused by JDK-8280890 (already applied in 8u) and JDK-8233228 (applied differently than in 11u) No regression in jtreg tests Follow-up JDK-8285696 fix should be applied ------------- Commit messages: - Backport 00e9c96d51bec53d4ae8a07c9c98af2c62f3d290 Changes: https://git.openjdk.org/jdk8u-dev/pull/356/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=356&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285398 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/356.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/356/head:pull/356 PR: https://git.openjdk.org/jdk8u-dev/pull/356 From andrew at openjdk.org Wed Aug 23 09:20:49 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:20:49 GMT Subject: [jdk8u-dev] RFR: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion In-Reply-To: References: Message-ID: On Sat, 12 Aug 2023 01:01:56 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [abeddab9](https://github.com/openjdk/jdk/commit/abeddab991d71f4ea54665082ffcb284267d7f44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen. > Thanks! Trivially clean backport as it introduces a new test file, so only path adjustment is needed. Approving on the assumption this does pass on 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/354#pullrequestreview-1590736768 From andrew at openjdk.org Wed Aug 23 09:20:50 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:20:50 GMT Subject: [jdk8u-dev] RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:40 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8206179 for parity with Oracle 8u. > > Backport is clean, copyright was manually resolved. Backport is clean, bar the copyright header. Does the test pass on 8u when run standalone? The bug suggests it's part of tier5, not tier1. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/352#pullrequestreview-1590741780 From andrew at openjdk.org Wed Aug 23 09:20:54 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:20:54 GMT Subject: [jdk8u-dev] RFR: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. Changes to `ZipFileSystem.java` are clean (I think this code has been left largely untouched) Changes to `ZipCoder.java` are inapplicable because 8u does not have [JDK-8172921](https://bugs.openjdk.org/browse/JDK-8172921) which introduced the bad formatting (even though it's a code cleanup patch...) Approved for 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/349#pullrequestreview-1590734331 From andrew at openjdk.org Wed Aug 23 09:20:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:20:59 GMT Subject: [jdk8u-dev] RFR: 8212677: X11 default visual support for IM status window on VNC In-Reply-To: References: Message-ID: On Mon, 24 Jul 2023 20:23:40 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/86cf7f8768977aea7b9ea1c90da498a1d91d2891 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ichiroh Takiguchi on Feb 1, 2019 and was reviewed by Naoto Sato and Sergey Bylokhov > > @takiguc please take a look. > > Thanks! Approved. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/345#issuecomment-1689254541 From andrew at openjdk.org Wed Aug 23 09:21:31 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:21:31 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v3] In-Reply-To: References:

Message-ID: On Fri, 24 Mar 2023 13:47:54 GMT, Roland Westrelin wrote: >> Dongbo He has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' into 8202952 >> - Backport 50e3aa4150dc1dd18870c5725666188ab38ab7d5 > > Looks reasonable to me. Yes, this seems the better approach. Please let @rwestrel ack this updated patch version as well. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/291#issuecomment-1689563634 From andrew at openjdk.org Wed Aug 23 09:22:08 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 09:22:08 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build Message-ID: The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user. 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build. ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set. However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code. We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped. This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system. With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms) ------------- Commit messages: - 8281096: Flags introduced by configure script are not passed to ADLC build Changes: https://git.openjdk.org/jdk8u-dev/pull/357/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=357&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8281096 Stats: 19 lines in 4 files changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/357.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/357/head:pull/357 PR: https://git.openjdk.org/jdk8u-dev/pull/357 From roland at openjdk.org Wed Aug 23 09:33:32 2023 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 23 Aug 2023 09:33:32 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v3] In-Reply-To: References:

Message-ID: <4FOsZnpItDYIlYuwNrzXEKCB460A3R7QaDc7O069nyo=.d6a65dc6-64e5-4b7d-aa80-b8a82005996c@github.com> On Tue, 15 Aug 2023 01:31:24 GMT, Dongbo He wrote: >> I would like to backport this patch to fix crash during C2 compilation. >> >> This patch doesn't apply cleanly due to context differences, and >> I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. >> >> Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. > > Dongbo He has updated the pull request incrementally with one additional commit since the last revision: > > use X86_ONLY(LP64_ONLY(x)) instead of LP64_ONLY Update looks good. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/291#pullrequestreview-1591167289 From dongbohe at openjdk.org Wed Aug 23 11:11:27 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Wed, 23 Aug 2023 11:11:27 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching [v3] In-Reply-To: References:

Message-ID: On Tue, 15 Aug 2023 01:31:24 GMT, Dongbo He wrote: >> I would like to backport this patch to fix crash during C2 compilation. >> >> This patch doesn't apply cleanly due to context differences, and >> I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. >> >> Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. > > Dongbo He has updated the pull request incrementally with one additional commit since the last revision: > > use X86_ONLY(LP64_ONLY(x)) instead of LP64_ONLY Got the jdk8u-fix-yes. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/291#issuecomment-1691292613 From dongbohe at openjdk.org Thu Aug 24 12:50:37 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Thu, 24 Aug 2023 12:50:37 GMT Subject: [jdk8u-dev] Integrated: 8202952: C2: Unexpected dead nodes after matching In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 07:57:45 GMT, Dongbo He wrote: > I would like to backport this patch to fix crash during C2 compilation. > > This patch doesn't apply cleanly due to context differences, and > I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. > > Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. This pull request has now been integrated. Changeset: aa3e9dda Author: Dongbo He Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/aa3e9dda3d733508ad8bcd6e290f716b189141d4 Stats: 68 lines in 2 files changed: 68 ins; 0 del; 0 mod 8202952: C2: Unexpected dead nodes after matching Reviewed-by: roland, andrew Backport-of: 50e3aa4150dc1dd18870c5725666188ab38ab7d5 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/291 From xliu at openjdk.org Thu Aug 24 16:10:34 2023 From: xliu at openjdk.org (Xin Liu) Date: Thu, 24 Aug 2023 16:10:34 GMT Subject: [jdk8u-dev] RFR: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. Thanks all for reviewing this patch. --lx ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/349#issuecomment-1691982067 From xliu at openjdk.org Thu Aug 24 17:52:34 2023 From: xliu at openjdk.org (Xin Liu) Date: Thu, 24 Aug 2023 17:52:34 GMT Subject: [jdk8u-dev] Integrated: 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 22:54:53 GMT, Xin Liu wrote: > Package nio.zipfs is in demo directory of jdk8u. It is not the part of standard libraries until jdk9. However, we found that some Java8 applications use it and hit a bug. I guess this manifests Hyrum's Law again. > > This patch can *NOT* apply to jdk8u cleanly. I need to adjust the directory. I drop the cosmetic changes in nio/zipfs/ZipCoder.java. It helps minimize changeset. If we want to include them, we need to backport other patches. > > We test jtreg locally. I reckon the risk is minimal because the patch only adds a few boundary checks in nio/zipfs/EXTT. Without it, zipfs throws java.lang.ArrayIndexOutOfBoundsException when it encounters a problematic zip file. This pull request has now been integrated. Changeset: f9292695 Author: Xin Liu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/f92926955791c810469e412927f58f2ca634fe4b Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field" Reviewed-by: phh, serb, andrew Backport-of: 248778d27a5f8a16e4c90a4f5a6632a7ca8e9a89 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/349 From stuefe at openjdk.org Fri Aug 25 05:50:14 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 05:50:14 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 03:58:10 GMT, Andrew John Hughes wrote: > The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user. > > 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build. > > ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set. > > However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code. > > We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped. > > This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system. > > With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms) Looks good and makes sense. Why not passing LFLAGS to solaris? ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/357#pullrequestreview-1594912757 From inakonechnyy at openjdk.org Fri Aug 25 18:00:30 2023 From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy) Date: Fri, 25 Aug 2023 18:00:30 GMT Subject: [jdk8u-dev] RFR: 8159156: [TESTBUG] ReserveMemory test is not useful on Aix. Message-ID: Backport of JDK-8159156 [TESTBUG] ReserveMemory test is not useful on Aix. Applied cleanly. ------------- Commit messages: - Backport 8bb3799029d34e7f5bbc3d9e5bc6da7068360bc7 Changes: https://git.openjdk.org/jdk8u-dev/pull/358/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=358&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159156 Stats: 12 lines in 1 file changed: 2 ins; 8 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/358.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/358/head:pull/358 PR: https://git.openjdk.org/jdk8u-dev/pull/358 From phh at openjdk.org Fri Aug 25 20:53:16 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 25 Aug 2023 20:53:16 GMT Subject: [jdk8u-dev] RFR: 8285398: Cache the results of constraint checks In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 02:53:43 GMT, Alexey Bakhtin wrote: > Backport applies almost cleanly. > Small merge fixes in the import section caused by JDK-8280890 (already applied in 8u) and JDK-8233228 (applied differently than in 11u) > > No regression in jtreg tests > > Follow-up JDK-8285696 fix should be applied Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/356#pullrequestreview-1596495520 From andrew at openjdk.org Sun Aug 27 10:48:13 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 27 Aug 2023 10:48:13 GMT Subject: [jdk8u-dev] RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:40 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8206179 for parity with Oracle 8u. > > Backport is clean, copyright was manually resolved. Thanks. Approved for 8u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/352#pullrequestreview-1597114262 From serb at openjdk.org Mon Aug 28 18:51:15 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Aug 2023 18:51:15 GMT Subject: [jdk8u-dev] Integrated: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion In-Reply-To: References: Message-ID: On Sat, 12 Aug 2023 01:01:56 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [abeddab9](https://github.com/openjdk/jdk/commit/abeddab991d71f4ea54665082ffcb284267d7f44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen. > Thanks! This pull request has now been integrated. Changeset: 79cae436 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/79cae4364d17b449f645c94c5157bd3d81962c24 Stats: 51 lines in 1 file changed: 51 ins; 0 del; 0 mod 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Reviewed-by: andrew Backport-of: abeddab991d71f4ea54665082ffcb284267d7f44 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/354 From serb at openjdk.org Mon Aug 28 19:35:18 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Aug 2023 19:35:18 GMT Subject: [jdk8u-dev] Integrated: 8212677: X11 default visual support for IM status window on VNC In-Reply-To: References: Message-ID: On Mon, 24 Jul 2023 20:23:40 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/86cf7f8768977aea7b9ea1c90da498a1d91d2891 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ichiroh Takiguchi on Feb 1, 2019 and was reviewed by Naoto Sato and Sergey Bylokhov > > @takiguc please take a look. > > Thanks! This pull request has now been integrated. Changeset: 6c67bf69 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/6c67bf693bbe06d3d1cfec20baa1e435695ff34b Stats: 33 lines in 2 files changed: 19 ins; 5 del; 9 mod 8212677: X11 default visual support for IM status window on VNC Reviewed-by: phh, andrew Backport-of: 86cf7f8768977aea7b9ea1c90da498a1d91d2891 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/345 From serb at openjdk.org Tue Aug 29 01:23:44 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 01:23:44 GMT Subject: [jdk8u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Message-ID: <4uZA2nL5gSCEAzTf-Y_noi9cxjOfGxQ8bbOECob-SmM=.c2d48deb-d120-4368-99f7-ad3315961913@github.com> Hi all, This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 87298d2ade41c689d3140981a123b0e9130fc651 Changes: https://git.openjdk.org/jdk8u-dev/pull/359/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=359&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312535 Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/359.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/359/head:pull/359 PR: https://git.openjdk.org/jdk8u-dev/pull/359 From gnu.andrew at redhat.com Wed Aug 30 01:13:50 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 30 Aug 2023 02:13:50 +0100 Subject: [RAMPDOWN] 8u392 now in Rampdown Stage Message-ID: 8u392 is in rampdown for release in October. jdk8u-dev is CLOSED for commits until https://bugs.openjdk.org/browse/JDK-8315280 is integrated to begin the 8u402 release cycle. For critical fixes (i.e. regressions or urgent fixes like tzdata updates) for 8u392, please file a PR against https://github.com/openjdk/jdk8u and use jdk8u-critical-request to obtain approval to push. Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Wed Aug 30 01:24:36 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Aug 2023 01:24:36 GMT Subject: [jdk8u-dev] RFR: 8315280: Bump update version of OpenJDK: 8u402 Message-ID: Rampdown for 8u392 has begun. 8u-dev needs to transition to 8u402. ------------- Commit messages: - 8315280: Bump update version of OpenJDK: 8u402 Changes: https://git.openjdk.org/jdk8u-dev/pull/360/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=360&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315280 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/360.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/360/head:pull/360 PR: https://git.openjdk.org/jdk8u-dev/pull/360 From andrew at openjdk.org Wed Aug 30 01:27:14 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Aug 2023 01:27:14 GMT Subject: [jdk8u-dev] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors In-Reply-To: References: Message-ID: <24wuSQY6u7Ibq7FNLskRZICPFUIC_VW3IYMc9xBRuYA=.84ed9e2a-434b-4e6c-b745-649fbb12a3f1@github.com> On Sat, 12 Aug 2023 00:25:03 GMT, Alexey Bakhtin wrote: > This is a follow-up fix for JDK-6722928. > Clean backport from JDK11 Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/353#issuecomment-1698355448 From duke at openjdk.org Wed Aug 30 03:20:19 2023 From: duke at openjdk.org (duke) Date: Wed, 30 Aug 2023 03:20:19 GMT Subject: [jdk8u-dev] Withdrawn: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Wed, 24 May 2023 10:00:33 GMT, George Adams wrote: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/318 From serb at openjdk.org Wed Aug 30 05:25:15 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Aug 2023 05:25:15 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: On Wed, 24 May 2023 12:57:28 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > move libfreetype to correct src directory probably we should keep it open? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-1698511673 From serb at openjdk.org Wed Aug 30 05:27:13 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Aug 2023 05:27:13 GMT Subject: [jdk8u-dev] RFR: 8315280: Bump update version of OpenJDK: 8u402 In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 01:18:17 GMT, Andrew John Hughes wrote: > Rampdown for 8u392 has begun. 8u-dev needs to transition to 8u402. common/autoconf/version-numbers line 29: > 27: JDK_MINOR_VERSION=8 > 28: JDK_MICRO_VERSION=0 > 29: JDK_UPDATE_VERSION=402 Just in case, don't we need to bump the date in the copyright? ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/360#discussion_r1309676759 From abakhtin at openjdk.org Wed Aug 30 14:11:21 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 30 Aug 2023 14:11:21 GMT Subject: [jdk8u-dev] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors In-Reply-To: <24wuSQY6u7Ibq7FNLskRZICPFUIC_VW3IYMc9xBRuYA=.84ed9e2a-434b-4e6c-b745-649fbb12a3f1@github.com> References: <24wuSQY6u7Ibq7FNLskRZICPFUIC_VW3IYMc9xBRuYA=.84ed9e2a-434b-4e6c-b745-649fbb12a3f1@github.com> Message-ID: On Wed, 30 Aug 2023 01:25:00 GMT, Andrew John Hughes wrote: > Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble. Sure, just made a PR against openjdk/jdk8u ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/353#issuecomment-1699261144 From abakhtin at openjdk.org Wed Aug 30 14:14:37 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 30 Aug 2023 14:14:37 GMT Subject: [jdk8u] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors Message-ID: This is a follow-up fix for JDK-6722928. Clean backport from JDK11 ------------- Commit messages: - Backport e03c2a270b291e7b1edcf4df491d6d386a882a87 Changes: https://git.openjdk.org/jdk8u/pull/47/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=47&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8225687 Stats: 127 lines in 3 files changed: 42 ins; 1 del; 84 mod Patch: https://git.openjdk.org/jdk8u/pull/47.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/47/head:pull/47 PR: https://git.openjdk.org/jdk8u/pull/47 From simonis at openjdk.org Wed Aug 30 16:21:44 2023 From: simonis at openjdk.org (Volker Simonis) Date: Wed, 30 Aug 2023 16:21:44 GMT Subject: [jdk8u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() Message-ID: Hi all, This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. The backport applies cleanly except for the usual 11/8 directory shuffling and the following cosmetic context change in `jni.cpp`: > --- a/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp > +++ b/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp 58c58 < CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0); --- > CHECK_EXCEPTION_RETURN_VALUE(uPtr, NULL); Thanks! ------------- Commit messages: - Backport b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc Changes: https://git.openjdk.org/jdk8u-dev/pull/361/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=361&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315135 Stats: 65 lines in 4 files changed: 63 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/361.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/361/head:pull/361 PR: https://git.openjdk.org/jdk8u-dev/pull/361 From btaylor at openjdk.org Wed Aug 30 17:47:18 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 30 Aug 2023 17:47:18 GMT Subject: [jdk8u-dev] Integrated: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 20:45:40 GMT, Ben Taylor wrote: > Backporting https://bugs.openjdk.org/browse/JDK-8206179 for parity with Oracle 8u. > > Backport is clean, copyright was manually resolved. This pull request has now been integrated. Changeset: bbc068f2 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/bbc068f291f0af9c15edc10ed967dece8b44b8fd Stats: 15 lines in 1 file changed: 0 ins; 11 del; 4 mod 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value Reviewed-by: andrew, phh Backport-of: 1ea3869a926003cd3cebd3d8ecf9657646bdbda3 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/352 From andrew at openjdk.org Wed Aug 30 17:52:48 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Aug 2023 17:52:48 GMT Subject: [jdk8u-dev] RFR: 8315280: Bump update version of OpenJDK: 8u402 [v2] In-Reply-To: References: Message-ID: > Rampdown for 8u392 has begun. 8u-dev needs to transition to 8u402. Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: Bump common/autoconf/version-numbers copyright after ten years... ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/360/files - new: https://git.openjdk.org/jdk8u-dev/pull/360/files/b714ed62..97b23184 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=360&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=360&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/360.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/360/head:pull/360 PR: https://git.openjdk.org/jdk8u-dev/pull/360 From andrew at openjdk.org Wed Aug 30 17:52:49 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Aug 2023 17:52:49 GMT Subject: [jdk8u-dev] RFR: 8315280: Bump update version of OpenJDK: 8u402 [v2] In-Reply-To: References: