[jdk8u-dev] RFR: 8287663: Add a regression test for JDK-8287073
Andrew John Hughes
andrew at openjdk.org
Fri Aug 11 02:59:28 UTC 2023
On Fri, 26 May 2023 14:44:12 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> Simple low risk backport for a regression check of https://bugs.openjdk.org/browse/JDK-8287073 (forthcoming). The only changes were (other than context changes due to `optResult.equals(Optional.empty()` vs `optResult.isEmpty()` differences):
>
> - Bug line in test. Fixed manually
> - `Files.writeString()` => `Files.write()` changes in test.
>
> Testing:
> - [x] New regression test fails without the product fix of JDK-8287073, passes with it.
> - [x] Linux container tests on x86_64 and cg1
The `@bug` line difference seems to have occurred because JDK-8293540 was backported before JDK-8287107 and JDK-8287073 in 8u.
Can we use this opportunity to get the bug line into numerical order, so any later patches apply cleanly? i.e. `@bug 8287107 8287073 8293540` as in https://github.com/openjdk/jdk/commit/6d83482a6b5f1898514fd450d8143dbfef57e362 ? Thanks.
We should probably be removing the `@modules` line in 8u, but I'm happy to let that stay if it makes backports easier.
-------------
PR Review: https://git.openjdk.org/jdk8u-dev/pull/323#pullrequestreview-1572942676
More information about the jdk8u-dev
mailing list