[jdk8u-dev] RFR: 6722928: Provide a default native GSS-API library on Windows [v2]

[Andrew John Hughes]

On Thu, 3 Aug 2023 20:55:09 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Please review the backport of sspi bridge to JDK8
>> 
>> The backport is based on the JDK11 version and is almost clean.
>> The copyright years are updated manually:
>> - NativeFunc.h already has a newer copyright year
>> - SunNativeProvider.java updated manually
>> The main difference is a build script for sspi_bridge. It is located in SecurityLibraries.gmk
>> 
>> No regressions on the sun/security/krb5 tests (Windows and Linux platforms)
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge upstream/master into JDK-6722928
>  - Backport 475996adc2aaa7af920f2e9711d0ace2ddd2430e

Thanks for getting the CSR sorted. If that's approved for 8u, I don't have an issue with this change going into 8u.

As to the backport itself, it mostly looks good. The `Makefile` changes seem appropriate, given its location in a more general file, and I presume that it does build :)

There is a hunk missing in `SunNativeProvider.java`:

~~~
-@@ -68,7 +68,7 @@ public final class SunNativeProvider extends Provider {
-     static {
-         MECH_MAP =
-             AccessController.doPrivileged(
--                new PrivilegedAction<HashMap<String, String>>() {
-+                new PrivilegedAction<>() {
-                     public HashMap<String, String> run() {
-                         DEBUG = Boolean.parseBoolean
-                             (System.getProperty(DEBUG_PROP));
~~~

While I'm not a fan of doing these kind of unrelated changes in the patch, it was in the original fix. Was the compiler unable to derive this type in 8u or was it just an accidental omission?

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/340#pullrequestreview-1572953964