From andrew at openjdk.org  Sat Dec  2 00:39:51 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 2 Dec 2023 00:39:51 GMT
Subject: [jdk8u-dev] RFR: 8308592: Framework for CA interoperability
 testing [v4]
In-Reply-To: <Wc4l1_4_Bo_7FYnWc3eWivtpdkZKPFEXm3wynJmYg2I=.a1a241ba-9f6e-4b0a-bfc8-11f02deb69d9@github.com>
References: <nLjsmz7RYJr-3opqieWDgv6iID-HLEx5_lT9moVwGKk=.a1fdee02-7bea-4126-9942-b26c45381dc2@github.com>
 <Wc4l1_4_Bo_7FYnWc3eWivtpdkZKPFEXm3wynJmYg2I=.a1a241ba-9f6e-4b0a-bfc8-11f02deb69d9@github.com>
Message-ID: <nDFCUje70YDvM5ltNj1gC16VCw61aC3QQa0N4EnnSIU=.8de04f5c-c5b7-4d51-949a-20e92f7f85c6@github.com>

On Tue, 28 Nov 2023 15:12:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [da57d2a1](https://github.com/openjdk/jdk/commit/da57d2a1eb409ddc64117865c7d24ed518421cab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Rajan Halade on 19 Sep 2023 and was reviewed by Sean Mullan. It was backported to 17u on 2023-09-28 and 11u on 2023-10-11
>> 
>> It reworks the certificate tests to use test portals rather than having to maintain copies of the certificates in the OpenJDK repository and so should reduce the maintenance cost of these tests going forward. The fix has already been backported to 21u and Oracle-17u.
>> 
>> There were conflicts in the removals of `ActalisCA.java`, `BuypassCA.java`, `LetsEncryptCA.java` and `QuoVadisCA.java`, due to changes not in 8u. For the first of these, we backported JDK-8297955 (see #388) as it also contains a code change. As the other three are only test changes, we assumed these bugs to be resolved by the replacement of the individual tests with `CAInterop.java`.
>> 
>> The `ValidatePathWithURL.java` class had to be modified slightly to work with the 8u `cacerts`. These changes were based on the existing `ValidatePathWithParams.java`.
>> 
>> All tests pass with the exception of the OCSP case of `certignarootca`. This fails with `Caused by: java.security.cert.CertPathValidatorException: Certificate does not specify OCSP responder`. While not ideal, I don't think this is an issue with the testing backport so I'd suggest we look into this and fix it later, while getting this in so that pending certificate updates can go in. It seems to be 8u specific (the case passed on 11u). The CRL case does pass as does `CertignaCA.java` (not sure why there are two tests for this one).
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Explicitly enable stapling, which is disabled by default in the 8u backport of TLS 1.3

Thought I had, sorry.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/390#issuecomment-1836959465

From andrew at openjdk.org  Sat Dec  2 00:39:53 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 2 Dec 2023 00:39:53 GMT
Subject: [jdk8u-dev] Integrated: 8308592: Framework for CA interoperability
 testing
In-Reply-To: <nLjsmz7RYJr-3opqieWDgv6iID-HLEx5_lT9moVwGKk=.a1fdee02-7bea-4126-9942-b26c45381dc2@github.com>
References: <nLjsmz7RYJr-3opqieWDgv6iID-HLEx5_lT9moVwGKk=.a1fdee02-7bea-4126-9942-b26c45381dc2@github.com>
Message-ID: <NF7owzzFCdaonRSGrv-eaTb-7Yu-xhM4Dl-uET2Qmhs=.9180cb16-b9ee-46cb-b1fa-18c3f748be96@github.com>

On Fri, 24 Nov 2023 08:24:59 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [da57d2a1](https://github.com/openjdk/jdk/commit/da57d2a1eb409ddc64117865c7d24ed518421cab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Rajan Halade on 19 Sep 2023 and was reviewed by Sean Mullan. It was backported to 17u on 2023-09-28 and 11u on 2023-10-11
> 
> It reworks the certificate tests to use test portals rather than having to maintain copies of the certificates in the OpenJDK repository and so should reduce the maintenance cost of these tests going forward. The fix has already been backported to 21u and Oracle-17u.
> 
> There were conflicts in the removals of `ActalisCA.java`, `BuypassCA.java`, `LetsEncryptCA.java` and `QuoVadisCA.java`, due to changes not in 8u. For the first of these, we backported JDK-8297955 (see #388) as it also contains a code change. As the other three are only test changes, we assumed these bugs to be resolved by the replacement of the individual tests with `CAInterop.java`.
> 
> The `ValidatePathWithURL.java` class had to be modified slightly to work with the 8u `cacerts`. These changes were based on the existing `ValidatePathWithParams.java`.
> 
> All tests pass with the exception of the OCSP case of `certignarootca`. This fails with `Caused by: java.security.cert.CertPathValidatorException: Certificate does not specify OCSP responder`. While not ideal, I don't think this is an issue with the testing backport so I'd suggest we look into this and fix it later, while getting this in so that pending certificate updates can go in. It seems to be 8u specific (the case passed on 11u). The CRL case does pass as does `CertignaCA.java` (not sure why there are two tests for this one).

This pull request has now been integrated.

Changeset: b610be3d
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b610be3da454727b1b22631f24beab165777d6a9
Stats:     6505 lines in 18 files changed: 1014 ins; 5491 del; 0 mod

8308592: Framework for CA interoperability testing
8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
8288132: Update test artifacts in QuoVadis CA interop tests
8268678: LetsEncryptCA.java test fails as Let?s Encrypt Authority X3 is retired
8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java  OCSP response error

Reviewed-by: sgehwolf
Backport-of: c4faab66933b5977a466f28c31cba9fc099c8fb4

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/390

From sgehwolf at openjdk.org  Sat Dec  2 00:46:27 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Sat, 2 Dec 2023 00:46:27 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v2]
In-Reply-To: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
Message-ID: <TKraYhvI1bU8DLt8Ekk2PQL6sXucx3fYZ9l_WRTFPkg=.0d163be0-4d9b-49de-bcd6-d66955738fe2@github.com>

> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/397/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/397/files/243ad718..243ad718

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=397&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=397&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/397.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/397/head:pull/397

PR: https://git.openjdk.org/jdk8u-dev/pull/397

From sgehwolf at openjdk.org  Mon Dec  4 11:04:10 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Dec 2023 11:04:10 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v6]
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <bsqDmq1BUUj-HwrJuNcgRJyQ-s2j428nJBUX27ztXgw=.a9f2b7a3-fde9-40f1-9f21-d54944c288fa@github.com>

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [ ] GHA (still running). It should be clean after #390.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Move to jdk_security_infra and add to tier1
 - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/368/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=05
  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/368.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From sgehwolf at openjdk.org  Mon Dec  4 11:08:13 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Dec 2023 11:08:13 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v3]
In-Reply-To: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
Message-ID: <W5Fh-vc2DscYTLXQGfN01Pw2Jm5HC8bz6X2TOdF_llk=.29011714-6f90-45f9-84c9-7b40441ad1db@github.com>

> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/397/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=397&range=02
  Stats: 58 lines in 3 files changed: 55 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/397.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/397/head:pull/397

PR: https://git.openjdk.org/jdk8u-dev/pull/397

From sgehwolf at openjdk.org  Mon Dec  4 11:10:28 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Dec 2023 11:10:28 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v2]
In-Reply-To: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
Message-ID: <dcflJXhMGqfUrGRq0vwwc5zsB4nrjNpWN_IaDH04cxk=.b2e4a565-8cd4-4842-895a-cad9b16d763b@github.com>

> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
> 
> Testing:
> - [ ] GHA (still running)
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/398/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/398/files/71a0adac..71a0adac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=398&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=398&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/398.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/398/head:pull/398

PR: https://git.openjdk.org/jdk8u-dev/pull/398

From sgehwolf at openjdk.org  Mon Dec  4 13:46:20 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Dec 2023 13:46:20 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v3]
In-Reply-To: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
Message-ID: <lo9Kzt4zDXTXoHCIM-iwsH8utwjAgpSYXPHYnpsLkhY=.b7df97d2-f96f-41f7-beec-28d0cd3eb2a1@github.com>

> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/398/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=398&range=02
  Stats: 39 lines in 3 files changed: 35 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/398.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/398/head:pull/398

PR: https://git.openjdk.org/jdk8u-dev/pull/398

From sgehwolf at openjdk.org  Mon Dec  4 13:48:13 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Dec 2023 13:48:13 GMT
Subject: [jdk8u-dev] RFR: 8318759: Add four DigiCert root certificates [v2]
In-Reply-To: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
References: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
Message-ID: <3EPQI4yFBz7kXs9APzgnphFpwYDD5uRH9jLgcURGaVM=.0b710a1f-aa2a-4c2b-9b4c-aafb2051b41f@github.com>

> Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
> 
> Testing:
> - [ ] GHA (still running)
> - [x] jdk/test/security/infra/java/security/cert/CertPathValidator and jdk/test/sun/security/lib/cacerts jtreg tests. Including new ones. All 43 tests pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/399/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/399/files/dc542fe5..dc542fe5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=399&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=399&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/399.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/399/head:pull/399

PR: https://git.openjdk.org/jdk8u-dev/pull/399

From andrew at openjdk.org  Tue Dec  5 14:12:52 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 5 Dec 2023 14:12:52 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v6]
In-Reply-To: <bsqDmq1BUUj-HwrJuNcgRJyQ-s2j428nJBUX27ztXgw=.a9f2b7a3-fde9-40f1-9f21-d54944c288fa@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bsqDmq1BUUj-HwrJuNcgRJyQ-s2j428nJBUX27ztXgw=.a9f2b7a3-fde9-40f1-9f21-d54944c288fa@github.com>
Message-ID: <MgO9xw3eJQd1ZLDlrK4KBpQQXjSG1BbQvpZ95d3MWRg=.296cad1c-59e3-45ac-a8b4-7d6e6d203d0c@github.com>

On Mon, 4 Dec 2023 11:04:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (including the new [CA certs tests](https://github.com/jerboaa/jdk8u-dev/actions/runs/7085611627/job/19282659481#step:9:1315)).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

jdk tests finally passing (for the time being!)

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/368#pullrequestreview-1765181523

From sgehwolf at openjdk.org  Tue Dec  5 16:37:57 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Dec 2023 16:37:57 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v6]
In-Reply-To: <bsqDmq1BUUj-HwrJuNcgRJyQ-s2j428nJBUX27ztXgw=.a9f2b7a3-fde9-40f1-9f21-d54944c288fa@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bsqDmq1BUUj-HwrJuNcgRJyQ-s2j428nJBUX27ztXgw=.a9f2b7a3-fde9-40f1-9f21-d54944c288fa@github.com>
Message-ID: <9Pn9IV7MXO5-1gOvD2gtg-lLHWHqFv2B6XWmbcoYE8M=.6a447914-3788-4fd4-baa4-611c58f3b250@github.com>

On Mon, 4 Dec 2023 11:04:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (including the new [CA certs tests](https://github.com/jerboaa/jdk8u-dev/actions/runs/7085611627/job/19282659481#step:9:1315)).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Thanks for the review and approval!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1841159586

From sgehwolf at openjdk.org  Tue Dec  5 16:37:59 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Dec 2023 16:37:59 GMT
Subject: [jdk8u-dev] Integrated: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <-luK7HFhGfmzZXUD66R6revkBuGeV-5-jNhAYGKNufI=.87ffabd7-8915-43b8-b4cf-c584e58c47f5@github.com>

On Wed, 6 Sep 2023 13:50:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (including the new [CA certs tests](https://github.com/jerboaa/jdk8u-dev/actions/runs/7085611627/job/19282659481#step:9:1315)).

This pull request has now been integrated.

Changeset: 74a3dddd
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/74a3ddddd7784b513911bedb999c967fbed92e92
Stats:     5 lines in 1 file changed: 3 ins; 0 del; 2 mod

8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Reviewed-by: phh, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From sgehwolf at openjdk.org  Tue Dec  5 17:40:05 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Dec 2023 17:40:05 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v4]
In-Reply-To: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
Message-ID: <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>

> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into jdk-8317373-telia-root2
 - Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/397/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/397/files/c4e404eb..073931b6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=397&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=397&range=02-03

  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/397.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/397/head:pull/397

PR: https://git.openjdk.org/jdk8u-dev/pull/397

From sgehwolf at openjdk.org  Tue Dec  5 17:51:48 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Dec 2023 17:51:48 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v4]
In-Reply-To: <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
 <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
Message-ID: <52XQhRHSmPn6DJtnxgPZSCoXOx9TYY-JvTeN1_F6Uvw=.72e07704-07a9-498c-8fa0-02a6557d07da@github.com>

On Tue, 5 Dec 2023 17:40:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into jdk-8317373-telia-root2
>  - Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

With the latest merge #368 is part of it, so GHA should run the tests as well.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/397#issuecomment-1841313228

From phh at openjdk.org  Wed Dec  6 13:01:49 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 6 Dec 2023 13:01:49 GMT
Subject: [jdk8u-dev] RFR: 8304074: [JMX] Add an approximation of total
 bytes allocated on the Java heap by the JVM [v2]
In-Reply-To: <XXckAHwedq7Yided3yYZw56qIZ_EGMCdeDOWk4_TZrI=.4f4a63c7-84fa-4057-bf41-515592ed1755@github.com>
References: <_ZWKxcgZzaoqb9iLlIsSoceyd-fiHhdHOpVmTsbRNI0=.99ae0e62-e9b2-4ef0-a6fe-15faa3e3c9cd@github.com>
 <XXckAHwedq7Yided3yYZw56qIZ_EGMCdeDOWk4_TZrI=.4f4a63c7-84fa-4057-bf41-515592ed1755@github.com>
Message-ID: <_jQP_ACz2Ee9Kp2tWn6JVAxxCoUCxas0dWt5jIJLMnw=.9b5f1a82-f497-47f4-88af-4390f29df327@github.com>

On Tue, 28 Nov 2023 23:14:29 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> I'd like to backport the definition and implementation of com.sun.management.ThreadMXBean.getTotalThreadAllocatedBytes to 8u. The backport CSR is [JDK-8320375](https://bugs.openjdk.org/browse/JDK-8320375). A follow-up bugfix backport of [JDK-8313081](https://bugs.openjdk.org/browse/JDK-8313081) will be done following this backport. The combined backports have been in production at Amazon for two months with no issues. The backport uses the reserved1 slot in jmm.h in order to preserve binary compatibility with 8u. Per current policy, there is no update to JMM_VERSION in jmm.h and the new method is marked
>> 
>> @since 8u412
>> 
>> Aside from file relocation and context differences, relative to the 11u backport the MonitoringSupport_lock definition macro changes, and the reserved1 rather than reserved6 jmm slot is used. SMR doesn't exist in 8u, so jmm_GetTotalThreadAllocated bytes attempts to lock Threads_lock instead, and if the Threads_lock is already locked, the previous return value is returned. HotSpotThreadImpl.java doesn't exist in 8u, so the hunk associated with it is dropped.
>
> Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8304074: whitespace fix

Pre-submit failures appear unrelated.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/392#issuecomment-1842834030

From jkratochvil at azul.com  Wed Dec  6 14:33:00 2023
From: jkratochvil at azul.com (Jan Kratochvil (Azul))
Date: Wed, 6 Dec 2023 22:33:00 +0800
Subject: Backporting stack guard fixes from JDK-9 (8169373+8159335+8139864)
Message-ID: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>

Hello,

I got a crash report for an OpenJDK-8 derivation (Azul company's build Zulu-8)
on aarch64. Details are at the end. I believe it could be fixed by some
backports below but the resulting patch gets too big (>10k LoC = Lines of
Code).

Do you have an idea how to make the backport feasible for JDK-8?

JDK-8169373: Work around linux NPTL stack guard error
 13 files changed, 165 insertions(+), 425 deletions(-)

Unfortunately this patch depends on a lot of other code from JDK-9 and
I believe these fixes are related anyway so they also need a backport:

JDK-8159335: Fix problems with stack overflow handling
 33 files changed, 183 insertions(+), 236 deletions(-)
JDK-8139864: Improve handling of stack protection zones
 43 files changed, 312 insertions(+), 226 deletions(-)

To satisfy dependencies of the patches above I had to backport also:
    8078513: [linux] Clean up code relevant to LinuxThreads implementation
    8080298: Clean up os::...::supports_variable_stack_size()
    8037842: Failing to allocate MethodCounters and MDO causes a serious performance drop
    8059847: complement JDK-8055286 and JDK-8056964 changes
    8059606: Enable per-method usage of CompileThresholdScaling (per-method compilation thresholds)
    8074119: [AARCH64] stage repo misses fixes from several Hotspot changes
    8013393: Merge template interpreter files for x86 _32 and _64
    8122937: [JEP 245] Validate JVM Command-Line Flag Arguments
    8078556: Runtime: implement ranges (optionally constraints) for those flags that have them missing
    8048241: Introduce umbrella header os.inline.hpp and clean up includes
^^^ 8139864: Improve handling of stack protection zones
^^^ 8159335: Fix problems with stack overflow handling
    8140520: segfault on solaris-amd64 with "-XX:VMThreadStackSize=1" option
^^^ 8169373: Work around linux NPTL stack guard error
    8049325: Introduce and clean up umbrella headers for the files in the cpu subdirectories
    8064611: AARCH64: Changes to HotSpot shared code
    8160189: Fix for 8159335 breaks AArch64
    8130858: CICompilerCount=1 when tiered is off is not allowed any more
    8072931: JEP-JDK-8059557: Test task: test framework development
 228 files changed, 13311 insertions(+), 8831 deletions(-)

Which is just a too big patch for a backport into JDK-8. There are some
possibilities for minor reduction of the whole patch but it will be still
around 10k LoC. None of the patches above have been backported to JDK-8.

Unfortunately due to time constraints I do not yet have confirmed these
backports really fix this crash. It needs to be tested at a customer as I do
not have a reproducer (and it is even difficult to reproduce on the target
system).

I can publish the whole patchset above but I would need to rebase it first
from the Zulu-8 derivation to plain OpenJDK-8.


Thanks for your opinion,
Jan Kratochvil

------------------------------------------------------------------------------

The crashing memory access of __resp is in TLS (thread-local storage) which
points to an unmapped memory during very early thread startup still in glibc:

#1  <signal handler called>
#2  start_thread (arg=0x7ef47cd160) at /usr/src/debug/glibc/2.23-r0/git/nptl/pthread_create.c:265
265      __resp = &pd->res;
=> 0x0000007f836e7f1c <+36>:    str    x0, [x2, x1]

Program Headers:
  Type           Offset   VirtAddr           PhysAddr           FileSiz  MemSiz   Flg Align
  LOAD           0x10e75000 0x0000007ef45ce000 0x0000000000000000 0x1ff000 0x1ff000 RW  0x1000
                                  0x7ef47cd000=end
                                    7ef47cd850=accessed memory __resp
  LOAD           0x11074000 0x0000007ef47ce000 0x0000000000000000 0x003000 0x003000     0x1000

A different thread was creating the thread above:

[Current thread is 13 (LWP 834)]
#5  0x0000007f811b83a4 in os::create_thread (thread=0x7f20010420, thr_type=<optimized out>, stack_size=<optimized out>)
    at zulu8-arm64-dev/hotspot/src/os/linux/vm/os_linux.cpp:939
        tid = 545267700064 = 0x7ef47cd160

Someone did unmap the page where TLS of the new thread is being located before
the thread really started.

Given there is always gap 0x3000 between the mappings - it should be the guard
pages.

  Type           Offset     VirtAddr           PhysAddr           FileSiz  MemSiz   Flg Align
  LOAD           0x10e75000 0x0000007ef45ce000 0x0000000000000000 0x1ff000 0x1ff000 RW  0x1000
                                  0x7ef47cb6c0=$sp of Thread 1 (LWP 1358)
                                  0x7ef47cd000=mapped area end
                                  0x7ef47cd160=thread tid
                                  0x7ef47cd850=accessed memory __resp
  LOAD           0x11074000 0x0000007ef47ce000 0x0000000000000000 0x003000 0x003000     0x1000
  LOAD           0x11077000 0x0000007ef47d1000 0x0000000000000000 0x1fd000 0x1fd000 RW  0x1000
                                  0x7ef49cc240=$sp of Thread 37 (LWP 1349)
  LOAD           0x11274000 0x0000007ef49ce000 0x0000000000000000 0x003000 0x003000     0x1000
  LOAD           0x11277000 0x0000007ef49d1000 0x0000000000000000 0x1fd000 0x1fd000 RW  0x1000
                                  0x7ef4bc8fa0=$sp of Thread 36 (LWP 1290)
  LOAD           0x11474000 0x0000007ef4bce000 0x0000000000000000 0x000000 0x003000     0x1000

From sgehwolf at openjdk.org  Wed Dec  6 14:39:56 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Dec 2023 14:39:56 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v4]
In-Reply-To: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
Message-ID: <U87o9KuGUX9qrVIiohMychOtG4tK0Pki726ve94s4_I=.e4b8143f-79c3-489c-9770-edbb6e5dd323@github.com>

> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/398/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=398&range=03
  Stats: 39 lines in 3 files changed: 35 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/398.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/398/head:pull/398

PR: https://git.openjdk.org/jdk8u-dev/pull/398

From thomas.stuefe at gmail.com  Wed Dec  6 16:22:34 2023
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Wed, 6 Dec 2023 17:22:34 +0100
Subject: Backporting stack guard fixes from JDK-9 (8169373+8159335+8139864)
In-Reply-To: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>
References: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>
Message-ID: <CAA-vtUy6ParNLuGf=jLX8MjL+rQH==LgLOAjLC-uWvNmJaq6eQ@mail.gmail.com>

Hi Jan,

are you sure this crash is related to JDK-8169373?

As far as I remember that bug resulted in threads possibly failing to start
because the thread stack size specified was too small; I don't see how it
can cause crashes like the one you describe. Once the thread had been
started successfully, things should work, no?

Thanks, Thomas


On Wed, Dec 6, 2023 at 5:07?PM Jan Kratochvil (Azul) <jkratochvil at azul.com>
wrote:

> Hello,
>
> I got a crash report for an OpenJDK-8 derivation (Azul company's build
> Zulu-8)
> on aarch64. Details are at the end. I believe it could be fixed by some
> backports below but the resulting patch gets too big (>10k LoC = Lines of
> Code).
>
> Do you have an idea how to make the backport feasible for JDK-8?
>
> JDK-8169373: Work around linux NPTL stack guard error
>  13 files changed, 165 insertions(+), 425 deletions(-)
>
> Unfortunately this patch depends on a lot of other code from JDK-9 and
> I believe these fixes are related anyway so they also need a backport:
>
> JDK-8159335: Fix problems with stack overflow handling
>  33 files changed, 183 insertions(+), 236 deletions(-)
> JDK-8139864: Improve handling of stack protection zones
>  43 files changed, 312 insertions(+), 226 deletions(-)
>
> To satisfy dependencies of the patches above I had to backport also:
>     8078513: [linux] Clean up code relevant to LinuxThreads implementation
>     8080298: Clean up os::...::supports_variable_stack_size()
>     8037842: Failing to allocate MethodCounters and MDO causes a serious
> performance drop
>     8059847: complement JDK-8055286 and JDK-8056964 changes
>     8059606: Enable per-method usage of CompileThresholdScaling
> (per-method compilation thresholds)
>     8074119: [AARCH64] stage repo misses fixes from several Hotspot changes
>     8013393: Merge template interpreter files for x86 _32 and _64
>     8122937: [JEP 245] Validate JVM Command-Line Flag Arguments
>     8078556: Runtime: implement ranges (optionally constraints) for those
> flags that have them missing
>     8048241: Introduce umbrella header os.inline.hpp and clean up includes
> ^^^ 8139864: Improve handling of stack protection zones
> ^^^ 8159335: Fix problems with stack overflow handling
>     8140520: segfault on solaris-amd64 with "-XX:VMThreadStackSize=1"
> option
> ^^^ 8169373: Work around linux NPTL stack guard error
>     8049325: Introduce and clean up umbrella headers for the files in the
> cpu subdirectories
>     8064611: AARCH64: Changes to HotSpot shared code
>     8160189: Fix for 8159335 breaks AArch64
>     8130858: CICompilerCount=1 when tiered is off is not allowed any more
>     8072931: JEP-JDK-8059557: Test task: test framework development
>  228 files changed, 13311 insertions(+), 8831 deletions(-)
>
> Which is just a too big patch for a backport into JDK-8. There are some
> possibilities for minor reduction of the whole patch but it will be still
> around 10k LoC. None of the patches above have been backported to JDK-8.
>
> Unfortunately due to time constraints I do not yet have confirmed these
> backports really fix this crash. It needs to be tested at a customer as I
> do
> not have a reproducer (and it is even difficult to reproduce on the target
> system).
>
> I can publish the whole patchset above but I would need to rebase it first
> from the Zulu-8 derivation to plain OpenJDK-8.
>
>
> Thanks for your opinion,
> Jan Kratochvil
>
>
> ------------------------------------------------------------------------------
>
> The crashing memory access of __resp is in TLS (thread-local storage) which
> points to an unmapped memory during very early thread startup still in
> glibc:
>
> #1  <signal handler called>
> #2  start_thread (arg=0x7ef47cd160) at
> /usr/src/debug/glibc/2.23-r0/git/nptl/pthread_create.c:265
> 265      __resp = &pd->res;
> => 0x0000007f836e7f1c <+36>:    str    x0, [x2, x1]
>
> Program Headers:
>   Type           Offset   VirtAddr           PhysAddr           FileSiz
> MemSiz   Flg Align
>   LOAD           0x10e75000 0x0000007ef45ce000 0x0000000000000000 0x1ff000
> 0x1ff000 RW  0x1000
>                                   0x7ef47cd000=end
>                                     7ef47cd850=accessed memory __resp
>   LOAD           0x11074000 0x0000007ef47ce000 0x0000000000000000 0x003000
> 0x003000     0x1000
>
> A different thread was creating the thread above:
>
> [Current thread is 13 (LWP 834)]
> #5  0x0000007f811b83a4 in os::create_thread (thread=0x7f20010420,
> thr_type=<optimized out>, stack_size=<optimized out>)
>     at zulu8-arm64-dev/hotspot/src/os/linux/vm/os_linux.cpp:939
>         tid = 545267700064 = 0x7ef47cd160
>
> Someone did unmap the page where TLS of the new thread is being located
> before
> the thread really started.
>
> Given there is always gap 0x3000 between the mappings - it should be the
> guard
> pages.
>
>   Type           Offset     VirtAddr           PhysAddr           FileSiz
> MemSiz   Flg Align
>   LOAD           0x10e75000 0x0000007ef45ce000 0x0000000000000000 0x1ff000
> 0x1ff000 RW  0x1000
>                                   0x7ef47cb6c0=$sp of Thread 1 (LWP 1358)
>                                   0x7ef47cd000=mapped area end
>                                   0x7ef47cd160=thread tid
>                                   0x7ef47cd850=accessed memory __resp
>   LOAD           0x11074000 0x0000007ef47ce000 0x0000000000000000 0x003000
> 0x003000     0x1000
>   LOAD           0x11077000 0x0000007ef47d1000 0x0000000000000000 0x1fd000
> 0x1fd000 RW  0x1000
>                                   0x7ef49cc240=$sp of Thread 37 (LWP 1349)
>   LOAD           0x11274000 0x0000007ef49ce000 0x0000000000000000 0x003000
> 0x003000     0x1000
>   LOAD           0x11277000 0x0000007ef49d1000 0x0000000000000000 0x1fd000
> 0x1fd000 RW  0x1000
>                                   0x7ef4bc8fa0=$sp of Thread 36 (LWP 1290)
>   LOAD           0x11474000 0x0000007ef4bce000 0x0000000000000000 0x000000
> 0x003000     0x1000
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20231206/d9261fec/attachment.htm>

From sgehwolf at openjdk.org  Wed Dec  6 17:07:43 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Dec 2023 17:07:43 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v4]
In-Reply-To: <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
 <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
Message-ID: <AAkcrDx3wzxVI0-UfFOOx6PmaJhA6jkn1UVcknIU_HY=.81b6fe3f-2392-4f12-9b91-0bd6fd33b2ad@github.com>

On Tue, 5 Dec 2023 17:40:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into jdk-8317373-telia-root2
>  - Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

Test failures seem infra related. All pass in #398

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/397#issuecomment-1843304414

From duke at openjdk.org  Wed Dec  6 19:21:49 2023
From: duke at openjdk.org (duke)
Date: Wed, 6 Dec 2023 19:21:49 GMT
Subject: [jdk8u-dev] Withdrawn: 8154043: Fields not reachable anymore by
 tab-key, because of new tabbing behaviour of radio button groups.
In-Reply-To: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
Message-ID: <FCaUl1cRrezTekL3z9_WU9WkTi-18Kf4LB6397n6xpU=.34145d29-31df-45dc-a203-f94b136c8b4b@github.com>

On Wed, 15 Mar 2023 05:47:54 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
> 
> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
> 
> Testing:
> java/awt
> javax/swing
> ButtonGroupLayoutTraversalTest.java
> bug8033699.java
> DefaultButtonModelCrashTest.java
> on Windows x86_64

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/285

From phh at openjdk.org  Wed Dec  6 23:42:42 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 6 Dec 2023 23:42:42 GMT
Subject: [jdk8u-dev] RFR: 8304074: [JMX] Add an approximation of total
 bytes allocated on the Java heap by the JVM [v2]
In-Reply-To: <XXckAHwedq7Yided3yYZw56qIZ_EGMCdeDOWk4_TZrI=.4f4a63c7-84fa-4057-bf41-515592ed1755@github.com>
References: <_ZWKxcgZzaoqb9iLlIsSoceyd-fiHhdHOpVmTsbRNI0=.99ae0e62-e9b2-4ef0-a6fe-15faa3e3c9cd@github.com>
 <XXckAHwedq7Yided3yYZw56qIZ_EGMCdeDOWk4_TZrI=.4f4a63c7-84fa-4057-bf41-515592ed1755@github.com>
Message-ID: <hNTjZDljE8SGLc6sUb-FyWBRShNSUT0TeGsIizjHbuU=.0ba70e31-dfb7-49d1-80fe-fa40a0782d88@github.com>

On Tue, 28 Nov 2023 23:14:29 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> I'd like to backport the definition and implementation of com.sun.management.ThreadMXBean.getTotalThreadAllocatedBytes to 8u. The backport CSR is [JDK-8320375](https://bugs.openjdk.org/browse/JDK-8320375). A follow-up bugfix backport of [JDK-8313081](https://bugs.openjdk.org/browse/JDK-8313081) will be done following this backport. The combined backports have been in production at Amazon for two months with no issues. The backport uses the reserved1 slot in jmm.h in order to preserve binary compatibility with 8u. Per current policy, there is no update to JMM_VERSION in jmm.h and the new method is marked
>> 
>> @since 8u412
>> 
>> Aside from file relocation and context differences, relative to the 11u backport the MonitoringSupport_lock definition macro changes, and the reserved1 rather than reserved6 jmm slot is used. SMR doesn't exist in 8u, so jmm_GetTotalThreadAllocated bytes attempts to lock Threads_lock instead, and if the Threads_lock is already locked, the previous return value is returned. HotSpotThreadImpl.java doesn't exist in 8u, so the hunk associated with it is dropped.
>
> Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8304074: whitespace fix

The backport CSR has been approved, but the bot doesn't recognize it as being associated with the 8u backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/392#issuecomment-1843863477

From andrew at openjdk.org  Thu Dec  7 00:14:42 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 7 Dec 2023 00:14:42 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v4]
In-Reply-To: <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
 <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
Message-ID: <jEFTSnzd7OVPmeuHqFY_2f_IFqvL2pRg-D2JgAmer3Q=.6d118adf-7457-46c0-b8c1-c9d05e2b6311@github.com>

On Tue, 5 Dec 2023 17:40:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into jdk-8317373-telia-root2
>  - Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

Confirmed clean.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/397#pullrequestreview-1768876333

From andrew at openjdk.org  Thu Dec  7 00:25:38 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 7 Dec 2023 00:25:38 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese
In-Reply-To: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
Message-ID: <Euo0HwfMo5MraUHKL450AIFajUUJA00dQ_c6-MYjXGU=.09939e20-536f-4d46-99c4-9ffe03bca79e@github.com>

On Wed, 29 Nov 2023 10:55:17 GMT, ktakakuri <duke at openjdk.org> wrote:

> I would like to fix this issue because the test dose not work as intended.
> Could someone please review it?

The tool and its tests are removed in 11u and later by JDK-8074431 so this is only applicable to 8u. The incorrect `\\r` was still in place when removed.

Is this specific to Japanese? It seems like it would fail with any Windows output containing carriage returns. Is it just that the Japanese character set needs conversion from native to ASCII?

The fix itself looks good. The copyright year needs to be bumped and the bug ID added to the `@bug` line. It will probably need to be split onto a new line due to the length; see `jdk/test/java/util/Locale/LocaleTest.java` for an example of this.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-1768885855

From andrew at openjdk.org  Thu Dec  7 00:44:39 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 7 Dec 2023 00:44:39 GMT
Subject: [jdk8u-dev] RFR: 8301310: The SendRawSysexMessage test may cause a
 JVM crash
In-Reply-To: <-YbOn_cUf3QNL2RrekxKnXh8IvdZuTdI-Lz7YXmUYRs=.42795677-64b8-45ca-838c-ae63efa6f56d@github.com>
References: <-YbOn_cUf3QNL2RrekxKnXh8IvdZuTdI-Lz7YXmUYRs=.42795677-64b8-45ca-838c-ae63efa6f56d@github.com>
Message-ID: <vv8Vwv9I6em6MhcKiqfoaTTOoflIwILQC1JTNgwJFyc=.f8d49464-dc5e-4b82-bfab-e2974694196a@github.com>

On Tue, 28 Nov 2023 03:07:08 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov.
> 
> Thanks!

Confirmed clean (sans paths) against the 22u version.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/395#pullrequestreview-1768904309

From andrew at openjdk.org  Thu Dec  7 12:05:45 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 7 Dec 2023 12:05:45 GMT
Subject: [jdk8u-dev] RFR: 8210560: [TEST] convert com/sun/jdi
 redefineClass-related tests
In-Reply-To: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
References: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
Message-ID: <4jmCLIle8U7wPvAeOHMPqteoKVTHnkNlxvyjKh8ytJw=.461367e3-f833-422b-acfc-78dfafeb9e74@github.com>

On Thu, 3 Aug 2023 07:15:41 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.
> 
> Original patch does not apply cleanly to 8u, because:
> 1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib.
> 2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager).
> 
> So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.
> 
> I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.

This seems to include both 8210560 & [8209109](https://bugs.openjdk.org/browse/JDK-8209109).
Can we please do 8209109 separately first? It is difficult to review this when the backport does not align with the version in 11u & trunk. Thanks.
Incidentally, the version of `CompilerUtils.java` that couldn't be compiled has now  been removed by [JDK-8305329](https://bugs.openjdk.org/browse/JDK-8305329)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/350#issuecomment-1845220807

From andrew at openjdk.org  Thu Dec  7 12:12:46 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 7 Dec 2023 12:12:46 GMT
Subject: [jdk8u-dev] RFR: 8317373: Add Telia Root CA v2 [v4]
In-Reply-To: <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
 <Sw6DKinwntoDJiKkVBcZBYNCO7r6zqqTcHoooyj5W3E=.fb84e380-6457-4353-b50b-ca7bd99dfc3c@github.com>
Message-ID: <uQO_DGZ38oMlxIoh5cWHxO6ou5JdSRPhGdwm4rbu3vU=.f15e90be-9558-4960-9dbd-ff7783ead65f@github.com>

On Tue, 5 Dec 2023 17:40:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into jdk-8317373-telia-root2
>  - Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267

Let's try again.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/397#issuecomment-1845230705

From serb at openjdk.org  Fri Dec  8 18:09:26 2023
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 8 Dec 2023 18:09:26 GMT
Subject: [jdk8u-dev] Integrated: 8301310: The SendRawSysexMessage test may
 cause a JVM crash
In-Reply-To: <-YbOn_cUf3QNL2RrekxKnXh8IvdZuTdI-Lz7YXmUYRs=.42795677-64b8-45ca-838c-ae63efa6f56d@github.com>
References: <-YbOn_cUf3QNL2RrekxKnXh8IvdZuTdI-Lz7YXmUYRs=.42795677-64b8-45ca-838c-ae63efa6f56d@github.com>
Message-ID: <N-85PScJf7lh5yhaIoQr-j5gaogiFWl5TrpEgUz6B6Q=.f84a0bc8-aea2-4d27-afe4-5f847b8fc5a9@github.com>

On Tue, 28 Nov 2023 03:07:08 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 3db93fce
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/3db93fcef419c4fe5bcc6fadfb3203a10a9d85f2
Stats:     19 lines in 2 files changed: 13 ins; 0 del; 6 mod

8301310: The SendRawSysexMessage test may cause a JVM crash

Reviewed-by: andrew
Backport-of: d725b73df01ae4478dfaabc47c48cd7231d91afa

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/395

From sgehwolf at openjdk.org  Mon Dec 11 10:44:32 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 10:44:32 GMT
Subject: [jdk8u-dev] Integrated: 8317373: Add Telia Root CA v2
In-Reply-To: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
References: <Wi0adPk3M3WV8aAdEKbmRAwXOAIIfuebk6bmESlzvUU=.59b08baa-26b7-4b91-aac6-44b76017270c@github.com>
Message-ID: <WwHV7a-MshYKYy1GaoQp_Ay4cCV_l7_FO2PflVh9abY=.ddcae5a0-97e0-47e5-a403-805e888cea58@github.com>

On Tue, 28 Nov 2023 16:18:12 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of a mandatory cacert root addition. JDK 11u patch applies clean modulo path changes. Please review.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/sun/security/lib/cacerts` and `jdk/test/security/infra/java/security/cert/CertPathValidator` jtreg tests (including the new one). All pass.

This pull request has now been integrated.

Changeset: fc8c4008
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/fc8c4008c46a41fbd83a5d41de69e8532a4f5b23
Stats:     58 lines in 3 files changed: 55 ins; 0 del; 3 mod

8317373: Add Telia Root CA v2

Reviewed-by: phh, andrew
Backport-of: d3ebb4a155be8ed93e79b6b58c645e861ec30267

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/397

From andrew at openjdk.org  Mon Dec 11 13:23:29 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 11 Dec 2023 13:23:29 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v4]
In-Reply-To: <U87o9KuGUX9qrVIiohMychOtG4tK0Pki726ve94s4_I=.e4b8143f-79c3-489c-9770-edbb6e5dd323@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
 <U87o9KuGUX9qrVIiohMychOtG4tK0Pki726ve94s4_I=.e4b8143f-79c3-489c-9770-edbb6e5dd323@github.com>
Message-ID: <AOPw_K1sV4PayMvByqoRNSMr9HAxAlWs1MJdbrcB-rY=.c7b87227-2ae5-4bf3-81af-931b6dc7b326@github.com>

On Wed, 6 Dec 2023 14:39:56 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

Waiting for rebase now that #397 is integrated

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/398#issuecomment-1850067365

From sgehwolf at openjdk.org  Mon Dec 11 13:38:32 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 13:38:32 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v5]
In-Reply-To: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
Message-ID: <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>

> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/398/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=398&range=04
  Stats: 39 lines in 3 files changed: 35 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/398.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/398/head:pull/398

PR: https://git.openjdk.org/jdk8u-dev/pull/398

From sgehwolf at openjdk.org  Mon Dec 11 13:38:34 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 13:38:34 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v4]
In-Reply-To: <AOPw_K1sV4PayMvByqoRNSMr9HAxAlWs1MJdbrcB-rY=.c7b87227-2ae5-4bf3-81af-931b6dc7b326@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
 <U87o9KuGUX9qrVIiohMychOtG4tK0Pki726ve94s4_I=.e4b8143f-79c3-489c-9770-edbb6e5dd323@github.com>
 <AOPw_K1sV4PayMvByqoRNSMr9HAxAlWs1MJdbrcB-rY=.c7b87227-2ae5-4bf3-81af-931b6dc7b326@github.com>
Message-ID: <PUMwuyz33vSvot-mlD_RJmuqbLvprJBCJWdelYu8x-s=.35c794e7-2f8c-4375-b2ae-b7e0cac07bc8@github.com>

On Mon, 11 Dec 2023 13:20:30 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Waiting for rebase now that #397 is integrated

Done.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/398#issuecomment-1850087320

From sgehwolf at openjdk.org  Mon Dec 11 13:43:48 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 13:43:48 GMT
Subject: [jdk8u-dev] RFR: 8318759: Add four DigiCert root certificates [v3]
In-Reply-To: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
References: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
Message-ID: <TdB8_Ne-Yg59BXeDKYFoOMxSbx3YRSSYcqfcgOtJjR8=.f02a6bfd-cb00-45d7-a2ce-cc8f2443b867@github.com>

> Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
> 
> Testing:
> - [x] GHA
> - [x] jdk/test/security/infra/java/security/cert/CertPathValidator and jdk/test/sun/security/lib/cacerts jtreg tests. Including new ones. All 43 tests pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport 0ea58048f9b4cdaaa0470b2bcc03913fb3939453

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/399/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=399&range=02
  Stats: 459 lines in 7 files changed: 456 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/399.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/399/head:pull/399

PR: https://git.openjdk.org/jdk8u-dev/pull/399

From andrew at openjdk.org  Mon Dec 11 14:32:23 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 11 Dec 2023 14:32:23 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v5]
In-Reply-To: <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
 <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>
Message-ID: <LWiV3Ks1zo0bw7FAdMqdv3LyQhKSF9PAFWGmsKJbUaY=.c8a7e54a-a7db-4e23-af5b-a44ceb10cbce@github.com>

On Mon, 11 Dec 2023 13:38:32 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

Thanks. Patch looks clean (sans paths) and tests pass.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/398#pullrequestreview-1775267869

From sgehwolf at openjdk.org  Mon Dec 11 14:32:24 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 14:32:24 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v5]
In-Reply-To: <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
 <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>
Message-ID: <JC9ki_GP-n-GLfiCH1Rq6md7NRWkKurxGmxY8rUw5-E=.fbba40ec-3364-4794-a101-b445c7047bab@github.com>

On Mon, 11 Dec 2023 13:38:32 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

Linux x64 test failure of `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#usertrusteccca` seems infra flakiness. We have seen it fail a couple of times now:


Caused by: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: OCSP response error: INTERNAL_ERROR

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/398#issuecomment-1850193648

From andrew at openjdk.org  Mon Dec 11 14:39:28 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 11 Dec 2023 14:39:28 GMT
Subject: [jdk8u-dev] RFR: 8317374: Add Let's Encrypt ISRG Root X2 [v5]
In-Reply-To: <JC9ki_GP-n-GLfiCH1Rq6md7NRWkKurxGmxY8rUw5-E=.fbba40ec-3364-4794-a101-b445c7047bab@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
 <pgnSvfMn_WYIWGMHezT1yeb42CNWXz1BJkS-hqnJ9L0=.4e7b9ba4-0de8-4e0c-a95a-e92428e60399@github.com>
 <JC9ki_GP-n-GLfiCH1Rq6md7NRWkKurxGmxY8rUw5-E=.fbba40ec-3364-4794-a101-b445c7047bab@github.com>
Message-ID: <iqU8ca7dfsczBFQpP8O-TxU4_PIuvhXfTEUCPxCTbt8=.f780b498-23d3-49de-bada-3ec987331d2d@github.com>

On Mon, 11 Dec 2023 14:29:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Linux x64 test failure of `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#usertrusteccca` seems infra flakiness. We have seen it fail a couple of times now:
> 
> ```
> Caused by: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: OCSP response error: INTERNAL_ERROR
> ```

Thanks, I hadn't seen that one yet. I don't think it's a blocker for this, as it's not one of the certificates being added.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/398#issuecomment-1850207223

From sgehwolf at openjdk.org  Mon Dec 11 15:46:28 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 15:46:28 GMT
Subject: [jdk8u-dev] Integrated: 8317374: Add Let's Encrypt ISRG Root X2
In-Reply-To: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
References: <kau-cU20LXmaLtZb28aQw90jUxI074y9Wts9VI1OQKI=.db5f8805-7fab-4817-8389-30888301e2c4@github.com>
Message-ID: <CKBVLCCPrQ_Op7WHh0-BQDUBzVFD6IZNa3-Wt6b_8hg=.508750ca-f6ce-42ff-9716-db79b6b542b7@github.com>

On Tue, 28 Nov 2023 18:50:55 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport so as to add the Let's Encrypt ISRG Root X2 CA. Applies clean after path shuffeling. Please review!
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests.

This pull request has now been integrated.

Changeset: 4d1c3a6c
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4d1c3a6c39a8630968e83cfd2b71dc0c3c938eaf
Stats:     39 lines in 3 files changed: 35 ins; 0 del; 4 mod

8317374: Add Let's Encrypt ISRG Root X2

Reviewed-by: phh, andrew
Backport-of: e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/398

From sgehwolf at openjdk.org  Mon Dec 11 16:16:16 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 16:16:16 GMT
Subject: [jdk8u-dev] RFR: 8318759: Add four DigiCert root certificates [v4]
In-Reply-To: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
References: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
Message-ID: <cgS4T5bNxcFHwqS7ceIJrXWpJfoc43pN9SQ2eftDXxM=.f06d81b2-a389-498f-841e-eb47e343038e@github.com>

> Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
> 
> Testing:
> - [x] GHA
> - [x] jdk/test/security/infra/java/security/cert/CertPathValidator and jdk/test/sun/security/lib/cacerts jtreg tests. Including new ones. All 43 tests pass.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport 0ea58048f9b4cdaaa0470b2bcc03913fb3939453

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/399/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=399&range=03
  Stats: 459 lines in 7 files changed: 456 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/399.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/399/head:pull/399

PR: https://git.openjdk.org/jdk8u-dev/pull/399

From sgehwolf at openjdk.org  Mon Dec 11 18:22:51 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 18:22:51 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots
Message-ID: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>

Clean backport of the JDK 11u patch of 
some more `cacert` additions (modulo path adjustments). Please review!

Testing:
- GHA (still running). Includes `cacerts` testing these days.
- cacerts tests locally on Linux x86_64. All pass (including the new tests).

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/399

Commit messages:
 - Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

Changes: https://git.openjdk.org/jdk8u-dev/pull/401/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=401&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8319187
  Stats: 305 lines in 6 files changed: 302 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/401.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/401/head:pull/401

PR: https://git.openjdk.org/jdk8u-dev/pull/401

From andrew at openjdk.org  Mon Dec 11 18:37:31 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 11 Dec 2023 18:37:31 GMT
Subject: [jdk8u-dev] RFR: 8318759: Add four DigiCert root certificates [v4]
In-Reply-To: <cgS4T5bNxcFHwqS7ceIJrXWpJfoc43pN9SQ2eftDXxM=.f06d81b2-a389-498f-841e-eb47e343038e@github.com>
References: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
 <cgS4T5bNxcFHwqS7ceIJrXWpJfoc43pN9SQ2eftDXxM=.f06d81b2-a389-498f-841e-eb47e343038e@github.com>
Message-ID: <T60pPsIbzp0ojKVCGyXhM7Ts6sdI2pcVetvohbcUwwE=.ff30fd25-02fa-413e-880e-912475d6a7ef@github.com>

On Mon, 11 Dec 2023 16:16:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
>> 
>> Testing:
>> - [x] GHA
>> - [x] jdk/test/security/infra/java/security/cert/CertPathValidator and jdk/test/sun/security/lib/cacerts jtreg tests. Including new ones. All 43 tests pass.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 0ea58048f9b4cdaaa0470b2bcc03913fb3939453

Patch looks clean (sans paths). New tests pass.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/399#pullrequestreview-1775902695

From sgehwolf at openjdk.org  Mon Dec 11 19:26:37 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 19:26:37 GMT
Subject: [jdk8u-dev] Integrated: 8318759: Add four DigiCert root certificates
In-Reply-To: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
References: <PQdUPh9-t5YnrqdrrzMmD0Fio4Dqz-2pGvZO-EvvnEM=.bdc4f223-add2-4588-81bd-a61f8b0a8ce7@github.com>
Message-ID: <QcAVqW7bqHdmuPnNj9XX7bo5glHs4SQgfj4NJCxnX-c=.655ad796-3e2a-42f3-94cb-42d34be1280c@github.com>

On Tue, 28 Nov 2023 19:12:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
> 
> Testing:
> - [x] GHA
> - [x] jdk/test/security/infra/java/security/cert/CertPathValidator and jdk/test/sun/security/lib/cacerts jtreg tests. Including new ones. All 43 tests pass.

This pull request has now been integrated.

Changeset: 7098ac7b
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7098ac7ba63ab08d96605caf25173848111fd0db
Stats:     459 lines in 7 files changed: 456 ins; 0 del; 3 mod

8318759: Add four DigiCert root certificates

Reviewed-by: phh, andrew
Backport-of: 0ea58048f9b4cdaaa0470b2bcc03913fb3939453

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/399

From sgehwolf at openjdk.org  Mon Dec 11 19:29:00 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Dec 2023 19:29:00 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v2]
In-Reply-To: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
Message-ID: <wzICIgypfMIj5AmWBFmsjPRHYk8Z-YR26PZfI0dN3lk=.d4177596-8ea3-4b00-b4e7-736964f45af8@github.com>

> Clean backport of the JDK 11u patch of 
> some more `cacert` additions (modulo path adjustments). Please review!
> 
> Testing:
> - GHA (still running). Includes `cacerts` testing these days.
> - cacerts tests locally on Linux x86_64. All pass (including the new tests).

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/401/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/401/files/57bc091c..57bc091c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=401&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=401&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/401.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/401/head:pull/401

PR: https://git.openjdk.org/jdk8u-dev/pull/401

From dhanalla at openjdk.org  Tue Dec 12 00:14:43 2023
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Tue, 12 Dec 2023 00:14:43 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing
 Connections
Message-ID: <ePVS-zJOUid-JXuU4qG_Ccg1dOJKmWQWukLHlEuip5M=.4c283d51-4014-47e0-933b-fdd922c0bc81@github.com>

Issue:  [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections

Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890  fromJDK11 to JDK8.

-------------

Commit messages:
 - Backport 770c1f65c588f3156f9b70097df752d8059c1038

Changes: https://git.openjdk.org/jdk8u-dev/pull/402/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=402&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293562
  Stats: 401 lines in 3 files changed: 302 ins; 36 del; 63 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/402.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/402/head:pull/402

PR: https://git.openjdk.org/jdk8u-dev/pull/402

From dhanalla at microsoft.com  Tue Dec 12 00:25:40 2023
From: dhanalla at microsoft.com (Dhamoder Nalla)
Date: Tue, 12 Dec 2023 00:25:40 +0000
Subject: [EXTERNAL] Re: Backport of JDK-8293562 to JDK8
In-Reply-To: <ZWZL6OrifUkZ7po/@hex.discworld.ac.uk>
References: <DS7PR21MB347959BF949FD7242C27326EC2BAA@DS7PR21MB3479.namprd21.prod.outlook.com>
 <DS7PR21MB347927F921D347C3459A1E2CC2BDA@DS7PR21MB3479.namprd21.prod.outlook.com>
 <ZWZL6OrifUkZ7po/@hex.discworld.ac.uk>
Message-ID: <DS7PR21MB34791BDD0228B57DC9953C24C28EA@DS7PR21MB3479.namprd21.prod.outlook.com>

Thanks @Andrew Hughes,  
Here is the backport PR https://github.com/openjdk/jdk8u-dev/pull/402

Thanks,
Dhamoder.
-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com> 
Sent: Tuesday, November 28, 2023 2:22 PM
To: Dhamoder Nalla <dhanalla at microsoft.com>
Cc: jdk8u-dev at openjdk.org
Subject: [EXTERNAL] Re: Backport of JDK-8293562 to JDK8

On 16:47 Mon 27 Nov     , Dhamoder Nalla wrote:
> Hi All,
> 
> I'm a member of the Java Engineering Group at Microsoft, currently working on a TLS 1.3 issue for one of our customers using JDK8. This issue aligns with JDK-8293562<https://bugs.openjdk.org/browse/JDK-8293562>.
> This customer is currently not able to upgrade their JDK version, so I'm interested in understanding if there are any concerns about backporting this bug (JDK-8293562<https://bugs.openjdk.org/browse/JDK-8293562>) fix to JDK8 (or if this is already in progress by someone).
> 
> Thanks,
> Dhamoder.
> 
> 

It's difficult to give a definitive answer without seeing what the backport would actually look like, how it may need to be modified for 8u and if any other backports are needed as well.

What I would say is that the TLS 1.3 support in 8u was recently backported from 11u, so it is already code that is newer than most of 8u and similar to what it is in 11u. Given we already made a backport of such a significant enhancement, I would say that bug fixes for it have a lower bar than other changes elsewhere in the 8u code base.
The change also has a test case which is always a plus.

I'm not aware of any work on 8u already, though this ticket saw a lot of interest when backporting to 11u with two competing PRs.  I would say do the backport and propose a PR, but be aware that the end result of that process could be that we decide not to go ahead, as some changes are deemed too risky to 8u stability.

Hope that helps,
--
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew

From sgehwolf at openjdk.org  Tue Dec 12 09:25:50 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 12 Dec 2023 09:25:50 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v3]
In-Reply-To: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
Message-ID: <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>

> Clean backport of the JDK 11u patch of 
> some more `cacert` additions (modulo path adjustments). Please review!
> 
> Testing:
> - GHA (still running). Includes `cacerts` testing these days.
> - cacerts tests locally on Linux x86_64. All pass (including the new tests).

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/401/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=401&range=02
  Stats: 305 lines in 6 files changed: 302 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/401.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/401/head:pull/401

PR: https://git.openjdk.org/jdk8u-dev/pull/401

From andrew at openjdk.org  Wed Dec 13 00:55:44 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 13 Dec 2023 00:55:44 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v3]
In-Reply-To: <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
 <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
Message-ID: <PwIQr26g-Qab7MPq_leoGhJ1CZsaSsAKbp4lCSRBO1I=.4d220d36-e2aa-412f-9d12-f58c1e938c61@github.com>

On Tue, 12 Dec 2023 09:25:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport of the JDK 11u patch of 
>> some more `cacert` additions (modulo path adjustments). Please review!
>> 
>> Testing:
>> - GHA (still running). Includes `cacerts` testing these days.
>> - cacerts tests locally on Linux x86_64. All pass (including the new tests).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

I see some contextual differences:
~~~
-@@ -586,6 +606,13 @@ public class CAInterop {
-                     return new CATestURLs("https://validpremiumecc.affirmtrust.com",
-                             "https://revokedpremiumecc.affirmtrust.com");
+@@ -532,6 +552,13 @@ private CATestURLs getTestURLs(String alias) {
+                     return new CATestURLs("https://juolukka.cover.telia.fi:10600",
+                             "https://juolukka.cover.telia.fi:10601");
~~~
It seems [JDK-8268916](https://bugs.openjdk.org/browse/JDK-8268916) should go in first and make this a cleaner backport.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/401#pullrequestreview-1778661529

From sgehwolf at openjdk.org  Wed Dec 13 12:48:50 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 13 Dec 2023 12:48:50 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v3]
In-Reply-To: <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
 <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
Message-ID: <WcrZj2FW1rTCmLMz7BAkEQC0-2f8F82oP9aKRmcE1wQ=.6eaf946d-6987-454f-82a4-19989d7b68ce@github.com>

On Tue, 12 Dec 2023 09:25:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport of the JDK 11u patch of 
>> some more `cacert` additions (modulo path adjustments). Please review!
>> 
>> Testing:
>> - GHA (still running). Includes `cacerts` testing these days.
>> - cacerts tests locally on Linux x86_64. All pass (including the new tests).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

OK, I'll work on a backport of [JDK-8268916](https://bugs.openjdk.org/browse/JDK-8268916), but it doesn't need to go in the same order as JDK 11. It's just context difference. How about we get this one in first and I'll follow up with the test addition in parallel? Seems counter-intuitive to require JDK-8268916 first. It's a test change only and unrelated to this patch.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/401#issuecomment-1853854684

From andrew at openjdk.org  Wed Dec 13 13:03:51 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 13 Dec 2023 13:03:51 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v3]
In-Reply-To: <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
 <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
Message-ID: <V2rHZLkxa17LAPTDLH39j1zGMyHVsl9q-O9E32Tuhbc=.37004951-a38f-497b-9089-9c3105711d32@github.com>

On Tue, 12 Dec 2023 09:25:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport of the JDK 11u patch of 
>> some more `cacert` additions (modulo path adjustments). Please review!
>> 
>> Testing:
>> - GHA (still running). Includes `cacerts` testing these days.
>> - cacerts tests locally on Linux x86_64. All pass (including the new tests).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

Alright, I'm ok with that as long as the files are the same once both patches are applied.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/401#pullrequestreview-1779589257

From sgehwolf at openjdk.org  Wed Dec 13 13:22:53 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 13 Dec 2023 13:22:53 GMT
Subject: [jdk8u-dev] RFR: 8319187: Add three eMudhra emSign roots [v3]
In-Reply-To: <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
 <S7gpg-jLGC8ja50O24PlDD46pDGP_BatmvfiaEopekw=.1b1068b3-28bc-4971-8174-9f41882176e2@github.com>
Message-ID: <0_Gc7kYwnSAZn0PdG_P5jcDjvO4t-BTEA_J7zKXjnoo=.9c313110-f84b-4267-aded-bc9add930c76@github.com>

On Tue, 12 Dec 2023 09:25:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport of the JDK 11u patch of 
>> some more `cacert` additions (modulo path adjustments). Please review!
>> 
>> Testing:
>> - GHA (still running). Includes `cacerts` testing these days.
>> - cacerts tests locally on Linux x86_64. All pass (including the new tests).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

Thanks. Asked for approval.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/401#issuecomment-1853906254

From sgehwolf at openjdk.org  Wed Dec 13 15:01:57 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 13 Dec 2023 15:01:57 GMT
Subject: [jdk8u-dev] Integrated: 8319187: Add three eMudhra emSign roots
In-Reply-To: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
References: <mnUXfZ8wIxy7Eggts9o3nbZyThb0rvPrsUfjJ3BVhpA=.7a91aa62-f027-4028-92db-f10c86edaba3@github.com>
Message-ID: <GUsrxnDAItux0tDzbeAOalfkwmGP0G6YaHF9nOI1Dq0=.f7d2af2f-ebdf-4062-a6c7-67ea20b76b40@github.com>

On Mon, 11 Dec 2023 18:17:08 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport of the JDK 11u patch of 
> some more `cacert` additions (modulo path adjustments). Please review!
> 
> Testing:
> - GHA (still running). Includes `cacerts` testing these days.
> - cacerts tests locally on Linux x86_64. All pass (including the new tests).

This pull request has now been integrated.

Changeset: 31162fb2
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/31162fb2760d01e1fd4a84bcb796400d95c82506
Stats:     305 lines in 6 files changed: 302 ins; 0 del; 3 mod

8319187: Add three eMudhra emSign roots

Reviewed-by: andrew
Backport-of: 0bda467f6e29c866c661e88a76a9fe3efc0a0d19

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/401

From jkratochvil at azul.com  Wed Dec 13 16:03:05 2023
From: jkratochvil at azul.com (Jan Kratochvil (Azul))
Date: Thu, 14 Dec 2023 00:03:05 +0800
Subject: Backporting stack guard fixes from JDK-9 (8169373+8159335+8139864)
In-Reply-To: <CAA-vtUy6ParNLuGf=jLX8MjL+rQH==LgLOAjLC-uWvNmJaq6eQ@mail.gmail.com>
References: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>
 <CAA-vtUy6ParNLuGf=jLX8MjL+rQH==LgLOAjLC-uWvNmJaq6eQ@mail.gmail.com>
Message-ID: <ZXnVud0q5CubypGp@host1.jankratochvil.net>

Hi Thomas,

On Thu, 07 Dec 2023 00:22:34 +0800, Thomas St?fe wrote:
> are you sure this crash is related to JDK-8169373?

No.


> As far as I remember that bug resulted in threads possibly failing to start
> because the thread stack size specified was too small;
> I don't see how it can cause crashes like the one you describe. Once the
> thread had been started successfully, things should work, no?

The thread crashes still very early - in its glibc startup. As its TLS address
(which is in the top last page of its stack) is unmapped. I expect another
thread could accidentally unmap the pages due to some discrepancy of stack
boundaries calculations between glibc and JVM. JVM was fixing some that stuff
in:
	JDK-8169373: Work around linux NPTL stack guard error

hotspot/src/os/linux/vm/os_linux.cpp:
bool os::pd_create_stack_guard_pages(char* addr, size_t size) {
  if (os::is_primordial_thread()) {
...
    if (stack_extent < (uintptr_t)addr) {
      ::munmap((void*)stack_extent, (uintptr_t)(addr - stack_extent));


Thanks for hints,
Jan

From abakhtin at openjdk.org  Thu Dec 14 03:00:05 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 14 Dec 2023 03:00:05 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it will
 be thrown
Message-ID: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>

Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

-------------

Commit messages:
 - Fix switch statement
 - Backport 334b977259930368160db705c1f2feda0b0e8707

Changes: https://git.openjdk.org/jdk8u-dev/pull/403/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=403&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8302017
  Stats: 155 lines in 5 files changed: 92 ins; 17 del; 46 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/403.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/403/head:pull/403

PR: https://git.openjdk.org/jdk8u-dev/pull/403

From abakhtin at openjdk.org  Thu Dec 14 03:26:05 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 14 Dec 2023 03:26:05 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on signed
 data that does not encode params correctly
Message-ID: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>

Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
the only differences in the removed decodeSignature() method

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/403

Commit messages:
 - Backport 11e4a925bec3c1f79e03045d48def53188b655e6

Changes: https://git.openjdk.org/jdk8u-dev/pull/404/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=404&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320597
  Stats: 85 lines in 2 files changed: 66 ins; 8 del; 11 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/404.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/404/head:pull/404

PR: https://git.openjdk.org/jdk8u-dev/pull/404

From mbalao at openjdk.org  Thu Dec 14 07:19:44 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 14 Dec 2023 07:19:44 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown
In-Reply-To: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
Message-ID: <hZTAMmTYXRQxFjLgFtDYrgL5kPx2JF2WBmHTxE07qsI=.17609ac6-417a-4793-bdb0-04b2fe14f17d@github.com>

On Thu, 14 Dec 2023 02:53:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

Hi @alexeybakhtin 

Thanks for proposing this backport.

Two minor comments:

1) The copyright date change in RSAPadding.java is not necessary (I made this comment for 17u and 11u too).

2) Would you mind adding the comment "// https://www.rfc-editor.org..." (and the line before) inside the try block as in 17u and 11u?

Thanks,
Martin.-

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/403#pullrequestreview-1781102180

From andrew at openjdk.org  Thu Dec 14 10:43:48 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 14 Dec 2023 10:43:48 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections
In-Reply-To: <ePVS-zJOUid-JXuU4qG_Ccg1dOJKmWQWukLHlEuip5M=.4c283d51-4014-47e0-933b-fdd922c0bc81@github.com>
References: <ePVS-zJOUid-JXuU4qG_Ccg1dOJKmWQWukLHlEuip5M=.4c283d51-4014-47e0-933b-fdd922c0bc81@github.com>
Message-ID: <uJAk0AxMoaA_oPSjX9tWsWAcj6NT2CbJBFXe-jVnBvg=.aa889fed-b72d-47bb-9ee7-b99d248a827c@github.com>

On Tue, 12 Dec 2023 00:09:06 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Issue:  [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890  fromJDK11 to JDK8.
> 
> The JDK11 patch doesn't apply cleanly due to file path/structure changes and the transformation of the ClientVector class to ArrayDeque from a Stack, resulting in changes being picked individually.
> 
> Test performed:
>    1. JTreg jdk_tier1
>    2. JTreg jdk_tier2
>    3. New test case added to this PR passed with the fix and failed without it.

It's difficult to review this accurately because it now contains both 8293562 and most of [JDK-8155590](https://bugs.openjdk.org/browse/JDK-8155590) for the `ArrayDeque` change.

I'd be more comfortable with this if we backported 8155590 separately and then rebased this change on top of that. Although this looks correct when I apply it and compare it to the 11u version, we end up with minor differences remaining that may then cause issues for any later changes. With looking at each patch separately, it makes it possible to compare it with the 11u version of the patch and spot any differences.

I had a quick look at 8155590 myself and it largely applies, with just a few hunks needing to be done manually (which I suspect you already had to do for this patch).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/402#pullrequestreview-1781531832

From duke at openjdk.org  Thu Dec 14 11:08:53 2023
From: duke at openjdk.org (ktakakuri)
Date: Thu, 14 Dec 2023 11:08:53 GMT
Subject: [jdk8u-dev] RFR: 8059847: complement JDK-8055286 and JDK-8056964
 changes
In-Reply-To: <F047NIj7JkXULddXn5NcuUYMo-tufGtIjp2YdC_QM9Y=.207a0ff8-3d24-49f2-a80a-262f2343bf3e@github.com>
References: <F047NIj7JkXULddXn5NcuUYMo-tufGtIjp2YdC_QM9Y=.207a0ff8-3d24-49f2-a80a-262f2343bf3e@github.com>
Message-ID: <xqIBXHzWSkWWU1TWxizgawDURTxL2SyDsf0nwMAkxnU=.effcb373-6698-40e8-9fb8-16b2556d0e18@github.com>

On Tue, 28 Nov 2023 12:33:12 GMT, ktakakuri <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8059847: complement JDK-8055286 and JDK-8056964 changes
> 
> JDK-8055286 and JDK-8056964 are already backported to JDK8, but this patch is not. For this reason, CompileCommand=option does not support flags of type double, as reported. So this patch should be applied.
> 
> The original patch is applied cleanly.
> 
> Testing: hotspot_tier1 including the test which come with this patch.
> 
> Thank you.

Thank you for your comment.
When submitting this PR, I thought that the -XX:CompileCommand=option could handle all available flag types except double and that this follow-up enhancement should be backported for completeness.
However the uint64_t type is used as a flag type but is not handled by CompileCommand.
Now that I know this, I don't think there's much need to backport this fix, so I close this request.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/396#issuecomment-1855643452

From duke at openjdk.org  Thu Dec 14 11:08:54 2023
From: duke at openjdk.org (ktakakuri)
Date: Thu, 14 Dec 2023 11:08:54 GMT
Subject: [jdk8u-dev] Withdrawn: 8059847: complement JDK-8055286 and JDK-8056964
 changes
In-Reply-To: <F047NIj7JkXULddXn5NcuUYMo-tufGtIjp2YdC_QM9Y=.207a0ff8-3d24-49f2-a80a-262f2343bf3e@github.com>
References: <F047NIj7JkXULddXn5NcuUYMo-tufGtIjp2YdC_QM9Y=.207a0ff8-3d24-49f2-a80a-262f2343bf3e@github.com>
Message-ID: <Lpv3gccmuBPGyu0cxtogvedqa0L-jxkZDU0Lcb2zoFo=.8d3d8f07-9cf5-45be-8831-b84654a9a6c1@github.com>

On Tue, 28 Nov 2023 12:33:12 GMT, ktakakuri <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8059847: complement JDK-8055286 and JDK-8056964 changes
> 
> JDK-8055286 and JDK-8056964 are already backported to JDK8, but this patch is not. For this reason, CompileCommand=option does not support flags of type double, as reported. So this patch should be applied.
> 
> The original patch is applied cleanly.
> 
> Testing: hotspot_tier1 including the test which come with this patch.
> 
> Thank you.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/396

From duke at openjdk.org  Thu Dec 14 12:20:55 2023
From: duke at openjdk.org (ktakakuri)
Date: Thu, 14 Dec 2023 12:20:55 GMT
Subject: [jdk8u-dev] RFR: 8159454: [TEST_BUG]
 javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics
 configurations should be limited
Message-ID: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>

Hi all,

This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
I have confirmed that bug7123767.java passes by backporting this fix.

Thank you.

-------------

Commit messages:
 - Backport 64a2db9060bc9fc81afe451d0b057af57fc10f94
 - Backport 64a2db9060bc9fc81afe451d0b057af57fc10f94

Changes: https://git.openjdk.org/jdk8u-dev/pull/405/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=405&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8159454
  Stats: 138 lines in 1 file changed: 82 ins; 23 del; 33 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/405/head:pull/405

PR: https://git.openjdk.org/jdk8u-dev/pull/405

From abakhtin at openjdk.org  Thu Dec 14 14:34:22 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 14 Dec 2023 14:34:22 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
Message-ID: <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  Fixed copyright date and engineVerify formating

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/403/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/403/files/66deb0df..2110d9f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=403&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=403&range=00-01

  Stats: 8 lines in 2 files changed: 0 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/403.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/403/head:pull/403

PR: https://git.openjdk.org/jdk8u-dev/pull/403

From abakhtin at openjdk.org  Thu Dec 14 14:34:22 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 14 Dec 2023 14:34:22 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <hZTAMmTYXRQxFjLgFtDYrgL5kPx2JF2WBmHTxE07qsI=.17609ac6-417a-4793-bdb0-04b2fe14f17d@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
 <hZTAMmTYXRQxFjLgFtDYrgL5kPx2JF2WBmHTxE07qsI=.17609ac6-417a-4793-bdb0-04b2fe14f17d@github.com>
Message-ID: <AJnM0LbhnsWCo-fUpT9POqJ4FP6DpmlItxx97MN4_H0=.a4243781-ccb1-43de-ba20-5e1feb512b60@github.com>

On Thu, 14 Dec 2023 07:16:45 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi @alexeybakhtin
> 
> Thanks for proposing this backport.
> 
> Two minor comments:
> 
> 1. The copyright date change in RSAPadding.java is not necessary (I made this comment for 17u and 11u too).
> 2. Would you mind adding the comment "// https://www.rfc-editor.org..." (and the line before) inside the try block as in 17u and 11u?
> 
> Thanks, Martin.-

Thank you @martinuy !
Both comments are fixed now

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/403#issuecomment-1855957007

From abakhtin at openjdk.org  Thu Dec 14 17:26:50 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 14 Dec 2023 17:26:50 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
 <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
Message-ID: <fk3gClMeUZRX112DH6K-lvOKRdEFz8TlMjKW8leZiqM=.215993a4-d813-4a16-8a33-5de367b764ca@github.com>

On Thu, 14 Dec 2023 14:34:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
>> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed copyright date and engineVerify formating

Pre-submit test failures are not related to the current changes

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/403#issuecomment-1856266563

From sgehwolf at openjdk.org  Thu Dec 14 19:25:16 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 14 Dec 2023 19:25:16 GMT
Subject: [jdk8u-dev] RFR: 8268916: Tests for AffirmTrust roots
Message-ID: <e74YO9xz654J21H76Z19tQmVxVSIef-AQtkrUFOG0cc=.a0ace7f4-6354-4805-9d3d-b5929de59ff2@github.com>

Clean backport modulo context differences (after path suffeling). After this, `CAInterop.java` is the same as in openjdk/jdk11u. Patch as requested in #401 

Testing:
 - [ ] GHA (still running, includes new tests).

-------------

Commit messages:
 - Backport 8c1bb2b28066ee32bef22110df06318d938c7d8b

Changes: https://git.openjdk.org/jdk8u-dev/pull/406/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=406&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8268916
  Stats: 54 lines in 1 file changed: 54 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/406.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/406/head:pull/406

PR: https://git.openjdk.org/jdk8u-dev/pull/406

From phh at openjdk.org  Thu Dec 14 20:33:46 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 14 Dec 2023 20:33:46 GMT
Subject: [jdk8u-dev] RFR: 8268916: Tests for AffirmTrust roots
In-Reply-To: <e74YO9xz654J21H76Z19tQmVxVSIef-AQtkrUFOG0cc=.a0ace7f4-6354-4805-9d3d-b5929de59ff2@github.com>
References: <e74YO9xz654J21H76Z19tQmVxVSIef-AQtkrUFOG0cc=.a0ace7f4-6354-4805-9d3d-b5929de59ff2@github.com>
Message-ID: <rRgCmC_9WtNW3c0S_PHsWNQdg7nLqwtPjHGOklPagVs=.5d95a6be-c7ed-4b00-8c7a-1bdfcf707719@github.com>

On Thu, 14 Dec 2023 19:18:32 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport modulo context differences (after path suffeling). After this, `CAInterop.java` is the same as in openjdk/jdk11u. Patch as requested in #401 
> 
> Testing:
>  - [ ] GHA (still running, includes new tests).

Marked as reviewed by phh (Reviewer).

linux-x86 GHA failure is unrelated.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/406#pullrequestreview-1782667906
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/406#issuecomment-1856538541

From mbalao at openjdk.org  Fri Dec 15 05:38:47 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Dec 2023 05:38:47 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
 <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
Message-ID: <920PEdvPfhAwggyZ3B2znmqRguvQzr23YSJj9u8xZuM=.4ef76b52-4f74-4f0f-b505-7d794920ec9a@github.com>

On Thu, 14 Dec 2023 14:34:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
>> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed copyright date and engineVerify formating

Thanks for proposing this backport.

I meant adding the "// https://www.rfc..." comment only to the try block, not the previous "if". In 8u we don't have 8149802 that adds a try-finally block to call resetDigest, so there isn't a reason for it. Should cause no harm, but I'd keep it as in your 1st proposal. Sorry for the confusion. Anyways, this is a minor detail, looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/403#pullrequestreview-1783150583

From thomas.stuefe at gmail.com  Fri Dec 15 07:45:41 2023
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Fri, 15 Dec 2023 08:45:41 +0100
Subject: Backporting stack guard fixes from JDK-9 (8169373+8159335+8139864)
In-Reply-To: <ZXnVud0q5CubypGp@host1.jankratochvil.net>
References: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>
 <CAA-vtUy6ParNLuGf=jLX8MjL+rQH==LgLOAjLC-uWvNmJaq6eQ@mail.gmail.com>
 <ZXnVud0q5CubypGp@host1.jankratochvil.net>
Message-ID: <CAA-vtUy3Mfz+E_LFSwO5SK2kxFvZvh-5R8WcB0vw0C-6xONnDA@mail.gmail.com>

On Wed, Dec 13, 2023 at 5:03?PM Jan Kratochvil (Azul) <jkratochvil at azul.com>
wrote:

> Hi Thomas,
>
> On Thu, 07 Dec 2023 00:22:34 +0800, Thomas St?fe wrote:
> > are you sure this crash is related to JDK-8169373?
>
> No.
>
>
> > As far as I remember that bug resulted in threads possibly failing to
> start
> > because the thread stack size specified was too small;
> > I don't see how it can cause crashes like the one you describe. Once the
> > thread had been started successfully, things should work, no?
>
> The thread crashes still very early - in its glibc startup. As its TLS
> address
> (which is in the top last page of its stack) is unmapped. I expect another
> thread could accidentally unmap the pages due to some discrepancy of stack
> boundaries calculations between glibc and JVM. JVM was fixing some that
> stuff
> in:
>         JDK-8169373: Work around linux NPTL stack guard error
>
> hotspot/src/os/linux/vm/os_linux.cpp:
> bool os::pd_create_stack_guard_pages(char* addr, size_t size) {
>   if (os::is_primordial_thread()) {
> ...
>     if (stack_extent < (uintptr_t)addr) {
>       ::munmap((void*)stack_extent, (uintptr_t)(addr - stack_extent));
>
>
>
This coding only gets executed for the primordial thread, and the only way
that could happen is if the hotspot had been embedded into a custom
launcher. Is this the case here?

The normal java launcher invokes the JVM on a newly spawned pthread, so
is_primordial_thread will always be false.

..Thomas

Thanks for hints,
> Jan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20231215/cfd1c28b/attachment-0001.htm>

From sgehwolf at openjdk.org  Fri Dec 15 10:21:51 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 15 Dec 2023 10:21:51 GMT
Subject: [jdk8u-dev] RFR: 8268916: Tests for AffirmTrust roots
In-Reply-To: <rRgCmC_9WtNW3c0S_PHsWNQdg7nLqwtPjHGOklPagVs=.5d95a6be-c7ed-4b00-8c7a-1bdfcf707719@github.com>
References: <e74YO9xz654J21H76Z19tQmVxVSIef-AQtkrUFOG0cc=.a0ace7f4-6354-4805-9d3d-b5929de59ff2@github.com>
 <rRgCmC_9WtNW3c0S_PHsWNQdg7nLqwtPjHGOklPagVs=.5d95a6be-c7ed-4b00-8c7a-1bdfcf707719@github.com>
Message-ID: <B2xkwq7R-gzWXwtcQxPhFlnKPghpTTXDRa3ecvW6A7A=.d7c077bf-9ffb-40a9-9177-2cde4648992c@github.com>

On Thu, 14 Dec 2023 20:30:49 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> linux-x86 GHA failure is unrelated.

Yes, thanks. We see the 32-bit failure of `gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java` regularly. This patch doesn't change anything that could be related.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/406#issuecomment-1857620845

From sgehwolf at openjdk.org  Fri Dec 15 10:40:47 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 15 Dec 2023 10:40:47 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly
In-Reply-To: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
Message-ID: <la72W5C7fmqzvD0kbkg_1Q3_gtQqHqGrpA-IHsQYrTg=.33eeef4d-ff3a-43fc-b35d-1148b2e7c731@github.com>

On Thu, 14 Dec 2023 03:19:25 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
> the only differences in the removed decodeSignature() method

Seems OK. Please apply for approval.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/404#pullrequestreview-1783564344

From gnu.andrew at redhat.com  Fri Dec 15 12:47:43 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Fri, 15 Dec 2023 12:47:43 +0000
Subject: Result: New OpenJDK 8u Reviewer: Thomas Stuefe
Message-ID: <ZXxK72R65Qb5A/3i@hex.discworld.ac.uk>

Voting for Thomas Stuefe [0] has now closed.

Yes: 9
Veto: 0
Abstain: 0

Turnout: 9% (9/102)

According to the Bylaws definition of Three-Vote Consensus [1], this is
sufficient to approve the nomination.

[0] https://mail.openjdk.org/pipermail/jdk8u-dev/2023-November/017693.html
[1] http://openjdk.java.net/bylaws#three-vote-consensus

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20231215/104b20c1/signature.asc>

From andrew at openjdk.org  Fri Dec 15 13:53:55 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Dec 2023 13:53:55 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
 <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
Message-ID: <X03FfN2yTCvhUOW9cmCB9F3qElyNNTLZds0iM2qrt3Q=.2556bcef-607a-46f9-a34c-1d98e85bbf9b@github.com>

On Thu, 14 Dec 2023 14:34:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
>> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed copyright date and engineVerify formating

Patch is mostly clean, bar moving the `try` block in `RSASignature.java`. There's a compatibility risk there, but it seems reasonably safe. I don't think JDK-8149802 i suitable for backporting as it introduces a reset in a `finally` block.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/403#pullrequestreview-1784081896

From andrew at openjdk.org  Fri Dec 15 13:54:51 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Dec 2023 13:54:51 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly
In-Reply-To: <la72W5C7fmqzvD0kbkg_1Q3_gtQqHqGrpA-IHsQYrTg=.33eeef4d-ff3a-43fc-b35d-1148b2e7c731@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
 <la72W5C7fmqzvD0kbkg_1Q3_gtQqHqGrpA-IHsQYrTg=.33eeef4d-ff3a-43fc-b35d-1148b2e7c731@github.com>
Message-ID: <vva09tuqq2YuHnKjjbqXbNmXL88CHg_nACp7JJf9SNE=.536186eb-95cd-4d97-878f-56c0e708e58d@github.com>

On Fri, 15 Dec 2023 10:37:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Seems OK. Please apply for approval.

Please wait until the dependency is in first, as this will then need to be rebased.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/404#issuecomment-1857917029

From abakhtin at openjdk.org  Fri Dec 15 17:43:00 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 17:43:00 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v3]
In-Reply-To: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
Message-ID: <kGX-63J-Wfw9oAughlAP7_koO6ShbbT4bosw531WFGI=.d6778561-acb6-4c0f-b2db-447541db58d6@github.com>

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  Move signature length verification out of try block

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/403/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/403/files/2110d9f5..8e33ae82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=403&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=403&range=01-02

  Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/403.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/403/head:pull/403

PR: https://git.openjdk.org/jdk8u-dev/pull/403

From abakhtin at openjdk.org  Fri Dec 15 17:43:03 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 17:43:03 GMT
Subject: [jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it
 will be thrown [v2]
In-Reply-To: <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
 <7qUyLeXUywpgxzYFNYUKtTWCZy2H4A-SdzFS-vaqnnU=.22b27773-81e3-4abe-89f7-5d4e18b101f3@github.com>
Message-ID: <2trWCSqSKt3diaw6bc8OsudGpUHg7OVsImEjikZcNBA=.8b002024-af87-4f2f-85f4-3bfc386b7fe1@github.com>

On Thu, 14 Dec 2023 14:34:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
>> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed copyright date and engineVerify formating

Thank you. I've moved length checking out of the try block

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/403#issuecomment-1858246035

From abakhtin at openjdk.org  Fri Dec 15 20:11:49 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 20:11:49 GMT
Subject: [jdk8u-dev] Integrated: 8302017: Allocate BadPaddingException only if
 it will be thrown
In-Reply-To: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
References: <1LgIFIrDOcyEHe6ZO9nplH5xzIPcsHuhCyveJFTRlQY=.752084e7-8fd6-45b7-8606-66d4c7cb39a8@github.com>
Message-ID: <CmPiNU831KYovRnQ5UwMLDAmPEUk-zj1gtERZVbodBI=.24b00b99-d8ca-47b5-81f5-13a7a8b49724@github.com>

On Thu, 14 Dec 2023 02:53:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block

This pull request has now been integrated.

Changeset: 2131e407
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/2131e40736a1c6e0dceb25fb0d27ff80d9dcb497
Stats:     154 lines in 5 files changed: 92 ins; 17 del; 45 mod

8302017: Allocate BadPaddingException only if it will be thrown

Reviewed-by: mbalao, andrew
Backport-of: 334b977259930368160db705c1f2feda0b0e8707

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/403

From abakhtin at openjdk.org  Fri Dec 15 20:17:01 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 20:17:01 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v2]
In-Reply-To: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
Message-ID: <p4TM1zodM__0cP17ThxHbIOCtWRsLdbZk3ECHyqhWrY=.56f5a383-df7d-423b-91d3-85f856efdb2e@github.com>

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
> the only differences in the removed decodeSignature() method

Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/404/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/404/files/73e9909f..73e9909f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=404&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=404&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/404.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/404/head:pull/404

PR: https://git.openjdk.org/jdk8u-dev/pull/404

From abakhtin at openjdk.org  Fri Dec 15 20:30:56 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 20:30:56 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v3]
In-Reply-To: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
Message-ID: <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
> the only differences in the removed decodeSignature() method

Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Revert copyright date
 - Merge branch 'master' into JDK-8320597
 - Backport 11e4a925bec3c1f79e03045d48def53188b655e6
 - Fix switch statement
 - Backport 334b977259930368160db705c1f2feda0b0e8707

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/404/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=404&range=02
  Stats: 85 lines in 2 files changed: 66 ins; 8 del; 11 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/404.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/404/head:pull/404

PR: https://git.openjdk.org/jdk8u-dev/pull/404

From abakhtin at openjdk.org  Fri Dec 15 20:34:47 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 15 Dec 2023 20:34:47 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v3]
In-Reply-To: <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
 <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
Message-ID: <pdL3xCC96BZDdcDxv2A7JrI6m1_awtfTkmePDT610hI=.ff0eddb4-7068-4e16-9d14-0f461626e6cb@github.com>

On Fri, 15 Dec 2023 20:30:56 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
>> the only differences in the removed decodeSignature() method
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Revert copyright date
>  - Merge branch 'master' into JDK-8320597
>  - Backport 11e4a925bec3c1f79e03045d48def53188b655e6
>  - Fix switch statement
>  - Backport 334b977259930368160db705c1f2feda0b0e8707

Fixed merge conflicts after 8302017 is integrated into 8u-dev

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/404#issuecomment-1858452654

From dhanalla at openjdk.org  Fri Dec 15 20:51:04 2023
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Fri, 15 Dec 2023 20:51:04 GMT
Subject: [jdk8u-dev] RFR: 8155590: Dubious collection management in
 sun.net.www.http.KeepAliveCache
Message-ID: <f6bdQ6ZGAsgXZzgfDhN3lfzSHnPN_nf5W4Jd4bQflro=.67bab6df-9ac8-462a-a154-93783cf2e709@github.com>

Issue:  [JDK-8155590](https://bugs.openjdk.org/browse/JDK-8155590) Dubious collection management in sun.net.www.http.KeepAliveCache

Backport of 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650

-------------

Commit messages:
 - Backport of 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650

Changes: https://git.openjdk.org/jdk8u-dev/pull/407/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=407&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8155590
  Stats: 103 lines in 1 file changed: 37 ins; 39 del; 27 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/407.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/407/head:pull/407

PR: https://git.openjdk.org/jdk8u-dev/pull/407

From mbalao at openjdk.org  Fri Dec 15 22:40:51 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Dec 2023 22:40:51 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v3]
In-Reply-To: <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
 <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
Message-ID: <hK51B6ZS5yWomqkj0x4b_ihPnUmdTSLA_cuOGnZHq90=.f42db71c-9407-4125-ada6-bcff6636aacd@github.com>

On Fri, 15 Dec 2023 20:30:56 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
>> the only differences in the removed decodeSignature() method
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Revert copyright date
>  - Merge branch 'master' into JDK-8320597
>  - Backport 11e4a925bec3c1f79e03045d48def53188b655e6
>  - Fix switch statement
>  - Backport 334b977259930368160db705c1f2feda0b0e8707

Thanks @alexeybakhtin for this backport. Looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/404#pullrequestreview-1785024403

From abakhtin at openjdk.org  Sat Dec 16 17:05:48 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Sat, 16 Dec 2023 17:05:48 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v3]
In-Reply-To: <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
 <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
Message-ID: <iz9HekV2MO2aTtEcvA8TJgJh8h3IyhL43mh8AQudc5E=.b8a5b29b-84c7-4e9f-9118-b24e94ae769b@github.com>

On Fri, 15 Dec 2023 20:30:56 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
>> the only differences in the removed decodeSignature() method
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Revert copyright date
>  - Merge branch 'master' into JDK-8320597
>  - Backport 11e4a925bec3c1f79e03045d48def53188b655e6
>  - Fix switch statement
>  - Backport 334b977259930368160db705c1f2feda0b0e8707

Pre-submit test failures are not related to the current changes

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/404#issuecomment-1858872146

From andrew at openjdk.org  Sat Dec 16 18:59:49 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 16 Dec 2023 18:59:49 GMT
Subject: [jdk8u-dev] RFR: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly [v3]
In-Reply-To: <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
 <YP3ybG_dVFTFxAZYTqRLgy7umq1d7HYCb3Iz4FMSDc0=.863ee66a-f6f3-4c94-b54b-2208e85eef9f@github.com>
Message-ID: <mHvR7T_MKSORpdWu8M2WSV4ehjLEig6HNG9apUXM8Tc=.94bc0bd3-616c-43c4-934d-30ed0c9d6513@github.com>

On Fri, 15 Dec 2023 20:30:56 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
>> the only differences in the removed decodeSignature() method
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Revert copyright date
>  - Merge branch 'master' into JDK-8320597
>  - Backport 11e4a925bec3c1f79e03045d48def53188b655e6
>  - Fix switch statement
>  - Backport 334b977259930368160db705c1f2feda0b0e8707

Looks clean, bar the differing `decodeSignature` method.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/404#pullrequestreview-1785256143

From abakhtin at openjdk.org  Sat Dec 16 19:31:50 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Sat, 16 Dec 2023 19:31:50 GMT
Subject: [jdk8u-dev] Integrated: 8320597: RSA signature verification fails on
 signed data that does not encode params correctly
In-Reply-To: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
References: <HMAcUO2bTvi1LdyiCchdAAlvX184VoUPOHPZsvTRhlw=.f8b0ce90-aa04-4b9a-82af-1b92768d7208@github.com>
Message-ID: <GSE9DPu0NSfKLzvhUzNgC2FgCpUNT0_lRw_3fID_yy0=.113a8f10-b660-4856-bb4d-2a88a07a90bf@github.com>

On Thu, 14 Dec 2023 03:19:25 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2384)
> the only differences in the removed decodeSignature() method

This pull request has now been integrated.

Changeset: a645ef48
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a645ef48c572e5b06710ae9d49bc4459ad1fa0f2
Stats:     85 lines in 2 files changed: 66 ins; 8 del; 11 mod

8320597: RSA signature verification fails on signed data that does not encode params correctly

Reviewed-by: sgehwolf, mbalao, andrew
Backport-of: 11e4a925bec3c1f79e03045d48def53188b655e6

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/404

From andrew at openjdk.org  Mon Dec 18 02:17:49 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 18 Dec 2023 02:17:49 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>

Sync jdk8u402-b05

-------------

Commit messages:
 - Merge
 - 8319187: Add three eMudhra emSign roots
 - 8318759: Add four DigiCert root certificates
 - 8317374: Add Let's Encrypt ISRG Root X2
 - 8317373: Add Telia Root CA v2

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/408/files
  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/408.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/408/head:pull/408

PR: https://git.openjdk.org/jdk8u-dev/pull/408

From jkratochvil at azul.com  Mon Dec 18 08:53:42 2023
From: jkratochvil at azul.com (Jan Kratochvil (Azul))
Date: Mon, 18 Dec 2023 16:53:42 +0800
Subject: Backporting stack guard fixes from JDK-9 (8169373+8159335+8139864)
In-Reply-To: <CAA-vtUy3Mfz+E_LFSwO5SK2kxFvZvh-5R8WcB0vw0C-6xONnDA@mail.gmail.com>
References: <ZXCGHI0jaDcjez53@host1.jankratochvil.net>
 <CAA-vtUy6ParNLuGf=jLX8MjL+rQH==LgLOAjLC-uWvNmJaq6eQ@mail.gmail.com>
 <ZXnVud0q5CubypGp@host1.jankratochvil.net>
 <CAA-vtUy3Mfz+E_LFSwO5SK2kxFvZvh-5R8WcB0vw0C-6xONnDA@mail.gmail.com>
Message-ID: <ZYAIlt7nTIoa_P1u@host1.jankratochvil.net>

On Fri, 15 Dec 2023 15:45:41 +0800, Thomas St?fe wrote:
> This coding only gets executed for the primordial thread, and the only way
> that could happen is if the hotspot had been embedded into a custom
> launcher. Is this the case here?

No, the crashed executable is .../bin/java.


> The normal java launcher invokes the JVM on a newly spawned pthread, so
> is_primordial_thread will always be false.

jdk/src/solaris/bin/java_md_solinux.c
    if (pthread_create(&tid, &attr, (void *(*)(void*))continuation, (void*)args) == 0) {
      void * tmp;
      // set name of the main java thread
      pthread_setname_np(pthread_self(), "JAVA");
----> pthread_join(tid, &tmp);
^^^^ = here is the core file in TID == PID
      rslt = (int)tmp;
    } else {
     /*
      * Continue execution in current thread if for some reason (e.g. out of
      * memory/LWP)  a new thread can't be created. This will likely fail
      * later in continuation as JNI_CreateJavaVM needs to create quite a
      * few new threads, anyway, just give it a try..
      */

OK, thanks for the advice. So the backport makes no sense.


Jan

From andrew at openjdk.org  Mon Dec 18 14:00:17 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 18 Dec 2023 14:00:17 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
In-Reply-To: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
References: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
Message-ID: <fA1FPF94iOjQxDxEzon0ImOzuABwp1ExtWqTZg5z6r8=.ff49966d-5950-48b7-9446-0d90a98ab406@github.com>

On Mon, 18 Dec 2023 02:13:20 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u402-b05

Failures unrelated to merge.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/408#issuecomment-1860565555

From andrew at openjdk.org  Mon Dec 18 14:00:17 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 18 Dec 2023 14:00:17 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
References: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
Message-ID: <wiNAvVgP9mDTp6yf72j2YP91pbovLxNLXydoAXYYILg=.98728da5-e2b8-4372-81e6-5ea4c3dc8997@github.com>

On Mon, 18 Dec 2023 02:13:20 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u402-b05

This pull request has now been integrated.

Changeset: d898d401
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d898d4018e0a16f2115f4b1cbf93eb5e653b789b
Stats:     0 lines in 0 files changed: 0 ins; 0 del; 0 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/408

From andrew at openjdk.org  Mon Dec 18 14:00:17 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 18 Dec 2023 14:00:17 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2]
In-Reply-To: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
References: <7OGfOxtTvRH8FSqjI_73IPxiHvhDL18vdG3_h1hJhXY=.99cab9a0-b29d-4f60-84f3-df8e5f8c4f8b@github.com>
Message-ID: <u-VhYLxrEy2LBwMWpbhzl9b23-CyoRkpS_1vdJpvdUg=.6211b8bc-4d10-4343-b3e6-2808aa28f1da@github.com>

> Sync jdk8u402-b05

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:

 - Merge
 - 8320597: RSA signature verification fails on signed data that does not encode params correctly
   
   Reviewed-by: sgehwolf, mbalao, andrew
   Backport-of: 11e4a925bec3c1f79e03045d48def53188b655e6
 - 8302017: Allocate BadPaddingException only if it will be thrown
   
   Reviewed-by: mbalao, andrew
   Backport-of: 334b977259930368160db705c1f2feda0b0e8707
 - 8319187: Add three eMudhra emSign roots
   
   Reviewed-by: andrew
   Backport-of: 0bda467f6e29c866c661e88a76a9fe3efc0a0d19
 - 8318759: Add four DigiCert root certificates
   
   Reviewed-by: phh, andrew
   Backport-of: 0ea58048f9b4cdaaa0470b2bcc03913fb3939453
 - 8317374: Add Let's Encrypt ISRG Root X2
   
   Reviewed-by: phh, andrew
   Backport-of: e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83
 - 8317373: Add Telia Root CA v2
   
   Reviewed-by: phh, andrew
   Backport-of: d3ebb4a155be8ed93e79b6b58c645e861ec30267
 - 8301310: The SendRawSysexMessage test may cause a JVM crash
   
   Reviewed-by: andrew
   Backport-of: d725b73df01ae4478dfaabc47c48cd7231d91afa
 - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set
   
   Reviewed-by: phh, andrew
 - 8308592: Framework for CA interoperability testing
   8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
   8288132: Update test artifacts in QuoVadis CA interop tests
   8268678: LetsEncryptCA.java test fails as Let?s Encrypt Authority X3 is retired
   8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java  OCSP response error
   
   Reviewed-by: sgehwolf
   Backport-of: c4faab66933b5977a466f28c31cba9fc099c8fb4
 - ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/9c9d6b26...46e51dca

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/408/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=408&range=01
  Stats: 7847 lines in 79 files changed: 1814 ins; 5698 del; 335 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/408.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/408/head:pull/408

PR: https://git.openjdk.org/jdk8u-dev/pull/408

From dhanalla at openjdk.org  Mon Dec 18 19:16:57 2023
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Mon, 18 Dec 2023 19:16:57 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing
 Connections
Message-ID: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>

Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.

The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.

Test performed:

JTreg jdk_tier1
JTreg jdk_tier2
New test case added to this PR passed with the fix and failed without it.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/407

Commit messages:
 - Backport 770c1f65c588f3156f9b70097df752d8059c1038

Changes: https://git.openjdk.org/jdk8u-dev/pull/409/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=409&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293562
  Stats: 306 lines in 3 files changed: 275 ins; 7 del; 24 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/409.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/409/head:pull/409

PR: https://git.openjdk.org/jdk8u-dev/pull/409

From duke at openjdk.org  Thu Dec 21 08:51:03 2023
From: duke at openjdk.org (Long Yang)
Date: Thu, 21 Dec 2023 08:51:03 GMT
Subject: [jdk8u-dev] RFR: 8312065: Socket.connect does not timeout when
 profiling
Message-ID: <kU2OUMEmk4aP92nKCFvgxdnYKY_pDb0bBXbDdiAb030=.23c470d0-81f5-49a1-8a0b-2254f5bbd322@github.com>

Hi,

This pull request contains the backport of [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), commit [1ce12c4](https://github.com/openjdk/jdk17u-dev/commit/1ce12c4f33d3d6905703d95df2574f4037dfd57d) from the [openjdk/jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository.

I added the test `B8312065.java`. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix.
This test relies on [libNativeThread](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/Socket/libNativeThread.c) to get the `OS thread ID` of the `Java threads`, and send signals to `OS threads`.
The `libNativeThread` was introduced to test the fix for [JDK-8237858](https://bugs.openjdk.org/browse/JDK-8237858). However, `JDK-8237858` only exists in Java 10 and above. There is no `JDK-8237858` problem on Java 8, so `JDK-8237858` cannot be backported to Java 8.
In order to use `libNativeThread`, I copied it to my backport.

I ran all the `jtreg` tests in `test/jdk/java/net/ServerSocket`,`test/jdk/java/net/Socket`,`test/jdk/java/net/SocketOption`,`test/jdk/java/net/ipv6` on my host, all passed.

Thanks!

-------------

Commit messages:
 - 8312065: Socket.connect does not timeout as expected when profiling

Changes: https://git.openjdk.org/jdk8u-dev/pull/410/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=410&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8312065
  Stats: 327 lines in 7 files changed: 244 ins; 0 del; 83 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/410.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/410/head:pull/410

PR: https://git.openjdk.org/jdk8u-dev/pull/410

From gnu.andrew at redhat.com  Tue Dec 26 18:18:59 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 26 Dec 2023 18:18:59 +0000
Subject: [FREEZE] 8u402 NOW FROZEN
Message-ID: <ZYsZEyq+djgjtWUZ@hex.discworld.ac.uk>

The release forest:

https://github.com/openjdk/jdk8u

is now frozen in preparation for release on or after 2024-01-16.

The final pre-release tag is jdk8u402-b05: https://github.com/openjdk/jdk8u/releases/tag/jdk8u402-b05

The final release tag will thus be no lower than jdk8u402-b06.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20231226/3cf2e22f/signature-0001.asc>