[jdk8u-dev] RFR: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese

[Andrew John Hughes]

On Wed, 29 Nov 2023 10:55:17 GMT, ktakakuri <duke at openjdk.org> wrote:

> I would like to fix this issue because the test dose not work as intended.
> Could someone please review it?

The tool and its tests are removed in 11u and later by JDK-8074431 so this is only applicable to 8u. The incorrect `\\r` was still in place when removed.

Is this specific to Japanese? It seems like it would fail with any Windows output containing carriage returns. Is it just that the Japanese character set needs conversion from native to ASCII?

The fix itself looks good. The copyright year needs to be bumped and the bug ID added to the `@bug` line. It will probably need to be split onto a new line due to the length; see `jdk/test/java/util/Locale/LocaleTest.java` for an example of this.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-1768885855