[jdk8u-dev] RFR: 8210560: [TEST] convert com/sun/jdi redefineClass-related tests

[Andrew John Hughes]

On Thu, 3 Aug 2023 07:15:41 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.
> 
> Original patch does not apply cleanly to 8u, because:
> 1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib.
> 2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager).
> 
> So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.
> 
> I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.

This seems to include both 8210560 & [8209109](https://bugs.openjdk.org/browse/JDK-8209109).
Can we please do 8209109 separately first? It is difficult to review this when the backport does not align with the version in 11u & trunk. Thanks.
Incidentally, the version of `CompilerUtils.java` that couldn't be compiled has now  been removed by [JDK-8305329](https://bugs.openjdk.org/browse/JDK-8305329)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/350#issuecomment-1845220807