[jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it will be thrown
Martin Balao
mbalao at openjdk.org
Thu Dec 14 07:19:44 UTC 2023
On Thu, 14 Dec 2023 02:53:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:
> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
Hi @alexeybakhtin
Thanks for proposing this backport.
Two minor comments:
1) The copyright date change in RSAPadding.java is not necessary (I made this comment for 17u and 11u too).
2) Would you mind adding the comment "// https://www.rfc-editor.org..." (and the line before) inside the try block as in 17u and 11u?
Thanks,
Martin.-
-------------
PR Review: https://git.openjdk.org/jdk8u-dev/pull/403#pullrequestreview-1781102180
More information about the jdk8u-dev
mailing list