[jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections

[Andrew John Hughes]

On Tue, 12 Dec 2023 00:09:06 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Issue:  [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890  fromJDK11 to JDK8.
> 
> The JDK11 patch doesn't apply cleanly due to file path/structure changes and the transformation of the ClientVector class to ArrayDeque from a Stack, resulting in changes being picked individually.
> 
> Test performed:
>    1. JTreg jdk_tier1
>    2. JTreg jdk_tier2
>    3. New test case added to this PR passed with the fix and failed without it.

It's difficult to review this accurately because it now contains both 8293562 and most of [JDK-8155590](https://bugs.openjdk.org/browse/JDK-8155590) for the `ArrayDeque` change.

I'd be more comfortable with this if we backported 8155590 separately and then rebased this change on top of that. Although this looks correct when I apply it and compare it to the 11u version, we end up with minor differences remaining that may then cause issues for any later changes. With looking at each patch separately, it makes it possible to compare it with the 11u version of the patch and spot any differences.

I had a quick look at 8155590 myself and it largely applies, with just a few hunks needing to be done manually (which I suspect you already had to do for this patch).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/402#pullrequestreview-1781531832