[jdk8u-dev] RFR: 8302017: Allocate BadPaddingException only if it will be thrown [v2]

Andrew John Hughes andrew at openjdk.org
Fri Dec 15 13:53:55 UTC 2023


On Thu, 14 Dec 2023 14:34:22 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport from [JDK11 PR](https://github.com/openjdk/jdk11u-dev/pull/2383)
>> The only changes in the RSASignature::engineVerify() method: getDigestValue() is called outside of try/catch block
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed copyright date and engineVerify formating

Patch is mostly clean, bar moving the `try` block in `RSASignature.java`. There's a compatibility risk there, but it seems reasonably safe. I don't think JDK-8149802 i suitable for backporting as it introduces a reset in a `finally` block.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/403#pullrequestreview-1784081896


More information about the jdk8u-dev mailing list