[jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v6]
Zdenek Zambersky
zzambers at openjdk.org
Mon Feb 6 13:03:55 UTC 2023
On Thu, 2 Feb 2023 09:34:11 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> 8287463: JFR: Disable TestDevNull.java on Windows
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>
> Moved to @requires (os.family != "windows") instead of Platfrom
Looked into `os.family` and this one indeed seems to work ok (there are tests using it in tier1 and they seem to be correctly selected based on OS). Note however that `@requires` requires some caution on JDK8 as not everything works. There was a problem with `vm.bits`, which has shown no errors, but tests got skipped on all platforms (even when supposed to be enabled) [1].
[1] https://github.com/openjdk/jdk8u-dev/pull/222
-------------
PR: https://git.openjdk.org/jdk8u-dev/pull/255
More information about the jdk8u-dev
mailing list