[jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v6]

Andrew John Hughes andrew at openjdk.org
Thu Feb 9 01:15:51 UTC 2023


On Wed, 8 Feb 2023 08:33:13 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Test files changed only.
>> 
>> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.
>> 
>> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.
>> 
>> There were 2 changes with test files paths:
>> 
>> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`.
>> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`.
>> 
>> Please note that this PR is a part of dependant PR chain
>> Prev PRs:
>> - #205 
>> - #206
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed review comments

Thanks, that looks a lot simpler.

Yes, `jdk8u-fix-request` can be added to the bug now all reviews are complete. Once you've done that, I'll approve and you can run the `integrate` command.

Thanks for persisting with this one.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/207


More information about the jdk8u-dev mailing list