From serb at openjdk.org Mon Jan 2 06:38:03 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 2 Jan 2023 06:38:03 GMT Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow In-Reply-To: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> Message-ID: On Mon, 12 Dec 2022 00:53:06 GMT, Leslie Zhai wrote: > Hi, > > java/awt/Graphics2D/DrawString/RotTransText.java fail: > > > STDERR: > java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064 > at RotTransText.testIt(RotTransText.java:102) > at RotTransText.main(RotTransText.java:41) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > > > And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue. > > The patch applies clean except manually change the source file path: > > * jdk/src/share/native/sun/font/freetypeScaler.c > * jdk/test/java/awt/font/Rotate/RotatedTextTest.java > > Tested jtreg tier1~3 for fastdebug/release. > > Thanks, > Leslie Zhai Marked as reviewed by serb (Reviewer). Looks fine. Please check that the fix for [JDK-8233006](https://bugs.openjdk.org/browse/JDK-8233006) need to be backported or not. It reworked this code as well. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/208 From lzhai at openjdk.org Tue Jan 3 02:49:57 2023 From: lzhai at openjdk.org (Leslie Zhai) Date: Tue, 3 Jan 2023 02:49:57 GMT Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow In-Reply-To: References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> Message-ID: On Mon, 2 Jan 2023 06:35:14 GMT, Sergey Bylokhov wrote: > Please check that the fix for [JDK-8233006](https://bugs.openjdk.org/browse/JDK-8233006) need to be backported or not. It reworked this code as well. Yes! java/awt/font/Rotate/RotatedSyntheticBoldTest.java [backported](https://github.com/xiangzhai/jdk8u-dev/commit/b24d5474e36db3e1a9b033f2f0e4112479b3eb0c) is still reproducible. And I am running jtreg test. Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/208 From jdowland at openjdk.org Tue Jan 3 11:53:32 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 3 Jan 2023 11:53:32 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory Message-ID: This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. the edited test passes for me. ------------- Commit messages: - adjust test to scope assertNotNull - add Java_jdk_internal_platform_CgroupMetrics_getTotalMemorySize0 to linux mapfile - 8292541: [Metrics] Reported memory limit may exceed physical machine memory Changes: https://git.openjdk.org/jdk8u-dev/pull/220/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=220&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292541 Stats: 62 lines in 4 files changed: 46 ins; 9 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/220.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/220/head:pull/220 PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Tue Jan 3 12:39:48 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 3 Jan 2023 12:39:48 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Message-ID: This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/220 Commit messages: - Fix test for 8u: lib paths and buildJdkDockerImage method - 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Changes: https://git.openjdk.org/jdk8u-dev/pull/221/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293540 Stats: 180 lines in 6 files changed: 143 ins; 23 del; 14 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/221/head:pull/221 PR: https://git.openjdk.org/jdk8u-dev/pull/221 From duke at openjdk.org Tue Jan 3 16:20:30 2023 From: duke at openjdk.org (zzambers) Date: Tue, 3 Jan 2023 16:20:30 GMT Subject: [jdk8u-dev] RFR: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u Message-ID: It was discovered [1] that following test is always skipped in 8u: `hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java` Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that: `@requires vm.bits == "64"` However `vm.bits` is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems. Fix: Fixed by doing explicit check in test instead of using jtreg tag. Testing: Tested using github actions as test is part of hotspot/tier1. [1] https://github.com/openjdk/jdk8u-dev/pull/182#discussion_r1024395333 [2] https://bugs.openjdk.org/browse/JDK-8087291 ------------- Commit messages: - Fixed MaxMetaspaceSizeTest Changes: https://git.openjdk.org/jdk8u-dev/pull/222/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299548 Stats: 6 lines in 1 file changed: 5 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/222.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/222/head:pull/222 PR: https://git.openjdk.org/jdk8u-dev/pull/222 From andrew at openjdk.org Wed Jan 4 01:46:01 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jan 2023 01:46:01 GMT Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> Message-ID: On Fri, 9 Dec 2022 09:39:45 GMT, Roman Marchenko wrote: > Actually clean backport. > > JDK8 has the same issue with processing host names for SNI. It'd be good to keep JDK8 up to date with the upstream. No risks. > > There were 2 conflicts with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` added and moved to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` added and moved to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs > > - #206 > - #207 Clean backport, simple bug fix. This has a `jdk8u-fix-yes` approval already. Please run the `integrate` command and then one of us can sponsor this to get it in. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/205 From andrew at openjdk.org Wed Jan 4 01:50:51 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Jan 2023 01:50:51 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired In-Reply-To: References: Message-ID: <_2DDM0hvty8-JmkC9uxyudIK0U4Jkpp8kWzeaXigVVI=.a033a33c-e1f6-491d-843b-6d2ca8765ed9@github.com> On Fri, 9 Dec 2022 09:48:57 GMT, Roman Marchenko wrote: > Actually clean backport. Test files changed only. > > There were 2 conflicts with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 Clean backport, necessary bug fix after integrating #205 Bug has `jdk8u-fix-yes` approval so this can be integrated once the dependent PR is integrated. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/206 From phh at openjdk.org Wed Jan 4 13:44:58 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 4 Jan 2023 13:44:58 GMT Subject: [jdk8u-dev] RFR: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 16:14:11 GMT, zzambers wrote: > It was discovered [1] that following test is always skipped in 8u: > `hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java` > > Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that: > `@requires vm.bits == "64"` > > However `vm.bits` is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems. > > **Fix:** > Fixed by doing explicit check in test instead of using jtreg tag. > > **Testing:** > Tested using github actions as test is part of hotspot/tier1. > > [1] https://github.com/openjdk/jdk8u-dev/pull/182#discussion_r1024395333 > [2] https://bugs.openjdk.org/browse/JDK-8087291 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/222 From andrew at openjdk.org Thu Jan 5 02:39:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 5 Jan 2023 02:39:59 GMT Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 13:33:24 GMT, Dmitry Cherepanov wrote: > Please review the currency data update (ISO 4217 Amendment 171 Update) > > CurrencyData.properties - conflict in copyright year > ValidateISO4217.java - conflict in copyright year and bug id list > tablea1.txt - conflict in FILEVERSION > LocaleDataTest.java - conflict in bug id list > > Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed Backport looks good to me, just a few adjustments for metadata and header differences. Looks like the bug already has approval, so can we get this integrated please? I'd like to follow it up with the remaining data updates, including the recent Croatian adoption of the Euro, and include them with the security bundle for the upcoming release. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/202 From andrew at openjdk.org Thu Jan 5 02:40:00 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 5 Jan 2023 02:40:00 GMT Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: <24hNZTsYXVj5zqn-YStq4a2Ihq8FdiAmK1azykHJGDo=.4108f7b5-45b4-4e96-a35c-4d4fe7688006@github.com> References: <24hNZTsYXVj5zqn-YStq4a2Ihq8FdiAmK1azykHJGDo=.4108f7b5-45b4-4e96-a35c-4d4fe7688006@github.com> Message-ID: On Fri, 2 Dec 2022 18:59:39 GMT, Paul Hohensee wrote: > Imo worth backporting [JDK-7102969](https://bugs.openjdk.org/browse/JDK-7102969) because it covers 3 issues that are worth fixing. > > 7102969: currency.properties supercede not working correctly 8149452: j.t.SimpleDateFormat.getDateFormatSymbols().getZoneStrings() returns incorrect result for some time zones 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) I agree this looks worth backporting, though it's largely separate to the pending data updates which are more critical. I'll look into this for 8u372 once those are in. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/202 From dcherepanov at openjdk.org Thu Jan 5 07:52:03 2023 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Thu, 5 Jan 2023 07:52:03 GMT Subject: [jdk8u-dev] Integrated: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 13:33:24 GMT, Dmitry Cherepanov wrote: > Please review the currency data update (ISO 4217 Amendment 171 Update) > > CurrencyData.properties - conflict in copyright year > ValidateISO4217.java - conflict in copyright year and bug id list > tablea1.txt - conflict in FILEVERSION > LocaleDataTest.java - conflict in bug id list > > Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed This pull request has now been integrated. Changeset: 7ad517dd Author: Dmitry Cherepanov URL: https://git.openjdk.org/jdk8u-dev/commit/7ad517dd8fdc142827062876da334f53ceb65749 Stats: 17 lines in 6 files changed: 3 ins; 0 del; 14 mod 8283277: ISO 4217 Amendment 171 Update Reviewed-by: phh, andrew Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/202 From serb at openjdk.org Fri Jan 6 03:18:01 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 6 Jan 2023 03:18:01 GMT Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow In-Reply-To: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> Message-ID: On Mon, 12 Dec 2022 00:53:06 GMT, Leslie Zhai wrote: > Hi, > > java/awt/Graphics2D/DrawString/RotTransText.java fail: > > > STDERR: > java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064 > at RotTransText.testIt(RotTransText.java:102) > at RotTransText.main(RotTransText.java:41) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > > > And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue. > > The patch applies clean except manually change the source file path: > > * jdk/src/share/native/sun/font/freetypeScaler.c > * jdk/test/java/awt/font/Rotate/RotatedTextTest.java > > Tested jtreg tier1~3 for fastdebug/release. > > Thanks, > Leslie Zhai > /integrate You need to get an approval in JBS before integration. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/208 From lzhai at openjdk.org Fri Jan 6 03:30:54 2023 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 6 Jan 2023 03:30:54 GMT Subject: [jdk8u-dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow In-Reply-To: References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> Message-ID: On Fri, 6 Jan 2023 03:15:18 GMT, Sergey Bylokhov wrote: >> Hi, >> >> java/awt/Graphics2D/DrawString/RotTransText.java fail: >> >> >> STDERR: >> java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064 >> at RotTransText.testIt(RotTransText.java:102) >> at RotTransText.main(RotTransText.java:41) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) >> at java.lang.Thread.run(Thread.java:750) >> >> >> And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue. >> >> The patch applies clean except manually change the source file path: >> >> * jdk/src/share/native/sun/font/freetypeScaler.c >> * jdk/test/java/awt/font/Rotate/RotatedTextTest.java >> >> Tested jtreg tier1~3 for fastdebug/release. >> >> Thanks, >> Leslie Zhai > >> /integrate > > You need to get an approval in JBS before integration. Hi @mrserb > You need to get an approval in JBS before integration. I added jdk8u-fix-request label back. Please point out my fault. Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/208 From serb at openjdk.org Fri Jan 6 03:54:03 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 6 Jan 2023 03:54:03 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 It looks like this change caused a regression fixed by the [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577)(probably some ofthe issues were fixed as well?), please chech that it is possible to backport it as well. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/212 From duke at openjdk.org Fri Jan 6 11:39:01 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 6 Jan 2023 11:39:01 GMT Subject: [jdk8u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS Message-ID: I would like to backport JDK-8283606 to JDK8u. This fix cannot be applied cleanly. - jdk8u contains only 1 test fixed in JDK-8283606 (hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java) - jdk8u contains 2 tests fixed in JDK-8299383 (backported to jdk11u) (langtools/test/tools/javadoc/6964914/TestStdDoclet.java, and langtools/test/tools/javadoc/6964914/TestUserDoclet.java) - Need to add more tests that are removed in latest version and have same problem. (langtools/test/tools/javah/T6893943.java) I tried to run these tests on Japanese Windows 10, and all tests are passed. But, I am not a author, so need a sponsor. Would you plese review this fix? Thank you. ------------- Commit messages: - Backport 7d545084f45af44386cb38172fd783f889a8c4e7 Changes: https://git.openjdk.org/jdk8u-dev/pull/223/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283606 Stats: 14 lines in 4 files changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/223.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/223/head:pull/223 PR: https://git.openjdk.org/jdk8u-dev/pull/223 From andrew at openjdk.org Fri Jan 6 12:16:54 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 12:16:54 GMT Subject: [jdk8u-dev] RFR: 8283277: ISO 4217 Amendment 171 Update In-Reply-To: References: Message-ID: On Fri, 2 Dec 2022 13:33:24 GMT, Dmitry Cherepanov wrote: > Please review the currency data update (ISO 4217 Amendment 171 Update) > > CurrencyData.properties - conflict in copyright year > ValidateISO4217.java - conflict in copyright year and bug id list > tablea1.txt - conflict in FILEVERSION > LocaleDataTest.java - conflict in bug id list > > Testing: jdk/test/java/util/Currency and jdk/test/sun/text/resources passed PR for the next ISO 4217 update: https://github.com/openjdk/jdk8u-dev/pull/224 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/202 From andrew at openjdk.org Fri Jan 6 12:24:51 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 12:24:51 GMT Subject: [jdk8u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update Message-ID: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. No data changes due to the last update already having the Sierra Leone changes, so this one is just a `dataversion` bump. Tests in `jdk/test/java/util/Currency` all pass. ------------- Commit messages: - Backport 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6 Changes: https://git.openjdk.org/jdk8u-dev/pull/224/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=224&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289549 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/224.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/224/head:pull/224 PR: https://git.openjdk.org/jdk8u-dev/pull/224 From andrew at openjdk.org Fri Jan 6 12:34:24 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 12:34:24 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update Message-ID: Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. Tests in `jdk/test/java/util/Currency` all pass. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/224 Commit messages: - Backport e3eccbcbc2e27921c058d43b81fb113d10be2dab Changes: https://git.openjdk.org/jdk8u-dev/pull/225/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294307 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/225.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/225/head:pull/225 PR: https://git.openjdk.org/jdk8u-dev/pull/225 From andrew at openjdk.org Fri Jan 6 12:45:38 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 12:45:38 GMT Subject: [jdk8u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update Message-ID: Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present, and `ValidateISO4217.java`, as it doesn't yet have [JDK-8264792](https://bugs.openjdk.org/browse/JDK-8264792) This one introduces Croatia's move to the Euro which occurred at the start of 2023. Tests in `jdk/test/java/util/Currency` all pass. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/225 Commit messages: - Backport ff60b348813fd7e32bdda322f345f90311a60207 Changes: https://git.openjdk.org/jdk8u-dev/pull/226/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=226&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296239 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/226.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/226/head:pull/226 PR: https://git.openjdk.org/jdk8u-dev/pull/226 From dcherepanov at openjdk.org Fri Jan 6 13:54:53 2023 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 6 Jan 2023 13:54:53 GMT Subject: [jdk8u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> References: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> Message-ID: On Fri, 6 Jan 2023 12:14:00 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the last update already having the Sierra Leone changes, so this one is just a `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. Looks good. ------------- Marked as reviewed by dcherepanov (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/224 From dcherepanov at openjdk.org Fri Jan 6 13:56:03 2023 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 6 Jan 2023 13:56:03 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: <6iAdyBOZXBX2bqu5wLGaaa6raFxmR9kFRg-7Fqs4V-s=.26a29399-afd0-4f76-8edb-4aded04b7b51@github.com> On Fri, 6 Jan 2023 12:27:34 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. Looks good. ------------- Marked as reviewed by dcherepanov (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/225 From dcherepanov at openjdk.org Fri Jan 6 13:57:52 2023 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 6 Jan 2023 13:57:52 GMT Subject: [jdk8u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 12:38:38 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present, and `ValidateISO4217.java`, as it doesn't yet have [JDK-8264792](https://bugs.openjdk.org/browse/JDK-8264792) > > This one introduces Croatia's move to the Euro which occurred at the start of 2023. > > Tests in `jdk/test/java/util/Currency` all pass. Looks good. ------------- Marked as reviewed by dcherepanov (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/226 From andrew at openjdk.org Fri Jan 6 17:21:05 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 17:21:05 GMT Subject: [jdk8u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: References: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> Message-ID: <_ay5yiUZwyy-NvH7MImOks7TQfqXef8UEaVY3W8nrn0=.d2ba158e-cf85-4a40-8c2f-4d87a682dbf0@github.com> On Fri, 6 Jan 2023 13:51:44 GMT, Dmitry Cherepanov wrote: > Looks good. Thanks. Flagged with `jdk8u-fix-request`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/224 From andrew at openjdk.org Fri Jan 6 17:24:55 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 17:24:55 GMT Subject: [jdk8u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 13:54:50 GMT, Dmitry Cherepanov wrote: > Looks good. Thanks for the quick review. Flagged with `jdk8u-fix-request`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/226 From andrew at openjdk.org Fri Jan 6 17:25:02 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Jan 2023 17:25:02 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: <6iAdyBOZXBX2bqu5wLGaaa6raFxmR9kFRg-7Fqs4V-s=.26a29399-afd0-4f76-8edb-4aded04b7b51@github.com> References: <6iAdyBOZXBX2bqu5wLGaaa6raFxmR9kFRg-7Fqs4V-s=.26a29399-afd0-4f76-8edb-4aded04b7b51@github.com> Message-ID: On Fri, 6 Jan 2023 13:52:50 GMT, Dmitry Cherepanov wrote: > Looks good. Thanks for the quick review. Flagged with `jdk8u-fix-request`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/225 From yan at azul.com Mon Jan 9 09:01:26 2023 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 9 Jan 2023 12:01:26 +0300 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin Message-ID: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates Committer. Alexey is doing active backporting work for 8u [1]. Having the committer role would aid this backporting work by avoiding the need to wait for sponsorship of fixes, after review & approval. Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. [0] https://openjdk.org/census#apavlyutkin [1] https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits [2] https://openjdk.org/census#jdk8u [3] https://openjdk.org/projects/#committer-vote Thanks, --yan From duke at openjdk.org Mon Jan 9 12:12:07 2023 From: duke at openjdk.org (zzambers) Date: Mon, 9 Jan 2023 12:12:07 GMT Subject: [jdk8u-dev] RFR: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u In-Reply-To: References: Message-ID: On Wed, 4 Jan 2023 13:42:17 GMT, Paul Hohensee wrote: >> It was discovered [1] that following test is always skipped in 8u: >> `hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java` >> >> Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that: >> `@requires vm.bits == "64"` >> >> However `vm.bits` is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems. >> >> **Fix:** >> Fixed by doing explicit check in test instead of using jtreg tag. >> >> **Testing:** >> Tested using github actions as test is part of hotspot/tier1. >> >> [1] https://github.com/openjdk/jdk8u-dev/pull/182#discussion_r1024395333 >> [2] https://bugs.openjdk.org/browse/JDK-8087291 > > Lgtm. @phohensee thanks ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/222 From sgehwolf at openjdk.org Mon Jan 9 13:16:43 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Jan 2023 13:16:43 GMT Subject: [jdk8u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun [v3] In-Reply-To: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> References: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> Message-ID: <_32oUOGiqdjX6QOfkQqem5y9VVgrScCjcQjQEIrII0o=.fb8ec992-4782-44fd-914f-b7c962a7992b@github.com> > Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Backport-of: ac6be165196457a26d837760b5f5030fe010d633 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/217/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=217&range=02 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/217.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/217/head:pull/217 PR: https://git.openjdk.org/jdk8u-dev/pull/217 From duke at openjdk.org Mon Jan 9 14:16:41 2023 From: duke at openjdk.org (zzambers) Date: Mon, 9 Jan 2023 14:16:41 GMT Subject: [jdk8u-dev] RFR: 8299804: Fix non-portable code in hotspot shell tests in 8u Message-ID: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> Some hotspot shell tests use `==` for comparison inside of `[ ]`. However this is bash extension and it is not portable (posix test command only knows single `=`, see: [1]). This results in errors on systems where default shell is not bash, such as Ubuntu used in GHA (which defaults to "Dash" shell). E.g.: `Test7107135.sh: 50: [: x/bin/gcc: unexpected operator` Expressions are then treated as always false. Problem is only present on 8u as newer jdks use different approach for shell/jni tests and no longer have these shell tests. Testing: Tests passed in GHA, logs no longer contain these errors. (Affected tests passed even before, as problematic comparisons happen to have such form and placement, that they did not cause test failures, but logs contained error messages.) [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html ------------- Commit messages: - Fixed shell comparsions Changes: https://git.openjdk.org/jdk8u-dev/pull/227/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=227&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299804 Stats: 15 lines in 6 files changed: 0 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/227.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/227/head:pull/227 PR: https://git.openjdk.org/jdk8u-dev/pull/227 From duke at openjdk.org Mon Jan 9 16:17:58 2023 From: duke at openjdk.org (zzambers) Date: Mon, 9 Jan 2023 16:17:58 GMT Subject: [jdk8u-dev] Integrated: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 16:14:11 GMT, zzambers wrote: > It was discovered [1] that following test is always skipped in 8u: > `hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java` > > Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that: > `@requires vm.bits == "64"` > > However `vm.bits` is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems. > > **Fix:** > Fixed by doing explicit check in test instead of using jtreg tag. > > **Testing:** > Tested using github actions as test is part of hotspot/tier1. > > [1] https://github.com/openjdk/jdk8u-dev/pull/182#discussion_r1024395333 > [2] https://bugs.openjdk.org/browse/JDK-8087291 This pull request has now been integrated. Changeset: 0f698dae Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/0f698dae3bfee354de3c9bea32f881b4d7d5c73e Stats: 6 lines in 1 file changed: 5 ins; 1 del; 0 mod 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/222 From hohensee at amazon.com Mon Jan 9 16:46:58 2023 From: hohensee at amazon.com (Hohensee, Paul) Date: Mon, 9 Jan 2023 16:46:58 +0000 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin Message-ID: Vote: yes ?On 1/9/23, 1:15 AM, "jdk8u-dev on behalf of Yuri Nesterenko" wrote: I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates Committer. Alexey is doing active backporting work for 8u [1]. Having the committer role would aid this backporting work by avoiding the need to wait for sponsorship of fixes, after review & approval. Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. [0] https://openjdk.org/census#apavlyutkin [1] https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits [2] https://openjdk.org/census#jdk8u [3] https://openjdk.org/projects/#committer-vote Thanks, --yan From sgehwolf at openjdk.org Mon Jan 9 18:29:06 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Jan 2023 18:29:06 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: <7ZlFhzkr5VcMLHtbeYsW47zseQK-5M5OkW7WGlaaOxk=.9745d448-87d9-4cb2-af5b-b1ac62c53cc0@github.com> On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. @jmtd Do you know why `TestMemoryAwareness.java` fails on 32 bit x86 with GHA? See: https://github.com/jmtd/jdk8u-dev/actions/runs/3829174689/jobs/6515859844#step:10:1806 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From sgehwolf at openjdk.org Mon Jan 9 18:30:05 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 9 Jan 2023 18:30:05 GMT Subject: [jdk8u-dev] RFR: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present [v2] In-Reply-To: References: Message-ID: On Fri, 23 Dec 2022 10:07:49 GMT, Jonathan Dowland wrote: >> This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u. > > Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision: > > remove testJavaVersionWithCgMounts > > As Severin points out, this test is not useful (in its current form) > for 8u. This bug has all approvals now, please integrate. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/216 From phh at openjdk.org Mon Jan 9 20:31:05 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 9 Jan 2023 20:31:05 GMT Subject: [jdk8u-dev] RFR: 8299804: Fix non-portable code in hotspot shell tests in 8u In-Reply-To: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> References: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> Message-ID: On Mon, 9 Jan 2023 13:02:17 GMT, zzambers wrote: > Some hotspot shell tests use `==` for comparison inside of `[ ]`. However this is bash extension and it is not portable (posix test command only knows single `=`, see: [1]). > > This results in errors on systems where default shell is not bash, such as Ubuntu used in GHA (which defaults to "Dash" shell). E.g.: > `Test7107135.sh: 50: [: x/bin/gcc: unexpected operator` > Expressions are then treated as always false. > > Problem is only present on 8u as newer jdks use different approach for shell/jni tests and no longer have these shell tests. > > Testing: > Tests passed in GHA, logs no longer contain these errors. (Affected tests passed even before, as problematic comparisons happen to have such form and placement, that they did not cause test failures, but logs contained error messages.) > > [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/227 From jdowland at openjdk.org Mon Jan 9 20:38:59 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 9 Jan 2023 20:38:59 GMT Subject: [jdk8u-dev] Integrated: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 12:14:12 GMT, Jonathan Dowland wrote: > This is a backport of 8293472 to 8u for cgroups v2 support. Not clean: log_debug?tty->print_cr and Files.writeString ? Files.write() needed, as well as adjustments for the lack of [8266490](https://bugs.openjdk.org/browse/JDK-8266490) (PID controller support) in 8u. This pull request has now been integrated. Changeset: 65fcf619 Author: Jonathan Dowland URL: https://git.openjdk.org/jdk8u-dev/commit/65fcf61916526f929c1cc2c1d2971451676fc9e9 Stats: 153 lines in 5 files changed: 98 ins; 29 del; 26 mod 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Reviewed-by: sgehwolf Backport-of: 8f3bbe950fb5a3d9f6cae122209df01df0f342f0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/216 From andrew at openjdk.org Tue Jan 10 02:51:01 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 02:51:01 GMT Subject: [jdk8u-dev] RFR: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> References: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> Message-ID: On Fri, 6 Jan 2023 12:14:00 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the last update already having the Sierra Leone changes, so this one is just a `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. I see `jdk8u-fix-yes` ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/224 From andrew at openjdk.org Tue Jan 10 02:51:02 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 02:51:02 GMT Subject: [jdk8u-dev] Integrated: 8289549: ISO 4217 Amendment 172 Update In-Reply-To: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> References: <95sWn-zCRZv5rVI_0hY_cBeOfWmMUeg3ahA7tFSqCWo=.63f58648-b776-41f0-8aa7-4573254c1f5f@github.com> Message-ID: On Fri, 6 Jan 2023 12:14:00 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the last update already having the Sierra Leone changes, so this one is just a `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. This pull request has now been integrated. Changeset: ca685797 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/ca6857979dbc90b9f9ecbbea6b55727bc4540a97 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8289549: ISO 4217 Amendment 172 Update Reviewed-by: dcherepanov Backport-of: 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/224 From andrew at openjdk.org Tue Jan 10 02:57:14 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 02:57:14 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update [v2] In-Reply-To: References: Message-ID: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/225/files - new: https://git.openjdk.org/jdk8u-dev/pull/225/files/12e5b182..12e5b182 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=225&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=225&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/225.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/225/head:pull/225 PR: https://git.openjdk.org/jdk8u-dev/pull/225 From andrew at openjdk.org Tue Jan 10 04:34:56 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 04:34:56 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update [v2] In-Reply-To: References: Message-ID: On Tue, 10 Jan 2023 02:57:14 GMT, Andrew John Hughes wrote: >> Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. >> >> No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. >> >> Tests in `jdk/test/java/util/Currency` all pass. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. I see `jdk8u-fix-yes`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/225 From andrew at openjdk.org Tue Jan 10 04:34:55 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 04:34:55 GMT Subject: [jdk8u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update [v3] In-Reply-To: References: Message-ID: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport e3eccbcbc2e27921c058d43b81fb113d10be2dab ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/225/files - new: https://git.openjdk.org/jdk8u-dev/pull/225/files/12e5b182..6281319c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=225&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=225&range=01-02 Stats: 159 lines in 6 files changed: 103 ins; 30 del; 26 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/225.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/225/head:pull/225 PR: https://git.openjdk.org/jdk8u-dev/pull/225 From andrew at openjdk.org Tue Jan 10 04:34:57 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 04:34:57 GMT Subject: [jdk8u-dev] Integrated: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 12:27:34 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present. > > No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another `dataversion` bump. > > Tests in `jdk/test/java/util/Currency` all pass. This pull request has now been integrated. Changeset: 7c51dae1 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/7c51dae174c4df694b3d9cb072f03ea455066bfd Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8294307: ISO 4217 Amendment 173 Update Reviewed-by: dcherepanov Backport-of: e3eccbcbc2e27921c058d43b81fb113d10be2dab ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/225 From andrew at openjdk.org Tue Jan 10 04:41:02 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 04:41:02 GMT Subject: [jdk8u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update [v2] In-Reply-To: References: Message-ID: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present, and `ValidateISO4217.java`, as it doesn't yet have [JDK-8264792](https://bugs.openjdk.org/browse/JDK-8264792) > > This one introduces Croatia's move to the Euro which occurred at the start of 2023. > > Tests in `jdk/test/java/util/Currency` all pass. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ff60b348813fd7e32bdda322f345f90311a60207 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/226/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=226&range=01 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/226.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/226/head:pull/226 PR: https://git.openjdk.org/jdk8u-dev/pull/226 From alexey at azul.com Tue Jan 10 06:28:03 2023 From: alexey at azul.com (Alexey Bakhtin) Date: Tue, 10 Jan 2023 06:28:03 +0000 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin In-Reply-To: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> References: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> Message-ID: <63120294-D493-4367-88C8-3B74B4CD0C3B@azul.com> Vote: yes > On 9 Jan 2023, at 11:01, Yuri Nesterenko wrote: > > I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates > Committer. > > Alexey is doing active backporting work for 8u [1]. Having the committer role > would aid this backporting work by avoiding the need to wait for sponsorship of > fixes, after review & approval. > > Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. > > Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > [0] https://openjdk.org/census#apavlyutkin > > > [1] > https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits > > > [2] https://openjdk.org/census#jdk8u > > [3] https://openjdk.org/projects/#committer-vote > > > Thanks, > --yan -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: From yan at azul.com Tue Jan 10 07:29:51 2023 From: yan at azul.com (Yuri Nesterenko) Date: Tue, 10 Jan 2023 10:29:51 +0300 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin In-Reply-To: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> References: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> Message-ID: <9f337f80-d3ed-5130-acd9-778808a73583@azul.com> And, vote: yes --yan On 09.01.2023 12:01, Yuri Nesterenko wrote: > I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates > Committer. > > Alexey is doing active backporting work for 8u [1]. Having the committer role > would aid this backporting work by avoiding the need to wait for sponsorship of > fixes, after review & approval. > > Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. > > Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > [0] https://openjdk.org/census#apavlyutkin > > > [1] > https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits > > > [2] https://openjdk.org/census#jdk8u > > [3] https://openjdk.org/projects/#committer-vote > > > Thanks, > --yan From dcherepanov at azul.com Tue Jan 10 07:50:52 2023 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Tue, 10 Jan 2023 11:50:52 +0400 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin In-Reply-To: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> References: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> Message-ID: <5d0c2909-ac55-31a4-351c-f3d5cbf632bf@azul.com> Vote: yes On 09.01.2023 13:01, Yuri Nesterenko wrote: > I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates > Committer. > > Alexey is doing active backporting work for 8u [1]. Having the committer role > would aid this backporting work by avoiding the need to wait for sponsorship of > fixes, after review & approval. > > Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. > > Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > [0] https://openjdk.org/census#apavlyutkin > > > [1] > https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits > > > [2] https://openjdk.org/census#jdk8u > > [3] https://openjdk.org/projects/#committer-vote > > > Thanks, > --yan From abrygin at azul.com Tue Jan 10 09:32:59 2023 From: abrygin at azul.com (Andrew Brygin) Date: Tue, 10 Jan 2023 12:32:59 +0300 Subject: CFV: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin In-Reply-To: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> References: <12e2c000-6ac0-fb99-be42-676a3daad40a@azul.com> Message-ID: <848c27e5-b83d-9aa2-cb66-1ccb79d14794@azul.com> Vote: yes. Thanks, Andrew On 09.01.2023 12:01, Yuri Nesterenko wrote: > I hereby nominate Alexey Pavlyutkin (apavlyutkin) [0] to OpenJDK 8 Updates > Committer. > > Alexey is doing active backporting work for 8u [1]. Having the committer > role > would aid this backporting work by avoiding the need to wait for > sponsorship of > fixes, after review & approval. > > Votes are due by 00h00 UTC on Tuesday, the 24th of January 2023. > > Only current OpenJDK 8 Updates Committers (and above) [2] are eligible > to vote > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > [0] https://openjdk.org/census#apavlyutkin > > > [1] > https://github.com/openjdk/jdk8u-dev/search?q=author:apavlyutkin&type=commits > > > [2] https://openjdk.org/census#jdk8u > > [3] https://openjdk.org/projects/#committer-vote > > > Thanks, > --yan From sgehwolf at openjdk.org Tue Jan 10 11:12:03 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 10 Jan 2023 11:12:03 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. Looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/220 From sgehwolf at openjdk.org Tue Jan 10 17:46:08 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 10 Jan 2023 17:46:08 GMT Subject: [jdk8u-dev] RFR: 8299804: Fix non-portable code in hotspot shell tests in 8u In-Reply-To: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> References: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> Message-ID: On Mon, 9 Jan 2023 13:02:17 GMT, zzambers wrote: > Some hotspot shell tests use `==` for comparison inside of `[ ]`. However this is bash extension and it is not portable (posix test command only knows single `=`, see: [1]). > > This results in errors on systems where default shell is not bash, such as Ubuntu used in GHA (which defaults to "Dash" shell). E.g.: > `Test7107135.sh: 50: [: x/bin/gcc: unexpected operator` > Expressions are then treated as always false. > > Problem is only present on 8u as newer jdks use different approach for shell/jni tests and no longer have these shell tests. > > Testing: > Tests passed in GHA, logs no longer contain these errors. (Affected tests passed even before, as problematic comparisons happen to have such form and placement, that they did not cause test failures, but logs contained error messages.) > > [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/227 From andrew at openjdk.org Tue Jan 10 18:59:13 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 18:59:13 GMT Subject: [jdk8u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update [v2] In-Reply-To: References: Message-ID: On Tue, 10 Jan 2023 04:41:02 GMT, Andrew John Hughes wrote: >> Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present, and `ValidateISO4217.java`, as it doesn't yet have [JDK-8264792](https://bugs.openjdk.org/browse/JDK-8264792) >> >> This one introduces Croatia's move to the Euro which occurred at the start of 2023. >> >> Tests in `jdk/test/java/util/Currency` all pass. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ff60b348813fd7e32bdda322f345f90311a60207 I see `jdk8u-fix-yes`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/226 From andrew at openjdk.org Tue Jan 10 18:59:14 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 10 Jan 2023 18:59:14 GMT Subject: [jdk8u-dev] Integrated: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 12:38:38 GMT, Andrew John Hughes wrote: > Mostly clean backport of the next ISO 4217 update. Manual resolution was required on `tablea1.txt` as 8u is still using the older `FILEVERSION` at present, and `ValidateISO4217.java`, as it doesn't yet have [JDK-8264792](https://bugs.openjdk.org/browse/JDK-8264792) > > This one introduces Croatia's move to the Euro which occurred at the start of 2023. > > Tests in `jdk/test/java/util/Currency` all pass. This pull request has now been integrated. Changeset: 1694a3aa Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/1694a3aa8fd28739889cca0356e1ec4b4db4b8fb Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod 8296239: ISO 4217 Amendment 174 Update Reviewed-by: dcherepanov Backport-of: ff60b348813fd7e32bdda322f345f90311a60207 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/226 From andrew at openjdk.org Wed Jan 11 03:03:43 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 11 Jan 2023 03:03:43 GMT Subject: [jdk8u-dev] RFR: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR Message-ID: This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. There are actually two fixes here, which may not be clear from the original bug: 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. The patch also removes the long redundant time dependencies for Lithuania and Latvia. ------------- Commit messages: - Backport 80eecc50e663155f04dcec1797efb4be4b8ee7b2 Changes: https://git.openjdk.org/jdk8u-dev/pull/228/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=228&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299439 Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/228.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/228/head:pull/228 PR: https://git.openjdk.org/jdk8u-dev/pull/228 From andrew at openjdk.org Wed Jan 11 04:35:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 11 Jan 2023 04:35:30 GMT Subject: [jdk8u-dev] RFR: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR In-Reply-To: References: Message-ID: On Wed, 11 Jan 2023 02:56:01 GMT, Andrew John Hughes wrote: > This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. > > There are actually two fixes here, which may not be clear from the original bug: > > 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. > 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) > > The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. > > The patch also removes the long redundant time dependencies for Lithuania and Latvia. Failures appear to be down to download errors, nothing to do with the patch. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/228 From dcherepanov at openjdk.org Wed Jan 11 07:03:24 2023 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Wed, 11 Jan 2023 07:03:24 GMT Subject: [jdk8u-dev] RFR: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR In-Reply-To: References: Message-ID: On Wed, 11 Jan 2023 02:56:01 GMT, Andrew John Hughes wrote: > This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. > > There are actually two fixes here, which may not be clear from the original bug: > > 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. > 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) > > The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. > > The patch also removes the long redundant time dependencies for Lithuania and Latvia. Looks good ------------- Marked as reviewed by dcherepanov (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/228 From sgehwolf at openjdk.org Wed Jan 11 09:33:26 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Jan 2023 09:33:26 GMT Subject: [jdk8u-dev] RFR: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR In-Reply-To: References: Message-ID: On Wed, 11 Jan 2023 02:56:01 GMT, Andrew John Hughes wrote: > This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. > > There are actually two fixes here, which may not be clear from the original bug: > > 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. > 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) > > The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. > > The patch also removes the long redundant time dependencies for Lithuania and Latvia. Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/228 From duke at openjdk.org Wed Jan 11 12:36:26 2023 From: duke at openjdk.org (zzambers) Date: Wed, 11 Jan 2023 12:36:26 GMT Subject: [jdk8u-dev] RFR: 8299804: Fix non-portable code in hotspot shell tests in 8u In-Reply-To: References: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> Message-ID: On Mon, 9 Jan 2023 20:28:00 GMT, Paul Hohensee wrote: >> Some hotspot shell tests use `==` for comparison inside of `[ ]`. However this is bash extension and it is not portable (posix test command only knows single `=`, see: [1]). >> >> This results in errors on systems where default shell is not bash, such as Ubuntu used in GHA (which defaults to "Dash" shell). E.g.: >> `Test7107135.sh: 50: [: x/bin/gcc: unexpected operator` >> Expressions are then treated as always false. >> >> Problem is only present on 8u as newer jdks use different approach for shell/jni tests and no longer have these shell tests. >> >> Testing: >> Tests passed in GHA, logs no longer contain these errors. (Affected tests passed even before, as problematic comparisons happen to have such form and placement, that they did not cause test failures, but logs contained error messages.) >> >> [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html > > Lgtm. @phohensee @jerboaa thanks ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/227 From duke at openjdk.org Wed Jan 11 13:13:26 2023 From: duke at openjdk.org (zzambers) Date: Wed, 11 Jan 2023 13:13:26 GMT Subject: [jdk8u-dev] Integrated: 8299804: Fix non-portable code in hotspot shell tests in 8u In-Reply-To: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> References: <8ImGGABGMuTjFFa2ez_Vlt5vZcuWLRQ-w-1pwWo_-3E=.49f614e2-c399-4017-94d0-9a488a906280@github.com> Message-ID: On Mon, 9 Jan 2023 13:02:17 GMT, zzambers wrote: > Some hotspot shell tests use `==` for comparison inside of `[ ]`. However this is bash extension and it is not portable (posix test command only knows single `=`, see: [1]). > > This results in errors on systems where default shell is not bash, such as Ubuntu used in GHA (which defaults to "Dash" shell). E.g.: > `Test7107135.sh: 50: [: x/bin/gcc: unexpected operator` > Expressions are then treated as always false. > > Problem is only present on 8u as newer jdks use different approach for shell/jni tests and no longer have these shell tests. > > Testing: > Tests passed in GHA, logs no longer contain these errors. (Affected tests passed even before, as problematic comparisons happen to have such form and placement, that they did not cause test failures, but logs contained error messages.) > > [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html This pull request has now been integrated. Changeset: 5a3fc18e Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5a3fc18e92f3b34ad604b4cb269c08a96c021560 Stats: 15 lines in 6 files changed: 0 ins; 0 del; 15 mod 8299804: Fix non-portable code in hotspot shell tests in 8u Reviewed-by: phh, sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/227 From sgehwolf at openjdk.org Wed Jan 11 15:52:29 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Jan 2023 15:52:29 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. This patch breaks GHA tests on 32 bit Linux. We need to investigate why before we can integrate it. ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/220 From andrew at openjdk.org Wed Jan 11 16:35:26 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 11 Jan 2023 16:35:26 GMT Subject: [jdk8u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun [v3] In-Reply-To: <_32oUOGiqdjX6QOfkQqem5y9VVgrScCjcQjQEIrII0o=.fb8ec992-4782-44fd-914f-b7c962a7992b@github.com> References: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> <_32oUOGiqdjX6QOfkQqem5y9VVgrScCjcQjQEIrII0o=.fb8ec992-4782-44fd-914f-b7c962a7992b@github.com> Message-ID: On Mon, 9 Jan 2023 13:16:43 GMT, Severin Gehwolf wrote: >> Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun > > Backport-of: ac6be165196457a26d837760b5f5030fe010d633 Makes sense. Was `--memory-swappiness` actually achieving anything on systems where it was supported? ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/217 From sgehwolf at openjdk.org Wed Jan 11 17:31:34 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Jan 2023 17:31:34 GMT Subject: [jdk8u-dev] RFR: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun [v3] In-Reply-To: <_32oUOGiqdjX6QOfkQqem5y9VVgrScCjcQjQEIrII0o=.fb8ec992-4782-44fd-914f-b7c962a7992b@github.com> References: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> <_32oUOGiqdjX6QOfkQqem5y9VVgrScCjcQjQEIrII0o=.fb8ec992-4782-44fd-914f-b7c962a7992b@github.com> Message-ID: On Mon, 9 Jan 2023 13:16:43 GMT, Severin Gehwolf wrote: >> Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun > > Backport-of: ac6be165196457a26d837760b5f5030fe010d633 Thanks! > Was `--memory-swappiness` actually achieving anything on systems where it was supported? Memory swappiness is a cgroup v1 feature. So it might have had some effect, but for the purpose of the test I'm not sure it did matter as it was setting memory and memory/swap to the same value anyway. At least I'm not aware of any test failures of this OOM test with these settings. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/217 From sgehwolf at openjdk.org Wed Jan 11 17:36:27 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Jan 2023 17:36:27 GMT Subject: [jdk8u-dev] Integrated: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun In-Reply-To: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> References: <5998AxvGX5tMLYgxru5nLdk635a0JDOgzsX5XqPOETk=.5eb7735b-83ce-4806-8213-e33143aa87c1@github.com> Message-ID: On Tue, 20 Dec 2022 16:59:18 GMT, Severin Gehwolf wrote: > Clean backport. Fixes a test issue on cg v2 where `--memory-swappiness` is not supported. This pull request has now been integrated. Changeset: 9d954b9f Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/9d954b9ff20185366d394c0971b01fbea70c745f Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun Reviewed-by: andrew Backport-of: ac6be165196457a26d837760b5f5030fe010d633 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/217 From serb at openjdk.org Thu Jan 12 04:15:12 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 12 Jan 2023 04:15:12 GMT Subject: [jdk8u-dev] RFR: 8300014: Some backports placed the tests in the wrong location Message-ID: The test added [here](https://github.com/openjdk/jdk8u-dev/commit/700f182cae67101bc5905105b4d45b2449ec3df0) is moved from the "jdk/test/jdk/java/awt/print/" to the "jdk/test/java/awt/print/". The empty file added [here](https://github.com/openjdk/jdk8u-dev/commit/70d7bd18c82ecd56efc676909eec4480e4feaa6f) deleted. ------------- Commit messages: - Some backports placed the tests in the wrong location Changes: https://git.openjdk.org/jdk8u-dev/pull/229/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=229&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300014 Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/229.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/229/head:pull/229 PR: https://git.openjdk.org/jdk8u-dev/pull/229 From sgehwolf at openjdk.org Thu Jan 12 09:36:22 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Jan 2023 09:36:22 GMT Subject: [jdk8u-dev] RFR: 8300014: Some backports placed the tests in the wrong location In-Reply-To: References: Message-ID: On Thu, 12 Jan 2023 03:52:53 GMT, Sergey Bylokhov wrote: > The test added [here](https://github.com/openjdk/jdk8u-dev/commit/700f182cae67101bc5905105b4d45b2449ec3df0) is moved from the "jdk/test/jdk/java/awt/print/" to the "jdk/test/java/awt/print/". > > The empty file added [here](https://github.com/openjdk/jdk8u-dev/commit/70d7bd18c82ecd56efc676909eec4480e4feaa6f) deleted. Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/229 From andrew at openjdk.org Thu Jan 12 16:20:32 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 12 Jan 2023 16:20:32 GMT Subject: [jdk8u-dev] RFR: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR In-Reply-To: References: Message-ID: <4c-PAd-rQQJv0trnqypDeJDNSeDUVexNDh8VrbYqya0=.a4009265-14e1-477a-90ec-79d426c0e906@github.com> On Wed, 11 Jan 2023 02:56:01 GMT, Andrew John Hughes wrote: > This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. > > There are actually two fixes here, which may not be clear from the original bug: > > 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. > 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) > > The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. > > The patch also removes the long redundant time dependencies for Lithuania and Latvia. I see `jdk8u-fix-yes`. \integrate Test failure is a timeout on `gc/6581734/Test6581734.java`. Is this a known failure? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/228 From phh at openjdk.org Thu Jan 12 16:52:26 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 12 Jan 2023 16:52:26 GMT Subject: [jdk8u-dev] RFR: 8300014: Some backports placed the tests in the wrong location In-Reply-To: References: Message-ID: <3d8jh9_UWPyeZhqn5hNAo7nVm5QIq9KGFZyz59ZnQpw=.6c93362e-cfd7-4dc7-b852-1fbb337b325b@github.com> On Thu, 12 Jan 2023 03:52:53 GMT, Sergey Bylokhov wrote: > The test added [here](https://github.com/openjdk/jdk8u-dev/commit/700f182cae67101bc5905105b4d45b2449ec3df0) is moved from the "jdk/test/jdk/java/awt/print/" to the "jdk/test/java/awt/print/". > > The empty file added [here](https://github.com/openjdk/jdk8u-dev/commit/70d7bd18c82ecd56efc676909eec4480e4feaa6f) deleted. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/229 From andrew at openjdk.org Thu Jan 12 17:47:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 12 Jan 2023 17:47:30 GMT Subject: [jdk8u-dev] Integrated: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR In-Reply-To: References: Message-ID: <8Epm4jeytIctgMT6ufI-P5SLSVuL0bN0lLXwSse4vuw=.9e931643-dbbb-416a-b0fb-88197848c0d3@github.com> On Wed, 11 Jan 2023 02:56:01 GMT, Andrew John Hughes wrote: > This is a mostly clean backport from 11u. The only difference is the `ProblemList.txt` copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes. > > There are actually two fixes here, which may not be clear from the original bug: > > 1. The test data for the `CurrencyFormat.java` test still expects `hr_HR` to return `Kn` and hasn't been updated following Croatia's move to the Euro. > 2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code `EUR` to the Euro symbol. The same change to `CurrencyNames_hr_HR.properties` is required as was made to `CurrencyNames_lt_LT.properties` for [Lithuania's move to the Euro in 2014](https://github.com/openjdk/jdk8u/commit/f11ce28bbcba7d0c07c2340a748a828efe5d454f#diff-3f1199e2404f201dd0f738feb6f5c03de95013dda69e1896fc74ca0ed0e6f29a) > > The above was verified by running the unpatched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"`), the patched test against an unpatched JDK (`"Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR"`) and the patched test against a patched JDK (both `\u20AC`). Only the last of these passes. > > The patch also removes the long redundant time dependencies for Lithuania and Latvia. This pull request has now been integrated. Changeset: a5c3ebe6 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/a5c3ebe614d5d1595098bb402ae94e6ba5265171 Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Reviewed-by: dcherepanov, sgehwolf Backport-of: 80eecc50e663155f04dcec1797efb4be4b8ee7b2 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/228 From duke at openjdk.org Fri Jan 13 10:02:31 2023 From: duke at openjdk.org (ktakakuri) Date: Fri, 13 Jan 2023 10:02:31 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 DefaultButtonModelCrashTest passed even before this backport was applied. Does this mean that JDK-8182577 is already fixed in 8u? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/212 From sgehwolf at openjdk.org Fri Jan 13 13:00:36 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 13 Jan 2023 13:00:36 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. jdk/src/linux/native/jdk/internal/platform/cgroupv1/CgroupMetrics.c line 42: > 40: (JNIEnv *env, jclass ignored) > 41: { > 42: return sysconf(_SC_PHYS_PAGES) * sysconf(_SC_PAGESIZE); According to my experiments changing this to: jlong page_size = sysconf(_SC_PAGESIZE); jlong pages = sysconf(_SC_PHYS_PAGES); return pages * page_size; fixes the test issue on x86 (32 bit). As this is an issue with the upstream patch, I suggest to file an upstream bug to get it fixed as we'll likely have missed the issue on later JDKs (no testing happens on x86 AFAIK). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From sgehwolf at openjdk.org Fri Jan 13 13:03:41 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 13 Jan 2023 13:03:41 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 12:58:01 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. >> >> It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. >> >> the edited test passes for me. > > jdk/src/linux/native/jdk/internal/platform/cgroupv1/CgroupMetrics.c line 42: > >> 40: (JNIEnv *env, jclass ignored) >> 41: { >> 42: return sysconf(_SC_PHYS_PAGES) * sysconf(_SC_PAGESIZE); > > According to my experiments changing this to: > > > jlong page_size = sysconf(_SC_PAGESIZE); > jlong pages = sysconf(_SC_PHYS_PAGES); > return pages * page_size; > > > fixes the test issue on x86 (32 bit). As this is an issue with the upstream patch, I suggest to file an upstream bug to get it fixed as we'll likely have missed the issue on later JDKs (no testing happens on x86 AFAIK). Not that with an instrumented JDK I was able to observe the following (when the test fails): systemMemory == -1308622848 containerMemory == 104857600 Metrics.getMemoryLimit() == -1 I.e. we were getting a negative host memory value. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 14:53:21 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 14:53:21 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 13:01:14 GMT, Severin Gehwolf wrote: >> jdk/src/linux/native/jdk/internal/platform/cgroupv1/CgroupMetrics.c line 42: >> >>> 40: (JNIEnv *env, jclass ignored) >>> 41: { >>> 42: return sysconf(_SC_PHYS_PAGES) * sysconf(_SC_PAGESIZE); >> >> According to my experiments changing this to: >> >> >> jlong page_size = sysconf(_SC_PAGESIZE); >> jlong pages = sysconf(_SC_PHYS_PAGES); >> return pages * page_size; >> >> >> fixes the test issue on x86 (32 bit). As this is an issue with the upstream patch, I suggest to file an upstream bug to get it fixed as we'll likely have missed the issue on later JDKs (no testing happens on x86 AFAIK). > > Note that with an instrumented JDK I was able to observe the following (when the test fails): > > > systemMemory == -1308622848 > containerMemory == 104857600 > Metrics.getMemoryLimit() == -1 > > > I.e. we were getting a negative host memory value. Thanks for working on this! I guess without the explicit intermediate variables some kind of integer promotion/demotion is going on and there's an overflow on 32 bit? I'll raise the upstream bug, thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 14:53:21 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 14:53:21 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 14:48:38 GMT, Jonathan Dowland wrote: >> Note that with an instrumented JDK I was able to observe the following (when the test fails): >> >> >> systemMemory == -1308622848 >> containerMemory == 104857600 >> Metrics.getMemoryLimit() == -1 >> >> >> I.e. we were getting a negative host memory value. > > Thanks for working on this! I guess without the explicit intermediate variables some kind of integer promotion/demotion is going on and there's an overflow on 32 bit? > > I'll raise the upstream bug, thanks! I wonder what the behaviour is on ARM32. I don't know whether we are testing that, whether it's explicitly supported for jdk8u or not, or by who. I've been wondering that since the reports of problems with non-static member initialization in another backport. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 15:00:29 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 15:00:29 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 14:50:36 GMT, Jonathan Dowland wrote: >> Thanks for working on this! I guess without the explicit intermediate variables some kind of integer promotion/demotion is going on and there's an overflow on 32 bit? >> >> I'll raise the upstream bug, thanks! > > I wonder what the behaviour is on ARM32. I don't know whether we are testing that, whether it's explicitly supported for jdk8u or not, or by who. I've been wondering that since the reports of problems with non-static member initialization in another backport. Filed https://bugs.openjdk.org/browse/JDK-8300119 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 15:00:30 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 15:00:30 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 14:57:17 GMT, Jonathan Dowland wrote: >> I wonder what the behaviour is on ARM32. I don't know whether we are testing that, whether it's explicitly supported for jdk8u or not, or by who. I've been wondering that since the reports of problems with non-static member initialization in another backport. > > Filed https://bugs.openjdk.org/browse/JDK-8300119 I am happy to raise the upstream patch, or do you want to do it? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From sgehwolf at openjdk.org Fri Jan 13 15:18:05 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 13 Jan 2023 15:18:05 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: <1qWrca5qZnC1I1AeSK4DI0ile7E_Qtc2mt1osz0eLJ4=.09a0906d-7857-4bc9-8719-71972d2bef6d@github.com> Message-ID: On Fri, 13 Jan 2023 14:57:43 GMT, Jonathan Dowland wrote: >> Filed https://bugs.openjdk.org/browse/JDK-8300119 > > I am happy to raise the upstream patch, or do you want to do it? Feel free to go ahead and post a patch for [JDK-8300119](https://bugs.openjdk.org/browse/JDK-8300119). Thanks! In this backport we could do `/issue add JDK-8300119` if you ask me. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 16:37:23 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 16:37:23 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. > Feel free to go ahead and post a patch for [JDK-8300119](https://bugs.openjdk.org/browse/JDK-8300119). Thanks! In this backport we could do /issue add JDK-8300119 if you ask me. OK thanks. Makes sense ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 16:44:02 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 16:44:02 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision: Use explicit intermediary variables to avoid overflow on 32bit Thanks Severin Gehwolf for spotting and correcting. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/220/files - new: https://git.openjdk.org/jdk8u-dev/pull/220/files/589c5a51..4146ef2d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=220&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=220&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/220.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/220/head:pull/220 PR: https://git.openjdk.org/jdk8u-dev/pull/220 From sgehwolf at openjdk.org Fri Jan 13 17:23:20 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 13 Jan 2023 17:23:20 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: <4Be_8D1GMKGXJynZz8lau_WtKJvcUPDHGpqXdSOI480=.fe4261ad-c1b0-4d26-b177-326b3cc994e3@github.com> On Fri, 13 Jan 2023 16:34:24 GMT, Jonathan Dowland wrote: >> This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. >> >> It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. >> >> the edited test passes for me. > >> Feel free to go ahead and post a patch for [JDK-8300119](https://bugs.openjdk.org/browse/JDK-8300119). Thanks! In this backport we could do /issue add JDK-8300119 if you ask me. > > OK thanks. Makes sense @jmtd Note that we need to have [JDK-8300119](https://bugs.openjdk.org/browse/JDK-8300119) fixed in jdk head before we can integrate this (it would be bad if it were resolved in a backport first). We can follow up with 17 and 11 backports later, but head would have to be in. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Fri Jan 13 18:36:22 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 13 Jan 2023 18:36:22 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: <4Be_8D1GMKGXJynZz8lau_WtKJvcUPDHGpqXdSOI480=.fe4261ad-c1b0-4d26-b177-326b3cc994e3@github.com> References: <4Be_8D1GMKGXJynZz8lau_WtKJvcUPDHGpqXdSOI480=.fe4261ad-c1b0-4d26-b177-326b3cc994e3@github.com> Message-ID: <-304F9It7TpA5nN3J39LId0A0_cDz898eRlW1oEEVXE=.c6377049-4272-4973-b8f3-faa73a7401d0@github.com> On Fri, 13 Jan 2023 17:20:11 GMT, Severin Gehwolf wrote: > Note that we need to have [JDK-8300119](https://bugs.openjdk.org/browse/JDK-8300119) fixed in jdk head before we can integrate this understood. I?m refreshing my upstream build toolchain (and going to try setting up a 32 bit compiler for testing this) before I raise the upstream PR. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From serb at openjdk.org Sat Jan 14 04:20:19 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 14 Jan 2023 04:20:19 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 One of the comment in the JDK-8182577 mentioned that that test works fine in jdk8 and failed since jdk9. So that was a regression, possibly caused by the change you requested to backport or maybe some other. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/212 From duke at openjdk.org Mon Jan 16 13:04:14 2023 From: duke at openjdk.org (ktakakuri) Date: Mon, 16 Jan 2023 13:04:14 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 DefaultButtonModelCrashTest passed even after applying this backport. Is there any proof needed? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/212 From sgehwolf at openjdk.org Mon Jan 16 15:14:17 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 16 Jan 2023 15:14:17 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 12:32:05 GMT, Jonathan Dowland wrote: > This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. > > Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. One test related issue, looks good otherwise. jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 368: > 366: assertEquals("/", cpuSetInfo.getMountRoot()); > 367: // Ensure controllers at /sys/fs/cgroup will be used > 368: String[] ctrlNames = new String[] { "memory", "cpu", "cpuacct", "blkio", "pids" }; The `pids` controller is not present in 8u ([JDK-8266490](https://bugs.openjdk.org/browse/JDK-8266490)). This results in a test failure (NPE). Please remove it. ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/221 From duke at openjdk.org Tue Jan 17 08:06:16 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Tue, 17 Jan 2023 08:06:16 GMT Subject: [jdk8u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 11:30:35 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK8u. This fix cannot be applied cleanly. > - jdk8u contains only 1 test fixed in JDK-8283606 > (hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java) > - jdk8u contains 2 tests fixed in JDK-8299383 (backported to jdk11u) > (langtools/test/tools/javadoc/6964914/TestStdDoclet.java, and > langtools/test/tools/javadoc/6964914/TestUserDoclet.java) > - Need to add more tests that are removed in latest version and have same problem. > (langtools/test/tools/javah/T6893943.java) > > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > Would you plese review this fix? > > Thank you. Could someone review this PR? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/223 From duke at openjdk.org Tue Jan 17 09:21:22 2023 From: duke at openjdk.org (duke) Date: Tue, 17 Jan 2023 09:21:22 GMT Subject: [jdk8u-dev] Withdrawn: 8209052: Low contrast in docs/api/constant-values.html In-Reply-To: References: Message-ID: On Thu, 25 Aug 2022 07:48:19 GMT, psoujany wrote: > Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8. > Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/114 From lzhai at openjdk.org Tue Jan 17 15:43:58 2023 From: lzhai at openjdk.org (Leslie Zhai) Date: Tue, 17 Jan 2023 15:43:58 GMT Subject: [jdk8u-dev] Integrated: 8203485: [freetype] text rotated on 180 degrees is too narrow In-Reply-To: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> References: <2tCemlFksSCt1w0KKdB2YwnPbun9-i-kRRzaNjT02s0=.08ac882a-833e-4293-89dd-6aa568fd28cf@github.com> Message-ID: On Mon, 12 Dec 2022 00:53:06 GMT, Leslie Zhai wrote: > Hi, > > java/awt/Graphics2D/DrawString/RotTransText.java fail: > > > STDERR: > java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064 > at RotTransText.testIt(RotTransText.java:102) > at RotTransText.main(RotTransText.java:41) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > > > And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue. > > The patch applies clean except manually change the source file path: > > * jdk/src/share/native/sun/font/freetypeScaler.c > * jdk/test/java/awt/font/Rotate/RotatedTextTest.java > > Tested jtreg tier1~3 for fastdebug/release. > > Thanks, > Leslie Zhai This pull request has now been integrated. Changeset: 014f21f0 Author: Leslie Zhai Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/014f21f0232b135c978774b8f256edad035ada00 Stats: 143 lines in 2 files changed: 140 ins; 0 del; 3 mod 8203485: [freetype] text rotated on 180 degrees is too narrow Reviewed-by: serb Backport-of: db67279f08b2db148958a4faafd19a0d50ff8742 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/208 From andrew at openjdk.org Wed Jan 18 00:43:51 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 00:43:51 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge `8u362-b08` to 8u-dev ------------- Commit messages: - Merge jdk8u:master - 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR - 8296239: ISO 4217 Amendment 174 Update - 8294307: ISO 4217 Amendment 173 Update - 8289549: ISO 4217 Amendment 172 Update - 8283277: ISO 4217 Amendment 171 Update - 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error - 8295687: Better BMP bounds - 8293742: Better Banking of Sounds - 8293734: Improve BMP image handling - ... and 12 more: https://git.openjdk.org/jdk8u-dev/compare/014f21f0...290fd3de The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/230/files Stats: 3470 lines in 83 files changed: 1571 ins; 1504 del; 395 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/230.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/230/head:pull/230 PR: https://git.openjdk.org/jdk8u-dev/pull/230 From rmarchenko at openjdk.org Wed Jan 18 07:29:46 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 07:29:46 GMT Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2] In-Reply-To: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> Message-ID: > Actually clean backport. > > JDK8 has the same issue with processing host names for SNI. It'd be good to keep JDK8 up to date with the upstream. No risks. > > There were 2 conflicts with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` added and moved to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` added and moved to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs > > - #206 > - #207 Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision: Fixed strings format ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/205/files - new: https://git.openjdk.org/jdk8u-dev/pull/205/files/84cd2b55..08f949b2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=205&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=205&range=00-01 Stats: 213 lines in 1 file changed: 63 ins; 66 del; 84 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/205.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/205/head:pull/205 PR: https://git.openjdk.org/jdk8u-dev/pull/205 From rmarchenko at openjdk.org Wed Jan 18 07:34:39 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 07:34:39 GMT Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2] In-Reply-To: References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> Message-ID: <54UG9gPNrnKc35ahXJBel4dAWp0HaLTQR39ogBPn_ZE=.da7dd633-2ecb-4268-8c20-798b9ee6ee54@github.com> On Wed, 18 Jan 2023 07:29:46 GMT, Roman Marchenko wrote: >> _Almost_ clean backport. >> >> JDK8 has the same issue with processing host names for SNI. It'd be good to keep JDK8 up to date with the upstream. No risks. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` added and moved to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` added and moved to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> And the original changes use JDK17 strings in `SSLExampleCert.java`, so it was adapted for JDK8 withthe additional commit as it was done for JDK11 backport. >> >> Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs >> >> - #206 >> - #207 > > Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision: > > Fixed strings format The original changes use JDK17 strings in `SSLExampleCert.java`, so it was adapted for JDK8 withthe additional commit as it was done for JDK11 backport. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/205 From rmarchenko at openjdk.org Wed Jan 18 07:56:18 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 07:56:18 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: References: Message-ID: > Almost clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Fixed strings format - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/206/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=206&range=01 Stats: 52 lines in 2 files changed: 26 ins; 1 del; 25 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/206/head:pull/206 PR: https://git.openjdk.org/jdk8u-dev/pull/206 From rmarchenko at openjdk.org Wed Jan 18 07:59:10 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 07:59:10 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2] In-Reply-To: References: Message-ID: <_NqVPFbnU0VKxNH-spGQdVm5Y_czQx8gvFIi8pYJzBk=.c8cce3ad-029a-4d61-9d07-83e379f45bc4@github.com> > Actually clean backport. Test files changed only. > > There were 2 conflicts with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > Please note that this PR is a part of dependant PR chain > Prev PRs: > - #205 > - #206 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/207/files - new: https://git.openjdk.org/jdk8u-dev/pull/207/files/7781cea9..7781cea9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207 PR: https://git.openjdk.org/jdk8u-dev/pull/207 From rmarchenko at openjdk.org Wed Jan 18 07:56:20 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 07:56:20 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 09:48:57 GMT, Roman Marchenko wrote: > Almost clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. Force-pushed to keep the commit history clean to make reviewing easier. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/206 From rmarchenko at openjdk.org Wed Jan 18 08:17:37 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:17:37 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v3] In-Reply-To: References: Message-ID: > Almost clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 Roman Marchenko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fixed strings format ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/206/files - new: https://git.openjdk.org/jdk8u-dev/pull/206/files/67036c66..6860520f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=206&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=206&range=01-02 Stats: 148 lines in 1 file changed: 4 ins; 1 del; 143 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/206/head:pull/206 PR: https://git.openjdk.org/jdk8u-dev/pull/206 From rmarchenko at openjdk.org Wed Jan 18 08:17:39 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:17:39 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 07:56:18 GMT, Roman Marchenko wrote: >> Almost clean backport. Test files changed only. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. >> >> Please note that this PR is a part of dependant PR chain >> >> - Prev PR #205 >> - Next PR #207 > > Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Fixed strings format > - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. Force-pushed to keep the commit history clean to make reviewing easier. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/206 From rmarchenko at openjdk.org Wed Jan 18 08:44:28 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:44:28 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3] In-Reply-To: References: Message-ID: > Actually clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. > > Please note that this PR is a part of dependant PR chain > Prev PRs: > - #205 > - #206 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Fixed strings format and hosts file substitution - Fixed tests for JDK8 - Fixed strings format - Backport 268fa693188b685de6289927ee5a1e99473a50f6 - Fixed strings format - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e - Backport 268fa693188b685de6289927ee5a1e99473a50f6 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/207/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=02 Stats: 247 lines in 2 files changed: 58 ins; 2 del; 187 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207 PR: https://git.openjdk.org/jdk8u-dev/pull/207 From rmarchenko at openjdk.org Wed Jan 18 08:48:57 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:48:57 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v4] In-Reply-To: References: Message-ID: > Actually clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. > > Please note that this PR is a part of dependant PR chain > Prev PRs: > - #205 > - #206 Roman Marchenko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fixed strings format and hosts file substitution ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/207/files - new: https://git.openjdk.org/jdk8u-dev/pull/207/files/58e3086a..491b6b93 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207 PR: https://git.openjdk.org/jdk8u-dev/pull/207 From rmarchenko at openjdk.org Wed Jan 18 08:51:38 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:51:38 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v4] In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 08:48:57 GMT, Roman Marchenko wrote: >> Actually clean backport. Test files changed only. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. >> >> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. >> >> Please note that this PR is a part of dependant PR chain >> Prev PRs: >> - #205 >> - #206 > > Roman Marchenko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Fixed strings format and hosts file substitution @gnu-andrew Could you also review this, please? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/207 From rmarchenko at openjdk.org Wed Jan 18 08:48:58 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 18 Jan 2023 08:48:58 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2] In-Reply-To: <_NqVPFbnU0VKxNH-spGQdVm5Y_czQx8gvFIi8pYJzBk=.c8cce3ad-029a-4d61-9d07-83e379f45bc4@github.com> References: <_NqVPFbnU0VKxNH-spGQdVm5Y_czQx8gvFIi8pYJzBk=.c8cce3ad-029a-4d61-9d07-83e379f45bc4@github.com> Message-ID: On Wed, 18 Jan 2023 07:59:10 GMT, Roman Marchenko wrote: >> Actually clean backport. Test files changed only. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. >> >> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. >> >> Please note that this PR is a part of dependant PR chain >> Prev PRs: >> - #205 >> - #206 > > Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. Force-pushed to keep the commit history clean to make reviewing easier. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/207 From dongbohe at openjdk.org Wed Jan 18 09:30:19 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Wed, 18 Jan 2023 09:30:19 GMT Subject: [jdk8u-dev] RFR: 8185736: missing default exception handler in calls to rethrow_Stub Message-ID: Hi, I would like to backport this patch to fix missing of default exception handler in catch table produced by C2. Patch apply cleanly, worked correctly after patch. Testing: Performed hotspot jtreg test on linux x86-64 platforms with -XX:-TieredCompilation -Xcomp options. ------------- Commit messages: - Backport b97f668af3f55c0d67cdd7a4a191bd81cdc4aa78 Changes: https://git.openjdk.org/jdk8u-dev/pull/231/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=231&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8185736 Stats: 10 lines in 2 files changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/231.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/231/head:pull/231 PR: https://git.openjdk.org/jdk8u-dev/pull/231 From sgehwolf at openjdk.org Wed Jan 18 09:38:28 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 18 Jan 2023 09:38:28 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller In-Reply-To: References: Message-ID: <6xmLftkwDGxaNLFO4rHcEAgLdmumSC6RlCCnaWfc3ME=.58ed20bb-ee5f-4938-b3fa-7f4114a4e9b6@github.com> On Tue, 20 Dec 2022 18:01:35 GMT, Severin Gehwolf wrote: > Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. > > Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). Anyone willing to review this? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Wed Jan 18 10:06:41 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 18 Jan 2023 10:06:41 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 00:38:44 GMT, Andrew John Hughes wrote: > Merge `8u362-b08` to 8u-dev Merge of `jdk8u362-b09` over `jdk8u362-b08`? Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/230 From sgehwolf at openjdk.org Wed Jan 18 15:00:01 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 18 Jan 2023 15:00:01 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:20:47 GMT, Severin Gehwolf wrote: > Clean backport. Only path differences. Give me some time please, bot. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/219 From sgehwolf at openjdk.org Wed Jan 18 15:16:58 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 18 Jan 2023 15:16:58 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 10:04:06 GMT, Severin Gehwolf wrote: > Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance? @stooke tells me that we need this one to fix it: https://github.com/openjdk/jdk8u/commit/36321be7840c8e044340b8c162a75dce3ae7698f @gnu-andrew Any thoughts why that isn't part of the merge? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/230 From sgehwolf at openjdk.org Wed Jan 18 15:19:31 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 18 Jan 2023 15:19:31 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 00:38:44 GMT, Andrew John Hughes wrote: > Merge `8u362-b08` to 8u-dev https://github.com/openjdk/jdk8u/compare/jdk8u362-b08...jdk8u362-b09?expand=1 suggests it's part of the `jdk8u362-b09` merge :) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/230 From andrew at openjdk.org Wed Jan 18 15:50:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 15:50:30 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 10:04:06 GMT, Severin Gehwolf wrote: > Merge of `jdk8u362-b09` over `jdk8u362-b08`? > > Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance? Yeah, failure was expected. I wanted to see if GHA would have caught it if it had been public, so only merged b08. Also, I noticed I used the wrong ID on the commit in jdk8u so will fix that in the jdk8u-dev version, so there is a least one version with the right ID. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/230 From andrew at openjdk.org Wed Jan 18 15:50:32 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 15:50:32 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 00:38:44 GMT, Andrew John Hughes wrote: > Merge `8u362-b08` to 8u-dev This pull request has now been integrated. Changeset: ddb9a5c4 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/ddb9a5c4625839bdc985ed8d84d216626ef6db55 Stats: 3470 lines in 83 files changed: 1571 ins; 1504 del; 395 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/230 From andrew at openjdk.org Wed Jan 18 16:11:25 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 16:11:25 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge of `jdk8u362-b09`/`jdk8u362-ga` ------------- Commit messages: - Merge - 8300178: JDK-8288516 causes build failure on Windows + VS2010 - 8300225: JDK-8288516 causes build failure on Windows + VS2010 - Merge - 8300178: JDK-8286496 causes build failure on older GCC The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/232/files Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/232.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/232/head:pull/232 PR: https://git.openjdk.org/jdk8u-dev/pull/232 From andrew at openjdk.org Wed Jan 18 17:41:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 17:41:29 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 16:06:36 GMT, Andrew John Hughes wrote: > Merge of `jdk8u362-b09`/`jdk8u362-ga` Windows x86 build failure this time is only the release build failing to download VS2010. Debug build passed. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/232 From andrew at openjdk.org Wed Jan 18 17:41:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 17:41:30 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 16:06:36 GMT, Andrew John Hughes wrote: > Merge of `jdk8u362-b09`/`jdk8u362-ga` This pull request has now been integrated. Changeset: da57ed1b Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/da57ed1b0d541803b5e4c0237449b86c9c26e342 Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/232 From serb at openjdk.org Wed Jan 18 18:34:30 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 18 Jan 2023 18:34:30 GMT Subject: [jdk8u-dev] Integrated: 8300014: Some backports placed the tests in the wrong location In-Reply-To: References: Message-ID: On Thu, 12 Jan 2023 03:52:53 GMT, Sergey Bylokhov wrote: > The test added [here](https://github.com/openjdk/jdk8u-dev/commit/700f182cae67101bc5905105b4d45b2449ec3df0) is moved from the "jdk/test/jdk/java/awt/print/" to the "jdk/test/java/awt/print/". > > The empty file added [here](https://github.com/openjdk/jdk8u-dev/commit/70d7bd18c82ecd56efc676909eec4480e4feaa6f) deleted. This pull request has now been integrated. Changeset: a318e48e Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/a318e48e205acd2e15c50afb9c70c4106ed72463 Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod 8300014: Some backports placed the tests in the wrong location Reviewed-by: sgehwolf, phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/229 From andrew at openjdk.org Wed Jan 18 20:50:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Jan 2023 20:50:40 GMT Subject: [jdk8u-dev] RFR: 8300014: Some backports placed the tests in the wrong location In-Reply-To: References: Message-ID: <51CXHKgU5GMr_5xKCMWzwivt9kXqcRg3pWUmLdh3W30=.5843b443-0862-4fd9-8bea-6abfa721ac60@github.com> On Thu, 12 Jan 2023 03:52:53 GMT, Sergey Bylokhov wrote: > The test added [here](https://github.com/openjdk/jdk8u-dev/commit/700f182cae67101bc5905105b4d45b2449ec3df0) is moved from the "jdk/test/jdk/java/awt/print/" to the "jdk/test/java/awt/print/". > > The empty file added [here](https://github.com/openjdk/jdk8u-dev/commit/70d7bd18c82ecd56efc676909eec4480e4feaa6f) deleted. Thanks for fixing the printing one. I remember spotting that back in the days when we were still using Mercurial and just never got round to fixing it. The whole `test` structure in 8u definitely needs some TLC! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/229 From phh at openjdk.org Thu Jan 19 00:02:36 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 19 Jan 2023 00:02:36 GMT Subject: [jdk8u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled [v2] In-Reply-To: <54UG9gPNrnKc35ahXJBel4dAWp0HaLTQR39ogBPn_ZE=.da7dd633-2ecb-4268-8c20-798b9ee6ee54@github.com> References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> <54UG9gPNrnKc35ahXJBel4dAWp0HaLTQR39ogBPn_ZE=.da7dd633-2ecb-4268-8c20-798b9ee6ee54@github.com> Message-ID: On Wed, 18 Jan 2023 07:31:14 GMT, Roman Marchenko wrote: >> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixed strings format > > The original changes use JDK17 strings in `SSLExampleCert.java`, so it was adapted for JDK8 withthe additional commit as it was done for JDK11 backport. > > I will update the related PRs accordingly. Pre-submit test failures look like an infrastructure issue. @wkia, the backport has been approved, so if you add a "/integrate" comment, I or another committer can sponsor it. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/205 From phh at openjdk.org Thu Jan 19 00:03:34 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 19 Jan 2023 00:03:34 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: References: Message-ID: <6qifa4lRslr4sueM8LmlH1nO-x3TVKyyrtkVQ78S1Ls=.2a71a267-7ad9-4a3b-b434-945b3f11b027@github.com> On Wed, 18 Jan 2023 08:14:20 GMT, Roman Marchenko wrote: >> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Force-pushed to keep the commit history clean to make reviewing easier. Pre-submit test failures look like an infrastructure issue. @wkia, the backport has been approved, so if you add a "/integrate" comment, I or another committer can sponsor it. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/206 From gnu.andrew at redhat.com Thu Jan 19 01:59:08 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 19 Jan 2023 01:59:08 +0000 Subject: OpenJDK 8u362 Released Message-ID: We are pleased to announce the release of OpenJDK 8u362. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b09.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b09.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 5d832213502d17ee0a4dd70779cabc811a8643ab2fc780d5cd24b6612f07ab93 openjdk8u362-b09.tar.xz 7cba773ebf1fe68946cc6a9cf837f36ab795e4529f4915a68abea4d1955ca81f openjdk8u362-b09.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u362-b09.sha256 New in release OpenJDK 8u362 (2023-01-17): =========================================== Live versions of these release notes can be found at: * https://bit.ly/openjdk8u362 * https://builds.shipilev.net/backports-monitor/release-notes-openjdk8u362.html * CVEs - CVE-2023-21830 - CVE-2023-21843 * Security fixes - JDK-8285021: Improve CORBA communication - JDK-8286496: Improve Thread labels - JDK-8288516: Enhance font creation - JDK-8289350: Better media supports - JDK-8293554: Enhanced DH Key Exchanges - JDK-8293598: Enhance InetAddress address handling - JDK-8293717: Objective view of ObjectView - JDK-8293734: Improve BMP image handling - JDK-8293742: Better Banking of Sounds - JDK-8295687: Better BMP bounds * Other changes - JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods - JDK-7124218: [TEST_BUG] [macosx] Space should select cell in the JTable - JDK-8054066: com/sun/jdi/DoubleAgentTest.java fails with timeout - JDK-8067941: [TESTBUG] Fix tests for OS with 64K page size. - JDK-8071530: Update OS detection code to reflect Windows 10 version change - JDK-8073464: GC workers do not have thread names - JDK-8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only - JDK-8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails - JDK-8148005: One byte may be corrupted by get_datetime_string() - JDK-8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java - JDK-8159720: Failure of C2 compilation with tiered prevents some C1 compilations - JDK-8195607: sun/security/pkcs11/Secmod/TestNssDbSqlite.java failed with "NSS initialization failed" on NSS 3.34.1 - JDK-8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp - JDK-8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mems - JDK-8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64 - JDK-8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 - JDK-8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS - JDK-8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows - JDK-8253702: BigSur version number reported as 10.16, should be 11.nn - JDK-8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI() - JDK-8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport - JDK-8269039: Disable SHA-1 Signed JARs - JDK-8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 - JDK-8270344: Session resumption errors - JDK-8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity - JDK-8273176: handle latest VS2019 in abstract_vm_version - JDK-8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening - JDK-8274840: Update OS detection code to recognize Windows 11 - JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled - JDK-8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR - JDK-8283277: ISO 4217 Amendment 171 Update - JDK-8283903: GetContainerCpuLoad does not return the correct result in share mode - JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer - JDK-8284622: Update versions of some Github Actions used in JDK workflow - JDK-8286582: Build fails on macos aarch64 when using --with-zlib=bundled - JDK-8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041) - JDK-8289549: ISO 4217 Amendment 172 Update - JDK-8292762: Remove .jcheck directories from jdk8u subcomponents - JDK-8293181: Bump update version of OpenJDK: 8u362 - JDK-8293461: Add a test for JDK-8290832 - JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening - JDK-8294307: ISO 4217 Amendment 173 Update - JDK-8294357: (tz) Update Timezone Data to 2022d - JDK-8294863: Enable partial tier1 testing in GHA for JDK8 - JDK-8295164: JDK 8 jdi tests should not use tasklist command on Windows - JDK-8295173: (tz) Update Timezone Data to 2022e - JDK-8295288: Some vm_flags tests associate with a wrong BugID - JDK-8295714: GHA ::set-output is deprecated and will be removed - JDK-8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error - JDK-8295915: Problemlist compiler/rtm failures specific to 8u - JDK-8295950: Enable langtools/tier1 in GHA for 8u - JDK-8296108: (tz) Update Timezone Data to 2022f - JDK-8296239: ISO 4217 Amendment 174 Update - JDK-8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u - JDK-8296715: CLDR v42 update for tzdata 2022f - JDK-8296959: Fix hotspot shell tests of 8u on multilib systems - JDK-8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u - JDK-8297804: (tz) Update Timezone Data to 2022g - JDK-8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR - JDK-8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java - JDK-8300178: JDK-8286496 causes build failure on older GCC - JDK-8300225: JDK-8288516 causes build failure on Windows + VS2010 Notes on individual issues: =========================== client-libs/javax.imageio: JDK-8295687: Better BMP bounds ============================== Loading a linked ICC profile within a BMP image is now disabled by default. To re-enable it, set the new system property `sun.imageio.bmp.enabledLinkedProfiles` to `true`. This new property replaces the old property, `sun.imageio.plugins.bmp.disableLinkedProfiles`. client-libs/javax.sound: JDK-8293742: Better Banking of Sounds ===================================== Previously, the SoundbankReader implementation, `com.sun.media.sound.JARSoundbankReader`, would download a JAR soundbank from a URL. This behaviour is now disabled by default. To re-enable it, set the new system property `jdk.sound.jarsoundbank` to `true`. hotspot/runtime: JDK-8274840: Release Now Recognises Windows 11 ============================================== This release now correctly sets the `os.name` property to `Windows 11`, as would be expected. other-libs/corba:idl: JDK-8285021: Improve CORBA communication ======================================== The JDK's CORBA implementation now refuses by default to deserialize objects, unless they have the "IOR:" prefix. The previous behaviour can be re-enabled by setting the new property `com.sun.CORBA.ORBAllowDeserializeObject` to `true`. security-libs/java.security: JDK-8269039: Disabled SHA-1 Signed JARs ======================================= JARs signed with SHA-1 algorithms are now restricted by default and treated as if they were unsigned. This applies to the algorithms used to digest, sign, and optionally timestamp the JAR. It also applies to the signature and digest algorithms of the certificates in the certificate chain of the code signer and the Timestamp Authority, and any CRLs or OCSP responses that are used to verify if those certificates have been revoked. These restrictions also apply to signed JCE providers. To reduce the compatibility risk for JARs that have been previously timestamped, there is one exception to this policy: - Any JAR signed with SHA-1 algorithms and timestamped prior to January 01, 2019 will not be restricted. This exception may be removed in a future JDK release. To determine if your signed JARs are affected by this change, run: $ jarsigner -verify -verbose -certs` on the signed JAR, and look for instances of "SHA1" or "SHA-1" and "disabled" and a warning that the JAR will be treated as unsigned in the output. For example: Signed by "CN="Signer"" Digest algorithm: SHA-1 (disabled) Signature algorithm: SHA1withRSA (disabled), 2048-bit key WARNING: The jar will be treated as unsigned, because it is signed with a weak algorithm that is now disabled by the security property: jdk.jar.disabledAlgorithms=MD2, MD5, RSA keySize < 1024, DSA keySize < 1024, SHA1 denyAfter 2019-01-01 JARs affected by these new restrictions should be replaced or re-signed with stronger algorithms. Users can, *at their own risk*, remove these restrictions by modifying the `java.security` configuration file (or override it by using the `java.security.properties` system property) and removing "SHA1 usage SignedJAR & denyAfter 2019-01-01" from the `jdk.certpath.disabledAlgorithms` security property and "SHA1 denyAfter 2019-01-01" from the `jdk.jar.disabledAlgorithms` security property. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From t.glaser at tarent.de Thu Jan 19 02:50:22 2023 From: t.glaser at tarent.de (Thorsten Glaser) Date: Thu, 19 Jan 2023 03:50:22 +0100 (CET) Subject: OpenJDK 8u362 Released In-Reply-To: References: Message-ID: On Thu, 19 Jan 2023, Andrew Hughes wrote: >to digest, sign, and optionally timestamp the JAR. It also applies to >the signature and digest algorithms of the certificates in the >certificate chain of the code signer and the Timestamp Authority, and Does this also apply to the root certificates in that chain? I?m asking because many root certificates? self signatures use SHA-1 signatures, but the root certificates? signatures are not relevant to the verification process as they are available in their entirety locally, so their signatures (usually self, but possibly cross as well) are traditionally excluded from these new restrictions as long as the entire root certificate is available. A random (valid) example from a CA bundle I have expanded at hand: C=US, O=thawte, Inc., OU=Certification Services Division, OU=(c) 2006 thawte, Inc. - For authorized use only, CN=thawte Primary Root CA bye, //mirabilos -- Infrastrukturexperte ? tarent solutions GmbH Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941 Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg **************************************************** /?\ The UTF-8 Ribbon ??? Campaign against Mit dem tarent-Newsletter nichts mehr verpassen: ??? HTML eMail! Also, https://www.tarent.de/newsletter ??? header encryption! **************************************************** From jvanek at openjdk.org Thu Jan 19 12:05:24 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 12:05:24 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions Message-ID: Reviewed-by: mgronlun ------------- Commit messages: - 8282947: JFR: Dump on shutdown live-locks in some conditions Changes: https://git.openjdk.org/jdk8u-dev/pull/233/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=233&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282947 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/233.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/233/head:pull/233 PR: https://git.openjdk.org/jdk8u-dev/pull/233 From jvanek at openjdk.org Thu Jan 19 12:34:17 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 12:34:17 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v2] In-Reply-To: References: Message-ID: <-ohsbowWCoSBGpRCrLHOMjgVascXMVKBCTbnZOwmMv8=.47cde712-57fa-4649-bab2-2e16c3b53f20@github.com> > Reviewed-by: mgronlun Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8282947: JFR: Dump on shutdown live-locks in some conditions Reviewed-by: mgronlun ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/233/files - new: https://git.openjdk.org/jdk8u-dev/pull/233/files/06c56f35..d20af9f6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=233&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=233&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/233.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/233/head:pull/233 PR: https://git.openjdk.org/jdk8u-dev/pull/233 From jvanek at openjdk.org Thu Jan 19 12:37:24 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 12:37:24 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v2] In-Reply-To: <-ohsbowWCoSBGpRCrLHOMjgVascXMVKBCTbnZOwmMv8=.47cde712-57fa-4649-bab2-2e16c3b53f20@github.com> References: <-ohsbowWCoSBGpRCrLHOMjgVascXMVKBCTbnZOwmMv8=.47cde712-57fa-4649-bab2-2e16c3b53f20@github.com> Message-ID: On Thu, 19 Jan 2023 12:34:17 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8282947: JFR: Dump on shutdown live-locks in some conditions > > Reviewed-by: mgronlun closing to pick up freshly enabled GithubActions ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/233 From jvanek at openjdk.org Thu Jan 19 12:37:27 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 12:37:27 GMT Subject: [jdk8u-dev] Withdrawn: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: References: Message-ID: On Thu, 19 Jan 2023 11:58:02 GMT, Ji?? Van?k wrote: > Reviewed-by: mgronlun This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/233 From jvanek at openjdk.org Thu Jan 19 12:42:14 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 12:42:14 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions Message-ID: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Reviewed-by: mgronlun ------------- Commit messages: - 8282947: JFR: Dump on shutdown live-locks in some conditions Changes: https://git.openjdk.org/jdk8u-dev/pull/234/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282947 Stats: 66 lines in 3 files changed: 62 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234 PR: https://git.openjdk.org/jdk8u-dev/pull/234 From rmarchenko at openjdk.org Thu Jan 19 12:58:56 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 19 Jan 2023 12:58:56 GMT Subject: [jdk8u-dev] Integrated: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> References: <8cGmyej6l-EDJL3S3OPRf-JxyrImPBIR1loWvWPsa10=.3f353c2f-23b1-40db-b6d4-e277fc57cb58@github.com> Message-ID: On Fri, 9 Dec 2022 09:39:45 GMT, Roman Marchenko wrote: > _Almost_ clean backport. > > JDK8 has the same issue with processing host names for SNI. It'd be good to keep JDK8 up to date with the upstream. No risks. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` added and moved to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` added and moved to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > And the original changes use JDK17 strings in `SSLExampleCert.java`, so it was adapted for JDK8 withthe additional commit as it was done for JDK11 backport. > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs > > - #206 > - #207 This pull request has now been integrated. Changeset: 55254644 Author: Roman Marchenko Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/55254644f78cc8c67cf6b8bc46cf10676da5fe5e Stats: 613 lines in 4 files changed: 610 ins; 0 del; 3 mod 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Reviewed-by: yan, andrew Backport-of: a95ee5ada230a0177517efd3a417f319066169dd ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/205 From sgehwolf at openjdk.org Thu Jan 19 13:49:49 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 19 Jan 2023 13:49:49 GMT Subject: [jdk8u-dev] RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory [v2] In-Reply-To: References: Message-ID: On Fri, 13 Jan 2023 16:44:02 GMT, Jonathan Dowland wrote: >> This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. >> >> It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. >> >> the edited test passes for me. > > Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision: > > Use explicit intermediary variables to avoid overflow on 32bit > > Thanks Severin Gehwolf for spotting and correcting. Looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/220 From phh at openjdk.org Thu Jan 19 14:07:31 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 19 Jan 2023 14:07:31 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: On Thu, 19 Jan 2023 12:35:37 GMT, Ji?? Van?k wrote: > Reviewed-by: mgronlun Please change the PR title to "Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569". ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jdowland at openjdk.org Thu Jan 19 14:37:28 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 19 Jan 2023 14:37:28 GMT Subject: [jdk8u-dev] Integrated: 8292541: [Metrics] Reported memory limit may exceed physical machine memory In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 11:46:29 GMT, Jonathan Dowland wrote: > This is a backport of JDK-8292541 to jdk8u-dev as part of cgroups v2 support. > > It's not clean: two separate fix ups were needed for 8u which are broken out in separate commits: add the new JNI method name to a mapfile; fully qualify the use of a method name in the test. > > the edited test passes for me. This pull request has now been integrated. Changeset: 8d2f7e0c Author: Jonathan Dowland URL: https://git.openjdk.org/jdk8u-dev/commit/8d2f7e0ccb2bf6c3d5bccb35aef39236e5c157d3 Stats: 64 lines in 4 files changed: 48 ins; 9 del; 7 mod 8292541: [Metrics] Reported memory limit may exceed physical machine memory 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems Reviewed-by: sgehwolf Backport-of: 9a0d1e7ce86368cdcade713a9e220604f7d77ecf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/220 From jdowland at openjdk.org Thu Jan 19 14:45:20 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 19 Jan 2023 14:45:20 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: References: Message-ID: > This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. > > Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/221/files - new: https://git.openjdk.org/jdk8u-dev/pull/221/files/2bc0fa3b..2bc0fa3b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/221/head:pull/221 PR: https://git.openjdk.org/jdk8u-dev/pull/221 From rmarchenko at openjdk.org Thu Jan 19 15:16:48 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 19 Jan 2023 15:16:48 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v4] In-Reply-To: References: Message-ID: > Almost clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into backport-afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e - Fixed strings format - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e - Fixed strings format - Backport a95ee5ada230a0177517efd3a417f319066169dd ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/206/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=206&range=03 Stats: 203 lines in 2 files changed: 30 ins; 2 del; 171 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/206/head:pull/206 PR: https://git.openjdk.org/jdk8u-dev/pull/206 From phh at openjdk.org Thu Jan 19 15:20:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 19 Jan 2023 15:20:25 GMT Subject: [jdk8u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 08:14:20 GMT, Roman Marchenko wrote: >> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Force-pushed to keep the commit history clean to make reviewing easier. @wkia, please use "/integrate". ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/206 From rmarchenko at openjdk.org Thu Jan 19 15:44:04 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 19 Jan 2023 15:44:04 GMT Subject: [jdk8u-dev] Integrated: 8282398: EndingDotHostname.java test fails because SSL cert expired In-Reply-To: References: Message-ID: On Fri, 9 Dec 2022 09:48:57 GMT, Roman Marchenko wrote: > Almost clean backport. Test files changed only. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Please note that this PR is a part of dependant PR chain > > - Prev PR #205 > - Next PR #207 This pull request has now been integrated. Changeset: 75fd39f0 Author: Roman Marchenko Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/75fd39f05e4c090192a5eca1fbdf2b6d1993fc4a Stats: 203 lines in 2 files changed: 30 ins; 2 del; 171 mod 8282398: EndingDotHostname.java test fails because SSL cert expired Reviewed-by: yan, andrew Backport-of: afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/206 From jvanek at openjdk.org Thu Jan 19 16:39:11 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 16:39:11 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: On Thu, 19 Jan 2023 12:35:37 GMT, Ji?? Van?k wrote: > Reviewed-by: mgronlun Actually, the lib should be @library /lib / ? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Thu Jan 19 16:45:02 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 16:45:02 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v2] In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: > Reviewed-by: mgronlun Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Changed test to use @library /lib / ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/234/files - new: https://git.openjdk.org/jdk8u-dev/pull/234/files/d20af9f6..26a1c9ae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234 PR: https://git.openjdk.org/jdk8u-dev/pull/234 From rmarchenko at openjdk.org Thu Jan 19 16:53:04 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 19 Jan 2023 16:53:04 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v5] In-Reply-To: References: Message-ID: <5CB1OUe3HRJEt8KMNMZ4BGzWiHm4rBLtQP1sYg0r4tA=.8ffa3c84-a1d8-46ed-9f90-eaad96b74751@github.com> > Test files changed only. > > The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. > > Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. > > There were 2 changes with test files paths: > > - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. > - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. > > Please note that this PR is a part of dependant PR chain > Prev PRs: > - #205 > - #206 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into backport-268fa693188b685de6289927ee5a1e99473a50f6 - Fixed strings format and hosts file substitution - Backport 268fa693188b685de6289927ee5a1e99473a50f6 - Fixed strings format - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e - Fixed strings format - Backport a95ee5ada230a0177517efd3a417f319066169dd ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/207/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=207&range=04 Stats: 246 lines in 2 files changed: 58 ins; 2 del; 186 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207 PR: https://git.openjdk.org/jdk8u-dev/pull/207 From jvanek at openjdk.org Thu Jan 19 17:14:25 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 17:14:25 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v3] In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: > Reviewed-by: mgronlun Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: removed @requires vm.hasJFR ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/234/files - new: https://git.openjdk.org/jdk8u-dev/pull/234/files/26a1c9ae..eca929f5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234 PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Thu Jan 19 17:45:43 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 19 Jan 2023 17:45:43 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v3] In-Reply-To: References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: On Thu, 19 Jan 2023 17:14:25 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > removed @requires vm.hasJFR Hmm. The test fails. I need to elaborate. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From sgehwolf at openjdk.org Thu Jan 19 18:28:45 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 19 Jan 2023 18:28:45 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: References: Message-ID: <6aNvTmtJEM1D1sdHxVR1AaNDZzRCB5qk5sXT2pO0rto=.1fb20548-8dda-473a-8fc8-5ccecad22312@github.com> On Thu, 19 Jan 2023 14:45:20 GMT, Jonathan Dowland wrote: >> This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. >> >> Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. > > Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @jmtd Please rebase this onto master when you get a chance. Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/221 From jdowland at openjdk.org Fri Jan 20 10:54:15 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 20 Jan 2023 10:54:15 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3] In-Reply-To: References: Message-ID: > This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. > > Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Fix test for 8u: lib paths and buildJdkDockerImage method - 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/221/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=02 Stats: 180 lines in 6 files changed: 143 ins; 23 del; 14 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/221/head:pull/221 PR: https://git.openjdk.org/jdk8u-dev/pull/221 From jdowland at openjdk.org Fri Jan 20 10:54:20 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 20 Jan 2023 10:54:20 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: <6aNvTmtJEM1D1sdHxVR1AaNDZzRCB5qk5sXT2pO0rto=.1fb20548-8dda-473a-8fc8-5ccecad22312@github.com> References: <6aNvTmtJEM1D1sdHxVR1AaNDZzRCB5qk5sXT2pO0rto=.1fb20548-8dda-473a-8fc8-5ccecad22312@github.com> Message-ID: On Thu, 19 Jan 2023 18:25:33 GMT, Severin Gehwolf wrote: >> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: >> >> - Fix test for 8u: lib paths and buildJdkDockerImage method >> - 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts >> >> Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 >> - adjust test to scope assertNotNull >> - add Java_jdk_internal_platform_CgroupMetrics_getTotalMemorySize0 to linux mapfile >> - 8292541: [Metrics] Reported memory limit may exceed physical machine memory >> >> Backport-of: 9a0d1e7ce86368cdcade713a9e220604f7d77ecf > > @jmtd Please rebase this onto master when you get a chance. Thanks! @jerboaa: > @jmtd Please rebase this onto master when you get a chance. Thanks! Done :) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/221 From sgehwolf at openjdk.org Fri Jan 20 11:13:44 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 20 Jan 2023 11:13:44 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: References: Message-ID: On Wed, 11 Jan 2023 15:30:49 GMT, Severin Gehwolf wrote: >> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 368: > >> 366: assertEquals("/", cpuSetInfo.getMountRoot()); >> 367: // Ensure controllers at /sys/fs/cgroup will be used >> 368: String[] ctrlNames = new String[] { "memory", "cpu", "cpuacct", "blkio", "pids" }; > > The `pids` controller is not present in 8u ([JDK-8266490](https://bugs.openjdk.org/browse/JDK-8266490)). This results in a test failure (NPE). Please remove it. @jmtd This would also need fixing --^ :) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/221 From jdowland at openjdk.org Mon Jan 23 11:29:45 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 23 Jan 2023 11:29:45 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v4] In-Reply-To: References: Message-ID: > This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. > > Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision: don't check pid controller in jdk8u-dev ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/221/files - new: https://git.openjdk.org/jdk8u-dev/pull/221/files/4cdc74b5..9fd796c2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=221&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/221/head:pull/221 PR: https://git.openjdk.org/jdk8u-dev/pull/221 From jdowland at openjdk.org Mon Jan 23 11:29:46 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 23 Jan 2023 11:29:46 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: References: Message-ID: On Fri, 20 Jan 2023 11:10:53 GMT, Severin Gehwolf wrote: >> jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 368: >> >>> 366: assertEquals("/", cpuSetInfo.getMountRoot()); >>> 367: // Ensure controllers at /sys/fs/cgroup will be used >>> 368: String[] ctrlNames = new String[] { "memory", "cpu", "cpuacct", "blkio", "pids" }; >> >> The `pids` controller is not present in 8u ([JDK-8266490](https://bugs.openjdk.org/browse/JDK-8266490)). This results in a test failure (NPE). Please remove it. > > @jmtd This would also need fixing --^ :) > The pids controller is not present in 8u ([JDK-8266490](https://bugs.openjdk.org/browse/JDK-8266490)). This results in a test failure (NPE). Please remove it. Thanks for catching. Confirmed, removed, re-tested, pushed. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/221 From sgehwolf at openjdk.org Mon Jan 23 14:02:16 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 23 Jan 2023 14:02:16 GMT Subject: [jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v4] In-Reply-To: References: Message-ID: On Mon, 23 Jan 2023 11:29:45 GMT, Jonathan Dowland wrote: >> This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. >> >> Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. > > Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision: > > don't check pid controller in jdk8u-dev Looks OK now. Thanks. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/221 From jvanek at openjdk.org Mon Jan 23 15:59:03 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Jan 2023 15:59:03 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v4] In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: > Reviewed-by: mgronlun Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Avoided usage of jdk11+ Path.of(String) by File(String).toPath ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/234/files - new: https://git.openjdk.org/jdk8u-dev/pull/234/files/eca929f5..a195b668 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234 PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Mon Jan 23 16:00:52 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Jan 2023 16:00:52 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v3] In-Reply-To: References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: On Thu, 19 Jan 2023 17:14:25 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > removed @requires vm.hasJFR Hello! I had adapted the test. It sitll represents issue - fails on non patched jdk, and now correctly passes on patched jdk. Automated test is now running for both jfr group and jdk group. So far so good. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Mon Jan 23 17:07:42 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Jan 2023 17:07:42 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> Message-ID: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> > Reviewed-by: mgronlun Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Removed jdk8 incompatible -Xlog:jfr it do not affect tests behavior ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/234/files - new: https://git.openjdk.org/jdk8u-dev/pull/234/files/a195b668..39d3b246 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=234&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234 PR: https://git.openjdk.org/jdk8u-dev/pull/234 From yan at azul.com Tue Jan 24 07:08:54 2023 From: yan at azul.com (Yuri Nesterenko) Date: Tue, 24 Jan 2023 10:08:54 +0300 Subject: Result: New OpenJDK 8 Updates Committer: Alexey Pavlyutkin Message-ID: <66d88009-bdaa-6643-0bb7-8e333614e29d@azul.com> Voting for Alexey Pavlyutkin [0] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus [1], this is sufficient to approve the nomination. [0] https://mail.openjdk.org/pipermail/jdk8u-dev/2023-January/016394.html.html [1] https://openjdk.java.net/bylaws#lazy-consensus Thank you! --yan From jvanek at openjdk.org Tue Jan 24 09:54:15 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 24 Jan 2023 09:54:15 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior The pass can be visible on https://github.com/judovana/jdk-tester/actions/runs/3988734842/jobs/6840282234#step:12:187 What now? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jdowland at openjdk.org Tue Jan 24 10:44:17 2023 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 24 Jan 2023 10:44:17 GMT Subject: [jdk8u-dev] Integrated: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts In-Reply-To: References: Message-ID: On Tue, 3 Jan 2023 12:32:05 GMT, Jonathan Dowland wrote: > This is a backport of 8293540 to jdk8u-dev for cgroups v2 support. > > Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods. This pull request has now been integrated. Changeset: a5bd9018 Author: Jonathan Dowland URL: https://git.openjdk.org/jdk8u-dev/commit/a5bd9018d5671f2399272b680e83239154443b11 Stats: 180 lines in 6 files changed: 143 ins; 23 del; 14 mod 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Reviewed-by: sgehwolf Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/221 From sgehwolf at openjdk.org Tue Jan 24 10:55:11 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 24 Jan 2023 10:55:11 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Tue, 24 Jan 2023 09:51:18 GMT, Ji?? Van?k wrote: > What now? See `Contributing` section in https://wiki.openjdk.org/display/jdk8u ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Tue Jan 24 11:20:15 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 24 Jan 2023 11:20:15 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior Thank you:) Label added. All testing on my end done. Waiting for review. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From zzambers at openjdk.org Tue Jan 24 16:35:17 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 24 Jan 2023 16:35:17 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior I have tried to run jdk_jfr group on master, 3 failures are not regressions (fail both with and without changes): https://github.com/zzambers/jdk-tester/actions/runs/3997510473/jobs/6858945097#step:12:2527 Failures are: jdk/jfr/event/compiler/TestCompilerCompile.java jdk/jfr/event/sampling/TestNative.java jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Tue Jan 24 16:41:14 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 24 Jan 2023 16:41:14 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior On my local machine only the `jdk/jfr/event/sampling/TestNative.java` is failing. I had fixed it like this: https://github.com/openjdk/jdk8u-dev/pull/235 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From zzambers at openjdk.org Tue Jan 24 18:09:22 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 24 Jan 2023 18:09:22 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior > On my local machine only the `jdk/jfr/event/sampling/TestNative.java` is failing. I had fixed it like this: #235 Interesting, so these 2 seem environment/test machine speed sensitive TestCompilerCompile - timeout actually TestJcmdDumpPathToGCRoots - ? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From serb at openjdk.org Wed Jan 25 19:51:32 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 19:51:32 GMT Subject: [jdk8u-dev] RFR: 8293767: AWT test TestSinhalaChar.java has old SCCS markings Message-ID: Hi all, This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. Thanks! ------------- Commit messages: - Backport 141d5f5deec488531e410af875c781f4b70490da Changes: https://git.openjdk.org/jdk8u-dev/pull/236/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=236&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293767 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/236.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/236/head:pull/236 PR: https://git.openjdk.org/jdk8u-dev/pull/236 From phh at openjdk.org Wed Jan 25 20:54:05 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 25 Jan 2023 20:54:05 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Mon, 23 Jan 2023 17:07:42 GMT, Ji?? Van?k wrote: >> Reviewed-by: mgronlun > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Removed jdk8 incompatible -Xlog:jfr > > it do not affect tests behavior Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/234 From serb at openjdk.org Wed Jan 25 21:08:33 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 21:08:33 GMT Subject: [jdk8u-dev] RFR: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail Message-ID: Hi all, This pull request contains a backport of commit [a222aedf](https://github.com/openjdk/jdk/commit/a222aedf0fa1961e902db35cbe4145623c6af999) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajeev Chamyal on 15 Jun 2016 and was reviewed by Alexander Scherbatiy. Thanks! ------------- Commit messages: - Backport a222aedf0fa1961e902db35cbe4145623c6af999 Changes: https://git.openjdk.org/jdk8u-dev/pull/237/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=237&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159135 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/237.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/237/head:pull/237 PR: https://git.openjdk.org/jdk8u-dev/pull/237 From serb at openjdk.org Wed Jan 25 21:53:30 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 21:53:30 GMT Subject: [jdk8u-dev] RFR: 8196467: javax/swing/JInternalFrame/Test6325652.java fails Message-ID: The fix for a test issue. ------------- Commit messages: - Backport be762d7ac85910bffd7fd8e91e04d81961c35966 Changes: https://git.openjdk.org/jdk8u-dev/pull/238/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=238&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8196467 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/238.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/238/head:pull/238 PR: https://git.openjdk.org/jdk8u-dev/pull/238 From serb at openjdk.org Wed Jan 25 21:58:13 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 21:58:13 GMT Subject: [jdk8u-dev] RFR: 8293767: AWT test TestSinhalaChar.java has old SCCS markings In-Reply-To: References: Message-ID: <9uoigJy0q02jJe39wmEX1RXss6G3uL91HviuDomga6U=.30d7aac5-45a2-4440-a9f5-ddc59741ea28@github.com> On Wed, 25 Jan 2023 19:42:09 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. > Thanks! Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/236 From serb at openjdk.org Wed Jan 25 21:58:14 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 21:58:14 GMT Subject: [jdk8u-dev] RFR: 8196467: javax/swing/JInternalFrame/Test6325652.java fails In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 21:37:32 GMT, Sergey Bylokhov wrote: > The fix for a test issue. Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/238 From serb at openjdk.org Wed Jan 25 21:58:14 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 21:58:14 GMT Subject: [jdk8u-dev] RFR: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 19:54:44 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a222aedf](https://github.com/openjdk/jdk/commit/a222aedf0fa1961e902db35cbe4145623c6af999) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Rajeev Chamyal on 15 Jun 2016 and was reviewed by Alexander Scherbatiy. > Thanks! Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/237 From serb at openjdk.org Wed Jan 25 22:16:30 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 22:16:30 GMT Subject: [jdk8u-dev] RFR: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java Message-ID: Hi all, This pull request contains a backport of commit [cd8cd68e](https://github.com/openjdk/jdk/commit/cd8cd68e09370fbf0c3509deaee381417dd12533) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 28 Feb 2017 and was reviewed by Sergey Bylokhov and Alexander Scherbatiy. Thanks! ------------- Commit messages: - Backport cd8cd68e09370fbf0c3509deaee381417dd12533 Changes: https://git.openjdk.org/jdk8u-dev/pull/239/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=239&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8039888 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/239.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/239/head:pull/239 PR: https://git.openjdk.org/jdk8u-dev/pull/239 From serb at openjdk.org Wed Jan 25 22:30:47 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 22:30:47 GMT Subject: [jdk8u-dev] RFR: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 22:05:12 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cd8cd68e](https://github.com/openjdk/jdk/commit/cd8cd68e09370fbf0c3509deaee381417dd12533) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 28 Feb 2017 and was reviewed by Sergey Bylokhov and Alexander Scherbatiy. > Thanks! Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/239 From zzambers at openjdk.org Wed Jan 25 22:56:12 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 25 Jan 2023 22:56:12 GMT Subject: [jdk8u-dev] RFR: 8301122: [8u] Fix unreliable vs2010 download link Message-ID: **Problem:** Link to web.archive.org is currently used to download vs2010, since original download link for vs2010 from Microsoft is dead. Even though it usually works, download from web.archive.org fails from time to time, causing windows x86 build failures in github CI. **Fix:** Switch to more reliable download link for vs2010. Use download link used by winetricks project instead. (As they also switched away from web.archive.org link, when they faced the same problem in the past. [1]) Test code already does fingerprint check of downloaded file, so changing download link should be safe. [1] https://github.com/Winetricks/winetricks/pull/952 ------------- Commit messages: - Use more reliable download link for VS2010 Changes: https://git.openjdk.org/jdk8u-dev/pull/240/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=240&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301122 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/240.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/240/head:pull/240 PR: https://git.openjdk.org/jdk8u-dev/pull/240 From serb at openjdk.org Wed Jan 25 23:13:17 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 23:13:17 GMT Subject: [jdk8u-dev] RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Message-ID: I backport this for parity with 8u361. ------------- Commit messages: - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Changes: https://git.openjdk.org/jdk8u-dev/pull/241/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=241&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7001973 Stats: 58 lines in 1 file changed: 13 ins; 37 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/241.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/241/head:pull/241 PR: https://git.openjdk.org/jdk8u-dev/pull/241 From serb at openjdk.org Wed Jan 25 23:13:18 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 23:13:18 GMT Subject: [jdk8u-dev] RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 23:00:08 GMT, Sergey Bylokhov wrote: > I backport this for parity with 8u361. Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/241 From serb at openjdk.org Wed Jan 25 23:45:05 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 25 Jan 2023 23:45:05 GMT Subject: [jdk8u-dev] RFR: 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows Message-ID: Hi all, This pull request contains a backport of commit [b5769155](https://github.com/openjdk/jdk/commit/b5769155b4bf453d65c43921dbcae4d115f17df7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Phil Race on 20 Jun 2014 and was reviewed by Jennifer Godinez. Thanks! ------------- Commit messages: - Backport b5769155b4bf453d65c43921dbcae4d115f17df7 Changes: https://git.openjdk.org/jdk8u-dev/pull/242/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=242&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8042098 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/242.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/242/head:pull/242 PR: https://git.openjdk.org/jdk8u-dev/pull/242 From serb at openjdk.org Thu Jan 26 00:20:26 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Jan 2023 00:20:26 GMT Subject: [jdk8u-dev] RFR: 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 23:26:32 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [b5769155](https://github.com/openjdk/jdk/commit/b5769155b4bf453d65c43921dbcae4d115f17df7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Phil Race on 20 Jun 2014 and was reviewed by Jennifer Godinez. > Thanks! Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/242 From serb at openjdk.org Thu Jan 26 00:25:11 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Jan 2023 00:25:11 GMT Subject: [jdk8u-dev] RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual Message-ID: The fix for a test bug. ------------- Commit messages: - Backport 7cc3ba5f9b188e5dd298dbcde3934d08b6101032 Changes: https://git.openjdk.org/jdk8u-dev/pull/243/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=243&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239827 Stats: 156 lines in 1 file changed: 105 ins; 25 del; 26 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/243.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/243/head:pull/243 PR: https://git.openjdk.org/jdk8u-dev/pull/243 From sgehwolf at openjdk.org Thu Jan 26 09:13:09 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 26 Jan 2023 09:13:09 GMT Subject: [jdk8u-dev] RFR: 8282947: JFR: Dump on shutdown live-locks in some conditions [v5] In-Reply-To: References: <3Rf3qeaL7e7mMRDNhQgcru20k955-inB45mGP0umDKU=.14c73201-f9be-400a-b577-d7f945dbc053@github.com> <92VAzt4j_UcYnTmsHxV83VN-OJpKcWKo45bTX7mDFKI=.ceb130df-2eec-4cbf-b944-dd5d6cca311b@github.com> Message-ID: On Tue, 24 Jan 2023 16:38:46 GMT, Ji?? Van?k wrote: >> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: >> >> Removed jdk8 incompatible -Xlog:jfr >> >> it do not affect tests behavior > > On my local machine only the `jdk/jfr/event/sampling/TestNative.java` is failing. I had fixed it like this: https://github.com/openjdk/jdk8u-dev/pull/235 @judovana Please only integrate once you have approval via `jdk8u-fix-yes` on the bug. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/234 From jvanek at openjdk.org Thu Jan 26 10:05:19 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 26 Jan 2023 10:05:19 GMT Subject: [jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper Message-ID: This test was brouht in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support casses. This is adding the shell wrapper which is compiling and properly setting up the native longSleep in native shared object. This comit was tested only on linux. After this commit whole jdk_jfr group passes ------------- Commit messages: - Added multilib support - repalce == by =, mkaing older ubuntu happy - Revert "repalce [] by test, mkaing older ubuntu happy" - repalce [] by test, mkaing older ubuntu happy - Removed -o pipefail; it is not 100% trasnferable - fixed jfr/event/sampling/TestNative test Changes: https://git.openjdk.org/jdk8u-dev/pull/235/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=235&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301143 Stats: 64 lines in 2 files changed: 63 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/235.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/235/head:pull/235 PR: https://git.openjdk.org/jdk8u-dev/pull/235 From jvanek at openjdk.org Thu Jan 26 10:05:19 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 26 Jan 2023 10:05:19 GMT Subject: [jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper In-Reply-To: References: Message-ID: On Tue, 24 Jan 2023 16:12:14 GMT, Ji?? Van?k wrote: > This test was brouht in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support casses. > > This is adding the shell wrapper which is compiling and properly setting up the native longSleep in native shared object. > > This comit was tested only on linux. > After this commit whole jdk_jfr group passes Would be nice if original authors @egahlin and @mgronlun doublechekced if the test is still testing the same This do not have yet bugid. Will create and adapt as needed if this fix will prove worthy. Note, that the test is ok in jdk11 and up. Thaxn for the ==/=. Fixed now. The multilib chaneg sounds jsut like source ${JDK_TOPDIR}/hotspot/test/test_env.sh ... $gcc ...${CFLAGBITS} ... Which sounds like safe tor. Thanx a lot! As for MacOs, it should work. I can exclude the Darwin from enumerating. I do not have any mAcOs around. PAss is now visible at: https://github.com/judovana/jdk-tester/actions/runs/3998180323/jobs/6879504748#step:12:406 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/235 From zzambers at openjdk.org Thu Jan 26 10:05:20 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 26 Jan 2023 10:05:20 GMT Subject: [jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper In-Reply-To: References: Message-ID: <1gq56tAP8vOKuyBcjNKtO3nj9fni3kyZuAawsUpNq6o=.b87c3d0c-d60d-40f3-a301-564251ffe289@github.com> On Tue, 24 Jan 2023 16:12:14 GMT, Ji?? Van?k wrote: > This test was brouht in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support casses. > > This is adding the shell wrapper which is compiling and properly setting up the native longSleep in native shared object. > > This comit was tested only on linux. > After this commit whole jdk_jfr group passes Yy, shell wrapper will be necessary to make this work on JDK8. (This wrapper is inspired by [1], I think.) I have 2 remarks: MacOS testing - do we want to enable this test on MacOS? (if so, it should probably be tested there) Linux multilib - on linux there is also multilib scenario, which is a bit tricky - basically when building native test libs for 32-bit JDK running on 64-bit system, compiler flag is needed to build 32-bit test libs - for hotspot tests this case is now detected in test_env.sh file (See this PR for details [2]) - question is: should this be done in test or should there be something like test_env.sh for jdk tests as well? [1] https://github.com/openjdk/jdk8u-dev/blob/a5bd9018d5671f2399272b680e83239154443b11/jdk/test/jdk/tools/launcher/JliLaunchTest.sh [2] https://github.com/openjdk/jdk8u-dev/pull/173 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/235 From duke at openjdk.org Thu Jan 26 11:45:10 2023 From: duke at openjdk.org (ktakakuri) Date: Thu, 26 Jan 2023 11:45:10 GMT Subject: [jdk8u-dev] RFR: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Message-ID: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11. The original patch accidentally added "out", but it was removed in JDK-8276623. This PR backports 8275650 without "out". ------------- Commit messages: - Backport 32895ac60949ccceb0a3d25c73ec5e3a00c29593 Changes: https://git.openjdk.org/jdk8u-dev/pull/244/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=244&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275650 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/244.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/244/head:pull/244 PR: https://git.openjdk.org/jdk8u-dev/pull/244 From yan at openjdk.org Thu Jan 26 13:33:26 2023 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 26 Jan 2023 13:33:26 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v5] In-Reply-To: <5CB1OUe3HRJEt8KMNMZ4BGzWiHm4rBLtQP1sYg0r4tA=.8ffa3c84-a1d8-46ed-9f90-eaad96b74751@github.com> References: <5CB1OUe3HRJEt8KMNMZ4BGzWiHm4rBLtQP1sYg0r4tA=.8ffa3c84-a1d8-46ed-9f90-eaad96b74751@github.com> Message-ID: On Thu, 19 Jan 2023 16:53:04 GMT, Roman Marchenko wrote: >> Test files changed only. >> >> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. >> >> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> Please note that this PR is a part of dependant PR chain >> Prev PRs: >> - #205 >> - #206 > > Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: > > - Merge branch 'master' into backport-268fa693188b685de6289927ee5a1e99473a50f6 > - Fixed strings format and hosts file substitution > - Backport 268fa693188b685de6289927ee5a1e99473a50f6 > - Fixed strings format > - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e > - Fixed strings format > - Backport a95ee5ada230a0177517efd3a417f319066169dd Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/207 From rmarchenko at openjdk.org Thu Jan 26 13:44:24 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 26 Jan 2023 13:44:24 GMT Subject: [jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v5] In-Reply-To: <5CB1OUe3HRJEt8KMNMZ4BGzWiHm4rBLtQP1sYg0r4tA=.8ffa3c84-a1d8-46ed-9f90-eaad96b74751@github.com> References: <5CB1OUe3HRJEt8KMNMZ4BGzWiHm4rBLtQP1sYg0r4tA=.8ffa3c84-a1d8-46ed-9f90-eaad96b74751@github.com> Message-ID: <2BMsBvrrfl9Cvcjme9igxZqivAGMIATob6kVl8qhcEo=.389ba9ed-0daf-4aec-9a95-ac774c2ade1e@github.com> On Thu, 19 Jan 2023 16:53:04 GMT, Roman Marchenko wrote: >> Test files changed only. >> >> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport. >> >> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation. >> >> There were 2 changes with test files paths: >> >> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`. >> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`. >> >> Please note that this PR is a part of dependant PR chain >> Prev PRs: >> - #205 >> - #206 > > Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: > > - Merge branch 'master' into backport-268fa693188b685de6289927ee5a1e99473a50f6 > - Fixed strings format and hosts file substitution > - Backport 268fa693188b685de6289927ee5a1e99473a50f6 > - Fixed strings format > - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e > - Fixed strings format > - Backport a95ee5ada230a0177517efd3a417f319066169dd @gnu-andrew Could you re-review, please? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/207 From serb at openjdk.org Thu Jan 26 19:24:10 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Jan 2023 19:24:10 GMT Subject: [jdk8u-dev] RFR: 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error Message-ID: Hi all, This pull request contains a backport of commit [b0fddb9f](https://github.com/openjdk/jdk/commit/b0fddb9f8045cca10b4e757d8d187af7fb117405) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Manajit Halder on 29 Jan 2016 and was reviewed by Ambarish Rapte and Semyon Sadetsky. Thanks! ------------- Commit messages: - Backport b0fddb9f8045cca10b4e757d8d187af7fb117405 Changes: https://git.openjdk.org/jdk8u-dev/pull/245/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=245&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8075964 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/245.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/245/head:pull/245 PR: https://git.openjdk.org/jdk8u-dev/pull/245 From serb at openjdk.org Thu Jan 26 19:24:13 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Jan 2023 19:24:13 GMT Subject: [jdk8u-dev] RFR: 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error In-Reply-To: References: Message-ID: On Thu, 26 Jan 2023 17:23:08 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [b0fddb9f](https://github.com/openjdk/jdk/commit/b0fddb9f8045cca10b4e757d8d187af7fb117405) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Manajit Halder on 29 Jan 2016 and was reviewed by Ambarish Rapte and Semyon Sadetsky. > Thanks! Windows build issue is unrelated: >curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4 Line | 4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/245 From phh at openjdk.org Thu Jan 26 23:41:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 26 Jan 2023 23:41:25 GMT Subject: [jdk8u-dev] RFR: 8301122: [8u] Fix unreliable vs2010 download link In-Reply-To: References: Message-ID: <8WOLNHV7bL2rloBKyCqyw-N5oZ1ToArZ_pXzNQlNM1A=.fb2bed1e-6852-461b-8fc8-eab9078ef3b2@github.com> On Wed, 25 Jan 2023 22:48:24 GMT, Zdenek Zambersky wrote: > **Problem:** > Link to web.archive.org is currently used to download vs2010, since original download link for vs2010 from Microsoft is dead. Even though it usually works, download from web.archive.org fails from time to time, causing windows x86 build failures in github CI. > > **Fix:** > Switch to more reliable download link for vs2010. Use download link used by winetricks project instead. (As they also switched away from web.archive.org link, when they faced the same problem in the past. [1]) Test code already does fingerprint check of downloaded file, so changing download link should be safe. > > [1] https://github.com/Winetricks/winetricks/pull/952 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/240 From phh at openjdk.org Thu Jan 26 23:45:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 26 Jan 2023 23:45:25 GMT Subject: [jdk8u-dev] RFR: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 In-Reply-To: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> References: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> Message-ID: On Thu, 26 Jan 2023 11:37:29 GMT, ktakakuri wrote: > This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11. > The original patch accidentally added "out", but it was removed in JDK-8276623. > This PR backports 8275650 without "out". Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/244 From phh at openjdk.org Fri Jan 27 00:08:23 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 27 Jan 2023 00:08:23 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:01:35 GMT, Severin Gehwolf wrote: > Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. > > Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Fri Jan 27 09:23:27 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 09:23:27 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: References: Message-ID: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> > Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. > > Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/218/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=218&range=01 Stats: 117 lines in 3 files changed: 113 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/218.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/218/head:pull/218 PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Fri Jan 27 09:24:03 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 09:24:03 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v2] In-Reply-To: References: Message-ID: > Clean backport. Only path differences. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/219/files - new: https://git.openjdk.org/jdk8u-dev/pull/219/files/9e8ace88..9e8ace88 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=219&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=219&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/219.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/219/head:pull/219 PR: https://git.openjdk.org/jdk8u-dev/pull/219 From sgehwolf at openjdk.org Fri Jan 27 09:31:08 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 09:31:08 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v3] In-Reply-To: References: Message-ID: > Clean backport. Only path differences. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/219/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=219&range=02 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/219.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/219/head:pull/219 PR: https://git.openjdk.org/jdk8u-dev/pull/219 From sgehwolf at openjdk.org Fri Jan 27 09:31:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 09:31:24 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 00:06:02 GMT, Paul Hohensee wrote: > Lgtm. Thanks for the review @phohensee! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Fri Jan 27 09:51:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 09:51:25 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v3] In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 09:31:08 GMT, Severin Gehwolf wrote: >> Clean backport. Only path differences. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete > > Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 Windows GHA test failed due to #240 (unrelated). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/219 From sgehwolf at openjdk.org Fri Jan 27 11:09:27 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 11:09:27 GMT Subject: [jdk8u-dev] RFR: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 In-Reply-To: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> References: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> Message-ID: On Thu, 26 Jan 2023 11:37:29 GMT, ktakakuri wrote: > This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11. > The original patch accidentally added "out", but it was removed in JDK-8276623. > This PR backports 8275650 without "out". Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/244 From sgehwolf at openjdk.org Fri Jan 27 11:26:28 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 27 Jan 2023 11:26:28 GMT Subject: [jdk8u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 11:30:35 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK8u. This fix cannot be applied cleanly. > - jdk8u contains only 1 test fixed in JDK-8283606 > (hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java) > - jdk8u contains 2 tests fixed in JDK-8299383 (backported to jdk11u) > (langtools/test/tools/javadoc/6964914/TestStdDoclet.java, and > langtools/test/tools/javadoc/6964914/TestUserDoclet.java) > - Need to add more tests that are removed in latest version and have same problem. > (langtools/test/tools/javah/T6893943.java) > > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > Would you plese review this fix? > > Thank you. Looks OK to me. Bug is now approved. Feel free to integrate and I can help with sponsoring the patch. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/223 From zzambers at openjdk.org Fri Jan 27 14:05:32 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Fri, 27 Jan 2023 14:05:32 GMT Subject: [jdk8u-dev] RFR: 8301122: [8u] Fix unreliable vs2010 download link In-Reply-To: <8WOLNHV7bL2rloBKyCqyw-N5oZ1ToArZ_pXzNQlNM1A=.fb2bed1e-6852-461b-8fc8-eab9078ef3b2@github.com> References: <8WOLNHV7bL2rloBKyCqyw-N5oZ1ToArZ_pXzNQlNM1A=.fb2bed1e-6852-461b-8fc8-eab9078ef3b2@github.com> Message-ID: On Thu, 26 Jan 2023 23:39:00 GMT, Paul Hohensee wrote: >> **Problem:** >> Link to web.archive.org is currently used to download vs2010, since original download link for vs2010 from Microsoft is dead. Even though it usually works, download from web.archive.org fails from time to time, causing windows x86 build failures in github CI. >> >> **Fix:** >> Switch to more reliable download link for vs2010. Use download link used by winetricks project instead. (As they also switched away from web.archive.org link, when they faced the same problem in the past. [1]) Test code already does fingerprint check of downloaded file, so changing download link should be safe. >> >> [1] https://github.com/Winetricks/winetricks/pull/952 > > Lgtm. @phohensee @jerboaa thanks ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/240 From zzambers at openjdk.org Fri Jan 27 14:05:34 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Fri, 27 Jan 2023 14:05:34 GMT Subject: [jdk8u-dev] Integrated: 8301122: [8u] Fix unreliable vs2010 download link In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 22:48:24 GMT, Zdenek Zambersky wrote: > **Problem:** > Link to web.archive.org is currently used to download vs2010, since original download link for vs2010 from Microsoft is dead. Even though it usually works, download from web.archive.org fails from time to time, causing windows x86 build failures in github CI. > > **Fix:** > Switch to more reliable download link for vs2010. Use download link used by winetricks project instead. (As they also switched away from web.archive.org link, when they faced the same problem in the past. [1]) Test code already does fingerprint check of downloaded file, so changing download link should be safe. > > [1] https://github.com/Winetricks/winetricks/pull/952 This pull request has now been integrated. Changeset: d0cbcc51 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/d0cbcc5101f166b0469b889ef6f05b2925f0760c Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8301122: [8u] Fix unreliable vs2010 download link Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/240 From alexsch at openjdk.org Fri Jan 27 14:38:07 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Fri, 27 Jan 2023 14:38:07 GMT Subject: [jdk8u-dev] RFR: 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig Message-ID: The issues is reproduced only with OpenJDK. Oracle 1.8.0_351 does not throw the NPE. OpenJDK 8u built from sources with custom fontconfig.properties file throws NPE `at sun.awt.FcFontManager.getDefaultPlatformFont(FcFontManager.java:76)` on Linux where fontconfig is not installed. The fix allows to return a default font info from FcFontManager.getDefaultPlatformFont() method even FontConfigManager.getFontConfigFonts() returns null. The issue has been already fixed in JDK 11 as part of the fix `8191522: Remove Bigelow&Holmes Lucida fonts from JDK sources` https://github.com/openjdk/jdk/commit/9a9dad8b63e6234829132d5557fbd412d295bb26 This is a backport of only small part of the fix `8191522` related to NPE in FcFontManager.getDefaultPlatformFont() method. Steps to reproduce: - Build jdk8u from sources: https://github.com/openjdk/jdk8u-dev/ - Copy custom [fontconfig.properties](https://bugs.openjdk.org/secure/attachment/102432/fontconfig.properties) file to build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib - Run docker with ubuntu 20.04, install dejavu fonts, and freetype (do not install fontconfig) docker run -it ubuntu:20.04 bash apt update apt install -y fonts-dejavu apt install -y libfreetype6 - Run HelloImage java sample in the docker with the build jdk import javax.imageio.ImageIO; import java.awt.*; import java.awt.image.BufferedImage; import java.io.File; public class HelloImage { public static void main(String[] args) throws Exception { BufferedImage buff = new BufferedImage(300, 200, BufferedImage.TYPE_INT_RGB); Graphics2D g = buff.createGraphics(); g.setColor(Color.WHITE); g.fillRect(0, 0, buff.getWidth(), buff.getHeight()); g.setColor(Color.BLUE); g.setFont(g.getFont().deriveFont(32f)); g.drawString("Hello, Image!", 50, 50); g.dispose(); File file = new File("hello-image.png"); ImageIO.write(buff, "png", file); } } build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac HelloImage.java build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/java HelloImage Exception in thread "main" java.lang.NullPointerException at sun.awt.FcFontManager.getDefaultPlatformFont(FcFontManager.java:76) at sun.font.SunFontManager$2.run(SunFontManager.java:443) at java.security.AccessController.doPrivileged(Native Method) at sun.font.SunFontManager.(SunFontManager.java:386) at sun.awt.FcFontManager.(FcFontManager.java:35) at sun.awt.X11FontManager.(X11FontManager.java:57) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at java.lang.Class.newInstance(Class.java:442) at sun.font.FontManagerFactory$1.run(FontManagerFactory.java:83) at java.security.AccessController.doPrivileged(Native Method) at sun.font.FontManagerFactory.getInstance(FontManagerFactory.java:74) at java.awt.Font.getFont2D(Font.java:491) at java.awt.Font.access$000(Font.java:224) at java.awt.Font$FontAccessImpl.getFont2D(Font.java:228) at sun.font.FontUtilities.getFont2D(FontUtilities.java:200) at sun.java2d.SunGraphics2D.checkFontInfo(SunGraphics2D.java:669) at sun.java2d.SunGraphics2D.getFontInfo(SunGraphics2D.java:835) at sun.java2d.pipe.GlyphListPipe.drawString(GlyphListPipe.java:50) at sun.java2d.SunGraphics2D.drawString(SunGraphics2D.java:2933) at HelloImage.main(HelloImage.java:17) ------------- Commit messages: - 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig Changes: https://git.openjdk.org/jdk8u-dev/pull/246/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=246&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301246 Stats: 9 lines in 1 file changed: 2 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/246.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/246/head:pull/246 PR: https://git.openjdk.org/jdk8u-dev/pull/246 From phh at openjdk.org Fri Jan 27 16:41:27 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 27 Jan 2023 16:41:27 GMT Subject: [jdk8u-dev] RFR: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Tue, 17 Jan 2023 08:03:50 GMT, Nagata-Haruhito wrote: >> I would like to backport JDK-8283606 to JDK8u. This fix cannot be applied cleanly. >> - jdk8u contains only 1 test fixed in JDK-8283606 >> (hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java) >> - jdk8u contains 2 tests fixed in JDK-8299383 (backported to jdk11u) >> (langtools/test/tools/javadoc/6964914/TestStdDoclet.java, and >> langtools/test/tools/javadoc/6964914/TestUserDoclet.java) >> - Need to add more tests that are removed in latest version and have same problem. >> (langtools/test/tools/javah/T6893943.java) >> >> I tried to run these tests on Japanese Windows 10, and all tests are passed. >> >> But, I am not a author, so need a sponsor. >> Would you plese review this fix? >> >> Thank you. > > Could someone review this PR? @Nagata-Haruhito, the backport has been approved, please add a "/integrate" comment and I'll sponsor. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/223 From serb at openjdk.org Fri Jan 27 19:40:31 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 19:40:31 GMT Subject: [jdk8u-dev] Integrated: 8293767: AWT test TestSinhalaChar.java has old SCCS markings In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 19:42:09 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [141d5f5d](https://github.com/openjdk/jdk/commit/141d5f5deec488531e410af875c781f4b70490da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 16 Sep 2022 and was reviewed by Iris Clark. > Thanks! This pull request has now been integrated. Changeset: 8192d03b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/8192d03b0fad34f745addde9408f4aa301dbebef Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8293767: AWT test TestSinhalaChar.java has old SCCS markings Backport-of: 141d5f5deec488531e410af875c781f4b70490da ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/236 From serb at openjdk.org Fri Jan 27 19:44:28 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 19:44:28 GMT Subject: [jdk8u-dev] Integrated: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail In-Reply-To: References: Message-ID: <7ZhLTVp4Fb0GBFbqKhGKtIdstZHCvKQDA9NCozJN5ls=.4c85c96a-550f-44bf-8811-899b8b82aca1@github.com> On Wed, 25 Jan 2023 19:54:44 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a222aedf](https://github.com/openjdk/jdk/commit/a222aedf0fa1961e902db35cbe4145623c6af999) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Rajeev Chamyal on 15 Jun 2016 and was reviewed by Alexander Scherbatiy. > Thanks! This pull request has now been integrated. Changeset: c3c871ee Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/c3c871eeb1767ad68c26cdf4473cf354149b492a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail Backport-of: a222aedf0fa1961e902db35cbe4145623c6af999 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/237 From serb at openjdk.org Fri Jan 27 19:51:28 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 19:51:28 GMT Subject: [jdk8u-dev] Integrated: 8196467: javax/swing/JInternalFrame/Test6325652.java fails In-Reply-To: References: Message-ID: <1q1-1YSUGR-0YjKtXnSYt0AIx5FLzShMxM_tbBgb7o4=.8ffff96d-bb58-4433-90cb-a1dfc3618650@github.com> On Wed, 25 Jan 2023 21:37:32 GMT, Sergey Bylokhov wrote: > The fix for a test issue. This pull request has now been integrated. Changeset: 5274069b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/5274069b5258c91cf258f3554a6c131775ec99c6 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8196467: javax/swing/JInternalFrame/Test6325652.java fails Backport-of: be762d7ac85910bffd7fd8e91e04d81961c35966 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/238 From serb at openjdk.org Fri Jan 27 20:12:26 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 20:12:26 GMT Subject: [jdk8u-dev] Integrated: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 22:05:12 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cd8cd68e](https://github.com/openjdk/jdk/commit/cd8cd68e09370fbf0c3509deaee381417dd12533) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Prasanta Sadhukhan on 28 Feb 2017 and was reviewed by Sergey Bylokhov and Alexander Scherbatiy. > Thanks! This pull request has now been integrated. Changeset: 92c9aed6 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/92c9aed66cde03c3b4f3188b2ec64ea531316bbd Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java Backport-of: cd8cd68e09370fbf0c3509deaee381417dd12533 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/239 From serb at openjdk.org Fri Jan 27 20:18:26 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 20:18:26 GMT Subject: [jdk8u-dev] Integrated: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 23:00:08 GMT, Sergey Bylokhov wrote: > I backport this for parity with 8u361. This pull request has now been integrated. Changeset: 85050ef8 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/85050ef8db4209158e6bb37628eae326dbdcac20 Stats: 58 lines in 1 file changed: 13 ins; 37 del; 8 mod 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Backport-of: 22b7295e75d3bc7ba2c2cd7b871bb2bb5bf290eb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/241 From serb at openjdk.org Fri Jan 27 20:20:29 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 20:20:29 GMT Subject: [jdk8u-dev] Integrated: 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows In-Reply-To: References: Message-ID: On Wed, 25 Jan 2023 23:26:32 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [b5769155](https://github.com/openjdk/jdk/commit/b5769155b4bf453d65c43921dbcae4d115f17df7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Phil Race on 20 Jun 2014 and was reviewed by Jennifer Godinez. > Thanks! This pull request has now been integrated. Changeset: dd8dd7b2 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/dd8dd7b20846d18865cdfb3e26c15c8f153b1a09 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows Backport-of: b5769155b4bf453d65c43921dbcae4d115f17df7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/242 From serb at openjdk.org Fri Jan 27 20:24:28 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 20:24:28 GMT Subject: [jdk8u-dev] Integrated: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual In-Reply-To: References: Message-ID: On Thu, 26 Jan 2023 00:10:38 GMT, Sergey Bylokhov wrote: > The fix for a test bug. This pull request has now been integrated. Changeset: 456d7aca Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/456d7aca8cc4ccc7fe9330bca92dda0b4ba0d8c0 Stats: 156 lines in 1 file changed: 105 ins; 25 del; 26 mod 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual Backport-of: 7cc3ba5f9b188e5dd298dbcde3934d08b6101032 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/243 From serb at openjdk.org Fri Jan 27 20:28:24 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Jan 2023 20:28:24 GMT Subject: [jdk8u-dev] Integrated: 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error In-Reply-To: References: Message-ID: On Thu, 26 Jan 2023 17:23:08 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [b0fddb9f](https://github.com/openjdk/jdk/commit/b0fddb9f8045cca10b4e757d8d187af7fb117405) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Manajit Halder on 29 Jan 2016 and was reviewed by Ambarish Rapte and Semyon Sadetsky. > Thanks! This pull request has now been integrated. Changeset: f1426189 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/f14261896825ca5aa14099576a10183f4476508d Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error Backport-of: b0fddb9f8045cca10b4e757d8d187af7fb117405 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/245 From andrew at openjdk.org Fri Jan 27 22:07:24 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 27 Jan 2023 22:07:24 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> Message-ID: <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> On Fri, 27 Jan 2023 09:23:27 GMT, Severin Gehwolf wrote: >> Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. >> >> Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller > > Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f I think it should be `Files.writeString(a, b) => Files.write(a, b.getBytes(StandardCharsets.UTF_8))` rather than `Files.writeString(a, b) => Files.write(a, b.getBytes())`. `Files.writeString(a,b)` is a shorthand for `Files.writeString(a, b, StandardCharsets.UTF_8)`, while `getBytes()` with [no arguments](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--) will use the platform default character set. This could lead to different behaviour with the default character set is not ASCII or UTF-8. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From andrew at openjdk.org Fri Jan 27 22:19:23 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 27 Jan 2023 22:19:23 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v3] In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 09:31:08 GMT, Severin Gehwolf wrote: >> Clean backport. Only path differences. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete > > Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 Confirmed clean and approved. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/219 From serb at openjdk.org Sat Jan 28 03:46:07 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 28 Jan 2023 03:46:07 GMT Subject: [jdk8u-dev] RFR: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos Message-ID: Backport to fix a test bug. ------------- Commit messages: - Backport a5b42ec8b29249814dda28e751ee363869e98da0 Changes: https://git.openjdk.org/jdk8u-dev/pull/247/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=247&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8233570 Stats: 38 lines in 1 file changed: 14 ins; 3 del; 21 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/247.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/247/head:pull/247 PR: https://git.openjdk.org/jdk8u-dev/pull/247 From serb at openjdk.org Sat Jan 28 03:46:10 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 28 Jan 2023 03:46:10 GMT Subject: [jdk8u-dev] RFR: 8280048: Missing comma in copyright header Message-ID: Hi all, This pull request contains a backport of commit [9a18190a](https://github.com/openjdk/jdk/commit/9a18190a4f8e31801d1442d97f247f074a3fd5c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mikael Vidstedt on 15 Jan 2022 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 9a18190a4f8e31801d1442d97f247f074a3fd5c0 Changes: https://git.openjdk.org/jdk8u-dev/pull/248/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=248&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280048 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/248.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/248/head:pull/248 PR: https://git.openjdk.org/jdk8u-dev/pull/248 From serb at openjdk.org Sat Jan 28 23:01:02 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 28 Jan 2023 23:01:02 GMT Subject: [jdk8u-dev] RFR: 8156581: Cleanup of ProblemList.txt Message-ID: <-oySz4WZqckE_MXDlpzvC-IQyXRUMhJOm7VCb6CET-0=.dc0c2469-9c7a-4833-864e-2062806a6149@github.com> This is a request to backport two updates to the ProblemList.txt. Backport of the [JDK-8156581](https://github.com/openjdk/jdk/commit/65713ca08e5fde04a22b25314976ca364916d409): * The [JDK-8060027](https://bugs.openjdk.org/browse/JDK-8060027) was backported to the JDK8, so the beans tests now work fine. * The [JDK-8059743](https://bugs.openjdk.org/browse/JDK-8059743) was JDK9 specific, so the sound test can be removed from the problem list. Backport of the [JDK-8156579](https://github.com/openjdk/jdk/commit/a279dc035c2c9142928974c8d7bbc02d6092e5ab) * That bug was JDK9 specific, so the tests can be removed from the problem list. ------------- Commit messages: - Backport 65713ca08e5fde04a22b25314976ca364916d409 Changes: https://git.openjdk.org/jdk8u-dev/pull/250/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=250&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8156581 Stats: 9 lines in 1 file changed: 0 ins; 9 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/250.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/250/head:pull/250 PR: https://git.openjdk.org/jdk8u-dev/pull/250 From serb at openjdk.org Sun Jan 29 03:33:59 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 29 Jan 2023 03:33:59 GMT Subject: [jdk8u-dev] RFR: 8177560: @headful key can be removed from the tests for JavaSound Message-ID: Hi all, This pull request contains a backport of commit [0b9c38fa](https://github.com/openjdk/jdk/commit/0b9c38fa6ec2a64d00d244cbe161feb29963ab11) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 31 Mar 2017 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 0b9c38fa6ec2a64d00d244cbe161feb29963ab11 Changes: https://git.openjdk.org/jdk8u-dev/pull/251/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=251&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8177560 Stats: 82 lines in 9 files changed: 41 ins; 13 del; 28 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/251.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/251/head:pull/251 PR: https://git.openjdk.org/jdk8u-dev/pull/251 From duke at openjdk.org Mon Jan 30 03:22:25 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Mon, 30 Jan 2023 03:22:25 GMT Subject: [jdk8u-dev] Integrated: 8283606: Tests may fail with zh locale on MacOS In-Reply-To: References: Message-ID: On Fri, 6 Jan 2023 11:30:35 GMT, Nagata-Haruhito wrote: > I would like to backport JDK-8283606 to JDK8u. This fix cannot be applied cleanly. > - jdk8u contains only 1 test fixed in JDK-8283606 > (hotspot/test/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java) > - jdk8u contains 2 tests fixed in JDK-8299383 (backported to jdk11u) > (langtools/test/tools/javadoc/6964914/TestStdDoclet.java, and > langtools/test/tools/javadoc/6964914/TestUserDoclet.java) > - Need to add more tests that are removed in latest version and have same problem. > (langtools/test/tools/javah/T6893943.java) > > I tried to run these tests on Japanese Windows 10, and all tests are passed. > > But, I am not a author, so need a sponsor. > Would you plese review this fix? > > Thank you. This pull request has now been integrated. Changeset: ab678bc8 Author: Nagata, Haruhito Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/ab678bc8e8b2c55e01151d8349eb086dfcbc3e44 Stats: 14 lines in 4 files changed: 8 ins; 0 del; 6 mod 8283606: Tests may fail with zh locale on MacOS Reviewed-by: sgehwolf Backport-of: 7d545084f45af44386cb38172fd783f889a8c4e7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/223 From duke at openjdk.org Mon Jan 30 03:22:26 2023 From: duke at openjdk.org (ktakakuri) Date: Mon, 30 Jan 2023 03:22:26 GMT Subject: [jdk8u-dev] Integrated: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 In-Reply-To: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> References: <8fb4-Y_ASOn2L86G1C-7VdXoDgL_LhMXOOttK5Lp5fA=.7d42afdf-94c1-4370-b5e9-d74d3dc06268@github.com> Message-ID: On Thu, 26 Jan 2023 11:37:29 GMT, ktakakuri wrote: > This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11. > The original patch accidentally added "out", but it was removed in JDK-8276623. > This PR backports 8275650 without "out". This pull request has now been integrated. Changeset: b057084f Author: Takakuri Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/b057084f8f44a6f81059ffa960304526c490aaad Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Reviewed-by: phh, sgehwolf Backport-of: 32895ac60949ccceb0a3d25c73ec5e3a00c29593 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/244 From sgehwolf at openjdk.org Mon Jan 30 09:13:28 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 09:13:28 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> Message-ID: On Fri, 27 Jan 2023 22:04:49 GMT, Andrew John Hughes wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller >> >> Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f > > I think it should be `Files.writeString(a, b) => Files.write(a, b.getBytes(StandardCharsets.UTF_8))` rather than `Files.writeString(a, b) => Files.write(a, b.getBytes())`. `Files.writeString(a,b)` is a shorthand for `Files.writeString(a, b, StandardCharsets.UTF_8)`, while `getBytes()` with [no arguments](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--) will use the platform default character set. This could lead to different behaviour with the default character set is not ASCII or UTF-8. Thanks for the review, @gnu-andrew! > I think it should be `Files.writeString(a, b) => Files.write(a, b.getBytes(StandardCharsets.UTF_8))` rather than `Files.writeString(a, b) => Files.write(a, b.getBytes())`. `Files.writeString(a,b)` is a shorthand for `Files.writeString(a, b, StandardCharsets.UTF_8)`, while `getBytes()` with [no arguments](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--) will use the platform default character set. This could lead to different behaviour with the default character set is not ASCII or UTF-8. That makes sense to me. However, it makes more sense to do this cleanup as a separate bug. We have a lot of code using this pattern with the cgroups v2 backport. I've filed https://bugs.openjdk.org/browse/JDK-8301332 and will post for review shortly. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Mon Jan 30 10:17:23 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 10:17:23 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> Message-ID: On Mon, 30 Jan 2023 09:10:48 GMT, Severin Gehwolf wrote: > [...] will post for review shortly. Here it is: https://github.com/openjdk/jdk8u-dev/pull/252 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Mon Jan 30 10:20:06 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 10:20:06 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport Message-ID: Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. Testing: - [x] Tests compile, run and pass (as before) Thoughts? ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/218 Commit messages: - 8301332: [8u] Fix writing of test files after the cgroups v2 backport Changes: https://git.openjdk.org/jdk8u-dev/pull/252/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=252&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301332 Stats: 50 lines in 3 files changed: 0 ins; 0 del; 50 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/252/head:pull/252 PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 10:29:27 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 10:29:27 GMT Subject: [jdk8u-dev] RFR: 8156581: Cleanup of ProblemList.txt In-Reply-To: <-oySz4WZqckE_MXDlpzvC-IQyXRUMhJOm7VCb6CET-0=.dc0c2469-9c7a-4833-864e-2062806a6149@github.com> References: <-oySz4WZqckE_MXDlpzvC-IQyXRUMhJOm7VCb6CET-0=.dc0c2469-9c7a-4833-864e-2062806a6149@github.com> Message-ID: On Sat, 28 Jan 2023 21:50:13 GMT, Sergey Bylokhov wrote: > This is a request to backport two updates to the ProblemList.txt. > Backport of the [JDK-8156581](https://github.com/openjdk/jdk/commit/65713ca08e5fde04a22b25314976ca364916d409): > * The [JDK-8060027](https://bugs.openjdk.org/browse/JDK-8060027) was backported to the JDK8, so the beans tests now work fine. > * The [JDK-8059743](https://bugs.openjdk.org/browse/JDK-8059743) was JDK9 specific, so the sound test can be removed from the problem list. > > Backport of the [JDK-8156579](https://github.com/openjdk/jdk/commit/a279dc035c2c9142928974c8d7bbc02d6092e5ab) > * That bug was JDK9 specific, so the tests can be removed from the problem list. Seems fine. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/250 From andrew at openjdk.org Mon Jan 30 15:50:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 30 Jan 2023 15:50:29 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> Message-ID: <2zkvjO0uQ9jihMXsKH38J8lLOxwjwuT-w2l8ZGF90lM=.a6bc80db-8aac-44d8-b2d8-822fd7d49d25@github.com> On Fri, 27 Jan 2023 09:23:27 GMT, Severin Gehwolf wrote: >> Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. >> >> Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller > > Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f `getBytes()` issue confirmed fixed with other cases in follow-up fix #252 ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/218 From andrew at openjdk.org Mon Jan 30 15:50:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 30 Jan 2023 15:50:30 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> <_joqd4hkznxH-eVTNvxxiR797LV6b5aDM8eyFI5MCxc=.72f58093-47c3-4754-8615-c29efe223d38@github.com> Message-ID: <_DCFoxZCvV29Nw4zHokz0rlvuRc8RufshbGB1HSHgt8=.ae219f9b-f8f7-4179-bc75-ae605fa58e5d@github.com> On Fri, 27 Jan 2023 22:04:49 GMT, Andrew John Hughes wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller >> >> Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f > > I think it should be `Files.writeString(a, b) => Files.write(a, b.getBytes(StandardCharsets.UTF_8))` rather than `Files.writeString(a, b) => Files.write(a, b.getBytes())`. `Files.writeString(a,b)` is a shorthand for `Files.writeString(a, b, StandardCharsets.UTF_8)`, while `getBytes()` with [no arguments](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--) will use the platform default character set. This could lead to different behaviour with the default character set is not ASCII or UTF-8. > Thanks for the review, @gnu-andrew! > > > I think it should be `Files.writeString(a, b) => Files.write(a, b.getBytes(StandardCharsets.UTF_8))` rather than `Files.writeString(a, b) => Files.write(a, b.getBytes())`. `Files.writeString(a,b)` is a shorthand for `Files.writeString(a, b, StandardCharsets.UTF_8)`, while `getBytes()` with [no arguments](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--) will use the platform default character set. This could lead to different behaviour with the default character set is not ASCII or UTF-8. > > That makes sense to me. However, it makes more sense to do this cleanup as a separate bug. We have a lot of code using this pattern with the cgroups v2 backport. I've filed https://bugs.openjdk.org/browse/JDK-8301332 and will post for review shortly. I agree a cleanup bug is the right way in this situation. I hadn't seen this pattern in earlier backports. Thanks for the quick bug and PR for that. No issue for me with this one as is. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From andrew at openjdk.org Mon Jan 30 15:54:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 30 Jan 2023 15:54:30 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport In-Reply-To: References: Message-ID: On Mon, 30 Jan 2023 10:11:11 GMT, Severin Gehwolf wrote: > Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. > > Testing: > - [x] Tests compile, run and pass (as before) > > Thoughts? Thanks for fixing these cases. I know it's likely low risk, but I have also seen cases in the past where the fix has to be to make the character set or language explicit, and these are the kind of issues you don't see until someone runs the test with an unusual default character set. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 16:02:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:02:25 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport In-Reply-To: References: Message-ID: On Mon, 30 Jan 2023 10:11:11 GMT, Severin Gehwolf wrote: > Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. > > Testing: > - [x] Tests compile, run and pass (as before) > > Thoughts? Thanks for the review and approval! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 16:02:32 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:02:32 GMT Subject: [jdk8u-dev] RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller [v2] In-Reply-To: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> References: <-AaxaXl49b23eXtxwCFy-myT4zV3xgmUZm1idBxTieA=.a90112b4-7bbf-41de-8ae5-646a4bd56dc1@github.com> Message-ID: On Fri, 27 Jan 2023 09:23:27 GMT, Severin Gehwolf wrote: >> Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. >> >> Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller > > Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Mon Jan 30 16:02:33 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:02:33 GMT Subject: [jdk8u-dev] Integrated: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:01:35 GMT, Severin Gehwolf wrote: > Not a clean backport due to changes in test - `Files.writeString(a, b)` => `Files.write(a, b.getBytes())` - and some copyright and `@bug` lines. Fixed manually. > > Testing: Linux x86_64 fastdebug (reg-test fails prior and passes after product fix). This pull request has now been integrated. Changeset: 36f6f17a Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/36f6f17a9c2ad27a50159c2bf93b7e1fe067d3a8 Stats: 117 lines in 3 files changed: 113 ins; 0 del; 4 mod 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller Reviewed-by: phh, andrew Backport-of: 704b9a66bba0dc8adb62be80fd62864b9c687c3f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/218 From sgehwolf at openjdk.org Mon Jan 30 16:07:53 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:07:53 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport [v2] In-Reply-To: References: Message-ID: > Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. > > Testing: > - [x] Tests compile, run and pass (as before) > > Thoughts? Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/252/files - new: https://git.openjdk.org/jdk8u-dev/pull/252/files/af674227..af674227 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=252&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=252&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/252/head:pull/252 PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 16:20:12 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:20:12 GMT Subject: [jdk8u-dev] RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v4] In-Reply-To: References: Message-ID: <0Tv9YNWBOmi1Her47jvpcoABLhyR8LDThQaFFmEhfWg=.b177ca43-b590-4014-87af-2fc0f1eb323e@github.com> > Clean backport. Only path differences. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/219/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=219&range=03 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/219.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/219/head:pull/219 PR: https://git.openjdk.org/jdk8u-dev/pull/219 From sgehwolf at openjdk.org Mon Jan 30 16:58:30 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 16:58:30 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport [v3] In-Reply-To: References: Message-ID: <7FgTueWloAELIArdI6DkFdaDX1cp1NFxF4RMZqhSNYY=.867453ba-0c00-4d4d-a1ed-1fc25ce64f6d@github.com> > Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. > > Testing: > - [x] Tests compile, run and pass (as before) > > Thoughts? Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: 8301332: [8u] Fix writing of test files after the cgroups v2 backport ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/252/files - new: https://git.openjdk.org/jdk8u-dev/pull/252/files/af674227..fbaeeb80 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=252&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=252&range=01-02 Stats: 248 lines in 14 files changed: 134 ins; 65 del; 49 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/252/head:pull/252 PR: https://git.openjdk.org/jdk8u-dev/pull/252 From andrew at openjdk.org Mon Jan 30 17:02:25 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 30 Jan 2023 17:02:25 GMT Subject: [jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport [v3] In-Reply-To: <7FgTueWloAELIArdI6DkFdaDX1cp1NFxF4RMZqhSNYY=.867453ba-0c00-4d4d-a1ed-1fc25ce64f6d@github.com> References: <7FgTueWloAELIArdI6DkFdaDX1cp1NFxF4RMZqhSNYY=.867453ba-0c00-4d4d-a1ed-1fc25ce64f6d@github.com> Message-ID: On Mon, 30 Jan 2023 16:58:30 GMT, Severin Gehwolf wrote: >> Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. >> >> Testing: >> - [x] Tests compile, run and pass (as before) >> >> Thoughts? > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8301332: [8u] Fix writing of test files after the cgroups v2 backport Marked as reviewed by andrew (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 17:16:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 17:16:25 GMT Subject: [jdk8u-dev] Integrated: 8301332: [8u] Fix writing of test files after the cgroups v2 backport In-Reply-To: References: Message-ID: On Mon, 30 Jan 2023 10:11:11 GMT, Severin Gehwolf wrote: > Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())` to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway. > > Testing: > - [x] Tests compile, run and pass (as before) > > Thoughts? This pull request has now been integrated. Changeset: b4ee9f86 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/b4ee9f86a159a3b1969b31e1e77f438b8833cc40 Stats: 50 lines in 3 files changed: 0 ins; 0 del; 50 mod 8301332: [8u] Fix writing of test files after the cgroups v2 backport Reviewed-by: andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/252 From sgehwolf at openjdk.org Mon Jan 30 17:19:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 30 Jan 2023 17:19:25 GMT Subject: [jdk8u-dev] Integrated: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 18:20:47 GMT, Severin Gehwolf wrote: > Clean backport. Only path differences. This pull request has now been integrated. Changeset: 563f7b5d Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/563f7b5df2f5758e009a38ae373dbd1084ec81b2 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/219 From serb at openjdk.org Mon Jan 30 19:11:16 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 30 Jan 2023 19:11:16 GMT Subject: [jdk8u-dev] Integrated: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 22:37:13 GMT, Sergey Bylokhov wrote: > Backport to fix a test bug. This pull request has now been integrated. Changeset: 604e5829 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/604e582943f1aa66cce34c2baa0f5516d2d69162 Stats: 38 lines in 1 file changed: 14 ins; 3 del; 21 mod 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos Backport-of: a5b42ec8b29249814dda28e751ee363869e98da0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/247 From serb at openjdk.org Mon Jan 30 19:17:49 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 30 Jan 2023 19:17:49 GMT Subject: [jdk8u-dev] Integrated: 8280048: Missing comma in copyright header In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 23:15:23 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [9a18190a](https://github.com/openjdk/jdk/commit/9a18190a4f8e31801d1442d97f247f074a3fd5c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Mikael Vidstedt on 15 Jan 2022 and was reviewed by Phil Race. > Thanks! This pull request has now been integrated. Changeset: 65b3bd91 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/65b3bd9162c7cd03c7348b45c24e57c8f0087a10 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8280048: Missing comma in copyright header Backport-of: 9a18190a4f8e31801d1442d97f247f074a3fd5c0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/248 From serb at openjdk.org Mon Jan 30 19:21:58 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 30 Jan 2023 19:21:58 GMT Subject: [jdk8u-dev] Integrated: 8177560: @headful key can be removed from the tests for JavaSound In-Reply-To: References: Message-ID: On Sun, 29 Jan 2023 02:04:52 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [0b9c38fa](https://github.com/openjdk/jdk/commit/0b9c38fa6ec2a64d00d244cbe161feb29963ab11) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 31 Mar 2017 and was reviewed by Phil Race. > Thanks! This pull request has now been integrated. Changeset: 165ce6aa Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/165ce6aa0bab08e9fbad3ac2495295278d3cf5c6 Stats: 82 lines in 9 files changed: 41 ins; 13 del; 28 mod 8177560: @headful key can be removed from the tests for JavaSound Backport-of: 0b9c38fa6ec2a64d00d244cbe161feb29963ab11 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/251 From phh at openjdk.org Mon Jan 30 20:26:48 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 30 Jan 2023 20:26:48 GMT Subject: [jdk8u-dev] RFR: 8270317: Large Allocation in CipherSuite Message-ID: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> Backport for Oracle parity. Backport from 11u is not clean due to lack of CopyOf in 8u. The nearest equivalents are Collections.unmodifiableMap and Collections.unmodifiableList. Tier1 and all security tests pass, in production at Amazon for over a year without issues. ------------- Commit messages: - Backport e627caec84c169c99c04e0d355c29b806a0266ed Changes: https://git.openjdk.org/jdk8u-dev/pull/253/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=253&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270317 Stats: 94 lines in 1 file changed: 33 ins; 45 del; 16 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/253/head:pull/253 PR: https://git.openjdk.org/jdk8u-dev/pull/253 From gnu.andrew at redhat.com Tue Jan 31 02:27:21 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 31 Jan 2023 02:27:21 +0000 Subject: OpenJDK 8u372-b01 EA Released Message-ID: I've made available an early access source bundle for 8u372, based on the tag jdk8u372-b01: https://openjdk-sources.osci.io/openjdk8/openjdk8u372-b01-ea.tar.xz The tarball is accompanied by a digital signature available at: https://openjdk-sources.osci.io/openjdk8/openjdk8u372-b01-ea.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint: CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: f8fc52937f0bbdc9805d014c866cbb1f058f5d836469712dcc6425172cf5f1bf openjdk8u372-b01-ea.tar.xz 7e43f61559cf7be99e7b334d878bbc3fe0fe56c33108d4c3e78564e682405ed9 openjdk8u372-b01-ea.tar.xz.sig They are listed at https://openjdk-sources.osci.io/openjdk8/openjdk8u372-b01-ea.sha256 The tarball was built on RHEL 6 (x86, x86_64) and RHEL 7 (aarch64, ppc, ppc64, ppc64le, s390x, x86, x86_64) Changes in 8u372-b01: - JDK-6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows - JDK-7001973: java/awt/Graphics2D/CopyAreaOOB.java fails - JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java - JDK-8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows - JDK-8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled - JDK-8072770: [TESTBUG] Some Introspector tests fail with a Java heap bigger than 4GB - JDK-8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error - JDK-8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail - JDK-8196196: Headful tests should not be run in headless mode - JDK-8196467: javax/swing/JInternalFrame/Test6325652.java fails - JDK-8197408: Bad pointer comparison and small cleanup in os_linux.cpp - JDK-8203485: [freetype] text rotated on 180 degrees is too narrow - JDK-8216366: Add rationale to PER_CPU_SHARES define - JDK-8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails - JDK-8228585: jdk/internal/platform/cgroup/TestCgroupMetrics.java - NumberFormatException because of large long values (memory limit_in_bytes) - JDK-8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12 - JDK-8229202: Docker reporting causes secondary crashes in error handling - JDK-8230305: Cgroups v2: Container awareness - JDK-8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy - JDK-8232207: Linux os::available_memory re-reads cgroup configuration on every invocation - JDK-8234484: Add ability to configure third port for remote JMX - JDK-8237479: 8230305 causes slowdebug build failure - JDK-8239559: Cgroups: Incorrect detection logic on some systems - JDK-8239785: Cgroups: Incorrect detection logic on old systems in hotspot - JDK-8239827: The test OpenByUNCPathNameTest.java should be changed to be manual - JDK-8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 - JDK-8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873 - JDK-8242468: VS2019 build missing vcruntime140_1.dll - JDK-8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java - JDK-8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) - JDK-8247676: vcruntime140_1.dll is not needed on 32-bit Windows - JDK-8252359: HotSpot Not Identifying it is Running in a Container - JDK-8252957: Wrong comment in CgroupV1Subsystem::cpu_quota - JDK-8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist - JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high - JDK-8253727: [cgroups v2] Memory and swap limits reported incorrectly - JDK-8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems - JDK-8253939: [TESTBUG] Increase coverage of the cgroups detection code - JDK-8254001: [Metrics] Enhance parsing of cgroup interface files for version detection - JDK-8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards - JDK-8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes - JDK-8257620: Do not use objc_msgSend_stret to get macOS version - JDK-8262379: Add regression test for JDK-8257746 - JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics - JDK-8275713: TestDockerMemoryMetrics test fails on recent runc - JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 - JDK-8282398: EndingDotHostname.java test fails because SSL cert expired - JDK-8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124 - JDK-8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox - JDK-8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem - JDK-8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist - JDK-8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 - JDK-8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun - JDK-8291570: [TESTBUG] Part of JDK-8250984 absent from 11u - JDK-8292083: Detected container memory limit may exceed physical machine memory - JDK-8292541: [Metrics] Reported memory limit may exceed physical machine memory - JDK-8293472: Incorrect container resource limit detection if manual cgroup fs mounts present - JDK-8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts - JDK-8293767: AWT test TestSinhalaChar.java has old SCCS markings - JDK-8294767: 8u contains two copies of test/../FileUtils.java, one uses JDK9+ features - JDK-8295322: Tests for JDK-8271459 were not backported to 11u - JDK-8295952: Problemlist existing compiler/rtm tests also on x86 - JDK-8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process - JDK-8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing - JDK-8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException - JDK-8296496: Overzealous check in sizecalc.h prevents large memory allocation - JDK-8296632: Write a test to verify the content change of TextArea sends TextEvent - JDK-8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 - JDK-8297329: [8u] hotspot needs to recognise VS2019 - JDK-8297739: Bump update version of OpenJDK: 8u372 - JDK-8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's - JDK-8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u - JDK-8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u - JDK-8299804: Fix non-portable code in hotspot shell tests in 8u - JDK-8300014: Some backports placed the tests in the wrong location - JDK-8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems - JDK-8301122: [8u] Fix unreliable vs2010 download link Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From simonis at openjdk.org Tue Jan 31 12:11:11 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 31 Jan 2023 12:11:11 GMT Subject: [jdk8u-dev] RFR: 8270317: Large Allocation in CipherSuite In-Reply-To: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> References: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> Message-ID: <6ETuX2cASQRjvlIEprgCkiA-jZopDTgfR0atQUnTuBo=.5be52fff-6cc3-4a60-9093-f14e946ee3eb@github.com> On Mon, 30 Jan 2023 20:20:16 GMT, Paul Hohensee wrote: > Backport for Oracle parity. Backport from 11u is not clean due to lack of CopyOf in 8u. The nearest equivalents are Collections.unmodifiableMap and Collections.unmodifiableList. Also, there is no jmh archive in 8u, so the performance test is not included. > > Tier1 and all security tests pass, in production at Amazon for over a year without issues. Looks good except for the comment change (which might be a merge artifact?). jdk/src/share/classes/sun/security/ssl/CipherSuite.java line 38: > 36: > 37: /** > 38: * Enum for SSL/(D)TLS cipher suites It doesn't look like the original 11u patch changed this comment so I don't think we need this change in 8. jdk/src/share/classes/sun/security/ssl/CipherSuite.java line 904: > 902: allowedCipherSuites = Collections.unmodifiableList(allowedCS); > 903: defaultCipherSuites = Collections.unmodifiableList(defaultCS); > 904: } Agree that in this case `Collections.unmodifiableMap()`/`Collections.unmodifiableList()` are a good replacement for the missing `copyOf()`. And it should also be faster, because it avoids a copy :) ------------- Marked as reviewed by simonis (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/253 From phh at openjdk.org Tue Jan 31 13:48:34 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 31 Jan 2023 13:48:34 GMT Subject: [jdk8u-dev] RFR: 8270317: Large Allocation in CipherSuite [v2] In-Reply-To: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> References: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> Message-ID: <3WFkE7-YMm7BqQLMs1_yhU-oyfDL-usPwquHuFZ_VYs=.e6ca8155-84fc-4c7f-a234-a60de7f2e7ef@github.com> > Backport for Oracle parity. Backport from 11u is not clean due to lack of CopyOf in 8u. The nearest equivalents are Collections.unmodifiableMap and Collections.unmodifiableList. Also, there is no jmh archive in 8u, so the performance test is not included. > > Tier1 and all security tests pass, in production at Amazon for over a year without issues. Paul Hohensee has updated the pull request incrementally with two additional commits since the last revision: - Remove merge artifact comment change - Remove merge artifact comment change ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/253/files - new: https://git.openjdk.org/jdk8u-dev/pull/253/files/c2debd86..fed5ce43 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=253&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=253&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/253/head:pull/253 PR: https://git.openjdk.org/jdk8u-dev/pull/253 From zzambers at openjdk.org Tue Jan 31 14:39:11 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 31 Jan 2023 14:39:11 GMT Subject: [jdk8u-dev] RFR: 8301550: [8u] Enable additional linux build testing in GitHub Message-ID: Parts of testing in GitHub are currently still disabled as they needed changes to work with JDK 8. This change does fixes for JDK 8 and enables them. Enabled tests include building hotspot in different configurations and also cross building for other architectures. **Notes on modifications:** - `optimized` jvm-variant does not exist on JDK 8, `client` variant tested instead - added support for multilib testing to linux additional (to existing native and cross) as `client` and `minimal` variants are only for 32-bits on JDK 8 - arm and s390x are only available as `zero` variant on JDK 8 so they use this variant (added required libffi to buildroot) - JDK 8 does not support `--with-build-jdk` configuration option (not to be confused with boot jdk), so it was removed as well as code preparing build jdk - dropped dependence of linux additional on linux x64 build (was only needed to get build jdk) - In case of JDK 8, a bit more persuasion was required to successfully configure cross build. Explicit configuration of libs was required. Also *FLAGS env. variables with sysroot had to be set for configuration to succeed, but they must not remain set for build, otherwise it fails. **Testing:** All test passed in Github CI. ------------- Commit messages: - Enable linux additional build Changes: https://git.openjdk.org/jdk8u-dev/pull/254/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=254&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301550 Stats: 63 lines in 1 file changed: 23 ins; 26 del; 14 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/254.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/254/head:pull/254 PR: https://git.openjdk.org/jdk8u-dev/pull/254 From jvanek at openjdk.org Tue Jan 31 16:55:42 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 31 Jan 2023 16:55:42 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows Message-ID: 8287463: JFR: Disable TestDevNull.java on Windows ------------- Commit messages: - 8287463: JFR: Disable TestDevNull.java on Windows - Removed jdk8 incompatible -Xlog:jfr - Avoided usage of jdk11+ Path.of(String) by File(String).toPath - removed @requires vm.hasJFR - Changed test to use @library /lib / - 8282947: JFR: Dump on shutdown live-locks in some conditions Changes: https://git.openjdk.org/jdk8u-dev/pull/255/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=255&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287463 Stats: 71 lines in 3 files changed: 67 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/255/head:pull/255 PR: https://git.openjdk.org/jdk8u-dev/pull/255 From sgehwolf at openjdk.org Tue Jan 31 17:12:16 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 31 Jan 2023 17:12:16 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: On Tue, 31 Jan 2023 16:40:26 GMT, Ji?? Van?k wrote: > 8287463: JFR: Disable TestDevNull.java on Windows @judovana It's targeting `master` branch, while I think it should target `pr/234`. The effect would be that changes part of #234 don't show up in this PR. See https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/255 From jvanek at openjdk.org Tue Jan 31 17:31:49 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 31 Jan 2023 17:31:49 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v2] In-Reply-To: References: Message-ID: <9l4qMcV3ZZKL85-DEmlr4NkZg9Ydklv8P3XPb4jQ0s4=.ae6028d0-31c2-4571-9c1b-6fa374fcee06@github.com> > 8287463: JFR: Disable TestDevNull.java on Windows Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/255/files - new: https://git.openjdk.org/jdk8u-dev/pull/255/files/344ebe5e..344ebe5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=255&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=255&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/255/head:pull/255 PR: https://git.openjdk.org/jdk8u-dev/pull/255 From jvanek at openjdk.org Tue Jan 31 17:32:00 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 31 Jan 2023 17:32:00 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: References: Message-ID: <8l0X_kVSz8Zi3H4FTI_Ami7-mYnJobq8-Jc6vT7nHE8=.33806314-0c2d-41a7-bb20-36ea31cd7b8c@github.com> On Tue, 31 Jan 2023 16:40:26 GMT, Ji?? Van?k wrote: > 8287463: JFR: Disable TestDevNull.java on Windows Thanx a lot for sharing the link. Updated ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/255 From sgehwolf at openjdk.org Tue Jan 31 18:32:46 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 31 Jan 2023 18:32:46 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v2] In-Reply-To: <9l4qMcV3ZZKL85-DEmlr4NkZg9Ydklv8P3XPb4jQ0s4=.ae6028d0-31c2-4571-9c1b-6fa374fcee06@github.com> References: <9l4qMcV3ZZKL85-DEmlr4NkZg9Ydklv8P3XPb4jQ0s4=.ae6028d0-31c2-4571-9c1b-6fa374fcee06@github.com> Message-ID: On Tue, 31 Jan 2023 17:31:49 GMT, Ji?? Van?k wrote: >> 8287463: JFR: Disable TestDevNull.java on Windows > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/255 From zzambers at openjdk.org Tue Jan 31 18:49:54 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 31 Jan 2023 18:49:54 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: <8l0X_kVSz8Zi3H4FTI_Ami7-mYnJobq8-Jc6vT7nHE8=.33806314-0c2d-41a7-bb20-36ea31cd7b8c@github.com> References: <8l0X_kVSz8Zi3H4FTI_Ami7-mYnJobq8-Jc6vT7nHE8=.33806314-0c2d-41a7-bb20-36ea31cd7b8c@github.com> Message-ID: On Tue, 31 Jan 2023 17:20:20 GMT, Ji?? Van?k wrote: >> 8287463: JFR: Disable TestDevNull.java on Windows > > Thanx a lot for sharing the link. Updated @judovana btw. this can also be done by Platform class (from test library): https://github.com/openjdk/jdk8u-dev/blob/165ce6aa0bab08e9fbad3ac2495295278d3cf5c6/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java#L44 e.g.: https://github.com/openjdk/jdk8u-dev/blob/7d3c0bede34930cadd76644e58bf56f2a83c3d01/hotspot/test/runtime/memory/ReadFromNoaccessArea.java#L62 but probably does not matter here (Platform class literally does the same thing :) ) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/255 From jvanek at openjdk.org Tue Jan 31 19:45:55 2023 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 31 Jan 2023 19:45:55 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows In-Reply-To: <8l0X_kVSz8Zi3H4FTI_Ami7-mYnJobq8-Jc6vT7nHE8=.33806314-0c2d-41a7-bb20-36ea31cd7b8c@github.com> References: <8l0X_kVSz8Zi3H4FTI_Ami7-mYnJobq8-Jc6vT7nHE8=.33806314-0c2d-41a7-bb20-36ea31cd7b8c@github.com> Message-ID: On Tue, 31 Jan 2023 17:20:20 GMT, Ji?? Van?k wrote: >> 8287463: JFR: Disable TestDevNull.java on Windows > > Thanx a lot for sharing the link. Updated > @judovana btw. this can also be done by Platform class (from test library): > > https://github.com/openjdk/jdk8u-dev/blob/165ce6aa0bab08e9fbad3ac2495295278d3cf5c6/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java#L44 > > e.g.: > > https://github.com/openjdk/jdk8u-dev/blob/7d3c0bede34930cadd76644e58bf56f2a83c3d01/hotspot/test/runtime/memory/ReadFromNoaccessArea.java#L62 > > but probably does not matter here (Platform class literally does the same thing :) ) I will humbly stay library-less. It had bittenme a bit in the https://github.com/openjdk/jdk8u-dev/pull/235 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/255 From serb at openjdk.org Tue Jan 31 20:36:56 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 31 Jan 2023 20:36:56 GMT Subject: [jdk8u-dev] RFR: 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig In-Reply-To: References: Message-ID: On Fri, 27 Jan 2023 14:33:36 GMT, Alexander Scherbatiy wrote: > The issues is reproduced only with OpenJDK. Oracle 1.8.0_351 does not throw the NPE. > > OpenJDK 8u built from sources with custom fontconfig.properties file throws NPE > `at sun.awt.FcFontManager.getDefaultPlatformFont(FcFontManager.java:76)` > on Linux where fontconfig is not installed. > > The fix allows to return a default font info from FcFontManager.getDefaultPlatformFont() method even FontConfigManager.getFontConfigFonts() returns null. > > The issue has been already fixed in JDK 11 as part of the fix `8191522: Remove Bigelow&Holmes Lucida fonts from JDK sources` https://github.com/openjdk/jdk/commit/9a9dad8b63e6234829132d5557fbd412d295bb26 > > This is a backport of only small part of the fix `8191522` related to NPE in FcFontManager.getDefaultPlatformFont() method. > > Steps to reproduce: > - Build jdk8u from sources: https://github.com/openjdk/jdk8u-dev/ > - Copy custom [fontconfig.properties](https://bugs.openjdk.org/secure/attachment/102432/fontconfig.properties) file to build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib directory > - Run docker with ubuntu 20.04, install dejavu fonts, and freetype (do not install fontconfig) > > docker run -it ubuntu:20.04 bash > apt update > apt install -y fonts-dejavu > apt install -y libfreetype6 > > - Run HelloImage java sample in the docker with the built jdk > > import javax.imageio.ImageIO; > import java.awt.*; > import java.awt.image.BufferedImage; > import java.io.File; > > public class HelloImage { > > public static void main(String[] args) throws Exception { > > BufferedImage buff = new BufferedImage(300, 200, BufferedImage.TYPE_INT_RGB); > Graphics2D g = buff.createGraphics(); > g.setColor(Color.WHITE); > g.fillRect(0, 0, buff.getWidth(), buff.getHeight()); > > g.setColor(Color.BLUE); > g.setFont(g.getFont().deriveFont(32f)); > g.drawString("Hello, Image!", 50, 50); > g.dispose(); > > File file = new File("hello-image.png"); > ImageIO.write(buff, "png", file); > } > } > > > > build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac HelloImage.java > build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/java HelloImage > Exception in thread "main" java.lang.NullPointerException > at sun.awt.FcFontManager.getDefaultPlatformFont(FcFontManager.java:76) > at sun.font.SunFontManager$2.run(SunFontManager.java:443) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.SunFontManager.(SunFontManager.java:386) > at sun.awt.FcFontManager.(FcFontManager.java:35) > at sun.awt.X11FontManager.(X11FontManager.java:57) > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:423) > at java.lang.Class.newInstance(Class.java:442) > at sun.font.FontManagerFactory$1.run(FontManagerFactory.java:83) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerFactory.getInstance(FontManagerFactory.java:74) > at java.awt.Font.getFont2D(Font.java:491) > at java.awt.Font.access$000(Font.java:224) > at java.awt.Font$FontAccessImpl.getFont2D(Font.java:228) > at sun.font.FontUtilities.getFont2D(FontUtilities.java:200) > at sun.java2d.SunGraphics2D.checkFontInfo(SunGraphics2D.java:669) > at sun.java2d.SunGraphics2D.getFontInfo(SunGraphics2D.java:835) > at sun.java2d.pipe.GlyphListPipe.drawString(GlyphListPipe.java:50) > at sun.java2d.SunGraphics2D.drawString(SunGraphics2D.java:2933) > at HelloImage.main(HelloImage.java:17) Marked as reviewed by serb (Reviewer). I can reproduce the bug described above using the steps to reproduce and jdk8u. The change fixed the problem. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/246 From sgehwolf at openjdk.org Tue Jan 31 20:43:54 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 31 Jan 2023 20:43:54 GMT Subject: [jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v2] In-Reply-To: <9l4qMcV3ZZKL85-DEmlr4NkZg9Ydklv8P3XPb4jQ0s4=.ae6028d0-31c2-4571-9c1b-6fa374fcee06@github.com> References: <9l4qMcV3ZZKL85-DEmlr4NkZg9Ydklv8P3XPb4jQ0s4=.ae6028d0-31c2-4571-9c1b-6fa374fcee06@github.com> Message-ID: On Tue, 31 Jan 2023 17:31:49 GMT, Ji?? Van?k wrote: >> 8287463: JFR: Disable TestDevNull.java on Windows > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Right. I forgot about `Platform`. Yes, please use it. If we need to change how windows is being detected we only need to change one place not many. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/255