[jdk8u-dev] Integrated: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u

zzambers duke at openjdk.org
Mon Jan 9 16:17:58 UTC 2023


On Tue, 3 Jan 2023 16:14:11 GMT, zzambers <duke at openjdk.org> wrote:

> It was discovered [1] that following test is always skipped in 8u:
> `hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java`
> 
> Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that:
> `@requires vm.bits == "64"`
> 
> However `vm.bits` is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems.
> 
> **Fix:**
> Fixed by doing explicit check in test instead of using jtreg tag.
> 
> **Testing:**
> Tested using github actions as test is part of hotspot/tier1.
> 
> [1] https://github.com/openjdk/jdk8u-dev/pull/182#discussion_r1024395333
> [2] https://bugs.openjdk.org/browse/JDK-8087291

This pull request has now been integrated.

Changeset: 0f698dae
Author:    Zdenek Zambersky <zzambers at redhat.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0f698dae3bfee354de3c9bea32f881b4d7d5c73e
Stats:     6 lines in 1 file changed: 5 ins; 1 del; 0 mod

8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u

Reviewed-by: phh

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/222


More information about the jdk8u-dev mailing list