[jdk8u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts

Mon Jan 16 15:14:17 UTC 2023

On Tue, 3 Jan 2023 12:32:05 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> This is a backport of 8293540 to jdk8u-dev for cgroups v2 support.
> 
> Unclean: new test (TestDockerBasic.java) needed adjustments for the 8u test library paths and available methods.

One test related issue, looks good otherwise.

jdk/test/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 368:

> 366:         assertEquals("/", cpuSetInfo.getMountRoot());
> 367:         // Ensure controllers at /sys/fs/cgroup will be used
> 368:         String[] ctrlNames = new String[] { "memory", "cpu", "cpuacct", "blkio", "pids" };

The `pids` controller is not present in 8u ([JDK-8266490](https://bugs.openjdk.org/browse/JDK-8266490)). This results in a test failure (NPE). Please remove it.

-------------

Changes requested by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/221