[jdk8u-dev] RFR: 8301332: [8u] Fix writing of test files after the cgroups v2 backport

Andrew John Hughes andrew at openjdk.org
Mon Jan 30 15:54:30 UTC 2023


On Mon, 30 Jan 2023 10:11:11 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this trivial refactoring of test files. It fixes usages of `Files.write(..., String.getBytes())`  to `Files.write(..., String.getBytes(StandardCharsets.UTF-8))`. Affected files don't contain non-ascii content, but it's a good cleanup to do anyway.
> 
> Testing:
> - [x] Tests compile, run and pass (as before)
> 
> Thoughts?

Thanks for fixing these cases. I know it's likely low risk, but I have also seen cases in the past where the fix has to be to make the character set or language explicit, and these are the kind of issues you don't see until someone runs the test with an unusual default character set.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/252


More information about the jdk8u-dev mailing list