[jdk8u] RFR: 8241311: Move some charset mapping tests from closed to open
Severin Gehwolf
sgehwolf at openjdk.org
Thu Jun 22 13:55:14 UTC 2023
On Wed, 21 Jun 2023 01:18:23 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
> This is a second pre-requisite for [JDK-8301119](https://bugs.openjdk.org/browse/JDK-8301119) ("Support for GB18030-2022") and so is being proposed for inclusion in 8u382 during rampdown, so that the changes are in place for when GB18030-2022 enforcement begins in August. It adds more tests for character mappings, including GB18030.
>
> The patch only introduces new tests, shuffled to the correct location. The one change to an existing file (`TestCharsetMapping.java`) is dropped, as it only adds an unneeded `@modules` line. Similarly, `@modules` is dropped from `CoderTest.java`, `ConverterTest.java` and `TestConv.java`.
>
> The remaining change is to `MS950.c2b-irreversible`. 8u does not have [JDK-8232161](https://bugs.openjdk.org/browse/JDK-8232161), a change with an associated CSR that changed some of the mappings in the MS950 character set. We removed the four mappings from the test set, so as to match 8u's behaviour and avoid the `CoderTest.java` test from failing.
>
> All `sun.nio.cs` tests pass with this patch applied.
OK.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk8u/pull/44#pullrequestreview-1493251550
More information about the jdk8u-dev
mailing list