[jdk8u] RFR: 8241311: Move some charset mapping tests from closed to open [v3]
Andrew John Hughes
andrew at openjdk.org
Fri Jun 23 10:44:06 UTC 2023
On Fri, 23 Jun 2023 10:14:24 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
>> This is a second pre-requisite for [JDK-8301119](https://bugs.openjdk.org/browse/JDK-8301119) ("Support for GB18030-2022") and so is being proposed for inclusion in 8u382 during rampdown, so that the changes are in place for when GB18030-2022 enforcement begins in August. It adds more tests for character mappings, including GB18030.
>>
>> The patch only introduces new tests, shuffled to the correct location. The one change to an existing file (`TestCharsetMapping.java`) is dropped, as it only adds an unneeded `@modules` line. Similarly, `@modules` is dropped from `CoderTest.java`, `ConverterTest.java` and `TestConv.java`.
>>
>> The remaining change is to `MS950.c2b-irreversible`. 8u does not have [JDK-8232161](https://bugs.openjdk.org/browse/JDK-8232161), a change with an associated CSR that changed some of the mappings in the MS950 character set. We removed the four mappings from the test set, so as to match 8u's behaviour and avoid the `CoderTest.java` test from failing.
>>
>> All `sun.nio.cs` tests pass with this patch applied.
>
> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge remote-tracking branch 'jdk8u/master' into JDK-8241311
> - Backport c809c9944400f7ee9bc296e40d6068273bde5912
> - Backport cfe34ed89c4f6ef9a49dceef30da1e43b418b152
I see `jdk8u-critical-yes` so will integrate when testing of the merge version completes.
-------------
PR Comment: https://git.openjdk.org/jdk8u/pull/44#issuecomment-1604092124
More information about the jdk8u-dev
mailing list